[GitHub] [accumulo] dlmarion commented on issue #3087: Client in endless loop when ZooKeeper unavailable

2023-01-20 Thread via GitHub
dlmarion commented on issue #3087: URL: https://github.com/apache/accumulo/issues/3087#issuecomment-1398788327 Closing for now, can be re-opened if needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [accumulo] dlmarion closed issue #3087: Client in endless loop when ZooKeeper unavailable

2023-01-20 Thread via GitHub
dlmarion closed issue #3087: Client in endless loop when ZooKeeper unavailable URL: https://github.com/apache/accumulo/issues/3087 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [accumulo] dlmarion commented on pull request #3166: rename ScannerOptions timeOut to scanTimeOut, fix possible bug

2023-01-20 Thread via GitHub
dlmarion commented on PR #3166: URL: https://github.com/apache/accumulo/pull/3166#issuecomment-1398803887 Could this be the cause of #2606 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [accumulo] EdColeman commented on pull request #3166: rename ScannerOptions timeOut to scanTimeOut, fix possible bug

2023-01-20 Thread via GitHub
EdColeman commented on PR #3166: URL: https://github.com/apache/accumulo/pull/3166#issuecomment-1398817770 It does not seem to resolve #2606, I ran it with this change and the test still fails. @DomGarguilo noted that the slow iterator is pausing between calls to next which may be different

[GitHub] [accumulo] dlmarion commented on pull request #3166: rename ScannerOptions timeOut to scanTimeOut, fix possible bug

2023-01-20 Thread via GitHub
dlmarion commented on PR #3166: URL: https://github.com/apache/accumulo/pull/3166#issuecomment-1398819178 ok, thx for checking. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [accumulo] EdColeman commented on pull request #3166: rename ScannerOptions timeOut to scanTimeOut, fix possible bug

2023-01-20 Thread via GitHub
EdColeman commented on PR #3166: URL: https://github.com/apache/accumulo/pull/3166#issuecomment-1398893342 30c674cbd8 modifies the ScanServerIT to test scan timeout - may resolve #2606 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [accumulo-proxy] DomGarguilo merged pull request #59: Use single user

2023-01-20 Thread via GitHub
DomGarguilo merged PR #59: URL: https://github.com/apache/accumulo-proxy/pull/59 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr.

[GitHub] [accumulo] dlmarion opened a new pull request, #3167: Reuse ThreadPools where possible instead of recreating each time method is called

2023-01-20 Thread via GitHub
dlmarion opened a new pull request, #3167: URL: https://github.com/apache/accumulo/pull/3167 Closes #3062 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

[GitHub] [accumulo] keith-turner opened a new pull request, #3168: Fixes tablet location cache bug that caused batch scanner to return duplicate data

2023-01-21 Thread via GitHub
keith-turner opened a new pull request, #3168: URL: https://github.com/apache/accumulo/pull/3168 …uplicate data. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [accumulo] cshannon commented on pull request #3136: WIP - remove VFS and only search file system for jars for context classloading

2023-01-21 Thread via GitHub
cshannon commented on PR #3136: URL: https://github.com/apache/accumulo/pull/3136#issuecomment-1399303663 @ctubbsii and @dlmarion - I just pushed a new update and I have significantly reworked the PR. There's still work to be done...comments need updating, some tests still need fixing and t

[GitHub] [accumulo] cshannon commented on issue #608: Garbage Collector removed referenced files

2023-01-21 Thread via GitHub
cshannon commented on issue #608: URL: https://github.com/apache/accumulo/issues/608#issuecomment-1399316343 I investigated this again yesterday and there are still some reports of this same behavior happening against 1.10.x. It's similar behavior where there is missing data returned from t

[GitHub] [accumulo] keith-turner commented on pull request #3164: Fixed bugs found when testing offline scans

2023-01-21 Thread via GitHub
keith-turner commented on PR #3164: URL: https://github.com/apache/accumulo/pull/3164#issuecomment-1399325525 > @keith-turner - you may want to merge this directly to 2.1 That will be a lot cleaner than cherry picking it back and then merging it forward. I am going to do that. -- T

[GitHub] [accumulo] keith-turner merged pull request #3164: Fixed bugs found when testing offline scans

2023-01-21 Thread via GitHub
keith-turner merged PR #3164: URL: https://github.com/apache/accumulo/pull/3164 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr..

[GitHub] [accumulo] keith-turner commented on a diff in pull request #3167: Reuse ThreadPools where possible instead of recreating each time method is called

2023-01-22 Thread via GitHub
keith-turner commented on code in PR #3167: URL: https://github.com/apache/accumulo/pull/3167#discussion_r1083513557 ## server/compaction-coordinator/src/main/java/org/apache/accumulo/coordinator/CompactionCoordinator.java: ## @@ -319,39 +325,38 @@ public void run() { }

[GitHub] [accumulo] keith-turner commented on pull request #3166: rename ScannerOptions timeOut to scanTimeOut, fix possible bug

2023-01-22 Thread via GitHub
keith-turner commented on PR #3166: URL: https://github.com/apache/accumulo/pull/3166#issuecomment-1399573166 > In IsolatedScanner, the two timeouts are confusing and it could be an error that there are two values when one was intended, but I preserved current behavior. @EdColeman c

[GitHub] [accumulo-examples] Manno15 commented on issue #113: Dirlist example throws exceptions during execution

2023-01-22 Thread via GitHub
Manno15 commented on issue #113: URL: https://github.com/apache/accumulo-examples/issues/113#issuecomment-1399592006 After coming back to this, I have been able to reproduce the error. I am still looking for a solution but my guess is the client that was used to create the viewer was close

[GitHub] [accumulo] dlmarion commented on a diff in pull request #3167: Reuse ThreadPools where possible instead of recreating each time method is called

2023-01-23 Thread via GitHub
dlmarion commented on code in PR #3167: URL: https://github.com/apache/accumulo/pull/3167#discussion_r1083988954 ## server/compaction-coordinator/src/main/java/org/apache/accumulo/coordinator/CompactionCoordinator.java: ## @@ -319,39 +325,38 @@ public void run() { }

[GitHub] [accumulo] dlmarion commented on a diff in pull request #3167: Reuse ThreadPools where possible instead of recreating each time method is called

2023-01-23 Thread via GitHub
dlmarion commented on code in PR #3167: URL: https://github.com/apache/accumulo/pull/3167#discussion_r1084006624 ## server/manager/src/main/java/org/apache/accumulo/manager/Manager.java: ## @@ -217,6 +217,8 @@ public class Manager extends AbstractServer private final AtomicBo

[GitHub] [accumulo] dlmarion commented on a diff in pull request #3167: Reuse ThreadPools where possible instead of recreating each time method is called

2023-01-23 Thread via GitHub
dlmarion commented on code in PR #3167: URL: https://github.com/apache/accumulo/pull/3167#discussion_r1084007998 ## server/manager/src/main/java/org/apache/accumulo/manager/Manager.java: ## @@ -1012,16 +1013,19 @@ private SortedMap gatherTableInformation( badServer

[GitHub] [accumulo] dlmarion commented on a diff in pull request #3167: Reuse ThreadPools where possible instead of recreating each time method is called

2023-01-23 Thread via GitHub
dlmarion commented on code in PR #3167: URL: https://github.com/apache/accumulo/pull/3167#discussion_r1084008491 ## server/compaction-coordinator/src/main/java/org/apache/accumulo/coordinator/CompactionCoordinator.java: ## @@ -319,39 +325,38 @@ public void run() { }

[GitHub] [accumulo] dlmarion commented on issue #608: Garbage Collector removed referenced files

2023-01-23 Thread via GitHub
dlmarion commented on issue #608: URL: https://github.com/apache/accumulo/issues/608#issuecomment-1400299506 Another thought is that `LinkingIterator.goodTransition` defaults to returning `true` and only returning `false` under certain conditions. I'm wondering if that should be reversed, d

[GitHub] [accumulo] dlmarion commented on a diff in pull request #3167: Reuse ThreadPools where possible instead of recreating each time method is called

2023-01-23 Thread via GitHub
dlmarion commented on code in PR #3167: URL: https://github.com/apache/accumulo/pull/3167#discussion_r1084006976 ## server/manager/src/main/java/org/apache/accumulo/manager/Manager.java: ## @@ -1251,6 +1258,15 @@ boolean canSuspendTablets() { throw new IllegalStateExcepti

[GitHub] [accumulo] ddanielr opened a new pull request, #3169: Bugfix/check property values backend

2023-01-23 Thread via GitHub
ddanielr opened a new pull request, #3169: URL: https://github.com/apache/accumulo/pull/3169 WIP for tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[GitHub] [accumulo] ddanielr closed pull request #3169: Bugfix/check property values backend

2023-01-23 Thread via GitHub
ddanielr closed pull request #3169: Bugfix/check property values backend URL: https://github.com/apache/accumulo/pull/3169 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [accumulo] EdColeman commented on pull request #3166: rename ScannerOptions timeOut to scanTimeOut, fix possible bug

2023-01-23 Thread via GitHub
EdColeman commented on PR #3166: URL: https://github.com/apache/accumulo/pull/3166#issuecomment-1400652298 @keith-turner Basically there are two timeouts in IsolatedScanner - one is inherited by extending ScannerOptions and the other is local to IsolatedScanner (now named iteratorTimeout in

[GitHub] [accumulo] EdColeman commented on pull request #3166: rename ScannerOptions timeOut to scanTimeOut, fix possible bug

2023-01-23 Thread via GitHub
EdColeman commented on PR #3166: URL: https://github.com/apache/accumulo/pull/3166#issuecomment-1400834950 As @DomGarguilo noted in https://github.com/apache/accumulo/issues/2606 - I'm not sure that the timeouts being tested are actually the scanner timeouts. There seems to be a sensitivit

[GitHub] [accumulo] EdColeman commented on a diff in pull request #3146: Check Prop Value Format and Key types.

2023-01-23 Thread via GitHub
EdColeman commented on code in PR #3146: URL: https://github.com/apache/accumulo/pull/3146#discussion_r1084461119 ## shell/src/main/java/org/apache/accumulo/shell/commands/ConfigCommand.java: ## @@ -353,6 +344,31 @@ public int execute(final String fullCommand, final CommandLine

[GitHub] [accumulo] EdColeman commented on a diff in pull request #3146: Check Prop Value Format and Key types.

2023-01-23 Thread via GitHub
EdColeman commented on code in PR #3146: URL: https://github.com/apache/accumulo/pull/3146#discussion_r1084464373 ## shell/src/main/java/org/apache/accumulo/shell/commands/ConfigCommand.java: ## @@ -353,6 +344,31 @@ public int execute(final String fullCommand, final CommandLine

[GitHub] [accumulo] dlmarion commented on a diff in pull request #3168: Fixes tablet location cache bug that caused batch scanner to return duplicate data

2023-01-24 Thread via GitHub
dlmarion commented on code in PR #3168: URL: https://github.com/apache/accumulo/pull/3168#discussion_r1085247845 ## core/src/main/java/org/apache/accumulo/core/client/impl/TabletLocatorImpl.java: ## @@ -330,8 +348,16 @@ else if (!lookupFailed) tabletLocations.add(tl);

[GitHub] [accumulo] dlmarion commented on a diff in pull request #3167: Reuse ThreadPools where possible instead of recreating each time method is called

2023-01-24 Thread via GitHub
dlmarion commented on code in PR #3167: URL: https://github.com/apache/accumulo/pull/3167#discussion_r1085464357 ## server/manager/src/main/java/org/apache/accumulo/manager/Manager.java: ## @@ -950,11 +952,10 @@ private SortedMap gatherTableInformation( Set currentServer

[GitHub] [accumulo] keith-ratcliffe opened a new issue, #3170: In 2.1, accumulo shell exhibits unexpected copy/paste behavior

2023-01-24 Thread via GitHub
keith-ratcliffe opened a new issue, #3170: URL: https://github.com/apache/accumulo/issues/3170 **Describe the bug** In prior versions of Accumulo, the user could copy and paste a newline-separated list of commands into the shell and have them be executed in sequence. In 2.1, this see

[GitHub] [accumulo] dlmarion commented on pull request #3167: Reuse ThreadPools where possible instead of recreating each time method is called

2023-01-24 Thread via GitHub
dlmarion commented on PR #3167: URL: https://github.com/apache/accumulo/pull/3167#issuecomment-1402484884 There is something in the PR that is causing the balancer ITs to fail. I can't figure out what it is, so I'm going to let this sit for a while and close later if we can't figure it out.

[GitHub] [accumulo-proxy] DomGarguilo commented on pull request #23: accumulo-proxy #22 - Reduce Docker image size

2023-01-24 Thread via GitHub
DomGarguilo commented on PR #23: URL: https://github.com/apache/accumulo-proxy/pull/23#issuecomment-1402557902 It seems like there are some good improvements here. If there is no activity on this PR I may open a new one and try to incorporate some of these changes at some point. -- This

[GitHub] [accumulo] dlmarion commented on issue #3170: In 2.1, accumulo shell exhibits unexpected copy/paste behavior

2023-01-24 Thread via GitHub
dlmarion commented on issue #3170: URL: https://github.com/apache/accumulo/issues/3170#issuecomment-1402619461 I was able to reproduce your issue. IIRC the jline dependency was upgraded and looking at their documentation, issues, and user list, I'm guessing this is the issue. I did notice t

[GitHub] [accumulo-proxy] DomGarguilo opened a new issue, #66: Example clients no longer work

2023-01-24 Thread via GitHub
DomGarguilo opened a new issue, #66: URL: https://github.com/apache/accumulo-proxy/issues/66 In #59, the way a user authenticates to the proxy was changed. This changes some things that are used in `proxy.properties`. For example, the proxy looks for a property with the key `sharedSecret` w

[GitHub] [accumulo] dlmarion commented on issue #3170: In 2.1, accumulo shell exhibits unexpected copy/paste behavior

2023-01-24 Thread via GitHub
dlmarion commented on issue #3170: URL: https://github.com/apache/accumulo/issues/3170#issuecomment-1402647258 Reading through some of the issues and comments on the user list, it looks like we might need to create out own parser. -- This is an automated message from the Apache Git Servic

[GitHub] [accumulo] dlmarion opened a new pull request, #3171: Add options to JLine3 LineReader to disable highlighting and bracketed paste

2023-01-24 Thread via GitHub
dlmarion opened a new pull request, #3171: URL: https://github.com/apache/accumulo/pull/3171 Closes #3170 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

[GitHub] [accumulo] dlmarion commented on pull request #3171: Add options to JLine3 LineReader to disable highlighting and bracketed paste

2023-01-24 Thread via GitHub
dlmarion commented on PR #3171: URL: https://github.com/apache/accumulo/pull/3171#issuecomment-1402765491 It appears that JLine implemented (and enabled by default) [bracketed-paste](https://en.wikipedia.org/wiki/Bracketed-paste). This PR disables that and disables highlighting. I tested th

[GitHub] [accumulo] EdColeman commented on issue #2606: Scanner.setTimeout() does not work

2023-01-24 Thread via GitHub
EdColeman commented on issue #2606: URL: https://github.com/apache/accumulo/issues/2606#issuecomment-1402836124 The javadoc in ScannerBase says that the timeout is a retry timeout. ``` This setting determines how long a scanner will automatically retry when a failure occurs. By

[GitHub] [accumulo] EdColeman commented on pull request #3166: rename ScannerOptions timeOut to scanTimeOut, fix possible bug

2023-01-24 Thread via GitHub
EdColeman commented on PR #3166: URL: https://github.com/apache/accumulo/pull/3166#issuecomment-1402838794 Closing this and will submit a new PR against 2.1. After more investigation timeOut should be renamed retryTimeout and there may be other changes that can provide readability improvem

[GitHub] [accumulo] EdColeman closed pull request #3166: rename ScannerOptions timeOut to scanTimeOut, fix possible bug

2023-01-24 Thread via GitHub
EdColeman closed pull request #3166: rename ScannerOptions timeOut to scanTimeOut, fix possible bug URL: https://github.com/apache/accumulo/pull/3166 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [accumulo] EdColeman opened a new pull request, #3172: fix parameter timeout checks, rename timeOut to retryTimeout

2023-01-24 Thread via GitHub
EdColeman opened a new pull request, #3172: URL: https://github.com/apache/accumulo/pull/3172 Fixes parameter validation of timeout where the instance variable timeOut was used. Renames instance variable timeOut to retryTimeout to reflect the intended purpose in the javadoc. This

[GitHub] [accumulo] ddanielr commented on a diff in pull request #3172: fix parameter timeout checks, rename timeOut to retryTimeout

2023-01-24 Thread via GitHub
ddanielr commented on code in PR #3172: URL: https://github.com/apache/accumulo/pull/3172#discussion_r1086106035 ## core/src/main/java/org/apache/accumulo/core/client/ClientSideIteratorScanner.java: ## @@ -213,7 +213,7 @@ public ClientSideIteratorScanner(final Scanner scanner) {

[GitHub] [accumulo] ddanielr commented on pull request #3172: fix parameter timeout checks, rename timeOut to retryTimeout

2023-01-24 Thread via GitHub
ddanielr commented on PR #3172: URL: https://github.com/apache/accumulo/pull/3172#issuecomment-1402915758 :+1: Changing the verbiage to `retryTimeout` makes its use much clearer! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [accumulo] dlmarion commented on pull request #3171: Add options to JLine3 LineReader to disable highlighting and bracketed paste

2023-01-25 Thread via GitHub
dlmarion commented on PR #3171: URL: https://github.com/apache/accumulo/pull/3171#issuecomment-1403474518 Full IT build passed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [accumulo] dlmarion merged pull request #3171: Add options to JLine3 LineReader to disable highlighting and bracketed paste

2023-01-25 Thread via GitHub
dlmarion merged PR #3171: URL: https://github.com/apache/accumulo/pull/3171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ac

[GitHub] [accumulo] dlmarion closed issue #3170: In 2.1, accumulo shell exhibits unexpected copy/paste behavior

2023-01-25 Thread via GitHub
dlmarion closed issue #3170: In 2.1, accumulo shell exhibits unexpected copy/paste behavior URL: https://github.com/apache/accumulo/issues/3170 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [accumulo] dlmarion commented on a diff in pull request #3172: fix parameter timeout checks, rename timeOut to retryTimeout

2023-01-25 Thread via GitHub
dlmarion commented on code in PR #3172: URL: https://github.com/apache/accumulo/pull/3172#discussion_r1086535003 ## core/src/main/java/org/apache/accumulo/core/client/ClientSideIteratorScanner.java: ## @@ -213,7 +213,7 @@ public ClientSideIteratorScanner(final Scanner scanner) {

[GitHub] [accumulo] dlmarion commented on a diff in pull request #3172: fix parameter timeout checks, rename timeOut to retryTimeout

2023-01-25 Thread via GitHub
dlmarion commented on code in PR #3172: URL: https://github.com/apache/accumulo/pull/3172#discussion_r1086559302 ## core/src/main/java/org/apache/accumulo/core/clientImpl/TabletServerBatchReader.java: ## @@ -116,6 +116,6 @@ public Iterator> iterator() { } return new

[GitHub] [accumulo] dlmarion commented on a diff in pull request #3136: WIP - remove VFS and only search file system for jars for context classloading

2023-01-25 Thread via GitHub
dlmarion commented on code in PR #3136: URL: https://github.com/apache/accumulo/pull/3136#discussion_r1086632609 ## core/src/main/java/org/apache/accumulo/core/conf/Property.java: ## @@ -1058,45 +1044,6 @@ public enum Property { + "constraint.", "2.0.0"), -

[GitHub] [accumulo] dlmarion commented on a diff in pull request #3136: WIP - remove VFS and only search file system for jars for context classloading

2023-01-25 Thread via GitHub
dlmarion commented on code in PR #3136: URL: https://github.com/apache/accumulo/pull/3136#discussion_r1086632609 ## core/src/main/java/org/apache/accumulo/core/conf/Property.java: ## @@ -1058,45 +1044,6 @@ public enum Property { + "constraint.", "2.0.0"), -

[GitHub] [accumulo] dlmarion commented on a diff in pull request #3136: WIP - remove VFS and only search file system for jars for context classloading

2023-01-25 Thread via GitHub
dlmarion commented on code in PR #3136: URL: https://github.com/apache/accumulo/pull/3136#discussion_r1086724221 ## core/src/main/java/org/apache/accumulo/core/conf/Property.java: ## @@ -1058,45 +1044,6 @@ public enum Property { + "constraint.", "2.0.0"), -

[GitHub] [accumulo] EdColeman commented on a diff in pull request #3172: fix parameter timeout checks, rename timeOut to retryTimeout

2023-01-25 Thread via GitHub
EdColeman commented on code in PR #3172: URL: https://github.com/apache/accumulo/pull/3172#discussion_r1086735011 ## core/src/main/java/org/apache/accumulo/core/client/ClientSideIteratorScanner.java: ## @@ -213,7 +213,7 @@ public ClientSideIteratorScanner(final Scanner scanner)

[GitHub] [accumulo] EdColeman commented on a diff in pull request #3172: fix parameter timeout checks, rename timeOut to retryTimeout

2023-01-25 Thread via GitHub
EdColeman commented on code in PR #3172: URL: https://github.com/apache/accumulo/pull/3172#discussion_r1086737146 ## core/src/main/java/org/apache/accumulo/core/clientImpl/TabletServerBatchReader.java: ## @@ -116,6 +116,6 @@ public Iterator> iterator() { } return new

[GitHub] [accumulo] dlmarion commented on a diff in pull request #3172: fix parameter timeout checks, rename timeOut to retryTimeout

2023-01-25 Thread via GitHub
dlmarion commented on code in PR #3172: URL: https://github.com/apache/accumulo/pull/3172#discussion_r1086739983 ## core/src/main/java/org/apache/accumulo/core/clientImpl/TabletServerBatchReader.java: ## @@ -116,6 +116,6 @@ public Iterator> iterator() { } return new

[GitHub] [accumulo] EdColeman commented on a diff in pull request #3172: fix parameter timeout checks, rename timeOut to retryTimeout

2023-01-25 Thread via GitHub
EdColeman commented on code in PR #3172: URL: https://github.com/apache/accumulo/pull/3172#discussion_r1086742942 ## core/src/main/java/org/apache/accumulo/core/clientImpl/TabletServerBatchReader.java: ## @@ -116,6 +116,6 @@ public Iterator> iterator() { } return new

[GitHub] [accumulo] dlmarion commented on a diff in pull request #3136: WIP - remove VFS and only search file system for jars for context classloading

2023-01-25 Thread via GitHub
dlmarion commented on code in PR #3136: URL: https://github.com/apache/accumulo/pull/3136#discussion_r1086742635 ## core/src/main/java/org/apache/accumulo/core/classloader/DefaultContextClassLoaderFactory.java: ## @@ -48,55 +46,49 @@ public class DefaultContextClassLoaderFactory

[GitHub] [accumulo] ctubbsii commented on a diff in pull request #3161: Rename GarbageCollectionLogger, optionally pause scans/compactions until memory usage is lower

2023-01-25 Thread via GitHub
ctubbsii commented on code in PR #3161: URL: https://github.com/apache/accumulo/pull/3161#discussion_r1086869164 ## core/src/main/java/org/apache/accumulo/core/client/admin/ActiveCompaction.java: ## @@ -119,6 +119,12 @@ public enum CompactionReason { */ public abstract lo

[GitHub] [accumulo] keith-ratcliffe commented on issue #3170: In 2.1, accumulo shell exhibits unexpected copy/paste behavior

2023-01-25 Thread via GitHub
keith-ratcliffe commented on issue #3170: URL: https://github.com/apache/accumulo/issues/3170#issuecomment-1403986210 Thanks @dlmarion ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [accumulo] ctubbsii commented on pull request #3165: add option to dump Zk ACls with zoo-info-viewer (#3118)

2023-01-25 Thread via GitHub
ctubbsii commented on PR #3165: URL: https://github.com/apache/accumulo/pull/3165#issuecomment-1404020244 In trying to understand what happened, I see that I merged this forward to the main branch for 3.0.0 from the 2.1 branch from the command-line, so GitHub thought it was okay to delete t

[GitHub] [accumulo] dlmarion commented on a diff in pull request #3161: Rename GarbageCollectionLogger, optionally pause scans/compactions until memory usage is lower

2023-01-25 Thread via GitHub
dlmarion commented on code in PR #3161: URL: https://github.com/apache/accumulo/pull/3161#discussion_r1087000387 ## core/src/main/java/org/apache/accumulo/core/client/admin/ActiveCompaction.java: ## @@ -119,6 +119,12 @@ public enum CompactionReason { */ public abstract lo

[GitHub] [accumulo] dlmarion commented on pull request #3161: Rename GarbageCollectionLogger, optionally pause scans/compactions until memory usage is lower

2023-01-25 Thread via GitHub
dlmarion commented on PR #3161: URL: https://github.com/apache/accumulo/pull/3161#issuecomment-1404032242 @keith-turner - could you take a look at this when you get a chance? I talked with @ctubbsii and he said he had not objection to including in 3.0, wanted to get your input before I merg

[GitHub] [accumulo] EdColeman commented on pull request #3165: add option to dump Zk ACls with zoo-info-viewer (#3118)

2023-01-25 Thread via GitHub
EdColeman commented on PR #3165: URL: https://github.com/apache/accumulo/pull/3165#issuecomment-1404036393 I was incorrectly using my clone as a "staging branch" instead of pushing directly to the main (upstream) accumulo repository, thinking that would be a safer course. The githib action

[GitHub] [accumulo-proxy] ctubbsii closed issue #64: Update docker config to work with 2.1

2023-01-25 Thread via GitHub
ctubbsii closed issue #64: Update docker config to work with 2.1 URL: https://github.com/apache/accumulo-proxy/issues/64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [accumulo-proxy] ctubbsii merged pull request #65: Update Dockerfile to work with current code

2023-01-25 Thread via GitHub
ctubbsii merged PR #65: URL: https://github.com/apache/accumulo-proxy/pull/65 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [accumulo] ctubbsii commented on pull request #3166: rename ScannerOptions timeOut to scanTimeOut, fix possible bug

2023-01-25 Thread via GitHub
ctubbsii commented on PR #3166: URL: https://github.com/apache/accumulo/pull/3166#issuecomment-1404054373 Superseded by #3172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [accumulo] ctubbsii commented on pull request #3165: add option to dump Zk ACls with zoo-info-viewer (#3118)

2023-01-25 Thread via GitHub
ctubbsii commented on PR #3165: URL: https://github.com/apache/accumulo/pull/3165#issuecomment-1404061200 You can still stage on your clone to run GitHub Actions in your fork... and then fix any issues by adding fixes to your local branch before pushing up. You don't need to create a PR to

[GitHub] [accumulo] ddanielr opened a new pull request, #3173: WIP: Property Validation handling on backend

2023-01-25 Thread via GitHub
ddanielr opened a new pull request, #3173: URL: https://github.com/apache/accumulo/pull/3173 I'm looking for feedback on direction of thrift error handling. I'm not seeing the errors I'm expecting, so I'm attempting to figure out what disconnect I still have My expectation is that

[GitHub] [accumulo] ctubbsii commented on a diff in pull request #3160: remove upgrade code for versions before 2.1

2023-01-25 Thread via GitHub
ctubbsii commented on code in PR #3160: URL: https://github.com/apache/accumulo/pull/3160#discussion_r1087042300 ## server/base/src/main/java/org/apache/accumulo/server/AccumuloDataVersion.java: ## @@ -47,18 +47,6 @@ public class AccumuloDataVersion { */ public static fin

[GitHub] [accumulo] EdColeman commented on pull request #3172: fix parameter timeout checks, rename timeOut to retryTimeout

2023-01-25 Thread via GitHub
EdColeman commented on PR #3172: URL: https://github.com/apache/accumulo/pull/3172#issuecomment-1404085862 This looks like 1.10 may be a better target - but the package names have changed - @ctubbsii do you have a preference for the way the changes are applied? I could try an see if I can

[GitHub] [accumulo] EdColeman commented on a diff in pull request #3160: remove upgrade code for versions before 2.1

2023-01-25 Thread via GitHub
EdColeman commented on code in PR #3160: URL: https://github.com/apache/accumulo/pull/3160#discussion_r1087062854 ## server/manager/src/main/java/org/apache/accumulo/manager/upgrade/UpgradeChecker.java: ## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [accumulo] dlmarion commented on a diff in pull request #3173: WIP: Property Validation handling on backend

2023-01-25 Thread via GitHub
dlmarion commented on code in PR #3173: URL: https://github.com/apache/accumulo/pull/3173#discussion_r1087066114 ## server/manager/src/main/java/org/apache/accumulo/manager/ManagerClientServiceHandler.java: ## @@ -434,7 +441,7 @@ public void setSystemProperty(TInfo info, TCreden

[GitHub] [accumulo] ctubbsii commented on a diff in pull request #3160: remove upgrade code for versions before 2.1

2023-01-25 Thread via GitHub
ctubbsii commented on code in PR #3160: URL: https://github.com/apache/accumulo/pull/3160#discussion_r1087125107 ## server/manager/src/main/java/org/apache/accumulo/manager/upgrade/UpgradeChecker.java: ## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [accumulo] ctubbsii commented on a diff in pull request #3173: WIP: Property Validation handling on backend

2023-01-25 Thread via GitHub
ctubbsii commented on code in PR #3173: URL: https://github.com/apache/accumulo/pull/3173#discussion_r1087162094 ## core/src/main/java/org/apache/accumulo/core/conf/Property.java: ## @@ -1702,16 +1702,20 @@ private static boolean hasPrefixWithAnnotation(String key /**

[GitHub] [accumulo] ddanielr commented on a diff in pull request #3173: WIP: Property Validation handling on backend

2023-01-25 Thread via GitHub
ddanielr commented on code in PR #3173: URL: https://github.com/apache/accumulo/pull/3173#discussion_r1087206989 ## server/manager/src/main/java/org/apache/accumulo/manager/ManagerClientServiceHandler.java: ## @@ -434,7 +441,7 @@ public void setSystemProperty(TInfo info, TCreden

[GitHub] [accumulo] EdColeman commented on a diff in pull request #3160: remove upgrade code for versions before 2.1

2023-01-25 Thread via GitHub
EdColeman commented on code in PR #3160: URL: https://github.com/apache/accumulo/pull/3160#discussion_r1087252944 ## server/base/src/test/java/org/apache/accumulo/server/ServerContextTest.java: ## @@ -135,7 +135,8 @@ public void testCanRun() { // ensure this fails with olde

[GitHub] [accumulo] EdColeman commented on a diff in pull request #3160: remove upgrade code for versions before 2.1

2023-01-25 Thread via GitHub
EdColeman commented on code in PR #3160: URL: https://github.com/apache/accumulo/pull/3160#discussion_r1087286437 ## server/manager/src/main/java/org/apache/accumulo/manager/upgrade/UpgradeCoordinator.java: ## @@ -142,11 +140,14 @@ public synchronized void upgradeZookeeper(Serve

[GitHub] [accumulo] EdColeman commented on a diff in pull request #3160: remove upgrade code for versions before 2.1

2023-01-25 Thread via GitHub
EdColeman commented on code in PR #3160: URL: https://github.com/apache/accumulo/pull/3160#discussion_r1087294704 ## server/manager/src/main/java/org/apache/accumulo/manager/upgrade/UpgradeChecker.java: ## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [accumulo] EdColeman commented on a diff in pull request #3160: remove upgrade code for versions before 2.1

2023-01-25 Thread via GitHub
EdColeman commented on code in PR #3160: URL: https://github.com/apache/accumulo/pull/3160#discussion_r1087295011 ## server/base/src/main/java/org/apache/accumulo/server/AccumuloDataVersion.java: ## @@ -47,18 +47,6 @@ public class AccumuloDataVersion { */ public static fi

[GitHub] [accumulo] ctubbsii commented on a diff in pull request #3160: remove upgrade code for versions before 2.1

2023-01-26 Thread via GitHub
ctubbsii commented on code in PR #3160: URL: https://github.com/apache/accumulo/pull/3160#discussion_r1088008352 ## server/base/src/test/java/org/apache/accumulo/server/ServerContextTest.java: ## @@ -135,7 +135,8 @@ public void testCanRun() { // ensure this fails with older

[GitHub] [accumulo] ctubbsii commented on a diff in pull request #3160: remove upgrade code for versions before 2.1

2023-01-26 Thread via GitHub
ctubbsii commented on code in PR #3160: URL: https://github.com/apache/accumulo/pull/3160#discussion_r1088015001 ## server/manager/src/main/java/org/apache/accumulo/manager/upgrade/UpgradeCoordinator.java: ## @@ -142,11 +140,14 @@ public synchronized void upgradeZookeeper(Server

[GitHub] [accumulo] ctubbsii commented on a diff in pull request #3160: remove upgrade code for versions before 2.1

2023-01-26 Thread via GitHub
ctubbsii commented on code in PR #3160: URL: https://github.com/apache/accumulo/pull/3160#discussion_r1088015001 ## server/manager/src/main/java/org/apache/accumulo/manager/upgrade/UpgradeCoordinator.java: ## @@ -142,11 +140,14 @@ public synchronized void upgradeZookeeper(Server

[GitHub] [accumulo] ivakegg commented on pull request #3142: re #1169: Added a property to specify the location mode for tservers

2023-01-26 Thread via GitHub
ivakegg commented on PR #3142: URL: https://github.com/apache/accumulo/pull/3142#issuecomment-1405242835 @ctubbsii Are you now ok with this PR or do you hvae additional concerns? Do you want additional PRs to go against 2.1 and 1.10 ? -- This is an automated message from the Apache Git S

[GitHub] [accumulo] ctubbsii commented on pull request #3142: re #1169: Added a property to specify the location mode for tservers

2023-01-26 Thread via GitHub
ctubbsii commented on PR #3142: URL: https://github.com/apache/accumulo/pull/3142#issuecomment-1405281252 @ivakegg asked: > @ctubbsii Are you now ok with this PR or do you hvae additional concerns? Do you want additional PRs to go against 2.1 and 1.10 ? I don't have any other conce

[GitHub] [accumulo] ctubbsii commented on issue #1169: balancing strategy

2023-01-26 Thread via GitHub
ctubbsii commented on issue #1169: URL: https://github.com/apache/accumulo/issues/1169#issuecomment-1405284059 This is addressed by #3142 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [accumulo] ctubbsii merged pull request #3142: re #1169: Added a property to specify the location mode for tservers

2023-01-26 Thread via GitHub
ctubbsii merged PR #3142: URL: https://github.com/apache/accumulo/pull/3142 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ac

[GitHub] [accumulo] asfgit closed issue #1169: balancing strategy

2023-01-26 Thread via GitHub
asfgit closed issue #1169: balancing strategy URL: https://github.com/apache/accumulo/issues/1169 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifi

[GitHub] [accumulo] ctubbsii commented on pull request #3142: re #1169: Added a property to specify the location mode for tservers

2023-01-26 Thread via GitHub
ctubbsii commented on PR #3142: URL: https://github.com/apache/accumulo/pull/3142#issuecomment-1405328601 Committed to 2.1 branch as 7f19f96914ed12614bbd2d6b24a88d322e49b006 and merged forward into main branch -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [accumulo] ctubbsii commented on a diff in pull request #3167: Reuse ThreadPools where possible instead of recreating each time method is called

2023-01-26 Thread via GitHub
ctubbsii commented on code in PR #3167: URL: https://github.com/apache/accumulo/pull/3167#discussion_r1088130572 ## core/src/main/java/org/apache/accumulo/core/fate/Fate.java: ## @@ -235,6 +235,9 @@ public Fate(T environment, TStore store, Function,String> toLogStrFun * Lau

[GitHub] [accumulo-proxy] DomGarguilo opened a new pull request, #67: Fix ruby and python example clients

2023-01-26 Thread via GitHub
DomGarguilo opened a new pull request, #67: URL: https://github.com/apache/accumulo-proxy/pull/67 Fixes #66 The proxy now looks for the property `sharedSecret` in the props file. Also, the changes in #59 removed the login method. This PR fixes these two problems. -- This is

[GitHub] [accumulo-proxy] DomGarguilo commented on pull request #67: Fix ruby and python example clients

2023-01-26 Thread via GitHub
DomGarguilo commented on PR #67: URL: https://github.com/apache/accumulo-proxy/pull/67#issuecomment-1405397740 Before adding `sharedSecret` to the example properties file, it was being set to `null`. I am wondering if there should be a check in place to make sure that the shared secret is n

[GitHub] [accumulo] ivakegg commented on pull request #3142: re #1169: Added a property to specify the location mode for tservers

2023-01-26 Thread via GitHub
ivakegg commented on PR #3142: URL: https://github.com/apache/accumulo/pull/3142#issuecomment-1405487315 @ctubbsii OK, thank you for merging. I can keep 1.10 backport exclusively in our own repo. -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [accumulo] ddanielr commented on a diff in pull request #3173: WIP: Property Validation handling on backend

2023-01-26 Thread via GitHub
ddanielr commented on code in PR #3173: URL: https://github.com/apache/accumulo/pull/3173#discussion_r1088250767 ## core/src/main/java/org/apache/accumulo/core/conf/Property.java: ## @@ -1702,16 +1702,20 @@ private static boolean hasPrefixWithAnnotation(String key /**

[GitHub] [accumulo] dlmarion opened a new issue, #3174: ThriftScanner.serversWaitedForWrites - what does this do?

2023-01-26 Thread via GitHub
dlmarion opened a new issue, #3174: URL: https://github.com/apache/accumulo/issues/3174 There is some confusing logic/use of this static map that I don't understand. In the places that it's updated, servers are only added to it, never removed. In the way that it's used, it sets the boolean

[GitHub] [accumulo-examples] jmark99 opened a new pull request, #115: Add documentation for uniquecols example

2023-01-26 Thread via GitHub
jmark99 opened a new pull request, #115: URL: https://github.com/apache/accumulo-examples/pull/115 Provide step by step example of how to use the uniquecols example for the 2.1 examples repository. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [accumulo-examples] jmark99 merged pull request #115: Add documentation for uniquecols example

2023-01-26 Thread via GitHub
jmark99 merged PR #115: URL: https://github.com/apache/accumulo-examples/pull/115 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr

[GitHub] [accumulo-proxy] DomGarguilo opened a new pull request, #68: Remove tests that switch users

2023-01-26 Thread via GitHub
DomGarguilo opened a new pull request, #68: URL: https://github.com/apache/accumulo-proxy/pull/68 This PR: * removes tests or portions of tests that switch proxy users * misc. improvements to other test logic, names or logging -- This is an automated message from the Apache Git Servi

[GitHub] [accumulo] ddanielr commented on a diff in pull request #3146: Check Prop Value Format and Key types.

2023-01-27 Thread via GitHub
ddanielr commented on code in PR #3146: URL: https://github.com/apache/accumulo/pull/3146#discussion_r1088690055 ## shell/src/main/java/org/apache/accumulo/shell/commands/ConfigCommand.java: ## @@ -353,6 +344,31 @@ public int execute(final String fullCommand, final CommandLine

[GitHub] [accumulo] ddanielr commented on a diff in pull request #3146: Check Prop Value Format and Key types.

2023-01-27 Thread via GitHub
ddanielr commented on code in PR #3146: URL: https://github.com/apache/accumulo/pull/3146#discussion_r1088691250 ## shell/src/main/java/org/apache/accumulo/shell/commands/ConfigCommand.java: ## @@ -353,6 +344,31 @@ public int execute(final String fullCommand, final CommandLine

[GitHub] [accumulo] EdColeman commented on a diff in pull request #3146: Check Prop Value Format and Key types.

2023-01-27 Thread via GitHub
EdColeman commented on code in PR #3146: URL: https://github.com/apache/accumulo/pull/3146#discussion_r1088990088 ## shell/src/main/java/org/apache/accumulo/shell/commands/ConfigCommand.java: ## @@ -353,6 +344,31 @@ public int execute(final String fullCommand, final CommandLine

  1   2   3   4   5   6   7   8   9   10   >