DomGarguilo merged PR #400:
URL: https://github.com/apache/accumulo-website/pull/400
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dlmarion commented on code in PR #3733:
URL: https://github.com/apache/accumulo/pull/3733#discussion_r1310226745
##
core/src/main/java/org/apache/accumulo/core/clientImpl/TabletServerBatchWriter.java:
##
@@ -1028,14 +1022,139 @@ private MutationSet
DomGarguilo commented on code in PR #399:
URL: https://github.com/apache/accumulo-website/pull/399#discussion_r1310223675
##
js/search.js:
##
@@ -1,48 +1,49 @@
-jQuery(function() {
+jQuery(function () {
- window.idx = lunr(function () {
-this.field('id');
-
DomGarguilo merged PR #399:
URL: https://github.com/apache/accumulo-website/pull/399
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
DomGarguilo commented on code in PR #398:
URL: https://github.com/apache/accumulo-website/pull/398#discussion_r1310257157
##
pages/contact-us.md:
##
@@ -45,10 +45,10 @@ follow discussions as they happen.
{: .table }
| Name | Description
dlmarion commented on PR #3737:
URL: https://github.com/apache/accumulo/pull/3737#issuecomment-1698979347
Full IT build passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
ivakegg commented on code in PR #3727:
URL: https://github.com/apache/accumulo/pull/3727#discussion_r1315918822
##
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/DatafileManager.java:
##
@@ -571,4 +583,19 @@ public MetadataUpdateCount getUpdateCount() {
EdColeman commented on code in PR #3703:
URL: https://github.com/apache/accumulo/pull/3703#discussion_r1316028130
##
server/gc/src/main/java/org/apache/accumulo/gc/GarbageCollectionAlgorithm.java:
##
@@ -343,4 +357,82 @@ public void collect(GarbageCollectionEnvironment gce)
AlbertWhitlock commented on issue #403:
URL:
https://github.com/apache/accumulo-website/issues/403#issuecomment-1706730057
Dom.I can take this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
AlbertWhitlock commented on issue #402:
URL:
https://github.com/apache/accumulo-website/issues/402#issuecomment-1706729626
Dom.I can take this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
DomGarguilo merged PR #404:
URL: https://github.com/apache/accumulo-website/pull/404
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
AlbertWhitlock commented on issue #402:
URL:
https://github.com/apache/accumulo-website/issues/402#issuecomment-1706618881
Aren't some users not even on 2.1 yet? If that is true I think leaving the
deprecated entries in makes sense (since that is when the replication code got
deprecated.
DomGarguilo commented on PR #3719:
URL: https://github.com/apache/accumulo/pull/3719#issuecomment-1706842810
If nobody opposes, I think this PR is ready to merge. I think we could
create a new ticket to track the addition of text indicating various system
states but that might be outside
DomGarguilo commented on PR #3676:
URL: https://github.com/apache/accumulo/pull/3676#issuecomment-1707348122
Some of the tests are failing when i correct the Sets.difference() issue
mentioned in a previous comment. Will work to fix that tomorrow.
On Tue, Sep 5, 2023 at 4:56 PM
ivakegg commented on code in PR #3727:
URL: https://github.com/apache/accumulo/pull/3727#discussion_r1317175796
##
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/DatafileManager.java:
##
@@ -571,4 +583,19 @@ public MetadataUpdateCount getUpdateCount() {
ddanielr opened a new issue, #3744:
URL: https://github.com/apache/accumulo/issues/3744
**Describe the bug**
The GCRun class creates a logger based off the class and the current
datalevel.
ddanielr opened a new pull request, #3745:
URL: https://github.com/apache/accumulo/pull/3745
This change allows easy logging targeting by putting all file deletion
actions into a separate logger.
* Adds a separate file logger to GCRun to allow for easy filtering of file
deletion log
ddanielr commented on PR #3743:
URL: https://github.com/apache/accumulo/pull/3743#issuecomment-1709579266
Closing this in favor of #3745
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ddanielr closed pull request #3743: WIP: Separate file deletions from standard
GC logs.
URL: https://github.com/apache/accumulo/pull/3743
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ctubbsii commented on code in PR #398:
URL: https://github.com/apache/accumulo-website/pull/398#discussion_r1320909988
##
pages/downloads.md:
##
@@ -12,8 +12,8 @@ var updateLinks = function(mirror) {
};
var mirrorsCallback = function(json) {
- var htmlContent = 'Select an
ctubbsii commented on PR #3737:
URL: https://github.com/apache/accumulo/pull/3737#issuecomment-1713038224
I think it's related to the issue of the max message size counter not being
reset when the transport is reused for some new messages. So, you won't see it
for only a single message.
EdColeman commented on code in PR #3745:
URL: https://github.com/apache/accumulo/pull/3745#discussion_r1318576912
##
server/gc/src/main/java/org/apache/accumulo/gc/GCRun.java:
##
@@ -88,6 +88,7 @@
*/
public class GCRun implements GarbageCollectionEnvironment {
private
dlmarion commented on code in PR #3715:
URL: https://github.com/apache/accumulo/pull/3715#discussion_r1318522914
##
access/SPECIFICATION.md:
##
@@ -0,0 +1,66 @@
+
+
+# AccessExpression Specification
+
+This document specifies the format of an Apache Accumulo AccessExpression.
EdColeman commented on code in PR #3745:
URL: https://github.com/apache/accumulo/pull/3745#discussion_r1318570726
##
server/gc/src/main/java/org/apache/accumulo/gc/GCRun.java:
##
@@ -97,7 +98,8 @@ public class GCRun implements GarbageCollectionEnvironment {
private long
keith-turner opened a new pull request, #3747:
URL: https://github.com/apache/accumulo/pull/3747
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
EdColeman commented on code in PR #3727:
URL: https://github.com/apache/accumulo/pull/3727#discussion_r1321569371
##
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/DatafileTransactionLog.java:
##
@@ -0,0 +1,385 @@
+/*
+ * Licensed to the Apache Software
EdColeman commented on code in PR #3727:
URL: https://github.com/apache/accumulo/pull/3727#discussion_r1321653437
##
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/DatafileTransactionLog.java:
##
@@ -0,0 +1,385 @@
+/*
+ * Licensed to the Apache Software
EdColeman commented on code in PR #3727:
URL: https://github.com/apache/accumulo/pull/3727#discussion_r1321597519
##
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/DatafileTransactionLog.java:
##
@@ -0,0 +1,385 @@
+/*
+ * Licensed to the Apache Software
EdColeman commented on code in PR #3727:
URL: https://github.com/apache/accumulo/pull/3727#discussion_r1321569371
##
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/DatafileTransactionLog.java:
##
@@ -0,0 +1,385 @@
+/*
+ * Licensed to the Apache Software
DomGarguilo commented on PR #3719:
URL: https://github.com/apache/accumulo/pull/3719#issuecomment-1714097261
@ctubbsii, thanks for the detailed explanation here. I won't merge this in
until we find a good solution.
After reading your suggestions/ideas it seems like the idea of adding
EdColeman commented on code in PR #3727:
URL: https://github.com/apache/accumulo/pull/3727#discussion_r1321779768
##
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/DatafileTransactionLog.java:
##
@@ -0,0 +1,385 @@
+/*
+ * Licensed to the Apache Software
DomGarguilo commented on code in PR #30:
URL: https://github.com/apache/accumulo-docker/pull/30#discussion_r1321848241
##
README.md:
##
@@ -39,7 +39,7 @@ building an image:
Or build with an Accumulo tarball (located in same directory as DockerFile)
using the command
ctubbsii commented on code in PR #30:
URL: https://github.com/apache/accumulo-docker/pull/30#discussion_r1321897480
##
README.md:
##
@@ -39,7 +39,7 @@ building an image:
Or build with an Accumulo tarball (located in same directory as DockerFile)
using the command below:
DomGarguilo commented on code in PR #398:
URL: https://github.com/apache/accumulo-website/pull/398#discussion_r1321835486
##
pages/downloads.md:
##
@@ -12,8 +12,8 @@ var updateLinks = function(mirror) {
};
var mirrorsCallback = function(json) {
- var htmlContent = 'Select
ctubbsii commented on PR #4:
URL: https://github.com/apache/accumulo-access/pull/4#issuecomment-1714376490
> @ctubbsii - I think @keith-turner might be looking for your input /
changes on the pom overall.
I will definitely go spelunking in the POM and GitHub Actions to polish up
EdColeman commented on code in PR #3727:
URL: https://github.com/apache/accumulo/pull/3727#discussion_r1321757698
##
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/DatafileTransactionLog.java:
##
@@ -0,0 +1,385 @@
+/*
+ * Licensed to the Apache Software
AlbertWhitlock commented on code in PR #3228:
URL: https://github.com/apache/accumulo/pull/3228#discussion_r1321832379
##
test/src/main/java/org/apache/accumulo/test/ExportTableCommandWithMultipleVolumesIT.java:
##
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the Apache Software
dlmarion merged PR #5:
URL: https://github.com/apache/accumulo-access/pull/5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ctubbsii commented on code in PR #398:
URL: https://github.com/apache/accumulo-website/pull/398#discussion_r1321912875
##
pages/downloads.md:
##
@@ -85,26 +85,29 @@ available in a future update to this site.
{% for srcbin in srcbinArray %}
{% assign lnkFile = 'accumulo-' |
DomGarguilo commented on code in PR #398:
URL: https://github.com/apache/accumulo-website/pull/398#discussion_r1321798733
##
pages/downloads.md:
##
@@ -85,26 +85,29 @@ available in a future update to this site.
{% for srcbin in srcbinArray %}
{% assign lnkFile = 'accumulo-' |
dlmarion commented on PR #4:
URL: https://github.com/apache/accumulo-access/pull/4#issuecomment-1714350395
@ctubbsii - I think @keith-turner might be looking for your input / changes
on the pom overall.
--
This is an automated message from the Apache Git Service.
To respond to the
ctubbsii commented on code in PR #398:
URL: https://github.com/apache/accumulo-website/pull/398#discussion_r1321906688
##
pages/downloads.md:
##
@@ -85,26 +85,29 @@ available in a future update to this site.
{% for srcbin in srcbinArray %}
{% assign lnkFile = 'accumulo-' |
ctubbsii commented on code in PR #398:
URL: https://github.com/apache/accumulo-website/pull/398#discussion_r1321909298
##
pages/downloads.md:
##
@@ -85,26 +85,29 @@ available in a future update to this site.
{% for srcbin in srcbinArray %}
{% assign lnkFile = 'accumulo-' |
ctubbsii commented on code in PR #3228:
URL: https://github.com/apache/accumulo/pull/3228#discussion_r1321928796
##
test/src/main/java/org/apache/accumulo/test/ExportTableCommandWithMultipleVolumesIT.java:
##
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the Apache Software Foundation
DomGarguilo commented on code in PR #398:
URL: https://github.com/apache/accumulo-website/pull/398#discussion_r1321835278
##
pages/downloads.md:
##
@@ -85,26 +85,29 @@ available in a future update to this site.
{% for srcbin in srcbinArray %}
{% assign lnkFile = 'accumulo-' |
ctubbsii commented on code in PR #398:
URL: https://github.com/apache/accumulo-website/pull/398#discussion_r1321903836
##
pages/downloads.md:
##
@@ -85,16 +85,17 @@ available in a future update to this site.
{% for srcbin in srcbinArray %}
{% assign lnkFile = 'accumulo-' |
ctubbsii commented on code in PR #398:
URL: https://github.com/apache/accumulo-website/pull/398#discussion_r1321909298
##
pages/downloads.md:
##
@@ -85,26 +85,29 @@ available in a future update to this site.
{% for srcbin in srcbinArray %}
{% assign lnkFile = 'accumulo-' |
keith-turner opened a new pull request, #3748:
URL: https://github.com/apache/accumulo/pull/3748
The tablet code was structured in such a way that an exception could leave a
lock related to write ahead logs locked forever. This change does two things
to fix this.
* In
keith-turner commented on code in PR #3748:
URL: https://github.com/apache/accumulo/pull/3748#discussion_r1322189007
##
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java:
##
@@ -1889,6 +1889,8 @@ public void
checkIfMinorCompactionNeededForLogs(List
ctubbsii commented on PR #3719:
URL: https://github.com/apache/accumulo/pull/3719#issuecomment-1714668403
So, after speaking with @DomGarguilo , I want to break down the next steps
we discussed:
1. Create an icon that is normally not present, but appears as a distinct
alert,
ctubbsii commented on code in PR #398:
URL: https://github.com/apache/accumulo-website/pull/398#discussion_r1322157956
##
pages/downloads.md:
##
@@ -85,26 +85,29 @@ available in a future update to this site.
{% for srcbin in srcbinArray %}
{% assign lnkFile = 'accumulo-' |
keith-turner commented on code in PR #3748:
URL: https://github.com/apache/accumulo/pull/3748#discussion_r1322169702
##
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java:
##
@@ -1889,6 +1889,8 @@ public void
checkIfMinorCompactionNeededForLogs(List
ctubbsii commented on code in PR #3748:
URL: https://github.com/apache/accumulo/pull/3748#discussion_r1322162813
##
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java:
##
@@ -1889,6 +1889,8 @@ public void
checkIfMinorCompactionNeededForLogs(List
keith-turner commented on PR #3747:
URL: https://github.com/apache/accumulo/pull/3747#issuecomment-1714756924
> It doesn't look like this can happen. Is this just being added to help us
catch some future mistake?
Yes it would be very easy to make a code change in a function that
dlmarion commented on code in PR #3745:
URL: https://github.com/apache/accumulo/pull/3745#discussion_r1327190347
##
server/gc/src/main/java/org/apache/accumulo/gc/GCRun.java:
##
@@ -97,7 +98,8 @@ public class GCRun implements GarbageCollectionEnvironment {
private long
EdColeman commented on code in PR #3745:
URL: https://github.com/apache/accumulo/pull/3745#discussion_r1327318518
##
server/gc/src/main/java/org/apache/accumulo/gc/GCRun.java:
##
@@ -87,7 +87,9 @@
* A single garbage collection performed on a table (Root, MD) or all User
dlmarion commented on PR #4:
URL: https://github.com/apache/accumulo-access/pull/4#issuecomment-1721538535
In c43e905 I modified the ANTLR grammar to modify the parse tree such that
all of the tokens in an OR and AND expression were below that node in the tree.
Added test that performs all
cshannon commented on code in PR #3728:
URL: https://github.com/apache/accumulo/pull/3728#discussion_r1327157501
##
server/manager/src/main/java/org/apache/accumulo/manager/TabletGroupWatcher.java:
##
@@ -669,8 +598,97 @@ private void updateMergeState(Map
mergeStatsCache) {
cshannon commented on PR #3728:
URL: https://github.com/apache/accumulo/pull/3728#issuecomment-1721287651
I'm going to go ahead and merge this and continue on with some follow on
PRs. Specifically, code related to chop compactions can be removed and some
more testing needs to be done. I'm
dlmarion commented on code in PR #3745:
URL: https://github.com/apache/accumulo/pull/3745#discussion_r1327187307
##
server/gc/src/main/java/org/apache/accumulo/gc/GCRun.java:
##
@@ -97,7 +98,8 @@ public class GCRun implements GarbageCollectionEnvironment {
private long
DomGarguilo closed issue #394: Update javascript and css resources
URL: https://github.com/apache/accumulo-website/issues/394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
DomGarguilo merged PR #398:
URL: https://github.com/apache/accumulo-website/pull/398
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
DomGarguilo opened a new pull request, #407:
URL: https://github.com/apache/accumulo-website/pull/407
This PR fixes and improves a bunch of code blocks throughout the site.
For some reason `commandline` was used a lot in the code blocks but does not
exist in the code highlighter we
cshannon commented on code in PR #3728:
URL: https://github.com/apache/accumulo/pull/3728#discussion_r1327162763
##
server/manager/src/main/java/org/apache/accumulo/manager/TabletGroupWatcher.java:
##
@@ -1004,28 +1027,43 @@ private List
createRangesForDeletion(TabletMetadata
EdColeman commented on PR #3745:
URL: https://github.com/apache/accumulo/pull/3745#issuecomment-1721328393
Using thread context / mdc might be something that we would want to explore
in general, For a 2.1 release, it may not be the best time to introduce it.
If I recall, there are
cshannon merged PR #3728:
URL: https://github.com/apache/accumulo/pull/3728
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
keith-turner commented on code in PR #3738:
URL: https://github.com/apache/accumulo/pull/3738#discussion_r1327627210
##
server/gc/src/main/java/org/apache/accumulo/gc/GCRun.java:
##
@@ -104,21 +107,47 @@ public GCRun(Ample.DataLevel level, ServerContext
context) {
}
ddanielr commented on PR #3745:
URL: https://github.com/apache/accumulo/pull/3745#issuecomment-1721668014
slf4j supports passing the MDC implementation to the underlying logging
system, but has no direct support for MDC.
If the user's underlying logging system is log4j2 or logback, then
keith-turner commented on code in PR #3738:
URL: https://github.com/apache/accumulo/pull/3738#discussion_r1327813480
##
server/gc/src/main/java/org/apache/accumulo/gc/GarbageCollectionAlgorithm.java:
##
@@ -156,8 +159,9 @@ private void
EdColeman commented on code in PR #3755:
URL: https://github.com/apache/accumulo/pull/3755#discussion_r1327825209
##
test/src/main/java/org/apache/accumulo/test/GCRunIT.java:
##
@@ -0,0 +1,242 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
ddanielr commented on code in PR #3745:
URL: https://github.com/apache/accumulo/pull/3745#discussion_r1327605838
##
server/gc/src/main/java/org/apache/accumulo/gc/GCRun.java:
##
@@ -87,7 +87,9 @@
* A single garbage collection performed on a table (Root, MD) or all User
keith-turner commented on code in PR #3755:
URL: https://github.com/apache/accumulo/pull/3755#discussion_r1327666186
##
test/src/main/java/org/apache/accumulo/test/GCRunIT.java:
##
@@ -0,0 +1,242 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
keith-turner commented on code in PR #3755:
URL: https://github.com/apache/accumulo/pull/3755#discussion_r1327666186
##
test/src/main/java/org/apache/accumulo/test/GCRunIT.java:
##
@@ -0,0 +1,242 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
EdColeman commented on code in PR #3755:
URL: https://github.com/apache/accumulo/pull/3755#discussion_r1327823883
##
server/gc/src/main/java/org/apache/accumulo/gc/GCRun.java:
##
@@ -160,6 +160,16 @@ public Stream getReferences() {
// there is a lot going on in this "one
EdColeman commented on code in PR #3755:
URL: https://github.com/apache/accumulo/pull/3755#discussion_r1327827741
##
test/src/main/java/org/apache/accumulo/test/GCRunIT.java:
##
@@ -0,0 +1,242 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
ddanielr commented on code in PR #3745:
URL: https://github.com/apache/accumulo/pull/3745#discussion_r1327882917
##
server/gc/src/main/java/org/apache/accumulo/gc/GCRun.java:
##
@@ -87,7 +87,9 @@
* A single garbage collection performed on a table (Root, MD) or all User
ctubbsii opened a new issue, #3757:
URL: https://github.com/apache/accumulo/issues/3757
**Test name(s)**
- org.apache.accumulo.test.functional.BalanceInPresenceOfOfflineTableIT.test
- org.apache.accumulo.test.functional.MetadataMaxFilesIT.test
-
ctubbsii commented on code in PR #3754:
URL: https://github.com/apache/accumulo/pull/3754#discussion_r1327908250
##
server/monitor/src/main/resources/org/apache/accumulo/monitor/templates/default.ftl:
##
@@ -30,7 +30,8 @@
${val}
<#else>
-
+
+
ctubbsii commented on code in PR #4:
URL: https://github.com/apache/accumulo-access/pull/4#discussion_r1327889266
##
pom.xml:
##
@@ -82,6 +82,8 @@
generate-sources
target/generated-sources/antlr4/org/apache/accumulo/access/grammars
ctubbsii commented on code in PR #4:
URL: https://github.com/apache/accumulo-access/pull/4#discussion_r1327889266
##
pom.xml:
##
@@ -82,6 +82,8 @@
generate-sources
target/generated-sources/antlr4/org/apache/accumulo/access/grammars
keith-turner opened a new pull request, #7:
URL: https://github.com/apache/accumulo-access/pull/7
This commit reimplements the java parserver and evaluator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
keith-turner opened a new pull request, #6:
URL: https://github.com/apache/accumulo-access/pull/6
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
ctubbsii commented on code in PR #3745:
URL: https://github.com/apache/accumulo/pull/3745#discussion_r1327874299
##
server/gc/src/main/java/org/apache/accumulo/gc/GCRun.java:
##
@@ -318,7 +321,7 @@ public void
deleteConfirmedCandidates(SortedMap confirmedDeletes)
keith-turner opened a new issue, #8:
URL: https://github.com/apache/accumulo-access/issues/8
For different invalid access expressions it would be nice to have to unit
test that check the error messages in the exceptions.
--
This is an automated message from the Apache Git Service.
To
ctubbsii commented on issue #3734:
URL: https://github.com/apache/accumulo/issues/3734#issuecomment-1722116396
@keith-turner seems to have merged this in
e129b80ddf621cb52485e0fa455a3de9c82d326b ; so, I'll unassign myself and close
this as fixed.
--
This is an automated message from the
dlmarion commented on code in PR #6:
URL: https://github.com/apache/accumulo-access/pull/6#discussion_r1327957362
##
SPECIFICATION.md:
##
@@ -56,5 +56,41 @@ The definition of utf8 was borrowed from this [ietf
document][2]. TODO that doc
An AccessExpression is a UTF-8 string.
dlmarion commented on code in PR #4:
URL: https://github.com/apache/accumulo-access/pull/4#discussion_r1327956183
##
pom.xml:
##
@@ -82,6 +82,8 @@
generate-sources
target/generated-sources/antlr4/org/apache/accumulo/access/grammars
dlmarion commented on code in PR #4:
URL: https://github.com/apache/accumulo-access/pull/4#discussion_r1327956431
##
src/main/java/org/apache/accumulo/access/AccessEvaluatorImpl.java:
##
@@ -30,7 +30,7 @@
import java.util.stream.Stream;
//this class is intentionally package
dlmarion commented on PR #4:
URL: https://github.com/apache/accumulo-access/pull/4#issuecomment-173222
> It feels very weird to write the specification in ABNF, and then to have a
test to verify that the ABNF is properly written using an imported G4
specification for ABNF (which is
dlmarion commented on PR #7:
URL: https://github.com/apache/accumulo-access/pull/7#issuecomment-170495
> how well does this perform compared to the previous implementation
This is my main concern also, to include the ANTLR parser. @keith-turner and
I have discussed creating a
DomGarguilo opened a new pull request, #3719:
URL: https://github.com/apache/accumulo/pull/3719
Alternative approach to #3711. The difference here is the icon added is
simply a unicode character that is displayed over the existing dot icon when
the manager state is not normal. With this
DomGarguilo commented on PR #3711:
URL: https://github.com/apache/accumulo/pull/3711#issuecomment-1692008759
Created #3719 as an alternative approach to this PR. The difference being
the use of a unicode character for the icon as opposed to an svg like in this
PR. This PR can be closed as
keith-turner commented on code in PR #3720:
URL: https://github.com/apache/accumulo/pull/3720#discussion_r1304613468
##
core/src/main/java/org/apache/accumulo/core/fate/zookeeper/ZooReader.java:
##
@@ -184,7 +184,11 @@ protected R retryLoopMutator(ZKFunctionMutator zkf,
DomGarguilo commented on code in PR #3711:
URL: https://github.com/apache/accumulo/pull/3711#discussion_r1304459556
##
server/monitor/src/main/resources/org/apache/accumulo/monitor/templates/navbar.ftl:
##
@@ -33,12 +33,50 @@
-
hlgp commented on issue #3573:
URL: https://github.com/apache/accumulo/issues/3573#issuecomment-1691945563
I traced through 6 or 7 instances of this phenomenon and they all have the
same pattern regardless of whether its a metadata or non-metadata tablet
affected.
1. Files are
EdColeman commented on code in PR #3727:
URL: https://github.com/apache/accumulo/pull/3727#discussion_r1312058646
##
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/DatafileTransactionLog.java:
##
@@ -0,0 +1,286 @@
+/*
+ * Licensed to the Apache Software
keith-turner commented on code in PR #3727:
URL: https://github.com/apache/accumulo/pull/3727#discussion_r1312057404
##
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/DatafileManager.java:
##
@@ -571,4 +583,19 @@ public MetadataUpdateCount getUpdateCount() {
dlmarion commented on code in PR #3715:
URL: https://github.com/apache/accumulo/pull/3715#discussion_r1312312443
##
access/src/main/java/org/apache/accumulo/access/AccessExpressionImpl.java:
##
@@ -0,0 +1,635 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
dlmarion commented on code in PR #3737:
URL: https://github.com/apache/accumulo/pull/3737#discussion_r1311912690
##
core/src/test/java/org/apache/accumulo/core/rpc/ThriftUtilTest.java:
##
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
keith-turner commented on PR #3728:
URL: https://github.com/apache/accumulo/pull/3728#issuecomment-1701870738
While looking at this locally I noticed that
`TabletGroupWatcher.sendSplitRequest()` is no longer used. Could that be
removed? Also could `MergeState.SPLITTING` be removed?
--
1 - 100 of 10038 matches
Mail list logo
