[GitHub] ctubbsii commented on issue #332: ACCUMULO-4826 Use the hadoop3 shaded jars
ctubbsii commented on issue #332: ACCUMULO-4826 Use the hadoop3 shaded jars URL: https://github.com/apache/accumulo/pull/332#issuecomment-368367685 @joshelser This PR is against the 1.8 branch already. I don't see any reason it should be merged only into master. It can go into the 1.8 branch so we can have some Hadoop 3 support for Accumulo 1.9.0. There's no real risk in 1.9.0, since these changes are only build tooling / packaging changes. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ctubbsii commented on issue #332: ACCUMULO-4826 Use the hadoop3 shaded jars
ctubbsii commented on issue #332: ACCUMULO-4826 Use the hadoop3 shaded jars URL: https://github.com/apache/accumulo/pull/332#issuecomment-368365644 > Let's tack this on as a follow-up. Agreed. > Oh, funny. I thought you were the proponent of it :) You may have gotten that impression because I'm against bundling. But, I'm also against using Hadoop's bundled libs for same reason I'm against bundling our own. I'm in favor of intentional and thoughtful dependency convergence, as a downstream activity. I'd actually prefer we not ship any binary tarball packaging... but since we do, we might as well do it in a way that works well for most users. In any case, I agree with you, this can be improved once we get the basics in. :smile_cat: This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ctubbsii commented on issue #332: ACCUMULO-4826 Use the hadoop3 shaded jars
ctubbsii commented on issue #332: ACCUMULO-4826 Use the hadoop3 shaded jars URL: https://github.com/apache/accumulo/pull/332#issuecomment-368346932 >> does Accumulo need recompiling or just repackaging to switch between Hadoop 2 and 3? > > I've not noticed any required recompilation. If no recompilation is needed, I wonder if it would be a good idea to just go ahead and build both assemblies, regardless of which profile is set? Or, if the hadoop3 assembly works fine with hadoop2, maybe we can just always build that one? (I never liked relying on picking up the libs shipped by Hadoop anyway.) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ctubbsii commented on issue #332: ACCUMULO-4826 Use the hadoop3 shaded jars
ctubbsii commented on issue #332: ACCUMULO-4826 Use the hadoop3 shaded jars URL: https://github.com/apache/accumulo/pull/332#issuecomment-368159110 We could update the travis configuration to execute once with hadoop2, and once with hadoop3. It'd be useful to see both. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
