[GitHub] milleruntime commented on issue #753: Improve new MapReduce API

2018-11-09 Thread GitBox
milleruntime commented on issue #753: Improve new MapReduce API URL: https://github.com/apache/accumulo/issues/753#issuecomment-437418398 > It is not clear whether they are set at the table level or the same auths were used for all scans, since they aren't a part of InputTableConfig

[GitHub] milleruntime commented on issue #753: Improve new MapReduce API

2018-11-09 Thread GitBox
milleruntime commented on issue #753: Improve new MapReduce API URL: https://github.com/apache/accumulo/issues/753#issuecomment-437402982 I like ```configure()... store(job)``` It is shorter and makes more sense than `build()` or `done()`. I was thinking something similar for mutli

[GitHub] milleruntime commented on issue #753: Improve new MapReduce API

2018-11-08 Thread GitBox
milleruntime commented on issue #753: Improve new MapReduce API URL: https://github.com/apache/accumulo/issues/753#issuecomment-437177380 I was planning on performing the serialization of all the options into the configuration on the last method. So we could do something like:

[GitHub] milleruntime commented on issue #753: Improve new MapReduce API

2018-11-08 Thread GitBox
milleruntime commented on issue #753: Improve new MapReduce API URL: https://github.com/apache/accumulo/issues/753#issuecomment-437167347 Another thing to take into consideration is allowing multi table options for completing #749

[GitHub] milleruntime commented on issue #753: Improve new MapReduce API

2018-11-08 Thread GitBox
milleruntime commented on issue #753: Improve new MapReduce API URL: https://github.com/apache/accumulo/issues/753#issuecomment-437159568 @ctubbsii @keith-turner What do you think of this for the API?