[jira] [Commented] (ACCUMULO-4468) accumulo.core.data.Key.equals(Key, PartialKey) improvement

2016-10-20 Thread Keith Turner (JIRA)
[ https://issues.apache.org/jira/browse/ACCUMULO-4468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15592497#comment-15592497 ] Keith Turner commented on ACCUMULO-4468: i am in favor of merging this in >

[jira] [Commented] (ACCUMULO-4468) accumulo.core.data.Key.equals(Key, PartialKey) improvement

2016-10-20 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/ACCUMULO-4468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15592208#comment-15592208 ] Josh Elser commented on ACCUMULO-4468: -- [~kturner], what do you think we should do here? >

[jira] [Commented] (ACCUMULO-4468) accumulo.core.data.Key.equals(Key, PartialKey) improvement

2016-09-22 Thread Keith Turner (JIRA)
[ https://issues.apache.org/jira/browse/ACCUMULO-4468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15513616#comment-15513616 ] Keith Turner commented on ACCUMULO-4468: The network code uses the

[jira] [Commented] (ACCUMULO-4468) accumulo.core.data.Key.equals(Key, PartialKey) improvement

2016-09-22 Thread Keith Turner (JIRA)
[ https://issues.apache.org/jira/browse/ACCUMULO-4468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15513602#comment-15513602 ] Keith Turner commented on ACCUMULO-4468: bq. That said, maybe there would be benefits to

[jira] [Commented] (ACCUMULO-4468) accumulo.core.data.Key.equals(Key, PartialKey) improvement

2016-09-22 Thread Will Murnane (JIRA)
[ https://issues.apache.org/jira/browse/ACCUMULO-4468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15513435#comment-15513435 ] Will Murnane commented on ACCUMULO-4468: [~elserj] I'm not sure why customVanilla and

[jira] [Commented] (ACCUMULO-4468) accumulo.core.data.Key.equals(Key, PartialKey) improvement

2016-09-21 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/ACCUMULO-4468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15511949#comment-15511949 ] Josh Elser commented on ACCUMULO-4468: -- Reran Will's original test and can vouch for the results.

[jira] [Commented] (ACCUMULO-4468) accumulo.core.data.Key.equals(Key, PartialKey) improvement

2016-09-21 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/ACCUMULO-4468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15511430#comment-15511430 ] Josh Elser commented on ACCUMULO-4468: -- Looking at the repo, it's important that the code is not

[jira] [Commented] (ACCUMULO-4468) accumulo.core.data.Key.equals(Key, PartialKey) improvement

2016-09-21 Thread Keith Turner (JIRA)
[ https://issues.apache.org/jira/browse/ACCUMULO-4468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15511418#comment-15511418 ] Keith Turner commented on ACCUMULO-4468: [~wmurnane] I like the change. I wrote the comment

[jira] [Commented] (ACCUMULO-4468) accumulo.core.data.Key.equals(Key, PartialKey) improvement

2016-09-21 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/ACCUMULO-4468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15511398#comment-15511398 ] Josh Elser commented on ACCUMULO-4468: -- Great stuff, [~wmurnane]! A few thoughts: bq. the

[jira] [Commented] (ACCUMULO-4468) accumulo.core.data.Key.equals(Key, PartialKey) improvement

2016-09-21 Thread Will Murnane (JIRA)
[ https://issues.apache.org/jira/browse/ACCUMULO-4468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15511154#comment-15511154 ] Will Murnane commented on ACCUMULO-4468: Responding to [~ctubbsii]'s points first: # Most

[jira] [Commented] (ACCUMULO-4468) accumulo.core.data.Key.equals(Key, PartialKey) improvement

2016-09-21 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/ACCUMULO-4468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15510743#comment-15510743 ] Josh Elser commented on ACCUMULO-4468: -- {quote} bq.Do you have other examples of where this

[jira] [Commented] (ACCUMULO-4468) accumulo.core.data.Key.equals(Key, PartialKey) improvement

2016-09-21 Thread Christopher Tubbs (JIRA)
[ https://issues.apache.org/jira/browse/ACCUMULO-4468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15510736#comment-15510736 ] Christopher Tubbs commented on ACCUMULO-4468: - Hi [~wmurnane]. Thanks for the patch! After

[jira] [Commented] (ACCUMULO-4468) accumulo.core.data.Key.equals(Key, PartialKey) improvement

2016-09-21 Thread Will Murnane (JIRA)
[ https://issues.apache.org/jira/browse/ACCUMULO-4468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15510679#comment-15510679 ] Will Murnane commented on ACCUMULO-4468: bq. Do you have other examples of where this might be

[jira] [Commented] (ACCUMULO-4468) accumulo.core.data.Key.equals(Key, PartialKey) improvement

2016-09-21 Thread Josh Elser (JIRA)
[ https://issues.apache.org/jira/browse/ACCUMULO-4468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15510541#comment-15510541 ] Josh Elser commented on ACCUMULO-4468: -- Hi [~wmurnane]. Thanks for the patch. bq. This functions