Adam J Shook created ACCUMULO-4549:
--------------------------------------
Summary: Remove duplicate init functions in TabletBalancer
Key: ACCUMULO-4549
URL: https://issues.apache.org/jira/browse/ACCUMULO-4549
Project: Accumulo
Issue Type: Improvement
Reporter: Adam J Shook
Priority: Minor
There are two {{init}} functions with similar signatures in the
{{TabletLoadBalancer}} class that could result in an end-user overriding the
wrong function and their object may never be initialized.
{{Master}} (1) calls the {{TabletBalancer#init(ServerConfigurationFactory)}}
which is not what the regex load balancer is overriding (2), and the
{{TabletBalancer}} doesn't call the other init function (3).
Come up with a plan for compatibility and remove the duplicate functions.
(1)
https://github.com/apache/accumulo/blob/1.7/server/master/src/main/java/org/apache/accumulo/master/Master.java#L589
(2)
https://github.com/apache/accumulo/blob/1.7/server/base/src/main/java/org/apache/accumulo/server/master/balancer/HostRegexTableLoadBalancer.java#L257
(3)
https://github.com/apache/accumulo/blob/1.7/server/base/src/main/java/org/apache/accumulo/server/master/balancer/TabletBalancer.java#L57
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
