[ 
https://issues.apache.org/jira/browse/IVYDE-64?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nicolas Lalevée updated IVYDE-64:
---------------------------------

    Attachment: IVYDE-64-r600683.patch

So here is a new patch. So as discussed, the {{usePreviousResolveIfExist}} 
check is kept.  And there is still in the patch the eviction of parsing the 
report if we already have the artifacts.
I think I have mostly made the code simpler to understand. The functionnalites 
of the code are all here, even some error handling (parsing and IO exception 
which is fallbacking to a complete resolve).
I also included in that patch a little part of the patch of IVYDE-43 : use the 
IClasspathEntry more than the inner ClasspathItem class.
Then the patch may appear quite big. But I am not sure what the indentation 
convention are here. I know there is a migration in progress (IVY-511), but the 
convention doesn't specify if we should use spaces or tabs. I personnaly 
prefers spaces, so I used them. Editing with eclipse, it did some strange mix, 
but I tried to not make the patch appears as a complete diff.

I have tested this patch with some ivy-aware project, it works fine.



> Simplify the resolve process
> ----------------------------
>
>                 Key: IVYDE-64
>                 URL: https://issues.apache.org/jira/browse/IVYDE-64
>             Project: IvyDE
>          Issue Type: Improvement
>          Components: classpath container
>    Affects Versions: 1.3.0
>         Environment: trunk r595956
>            Reporter: Nicolas Lalevée
>         Attachments: IVYDE-64-r595956.patch, IVYDE-64-r600683.patch
>
>
> The current trunk, the resolve job is first checking manually if the artifact 
> has already been resolved. If not in cache, it let ivy resolve it. And 
> finally it parses the xml reports in the cache.
> So first, as far as I have understood, the manual checking against the cache 
> is not needed, ivy already does it.
> And then ivy produce in Java some resolve report that already contain every 
> needed information, there is no need to parse the reports in cache.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to