[Bug 63259] [PATCH] FTP symlinks are checked twice
https://bz.apache.org/bugzilla/show_bug.cgi?id=63259 Eugène Adell changed: What|Removed |Added Summary|[PATCH] FTP directories are |[PATCH] FTP symlinks are |checked twice |checked twice -- You are receiving this mail because: You are the assignee for the bug.
[Bug 63259] FTP directories are checked twice
https://bz.apache.org/bugzilla/show_bug.cgi?id=63259 --- Comment #1 from Eugène Adell --- Created attachment 36482 --> https://bz.apache.org/bugzilla/attachment.cgi?id=36482=edit patch patch which removes the double check to determine whether it is a directory or a file the network capture now looks like this : 19:45:34.367012 IP 4.31.198.44.21 > 185.47.63.113.54409: Flags [P.], seq 3779:3820, ack 702, win 22, options [nop,nop,TS val 134018688 ecr 2714840262], length 41 EH.]..@./.Zb...,./?q...h7..c... ..,.257 "/rfc/std" is the current directory 19:45:34.367628 IP 185.47.63.113.54409 > 4.31.198.44.21: Flags [P.], seq 702:722, ack 3820, win 140, options [nop,nop,TS val 2714840432 ecr 134018688], length 20 E..H.g@.@..\./?q...,7..c... ..-pCWD ../rfc7011.txt 19:45:34.537721 IP 4.31.198.44.21 > 185.47.63.113.54409: Flags [P.], seq 3820:3867, ack 722, win 22, options [nop,nop,TS val 134018730 ecr 2714840432], length 47 EH.c..@./.Z[...,./?q7..w... ..-p550 ../rfc7011.txt: No such file or directory 19:45:34.538756 IP 185.47.63.113.54409 > 4.31.198.44.21: Flags [P.], seq 722:727, ack 3867, win 140, options [nop,nop,TS val 2714840603 ecr 134018730], length 5 E..9.h@.@..j./?q...,7..weT. PWD 19:45:34.708577 IP 4.31.198.44.21 > 185.47.63.113.54409: Flags [P.], seq 3867:3908, ack 727, win 22, options [nop,nop,TS val 134018773 ecr 2714840603], length 41 EH.]..@./.Z`...,./?q7..|... 257 "/rfc/std" is the current directory 19:45:34.709179 IP 185.47.63.113.54409 > 4.31.198.44.21: Flags [P.], seq 727:747, ack 3908, win 140, options [nop,nop,TS val 2714840773 ecr 134018773], length 20 E..H.i@.@..Z./?q...,7..|... CWD ../rfc7296.txt -- You are receiving this mail because: You are the assignee for the bug.
[Bug 63259] [PATCH] FTP directories are checked twice
https://bz.apache.org/bugzilla/show_bug.cgi?id=63259 Eugène Adell changed: What|Removed |Added Summary|FTP directories are checked |[PATCH] FTP directories are |twice |checked twice -- You are receiving this mail because: You are the assignee for the bug.
[Bug 63259] New: FTP directories are checked twice
https://bz.apache.org/bugzilla/show_bug.cgi?id=63259
Bug ID: 63259
Summary: FTP directories are checked twice
Product: Ant
Version: 1.10.5
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P2
Component: Optional Tasks
Assignee: notifications@ant.apache.org
Reporter: eugene.ad...@gmail.com
Target Milestone: ---
When running FTP task to list files, the directories are checked twice. This is
not necessary and has a negative impact on performance.
This happens because the current code checks if an entry (of the list) is a
directory, and if it is not it then tries to determine if this is a file by -
again - checking if it is not a directory.
The network capture then looks like this, for example with two "rfc7296.txt: No
such file or directory" :
19:48:21.101597 IP 4.31.198.44.21 > 185.47.63.113.54412: Flags [P.], seq
5804:5845, ack 1278, win 22, options [nop,nop,TS val 134060372 ecr 2715006999],
length 41
EH.]..@./..,./?q6.Z.'.:]m..
...T257 "/rfc/std" is the current directory
19:48:21.101958 IP 185.47.63.113.54412 > 4.31.198.44.21: Flags [P.], seq
1278:1298, ack 5845, win 140, options [nop,nop,TS val 2715007166 ecr
134060372], length 20
E..HE,@.@.2../?q...,'.:]6.Z.~..
...TCWD ../rfc7296.txt
19:48:21.268070 IP 4.31.198.44.21 > 185.47.63.113.54412: Flags [P.], seq
5845:5892, ack 1298, win 22, options [nop,nop,TS val 134060414 ecr 2715007166],
length 47
EH.c..@./..,./?q6.Z.'.:q...
...~550 ../rfc7296.txt: No such file or directory
19:48:21.268350 IP 185.47.63.113.54412 > 4.31.198.44.21: Flags [P.], seq
1298:1303, ack 5892, win 140, options [nop,nop,TS val 2715007333 ecr
134060414], length 5
E..9E-@.@.2../?q...,'.:q6.[.OY.
...e...~PWD
19:48:21.415135 IP 4.31.198.44.21 > 185.47.63.113.54412: Flags [P.], seq
5892:5933, ack 1303, win 22, options [nop,nop,TS val 134060455 ecr 2715007333],
length 41
EH.]..@./..,./?q6.[.'.:vk..
...e257 "/rfc/std" is the current directory
19:48:21.415478 IP 185.47.63.113.54412 > 4.31.198.44.21: Flags [P.], seq
1303:1323, ack 5933, win 140, options [nop,nop,TS val 2715007480 ecr
134060455], length 20
E..HE.@.@.2../?q...,'.:v6.[*|..
CWD ../rfc7296.txt
19:48:21.563730 IP 4.31.198.44.21 > 185.47.63.113.54412: Flags [P.], seq
5933:5980, ack 1323, win 22, options [nop,nop,TS val 134060492 ecr 2715007480],
length 47
EH.c..@./..,./?q6.[*'.:
550 ../rfc7296.txt: No such file or directory
19:48:21.564411 IP 185.47.63.113.54412 > 4.31.198.44.21: Flags [P.], seq
1323:1328, ack 5980, win 140, options [nop,nop,TS val 2715007629 ecr
134060492], length 5
E..9E/@.@.2../?q...,'.:.6.[YMr.
PWD
19:48:21.711083 IP 4.31.198.44.21 > 185.47.63.113.54412: Flags [P.], seq
5980:6021, ack 1328, win 22, options [nop,nop,TS val 134060529 ecr 2715007629],
length 41
EH.]..@./..,./?q6.[Y'.:.j..
257 "/rfc/std" is the current directory
19:48:21.711398 IP 185.47.63.113.54412 > 4.31.198.44.21: Flags [P.], seq
1328:1346, ack 6021, win 140, options [nop,nop,TS val 2715007776 ecr
134060529], length 18
E..FE0@.@.2../?q...,'.:.6.[..E.
... CWD ../rfc20.txt
example target is :
output is
listingWithSymlinks:
[ftp] Opening FTP connection to ftp.ietf.org
[ftp] connected
[ftp] logging in to FTP server
[ftp] login succeeded
[ftp] changing the remote directory to /rfc/std
[ftp] listing files
fileset: Setup scanner in dir /home/eadell/tests/ftpant with patternSet{
includes: [*] excludes: [] }
[ftp] 92 files listed
[ftp] disconnecting
BUILD SUCCESSFUL
Total time: 1 minute 19 seconds
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 63259] FTP directories are checked twice
https://bz.apache.org/bugzilla/show_bug.cgi?id=63259 Eugène Adell changed: What|Removed |Added CC||eugene.ad...@gmail.com -- You are receiving this mail because: You are the assignee for the bug.
svn commit: r32887 - in /dev/ant: ./ binaries/ manual/ source/
Author: jaikiran Date: Tue Mar 12 09:30:39 2019 New Revision: 32887 Log: Release RC1 of 1.9.14 version of Ant Added: dev/ant/README.html (with props) dev/ant/RELEASE-NOTES-1.9.14.html (with props) dev/ant/binaries/apache-ant-1.9.14-bin.tar.bz2 (with props) dev/ant/binaries/apache-ant-1.9.14-bin.tar.bz2.asc dev/ant/binaries/apache-ant-1.9.14-bin.tar.bz2.sha1 dev/ant/binaries/apache-ant-1.9.14-bin.tar.bz2.sha512 dev/ant/binaries/apache-ant-1.9.14-bin.tar.gz (with props) dev/ant/binaries/apache-ant-1.9.14-bin.tar.gz.asc dev/ant/binaries/apache-ant-1.9.14-bin.tar.gz.sha1 dev/ant/binaries/apache-ant-1.9.14-bin.tar.gz.sha512 dev/ant/binaries/apache-ant-1.9.14-bin.zip (with props) dev/ant/binaries/apache-ant-1.9.14-bin.zip.asc dev/ant/binaries/apache-ant-1.9.14-bin.zip.sha1 dev/ant/binaries/apache-ant-1.9.14-bin.zip.sha512 dev/ant/manual/apache-ant-1.9.14-manual.tar.bz2 (with props) dev/ant/manual/apache-ant-1.9.14-manual.tar.bz2.asc dev/ant/manual/apache-ant-1.9.14-manual.tar.bz2.sha1 dev/ant/manual/apache-ant-1.9.14-manual.tar.bz2.sha512 dev/ant/manual/apache-ant-1.9.14-manual.tar.gz (with props) dev/ant/manual/apache-ant-1.9.14-manual.tar.gz.asc dev/ant/manual/apache-ant-1.9.14-manual.tar.gz.sha1 dev/ant/manual/apache-ant-1.9.14-manual.tar.gz.sha512 dev/ant/manual/apache-ant-1.9.14-manual.zip (with props) dev/ant/manual/apache-ant-1.9.14-manual.zip.asc dev/ant/manual/apache-ant-1.9.14-manual.zip.sha1 dev/ant/manual/apache-ant-1.9.14-manual.zip.sha512 dev/ant/source/apache-ant-1.9.14-src.tar.bz2 (with props) dev/ant/source/apache-ant-1.9.14-src.tar.bz2.asc dev/ant/source/apache-ant-1.9.14-src.tar.bz2.sha1 dev/ant/source/apache-ant-1.9.14-src.tar.bz2.sha512 dev/ant/source/apache-ant-1.9.14-src.tar.gz (with props) dev/ant/source/apache-ant-1.9.14-src.tar.gz.asc dev/ant/source/apache-ant-1.9.14-src.tar.gz.sha1 dev/ant/source/apache-ant-1.9.14-src.tar.gz.sha512 dev/ant/source/apache-ant-1.9.14-src.zip (with props) dev/ant/source/apache-ant-1.9.14-src.zip.asc dev/ant/source/apache-ant-1.9.14-src.zip.sha1 dev/ant/source/apache-ant-1.9.14-src.zip.sha512 Added: dev/ant/README.html == --- dev/ant/README.html (added) +++ dev/ant/README.html Tue Mar 12 09:30:39 2019 @@ -0,0 +1,61 @@ + + + Release Notes of Apache Ant 1.9.14 + + +Changes from Ant 1.9.13 TO Ant 1.9.14 += + +Changes that could break older environments: +--- + + * ClearCase#runS has been augmented by a two arg-version and the + one-arg version will no longer be called. This may affect + subclasses that have overridden runS. + +Fixed bugs: +--- + + * fetch.xml must retrieve runtime rather than compile dependencies for + mail task. + Bugzilla Report 62621 + + * augment task now throws a BuildException (as noted in its manual) + instead of a IllegalStateException in the absence of the "id" attribute. + Bugzilla Report 62655 + + * org.apache.tools.zip.ZipOutputStream would sometimes potentially use + an incorrect compression level for a zip entry. This is now fixed. + Bugzilla Report 62686 + + * cccheckout would ignore an error of the "ls checkout" command even + if failOnError was set to false. + Bugzilla Report 63071 + +Other changes: +-- + * generatekey task now supports SubjectAlternativeName during key + generation. + + * the modified> selector has a new built-in algorithm 'lastmodified' + which computes a value based upon the lastmodified time of the file. + + * signjar and verifyjar now support the -providerName, -providerClass + and -providerArg command line options of keytool via new attributes. + Bugzilla Report 65234 + + * signjar and verifyjar now supported nested arg> elements for + command line arguments that are not supported explicitly by the + tasks via attributes. + + * added several attributes to javadoc> that support modules. + Bugzilla Report 62424 + + * Jsch library dependency has now been upgraded to 0.1.55. Jsch is + the library behind the sshexec and scp Ant tasks. + Github Pull Request #84 + + * ftp task manual has been updated to mention that the remote listing of + files honours the followsymlinks attribute. + Bugzilla Report 63226 + Propchange: dev/ant/README.html -- svn:eol-style = native Added: dev/ant/RELEASE-NOTES-1.9.14.html == --- dev/ant/RELEASE-NOTES-1.9.14.html (added) +++ dev/ant/RELEASE-NOTES-1.9.14.html Tue Mar 12 09:30:39 2019 @@ -0,0 +1,61 @@ + + + Release Notes of Apache Ant 1.9.14 + + +Changes from Ant 1.9.13 TO Ant 1.9.14 += +
[ant] branch master updated (1c97966 -> 1e00d44)
This is an automated email from the ASF dual-hosted git repository. jhm pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/ant.git. from 1c97966 htmlcheck: generate report file, consistent property names, meaningful target name new e2b40e5 htmlcheck: correct tool name, consistent report placement new 978e8b4 missing dots new 1e00d44 extract 'report.dir' The 3 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: check.xml | 37 + 1 file changed, 21 insertions(+), 16 deletions(-)
[ant] 01/03: htmlcheck: correct tool name, consistent report placement
This is an automated email from the ASF dual-hosted git repository.
jhm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ant.git
commit e2b40e5dd384af9f6844b1c67590d86b0381f26b
Author: twogee
AuthorDate: Sun Mar 10 07:05:29 2019 +0100
htmlcheck: correct tool name, consistent report placement
---
check.xml | 20 +++-
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a/check.xml b/check.xml
index c0bcd9d..4c14c21 100644
--- a/check.xml
+++ b/check.xml
@@ -19,7 +19,8 @@
Check Ant codebase against certain code style guidelines using
-Checkstyle, Apache Rat, SpotBugs, OWASP Dependency Check and Simian.
+Checkstyle, Apache Rat, SpotBugs, OWASP Dependency Check, Simian
+and Nu Html Checker (v.Nu).
Checkstyle uses an abstract syntax tree (AST) for doing checks
against Java sources. It is available at http://checkstyle.sourceforge.net/
@@ -41,8 +42,9 @@
plain text files." It is available at https://www.harukizaemon.com/simian/
and is for free use in open source projects.
-Nu HTML Validator by Mozilla Foundation checks html files against HTML5
-specs and recommendations.
+"The Nu Html Checker (v.Nu) is the backend of checker.html5.org,
+html5.validator.nu, and validator.w3.org/nu." It is available at
+https://validator.github.io/validator/ under MIT license.
See external task page and homepages for more information.
@@ -120,7 +122,7 @@
value="${build.dir}/simian-lib"
description="Where to store Simian resources"/>
@@ -131,12 +133,12 @@
value="${build.dir}/reports/owasp-dc"
description="Where to store the OWASP Dependency Check reports"/>
-
+
+description="Which version of Nu Html Checker to use"/>
-
+
@@ -327,7 +329,7 @@
-
+
[ant] 03/03: extract 'report.dir'
This is an automated email from the ASF dual-hosted git repository. jhm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/ant.git commit 1e00d447d2a250a4e0581e010cf83b72a31abc7e Author: Jan Matèrne AuthorDate: Tue Mar 12 10:00:20 2019 +0100 extract 'report.dir' --- check.xml | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/check.xml b/check.xml index 185e023..7d1a901 100644 --- a/check.xml +++ b/check.xml @@ -50,15 +50,18 @@ + - + @@ -130,7 +133,7 @@ value="3.2.1" description="Which version of OWASP Dependency Check to use"/> @@ -138,7 +141,7 @@ value="18.11.5" description="Which version of Nu Html Checker to use"/>
[ant] 02/03: missing dots
This is an automated email from the ASF dual-hosted git repository. jhm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/ant.git commit 978e8b4677a4d56f30b462cba9cb85718626d956 Author: Jan Matèrne AuthorDate: Tue Mar 12 09:57:27 2019 +0100 missing dots --- check.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/check.xml b/check.xml index 4c14c21..185e023 100644 --- a/check.xml +++ b/check.xml @@ -27,7 +27,7 @@ under GPL 2.1 license. "Apache Rat is a release audit tool, focused on licenses." It is available -at https://creadur.apache.org/rat/ under Apache License, Version 2.0 +at https://creadur.apache.org/rat/ under Apache License, Version 2.0. "SpotBugs is a program which uses static analysis to look for bugs in Java code." It is available at https://spotbugs.github.io/ under LGPL 3 license. @@ -35,7 +35,7 @@ "Dependency-Check is a utility that identifies project dependencies and checks if there are any known, publicly disclosed, vulnerabilities." It is available at https://www.owasp.org/index.php/OWASP_Dependency_Check under -Apache License, Version 2.0 +Apache License, Version 2.0. "Simian (Similarity Analyser) identifies duplication in Java, C#, C, CPP, COBOL, Ruby, JSP, ASP, HTML, XML, Visual Basic, Groovy source code and even
[ant] annotated tag ANT_1914_RC1 created (now c26ea82)
This is an automated email from the ASF dual-hosted git repository. jaikiran pushed a change to annotated tag ANT_1914_RC1 in repository https://gitbox.apache.org/repos/asf/ant.git. at c26ea82 (tag) tagging 8ec8ecf4eb94b238b09161055e75508155040180 (commit) replaces rel/1.9.12 by Jaikiran Pai on Tue Mar 12 14:35:59 2019 +0530 - Log - Tagging RC1 for version 1.9.14 of Ant -BEGIN PGP SIGNATURE- iQIzBAABCAAdFiEEjacMAN968bDS+dx03bzBJwop0IEFAlyHdncACgkQ3bzBJwop 0IEICQ//dXXMMAo9w7O9zgn2spXWTKEKyH1KtZPKgiTGRdvWpzj0rxb0m7++JEfC GPTGymTBLhc1wPkje1dFl0vjUJUZwD9HikwDX0cqYmQ27nIGz61wgjfB0ImzeGVl DP8NH2XverkEjMLeDOdmcTVt/xvGPwNEt91Mr46Jip1OrNe+BJAMIpeSftkRly/9 TWDPX089FHfnUpIYiRksSFnhvPg1o87rHsr0Mr/TYS4i8ZOE0rJV16TnOga6kuds D1HYHSCrvcbHRB0cCNb/z2Sd06lkTILfpaX6tEcFurRPw96OXhwYvYc/d7Nd28HH mnOR+3PFu/6K/hY14YSHzPdrkL9DmBDYeI6hQvLfSmYOOn1HByb+qReGOMALJKgc 6WN6z/IcOau9bZZU6SCGaLcpyXjdhm9CZzh2flTTtSfGAM90q9CXQ/lFGUcHiPfg VAxJA6daZIENoCFS5/Jbl7ss08ZNMadX+9wsd30kd51YuXOMotBp7Pg/gV5+wVMb G7brPmWOOmgHuRn4jj1kBaUg4DrRtNKZaEPOthgzIz1+1PWdRPlxjVXl0XRWTuBq GEYn+yoRR2PWbs7avhwPI4WRDY276gMNNCiWXarJRhqI+yWsQMaMp3A5LvTGf+EE fzYFEt8nRh3kMg9GwvlydvRHS9cWoHJMqx1bYpizpecb2aGEYoc= =f4rV -END PGP SIGNATURE- --- This annotated tag includes the following new commits: new 8ec8ecf Release RC1 of 1.9.14 The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference.
