This is an automated email from the ASF dual-hosted git repository. jaikiran pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/ant.git
The following commit(s) were added to refs/heads/master by this push: new 52fa95523 bz-66164 Don't change file permissions on unrelated files in dest directory, when building and copying over Ant distribution 52fa95523 is described below commit 52fa955239c00ae00f03354a2c6145730325a5f2 Author: Jaikiran Pai <jaiki...@apache.org> AuthorDate: Thu Aug 18 19:10:13 2022 +0530 bz-66164 Don't change file permissions on unrelated files in dest directory, when building and copying over Ant distribution --- WHATSNEW | 6 ++++++ build.xml | 16 ---------------- manual/install.html | 1 + 3 files changed, 7 insertions(+), 16 deletions(-) diff --git a/WHATSNEW b/WHATSNEW index c684322bd..c0fe5ea7d 100644 --- a/WHATSNEW +++ b/WHATSNEW @@ -33,6 +33,12 @@ Fixed bugs: failed to download JAI. Github Pull Request #191 + * When building and installing Ant distribution from source, the build script + would change permissions on unrelated files in the destination directory. + This is now fixed and such unrelated files in the destination directory + will be left untouched. + Bugzilla Report 66164 + Other changes: -------------- diff --git a/build.xml b/build.xml index 8d401aac7..48378b078 100644 --- a/build.xml +++ b/build.xml @@ -1057,14 +1057,6 @@ <include name="*.pl"/> </fixcrlf> - <setpermissions mode="755" failonerror="${setpermissions.fail}" - nonPosixMode="${setpermissions.nonposixmode}"> - <dirset dir="${dist.dir}"/> - </setpermissions> - <setpermissions mode="644" failonerror="${setpermissions.fail}" - nonPosixMode="${setpermissions.nonposixmode}"> - <fileset dir="${dist.dir}"/> - </setpermissions> <setpermissions mode="755" failonerror="${setpermissions.fail}" nonPosixMode="${setpermissions.nonposixmode}"> <fileset dir="${dist.bin}"> @@ -1158,14 +1150,6 @@ </fileset> </copy> - <setpermissions mode="755" failonerror="${setpermissions.fail}" - nonPosixMode="${setpermissions.nonposixmode}"> - <dirset dir="${dist.dir}"/> - </setpermissions> - <setpermissions mode="644" failonerror="${setpermissions.fail}" - nonPosixMode="${setpermissions.nonposixmode}"> - <fileset dir="${dist.dir}"/> - </setpermissions> <setpermissions mode="755" failonerror="${setpermissions.fail}" nonPosixMode="${setpermissions.nonposixmode}"> <fileset dir="${dist.bin}"> diff --git a/manual/install.html b/manual/install.html index c959dbe9e..1aef1c709 100644 --- a/manual/install.html +++ b/manual/install.html @@ -697,6 +697,7 @@ from <a href="https://junit.org/" target="_top">JUnit.org</a>) if you are using Your are now ready to build Ant: </p> <blockquote> + <b>It is highly recommended that the directory path that you pass to dist.dir, in the following commands, points to an empty directory</b> <p><kbd>build -Ddist.dir=<<i>directory-to-contain-Ant-distribution</i>> dist</kbd> (<em>Windows</em>)</p> <p><kbd>sh build.sh -Ddist.dir=<<i>directory-to-contain-Ant-distribution</i>> dist</kbd> (<em>Unix</em>)</p> </blockquote>