[jira] Commented: (IVYDE-68) IvyDE is using some internal classes of Eclipse
[
https://issues.apache.org/jira/browse/IVYDE-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12556552#action_12556552
]
Nicolas Lalevée commented on IVYDE-68:
--
OK I see the issue, the UI is effectively not very clear. It seems that the
eclipse developer didn't see the real issue here, maybe he didn't read your
last comment ?
About letting the fix into IvyDE, I see no reason to not have this kind of
eclipse internal fix within the plugin. But it seems wrong to have the plugin
only target 3.2. Maybe you could create another plugin
org.apache.ivy.eclipse.javasearchfix that could be downloaded within the IvyDE
update site, with as many version as there are tagetted eclipse version.
IvyDE is using some internal classes of Eclipse
---
Key: IVYDE-68
URL: https://issues.apache.org/jira/browse/IVYDE-68
Project: IvyDE
Issue Type: Bug
Affects Versions: 1.3.0
Reporter: Nicolas Lalevée
Attachments: IVYDE-68-r607532.patch, ivyde.diff
Some classes in IvyDE use come classes which are in some
{{org.eclipseinternal... }} packages, which should not be used. Compiling
IvyDE with Eclipse 3.3 raise warning like :
{quote}
Discouraged access: The method containerPut(IJavaProject, IPath,
IClasspathContainer) from the type JavaModelManager is not accessible due to
restriction on required library
/Users/nicolas/tools/eclipse-3.3/plugins/org.eclipse.jdt.core_3.3.1.v_780_R33x.jar
ivyde/src/java/org/apache/ivyde/eclipse/cpcontainer
IvyClasspathContainer.java {quote}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (IVYDE-68) IvyDE is using some internal classes of Eclipse
[
https://issues.apache.org/jira/browse/IVYDE-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12556559#action_12556559
]
Xavier Hanin commented on IVYDE-68:
---
Yes, it's good idea, but it would mean more maintenance effort, and we are
already a little bit short for IvyDE core, so I guess we will remove this for
the moment, and if somebody in the eclipse community wants/need to provide a
plugin like this it will be very welcome :-)
IvyDE is using some internal classes of Eclipse
---
Key: IVYDE-68
URL: https://issues.apache.org/jira/browse/IVYDE-68
Project: IvyDE
Issue Type: Bug
Affects Versions: 1.3.0
Reporter: Nicolas Lalevée
Attachments: IVYDE-68-r607532.patch, ivyde.diff
Some classes in IvyDE use come classes which are in some
{{org.eclipseinternal... }} packages, which should not be used. Compiling
IvyDE with Eclipse 3.3 raise warning like :
{quote}
Discouraged access: The method containerPut(IJavaProject, IPath,
IClasspathContainer) from the type JavaModelManager is not accessible due to
restriction on required library
/Users/nicolas/tools/eclipse-3.3/plugins/org.eclipse.jdt.core_3.3.1.v_780_R33x.jar
ivyde/src/java/org/apache/ivyde/eclipse/cpcontainer
IvyClasspathContainer.java {quote}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (IVYDE-68) IvyDE is using some internal classes of Eclipse
[
https://issues.apache.org/jira/browse/IVYDE-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1218#action_1218
]
Xavier Hanin commented on IVYDE-68:
---
@Nicolas:
I've applied your patch with some modifications:
- in IvyClasspathContainer, I've only applied the change about the usage of
internal eclipse classes, since I already did the change for the cache
management myself. BTW, I'm impressed how fast you catch up with the cache
management changes in Ivy!
- in IvydeContainerPage, I had to make minor changes to how Status object are
created/obtained, to make it compatible with eclipse 3.2
That's all, thanks a lot for this worthy and very clean contribution!
@Markus:
Thanks for your contribution, but I can't review your patch easily, too much
diff. This is probably due to changes in white space chars, could you try to
update to latest version and make only the change you did?
@all:
The FixedJavaSearchPage is a problem to maintain, and since it has never been
documented and is probably not that much useful, I think we could remove it.
WDYT?
IvyDE is using some internal classes of Eclipse
---
Key: IVYDE-68
URL: https://issues.apache.org/jira/browse/IVYDE-68
Project: IvyDE
Issue Type: Bug
Affects Versions: 1.3.0
Reporter: Nicolas Lalevée
Attachments: IVYDE-68-r607532.patch, ivyde.diff
Some classes in IvyDE use come classes which are in some
{{org.eclipseinternal... }} packages, which should not be used. Compiling
IvyDE with Eclipse 3.3 raise warning like :
{quote}
Discouraged access: The method containerPut(IJavaProject, IPath,
IClasspathContainer) from the type JavaModelManager is not accessible due to
restriction on required library
/Users/nicolas/tools/eclipse-3.3/plugins/org.eclipse.jdt.core_3.3.1.v_780_R33x.jar
ivyde/src/java/org/apache/ivyde/eclipse/cpcontainer
IvyClasspathContainer.java {quote}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (IVYDE-68) IvyDE is using some internal classes of Eclipse
[
https://issues.apache.org/jira/browse/IVYDE-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12555023
]
Markus M. May commented on IVYDE-68:
I have editd this plugin, to support also the Eclipse 3.4 version. This patch
does include the previous patch as well.
The class FixedJavaSearchPage is a copy of the original file of eclipse and
then edited like the one stated above.
IvyDE is using some internal classes of Eclipse
---
Key: IVYDE-68
URL: https://issues.apache.org/jira/browse/IVYDE-68
Project: IvyDE
Issue Type: Bug
Affects Versions: 1.3.0
Reporter: Nicolas Lalevée
Attachments: IVYDE-68-r607532.patch
Some classes in IvyDE use come classes which are in some
{{org.eclipseinternal... }} packages, which should not be used. Compiling
IvyDE with Eclipse 3.3 raise warning like :
{quote}
Discouraged access: The method containerPut(IJavaProject, IPath,
IClasspathContainer) from the type JavaModelManager is not accessible due to
restriction on required library
/Users/nicolas/tools/eclipse-3.3/plugins/org.eclipse.jdt.core_3.3.1.v_780_R33x.jar
ivyde/src/java/org/apache/ivyde/eclipse/cpcontainer
IvyClasspathContainer.java {quote}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
