[GitHub] [incubator-apisix] moonming commented on issue #790: new plugin: data-validator

moonming commented on issue #790: new plugin: data-validator URL: https://github.com/apache/incubator-apisix/issues/790#issuecomment-549107224 ``` succ_code = 200 ``` I think we don't need `succ_code` This is an

[GitHub] [incubator-apisix] moonming commented on issue #790: new plugin: data-validator

moonming commented on issue #790: new plugin: data-validator URL: https://github.com/apache/incubator-apisix/issues/790#issuecomment-549107199 Is it support json schema v4 or v5? This is an automated message from the Apache

[GitHub] [incubator-apisix] moonming commented on a change in pull request #794: Feature prometheus

moonming commented on a change in pull request #794: Feature prometheus URL: https://github.com/apache/incubator-apisix/pull/794#discussion_r341835727 ## File path: lua/apisix/plugins/prometheus/exporter.lua ## @@ -21,6 +21,9 @@ local ngx_capture = ngx.location.capture

[GitHub] [incubator-apisix] moonming commented on a change in pull request #794: Feature prometheus

moonming commented on a change in pull request #794: Feature prometheus URL: https://github.com/apache/incubator-apisix/pull/794#discussion_r341835737 ## File path: lua/apisix/plugins/prometheus/exporter.lua ## @@ -44,26 +47,35 @@ function _M.init() -- per service

[GitHub] [incubator-apisix] lilien1010 commented on a change in pull request #775: bugfix: support more built-in parameters when set chash balancer

lilien1010 commented on a change in pull request #775: bugfix: support more built-in parameters when set chash balancer URL: https://github.com/apache/incubator-apisix/pull/775#discussion_r341833882 ## File path: doc/architecture-design-cn.md ## @@ -237,7 +237,7 @@ APISIX

[GitHub] [incubator-apisix] lyyoung commented on issue #794: Feature prometheus

lyyoung commented on issue #794: Feature prometheus URL: https://github.com/apache/incubator-apisix/pull/794#issuecomment-549022787 > Cod style, you can install luacheck and check it on your local machine: > > ```shell > [./lua/apisix/plugins/prometheus/exporter.lua]: >

[GitHub] [incubator-apisix] membphis commented on issue #794: Feature prometheus

membphis commented on issue #794: Feature prometheus URL: https://github.com/apache/incubator-apisix/pull/794#issuecomment-549018147 Cod style, you can install luacheck and check it on your local machine: ```shell [./lua/apisix/plugins/prometheus/exporter.lua]: 64: line

[GitHub] [incubator-apisix] lyyoung opened a new pull request #794: Feature prometheus

lyyoung opened a new pull request #794: Feature prometheus URL: https://github.com/apache/incubator-apisix/pull/794 [#792 ](https://github.com/apache/incubator-apisix/issues/792) This is an automated message from the Apache

[GitHub] [incubator-apisix] lyyoung closed pull request #793: Feature update prometheus

lyyoung closed pull request #793: Feature update prometheus URL: https://github.com/apache/incubator-apisix/pull/793 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-apisix] lyyoung opened a new pull request #793: Feature update prometheus

lyyoung opened a new pull request #793: Feature update prometheus URL: https://github.com/apache/incubator-apisix/pull/793 feature: [#792 ](https://github.com/apache/incubator-apisix/issues/792) This is an automated message

[GitHub] [incubator-apisix] lyyoung opened a new issue #792: Feature: Update prometheus plugin

lyyoung opened a new issue #792: Feature: Update prometheus plugin URL: https://github.com/apache/incubator-apisix/issues/792 The current Prometheus plug-in is relatively simple. According to the common business requirements, it is required to calculate the service-machine-level delay,