[GitHub] [incubator-apisix-dashboard] aimpsmile commented on issue #116: upstream page displays table error

2020-01-06 Thread GitBox
aimpsmile commented on issue #116: upstream page displays table error URL: https://github.com/apache/incubator-apisix-dashboard/issues/116#issuecomment-571453732 So good. now not problem This is an automated message from

[GitHub] [incubator-apisix-dashboard] aimpsmile closed issue #116: upstream page displays table error

2020-01-06 Thread GitBox
aimpsmile closed issue #116: upstream page displays table error URL: https://github.com/apache/incubator-apisix-dashboard/issues/116 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-apisix-dashboard] aimpsmile commented on issue #116: upstream page displays table error

2020-01-06 Thread GitBox
aimpsmile commented on issue #116: upstream page displays table error URL: https://github.com/apache/incubator-apisix-dashboard/issues/116#issuecomment-571452155 thanks. I have a try This is an automated message from the

[GitHub] [incubator-apisix-dashboard] juzhiyuan edited a comment on issue #116: upstream page displays table error

2020-01-06 Thread GitBox
juzhiyuan edited a comment on issue #116: upstream page displays table error URL: https://github.com/apache/incubator-apisix-dashboard/issues/116#issuecomment-571451817 [dashboard.tar.gz](https://github.com/apache/incubator-apisix-dashboard/files/4029142/dashboard.tar.gz) I just

[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on issue #116: upstream page displays table error

2020-01-06 Thread GitBox
juzhiyuan commented on issue #116: upstream page displays table error URL: https://github.com/apache/incubator-apisix-dashboard/issues/116#issuecomment-571451817 [dashboard.tar.gz](https://github.com/apache/incubator-apisix-dashboard/files/4029142/dashboard.tar.gz) You could use

[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on issue #116: upstream page displays table error

2020-01-06 Thread GitBox
juzhiyuan commented on issue #116: upstream page displays table error URL: https://github.com/apache/incubator-apisix-dashboard/issues/116#issuecomment-571451304 I see... I thought your question is why the browser is in Green background.. Please use the latest codes from master

[incubator-apisix-website] branch feature-release updated (b355279 -> e23891e)

2020-01-06 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch feature-release in repository https://gitbox.apache.org/repos/asf/incubator-apisix-website.git. from b355279 feat: added initial commit for releasing guide add e23891e feat: added

[GitHub] [incubator-apisix-dashboard] aimpsmile edited a comment on issue #116: upstream page displays table error

2020-01-06 Thread GitBox
aimpsmile edited a comment on issue #116: upstream page displays table error URL: https://github.com/apache/incubator-apisix-dashboard/issues/116#issuecomment-571440485 I add second node or more on upstreams are displays error,only one nodes displays no problem.

[GitHub] [incubator-apisix-dashboard] aimpsmile commented on issue #116: upstream page displays table error

2020-01-06 Thread GitBox
aimpsmile commented on issue #116: upstream page displays table error URL: https://github.com/apache/incubator-apisix-dashboard/issues/116#issuecomment-571440485 I add second node or more on upstreams are displays error,only one nodes displays not are problume .

[GitHub] [incubator-apisix-dashboard] aimpsmile commented on issue #116: upstream page displays table error

2020-01-06 Thread GitBox
aimpsmile commented on issue #116: upstream page displays table error URL: https://github.com/apache/incubator-apisix-dashboard/issues/116#issuecomment-571437875

[GitHub] [incubator-apisix-website] juzhiyuan opened a new pull request #15: feat: Release Guide

2020-01-06 Thread GitBox
juzhiyuan opened a new pull request #15: feat: Release Guide URL: https://github.com/apache/incubator-apisix-website/pull/15 resolve https://github.com/apache/incubator-apisix-website/issues/14 This is an automated message

[incubator-apisix-website] 01/01: feat: added initial commit for releasing guide

2020-01-06 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch feature-release in repository https://gitbox.apache.org/repos/asf/incubator-apisix-website.git commit b3552793695bdf109fb0b12af884fed9e00d281d Author: juzhiyuan AuthorDate: Tue Jan 7 12:09:50

[incubator-apisix-website] branch feature-release created (now b355279)

2020-01-06 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch feature-release in repository https://gitbox.apache.org/repos/asf/incubator-apisix-website.git. at b355279 feat: added initial commit for releasing guide This branch includes the

[GitHub] [incubator-apisix-dashboard] aimpsmile commented on issue #116: upstream page displays table error

2020-01-06 Thread GitBox
aimpsmile commented on issue #116: upstream page displays table error URL: https://github.com/apache/incubator-apisix-dashboard/issues/116#issuecomment-571422918 Ok. I do try This is an automated message from the Apache

[GitHub] [incubator-apisix-dashboard] juzhiyuan edited a comment on issue #116: upstream page displays table error

2020-01-06 Thread GitBox
juzhiyuan edited a comment on issue #116: upstream page displays table error URL: https://github.com/apache/incubator-apisix-dashboard/issues/116#issuecomment-571413076 I think the green background is related to some Chrome extensions, could you please have a try in Privacy mode? for no

[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on issue #116: upstream page displays table error

2020-01-06 Thread GitBox
juzhiyuan commented on issue #116: upstream page displays table error URL: https://github.com/apache/incubator-apisix-dashboard/issues/116#issuecomment-571413076 I think the green background is related to some Chrome extensions, could you please have a try on Privacy mode? for no

[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on issue #116: upstream page displays table error

2020-01-06 Thread GitBox
juzhiyuan commented on issue #116: upstream page displays table error URL: https://github.com/apache/incubator-apisix-dashboard/issues/116#issuecomment-571413151 ![image](https://user-images.githubusercontent.com/2106987/71865513-f451f780-313d-11ea-83d9-e11e7e6e3df8.png)

[incubator-apisix] 02/02: released new version 1.0

2020-01-06 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch v1.0 in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git commit 48ade0c67ae1e94129dec6df0002794605c803f7 Author: Yuansheng AuthorDate: Tue Jan 7 10:38:38 2020 +0800

[incubator-apisix] 01/02: doc: removed `rc1` version information.

2020-01-06 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch v1.0 in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git commit 3858c11bc32593a1422480d7e524e4038ee53c6a Author: Yuansheng AuthorDate: Tue Jan 7 10:37:36 2020 +0800

[incubator-apisix] branch v1.0 updated (cd041a1 -> 48ade0c)

2020-01-06 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a change to branch v1.0 in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git. from cd041a1 utils: added new tools to check apisix version. new 3858c11 doc: removed `rc1` version

[incubator-apisix] branch master updated (a5d6250 -> fba93d3)

2020-01-06 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git. from a5d6250 change: modified the SSL module from ffi to ngx.ssl (#1021) add fba93d3 plugin(JWT): JWT

[GitHub] [incubator-apisix] membphis merged pull request #1027: Jwt authentication plugin compatible with Bearer prefix

2020-01-06 Thread GitBox
membphis merged pull request #1027: Jwt authentication plugin compatible with Bearer prefix URL: https://github.com/apache/incubator-apisix/pull/1027 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-apisix] membphis closed issue #1026: bug: Jwt authentication plugin not comoatible that token without Bearer

2020-01-06 Thread GitBox
membphis closed issue #1026: bug: Jwt authentication plugin not comoatible that token without Bearer URL: https://github.com/apache/incubator-apisix/issues/1026 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-apisix] lilien1010 commented on a change in pull request #1027: Jwt authentication plugin compatible with Bearer prefix

2020-01-06 Thread GitBox
lilien1010 commented on a change in pull request #1027: Jwt authentication plugin compatible with Bearer prefix URL: https://github.com/apache/incubator-apisix/pull/1027#discussion_r363566591 ## File path: lua/apisix/plugins/jwt-auth.lua ## @@ -89,15 +90,19 @@ function

[GitHub] [incubator-apisix-dashboard] aimpsmile commented on issue #116: upstream page displays table error

2020-01-06 Thread GitBox
aimpsmile commented on issue #116: upstream page displays table error URL: https://github.com/apache/incubator-apisix-dashboard/issues/116#issuecomment-571400454

[GitHub] [incubator-apisix] membphis commented on issue #1025: request help: How to publish grayscale

2020-01-06 Thread GitBox
membphis commented on issue #1025: request help: How to publish grayscale URL: https://github.com/apache/incubator-apisix/issues/1025#issuecomment-571400513 Yes, that is a good way in APISIX . This is an automated message

[GitHub] [incubator-apisix] jiezaizone commented on issue #1025: request help: How to publish grayscale

2020-01-06 Thread GitBox
jiezaizone commented on issue #1025: request help: How to publish grayscale URL: https://github.com/apache/incubator-apisix/issues/1025#issuecomment-571396391 > The APISIX used `etcd` to store all of the route data. > > Why do you have to use Redis? I could use an etcd

[GitHub] [incubator-apisix-dashboard] todzhang commented on issue #117: add svg-icon support

2020-01-06 Thread GitBox
todzhang commented on issue #117: add svg-icon support URL: https://github.com/apache/incubator-apisix-dashboard/issues/117#issuecomment-571385321 [svgicon.zip](https://github.com/apache/incubator-apisix-dashboard/files/4028455/svgicon.zip) patch for svgicon

[GitHub] [incubator-apisix-dashboard] todzhang opened a new issue #117: add svg-icon support

2020-01-06 Thread GitBox
todzhang opened a new issue #117: add svg-icon support URL: https://github.com/apache/incubator-apisix-dashboard/issues/117 migrate code from vue-typescript-admin-template. So dashboard can display icons This is an automated

[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on issue #116: upstream page displays table error

2020-01-06 Thread GitBox
juzhiyuan commented on issue #116: upstream page displays table error URL: https://github.com/apache/incubator-apisix-dashboard/issues/116#issuecomment-571185314 Hi, I'd love to know which browser are you using? This is an

[GitHub] [incubator-apisix] agile6v commented on issue #962: feature: support showing apisix cluster node information

2020-01-06 Thread GitBox
agile6v commented on issue #962: feature: support showing apisix cluster node information URL: https://github.com/apache/incubator-apisix/pull/962#issuecomment-571181380 > @agile6v Of course, it can be implemented in `prometheus`. > >

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1027: Jwt authentication plugin compatible with Bearer prefix

2020-01-06 Thread GitBox
membphis commented on a change in pull request #1027: Jwt authentication plugin compatible with Bearer prefix URL: https://github.com/apache/incubator-apisix/pull/1027#discussion_r363326515 ## File path: lua/apisix/plugins/jwt-auth.lua ## @@ -89,15 +90,19 @@ function

[GitHub] [incubator-apisix] membphis commented on a change in pull request #976: Added password support for plugin limit-count-redis

2020-01-06 Thread GitBox
membphis commented on a change in pull request #976: Added password support for plugin limit-count-redis URL: https://github.com/apache/incubator-apisix/pull/976#discussion_r363323978 ## File path: t/plugin/limit-count-redis.t ## @@ -209,3 +212,69 @@ passed [404, 503,

[GitHub] [incubator-apisix] membphis commented on issue #1021: Modify the SSL module from ffi to ngx.ssl

2020-01-06 Thread GitBox
membphis commented on issue #1021: Modify the SSL module from ffi to ngx.ssl URL: https://github.com/apache/incubator-apisix/pull/1021#issuecomment-571164892 @xiaobiaozhao merged, many thx. This is an automated message from

[incubator-apisix] branch master updated (61727d4 -> a5d6250)

2020-01-06 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git. from 61727d4 feature: support regex_uri option in proxy-rewrite plugin (#979) add a5d6250 change:

[GitHub] [incubator-apisix] membphis merged pull request #1021: Modify the SSL module from ffi to ngx.ssl

2020-01-06 Thread GitBox
membphis merged pull request #1021: Modify the SSL module from ffi to ngx.ssl URL: https://github.com/apache/incubator-apisix/pull/1021 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-apisix] membphis commented on issue #1025: request help: How to publish grayscale

2020-01-06 Thread GitBox
membphis commented on issue #1025: request help: How to publish grayscale URL: https://github.com/apache/incubator-apisix/issues/1025#issuecomment-571164193 The APISIX used `etcd` to store all of the route data. Why do you have to use Redis?

[GitHub] [incubator-apisix-website] membphis commented on issue #14: doc: how to release a new version for PPMC

2020-01-06 Thread GitBox
membphis commented on issue #14: doc: how to release a new version for PPMC URL: https://github.com/apache/incubator-apisix-website/issues/14#issuecomment-571161316 related script: https://gist.github.com/membphis/7f5afa12e2bceb6231f41f88891a98c3

[GitHub] [incubator-apisix] agile6v commented on issue #962: feature: support showing apisix cluster node information

2020-01-06 Thread GitBox
agile6v commented on issue #962: feature: support showing apisix cluster node information URL: https://github.com/apache/incubator-apisix/pull/962#issuecomment-571134665 > @agile6v what's your opinion? @moonming I haven't figured out how to display the cluster information. This

[GitHub] [incubator-apisix] codjust commented on a change in pull request #1022: Feature/chash key support more flexible ways

2020-01-06 Thread GitBox
codjust commented on a change in pull request #1022: Feature/chash key support more flexible ways URL: https://github.com/apache/incubator-apisix/pull/1022#discussion_r363282685 ## File path: lua/apisix/admin/upstreams.lua ## @@ -45,23 +98,17 @@ local function

[GitHub] [incubator-apisix] moonming commented on a change in pull request #1022: Feature/chash key support more flexible ways

2020-01-06 Thread GitBox
moonming commented on a change in pull request #1022: Feature/chash key support more flexible ways URL: https://github.com/apache/incubator-apisix/pull/1022#discussion_r363280915 ## File path: t/admin/upstream.t ## @@ -980,3 +980,223 @@ GET /t passed --- no_error_log

[GitHub] [incubator-apisix] codjust commented on a change in pull request #1022: Feature/chash key support more flexible ways

2020-01-06 Thread GitBox
codjust commented on a change in pull request #1022: Feature/chash key support more flexible ways URL: https://github.com/apache/incubator-apisix/pull/1022#discussion_r363280855 ## File path: lua/apisix/admin/upstreams.lua ## @@ -28,6 +28,59 @@ local _M = { } +local

[GitHub] [incubator-apisix] codjust commented on a change in pull request #1022: Feature/chash key support more flexible ways

2020-01-06 Thread GitBox
codjust commented on a change in pull request #1022: Feature/chash key support more flexible ways URL: https://github.com/apache/incubator-apisix/pull/1022#discussion_r363278721 ## File path: lua/apisix/balancer.lua ## @@ -151,11 +184,11 @@ local function

[GitHub] [incubator-apisix] codjust commented on a change in pull request #1022: Feature/chash key support more flexible ways

2020-01-06 Thread GitBox
codjust commented on a change in pull request #1022: Feature/chash key support more flexible ways URL: https://github.com/apache/incubator-apisix/pull/1022#discussion_r363278540 ## File path: lua/apisix/balancer.lua ## @@ -122,6 +123,38 @@ local function

[GitHub] [incubator-apisix] codjust commented on a change in pull request #1022: Feature/chash key support more flexible ways

2020-01-06 Thread GitBox
codjust commented on a change in pull request #1022: Feature/chash key support more flexible ways URL: https://github.com/apache/incubator-apisix/pull/1022#discussion_r363278370 ## File path: lua/apisix/balancer.lua ## @@ -122,6 +123,38 @@ local function

[GitHub] [incubator-apisix] codjust commented on a change in pull request #1022: Feature/chash key support more flexible ways

2020-01-06 Thread GitBox
codjust commented on a change in pull request #1022: Feature/chash key support more flexible ways URL: https://github.com/apache/incubator-apisix/pull/1022#discussion_r363278222 ## File path: t/admin/upstream.t ## @@ -980,3 +980,223 @@ GET /t passed --- no_error_log

[GitHub] [incubator-apisix] codjust commented on a change in pull request #1022: Feature/chash key support more flexible ways

2020-01-06 Thread GitBox
codjust commented on a change in pull request #1022: Feature/chash key support more flexible ways URL: https://github.com/apache/incubator-apisix/pull/1022#discussion_r363278286 ## File path: t/admin/services.t ## @@ -751,3 +751,35 @@ GET /t passed --- no_error_log

[GitHub] [incubator-apisix] codjust commented on a change in pull request #1022: Feature/chash key support more flexible ways

2020-01-06 Thread GitBox
codjust commented on a change in pull request #1022: Feature/chash key support more flexible ways URL: https://github.com/apache/incubator-apisix/pull/1022#discussion_r363277303 ## File path: doc/architecture-design-cn.md ## @@ -334,9 +335,46 @@ curl

[GitHub] [incubator-apisix] codjust commented on a change in pull request #1022: Feature/chash key support more flexible ways

2020-01-06 Thread GitBox
codjust commented on a change in pull request #1022: Feature/chash key support more flexible ways URL: https://github.com/apache/incubator-apisix/pull/1022#discussion_r363277042 ## File path: doc/architecture-design-cn.md ## @@ -237,7 +237,8 @@ APISIX 的 Upstream

[GitHub] [incubator-apisix] codjust commented on a change in pull request #1022: Feature/chash key support more flexible ways

2020-01-06 Thread GitBox
codjust commented on a change in pull request #1022: Feature/chash key support more flexible ways URL: https://github.com/apache/incubator-apisix/pull/1022#discussion_r363277095 ## File path: doc/architecture-design-cn.md ## @@ -334,9 +335,46 @@ curl

[GitHub] [incubator-apisix] codjust commented on a change in pull request #1022: Feature/chash key support more flexible ways

2020-01-06 Thread GitBox
codjust commented on a change in pull request #1022: Feature/chash key support more flexible ways URL: https://github.com/apache/incubator-apisix/pull/1022#discussion_r363275347 ## File path: doc/architecture-design-cn.md ## @@ -237,7 +237,8 @@ APISIX 的 Upstream

[GitHub] [incubator-apisix] codjust commented on a change in pull request #1022: Feature/chash key support more flexible ways

2020-01-06 Thread GitBox
codjust commented on a change in pull request #1022: Feature/chash key support more flexible ways URL: https://github.com/apache/incubator-apisix/pull/1022#discussion_r363275316 ## File path: conf/config.yaml ## @@ -67,6 +67,7 @@ nginx_config: # config

[GitHub] [incubator-apisix-dashboard] aimpsmile opened a new issue #116: upstream page displays table error

2020-01-06 Thread GitBox
aimpsmile opened a new issue #116: upstream page displays table error URL: https://github.com/apache/incubator-apisix-dashboard/issues/116 eg: `json { "node": { "nodes": [ { "value": { "nodes": {

[GitHub] [incubator-apisix] moonming commented on a change in pull request #976: Added password support for plugin limit-count-redis

2020-01-06 Thread GitBox
moonming commented on a change in pull request #976: Added password support for plugin limit-count-redis URL: https://github.com/apache/incubator-apisix/pull/976#discussion_r363248877 ## File path: .travis/linux_openresty_runner.sh ## @@ -108,6 +108,9 @@ script() {

[GitHub] [incubator-apisix] totemofwolf commented on a change in pull request #976: Added password support for plugin limit-count-redis

2020-01-06 Thread GitBox
totemofwolf commented on a change in pull request #976: Added password support for plugin limit-count-redis URL: https://github.com/apache/incubator-apisix/pull/976#discussion_r363239220 ## File path: .travis/linux_openresty_runner.sh ## @@ -108,6 +108,9 @@ script() {

[GitHub] [incubator-apisix-docker] alexzhu0592 commented on issue #34: docker-compose occurres error which is cause by no exist url

2020-01-06 Thread GitBox
alexzhu0592 commented on issue #34: docker-compose occurres error which is cause by no exist url URL: https://github.com/apache/incubator-apisix-docker/issues/34#issuecomment-571085295 i change the url to

[GitHub] [incubator-apisix-docker] alexzhu0592 opened a new issue #34: docker-compose occurres error which is cause by no exist url

2020-01-06 Thread GitBox
alexzhu0592 opened a new issue #34: docker-compose occurres error which is cause by no exist url URL: https://github.com/apache/incubator-apisix-docker/issues/34 > Error: Error fetching file: Failed downloading https://github.com/iresty/apisix/raw/master/rockspec/apisix-master-0.rockspec

[incubator-apisix] branch v1.0 updated (afa2a6b -> cd041a1)

2020-01-06 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a change to branch v1.0 in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git. from afa2a6b doc: Update NOTICE year. new 688fef0 doc: updated version to 1.0 new cd041a1 utils:

[incubator-apisix] 01/02: doc: updated version to 1.0

2020-01-06 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch v1.0 in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git commit 688fef078afbc7be661784b2c5d76cbfc5fd2465 Author: Yuansheng AuthorDate: Mon Jan 6 18:02:35 2020 +0800

[incubator-apisix] 02/02: utils: added new tools to check apisix version.

2020-01-06 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch v1.0 in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git commit cd041a1dac876031f0f33ca91b458075f4fafba4 Author: Yuansheng AuthorDate: Mon Jan 6 18:02:59 2020 +0800

[GitHub] [incubator-apisix] lilien1010 commented on a change in pull request #1027: Jwt authentication plugin compatible with Bearer prefix

2020-01-06 Thread GitBox
lilien1010 commented on a change in pull request #1027: Jwt authentication plugin compatible with Bearer prefix URL: https://github.com/apache/incubator-apisix/pull/1027#discussion_r363224464 ## File path: lua/apisix/plugins/jwt-auth.lua ## @@ -90,16 +91,19 @@ end

[incubator-apisix] branch v1.0 updated: doc: Update NOTICE year.

2020-01-06 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch v1.0 in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git The following commit(s) were added to refs/heads/v1.0 by this push: new afa2a6b doc: Update NOTICE year.

[GitHub] [incubator-apisix] Miss-you commented on issue #342: CLI: check linux kernel and enable `REUSEPORT` if possible.

2020-01-06 Thread GitBox
Miss-you commented on issue #342: CLI: check linux kernel and enable `REUSEPORT` if possible. URL: https://github.com/apache/incubator-apisix/issues/342#issuecomment-571072461 I will solve this. This is an automated message

[GitHub] [incubator-apisix] lilien1010 commented on a change in pull request #1027: Jwt authentication plugin compatible with Bearer prefix

2020-01-06 Thread GitBox
lilien1010 commented on a change in pull request #1027: Jwt authentication plugin compatible with Bearer prefix URL: https://github.com/apache/incubator-apisix/pull/1027#discussion_r363215859 ## File path: lua/apisix/plugins/jwt-auth.lua ## @@ -90,16 +91,19 @@ end

[GitHub] [incubator-apisix] moonming commented on a change in pull request #1027: Jwt authentication plugin compatible with Bearer prefix

2020-01-06 Thread GitBox
moonming commented on a change in pull request #1027: Jwt authentication plugin compatible with Bearer prefix URL: https://github.com/apache/incubator-apisix/pull/1027#discussion_r363198693 ## File path: lua/apisix/plugins/jwt-auth.lua ## @@ -90,16 +91,19 @@ end

[GitHub] [incubator-apisix] moonming commented on a change in pull request #1027: Jwt authentication plugin compatible with Bearer prefix

2020-01-06 Thread GitBox
moonming commented on a change in pull request #1027: Jwt authentication plugin compatible with Bearer prefix URL: https://github.com/apache/incubator-apisix/pull/1027#discussion_r363198533 ## File path: lua/apisix/plugins/jwt-auth.lua ## @@ -90,16 +91,19 @@ end

[GitHub] [incubator-apisix] moonming commented on a change in pull request #1027: Jwt authentication plugin compatible with Bearer prefix

2020-01-06 Thread GitBox
moonming commented on a change in pull request #1027: Jwt authentication plugin compatible with Bearer prefix URL: https://github.com/apache/incubator-apisix/pull/1027#discussion_r363198899 ## File path: lua/apisix/plugins/jwt-auth.lua ## @@ -90,16 +91,19 @@ end

[GitHub] [incubator-apisix] moonming commented on a change in pull request #1027: Jwt authentication plugin compatible with Bearer prefix

2020-01-06 Thread GitBox
moonming commented on a change in pull request #1027: Jwt authentication plugin compatible with Bearer prefix URL: https://github.com/apache/incubator-apisix/pull/1027#discussion_r363206173 ## File path: t/plugin/jwt-auth.t ## @@ -218,7 +218,7 @@ hello world --- request

[GitHub] [incubator-apisix] moonming commented on a change in pull request #1027: Jwt authentication plugin compatible with Bearer prefix

2020-01-06 Thread GitBox
moonming commented on a change in pull request #1027: Jwt authentication plugin compatible with Bearer prefix URL: https://github.com/apache/incubator-apisix/pull/1027#discussion_r363205726 ## File path: lua/apisix/plugins/jwt-auth.lua ## @@ -90,16 +91,19 @@ end

[GitHub] [incubator-apisix] moonming commented on a change in pull request #1027: Jwt authentication plugin compatible with Bearer prefix

2020-01-06 Thread GitBox
moonming commented on a change in pull request #1027: Jwt authentication plugin compatible with Bearer prefix URL: https://github.com/apache/incubator-apisix/pull/1027#discussion_r363198859 ## File path: lua/apisix/plugins/jwt-auth.lua ## @@ -90,16 +91,19 @@ end

[GitHub] [incubator-apisix] moonming commented on a change in pull request #976: Added password support for plugin limit-count-redis

2020-01-06 Thread GitBox
moonming commented on a change in pull request #976: Added password support for plugin limit-count-redis URL: https://github.com/apache/incubator-apisix/pull/976#discussion_r363197206 ## File path: t/plugin/limit-count-redis.t ## @@ -209,3 +212,69 @@ passed [404, 503,

[GitHub] [incubator-apisix] totemofwolf commented on a change in pull request #976: Added password support for plugin limit-count-redis

2020-01-06 Thread GitBox
totemofwolf commented on a change in pull request #976: Added password support for plugin limit-count-redis URL: https://github.com/apache/incubator-apisix/pull/976#discussion_r363192009 ## File path: t/plugin/limit-count-redis.t ## @@ -209,3 +212,69 @@ passed [404, 503,