[GitHub] [incubator-apisix] sshniro commented on issue #1121: Batch processor implementation to aggregate logs in batch

2020-02-18 Thread GitBox
sshniro commented on issue #1121: Batch processor implementation to aggregate logs in batch URL: https://github.com/apache/incubator-apisix/pull/1121#issuecomment-588053122 Hi @membphis, all the review comments have been fixed now. -

[GitHub] [incubator-apisix] membphis opened a new pull request #1141: opt: print warning error message if the yaml route file is invalid.

2020-02-18 Thread GitBox
membphis opened a new pull request #1141: opt: print warning error message if the yaml route file is invalid. URL: https://github.com/apache/incubator-apisix/pull/1141 This is an automated message from the Apache Git Service

[GitHub] [incubator-apisix] membphis merged pull request #1140: change: updated jsonschema to v0.6 .

2020-02-18 Thread GitBox
membphis merged pull request #1140: change: updated jsonschema to v0.6 . URL: https://github.com/apache/incubator-apisix/pull/1140 This is an automated message from the Apache Git Service. To respond to the message, please lo

[incubator-apisix] branch master updated: change: updated jsonschema to v0.6 . (#1140)

2020-02-18 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git The following commit(s) were added to refs/heads/master by this push: new 6b5a606 change: updated jsonschema

[GitHub] [incubator-apisix] membphis opened a new pull request #1140: change: updated jsonschema to v0.6 .

2020-02-18 Thread GitBox
membphis opened a new pull request #1140: change: updated jsonschema to v0.6 . URL: https://github.com/apache/incubator-apisix/pull/1140 * ddd76d7 - (6 minutes ago) feature: supported table value as default value. This is an a

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1131: support distinguish configuration of different environments by environment variables

2020-02-18 Thread GitBox
membphis commented on a change in pull request #1131: support distinguish configuration of different environments by environment variables URL: https://github.com/apache/incubator-apisix/pull/1131#discussion_r380688837 ## File path: lua/apisix/core/profile.lua ## @@ -0,0 +

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1131: support distinguish configuration of different environments by environment variables

2020-02-18 Thread GitBox
membphis commented on a change in pull request #1131: support distinguish configuration of different environments by environment variables URL: https://github.com/apache/incubator-apisix/pull/1131#discussion_r380688192 ## File path: lua/apisix/core/profile.lua ## @@ -0,0 +

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1131: support distinguish configuration of different environments by environment variables

2020-02-18 Thread GitBox
membphis commented on a change in pull request #1131: support distinguish configuration of different environments by environment variables URL: https://github.com/apache/incubator-apisix/pull/1131#discussion_r380686874 ## File path: lua/apisix/core/config_local.lua ## @@ -

[incubator-apisix] branch master updated: bugfix: missing `clear` table before to reuse table. (#1134)

2020-02-18 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git The following commit(s) were added to refs/heads/master by this push: new 2870b79 bugfix: missing `clear` tab

[GitHub] [incubator-apisix] membphis merged pull request #1134: bugfix: missing `clear` table before to reuse table.

2020-02-18 Thread GitBox
membphis merged pull request #1134: bugfix: missing `clear` table before to reuse table. URL: https://github.com/apache/incubator-apisix/pull/1134 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [incubator-apisix] membphis commented on issue #1139: bugfix: checked `consumer` first, it maybe a boolean value when it was beed deleted.

2020-02-18 Thread GitBox
membphis commented on issue #1139: bugfix: checked `consumer` first, it maybe a boolean value when it was beed deleted. URL: https://github.com/apache/incubator-apisix/pull/1139#issuecomment-587451030 > Will other objects have similar problem? for example delete route https://github

[GitHub] [incubator-apisix] membphis commented on issue #1134: bugfix: missing `clear` table before to reuse table.

2020-02-18 Thread GitBox
membphis commented on issue #1134: bugfix: missing `clear` table before to reuse table. URL: https://github.com/apache/incubator-apisix/pull/1134#issuecomment-587449561 > need to add more infomation about this bug: memory leak? please take a look at: https://github.com/apache/incuba

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1134: bugfix: missing `clear` table before to reuse table.

2020-02-18 Thread GitBox
membphis commented on a change in pull request #1134: bugfix: missing `clear` table before to reuse table. URL: https://github.com/apache/incubator-apisix/pull/1134#discussion_r380657179 ## File path: lua/apisix/core/response.lua ## @@ -37,10 +37,12 @@ do local idx =

[GitHub] [incubator-apisix] moonming commented on issue #1139: bugfix: checked `consumer` first, it maybe a boolean value when it was beed deleted.

2020-02-18 Thread GitBox
moonming commented on issue #1139: bugfix: checked `consumer` first, it maybe a boolean value when it was beed deleted. URL: https://github.com/apache/incubator-apisix/pull/1139#issuecomment-587449058 Will other objects have similar problem? for example delete route --

[GitHub] [incubator-apisix] moonming commented on a change in pull request #1139: bugfix: checked `consumer` first, it maybe a boolean value when it was beed deleted.

2020-02-18 Thread GitBox
moonming commented on a change in pull request #1139: bugfix: checked `consumer` first, it maybe a boolean value when it was beed deleted. URL: https://github.com/apache/incubator-apisix/pull/1139#discussion_r380655099 ## File path: lua/apisix/consumer.lua ## @@ -35,6 +36,

[GitHub] [incubator-apisix] moonming commented on issue #1134: bugfix: missing `clear` table before to reuse table.

2020-02-18 Thread GitBox
moonming commented on issue #1134: bugfix: missing `clear` table before to reuse table. URL: https://github.com/apache/incubator-apisix/pull/1134#issuecomment-587445558 need to add more infomation about this bug: memory leak?

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1134: bugfix: missing `clear` table before to reuse table.

2020-02-18 Thread GitBox
membphis commented on a change in pull request #1134: bugfix: missing `clear` table before to reuse table. URL: https://github.com/apache/incubator-apisix/pull/1134#discussion_r380650710 ## File path: t/admin/routes.t ## @@ -1369,6 +1369,7 @@ passed location /t { con

[GitHub] [incubator-apisix] membphis commented on issue #1139: bugfix: checked `consumer` first, it maybe a boolean value when it was beed deleted.

2020-02-18 Thread GitBox
membphis commented on issue #1139: bugfix: checked `consumer` first, it maybe a boolean value when it was beed deleted. URL: https://github.com/apache/incubator-apisix/pull/1139#issuecomment-587442308 fix https://github.com/apache/incubator-apisix/issues/1138 --

[GitHub] [incubator-apisix] membphis opened a new pull request #1139: bugfix: checked `consumer` first, it maybe a boolean value when it was beed deleted.

2020-02-18 Thread GitBox
membphis opened a new pull request #1139: bugfix: checked `consumer` first, it maybe a boolean value when it was beed deleted. URL: https://github.com/apache/incubator-apisix/pull/1139 This is an automated message from the A

[GitHub] [incubator-apisix] moonming commented on a change in pull request #1134: bugfix: missing `clear` table before to reuse table.

2020-02-18 Thread GitBox
moonming commented on a change in pull request #1134: bugfix: missing `clear` table before to reuse table. URL: https://github.com/apache/incubator-apisix/pull/1134#discussion_r380632837 ## File path: t/admin/routes.t ## @@ -1369,6 +1369,7 @@ passed location /t { con

[GitHub] [incubator-apisix] AbelZhou commented on issue #1138: bug: 获取JWT token网页500错误

2020-02-18 Thread GitBox
AbelZhou commented on issue #1138: bug: 获取JWT token网页500错误 URL: https://github.com/apache/incubator-apisix/issues/1138#issuecomment-587420924 重新在dashboard添加一个新的consumer后,又复现了。 This is an automated message from the Apache Git

[GitHub] [incubator-apisix] AbelZhou commented on issue #1138: bug: 获取JWT token网页500错误

2020-02-18 Thread GitBox
AbelZhou commented on issue #1138: bug: 获取JWT token网页500错误 URL: https://github.com/apache/incubator-apisix/issues/1138#issuecomment-587419287 当我想调试一下的时候,我关闭了lua_code_cache,然后发现很多接口都不通了,还原代码缓存然后重启后这个issue问题不复现了。诡异。。 This is an

[GitHub] [incubator-apisix] AbelZhou opened a new issue #1138: bug: 获取JWT token网页500错误

2020-02-18 Thread GitBox
AbelZhou opened a new issue #1138: bug: 获取JWT token网页500错误 URL: https://github.com/apache/incubator-apisix/issues/1138 ### Issue description ``` 2020/02/18 18:37:10 [error] 72220#0: *3791238 lua entry thread aborted: runtime error: /Users/abel/server/apisix/lua/apisix/consumer.lua:38:

[GitHub] [incubator-apisix] membphis closed pull request #1137: !! test only !!

2020-02-18 Thread GitBox
membphis closed pull request #1137: !! test only !! URL: https://github.com/apache/incubator-apisix/pull/1137 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us