[GitHub] [incubator-apisix] moonming commented on a change in pull request #1182: Fix bad code style.

2020-03-02 Thread GitBox
moonming commented on a change in pull request #1182: Fix bad code style. URL: https://github.com/apache/incubator-apisix/pull/1182#discussion_r386825526 ## File path: bin/apisix ## @@ -540,24 +540,22 @@ local function check_or_version(cur_ver_s, need_ver_s) return tru

[GitHub] [incubator-apisix] wwd5613 commented on issue #1183: doc: remove some useless tip

2020-03-02 Thread GitBox
wwd5613 commented on issue #1183: doc: remove some useless tip URL: https://github.com/apache/incubator-apisix/issues/1183#issuecomment-593772863 I would like to do this job This is an automated message from the Apache Git Se

[GitHub] [incubator-apisix] membphis closed pull request #1177: feature: support plug-in independent development.

2020-03-02 Thread GitBox
membphis closed pull request #1177: feature: support plug-in independent development. URL: https://github.com/apache/incubator-apisix/pull/1177 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [incubator-apisix] membphis opened a new issue #1184: bug: failed to call `apisix init` after apisix was installed by luarocks

2020-03-02 Thread GitBox
membphis opened a new issue #1184: bug: failed to call `apisix init` after apisix was installed by luarocks URL: https://github.com/apache/incubator-apisix/issues/1184 ### Issue description https://travis-ci.org/apache/incubator-apisix/jobs/657178537#L1420 ### Environment

[GitHub] [incubator-apisix] membphis opened a new issue #1183: doc: remove some useless tip

2020-03-02 Thread GitBox
membphis opened a new issue #1183: doc: remove some useless tip URL: https://github.com/apache/incubator-apisix/issues/1183 Now all apisix routes are implemented by radixtree, so it is no longer necessary to notice this, it may even cause confusion. ![image](https://user-images.gith

[GitHub] [incubator-apisix] membphis commented on issue #1153: feature: support for proxy caching plugin based on disk.

2020-03-02 Thread GitBox
membphis commented on issue #1153: feature: support for proxy caching plugin based on disk. URL: https://github.com/apache/incubator-apisix/pull/1153#issuecomment-593721657 https://github.com/apache/incubator-apisix/pull/1153/files/56a1f42fd1e8bd30575856758a51e8a21acf2e4c..b3ccdb372520e284

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1153: feature: support for proxy caching plugin based on disk.

2020-03-02 Thread GitBox
membphis commented on a change in pull request #1153: feature: support for proxy caching plugin based on disk. URL: https://github.com/apache/incubator-apisix/pull/1153#discussion_r386752162 ## File path: lua/apisix/plugins/proxy-cache.lua ## @@ -178,6 +158,91 @@ local fun

[GitHub] [incubator-apisix] membphis commented on issue #1181: bug: coroutine.wrap:20: API disabled in the context of log_by_lua error in Batch Processor

2020-03-02 Thread GitBox
membphis commented on issue #1181: bug: coroutine.wrap:20: API disabled in the context of log_by_lua error in Batch Processor URL: https://github.com/apache/incubator-apisix/issues/1181#issuecomment-593711676 In jsonschema, the compiled Lua code is generated by using yield, but the yield

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1182: Fix bad code style.

2020-03-02 Thread GitBox
membphis commented on a change in pull request #1182: Fix bad code style. URL: https://github.com/apache/incubator-apisix/pull/1182#discussion_r386740051 ## File path: bin/apisix ## @@ -540,24 +540,22 @@ local function check_or_version(cur_ver_s, need_ver_s) return tru

[GitHub] [incubator-apisix] Akayeshmantha opened a new pull request #1182: Fix bad code style.

2020-03-02 Thread GitBox
Akayeshmantha opened a new pull request #1182: Fix bad code style. URL: https://github.com/apache/incubator-apisix/pull/1182 ### Full changelog * Fix bad code style in apisix file. ### Issues resolved Fix #1180 --

[GitHub] [incubator-apisix] sshniro commented on issue #1181: bug: coroutine.wrap:20: API disabled in the context of log_by_lua error in Batch Processor

2020-03-02 Thread GitBox
sshniro commented on issue #1181: bug: coroutine.wrap:20: API disabled in the context of log_by_lua error in Batch Processor URL: https://github.com/apache/incubator-apisix/issues/1181#issuecomment-593539764 @membphis I guess APISIX is not allowing to access the JSON schema validator duri

[GitHub] [incubator-apisix] agile6v commented on issue #1153: feature: support for proxy caching plugin based on disk.

2020-03-02 Thread GitBox
agile6v commented on issue #1153: feature: support for proxy caching plugin based on disk. URL: https://github.com/apache/incubator-apisix/pull/1153#issuecomment-593466068 > And I have other new questions: > > 1. need some e2e test case > 2. need a way to purge the old cache

[GitHub] [incubator-apisix] Akayeshmantha commented on issue #1180: bad code style

2020-03-02 Thread GitBox
Akayeshmantha commented on issue #1180: bad code style URL: https://github.com/apache/incubator-apisix/issues/1180#issuecomment-593463277 @membphis quick question am new to lua is there a starting guide for developers to set up dev environment. I wanted to test the modified function. --

[GitHub] [incubator-apisix] sshniro opened a new issue #1181: bug: coroutine.wrap:20: API disabled in the context of log_by_lua error in Batch Processor

2020-03-02 Thread GitBox
sshniro opened a new issue #1181: bug: coroutine.wrap:20: API disabled in the context of log_by_lua error in Batch Processor URL: https://github.com/apache/incubator-apisix/issues/1181 Hi, When using the [batch processor](https://github.com/apache/incubator-apisix/blob/e1ac426443293

[GitHub] [incubator-apisix-docker] Akayeshmantha commented on issue #38: Docker compose not working

2020-03-02 Thread GitBox
Akayeshmantha commented on issue #38: Docker compose not working URL: https://github.com/apache/incubator-apisix-docker/pull/38#issuecomment-593393726 @moonming isn't it good to have a script to always sync with the repository config.yaml file this will help to resolve the problems we are

[GitHub] [incubator-apisix] membphis commented on issue #1180: bad code style

2020-03-02 Thread GitBox
membphis commented on issue #1180: bad code style URL: https://github.com/apache/incubator-apisix/issues/1180#issuecomment-593380022 > Hi, @membphis I would like to work on this issue. Is it only the function that you pointed or the whole file we have to refactor? Fix this function

[GitHub] [incubator-apisix] Akayeshmantha commented on issue #1180: bad code style

2020-03-02 Thread GitBox
Akayeshmantha commented on issue #1180: bad code style URL: https://github.com/apache/incubator-apisix/issues/1180#issuecomment-593365869 Hi, @membphis I would like to work on this issue. Is it only the function that you pointed or the whole file we have to refactor?

[GitHub] [incubator-apisix-docker] Akayeshmantha opened a new pull request #38: Docker compose not working #37

2020-03-02 Thread GitBox
Akayeshmantha opened a new pull request #38: Docker compose not working #37 URL: https://github.com/apache/incubator-apisix-docker/pull/38 This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [incubator-apisix-docker] Akayeshmantha opened a new issue #37: Docker compose not working (nginx: [emerg] invalid parameter: valid= in /usr/local/apisix/conf/nginx.conf:48).

2020-03-02 Thread GitBox
Akayeshmantha opened a new issue #37: Docker compose not working (nginx: [emerg] invalid parameter: valid= in /usr/local/apisix/conf/nginx.conf:48). URL: https://github.com/apache/incubator-apisix-docker/issues/37 Hi All I got the latest clone and tried to run apisix with docker-comp

[GitHub] [incubator-apisix-docker] Akayeshmantha commented on issue #37: Docker compose not working (nginx: [emerg] invalid parameter: valid= in /usr/local/apisix/conf/nginx.conf:48).

2020-03-02 Thread GitBox
Akayeshmantha commented on issue #37: Docker compose not working (nginx: [emerg] invalid parameter: valid= in /usr/local/apisix/conf/nginx.conf:48). URL: https://github.com/apache/incubator-apisix-docker/issues/37#issuecomment-593329652 @moonming -

[GitHub] [incubator-apisix] membphis commented on issue #921: when upgrade 0.8 to 0.9 version resolve deps problem

2020-03-02 Thread GitBox
membphis commented on issue #921: when upgrade 0.8 to 0.9 version resolve deps problem URL: https://github.com/apache/incubator-apisix/pull/921#issuecomment-593275216 Who is interested in continuing this PR? This is an automa

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1167: feature: auto import nameservers into APISIX from system resolv file.…

2020-03-02 Thread GitBox
membphis commented on a change in pull request #1167: feature: auto import nameservers into APISIX from system resolv file.… URL: https://github.com/apache/incubator-apisix/pull/1167#discussion_r386243051 ## File path: bin/apisix ## @@ -525,6 +535,24 @@ local function chec

[GitHub] [incubator-apisix] membphis opened a new issue #1180: bad code style

2020-03-02 Thread GitBox
membphis opened a new issue #1180: bad code style URL: https://github.com/apache/incubator-apisix/issues/1180 https://github.com/apache/incubator-apisix/pull/1167/files#diff-62edadffc237f13dc28a694080d293a8R543 we need a better style, here is an example: ``` local function

[incubator-apisix] branch master updated: feature: auto import nameservers into APISIX from system resolver. (#1167)

2020-03-02 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git The following commit(s) were added to refs/heads/master by this push: new e1ac426 feature: auto import namese

[GitHub] [incubator-apisix] membphis merged pull request #1167: feature: auto import nameservers into APISIX from system resolv file.…

2020-03-02 Thread GitBox
membphis merged pull request #1167: feature: auto import nameservers into APISIX from system resolv file.… URL: https://github.com/apache/incubator-apisix/pull/1167 This is an automated message from the Apache Git Service. T

[GitHub] [incubator-apisix] membphis closed issue #1164: feature: auto import nameservers into APISIX from system resolv file.

2020-03-02 Thread GitBox
membphis closed issue #1164: feature: auto import nameservers into APISIX from system resolv file. URL: https://github.com/apache/incubator-apisix/issues/1164 This is an automated message from the Apache Git Service. To resp