[incubator-apisix] branch master updated: luacov: add new path `plugins/limit-count` and `plugins/utils`. (#1357)

2020-03-28 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git The following commit(s) were added to refs/heads/master by this push: new aa13b72 luacov: add new path

[GitHub] [incubator-apisix] membphis merged pull request #1357: luacov: add new path `plugins/limit-count` and `plugins/utils`.

2020-03-28 Thread GitBox
membphis merged pull request #1357: luacov: add new path `plugins/limit-count` and `plugins/utils`. URL: https://github.com/apache/incubator-apisix/pull/1357 This is an automated message from the Apache Git Service. To

[incubator-apisix] branch master updated: feature: add cors plugin (#1327)

2020-03-28 Thread wenming
This is an automated email from the ASF dual-hosted git repository. wenming pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git The following commit(s) were added to refs/heads/master by this push: new c363ea4 feature: add cors plugin

[GitHub] [incubator-apisix] moonming merged pull request #1327: features: append cors plugin

2020-03-28 Thread GitBox
moonming merged pull request #1327: features: append cors plugin URL: https://github.com/apache/incubator-apisix/pull/1327 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-apisix] moonming commented on a change in pull request #1351: [WIP]feature: remove `lua` dir.

2020-03-28 Thread GitBox
moonming commented on a change in pull request #1351: [WIP]feature: remove `lua` dir. URL: https://github.com/apache/incubator-apisix/pull/1351#discussion_r399734871 ## File path: Contributing.md ## @@ -98,15 +98,15 @@ Once we've discussed your changes and you've got your

[GitHub] [incubator-apisix] moonming commented on issue #1351: [WIP]feature: remove `lua` dir.

2020-03-28 Thread GitBox
moonming commented on issue #1351: [WIP]feature: remove `lua` dir. URL: https://github.com/apache/incubator-apisix/pull/1351#issuecomment-605546703 > > `lua/apisix.lua → apisix.lua ` > > How about `lua/apisix.lua → apisix/init.lua` ? good idea

[incubator-apisix] branch master updated: dashboard: add dashboard as submodule. (#1360)

2020-03-28 Thread wenming
This is an automated email from the ASF dual-hosted git repository. wenming pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git The following commit(s) were added to refs/heads/master by this push: new 7ff43d5 dashboard: add dashboard as

[GitHub] [incubator-apisix] moonming merged pull request #1360: dashboard: add dashboard as submodule.

2020-03-28 Thread GitBox
moonming merged pull request #1360: dashboard: add dashboard as submodule. URL: https://github.com/apache/incubator-apisix/pull/1360 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-apisix] nic-chen closed issue #1144: request help: fail to proxy grpc request

2020-03-28 Thread GitBox
nic-chen closed issue #1144: request help: fail to proxy grpc request URL: https://github.com/apache/incubator-apisix/issues/1144 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-apisix] nic-chen commented on issue #1144: request help: fail to proxy grpc request

2020-03-28 Thread GitBox
nic-chen commented on issue #1144: request help: fail to proxy grpc request URL: https://github.com/apache/incubator-apisix/issues/1144#issuecomment-605543060 duplicate issue with #1209 close. This is an automated

[GitHub] [incubator-apisix] moonming opened a new pull request #1360: dashboard: add dashboard as submodule.

2020-03-28 Thread GitBox
moonming opened a new pull request #1360: dashboard: add dashboard as submodule. URL: https://github.com/apache/incubator-apisix/pull/1360 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-apisix] membphis commented on issue #1327: features: append cors plugin

2020-03-28 Thread GitBox
membphis commented on issue #1327: features: append cors plugin URL: https://github.com/apache/incubator-apisix/pull/1327#issuecomment-605446526 you should revert them: ![image](https://user-images.githubusercontent.com/6814606/77823941-c0cdaa80-7139-11ea-89fb-accfc4ccc292.png)

[GitHub] [incubator-apisix] ShiningRush commented on issue #1327: features: append cors plugin

2020-03-28 Thread GitBox
ShiningRush commented on issue #1327: features: append cors plugin URL: https://github.com/apache/incubator-apisix/pull/1327#issuecomment-605435217 The ci show the `./doc/plugins/cors-cn.md` has no license header, but it does have, hmm, what happened to it?

[GitHub] [incubator-apisix] membphis commented on issue #1281: feature: Support for using Eureka as a service discovery center

2020-03-28 Thread GitBox
membphis commented on issue #1281: feature: Support for using Eureka as a service discovery center URL: https://github.com/apache/incubator-apisix/pull/1281#issuecomment-605421247 ``` .travis/openwhisk-utilities/scancode/scanCode.py --config .travis/ASF-Release.cfg ./ Reading

[GitHub] [incubator-apisix] membphis commented on issue #1351: [WIP]feature: remove `lua` dir.

2020-03-28 Thread GitBox
membphis commented on issue #1351: [WIP]feature: remove `lua` dir. URL: https://github.com/apache/incubator-apisix/pull/1351#issuecomment-605421029 > `lua/apisix.lua → apisix.lua ` How about `lua/apisix.lua → apisix/init.lua` ?

[GitHub] [incubator-apisix] membphis commented on issue #1327: features: append cors plugin

2020-03-28 Thread GitBox
membphis commented on issue #1327: features: append cors plugin URL: https://github.com/apache/incubator-apisix/pull/1327#issuecomment-605420837 add a reference to doc: https://github.com/apache/incubator-apisix#features

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1327: features: append cors plugin

2020-03-28 Thread GitBox
membphis commented on a change in pull request #1327: features: append cors plugin URL: https://github.com/apache/incubator-apisix/pull/1327#discussion_r399642693 ## File path: doc/plugins/cors-cn.md ## @@ -0,0 +1,92 @@ + + +# [English](cors.md) + +# 目录 + +- [**简介**](#简介)

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1327: features: append cors plugin

2020-03-28 Thread GitBox
membphis commented on a change in pull request #1327: features: append cors plugin URL: https://github.com/apache/incubator-apisix/pull/1327#discussion_r399642598 ## File path: doc/plugins/cors-cn.md ## @@ -0,0 +1,92 @@ + + +# [English](cors.md) + +# 目录 + +- [**简介**](#简介)

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1327: features: append cors plugin

2020-03-28 Thread GitBox
membphis commented on a change in pull request #1327: features: append cors plugin URL: https://github.com/apache/incubator-apisix/pull/1327#discussion_r399642697 ## File path: doc/plugins/cors-cn.md ## @@ -0,0 +1,92 @@ + + +# [English](cors.md) + +# 目录 + +- [**简介**](#简介)

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1327: features: append cors plugin

2020-03-28 Thread GitBox
membphis commented on a change in pull request #1327: features: append cors plugin URL: https://github.com/apache/incubator-apisix/pull/1327#discussion_r399642450 ## File path: doc/plugins/cors-cn.md ## @@ -0,0 +1,92 @@ + + +# [English](cors.md) + +# 目录 + +- [**简介**](#简介)

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1327: features: append cors plugin

2020-03-28 Thread GitBox
membphis commented on a change in pull request #1327: features: append cors plugin URL: https://github.com/apache/incubator-apisix/pull/1327#discussion_r399642628 ## File path: doc/plugins/cors-cn.md ## @@ -0,0 +1,92 @@ + + +# [English](cors.md) + +# 目录 + +- [**简介**](#简介)

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1327: features: append cors plugin

2020-03-28 Thread GitBox
membphis commented on a change in pull request #1327: features: append cors plugin URL: https://github.com/apache/incubator-apisix/pull/1327#discussion_r399642650 ## File path: doc/plugins/cors-cn.md ## @@ -0,0 +1,92 @@ + + +# [English](cors.md) + +# 目录 + +- [**简介**](#简介)

[GitHub] [incubator-apisix] chnliyong commented on a change in pull request #1351: [WIP]feature: remove `lua` dir.

2020-03-28 Thread GitBox
chnliyong commented on a change in pull request #1351: [WIP]feature: remove `lua` dir. URL: https://github.com/apache/incubator-apisix/pull/1351#discussion_r399628666 ## File path: bin/apisix ## @@ -113,9 +113,8 @@ env APISIX_PROFILE; {% if stream_proxy then %} stream

[GitHub] [incubator-apisix] membphis commented on issue #1351: [WIP]feature: remove `lua` dir.

2020-03-28 Thread GitBox
membphis commented on issue #1351: [WIP]feature: remove `lua` dir. URL: https://github.com/apache/incubator-apisix/pull/1351#issuecomment-605403364 > Will this conflict with other luarocks libraries? No conflict. This

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1351: [WIP]feature: remove `lua` dir.

2020-03-28 Thread GitBox
membphis commented on a change in pull request #1351: [WIP]feature: remove `lua` dir. URL: https://github.com/apache/incubator-apisix/pull/1351#discussion_r399626651 ## File path: Makefile ## @@ -117,47 +117,47 @@ install: $(INSTALL) conf/config.yaml