[GitHub] [incubator-apisix] membphis closed issue #1374: bug: missing a comma in health-check.md example

2020-03-30 Thread GitBox
membphis closed issue #1374: bug: missing a comma in health-check.md example URL: https://github.com/apache/incubator-apisix/issues/1374 This is an automated message from the Apache Git Service. To respond to the message,

[incubator-apisix] branch master updated: doc: Fix json format error. (#1373)

2020-03-30 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git The following commit(s) were added to refs/heads/master by this push: new 8838599 doc: Fix json format

[GitHub] [incubator-apisix] membphis merged pull request #1373: Fix doc json format error.

2020-03-30 Thread GitBox
membphis merged pull request #1373: Fix doc json format error. URL: https://github.com/apache/incubator-apisix/pull/1373 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1218: feature: add example .yaml resource files which support to run Apache APISIX on kubernetes

2020-03-30 Thread GitBox
membphis commented on a change in pull request #1218: feature: add example .yaml resource files which support to run Apache APISIX on kubernetes URL: https://github.com/apache/incubator-apisix/pull/1218#discussion_r400644795 ## File path: kubernetes/README.md ## @@ -0,0

[GitHub] [incubator-apisix] membphis merged pull request #1204: Wolf-Rbac: Add new api `change_pwd` and `user_info`.

2020-03-30 Thread GitBox
membphis merged pull request #1204: Wolf-Rbac: Add new api `change_pwd` and `user_info`. URL: https://github.com/apache/incubator-apisix/pull/1204 This is an automated message from the Apache Git Service. To respond to the

[incubator-apisix] branch master updated (11a9646 -> 8470726)

2020-03-30 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git. from 11a9646 change: check item count of DNS resolver (#1361) add 8470726 plugin(wolf-rbac): added new

[incubator-apisix] branch master updated (d7f54ff -> 11a9646)

2020-03-30 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git. from d7f54ff feature: support to print log with specific prefix. (#1284) add 11a9646 change: check

[GitHub] [incubator-apisix] membphis merged pull request #1361: check dns_addrs len

2020-03-30 Thread GitBox
membphis merged pull request #1361: check dns_addrs len URL: https://github.com/apache/incubator-apisix/pull/1361 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin

2020-03-30 Thread GitBox
membphis commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin URL: https://github.com/apache/incubator-apisix/pull/1372#discussion_r400645863 ## File path: lua/apisix/plugins/limit-count.lua ## @@ -51,6 +51,12 @@ local schema = {

[GitHub] [incubator-apisix] membphis commented on issue #1372: modify: specify pool_size and backlog for plugin

2020-03-30 Thread GitBox
membphis commented on issue #1372: modify: specify pool_size and backlog for plugin URL: https://github.com/apache/incubator-apisix/pull/1372#issuecomment-606401982 @gxthrj I think we need to update the doc too This is an

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin

2020-03-30 Thread GitBox
membphis commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin URL: https://github.com/apache/incubator-apisix/pull/1372#discussion_r400645276 ## File path: lua/apisix/plugins/limit-count.lua ## @@ -82,6 +88,8 @@ function

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1218: feature: add example .yaml resource files which support to run Apache APISIX on kubernetes

2020-03-30 Thread GitBox
membphis commented on a change in pull request #1218: feature: add example .yaml resource files which support to run Apache APISIX on kubernetes URL: https://github.com/apache/incubator-apisix/pull/1218#discussion_r400644568 ## File path: kubernetes/README.md ## @@ -0,0

[GitHub] [incubator-apisix] spacewander commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin

2020-03-30 Thread GitBox
spacewander commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin URL: https://github.com/apache/incubator-apisix/pull/1372#discussion_r400643075 ## File path: lua/apisix/plugins/limit-count.lua ## @@ -82,6 +88,8 @@ function

[GitHub] [incubator-apisix] totemofwolf commented on a change in pull request #1218: feature: add example .yaml resource files which support to run Apache APISIX on kubernetes

2020-03-30 Thread GitBox
totemofwolf commented on a change in pull request #1218: feature: add example .yaml resource files which support to run Apache APISIX on kubernetes URL: https://github.com/apache/incubator-apisix/pull/1218#discussion_r400635611 ## File path: kubernetes/README.md ## @@

[GitHub] [incubator-apisix] membphis commented on issue #1375: bug: restart apisix docker, show error log below

2020-03-30 Thread GitBox
membphis commented on issue #1375: bug: restart apisix docker, show error log below URL: https://github.com/apache/incubator-apisix/issues/1375#issuecomment-606387387 please use the latest `master` branch, I have fixed it for days.

[GitHub] [incubator-apisix] membphis commented on issue #1375: bug: restart apisix docker, show error log below

2020-03-30 Thread GitBox
membphis commented on issue #1375: bug: restart apisix docker, show error log below URL: https://github.com/apache/incubator-apisix/issues/1375#issuecomment-606387491

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1370: enhance: plugin Zipkin add service name and report local server IP

2020-03-30 Thread GitBox
membphis commented on a change in pull request #1370: enhance: plugin Zipkin add service name and report local server IP URL: https://github.com/apache/incubator-apisix/pull/1370#discussion_r400630065 ## File path: doc/plugins/zipkin-cn.md ## @@ -118,3 +120,45 @@ $ curl

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1370: enhance: plugin Zipkin add service name and report local server IP

2020-03-30 Thread GitBox
membphis commented on a change in pull request #1370: enhance: plugin Zipkin add service name and report local server IP URL: https://github.com/apache/incubator-apisix/pull/1370#discussion_r400630003 ## File path: lua/apisix/plugins/zipkin.lua ## @@ -131,6 +144,9 @@

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin

2020-03-30 Thread GitBox
membphis commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin URL: https://github.com/apache/incubator-apisix/pull/1372#discussion_r400620851 ## File path: lua/apisix/plugins/limit-count.lua ## @@ -82,6 +88,8 @@ function

[GitHub] [incubator-apisix] yeahzi opened a new issue #1374: bug:

2020-03-30 Thread GitBox
yeahzi opened a new issue #1374: bug: URL: https://github.com/apache/incubator-apisix/issues/1374 ### Issue description https://github.com/apache/incubator-apisix/blob/master/doc/health-check.md Missing a comma in this code: "nodes": { "127.0.0.1:1980": 1,

[GitHub] [incubator-apisix] lilien1010 opened a new issue #1375: bug: restart apisix docker, show error log below

2020-03-30 Thread GitBox
lilien1010 opened a new issue #1375: bug: restart apisix docker, show error log below URL: https://github.com/apache/incubator-apisix/issues/1375 ### Issue description ``` 2020/03/31 03:16:28 [error] 26#26: *3 [lua] plugin.lua:66: load_plugin(): failed to load plugin

[GitHub] [incubator-apisix] xxm404 opened a new pull request #1373: Fix doc json format error.

2020-03-30 Thread GitBox
xxm404 opened a new pull request #1373: Fix doc json format error. URL: https://github.com/apache/incubator-apisix/pull/1373 NOTE: Please read the Contributing.md guidelines before submitting your patch:

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin

2020-03-30 Thread GitBox
membphis commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin URL: https://github.com/apache/incubator-apisix/pull/1372#discussion_r400609550 ## File path: lua/apisix/plugins/limit-count/limit-count-redis.lua ## @@ -20,6 +20,7 @@

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1364: support to run `header_filter` and `body_filter` phase for global rules.

2020-03-30 Thread GitBox
membphis commented on a change in pull request #1364: support to run `header_filter` and `body_filter` phase for global rules. URL: https://github.com/apache/incubator-apisix/pull/1364#discussion_r400609225 ## File path: lua/apisix.lua ## @@ -435,12 +435,42 @@ end

[GitHub] [incubator-apisix] gxthrj commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin

2020-03-30 Thread GitBox
gxthrj commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin URL: https://github.com/apache/incubator-apisix/pull/1372#discussion_r400608964 ## File path: lua/apisix/plugins/limit-count/limit-count-redis.lua ## @@ -20,6 +20,7 @@

[GitHub] [incubator-apisix] moonming commented on a change in pull request #1370: enhance: plugin Zipkin add service name and report local server IP

2020-03-30 Thread GitBox
moonming commented on a change in pull request #1370: enhance: plugin Zipkin add service name and report local server IP URL: https://github.com/apache/incubator-apisix/pull/1370#discussion_r400606628 ## File path: lua/apisix/plugins/zipkin.lua ## @@ -94,6 +99,8 @@

[GitHub] [incubator-apisix] moonming commented on a change in pull request #1370: enhance: plugin Zipkin add service name and report local server IP

2020-03-30 Thread GitBox
moonming commented on a change in pull request #1370: enhance: plugin Zipkin add service name and report local server IP URL: https://github.com/apache/incubator-apisix/pull/1370#discussion_r400606384 ## File path: lua/apisix/plugins/zipkin.lua ## @@ -29,7 +29,12 @@ local

[GitHub] [incubator-apisix] moonming merged pull request #1284: feature: support to print log with specific prefix.

2020-03-30 Thread GitBox
moonming merged pull request #1284: feature: support to print log with specific prefix. URL: https://github.com/apache/incubator-apisix/pull/1284 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-apisix] moonming commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin

2020-03-30 Thread GitBox
moonming commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin URL: https://github.com/apache/incubator-apisix/pull/1372#discussion_r400604545 ## File path: lua/apisix/plugins/limit-count/limit-count-redis.lua ## @@ -20,6 +20,7 @@

[GitHub] [incubator-apisix] gxthrj commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin

2020-03-30 Thread GitBox
gxthrj commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin URL: https://github.com/apache/incubator-apisix/pull/1372#discussion_r400604186 ## File path: lua/apisix/plugins/limit-count/limit-count-redis.lua ## @@ -47,7 +47,8 @@

[incubator-apisix] branch master updated (d0900ca -> 12677c3)

2020-03-30 Thread wenming
This is an automated email from the ASF dual-hosted git repository. wenming pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git. from d0900ca feature: merge upstream tengine (2.3.2 < version < 2.3.3) patches (#1371) add 12677c3

[GitHub] [incubator-apisix] gxthrj commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin

2020-03-30 Thread GitBox
gxthrj commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin URL: https://github.com/apache/incubator-apisix/pull/1372#discussion_r400604186 ## File path: lua/apisix/plugins/limit-count/limit-count-redis.lua ## @@ -47,7 +47,8 @@

[GitHub] [incubator-apisix] moonming merged pull request #1367: Allow add custom shared dict

2020-03-30 Thread GitBox
moonming merged pull request #1367: Allow add custom shared dict URL: https://github.com/apache/incubator-apisix/pull/1367 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-apisix] gxthrj commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin

2020-03-30 Thread GitBox
gxthrj commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin URL: https://github.com/apache/incubator-apisix/pull/1372#discussion_r400604291 ## File path: lua/apisix/plugins/limit-count/limit-count-redis.lua ## @@ -47,7 +47,8 @@

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin

2020-03-30 Thread GitBox
membphis commented on a change in pull request #1372: modify: specify pool_size and backlog for plugin URL: https://github.com/apache/incubator-apisix/pull/1372#discussion_r400599270 ## File path: lua/apisix/plugins/limit-count/limit-count-redis.lua ## @@ -47,7 +47,8 @@

[GitHub] [incubator-apisix] gxthrj opened a new pull request #1372: modify: specify pool_size and backlog for plugin

2020-03-30 Thread GitBox
gxthrj opened a new pull request #1372: modify: specify pool_size and backlog for plugin URL: https://github.com/apache/incubator-apisix/pull/1372 ### specify pool_size and backlog for plugin ### Issues resolved Fix #1315

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1356: Updating TCP logger to use the batch processor util

2020-03-30 Thread GitBox
membphis commented on a change in pull request #1356: Updating TCP logger to use the batch processor util URL: https://github.com/apache/incubator-apisix/pull/1356#discussion_r400597617 ## File path: lua/apisix/plugins/tcp-logger.lua ## @@ -59,21 +59,21 @@ local function

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1351: feature: remove `lua` dir.

2020-03-30 Thread GitBox
membphis commented on a change in pull request #1351: feature: remove `lua` dir. URL: https://github.com/apache/incubator-apisix/pull/1351#discussion_r400596368 ## File path: t/admin/balancer.t ## @@ -25,7 +25,7 @@ add_block_preprocessor(sub { my $init_by_lua_block

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1351: feature: remove `lua` dir.

2020-03-30 Thread GitBox
membphis commented on a change in pull request #1351: feature: remove `lua` dir. URL: https://github.com/apache/incubator-apisix/pull/1351#discussion_r400594294 ## File path: t/admin/balancer.t ## @@ -25,7 +25,7 @@ add_block_preprocessor(sub { my $init_by_lua_block

[GitHub] [incubator-apisix] lilien1010 commented on a change in pull request #1370: enhance: plugin Zipkin add service name and report local server IP

2020-03-30 Thread GitBox
lilien1010 commented on a change in pull request #1370: enhance: plugin Zipkin add service name and report local server IP URL: https://github.com/apache/incubator-apisix/pull/1370#discussion_r400587909 ## File path: doc/plugins/zipkin-cn.md ## @@ -34,8 +34,9 @@ ## 属性

[GitHub] [incubator-apisix] lilien1010 commented on a change in pull request #1370: enhance: plugin Zipkin add service name and report local server IP

2020-03-30 Thread GitBox
lilien1010 commented on a change in pull request #1370: enhance: plugin Zipkin add service name and report local server IP URL: https://github.com/apache/incubator-apisix/pull/1370#discussion_r400587821 ## File path: doc/plugins/zipkin.md ## @@ -39,6 +39,7 @@ It's also

[GitHub] [incubator-apisix] membphis merged pull request #1371: feature: merge upstream tengine (2.3.2 < version < 2.3.3) patches

2020-03-30 Thread GitBox
membphis merged pull request #1371: feature: merge upstream tengine (2.3.2 < version < 2.3.3) patches URL: https://github.com/apache/incubator-apisix/pull/1371 This is an automated message from the Apache Git Service. To

[incubator-apisix] branch master updated: feature: merge upstream tengine (2.3.2 < version < 2.3.3) patches (#1371)

2020-03-30 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git The following commit(s) were added to refs/heads/master by this push: new d0900ca feature: merge upstream

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1218: feature: add example .yaml resource files which support to run Apache APISIX on kubernetes

2020-03-30 Thread GitBox
membphis commented on a change in pull request #1218: feature: add example .yaml resource files which support to run Apache APISIX on kubernetes URL: https://github.com/apache/incubator-apisix/pull/1218#discussion_r400574549 ## File path: kubernetes/README.md ## @@ -0,0

[GitHub] [incubator-apisix] moonming commented on a change in pull request #1370: enhance: plugin Zipkin add service name and report local server IP

2020-03-30 Thread GitBox
moonming commented on a change in pull request #1370: enhance: plugin Zipkin add service name and report local server IP URL: https://github.com/apache/incubator-apisix/pull/1370#discussion_r400254069 ## File path: doc/plugins/zipkin-cn.md ## @@ -34,8 +34,9 @@ ## 属性

[GitHub] [incubator-apisix] totemofwolf opened a new pull request #1371: feature: merge upstream tengine (2.3.2 < version < 2.3.3) patches

2020-03-30 Thread GitBox
totemofwolf opened a new pull request #1371: feature: merge upstream tengine (2.3.2 < version < 2.3.3) patches URL: https://github.com/apache/incubator-apisix/pull/1371 ### Summary feature: merge upstream tengine (2.3.2 < version < 2.3.3) patches ### Full changelog

[incubator-apisix-website] branch asf-site updated: Publishing to asf-site (publish.sh)

2020-03-30 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-apisix-website.git The following commit(s) were added to refs/heads/asf-site by this push: new d4ec551 Publishing to

[incubator-apisix-website] branch master updated: fix: styles

2020-03-30 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix-website.git The following commit(s) were added to refs/heads/master by this push: new 0b415ce fix: styles

[GitHub] [incubator-apisix] Akayeshmantha commented on issue #1364: support to run `header_filter` and `body_filter` phase for global rules.

2020-03-30 Thread GitBox
Akayeshmantha commented on issue #1364: support to run `header_filter` and `body_filter` phase for global rules. URL: https://github.com/apache/incubator-apisix/pull/1364#issuecomment-606034284 @membphis can we merge this if its ok?

[GitHub] [incubator-apisix] moonming commented on issue #1224: support base64 secret for jwt auth

2020-03-30 Thread GitBox
moonming commented on issue #1224: support base64 secret for jwt auth URL: https://github.com/apache/incubator-apisix/pull/1224#issuecomment-606031647 @paoying any update? This is an automated message from the Apache Git

[incubator-apisix-website] branch asf-site updated: Publishing to asf-site (publish.sh)

2020-03-30 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-apisix-website.git The following commit(s) were added to refs/heads/asf-site by this push: new 5d4fee4 Publishing to

[incubator-apisix-website] branch master updated: feat: update footer

2020-03-30 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix-website.git The following commit(s) were added to refs/heads/master by this push: new 773ffa9 feat: update

[GitHub] [incubator-apisix] Akayeshmantha commented on a change in pull request #1364: support to run `header_filter` and `body_filter` phase for global rules.

2020-03-30 Thread GitBox
Akayeshmantha commented on a change in pull request #1364: support to run `header_filter` and `body_filter` phase for global rules. URL: https://github.com/apache/incubator-apisix/pull/1364#discussion_r400135615 ## File path: lua/apisix.lua ## @@ -435,12 +435,42 @@ end

[GitHub] [incubator-apisix] Akayeshmantha commented on a change in pull request #1364: support to run `header_filter` and `body_filter` phase for global rules.

2020-03-30 Thread GitBox
Akayeshmantha commented on a change in pull request #1364: support to run `header_filter` and `body_filter` phase for global rules. URL: https://github.com/apache/incubator-apisix/pull/1364#discussion_r400135615 ## File path: lua/apisix.lua ## @@ -435,12 +435,42 @@ end

[GitHub] [incubator-apisix] spacewander commented on a change in pull request #1364: support to run `header_filter` and `body_filter` phase for global rules.

2020-03-30 Thread GitBox
spacewander commented on a change in pull request #1364: support to run `header_filter` and `body_filter` phase for global rules. URL: https://github.com/apache/incubator-apisix/pull/1364#discussion_r400126964 ## File path: lua/apisix.lua ## @@ -435,12 +435,42 @@ end

[GitHub] [incubator-apisix] Akayeshmantha commented on issue #1364: support to run `header_filter` and `body_filter` phase for global rules.

2020-03-30 Thread GitBox
Akayeshmantha commented on issue #1364: support to run `header_filter` and `body_filter` phase for global rules. URL: https://github.com/apache/incubator-apisix/pull/1364#issuecomment-605911045 @spacewander @membphis This

[GitHub] [incubator-apisix] lilien1010 commented on a change in pull request #1370: enhance: plugin Zipkin add service name and report local server IP

2020-03-30 Thread GitBox
lilien1010 commented on a change in pull request #1370: enhance: plugin Zipkin add service name and report local server IP URL: https://github.com/apache/incubator-apisix/pull/1370#discussion_r400074628 ## File path: lua/apisix/plugins/zipkin.lua ## @@ -109,6 +130,10 @@

[GitHub] [incubator-apisix] moonming commented on a change in pull request #1370: enhance: plugin Zipkin add service name and report local server IP

2020-03-30 Thread GitBox
moonming commented on a change in pull request #1370: enhance: plugin Zipkin add service name and report local server IP URL: https://github.com/apache/incubator-apisix/pull/1370#discussion_r400053007 ## File path: lua/apisix/plugins/zipkin.lua ## @@ -42,6 +47,20 @@ local

[GitHub] [incubator-apisix] moonming commented on a change in pull request #1370: enhance: plugin Zipkin add service name and report local server IP

2020-03-30 Thread GitBox
moonming commented on a change in pull request #1370: enhance: plugin Zipkin add service name and report local server IP URL: https://github.com/apache/incubator-apisix/pull/1370#discussion_r400054099 ## File path: t/plugin/zipkin.t ## @@ -126,7 +126,8 @@ done

[GitHub] [incubator-apisix] moonming commented on a change in pull request #1370: enhance: plugin Zipkin add service name and report local server IP

2020-03-30 Thread GitBox
moonming commented on a change in pull request #1370: enhance: plugin Zipkin add service name and report local server IP URL: https://github.com/apache/incubator-apisix/pull/1370#discussion_r400053650 ## File path: lua/apisix/plugins/zipkin.lua ## @@ -109,6 +130,10 @@

[GitHub] [incubator-apisix] lilien1010 opened a new pull request #1370: enhance: plugin Zipkin add service name and report local server IP

2020-03-30 Thread GitBox
lilien1010 opened a new pull request #1370: enhance: plugin Zipkin add service name and report local server IP URL: https://github.com/apache/incubator-apisix/pull/1370 ### Summary allow zipkin to set servie name so that we can track it in APM system ### Full changelog

[GitHub] [incubator-apisix] griffenliu commented on a change in pull request #1367: Allow add custom shared dict

2020-03-30 Thread GitBox
griffenliu commented on a change in pull request #1367: Allow add custom shared dict URL: https://github.com/apache/incubator-apisix/pull/1367#discussion_r400031964 ## File path: conf/config.yaml ## @@ -111,8 +111,8 @@ nginx_config: # config for render

[GitHub] [incubator-apisix] Akayeshmantha commented on issue #1364: support to run `header_filter` and `body_filter` phase for global rules.

2020-03-30 Thread GitBox
Akayeshmantha commented on issue #1364: support to run `header_filter` and `body_filter` phase for global rules. URL: https://github.com/apache/incubator-apisix/pull/1364#issuecomment-605872994 Sure @spacewander created a new issue #1369 since this ticket mentioned a different issue

[GitHub] [incubator-apisix] sshniro commented on issue #1358: Updating kafka logger to use the batch processor util

2020-03-30 Thread GitBox
sshniro commented on issue #1358: Updating kafka logger to use the batch processor util URL: https://github.com/apache/incubator-apisix/pull/1358#issuecomment-605872337 Closing the PR as agreed to use the builtin buffer of the library.

[GitHub] [incubator-apisix] Akayeshmantha opened a new issue #1369: Refactor the way to run global rule in log/header filter/body filter phases to use the same function?

2020-03-30 Thread GitBox
Akayeshmantha opened a new issue #1369: Refactor the way to run global rule in log/header filter/body filter phases to use the same function? URL: https://github.com/apache/incubator-apisix/issues/1369 This is an automated

[GitHub] [incubator-apisix] moonming commented on a change in pull request #1367: Allow add custom shared dict

2020-03-30 Thread GitBox
moonming commented on a change in pull request #1367: Allow add custom shared dict URL: https://github.com/apache/incubator-apisix/pull/1367#discussion_r400029392 ## File path: conf/config.yaml ## @@ -111,8 +111,8 @@ nginx_config: # config for render

[GitHub] [incubator-apisix] moonming merged pull request #1368: Adding code style and doc linting tool for contribution guidelines

2020-03-30 Thread GitBox
moonming merged pull request #1368: Adding code style and doc linting tool for contribution guidelines URL: https://github.com/apache/incubator-apisix/pull/1368 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-apisix] spacewander commented on issue #1364: support to run `header_filter` and `body_filter` phase for global rules.

2020-03-30 Thread GitBox
spacewander commented on issue #1364: support to run `header_filter` and `body_filter` phase for global rules. URL: https://github.com/apache/incubator-apisix/pull/1364#issuecomment-605869664 @Akayeshmantha Maybe we can refactor the way to run global rule in log/header filter/body

[GitHub] [incubator-apisix] moonming closed issue #1359: travis: update the openresty to `1.15.8.3` for Tengine ENV

2020-03-30 Thread GitBox
moonming closed issue #1359: travis: update the openresty to `1.15.8.3` for Tengine ENV URL: https://github.com/apache/incubator-apisix/issues/1359 This is an automated message from the Apache Git Service. To respond to the

[incubator-apisix] branch master updated (52934b5 -> 7585382)

2020-03-30 Thread wenming
This is an automated email from the ASF dual-hosted git repository. wenming pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git. from 52934b5 Batch Processor: Fix for rescheduling execution for max_retry_count is 0 and 1 (#1349) add

[incubator-apisix] branch master updated (7585382 -> 661f3ad)

2020-03-30 Thread wenming
This is an automated email from the ASF dual-hosted git repository. wenming pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git. from 7585382 Adding code style and doc linting tool for contribution guidelines (#1368) add 661f3ad

[GitHub] [incubator-apisix] moonming merged pull request #1363: update lua resty.

2020-03-30 Thread GitBox
moonming merged pull request #1363: update lua resty. URL: https://github.com/apache/incubator-apisix/pull/1363 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-apisix] moonming commented on issue #446: feature:support the CORS

2020-03-30 Thread GitBox
moonming commented on issue #446: feature:support the CORS URL: https://github.com/apache/incubator-apisix/issues/446#issuecomment-605868302 closed by https://github.com/apache/incubator-apisix/pull/1327 This is an automated

[GitHub] [incubator-apisix] moonming closed issue #446: feature:support the CORS

2020-03-30 Thread GitBox
moonming closed issue #446: feature:support the CORS URL: https://github.com/apache/incubator-apisix/issues/446 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-apisix] moonming commented on issue #1096: add cors plugin

2020-03-30 Thread GitBox
moonming commented on issue #1096: add cors plugin URL: https://github.com/apache/incubator-apisix/pull/1096#issuecomment-605868042 closed by https://github.com/apache/incubator-apisix/pull/1327 This is an automated message

[GitHub] [incubator-apisix] moonming closed pull request #1096: add cors plugin

2020-03-30 Thread GitBox
moonming closed pull request #1096: add cors plugin URL: https://github.com/apache/incubator-apisix/pull/1096 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-apisix] moonming commented on a change in pull request #1367: Allow add custom shared dict

2020-03-30 Thread GitBox
moonming commented on a change in pull request #1367: Allow add custom shared dict URL: https://github.com/apache/incubator-apisix/pull/1367#discussion_r400020513 ## File path: conf/config.yaml ## @@ -111,6 +111,8 @@ nginx_config: # config for render

[GitHub] [incubator-apisix] moonming commented on issue #1367: Allow add custom shared dict

2020-03-30 Thread GitBox
moonming commented on issue #1367: Allow add custom shared dict URL: https://github.com/apache/incubator-apisix/pull/1367#issuecomment-605863786 Got it. This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-apisix] griffenliu commented on issue #1367: Allow add custom shared dict

2020-03-30 Thread GitBox
griffenliu commented on issue #1367: Allow add custom shared dict URL: https://github.com/apache/incubator-apisix/pull/1367#issuecomment-605860584 > If you need to add one shared dict, then you will using this shared dict in Lua code, right? > So is this PR works with custom plugin?

[GitHub] [incubator-apisix] moonming commented on issue #1367: Allow add custom shared dict

2020-03-30 Thread GitBox
moonming commented on issue #1367: Allow add custom shared dict URL: https://github.com/apache/incubator-apisix/pull/1367#issuecomment-605859004 If you need to add one shared dict, then you will using this shared dict in Lua code, right? So is this PR works with custom plugin?

[GitHub] [incubator-apisix] Akayeshmantha commented on issue #1363: update lua resty.

2020-03-30 Thread GitBox
Akayeshmantha commented on issue #1363: update lua resty. URL: https://github.com/apache/incubator-apisix/pull/1363#issuecomment-605856307 sure @membphis @moonming done This is an automated message from the Apache Git

[GitHub] [incubator-apisix] totemofwolf commented on a change in pull request #1218: feature: add example .yaml resource files which support to run Apache APISIX on kubernetes

2020-03-30 Thread GitBox
totemofwolf commented on a change in pull request #1218: feature: add example .yaml resource files which support to run Apache APISIX on kubernetes URL: https://github.com/apache/incubator-apisix/pull/1218#discussion_r48268 ## File path: kubernetes/apisix-gw-config-cm.yaml

[GitHub] [incubator-apisix] totemofwolf commented on a change in pull request #1218: feature: add example .yaml resource files which support to run Apache APISIX on kubernetes

2020-03-30 Thread GitBox
totemofwolf commented on a change in pull request #1218: feature: add example .yaml resource files which support to run Apache APISIX on kubernetes URL: https://github.com/apache/incubator-apisix/pull/1218#discussion_r48391 ## File path: kubernetes/deployment.yaml ##

[GitHub] [incubator-apisix] sshniro opened a new pull request #1368: Adding code style and doc linting tool for contribution guidelines

2020-03-30 Thread GitBox
sshniro opened a new pull request #1368: Adding code style and doc linting tool for contribution guidelines URL: https://github.com/apache/incubator-apisix/pull/1368 ### Summary #1273 https://github.com/apache/incubator-apisix/pull/1356#discussion_r399891409

[GitHub] [incubator-apisix] sshniro commented on a change in pull request #1356: Updating TCP logger to use the batch processor util

2020-03-30 Thread GitBox
sshniro commented on a change in pull request #1356: Updating TCP logger to use the batch processor util URL: https://github.com/apache/incubator-apisix/pull/1356#discussion_r34762 ## File path: lua/apisix/plugins/tcp-logger.lua ## @@ -59,21 +59,21 @@ local function

[GitHub] [incubator-apisix] sshniro commented on a change in pull request #1356: Updating TCP logger to use the batch processor util

2020-03-30 Thread GitBox
sshniro commented on a change in pull request #1356: Updating TCP logger to use the batch processor util URL: https://github.com/apache/incubator-apisix/pull/1356#discussion_r34762 ## File path: lua/apisix/plugins/tcp-logger.lua ## @@ -59,21 +59,21 @@ local function

[GitHub] [incubator-apisix] griffenliu opened a new pull request #1367: Allow add custom shared dict

2020-03-30 Thread GitBox
griffenliu opened a new pull request #1367: Allow add custom shared dict URL: https://github.com/apache/incubator-apisix/pull/1367 NOTE: Please read the Contributing.md guidelines before submitting your patch:

[GitHub] [incubator-apisix] csluoqi opened a new issue #1366: bug:

2020-03-30 Thread GitBox
csluoqi opened a new issue #1366: bug: URL: https://github.com/apache/incubator-apisix/issues/1366 ### Issue description basic-auth插件,如果在页面上设置password为全数字,在通过curl 和postman测试后,都会报错 {"message":"Password is error"}。但是如果密码是英文,比如bar 那么两个测试工具的测试结果都是正确的。 ### Environment * apisix