[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #73: feat: added desc

2020-09-14 Thread GitBox
juzhiyuan commented on a change in pull request #73: URL: https://github.com/apache/apisix-website/pull/73#discussion_r488403217 ## File path: website/siteConfig.js ## @@ -29,7 +29,7 @@ const users = [ const siteConfig = { title: "Apache APISIX™", - tagline: "The

[apisix-website] branch feat-trademarks updated (46dc0ec -> 69a1a4f)

2020-09-14 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch feat-trademarks in repository https://gitbox.apache.org/repos/asf/apisix-website.git. from 46dc0ec feat: added desc add 69a1a4f feat: added tagline2 No new revisions were added by

[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #73: feat: added desc

2020-09-14 Thread GitBox
juzhiyuan commented on a change in pull request #73: URL: https://github.com/apache/apisix-website/pull/73#discussion_r488400764 ## File path: website/siteConfig.js ## @@ -29,7 +29,7 @@ const users = [ const siteConfig = { title: "Apache APISIX™", - tagline: "The

[apisix-dashboard] branch master updated: feat: remove netlify (#472)

2020-09-14 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new 361392f feat: remove netlify

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #472: feat: remove netlify

2020-09-14 Thread GitBox
juzhiyuan merged pull request #472: URL: https://github.com/apache/apisix-dashboard/pull/472 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix] moonming commented on issue #2229: request help: "consumer" provides access to a collection of "service".

2020-09-14 Thread GitBox
moonming commented on issue #2229: URL: https://github.com/apache/apisix/issues/2229#issuecomment-692476896 please take a look at kong's ACL plugin too: https://docs.konghq.com/hub/kong-inc/acl/ Thanks, Ming Wen Twitter: _WenMing Firstsawyou 于2020年9月15日周二

[GitHub] [apisix] Firstsawyou commented on issue #2229: request help: "consumer" provides access to a collection of "service".

2020-09-14 Thread GitBox
Firstsawyou commented on issue #2229: URL: https://github.com/apache/apisix/issues/2229#issuecomment-692473633 > the same as #385 Ok,let me take a look. This is an automated message from the Apache Git Service. To

[GitHub] [apisix] Firstsawyou commented on issue #2229: request help: "consumer" provides access to a collection of "service".

2020-09-14 Thread GitBox
Firstsawyou commented on issue #2229: URL: https://github.com/apache/apisix/issues/2229#issuecomment-692472362 > How do you plan to implement this feature? It is planned to create a whitelisted plug-in through "service_id", which is bound to "consumer".

[GitHub] [apisix] moonming commented on issue #2229: request help: "consumer" provides access to a collection of "service".

2020-09-14 Thread GitBox
moonming commented on issue #2229: URL: https://github.com/apache/apisix/issues/2229#issuecomment-692470173 How do you plan to implement this feature? This is an automated message from the Apache Git Service. To respond to

[GitHub] [apisix] Firstsawyou commented on issue #2229: request help: "consumer" provides access to a collection of "service".

2020-09-14 Thread GitBox
Firstsawyou commented on issue #2229: URL: https://github.com/apache/apisix/issues/2229#issuecomment-692469543 Assigned to me. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [apisix] moonming commented on issue #2229: request help: "consumer" provides access to a collection of "service".

2020-09-14 Thread GitBox
moonming commented on issue #2229: URL: https://github.com/apache/apisix/issues/2229#issuecomment-692469486 the same as https://github.com/apache/apisix/issues/385 This is an automated message from the Apache Git Service. To

[GitHub] [apisix] Firstsawyou commented on issue #2229: request help: "consumer" provides access to a collection of "service".

2020-09-14 Thread GitBox
Firstsawyou commented on issue #2229: URL: https://github.com/apache/apisix/issues/2229#issuecomment-692468901 > This is what identity authentication needs to do, such as ACL, right? Yes. This is an automated message

[GitHub] [apisix] moonming commented on issue #2229: request help: "consumer" provides access to a collection of "service".

2020-09-14 Thread GitBox
moonming commented on issue #2229: URL: https://github.com/apache/apisix/issues/2229#issuecomment-692468240 This is what identity authentication needs to do, such as ACL, right? This is an automated message from the Apache

[GitHub] [apisix] Firstsawyou opened a new issue #2229: request help: "consumer" provides access to a collection of "service".

2020-09-14 Thread GitBox
Firstsawyou opened a new issue #2229: URL: https://github.com/apache/apisix/issues/2229 ### Issue description Configure multiple "service" objects. I want to restrict the "service" on the "consumer". What should I do? For example: "service" has: serv1, serv2 and serv3. In "consumer",

[apisix] branch master updated (2999541 -> 12a0b13)

2020-09-14 Thread wenming
This is an automated email from the ASF dual-hosted git repository. wenming pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 2999541 fix: change the config file when deploying apisix in k8s #2182 (#2185) add 12a0b13 bugfix: use the

[GitHub] [apisix] moonming merged pull request #2211: bugfix: use the route's `has_domain` attribute if the route contains upstream object

2020-09-14 Thread GitBox
moonming merged pull request #2211: URL: https://github.com/apache/apisix/pull/2211 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix-website] moonming commented on a change in pull request #73: feat: added desc

2020-09-14 Thread GitBox
moonming commented on a change in pull request #73: URL: https://github.com/apache/apisix-website/pull/73#discussion_r488364826 ## File path: website/siteConfig.js ## @@ -29,7 +29,7 @@ const users = [ const siteConfig = { title: "Apache APISIX™", - tagline: "The

[GitHub] [apisix] Caelebs closed issue #2224: request help: k8s部署日志提示failed to read `apisix` field from yaml file

2020-09-14 Thread GitBox
Caelebs closed issue #2224: URL: https://github.com/apache/apisix/issues/2224 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix] Miss-you commented on pull request #2226: doc: added channel at slack and added new qq group.

2020-09-14 Thread GitBox
Miss-you commented on pull request #2226: URL: https://github.com/apache/apisix/pull/2226#issuecomment-692431848 ![image](https://user-images.githubusercontent.com/3816205/93160059-22162400-f742-11ea-98d3-300e4269365a.png) 836398818

[GitHub] [apisix] membphis commented on a change in pull request #2192: feat: add AK/SK auth plugin

2020-09-14 Thread GitBox
membphis commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r488348093 ## File path: doc/zh-cn/plugins/hmac-auth.md ## @@ -0,0 +1,157 @@ + + +- [English](../../plugins/hmac-auth.md) + +# 目录 +- [**名字**](#名字) +- [**属性**](#属性)

[GitHub] [apisix] tokers commented on issue #2227: CLI: Check the etcd version in CLI. The version must be 3.4 or greater.

2020-09-14 Thread GitBox
tokers commented on issue #2227: URL: https://github.com/apache/apisix/issues/2227#issuecomment-692426801 @membphis May i pick it up? This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix] shuaijinchao commented on pull request #2211: bugfix: use the route's `has_domain` attribute if the route contains upstream object

2020-09-14 Thread GitBox
shuaijinchao commented on pull request #2211: URL: https://github.com/apache/apisix/pull/2211#issuecomment-692425998 Follow-up can support dynamic upstream according to request information, cool. This is an automated

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #473: PluginModule: v2

2020-09-14 Thread GitBox
juzhiyuan commented on issue #473: URL: https://github.com/apache/apisix-dashboard/issues/473#issuecomment-692423742 @moonming @membphis Please provide the priority for every category and plugin. This is an automated

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2192: feat: add AK/SK auth plugin

2020-09-14 Thread GitBox
Firstsawyou commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r488343173 ## File path: doc/zh-cn/plugins/hmac-auth.md ## @@ -0,0 +1,152 @@ + + +- [English](../../plugins/hmac-auth.md) + +# 目录 +- [**名字**](#名字) +-

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2192: feat: add AK/SK auth plugin

2020-09-14 Thread GitBox
Firstsawyou commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r488339941 ## File path: doc/zh-cn/plugins/hmac-auth.md ## @@ -0,0 +1,152 @@ + + +- [English](../../plugins/hmac-auth.md) + +# 目录 +- [**名字**](#名字) +-

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2192: feat: add AK/SK auth plugin

2020-09-14 Thread GitBox
Firstsawyou commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r488336742 ## File path: doc/plugins/hmac-auth.md ## @@ -0,0 +1,151 @@ + + +- [中文](../zh-cn/plugins/hmac-auth.md) + +# Summary +- [**Name**](#name) +-

[GitHub] [apisix-dashboard] juzhiyuan closed issue #448: Proposal: improve the PluginModule

2020-09-14 Thread GitBox
juzhiyuan closed issue #448: URL: https://github.com/apache/apisix-dashboard/issues/448 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix-dashboard] juzhiyuan closed issue #459: In the routing plug-in configuration interface, click response rewrite to display 500

2020-09-14 Thread GitBox
juzhiyuan closed issue #459: URL: https://github.com/apache/apisix-dashboard/issues/459 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix] gy09535 commented on issue #2151: feature: Best practice for jaeger

2020-09-14 Thread GitBox
gy09535 commented on issue #2151: URL: https://github.com/apache/apisix/issues/2151#issuecomment-692414315 > I think you can add a plugin for jaeger, and welcome PR for this got it This is an automated message from

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2192: feat: add AK/SK auth plugin

2020-09-14 Thread GitBox
Firstsawyou commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r488335359 ## File path: doc/plugins/hmac-auth.md ## @@ -0,0 +1,151 @@ + + +- [中文](../zh-cn/plugins/hmac-auth.md) + +# Summary +- [**Name**](#name) +-

[GitHub] [apisix] moonming opened a new issue #2228: bug: remove `/tmp/apisix_cores/` in makefile and bin/apisix.

2020-09-14 Thread GitBox
moonming opened a new issue #2228: URL: https://github.com/apache/apisix/issues/2228 remove https://github.com/apache/apisix/blob/master/bin/apisix#L36 and https://github.com/apache/apisix/blob/master/Makefile#L84, both of them are useless now.

[apisix-dashboard] branch master updated (66709c4 -> 09c5be9)

2020-09-14 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 66709c4 feat: support ungroup in manager api (#460) add 09c5be9 feat: add publish status to

[apisix-dashboard] branch master updated (09c5be9 -> 13b5f0c)

2020-09-14 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 09c5be9 feat: add publish status to route in manager api (#450) add 13b5f0c feat(route): add

[GitHub] [apisix] membphis commented on a change in pull request #2221: send file contents and not file name

2020-09-14 Thread GitBox
membphis commented on a change in pull request #2221: URL: https://github.com/apache/apisix/pull/2221#discussion_r488333965 ## File path: apisix/utils/log-util.lua ## @@ -64,7 +64,11 @@ local function get_full_log(ngx, conf) else local body_file =

[GitHub] [apisix] membphis commented on pull request #2036: feature: support etcd v3, by mocking v2 API

2020-09-14 Thread GitBox
membphis commented on pull request #2036: URL: https://github.com/apache/apisix/pull/2036#issuecomment-692411184 > one more thing, we need to check the `etcd` version in `bin/apisix`, confirm the `etcd` version `>= 3.4` . we can fix this in a new PR, here is the related issue:

[GitHub] [apisix] membphis opened a new issue #2227: CLI: Check the etcd version in CLI. The version must be 3.4 or greater.

2020-09-14 Thread GitBox
membphis opened a new issue #2227: URL: https://github.com/apache/apisix/issues/2227 comments: https://github.com/apache/apisix/pull/2036#issuecomment-691957197 This is an automated message from the Apache Git

[GitHub] [apisix] moonming opened a new pull request #2226: doc: added channel at slack and added new qq group.

2020-09-14 Thread GitBox
moonming opened a new pull request #2226: URL: https://github.com/apache/apisix/pull/2226 ### What this PR does / why we need it: ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have

[apisix-dashboard] branch master updated (66709c4 -> 09c5be9)

2020-09-14 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 66709c4 feat: support ungroup in manager api (#460) add 09c5be9 feat: add publish status to

[apisix-dashboard] branch master updated (09c5be9 -> 13b5f0c)

2020-09-14 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 09c5be9 feat: add publish status to route in manager api (#450) add 13b5f0c feat(route): add

[apisix-dashboard] branch master updated (09c5be9 -> 13b5f0c)

2020-09-14 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 09c5be9 feat: add publish status to route in manager api (#450) add 13b5f0c feat(route): add

[GitHub] [apisix] membphis commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

2020-09-14 Thread GitBox
membphis commented on a change in pull request #2036: URL: https://github.com/apache/apisix/pull/2036#discussion_r488331969 ## File path: bin/apisix ## @@ -873,35 +873,26 @@ local function init_etcd(show_output) local host_count = #(yaml_conf.etcd.host) --- check

[apisix-dashboard] branch master updated (66709c4 -> 09c5be9)

2020-09-14 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 66709c4 feat: support ungroup in manager api (#460) add 09c5be9 feat: add publish status to

[GitHub] [apisix-dashboard] juzhiyuan opened a new issue #473: PluginModule

2020-09-14 Thread GitBox
juzhiyuan opened a new issue #473: URL: https://github.com/apache/apisix-dashboard/issues/473 - [ ] Support JSONSchema - [ ] Improve i18n This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #451: feat(route): add publish and offline to route

2020-09-14 Thread GitBox
juzhiyuan merged pull request #451: URL: https://github.com/apache/apisix-dashboard/pull/451 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #450: feat: add publish status to route in manager api

2020-09-14 Thread GitBox
juzhiyuan merged pull request #450: URL: https://github.com/apache/apisix-dashboard/pull/450 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix] membphis commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

2020-09-14 Thread GitBox
membphis commented on a change in pull request #2036: URL: https://github.com/apache/apisix/pull/2036#discussion_r488328057 ## File path: t/core/etcd.t ## @@ -0,0 +1,335 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

[GitHub] [apisix] nic-chen commented on pull request #2036: feature: support etcd v3, by mocking v2 API

2020-09-14 Thread GitBox
nic-chen commented on pull request #2036: URL: https://github.com/apache/apisix/pull/2036#issuecomment-692401902 Note: I found that run `etcd` v3 on docker for mac cause high CPU usage, like: https://github.com/etcd-io/etcd/issues/11460 Running on Linux is ok.

[GitHub] [apisix] nic-chen commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

2020-09-14 Thread GitBox
nic-chen commented on a change in pull request #2036: URL: https://github.com/apache/apisix/pull/2036#discussion_r488320970 ## File path: t/core/etcd.t ## @@ -0,0 +1,335 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

[apisix-dashboard] branch feat-remove-netlify created (now 6bf5759)

2020-09-14 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch feat-remove-netlify in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. at 6bf5759 feat: remove netlify No new revisions were added by this update.

[apisix-dashboard] branch feat-remove-netlify created (now 6bf5759)

2020-09-14 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch feat-remove-netlify in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. at 6bf5759 feat: remove netlify No new revisions were added by this update.

[GitHub] [apisix-dashboard] juzhiyuan opened a new pull request #472: feat: remove netlify

2020-09-14 Thread GitBox
juzhiyuan opened a new pull request #472: URL: https://github.com/apache/apisix-dashboard/pull/472 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bug fix - [x] New feature provided - [ ] Improve performance -

[GitHub] [apisix-website] juzhiyuan commented on pull request #73: feat: added desc

2020-09-14 Thread GitBox
juzhiyuan commented on pull request #73: URL: https://github.com/apache/apisix-website/pull/73#issuecomment-692392689 @moonming Please help to check http://www.apache.org/foundation/marks/pmcs#metadata This is an automated

[apisix-website] branch feat-trademarks created (now 46dc0ec)

2020-09-14 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch feat-trademarks in repository https://gitbox.apache.org/repos/asf/apisix-website.git. at 46dc0ec feat: added desc No new revisions were added by this update.

[GitHub] [apisix-website] juzhiyuan opened a new pull request #73: feat: added desc

2020-09-14 Thread GitBox
juzhiyuan opened a new pull request #73: URL: https://github.com/apache/apisix-website/pull/73 - [x] Desc on the homepage; - [x] Check ASF Links at homepage's bottom.; This is an automated message from the Apache Git

[GitHub] [apisix] membphis commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

2020-09-14 Thread GitBox
membphis commented on a change in pull request #2036: URL: https://github.com/apache/apisix/pull/2036#discussion_r488306915 ## File path: rockspec/apisix-master-0.rockspec ## @@ -52,6 +52,7 @@ dependencies = { "lua-resty-kafka = 0.07", "lua-resty-logger-socket =

[GitHub] [apisix] membphis commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

2020-09-14 Thread GitBox
membphis commented on a change in pull request #2036: URL: https://github.com/apache/apisix/pull/2036#discussion_r488305432 ## File path: apisix/core/etcd.lua ## @@ -44,24 +49,144 @@ end _M.new = new +local function kvs_to_node(kvs) +local node = {} +node.key =

[GitHub] [apisix] membphis commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

2020-09-14 Thread GitBox
membphis commented on a change in pull request #2036: URL: https://github.com/apache/apisix/pull/2036#discussion_r488305164 ## File path: README.md ## @@ -166,10 +166,9 @@ There are several ways to install the Apache Release version of APISIX: apisix start

[GitHub] [apisix] membphis commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

2020-09-14 Thread GitBox
membphis commented on a change in pull request #2036: URL: https://github.com/apache/apisix/pull/2036#discussion_r488305087 ## File path: apisix/core/config_etcd.lua ## @@ -92,17 +105,29 @@ local function waitdir(etcd_cli, key, modified_index, timeout) return nil,

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #450: feat: add publish status to route in manager api

2020-09-14 Thread GitBox
liuxiran commented on a change in pull request #450: URL: https://github.com/apache/apisix-dashboard/pull/450#discussion_r488259506 ## File path: api/route/route_test.go ## @@ -98,39 +153,41 @@ func TestCreateRouteWithCreateNewGroup(t *testing.T) { "vars":[],

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #450: feat: add publish status to route in manager api

2020-09-14 Thread GitBox
liuxiran commented on a change in pull request #450: URL: https://github.com/apache/apisix-dashboard/pull/450#discussion_r488259506 ## File path: api/route/route_test.go ## @@ -98,39 +153,41 @@ func TestCreateRouteWithCreateNewGroup(t *testing.T) { "vars":[],

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2192: feat: add AK/SK auth plugin

2020-09-14 Thread GitBox
Firstsawyou commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r488101612 ## File path: apisix/plugins/hmac-auth.lua ## @@ -0,0 +1,303 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +--

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2192: feat: add AK/SK auth plugin

2020-09-14 Thread GitBox
Firstsawyou commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r488095303 ## File path: apisix/plugins/hmac-auth.lua ## @@ -0,0 +1,303 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +--

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2192: feat: add AK/SK auth plugin

2020-09-14 Thread GitBox
Firstsawyou commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r488073128 ## File path: apisix/plugins/hmac-auth.lua ## @@ -0,0 +1,298 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +--

[GitHub] [apisix] nic-chen commented on a change in pull request #2192: feat: add AK/SK auth plugin

2020-09-14 Thread GitBox
nic-chen commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r488064180 ## File path: apisix/plugins/hmac-auth.lua ## @@ -0,0 +1,303 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +--

[GitHub] [apisix] nic-chen commented on a change in pull request #2192: feat: add AK/SK auth plugin

2020-09-14 Thread GitBox
nic-chen commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r488063399 ## File path: apisix/plugins/hmac-auth.lua ## @@ -0,0 +1,303 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +--

[GitHub] [apisix] nic-chen commented on a change in pull request #2192: feat: add AK/SK auth plugin

2020-09-14 Thread GitBox
nic-chen commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r488062025 ## File path: doc/zh-cn/plugins/hmac-auth.md ## @@ -0,0 +1,157 @@ + + +- [English](../../plugins/hmac-auth.md) + +# 目录 +- [**名字**](#名字) +- [**属性**](#属性)

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #450: feat: add publish status to route in manager api

2020-09-14 Thread GitBox
nic-chen commented on a change in pull request #450: URL: https://github.com/apache/apisix-dashboard/pull/450#discussion_r488057502 ## File path: api/route/route_test.go ## @@ -98,39 +153,41 @@ func TestCreateRouteWithCreateNewGroup(t *testing.T) { "vars":[],

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2192: feat: add AK/SK auth plugin

2020-09-14 Thread GitBox
Firstsawyou commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r487997453 ## File path: apisix/plugins/hmac-auth.lua ## @@ -0,0 +1,303 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +--

[GitHub] [apisix] Yiyiyimu commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

2020-09-14 Thread GitBox
Yiyiyimu commented on a change in pull request #2036: URL: https://github.com/apache/apisix/pull/2036#discussion_r488042113 ## File path: .travis/linux_tengine_runner.sh ## @@ -259,6 +259,12 @@ do_install() { sudo luarocks install luacheck > build.log 2>&1 || (cat

[GitHub] [apisix] moonming commented on a change in pull request #2225: move etcd cluster in docker for CI

2020-09-14 Thread GitBox
moonming commented on a change in pull request #2225: URL: https://github.com/apache/apisix/pull/2225#discussion_r488032627 ## File path: .github/workflows/build.yml ## @@ -28,9 +28,13 @@ jobs: #

[GitHub] [apisix] moonming commented on a change in pull request #2225: move etcd cluster in docker for CI

2020-09-14 Thread GitBox
moonming commented on a change in pull request #2225: URL: https://github.com/apache/apisix/pull/2225#discussion_r488031603 ## File path: .github/workflows/build.yml ## @@ -28,9 +28,13 @@ jobs: #

[GitHub] [apisix] moonming commented on a change in pull request #2192: feat: add AK/SK auth plugin

2020-09-14 Thread GitBox
moonming commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r488027011 ## File path: t/plugin/custom_hmac_auth.t ## @@ -0,0 +1,364 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

[GitHub] [apisix] moonming commented on a change in pull request #2192: feat: add AK/SK auth plugin

2020-09-14 Thread GitBox
moonming commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r488025254 ## File path: apisix/plugins/hmac-auth.lua ## @@ -0,0 +1,303 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +--

[GitHub] [apisix] Yiyiyimu commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

2020-09-14 Thread GitBox
Yiyiyimu commented on a change in pull request #2036: URL: https://github.com/apache/apisix/pull/2036#discussion_r488019814 ## File path: t/core/etcd-auth-fail.t ## @@ -18,24 +18,33 @@ BEGIN { $ENV{"ETCD_ENABLE_AUTH"} = "false" } -use t::APISIX 'no_plan'; +use

[GitHub] [apisix] Yiyiyimu commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

2020-09-14 Thread GitBox
Yiyiyimu commented on a change in pull request #2036: URL: https://github.com/apache/apisix/pull/2036#discussion_r488014261 ## File path: apisix/core/config_etcd.lua ## @@ -92,17 +105,29 @@ local function waitdir(etcd_cli, key, modified_index, timeout) return nil,

[GitHub] [apisix] membphis commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

2020-09-14 Thread GitBox
membphis commented on a change in pull request #2036: URL: https://github.com/apache/apisix/pull/2036#discussion_r488008439 ## File path: t/core/etcd.t ## @@ -0,0 +1,335 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

[GitHub] [apisix] Yiyiyimu commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

2020-09-14 Thread GitBox
Yiyiyimu commented on a change in pull request #2036: URL: https://github.com/apache/apisix/pull/2036#discussion_r487997808 ## File path: README.md ## @@ -166,10 +166,9 @@ There are several ways to install the Apache Release version of APISIX: apisix start

[GitHub] [apisix] Yiyiyimu commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

2020-09-14 Thread GitBox
Yiyiyimu commented on a change in pull request #2036: URL: https://github.com/apache/apisix/pull/2036#discussion_r487992864 ## File path: apisix/core/etcd.lua ## @@ -44,24 +49,144 @@ end _M.new = new +local function kvs_to_node(kvs) +local node = {} +node.key =

[GitHub] [apisix] membphis commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

2020-09-14 Thread GitBox
membphis commented on a change in pull request #2036: URL: https://github.com/apache/apisix/pull/2036#discussion_r487990382 ## File path: t/core/etcd.t ## @@ -0,0 +1,335 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

[GitHub] [apisix] membphis commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

2020-09-14 Thread GitBox
membphis commented on a change in pull request #2036: URL: https://github.com/apache/apisix/pull/2036#discussion_r487989714 ## File path: apisix/core/etcd.lua ## @@ -44,24 +49,144 @@ end _M.new = new +local function kvs_to_node(kvs) +local node = {} +node.key =

[GitHub] [apisix] membphis closed issue #2197: request help: How to ensure the security of token without password

2020-09-14 Thread GitBox
membphis closed issue #2197: URL: https://github.com/apache/apisix/issues/2197 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix] membphis commented on issue #2197: request help: How to ensure the security of token without password

2020-09-14 Thread GitBox
membphis commented on issue #2197: URL: https://github.com/apache/apisix/issues/2197#issuecomment-692104510 the client needs to know the valid `user-key` first, then the client can request the source he needs with token. for more information about JWT token, you can take a look at:

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2192: feat: add AK/SK auth plugin

2020-09-14 Thread GitBox
Firstsawyou commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r487970495 ## File path: apisix/plugins/hmac-auth.lua ## @@ -0,0 +1,303 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +--

[GitHub] [apisix] membphis commented on a change in pull request #2192: feat: add AK/SK auth plugin

2020-09-14 Thread GitBox
membphis commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r487958081 ## File path: doc/zh-cn/plugins/hmac-auth.md ## @@ -0,0 +1,157 @@ + + +- [English](../../plugins/hmac-auth.md) + +# 目录 +- [**名字**](#名字) +- [**属性**](#属性)

[GitHub] [apisix] membphis commented on a change in pull request #2192: feat: add AK/SK auth plugin

2020-09-14 Thread GitBox
membphis commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r487937146 ## File path: doc/plugins/hmac-auth.md ## @@ -0,0 +1,156 @@ + + +- [中文](../zh-cn/plugins/hmac-auth.md) + +# Summary +- [**Name**](#name) +-

[GitHub] [apisix-dashboard] juzhiyuan closed issue #457: request help: How to resolve the license conflict in the file header.

2020-09-14 Thread GitBox
juzhiyuan closed issue #457: URL: https://github.com/apache/apisix-dashboard/issues/457 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #457: request help: How to resolve the license conflict in the file header.

2020-09-14 Thread GitBox
juzhiyuan commented on issue #457: URL: https://github.com/apache/apisix-dashboard/issues/457#issuecomment-692076245 closed now, feel free to reopen it if needed. This is an automated message from the Apache Git Service. To

[GitHub] [apisix] membphis commented on a change in pull request #2192: feat: add AK/SK auth plugin

2020-09-14 Thread GitBox
membphis commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r487938697 ## File path: doc/plugins/hmac-auth.md ## @@ -0,0 +1,156 @@ + + +- [中文](../zh-cn/plugins/hmac-auth.md) + +# Summary +- [**Name**](#name) +-

[GitHub] [apisix] gy09535 edited a comment on pull request #2177: feature: support plugin for aliyun log service

2020-09-14 Thread GitBox
gy09535 edited a comment on pull request #2177: URL: https://github.com/apache/apisix/pull/2177#issuecomment-692061891 > @gy09535 Apache APISIX already has the syslog plugin, can these two plugins be combined into one? For combined into one I think the aliyun has some special

[GitHub] [apisix] gy09535 commented on a change in pull request #2177: feature: support plugin for aliyun log service

2020-09-14 Thread GitBox
gy09535 commented on a change in pull request #2177: URL: https://github.com/apache/apisix/pull/2177#discussion_r487799703 ## File path: apisix/plugins/slslog/rfc5424.lua ## @@ -0,0 +1,107 @@ +-- Review comment: I reference it and change some codes ,this codes is not

[GitHub] [apisix] gy09535 commented on pull request #2177: feature: support plugin for aliyun log service

2020-09-14 Thread GitBox
gy09535 commented on pull request #2177: URL: https://github.com/apache/apisix/pull/2177#issuecomment-692061891 > @gy09535 Apache APISIX already has the syslog plugin, can these two plugins be combined into one? For combined into one I think the aliyun has some special config, we

[GitHub] [apisix] membphis commented on a change in pull request #2192: feat: add AK/SK auth plugin

2020-09-14 Thread GitBox
membphis commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r487924251 ## File path: apisix/plugins/hmac-auth.lua ## @@ -0,0 +1,298 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +--

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2192: feat: add AK/SK auth plugin

2020-09-14 Thread GitBox
Firstsawyou commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r487791781 ## File path: apisix/plugins/hmac-auth.lua ## @@ -0,0 +1,298 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +--

[GitHub] [apisix] gy09535 commented on a change in pull request #2177: feature: support plugin for aliyun log service

2020-09-14 Thread GitBox
gy09535 commented on a change in pull request #2177: URL: https://github.com/apache/apisix/pull/2177#discussion_r487800878 ## File path: t/plugin/sls-logger.t ## @@ -0,0 +1,174 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

[GitHub] [apisix] nic-chen commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

2020-09-14 Thread GitBox
nic-chen commented on a change in pull request #2036: URL: https://github.com/apache/apisix/pull/2036#discussion_r487867038 ## File path: t/core/etcd.t ## @@ -0,0 +1,335 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

[GitHub] [apisix] spacewander merged pull request #2185: fix: change the config file when deploying apisix in k8s #2182

2020-09-14 Thread GitBox
spacewander merged pull request #2185: URL: https://github.com/apache/apisix/pull/2185 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[apisix] branch master updated: fix: change the config file when deploying apisix in k8s #2182 (#2185)

2020-09-14 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 2999541 fix: change the config file when

[GitHub] [apisix] tokers commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

2020-09-14 Thread GitBox
tokers commented on a change in pull request #2036: URL: https://github.com/apache/apisix/pull/2036#discussion_r487852649 ## File path: apisix/core/etcd.lua ## @@ -44,24 +49,144 @@ end _M.new = new +local function kvs_to_node(kvs) +local node = {} +node.key =

[GitHub] [apisix] nic-chen commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

2020-09-14 Thread GitBox
nic-chen commented on a change in pull request #2036: URL: https://github.com/apache/apisix/pull/2036#discussion_r487837001 ## File path: apisix/core/etcd.lua ## @@ -44,24 +49,144 @@ end _M.new = new +local function kvs_to_node(kvs) +local node = {} +node.key =

[GitHub] [apisix] EnableAsync opened a new pull request #2225: move etcd cluster in docker for CI

2020-09-14 Thread GitBox
EnableAsync opened a new pull request #2225: URL: https://github.com/apache/apisix/pull/2225 ### What this PR does / why we need it: #2125 move etcd cluster in docker for CI ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or

  1   2   >