[GitHub] [apisix] EnableAsync commented on pull request #2225: move etcd cluster in docker for CI

EnableAsync commented on pull request #2225: URL: https://github.com/apache/apisix/pull/2225#issuecomment-693182195 > I think we could run ETCD as a service in github actions. [doc about github actions

[GitHub] [apisix] membphis commented on a change in pull request #2233: change: check etcd cluster version when init_etcd

membphis commented on a change in pull request #2233: URL: https://github.com/apache/apisix/pull/2233#discussion_r489165395 ## File path: bin/apisix ## @@ -885,20 +939,44 @@ local function init_etcd(show_output) yaml_conf.etcd.host = {yaml_conf.etcd.host} end +

[GitHub] [apisix-dashboard] membphis commented on issue #476: How to configure a TCP upstream by dashboard?

membphis commented on issue #476: URL: https://github.com/apache/apisix-dashboard/issues/476#issuecomment-693164756 that is a todo feature now. @corffee welcome PR or provide your thoughts. This is an automated

[apisix-dashboard] branch refactor updated (13d0e98 -> b1471f9)

This is an automated email from the ASF dual-hosted git repository. vinci pushed a change to branch refactor in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 13d0e98 resolve conflict new 2ee78c7 refference droplet and write a API demo add 54f7a98 add

[apisix-dashboard] 01/02: refference droplet and write a API demo

This is an automated email from the ASF dual-hosted git repository. vinci pushed a commit to branch refactor in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git commit 2ee78c71bf38e076bb2def6e24a07743adcb1ca4 Author: ShiningRush <277040...@qq.com> AuthorDate: Wed Sep 16

[apisix-dashboard] 02/02: Merge remote-tracking branch 'origin/master' into refactor

This is an automated email from the ASF dual-hosted git repository. vinci pushed a commit to branch refactor in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git commit b1471f9db23a3af2636953918572fa5565a7f151 Merge: 2ee78c7 c81f0b9 Author: ShiningRush <277040...@qq.com>

[GitHub] [apisix] moonming commented on pull request #2225: move etcd cluster in docker for CI

moonming commented on pull request #2225: URL: https://github.com/apache/apisix/pull/2225#issuecomment-693154696 got it Thanks, Ming Wen Twitter: _WenMing EnableAsync 于2020年9月16日周三 上午11:40写道： > *@EnableAsync* commented on this pull request. >

[GitHub] [apisix] EnableAsync commented on a change in pull request #2225: move etcd cluster in docker for CI

EnableAsync commented on a change in pull request #2225: URL: https://github.com/apache/apisix/pull/2225#discussion_r489142349 ## File path: .github/workflows/build.yml ## @@ -28,9 +28,13 @@ jobs: #

[GitHub] [apisix] membphis commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

membphis commented on a change in pull request #2036: URL: https://github.com/apache/apisix/pull/2036#discussion_r489141555 ## File path: bin/apisix ## @@ -879,35 +887,35 @@ local function init_etcd(show_output) local host_count = #(yaml_conf.etcd.host) --- check

[apisix-dashboard] branch master updated: feat: added new plugin dependency (#475)

This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new c81f0b9 feat: added new plugin

[apisix] branch master updated (4722198 -> 4c227ad)

This is an automated email from the ASF dual-hosted git repository. wenming pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 4722198 feature: support etcd v3 by mocking v2 API (#2036) add 4c227ad doc: added channel at slack and added

[apisix-dashboard] branch master updated: feat: added new plugin dependency (#475)

This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new c81f0b9 feat: added new plugin

[apisix] branch master updated (4722198 -> 4c227ad)

This is an automated email from the ASF dual-hosted git repository. wenming pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 4722198 feature: support etcd v3 by mocking v2 API (#2036) add 4c227ad doc: added channel at slack and added

[GitHub] [apisix-control-plane] Firstsawyou commented on issue #25: CI: add tools to check ASF headers in code files

Firstsawyou commented on issue #25: URL: https://github.com/apache/apisix-control-plane/issues/25#issuecomment-693147259 solve #26 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [apisix-control-plane] Firstsawyou removed a comment on issue #25: CI: add tools to check ASF headers in code files

Firstsawyou removed a comment on issue #25: URL: https://github.com/apache/apisix-control-plane/issues/25#issuecomment-693146608 solve #26 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix-control-plane] Firstsawyou closed issue #25: CI: add tools to check ASF headers in code files

Firstsawyou closed issue #25: URL: https://github.com/apache/apisix-control-plane/issues/25 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #475: feat: added new plugin dependency

juzhiyuan merged pull request #475: URL: https://github.com/apache/apisix-dashboard/pull/475 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix] moonming merged pull request #2226: doc: added channel at slack and added new qq group.

moonming merged pull request #2226: URL: https://github.com/apache/apisix/pull/2226 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix-control-plane] Firstsawyou commented on issue #25: CI: add tools to check ASF headers in code files

Firstsawyou commented on issue #25: URL: https://github.com/apache/apisix-control-plane/issues/25#issuecomment-693146608 solve #26 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [apisix] tokers opened a new issue #2234: bug: etcd_version in ./bin/apisix is not defined

tokers opened a new issue #2234: URL: https://github.com/apache/apisix/issues/2234 ### Issue description The variable `etcd_version` in ./bin/apisix is not defined, comment see [here](https://github.com/apache/apisix/pull/2036/files#diff-62edadffc237f13dc28a694080d293a8R918).

[GitHub] [apisix] tokers commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

tokers commented on a change in pull request #2036: URL: https://github.com/apache/apisix/pull/2036#discussion_r489129014 ## File path: bin/apisix ## @@ -879,35 +887,35 @@ local function init_etcd(show_output) local host_count = #(yaml_conf.etcd.host) --- check

[GitHub] [apisix] moonming commented on pull request #2233: change: check etcd cluster version when init_etcd

moonming commented on pull request #2233: URL: https://github.com/apache/apisix/pull/2233#issuecomment-693135758 nice! we can fix it in this PR :) Thanks, Ming Wen Twitter: _WenMing Alex Zhang 于2020年9月16日周三 上午10:36写道： > @moonming

[GitHub] [apisix] membphis commented on a change in pull request #2221: send file contents and not file name

membphis commented on a change in pull request #2221: URL: https://github.com/apache/apisix/pull/2221#discussion_r488333965 ## File path: apisix/utils/log-util.lua ## @@ -64,7 +64,11 @@ local function get_full_log(ngx, conf) else local body_file =

[GitHub] [apisix] tokers commented on pull request #2233: change: check etcd cluster version when init_etcd

tokers commented on pull request #2233: URL: https://github.com/apache/apisix/pull/2233#issuecomment-693134034 @moonming I found PR #2036 also checked the etcd version, but IMHO the way is wrong. Firstly, when we ask the version message from etcd, it returns a JSON string like

[GitHub] [apisix] tokers commented on pull request #2233: change: check etcd cluster version when init_etcd

tokers commented on pull request #2233: URL: https://github.com/apache/apisix/pull/2233#issuecomment-693130100 @moonming OK, let me rebase my branch. By the way, i think it's better to check out the CHANGELOG of etcd, AKAIK there are some bugs in 3.x series releases, but i'm not sure the

[GitHub] [apisix] moonming commented on pull request #2233: change: check etcd cluster version when init_etcd

moonming commented on pull request #2233: URL: https://github.com/apache/apisix/pull/2233#issuecomment-693129140 we used to be the default version installed by github actions, now it is the etcd 3.4 version installed manually in https://github.com/apache/apisix/pull/2036

[apisix] branch master updated (b6354ec -> 4722198)

This is an automated email from the ASF dual-hosted git repository. wenming pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from b6354ec feat: allow to limit client body size to protect the service (#2214) add 4722198 feature: support

[GitHub] [apisix] moonming merged pull request #2036: feature: support etcd v3, by mocking v2 API

moonming merged pull request #2036: URL: https://github.com/apache/apisix/pull/2036 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] tokers commented on pull request #2233: change: check etcd cluster version when init_etcd

tokers commented on pull request #2233: URL: https://github.com/apache/apisix/pull/2233#issuecomment-693127956 @moonming It seems the version selection for etcd is not specified in `./bin/apisix` or other stuffs. Is it under the Github Action's control?

[apisix-dashboard] branch master updated: fix: host should not be required (#477)

This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new cf9d5ec fix: host should not be

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #477: fix: host should not be required

juzhiyuan merged pull request #477: URL: https://github.com/apache/apisix-dashboard/pull/477 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix-dashboard] LiteSun opened a new pull request #477: fix: host should not be required

LiteSun opened a new pull request #477: URL: https://github.com/apache/apisix-dashboard/pull/477 Please answer these questions before submitting a pull request - Why submit this pull request? - [x] Bug fix - [ ] New feature provided - [ ] Improve performance - Related

[GitHub] [apisix-dashboard] corffee opened a new issue #476: How to configure a TCP upstream by dashboard?

corffee opened a new issue #476: URL: https://github.com/apache/apisix-dashboard/issues/476 Please answer these questions before submitting your issue. - Why do you submit this issue? - [ 1] Question or discussion - [ ] Bug - [ ] Requirements - [ ] Feature or performance

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #469: Feature: debug a route online

juzhiyuan commented on issue #469: URL: https://github.com/apache/apisix-dashboard/issues/469#issuecomment-693117338 Looks good to me, and this needs a backend to proxy those different origins' requests, I guess this doesn't depend on DB, so feel free to go :D

[GitHub] [apisix-dashboard] juzhiyuan closed issue #474: Publish route failed

juzhiyuan closed issue #474: URL: https://github.com/apache/apisix-dashboard/issues/474 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix-control-plane] moonming merged pull request #26: CI: add tools to check ASF headers in code files

moonming merged pull request #26: URL: https://github.com/apache/apisix-control-plane/pull/26 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[apisix-control-plane] branch master updated: CI: add tools to check ASF headers in code files (#26)

This is an automated email from the ASF dual-hosted git repository. wenming pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-control-plane.git The following commit(s) were added to refs/heads/master by this push: new 729ca37 CI: add tools to check

[GitHub] [apisix] nic-chen commented on pull request #2036: feature: support etcd v3, by mocking v2 API

nic-chen commented on pull request #2036: URL: https://github.com/apache/apisix/pull/2036#issuecomment-693018270 > Currently the log produced by lua-resty-etcd would show message without base64 decode. For example > > ``` > > 2020/09/15 23:18:52 [info] 1964#1964: *2 [lua]

[GitHub] [apisix-dashboard] liuxiran commented on issue #469: Feature: debug a route online

liuxiran commented on issue #469: URL: https://github.com/apache/apisix-dashboard/issues/469#issuecomment-692861654 After research on swagger-ui, and tried to introduce [swagger-ui-react](https://www.npmjs.com/package/swagger-ui-react ) in our project, I found it would be a feasible

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2209: feature: allow empty `service` object, it does not contain any `upstream` and `plugin`.

Firstsawyou commented on a change in pull request #2209: URL: https://github.com/apache/apisix/pull/2209#discussion_r488819427 ## File path: t/admin/schema.t ## @@ -37,10 +37,47 @@ qr/"plugins":\{"type":"object"}/ === TEST 2: get service schema +--- config +location

[GitHub] [apisix-dashboard] liuxiran commented on issue #474: Publish route failed

liuxiran commented on issue #474: URL: https://github.com/apache/apisix-dashboard/issues/474#issuecomment-692790666 > I had updated mysql, you could have a try again. @juzhiyuan @liuxiran passed  This is an

[GitHub] [apisix] Yiyiyimu commented on pull request #2036: feature: support etcd v3, by mocking v2 API

Yiyiyimu commented on pull request #2036: URL: https://github.com/apache/apisix/pull/2036#issuecomment-69271 Currently the log produced by lua-resty-etcd would show message without base64 decode. For example ``` 2020/09/15 23:18:52 [info] 1964#1964: *2 [lua] v3.lua:284: set(): v3

[GitHub] [apisix] Yiyiyimu commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

Yiyiyimu commented on a change in pull request #2036: URL: https://github.com/apache/apisix/pull/2036#discussion_r488751665 ## File path: apisix/core/etcd.lua ## @@ -44,24 +49,144 @@ end _M.new = new +local function kvs_to_node(kvs) +local node = {} +node.key =

[GitHub] [apisix] Yiyiyimu edited a comment on issue #2227: CLI: Check the etcd version in CLI. The version must be 3.4 or greater.

Yiyiyimu edited a comment on issue #2227: URL: https://github.com/apache/apisix/issues/2227#issuecomment-69218 Sorry @tokers I just noticed you pick up this issue. I fixed it in the [new

[GitHub] [apisix] Yiyiyimu commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

Yiyiyimu commented on a change in pull request #2036: URL: https://github.com/apache/apisix/pull/2036#discussion_r488745722 ## File path: apisix/core/etcd.lua ## @@ -44,24 +48,134 @@ end _M.new = new +local function kvs_to_node(kvs) +local node = {} +node.key =

[GitHub] [apisix] Yiyiyimu commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

Yiyiyimu commented on a change in pull request #2036: URL: https://github.com/apache/apisix/pull/2036#discussion_r488739432 ## File path: apisix/core/etcd.lua ## @@ -44,24 +48,134 @@ end _M.new = new +local function kvs_to_node(kvs) +local node = {} +node.key =

[GitHub] [apisix] moonming commented on pull request #2225: move etcd cluster in docker for CI

moonming commented on pull request #2225: URL: https://github.com/apache/apisix/pull/2225#issuecomment-692752316 Cool, agreed nic-chen 于2020年9月15日 周二下午9:34写道： > > > I think we could run ETCD as a service in github actions. doc about > github actions services >

[GitHub] [apisix] Miss-you commented on a change in pull request #2226: doc: added channel at slack and added new qq group.

Miss-you commented on a change in pull request #2226: URL: https://github.com/apache/apisix/pull/2226#discussion_r488705032 ## File path: README_CN.md ## @@ -23,9 +23,11 @@ [![Build

[GitHub] [apisix] spacewander merged pull request #2214: feat: allow to limit client body size to protect the service

spacewander merged pull request #2214: URL: https://github.com/apache/apisix/pull/2214 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[apisix] branch master updated: feat: allow to limit client body size to protect the service (#2214)

This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new b6354ec feat: allow to limit client body

[GitHub] [apisix] nic-chen commented on a change in pull request #2192: feat: add AK/SK auth plugin

nic-chen commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r488680308 ## File path: doc/plugins/hmac-auth.md ## @@ -0,0 +1,151 @@ + + +- [中文](../zh-cn/plugins/hmac-auth.md) + +# Summary +- [**Name**](#name) +-

[GitHub] [apisix] nic-chen commented on a change in pull request #2192: feat: add AK/SK auth plugin

nic-chen commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r488679450 ## File path: doc/zh-cn/plugins/hmac-auth.md ## @@ -0,0 +1,157 @@ + + +- [English](../../plugins/hmac-auth.md) + +# 目录 +- [**名字**](#名字) +- [**属性**](#属性)

[GitHub] [apisix] nic-chen commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

nic-chen commented on a change in pull request #2036: URL: https://github.com/apache/apisix/pull/2036#discussion_r488672188 ## File path: utils/install-etcd.sh ## @@ -0,0 +1,24 @@ +#!/bin/sh + +# +# Licensed to the Apache Software Foundation (ASF) under one or more +#

[GitHub] [apisix] nic-chen commented on pull request #2225: move etcd cluster in docker for CI

nic-chen commented on pull request #2225: URL: https://github.com/apache/apisix/pull/2225#issuecomment-692717762 I think we could run ETCD as a service in github actions. [doc about github actions

[GitHub] [apisix-dashboard] nic-chen commented on issue #474: Publish route failed

nic-chen commented on issue #474: URL: https://github.com/apache/apisix-dashboard/issues/474#issuecomment-692708138 I had updated mysql, you could have a try again. @juzhiyuan @liuxiran This is an automated message from

[GitHub] [apisix-control-plane] Firstsawyou opened a new pull request #26: CI: add tools to check ASF headers in code files #25

Firstsawyou opened a new pull request #26: URL: https://github.com/apache/apisix-control-plane/pull/26 add license check. This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix] moonming commented on issue #2188: request help: url_block.lua plugin: Is there any performance bottleneck if there are many block rules, say 1000000 url rules in production envirom

moonming commented on issue #2188: URL: https://github.com/apache/apisix/issues/2188#issuecomment-692680602 > Can we divide the 1+ million block urls into groups according to their hosts? > > === > > @spacewander the whole 1+million urls only for one host(upstream) :)

[GitHub] [apisix] juzhiyuan commented on a change in pull request #2226: doc: added channel at slack and added new qq group.

juzhiyuan commented on a change in pull request #2226: URL: https://github.com/apache/apisix/pull/2226#discussion_r488623153 ## File path: README.md ## @@ -23,9 +23,11 @@ [![Build

[GitHub] [apisix] moonming commented on issue #2188: request help: url_block.lua plugin: Is there any performance bottleneck if there are many block rules, say 1000000 url rules in production envirom

moonming commented on issue #2188: URL: https://github.com/apache/apisix/issues/2188#issuecomment-692679685 > Improving performance mainly depends on the quality of the rules. > > For runtime selection, if better performance is required, streaming matching such as hyperscan is

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #474: Publish route failed

juzhiyuan commented on issue #474: URL: https://github.com/apache/apisix-dashboard/issues/474#issuecomment-692679130 not sure, cc @nic-chen This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix] moonming closed issue #2176: request help: How to configure timeout settings?

moonming closed issue #2176: URL: https://github.com/apache/apisix/issues/2176 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix] moonming commented on pull request #2233: change: check etcd cluster version when init_etcd

moonming commented on pull request #2233: URL: https://github.com/apache/apisix/pull/2233#issuecomment-692677880 the etcd in CI is 3.2, so failed: https://github.com/apache/apisix/pull/2233/checks?check_run_id=1116987808#step:6:288

[GitHub] [apisix] fankeke commented on issue #2188: request help: url_block.lua plugin: Is there any performance bottleneck if there are many block rules, say 1000000 url rules in production envirome

fankeke commented on issue #2188: URL: https://github.com/apache/apisix/issues/2188#issuecomment-692671931 Can we divide the 1+ million block urls into groups according to their hosts? === @spacewander the whole 1+million urls only for one host(upstream) :)

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2209: feature: allow empty `service` object, it does not contain any `upstream` and `plugin`.

Firstsawyou commented on a change in pull request #2209: URL: https://github.com/apache/apisix/pull/2209#discussion_r488599115 ## File path: t/admin/services.t ## @@ -1085,3 +1085,50 @@ GET /t --- error_code: 400 --- no_error_log [error] + + + +=== TEST 31: set service(id:

[GitHub] [apisix] membphis commented on a change in pull request #2192: feat: add AK/SK auth plugin

membphis commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r488558126 ## File path: t/plugin/hmac-auth.t ## @@ -0,0 +1,596 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

[GitHub] [apisix] membphis commented on a change in pull request #2192: feat: add AK/SK auth plugin

membphis commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r488557288 ## File path: doc/plugins/hmac-auth.md ## @@ -0,0 +1,151 @@ + + +- [中文](../zh-cn/plugins/hmac-auth.md) + +# Summary +- [**Name**](#name) +-

[GitHub] [apisix] membphis commented on a change in pull request #2192: feat: add AK/SK auth plugin

membphis commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r488557091 ## File path: apisix/plugins/hmac-auth.lua ## @@ -0,0 +1,303 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +--

[GitHub] [apisix] xyz2b commented on issue #2176: request help: How to configure timeout settings?

xyz2b commented on issue #2176: URL: https://github.com/apache/apisix/issues/2176#issuecomment-692622830 ok, thanks This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [apisix] gy09535 edited a comment on pull request #2177: feature: support plugin for aliyun log service

gy09535 edited a comment on pull request #2177: URL: https://github.com/apache/apisix/pull/2177#issuecomment-692061891 > @gy09535 Apache APISIX already has the syslog plugin, can these two plugins be combined into one? For combined into one I think the aliyun has some special

[GitHub] [apisix] gy09535 edited a comment on pull request #2177: feature: support plugin for aliyun log service

gy09535 edited a comment on pull request #2177: URL: https://github.com/apache/apisix/pull/2177#issuecomment-692061891 > @gy09535 Apache APISIX already has the syslog plugin, can these two plugins be combined into one? For combined into one I think the aliyun has some special

[GitHub] [apisix] tokers opened a new pull request #2233: change: check etcd cluster version when init_etcd

tokers opened a new pull request #2233: URL: https://github.com/apache/apisix/pull/2233 Signed-off-by: tokers ### What this PR does / why we need it: ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have

[GitHub] [apisix-dashboard] liuxiran commented on issue #470: Proposal: Health Checks for Upstream

liuxiran commented on issue #470: URL: https://github.com/apache/apisix-dashboard/issues/470#issuecomment-692600340 > hi @liuxiran, would you like to implement this feature (if you have free time)? yes, waiting for my pr :)(later this week)

[GitHub] [apisix] moonming commented on pull request #2230: bug: removed default access token for Admin API

moonming commented on pull request #2230: URL: https://github.com/apache/apisix/pull/2230#issuecomment-692560517 No, `YOUR_OWN_API_TOKEN` is just hint in doc, not api token itself. Thanks, Ming Wen Twitter: _WenMing YuanSheng Wang 于2020年9月15日周二 下午4:29写道： >

[GitHub] [apisix] moonming commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

moonming commented on a change in pull request #2036: URL: https://github.com/apache/apisix/pull/2036#discussion_r488484438 ## File path: apisix/core/etcd.lua ## @@ -44,24 +48,134 @@ end _M.new = new +local function kvs_to_node(kvs) +local node = {} +node.key =

[GitHub] [apisix] membphis commented on pull request #2230: bug: removed default access token for Admin API

membphis commented on pull request #2230: URL: https://github.com/apache/apisix/pull/2230#issuecomment-692558053 > I insist on this, if automatic generation token is not possible, I would rather not remove the default token I think they are two different questions. Let us discuss it

[GitHub] [apisix] Yiyiyimu commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

Yiyiyimu commented on a change in pull request #2036: URL: https://github.com/apache/apisix/pull/2036#discussion_r488485180 ## File path: apisix/core/config_etcd.lua ## @@ -92,17 +105,29 @@ local function waitdir(etcd_cli, key, modified_index, timeout) return nil,

[GitHub] [apisix] membphis commented on a change in pull request #2230: bug: removed default access token for Admin API

membphis commented on a change in pull request #2230: URL: https://github.com/apache/apisix/pull/2230#discussion_r488483897 ## File path: bin/apisix ## @@ -643,6 +643,34 @@ local function read_yaml_conf() merge_conf(default_conf, user_conf) end +-- check

[GitHub] [apisix] Yiyiyimu commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

Yiyiyimu commented on a change in pull request #2036: URL: https://github.com/apache/apisix/pull/2036#discussion_r488484262 ## File path: apisix/core/config_etcd.lua ## @@ -92,17 +105,29 @@ local function waitdir(etcd_cli, key, modified_index, timeout) return nil,

[GitHub] [apisix] Yiyiyimu commented on issue #2227: CLI: Check the etcd version in CLI. The version must be 3.4 or greater.

Yiyiyimu commented on issue #2227: URL: https://github.com/apache/apisix/issues/2227#issuecomment-69218 Sorry @tokers I just noticed you pick up this issue. I fixed it in the [new commit](https://github.com/apache/apisix/pull/2036/commits/58e8401a24ceed0313702903103ea4e608128021). But

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2192: feat: add AK/SK auth plugin

Firstsawyou commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r488482999 ## File path: t/plugin/hmac-auth.t ## @@ -0,0 +1,596 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

[GitHub] [apisix] Yiyiyimu edited a comment on pull request #2036: feature: support etcd v3, by mocking v2 API

Yiyiyimu edited a comment on pull request #2036: URL: https://github.com/apache/apisix/pull/2036#issuecomment-692553222 > > one more thing, we need to check the `etcd` version in `bin/apisix`, confirm the `etcd` version `>= 3.4` . > > we can fix this in a new PR, here is the related

[GitHub] [apisix] Yiyiyimu commented on pull request #2036: feature: support etcd v3, by mocking v2 API

Yiyiyimu commented on pull request #2036: URL: https://github.com/apache/apisix/pull/2036#issuecomment-692553222 > > one more thing, we need to check the `etcd` version in `bin/apisix`, confirm the `etcd` version `>= 3.4` . > > we can fix this in a new PR, here is the related issue:

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2192: feat: add AK/SK auth plugin

Firstsawyou commented on a change in pull request #2192: URL: https://github.com/apache/apisix/pull/2192#discussion_r488476189 ## File path: t/plugin/hmac-auth.t ## @@ -0,0 +1,596 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

[GitHub] [apisix] moonming commented on a change in pull request #2036: feature: support etcd v3, by mocking v2 API

moonming commented on a change in pull request #2036: URL: https://github.com/apache/apisix/pull/2036#discussion_r487762501 ## File path: apisix/core/config_etcd.lua ## @@ -92,17 +105,29 @@ local function waitdir(etcd_cli, key, modified_index, timeout) return nil,

[GitHub] [apisix-dashboard] moonming commented on issue #473: PluginModule: v2

moonming commented on issue #473: URL: https://github.com/apache/apisix-dashboard/issues/473#issuecomment-692548163 plugin categories and priority: - limit traffic: limit-req, limit-conn, limit-conn - observability: prometheus, skywalking, zipkin, request-id - security:

[GitHub] [apisix] moonming commented on issue #2232: request help: dashboard 404

moonming commented on issue #2232: URL: https://github.com/apache/apisix/issues/2232#issuecomment-692539013 Only 127.0.0.1 can access the dashboard by default, you can modify the ip limit yourself This is an automated

[GitHub] [apisix] moonming commented on a change in pull request #2230: bug: removed default access token for Admin API

moonming commented on a change in pull request #2230: URL: https://github.com/apache/apisix/pull/2230#discussion_r488454473 ## File path: bin/apisix ## @@ -643,6 +643,34 @@ local function read_yaml_conf() merge_conf(default_conf, user_conf) end +-- check

[GitHub] [apisix] membphis commented on pull request #2230: bug: removed default access token for Admin API

membphis commented on pull request #2230: URL: https://github.com/apache/apisix/pull/2230#issuecomment-692528591 > why `**` is invalid? Is this hard-coded in the code? you can take a look at this source code in CLI:

[GitHub] [apisix] MrJLuo opened a new issue #2232: request help: dashboard 404

MrJLuo opened a new issue #2232: URL: https://github.com/apache/apisix/issues/2232 ### Issue description 

[GitHub] [apisix-dashboard] liuxiran commented on issue #474: Publish route failed

liuxiran commented on issue #474: URL: https://github.com/apache/apisix-dashboard/issues/474#issuecomment-692525992 something like mysql has not been updated, Will mysql be updated synchronously when the demo environment updated? @juzhiyuan

[GitHub] [apisix] moonming opened a new pull request #2231: change: remove dashboard sub module.

moonming opened a new pull request #2231: URL: https://github.com/apache/apisix/pull/2231 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix] moonming commented on pull request #2230: bug: removed default access token for Admin API

moonming commented on pull request #2230: URL: https://github.com/apache/apisix/pull/2230#issuecomment-692518089 why `**` is invalid? Is this hard-coded in the code? Thanks, Ming Wen Twitter: _WenMing YuanSheng Wang 于2020年9月15日周二 下午3:15写道： >

[GitHub] [apisix] membphis commented on pull request #2230: bug: removed default access token for Admin API

membphis commented on pull request #2230: URL: https://github.com/apache/apisix/pull/2230#issuecomment-692516876 > YOUR_OWN_API_TOKEN that is a bad name, because of the `YOUR_OWN_API_TOKEN` is a valid Admin API key. the `**` is a invalid Admin API key. > valid

[GitHub] [apisix] moonming commented on pull request #2230: bug: removed default access token for Admin API

moonming commented on pull request #2230: URL: https://github.com/apache/apisix/pull/2230#issuecomment-692515707 I insist on this, if automatic generation token is not possible, I would rather not remove the default token Thanks, Ming Wen Twitter: _WenMing

[GitHub] [apisix] moonming commented on pull request #2230: bug: removed default access token for Admin API

moonming commented on pull request #2230: URL: https://github.com/apache/apisix/pull/2230#issuecomment-692515133 YOUR_OWN_API_TOKEN Thanks, Ming Wen Twitter: _WenMing YuanSheng Wang 于2020年9月15日周二 下午3:09写道： > *@membphis* commented on this pull request. >

[GitHub] [apisix] membphis edited a comment on pull request #2230: bug: removed default access token for Admin API

membphis edited a comment on pull request #2230: URL: https://github.com/apache/apisix/pull/2230#issuecomment-692513326 > Users will encounter errors when running `apisix start`, and this experience is bad. I think it is good enough for now. We have told the user how to generate the

[GitHub] [apisix] membphis commented on a change in pull request #2230: bug: removed default access token for Admin API

membphis commented on a change in pull request #2230: URL: https://github.com/apache/apisix/pull/2230#discussion_r488435973 ## File path: FAQ.md ## @@ -80,7 +80,7 @@ An example, `foo.com/product/index.html?id=204=2`, gray release based on `i here is the way: ```shell

[GitHub] [apisix] membphis commented on pull request #2230: bug: removed default access token for Admin API

membphis commented on pull request #2230: URL: https://github.com/apache/apisix/pull/2230#issuecomment-692513326 > Users will encounter errors when running `apisix start`, and this experience is bad. I think it is enough for now. We have told the user how to generate the Admin API

[GitHub] [apisix] moonming commented on issue #2227: CLI: Check the etcd version in CLI. The version must be 3.4 or greater.

moonming commented on issue #2227: URL: https://github.com/apache/apisix/issues/2227#issuecomment-692510383 sure, assigned to you @tokers This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix] moonming commented on a change in pull request #2230: bug: removed default access token for Admin API

moonming commented on a change in pull request #2230: URL: https://github.com/apache/apisix/pull/2230#discussion_r488430805 ## File path: FAQ.md ## @@ -80,7 +80,7 @@ An example, `foo.com/product/index.html?id=204=2`, gray release based on `i here is the way: ```shell

  1   2   >