[GitHub] [apisix] gy09535 commented on issue #2249: feat: build docker image with source code

gy09535 commented on issue #2249: URL: https://github.com/apache/apisix/issues/2249#issuecomment-694691589 I think it can not build code from local repos > is https://github.com/apache/apisix-docker good for you? I think it can not build images from our private repository for

[GitHub] [apisix] TigerGxl opened a new issue #2257: request help: http_to_https ret_code 307 not working

TigerGxl opened a new issue #2257: URL: https://github.com/apache/apisix/issues/2257 ### Issue description ### Environment * apisix version (cmd: `apisix version`):1.5 * OS:ubuntu16.04 i use plugin http_to_https and set ret_code 307, like below. ``` { "

[GitHub] [apisix] moonming opened a new issue #2256: request: add the dependency of lua-resty-hmac

moonming opened a new issue #2256: URL: https://github.com/apache/apisix/issues/2256 Now Apache APISIX does not declare the dependency on lua-resty-hmac, but implicitly installs it through [lua-resty-jwt](https://luarocks.org/modules/cdbattags/lua-resty-jwt). There are two problems with t

[GitHub] [apisix] moonming commented on a change in pull request #2241: draft: `consumer` provides access to a collection of `service`

moonming commented on a change in pull request #2241: URL: https://github.com/apache/apisix/pull/2241#discussion_r490722963 ## File path: apisix/plugins/consumer-restriction.lua ## @@ -67,26 +81,33 @@ function _M.check_schema(conf) return true end + function _M.access(

[GitHub] [apisix] moonming commented on a change in pull request #2241: draft: `consumer` provides access to a collection of `service`

moonming commented on a change in pull request #2241: URL: https://github.com/apache/apisix/pull/2241#discussion_r490722729 ## File path: t/plugin/consumer-restriction.t ## @@ -540,3 +540,256 @@ GET /hello hello world --- no_error_log [error] + + + +=== TEST 25: create servi

[GitHub] [apisix] moonming commented on issue #2255: request help: apisix upstream create failed: unsupported protocol scheme

moonming commented on issue #2255: URL: https://github.com/apache/apisix/issues/2255#issuecomment-694667634 @nic-chen please take a look This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [apisix] moonming commented on issue #2254: [discuss] add a new field `name` to plugin schema

moonming commented on issue #2254: URL: https://github.com/apache/apisix/issues/2254#issuecomment-694667337 I don't think so, which should be the job of dashboard, especially considering i18n This is an automated message fro

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2241: draft: `consumer` provides access to a collection of `service`

Firstsawyou commented on a change in pull request #2241: URL: https://github.com/apache/apisix/pull/2241#discussion_r490713892 ## File path: t/plugin/consumer-restriction.t ## @@ -540,3 +540,256 @@ GET /hello hello world --- no_error_log [error] + + + +=== TEST 25: create se

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2241: draft: `consumer` provides access to a collection of `service`

Firstsawyou commented on a change in pull request #2241: URL: https://github.com/apache/apisix/pull/2241#discussion_r490688992 ## File path: apisix/plugins/consumer-restriction.lua ## @@ -67,26 +81,33 @@ function _M.check_schema(conf) return true end + function _M.acce

[GitHub] [apisix] ShiningRush commented on issue #2006: bug(cors): attempt to concatenate field 'conf_id' (a nil value)

ShiningRush commented on issue #2006: URL: https://github.com/apache/apisix/issues/2006#issuecomment-694634705 I think this is the same problem, the key point is related with [this comment](https://github.com/apache/apisix/issues/2006#issuecomment-669769777) --

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2241: draft: `consumer` provides access to a collection of `service`

Firstsawyou commented on a change in pull request #2241: URL: https://github.com/apache/apisix/pull/2241#discussion_r490686675 ## File path: apisix/plugins/consumer-restriction.lua ## @@ -67,26 +81,33 @@ function _M.check_schema(conf) return true end + function _M.acce

[GitHub] [apisix] membphis commented on a change in pull request #2241: draft: `consumer` provides access to a collection of `service`

membphis commented on a change in pull request #2241: URL: https://github.com/apache/apisix/pull/2241#discussion_r490686228 ## File path: apisix/plugins/consumer-restriction.lua ## @@ -67,26 +81,33 @@ function _M.check_schema(conf) return true end + function _M.access(

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2241: draft: `consumer` provides access to a collection of `service`

Firstsawyou commented on a change in pull request #2241: URL: https://github.com/apache/apisix/pull/2241#discussion_r490685981 ## File path: t/plugin/consumer-restriction.t ## @@ -540,3 +540,256 @@ GET /hello hello world --- no_error_log [error] + + + +=== TEST 25: create se

[GitHub] [apisix] moonming commented on issue #2249: feat: build docker image with source code

moonming commented on issue #2249: URL: https://github.com/apache/apisix/issues/2249#issuecomment-694633629 is https://github.com/apache/apisix-docker good for you? This is an automated message from the Apache Git Service. To

[GitHub] [apisix] gxthrj commented on pull request #2239: feat: `hmac-auth` add signed headers to calculate signature

gxthrj commented on pull request #2239: URL: https://github.com/apache/apisix/pull/2239#issuecomment-694633423 > @gxthrj do you have time to take a look at this PR? ok This is an automated message from the Apache G

[GitHub] [apisix] membphis commented on a change in pull request #2241: draft: `consumer` provides access to a collection of `service`

membphis commented on a change in pull request #2241: URL: https://github.com/apache/apisix/pull/2241#discussion_r490685703 ## File path: t/plugin/consumer-restriction.t ## @@ -540,3 +540,256 @@ GET /hello hello world --- no_error_log [error] + + + +=== TEST 25: create servi

[GitHub] [apisix] moonming commented on issue #2006: bug(cors): attempt to concatenate field 'conf_id' (a nil value)

moonming commented on issue #2006: URL: https://github.com/apache/apisix/issues/2006#issuecomment-694633467 @membphis please take a look This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [apisix] membphis commented on pull request #2239: feat: `hmac-auth` add signed headers to calculate signature

membphis commented on pull request #2239: URL: https://github.com/apache/apisix/pull/2239#issuecomment-694629791 @gxthrj do you have time to take a look at this PR? This is an automated message from the Apache Git Service. T

[GitHub] [apisix] membphis commented on a change in pull request #2239: feat: `hmac-auth` add signed headers to calculate signature

membphis commented on a change in pull request #2239: URL: https://github.com/apache/apisix/pull/2239#discussion_r490681896 ## File path: apisix/plugins/hmac-auth.lua ## @@ -182,13 +201,25 @@ local function generate_signature(ctx, secret_key, params) canonical_query_st

[GitHub] [apisix] moonming commented on a change in pull request #2241: draft: `consumer` provides access to a collection of `service`

moonming commented on a change in pull request #2241: URL: https://github.com/apache/apisix/pull/2241#discussion_r490671665 ## File path: apisix/plugins/consumer-restriction.lua ## @@ -67,26 +81,33 @@ function _M.check_schema(conf) return true end + function _M.access(

[GitHub] [apisix] Caelebs opened a new issue #2255: request help: apisix upstream create failed: unsupported protocol scheme

Caelebs opened a new issue #2255: URL: https://github.com/apache/apisix/issues/2255 ### Issue description K8s deploy apisix create upstream returns error code 500 ``` {"app":"manager-api","level":"error","line":"route/upstream.go:162","msg":"apisix upstream create failed: Put //%

[GitHub] [apisix] membphis opened a new issue #2254: [discuss] add a new field `name` to plugin schema

membphis opened a new issue #2254: URL: https://github.com/apache/apisix/issues/2254 this field is used for dashboard, it looks more user-friendly. For example, the `name` field of `limit-req` is `Rate Limiting`. T

[GitHub] [apisix] membphis commented on a change in pull request #2241: draft: `consumer` provides access to a collection of `service`

membphis commented on a change in pull request #2241: URL: https://github.com/apache/apisix/pull/2241#discussion_r490674241 ## File path: t/plugin/consumer-restriction.t ## @@ -540,3 +541,256 @@ GET /hello hello world --- no_error_log [error] + + + +=== TEST 25: create servi

[GitHub] [apisix] membphis opened a new pull request #2253: test: before creating and deleting routes in batches, clear all routes first

membphis opened a new pull request #2253: URL: https://github.com/apache/apisix/pull/2253 ### What this PR does / why we need it: the test case is unstable, it runs fail sometimes. current way: before creating and deleting routes in batches, clear all routes first.

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #480: PluginModule v3

juzhiyuan commented on issue #480: URL: https://github.com/apache/apisix-dashboard/issues/480#issuecomment-694608787 cc @LiteSun please set category for plugin orchestration This is an automated message from the Apache Git S

[GitHub] [apisix-dashboard] ShiningRush commented on a change in pull request #484: chore: add structs

ShiningRush commented on a change in pull request #484: URL: https://github.com/apache/apisix-dashboard/pull/484#discussion_r490658451 ## File path: api/internal/core/entity/entity.go ## @@ -11,16 +11,107 @@ type Route struct { Hoststring `json:"host,om

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #485: feat: Route debug

juzhiyuan commented on a change in pull request #485: URL: https://github.com/apache/apisix-dashboard/pull/485#discussion_r490655427 ## File path: src/pages/Route/transform.ts ## @@ -252,3 +252,131 @@ export const transformRouteData = (data: RouteModule.Body) => { step3Da

[GitHub] [apisix] huzhewei commented on issue #2248: request help: apisix start error:init_by_lua error : no pcre jit support found

huzhewei commented on issue #2248: URL: https://github.com/apache/apisix/issues/2248#issuecomment-694601507 > Hi @huzhewei I think I met same problem before. I suggest to follow instructions in [doc/install-dependencies](https://github.com/apache/apisix/blob/master/doc/install-dependencies

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #485: feat: Route debug

liuxiran commented on a change in pull request #485: URL: https://github.com/apache/apisix-dashboard/pull/485#discussion_r490645695 ## File path: src/pages/Route/transform.ts ## @@ -252,3 +252,131 @@ export const transformRouteData = (data: RouteModule.Body) => { step3Dat

[GitHub] [apisix] spacewander opened a new pull request #2252: test: also lint the test helpers

spacewander opened a new pull request #2252: URL: https://github.com/apache/apisix/pull/2252 Close #2215. ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #485: feat: Route debug

juzhiyuan commented on a change in pull request #485: URL: https://github.com/apache/apisix-dashboard/pull/485#discussion_r490637289 ## File path: src/pages/Route/transform.ts ## @@ -252,3 +252,131 @@ export const transformRouteData = (data: RouteModule.Body) => { step3Da

[GitHub] [apisix-dashboard] liuxiran opened a new pull request #485: feat: Route debug

liuxiran opened a new pull request #485: URL: https://github.com/apache/apisix-dashboard/pull/485 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bug fix - [ ] New feature provided - [ ] Improve performance - Related

[GitHub] [apisix] swayamraina commented on a change in pull request #2221: send file contents and not file name

swayamraina commented on a change in pull request #2221: URL: https://github.com/apache/apisix/pull/2221#discussion_r490512498 ## File path: apisix/utils/log-util.lua ## @@ -64,7 +64,11 @@ local function get_full_log(ngx, conf) else local body_file = ngx.r

[GitHub] [apisix-dashboard] nic-chen opened a new pull request #484: chore: add structs

nic-chen opened a new pull request #484: URL: https://github.com/apache/apisix-dashboard/pull/484 Please answer these questions before submitting a pull request - Why submit this pull request? add structs Th

[GitHub] [apisix] Yiyiyimu commented on issue #2248: request help: apisix start error:init_by_lua error : no pcre jit support found

Yiyiyimu commented on issue #2248: URL: https://github.com/apache/apisix/issues/2248#issuecomment-694282024 Hi @huzhewei I think I met same problem before. I suggest to follow instructions in [doc/install-dependencies](https://github.com/apache/apisix/blob/master/doc/install-dependencies.m

[GitHub] [apisix-docker] Yiyiyimu opened a new issue #75: fix: remove enable-v2=true in etcd config

Yiyiyimu opened a new issue #75: URL: https://github.com/apache/apisix-docker/issues/75 Since apisix would not support etcd v2 anymore This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [apisix-dashboard] LiteSun opened a new pull request #483: feat: improve route

LiteSun opened a new pull request #483: URL: https://github.com/apache/apisix-dashboard/pull/483 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bug fix - [ ] New feature provided - [x] Improve performance - Related

[apisix] branch master updated: bugfix: independently check the "disabled" field to avoid `schema` ve… (#2099)

This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 4f90039 bugfix: independently check the "disa

[GitHub] [apisix] membphis closed issue #2084: request help: Update plugin's schema prometheus & node-status

membphis closed issue #2084: URL: https://github.com/apache/apisix/issues/2084 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [apisix] membphis merged pull request #2099: bugfix: independently check the "disabled" field to avoid `schema` ve…

membphis merged pull request #2099: URL: https://github.com/apache/apisix/pull/2099 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] membphis commented on a change in pull request #2244: bugfix(CLI): if the user used default token and allow any IP to acces…

membphis commented on a change in pull request #2244: URL: https://github.com/apache/apisix/pull/2244#discussion_r490290166 ## File path: bin/apisix ## @@ -799,6 +799,8 @@ version:print the version of apisix ]]) end + +local is_checked_admin_key Review comment:

[GitHub] [apisix] membphis opened a new pull request #2251: chore: get the complete error stack when sync etcd data, it is very u…

membphis opened a new pull request #2251: URL: https://github.com/apache/apisix/pull/2251 …seful when a serious error occurs. ### What this PR does / why we need it: chore: get the complete error stack when sync etcd data, it is very useful when a seriou

[GitHub] [apisix] griffenliu edited a comment on issue #2006: bug(cors): attempt to concatenate field 'conf_id' (a nil value)

griffenliu edited a comment on issue #2006: URL: https://github.com/apache/apisix/issues/2006#issuecomment-694208133 I want to use the prometheus plug-ins. But when I access http://localhost:9080/apisix/prometheus/metrics based on the document https://github.com/apache/apisix/blob/maste

[GitHub] [apisix] gy09535 opened a new pull request #2250: add docker file

gy09535 opened a new pull request #2250: URL: https://github.com/apache/apisix/pull/2250 ### What this PR does / why we need it: fix:https://github.com/apache/apisix/issues/2249 ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new feat

[GitHub] [apisix] gy09535 opened a new issue #2249: feat: build docker image with source code

gy09535 opened a new issue #2249: URL: https://github.com/apache/apisix/issues/2249 ### Issue description Sometime we should add some special logical for ourself business, we should build docker image with source code. So maybe we should add dockerfile in source code. ### Environmen

[GitHub] [apisix] griffenliu edited a comment on issue #2006: bug(cors): attempt to concatenate field 'conf_id' (a nil value)

griffenliu edited a comment on issue #2006: URL: https://github.com/apache/apisix/issues/2006#issuecomment-694208133 I want to use the prometheus plug-ins. But when I access http://localhost:9080/apisix/prometheus/metrics by document https://github.com/apache/apisix/blob/master/doc/zh-c

[GitHub] [apisix] griffenliu commented on issue #2006: bug(cors): attempt to concatenate field 'conf_id' (a nil value)

griffenliu commented on issue #2006: URL: https://github.com/apache/apisix/issues/2006#issuecomment-694208133 I want to use the prometheus plug-ins. But when I access http://localhost:9080/apisix/prometheus/metrics by document https://github.com/apache/apisix/blob/master/doc/zh-cn/plugi

[GitHub] [apisix] nic-chen commented on a change in pull request #2239: feat: `hmac-auth` add signed headers to calculate signature

nic-chen commented on a change in pull request #2239: URL: https://github.com/apache/apisix/pull/2239#discussion_r490192846 ## File path: apisix/plugins/hmac-auth.lua ## @@ -182,13 +201,25 @@ local function generate_signature(ctx, secret_key, params) canonical_query_st

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #478: What is the default account password of the dashboard?

juzhiyuan commented on issue #478: URL: https://github.com/apache/apisix-dashboard/issues/478#issuecomment-694171355 It looks working for you when using codes from the master branch, I will close this issue, feel free to reopen it.

[GitHub] [apisix-dashboard] juzhiyuan closed issue #478: What is the default account password of the dashboard?

juzhiyuan closed issue #478: URL: https://github.com/apache/apisix-dashboard/issues/478 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #478: What is the default account password of the dashboard?

juzhiyuan commented on issue #478: URL: https://github.com/apache/apisix-dashboard/issues/478#issuecomment-694171074 > 。。。 > 发现是apisix-dashboard-1.5这个包构建出来的manager-api和apisix1.5可能不配套，用当前最新代码重新构建了一下manager-api的镜像现在可以登录了，数据库的表多了一张。。。 Yep, codes between the master and the 1.5 branch

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #458: bug: When creating a route, host should not be required

juzhiyuan commented on issue #458: URL: https://github.com/apache/apisix-dashboard/issues/458#issuecomment-694170396 ping @LiteSun This is an automated message from the Apache Git Service. To respond to the message, please

[apisix-dashboard] branch feat-plugin updated (5b24ece -> 744af48)

This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch feat-plugin in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 5b24ece fix: host should not be required (#479) add 744af48 feat: update plugin No new revi

[apisix-dashboard] branch feat-plugin created (now 5b24ece)

This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch feat-plugin in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. at 5b24ece fix: host should not be required (#479) No new revisions were added by this update.

[GitHub] [apisix] huzhewei edited a comment on issue #2248: request help: apisix start error:init_by_lua error : no pcre jit support found

huzhewei edited a comment on issue #2248: URL: https://github.com/apache/apisix/issues/2248#issuecomment-694120286 我加了--with-pcre=../pcre-8.4.2后修复了此问题，但是抛出了新问题 nginx[error]: init_by_lua error: ../lualib/ngx/re.lua:47 : missing declaration for symbol 'ngx_http_lua_ffi_exec_regex' --

[GitHub] [apisix-dashboard] juzhiyuan opened a new pull request #482: feat: update plugin

juzhiyuan opened a new pull request #482: URL: https://github.com/apache/apisix-dashboard/pull/482 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bug fix - [ ] New feature provided - [ ] Improve performance - Relate

[apisix-dashboard] branch feat-plugin created (now f1c15e3)

This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch feat-plugin in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. at f1c15e3 feat: update plugin No new revisions were added by this update.

[apisix-dashboard] branch feat-plugin created (now f1c15e3)

This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch feat-plugin in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. at f1c15e3 feat: update plugin No new revisions were added by this update.

[GitHub] [apisix-dashboard] juzhiyuan closed pull request #481: Feat plugin

juzhiyuan closed pull request #481: URL: https://github.com/apache/apisix-dashboard/pull/481 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix-dashboard] juzhiyuan opened a new pull request #481: Feat plugin

juzhiyuan opened a new pull request #481: URL: https://github.com/apache/apisix-dashboard/pull/481 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bug fix - [ ] New feature provided - [ ] Improve performance - Relate

[GitHub] [apisix-dashboard] juzhiyuan closed issue #473: PluginModule: v2

juzhiyuan closed issue #473: URL: https://github.com/apache/apisix-dashboard/issues/473 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #473: PluginModule: v2

juzhiyuan commented on issue #473: URL: https://github.com/apache/apisix-dashboard/issues/473#issuecomment-694152749 Sort the category has been implemented, waiting for Plugin's PR review. This is an automated message from t

[GitHub] [apisix-dashboard] moonming commented on issue #473: PluginModule: v2

moonming commented on issue #473: URL: https://github.com/apache/apisix-dashboard/issues/473#issuecomment-694145651 Looks good for me 琚致远 于2020年9月17日 周四下午6:21写道： > > > [image: image] >

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #473: PluginModule: v2

juzhiyuan commented on issue #473: URL: https://github.com/apache/apisix-dashboard/issues/473#issuecomment-694140592  -

[GitHub] [apisix-dashboard] juzhiyuan opened a new issue #480: PluginModule v3

juzhiyuan opened a new issue #480: URL: https://github.com/apache/apisix-dashboard/issues/480 - [ ] Improve i18n - [ ] icon for plugins - [ ] Disable https://github.com/apache/apisix/pull/2099/files#diff-ed26f75979353d43aa8168d799d931d0R609 --

[GitHub] [apisix] huzhewei commented on issue #2248: request help: apisix start error:init_by_lua error : no pcre jit support found

huzhewei commented on issue #2248: URL: https://github.com/apache/apisix/issues/2248#issuecomment-694120286 我加了--with-pcre=../pcre-8.4.2后修复了此问题，但是抛出了新问题 nginx[error]: init_by_lua error: ../lualib/ngx/re.lua:47 : missing declaration for symbol hnx_http_lua_ffi_exec_regex'' -

[GitHub] [apisix-dashboard] Caelebs commented on issue #478: What is the default account password of the dashboard?

Caelebs commented on issue #478: URL: https://github.com/apache/apisix-dashboard/issues/478#issuecomment-694116308 。。。 发现是apisix-dashboard-1.5这个包构建出来的manager-api和apisix1.5可能不配套，用当前最新代码重新构建了一下manager-api的镜像现在可以登录了，数据库的表多了一张。。。 ---

[GitHub] [apisix] huzhewei opened a new issue #2248: request help: apisix start error:init_by_lua error : no pcre jit support found

huzhewei opened a new issue #2248: URL: https://github.com/apache/apisix/issues/2248 ### Issue description apisix start出现no pcre jit support found，但我本地已经安装了pcre和pcre-devel了 ### Environment * apisix version (cmd: `apisix version`):1.5 * OS:centos6.9 -

[GitHub] [apisix-dashboard] Caelebs commented on issue #478: What is the default account password of the dashboard?

Caelebs commented on issue #478: URL: https://github.com/apache/apisix-dashboard/issues/478#issuecomment-694095697 我重新部署了一下，manager-api的镜像是基于**apisix-dashboard-1.5**这个包里面的/api目录下的Dockerfile构建的，运行起来之后/root/manager-api目录下的conf.json配置看起来应该是正常的 ``` { "conf": { "mysql":{

[GitHub] [apisix-dashboard] moonming commented on pull request #479: fix: host should not be required

moonming commented on pull request #479: URL: https://github.com/apache/apisix-dashboard/pull/479#issuecomment-694093851 > create a route without host in on line demo: http://139.217.190.60/ has got an 500 error: > > ![image](https://user-images.githubusercontent.com/2561857/9344362

[GitHub] [apisix] tokers commented on pull request #2216: improve: use optimistic locking to avoid concurrency problem in admin…

tokers commented on pull request #2216: URL: https://github.com/apache/apisix/pull/2216#issuecomment-694089015 @membphis @moonming Please help me to retry the checks 😂, it's weird that this failure only in linux_tengine. Thi

[GitHub] [apisix-dashboard] liuxiran commented on pull request #479: fix: host should not be required

liuxiran commented on pull request #479: URL: https://github.com/apache/apisix-dashboard/pull/479#issuecomment-694085272 create a route without host in on line demo: http://139.217.190.60/ has got an 500 error: ![image](https://user-images.githubusercontent.com/2561857/93443627-ed04ff80

[GitHub] [apisix] juzhiyuan commented on a change in pull request #2099: bugfix: independently check the "disabled" field to avoid `schema` ve…

juzhiyuan commented on a change in pull request #2099: URL: https://github.com/apache/apisix/pull/2099#discussion_r490067745 ## File path: t/admin/plugins.t ## @@ -61,6 +61,16 @@ GET /apisix/admin/plugins/limit-req --- request GET /apisix/admin/plugins/node-status --- respon

[GitHub] [apisix-website] juzhiyuan commented on issue #74: Apache APISIX's official webpage is at risk of hijacking

juzhiyuan commented on issue #74: URL: https://github.com/apache/apisix-website/issues/74#issuecomment-694081497 need to create an infra ticket if this issue should be fixed. This is an automated message from the Apache Git S

[GitHub] [apisix-website] Miss-you opened a new issue #74: Apache APISIX's official webpage is at risk of hijacking

Miss-you opened a new issue #74: URL: https://github.com/apache/apisix-website/issues/74 Apache APISIX's official webpage is at risk of hijacking Phenomena. 1. search the Apache APISIX website through Baidu or Google, the default is to use the http protocol to access. ![image]

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #473: PluginModule: v2

juzhiyuan commented on issue #473: URL: https://github.com/apache/apisix-dashboard/issues/473#issuecomment-694073003  How about this one? --

[GitHub] [apisix-dashboard] moonming commented on issue #473: PluginModule: v2

moonming commented on issue #473: URL: https://github.com/apache/apisix-dashboard/issues/473#issuecomment-694064330 We can merge the switch and configuration together; or add the logo to the original description position Thanks, Ming Wen Twitter: _WenMing 琚致远 于20

[GitHub] [apisix] sshniro commented on issue #2175: bug: kafka-logger plugin comes with exception logs

sshniro commented on issue #2175: URL: https://github.com/apache/apisix/issues/2175#issuecomment-694064180 @GBXing I assume the issue relies on the connectivity to the Kafka or a bug inside the logger. The batch processor is a standalone module that is used in other loggers and does not ha

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #473: PluginModule: v2

juzhiyuan commented on issue #473: URL: https://github.com/apache/apisix-dashboard/issues/473#issuecomment-694054307  Very crowded I think if removed the description. -

[GitHub] [apisix] ShiningRush commented on issue #2247: feat: `apisix-schema` tool can return the `jsonschema` of route, service, upstream and plugins

ShiningRush commented on issue #2247: URL: https://github.com/apache/apisix/issues/2247#issuecomment-694053177 We maybe need a command to export all resources to a json file at once, such as `./apisix-schem all` It will automatically write the schema into the default directory for ea

[GitHub] [apisix] membphis opened a new issue #2247: feat: one tools can return the definition `jsonschema` of route, service, upstream and plugins

membphis opened a new issue #2247: URL: https://github.com/apache/apisix/issues/2247 I write an example, @ShiningRush please take a look at this design. ```shell $ ./apisix-schema help route # fetch route schema service # fetch service schema upst

[GitHub] [apisix] moonming opened a new pull request #2246: doc: removed qrcode of qq group.

moonming opened a new pull request #2246: URL: https://github.com/apache/apisix/pull/2246 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix] moonming commented on a change in pull request #2244: bugfix(CLI): if the user used default token and allow any IP to acces…

moonming commented on a change in pull request #2244: URL: https://github.com/apache/apisix/pull/2244#discussion_r490027799 ## File path: bin/apisix ## @@ -799,6 +799,8 @@ version:print the version of apisix ]]) end + +local is_checked_admin_key Review comment:

[GitHub] [apisix] moonming commented on a change in pull request #2244: bugfix(CLI): if the user used default token and allow any IP to acces…

moonming commented on a change in pull request #2244: URL: https://github.com/apache/apisix/pull/2244#discussion_r490026730 ## File path: conf/config.yaml ## @@ -21,3 +21,9 @@ # host: # - "http://127.0.0.1:2379"; # +apisix: + admin_key: +- + name: "admin"

[GitHub] [apisix] membphis commented on pull request #2099: bugfix: independently check the "disabled" field to avoid `schema` ve…

membphis commented on pull request #2099: URL: https://github.com/apache/apisix/pull/2099#issuecomment-694025952 @nic-chen do you have time to review this PR ? This is an automated message from the Apache Git Service. To resp

[GitHub] [apisix] moonming merged pull request #2222: fix: return ok in kafka-logger

moonming merged pull request #: URL: https://github.com/apache/apisix/pull/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[apisix] branch master updated: fix: return ok in kafka-logger (#2222)

This is an automated email from the ASF dual-hosted git repository. wenming pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new d050718 fix: return ok in kafka-logger (#)

[GitHub] [apisix] tokers commented on issue #2245: test: add test case

tokers commented on issue #2245: URL: https://github.com/apache/apisix/issues/2245#issuecomment-694019395 @membphis Sure. This is an automated message from the Apache Git Service. To respond to the message, please log on to G