membphis commented on pull request #2329:
URL: https://github.com/apache/apisix/pull/2329#issuecomment-699785979
@idbeta
https://github.com/apache/apisix/pull/2329/checks?check_run_id=1174617370#step:6:132
the CI is failed, please take a look at the output.
membphis commented on a change in pull request #2329:
URL: https://github.com/apache/apisix/pull/2329#discussion_r495700841
##
File path: t/integrationtest/cases/test_etcdlinks.py
##
@@ -0,0 +1,62 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+#
membphis commented on pull request #2331:
URL: https://github.com/apache/apisix/pull/2331#issuecomment-699778067
this way is much better than the old way ^_^
This is an automated message from the Apache Git Service.
To
membphis commented on pull request #2331:
URL: https://github.com/apache/apisix/pull/2331#issuecomment-699777817
@ShiningRush I remember we discussed this method before, you can look at
this PR
This is an automated message
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new 2521a42 fix: improve i18n (#522)
juzhiyuan closed issue #493:
URL: https://github.com/apache/apisix-dashboard/issues/493
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
juzhiyuan merged pull request #522:
URL: https://github.com/apache/apisix-dashboard/pull/522
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
juzhiyuan opened a new issue #2335:
URL: https://github.com/apache/apisix/issues/2335
### Issue description
As the Admin API[1] says, the `key` is only valid when using the `chash`
type, so why it's required in API's request body?
[1]
Firstsawyou commented on a change in pull request #2333:
URL: https://github.com/apache/apisix/pull/2333#discussion_r495679903
##
File path: apisix/core/ctx.lua
##
@@ -96,6 +96,9 @@ do
elseif key == "service_id" then
val = ngx.ctx.api_ctx and
gxthrj commented on issue #2303:
URL: https://github.com/apache/apisix/issues/2303#issuecomment-699758053
I like this proposal very much and think it will be the final form.
This function can be divided into two parts:
1.label && selector；
2. A grayscale upgrade configuration;
membphis commented on a change in pull request #2333:
URL: https://github.com/apache/apisix/pull/2333#discussion_r495678136
##
File path: apisix/core/ctx.lua
##
@@ -96,6 +96,9 @@ do
elseif key == "service_id" then
val = ngx.ctx.api_ctx and
membphis commented on issue #2334:
URL: https://github.com/apache/apisix/issues/2334#issuecomment-699753091
Here is the test file list:
```
$ grep -rn "baidu.com" ./t
./t/node/route-domain.t:40:"baidu.com:80": 0
moonming commented on issue #2334:
URL: https://github.com/apache/apisix/issues/2334#issuecomment-699751702
`github.com` or `apache.org` is better
This is an automated message from the Apache Git Service.
To respond to the
membphis opened a new issue #2334:
URL: https://github.com/apache/apisix/issues/2334
use `baidu.com` is unstable in Github Action.
maybe we can use `www.apple.com` for testing.
This is an automated message from the
spacewander commented on pull request #2331:
URL: https://github.com/apache/apisix/pull/2331#issuecomment-699750265
The original schema check is too floppy. It will let the invalid schema in
`TEST 10: invalid schema, not field given` pass, but when you hit the rule
later, you will be in
tokers commented on issue #2264:
URL: https://github.com/apache/apisix/issues/2264#issuecomment-699748620
@membphis Let me deal it :)
This is an automated message from the Apache Git Service.
To respond to the message,
membphis commented on pull request #2279:
URL: https://github.com/apache/apisix/pull/2279#issuecomment-699747432
@imjoey many thx, merged
This is an automated message from the Apache Git Service.
To respond to the message,
This is an automated email from the ASF dual-hosted git repository.
membphis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new ebe4f66 feat: Add labels for upstream object
membphis merged pull request #2279:
URL: https://github.com/apache/apisix/pull/2279
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
membphis commented on a change in pull request #2312:
URL: https://github.com/apache/apisix/pull/2312#discussion_r495669723
##
File path: apisix/core/config_etcd.lua
##
@@ -416,16 +416,20 @@ local function _automatic_fetch(premature, self)
return
end
-local
membphis commented on issue #2264:
URL: https://github.com/apache/apisix/issues/2264#issuecomment-699746746
> I think the first thing that we can do is splitting this monomeric file
into multiple modules, each as a Lua file, which enhances the readability and
keeps the code base clean.
membphis commented on issue #2264:
URL: https://github.com/apache/apisix/issues/2264#issuecomment-699746419
agree +1 to refactor `bin/apisix`
the CLI is becoming more and more important.
This is an automated message
idbeta commented on pull request #2273:
URL: https://github.com/apache/apisix/pull/2273#issuecomment-699746139
> The `t/integration` is confusing. Actually almost `*.t` files are for
integration test, and only a few of them are unit tests.
> Is there any different between the Python
MrLightSpeed0 commented on issue #2280:
URL: https://github.com/apache/apisix/issues/2280#issuecomment-699743662
Hi Maybe I didnt explain clearly... I dont think the proxy-rewrite will
solve the issue. basically, I am calling from inside a company, which has a
forward proxy to access
idbeta commented on a change in pull request #2329:
URL: https://github.com/apache/apisix/pull/2329#discussion_r495666587
##
File path: t/integrationtest/cases/test_base.py
##
@@ -0,0 +1,106 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+#
idbeta commented on a change in pull request #2329:
URL: https://github.com/apache/apisix/pull/2329#discussion_r495665986
##
File path: t/integrationtest/cases/test_base.py
##
@@ -0,0 +1,106 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+#
idbeta commented on a change in pull request #2329:
URL: https://github.com/apache/apisix/pull/2329#discussion_r495665486
##
File path: t/integrationtest/cases/test_base.py
##
@@ -0,0 +1,106 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+#
idbeta commented on a change in pull request #2329:
URL: https://github.com/apache/apisix/pull/2329#discussion_r495665299
##
File path: t/integrationtest/cases/test_base.py
##
@@ -0,0 +1,106 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+#
idbeta commented on a change in pull request #2329:
URL: https://github.com/apache/apisix/pull/2329#discussion_r495664264
##
File path: .travis/linux_apisix_integrationtest_runner.sh
##
@@ -0,0 +1,167 @@
+#!/usr/bin/env bash
+#
+# Licensed to the Apache Software Foundation
idbeta commented on a change in pull request #2329:
URL: https://github.com/apache/apisix/pull/2329#discussion_r495663724
##
File path: .github/workflows/build.yml
##
@@ -12,7 +12,7 @@ jobs:
fail-fast: false
matrix:
platform: [ubuntu-18.04]
-
MrLightSpeed0 commented on issue #500:
URL:
https://github.com/apache/apisix-dashboard/issues/500#issuecomment-699739985
Hello. I was following the steps mentioned on this page:
https://github.com/apache/apisix-dashboard
I was at this step 4 Build
cd api && go build -o
Firstsawyou commented on a change in pull request #2333:
URL: https://github.com/apache/apisix/pull/2333#discussion_r495660718
##
File path: apisix/core/ctx.lua
##
@@ -96,6 +96,9 @@ do
elseif key == "service_id" then
val = ngx.ctx.api_ctx and
tokers commented on issue #2264:
URL: https://github.com/apache/apisix/issues/2264#issuecomment-699732331
I think the first thing that we can do is splitting this monomeric file into
multiple modules, each as a Lua file, which enhances the readability and keeps
the code base clean.
moonming commented on pull request #2317:
URL: https://github.com/apache/apisix/pull/2317#issuecomment-699728058
> @moonming @membphis merge?
I am not get your point
This is an automated message from the Apache Git
liuhengloveyou commented on pull request #2317:
URL: https://github.com/apache/apisix/pull/2317#issuecomment-699727693
@moonming @membphis merge?
This is an automated message from the Apache Git Service.
To respond to the
moonming commented on issue #2264:
URL: https://github.com/apache/apisix/issues/2264#issuecomment-699727085
@membphis please take a look
This is an automated message from the Apache Git Service.
To respond to the message,
moonming commented on issue #2264:
URL: https://github.com/apache/apisix/issues/2264#issuecomment-699727008
agreed +1
do you have any idea about this?
This is an automated message from the Apache Git Service.
To respond
liuhengloveyou commented on pull request #2329:
URL: https://github.com/apache/apisix/pull/2329#issuecomment-699726799
good for me. 45 commit histories can be rebased into 1.
This is an automated message from the Apache Git
moonming closed issue #2324:
URL: https://github.com/apache/apisix/issues/2324
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
moonming commented on a change in pull request #2333:
URL: https://github.com/apache/apisix/pull/2333#discussion_r495651938
##
File path: apisix/core/ctx.lua
##
@@ -96,6 +96,9 @@ do
elseif key == "service_id" then
val = ngx.ctx.api_ctx and
imjoey commented on a change in pull request #2279:
URL: https://github.com/apache/apisix/pull/2279#discussion_r495651788
##
File path: doc/zh-cn/architecture-design.md
##
@@ -273,6 +273,7 @@ APISIX 的 Upstream 除了基本的复杂均衡算法选择外，还支持对上
|checks
liuhengloveyou commented on pull request #2331:
URL: https://github.com/apache/apisix/pull/2331#issuecomment-699725416
fix which issues?
This is an automated message from the Apache Git Service.
To respond to the message,
membphis commented on pull request #2304:
URL: https://github.com/apache/apisix/pull/2304#issuecomment-699720635
> @liuhengloveyou please update the status
ping @liuhengloveyou
This is an automated message from the
membphis commented on pull request #2301:
URL: https://github.com/apache/apisix/pull/2301#issuecomment-699718637
@nic-chen many thx
This is an automated message from the Apache Git Service.
To respond to the message, please
This is an automated email from the ASF dual-hosted git repository.
membphis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new c375bd0 feat: replace timestamp with date
membphis merged pull request #2301:
URL: https://github.com/apache/apisix/pull/2301
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
liuxiran opened a new pull request #522:
URL: https://github.com/apache/apisix-dashboard/pull/522
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bug fix
- [ ] New feature provided
- [ ] Improve performance
-
Firstsawyou opened a new pull request #2333:
URL: https://github.com/apache/apisix/pull/2333
### What this PR does / why we need it:
fix: #2297
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features
have been added?
Firstsawyou closed pull request #2332:
URL: https://github.com/apache/apisix/pull/2332
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
Firstsawyou opened a new pull request #2332:
URL: https://github.com/apache/apisix/pull/2332
### What this PR does / why we need it:
fix: #2297
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features
have been added?
spacewander removed a comment on pull request #2273:
URL: https://github.com/apache/apisix/pull/2273#issuecomment-699647477
The `t/integration` is confusing. Actually almost `*.t` files are for
integration test, and only a few of them are unit tests.
Is there any different between the
spacewander commented on pull request #2273:
URL: https://github.com/apache/apisix/pull/2273#issuecomment-699647477
The `t/integration` is confusing. Actually almost `*.t` files are for
integration test, and only a few of them are unit tests.
Is there any different between the Python
spacewander commented on pull request #2273:
URL: https://github.com/apache/apisix/pull/2273#issuecomment-699647039
The `t/integration` is confusing. Actually almost `*.t` files are for
integration test, and only a few of them are unit tests.
Is there any different between the Python
membphis closed issue #2275:
URL: https://github.com/apache/apisix/issues/2275
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
This is an automated email from the ASF dual-hosted git repository.
membphis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new b1770d4 feat: support to fetch `route_id`
membphis merged pull request #2326:
URL: https://github.com/apache/apisix/pull/2326
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
moonming commented on issue #519:
URL:
https://github.com/apache/apisix-dashboard/issues/519#issuecomment-699641196
> agree with Snowflake!
lgtm
This is an automated message from the Apache Git Service.
To respond to
juzhiyuan commented on issue #519:
URL:
https://github.com/apache/apisix-dashboard/issues/519#issuecomment-699639150
agree with Snowflake!
This is an automated message from the Apache Git Service.
To respond to the message,
juzhiyuan commented on issue #498:
URL:
https://github.com/apache/apisix-dashboard/issues/498#issuecomment-699639025
> > @juzhiyuan
> > For API parameters, please refer to:
https://github.com/apache/apisix/blob/master/doc/admin-api.md
>
> I'd like to know only APIs listed in
membphis commented on issue #519:
URL:
https://github.com/apache/apisix-dashboard/issues/519#issuecomment-699637825
> uuid is a little heavy(128bit), snowflake is fine(64bit), how do you think?
I think we can make a try with `snowflake` .
Firstsawyou commented on a change in pull request #2326:
URL: https://github.com/apache/apisix/pull/2326#discussion_r495573541
##
File path: t/core/ctx.t
##
@@ -155,3 +155,264 @@ GET /t?a=aaa
--- error_code: 500
--- error_log
invalid argument, expect string value
+
+
+
+===
membphis commented on a change in pull request #2279:
URL: https://github.com/apache/apisix/pull/2279#discussion_r495573065
##
File path: doc/zh-cn/architecture-design.md
##
@@ -273,6 +273,7 @@ APISIX 的 Upstream 除了基本的复杂均衡算法选择外，还支持对上
|checks
membphis commented on a change in pull request #2279:
URL: https://github.com/apache/apisix/pull/2279#discussion_r495572938
##
File path: apisix/schema_def.lua
##
@@ -332,6 +332,10 @@ local upstream_schema = {
description = "enable websocket for request",
ShiningRush commented on issue #519:
URL:
https://github.com/apache/apisix-dashboard/issues/519#issuecomment-699633934
OK, I got it. I think it not a good way that using etcd revision as key.
When two request arrive the server at same time, the later request will
cover the former,
nic-chen commented on issue #519:
URL:
https://github.com/apache/apisix-dashboard/issues/519#issuecomment-699630464
> I understand the scenario we are taking about is that user does not give
primary key in `PUT` request, right?
it should be `POST` which means `create`
ShiningRush commented on issue #519:
URL:
https://github.com/apache/apisix-dashboard/issues/519#issuecomment-699629797
I understand the scenario we are taking about is that user does not give
primary key in `PUT` request, right?
ShiningRush edited a comment on issue #498:
URL:
https://github.com/apache/apisix-dashboard/issues/498#issuecomment-699629286
> I'd like to know only APIs listed in this file have been implemented? how
about those APIs?
Here is anyone can tell me what those apis used for? then I
ShiningRush edited a comment on issue #498:
URL:
https://github.com/apache/apisix-dashboard/issues/498#issuecomment-699629286
> I'd like to know only APIs listed in this file have been implemented? how
about those APIs?
Here is anyone can tell me what those apis used for?
ShiningRush commented on issue #498:
URL:
https://github.com/apache/apisix-dashboard/issues/498#issuecomment-699629286
> I'd like to know only APIs listed in this file have been implemented? how
about those APIs?
Here is anyone can tell me what those apis used for?
Firstsawyou commented on a change in pull request #2326:
URL: https://github.com/apache/apisix/pull/2326#discussion_r495566281
##
File path: apisix/core/ctx.lua
##
@@ -89,6 +90,14 @@ do
key = re_gsub(key, "-", "_", "jo")
val = get_var(key,
Firstsawyou commented on a change in pull request #2326:
URL: https://github.com/apache/apisix/pull/2326#discussion_r495566270
##
File path: apisix/core/ctx.lua
##
@@ -89,6 +90,14 @@ do
key = re_gsub(key, "-", "_", "jo")
val = get_var(key,
Firstsawyou commented on a change in pull request #2326:
URL: https://github.com/apache/apisix/pull/2326#discussion_r495566237
##
File path: t/core/ctx.t
##
@@ -155,3 +155,183 @@ GET /t?a=aaa
--- error_code: 500
--- error_log
invalid argument, expect string value
+
+
+
+===
juzhiyuan opened a new pull request #521:
URL: https://github.com/apache/apisix-dashboard/pull/521
- [ ] Upstream
- [ ] Route
- [ ] SSL
- [ ] Consumer
This is an automated message from the Apache Git Service.
To
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a change to branch fe-refactor
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git.
at 60e86f5 feat: update Upstream List
This branch includes the following new commits:
new
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch fe-refactor
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
commit 60e86f5010318e121d6f7dbc7137d020562a8349
Author: juzhiyuan
AuthorDate: Sun Sep 27 18:42:42 2020 +0800
gy09535 commented on a change in pull request #2177:
URL: https://github.com/apache/apisix/pull/2177#discussion_r495557257
##
File path: conf/config-default.yaml
##
@@ -185,6 +185,7 @@ plugins: # plugin list
- proxy-cache
- proxy-mirror
-
juzhiyuan commented on issue #498:
URL:
https://github.com/apache/apisix-dashboard/issues/498#issuecomment-699616533
It means all features related to those APIs will be removed from frontend..
This is an automated message
gy09535 commented on a change in pull request #2177:
URL: https://github.com/apache/apisix/pull/2177#discussion_r495557257
##
File path: conf/config-default.yaml
##
@@ -185,6 +185,7 @@ plugins: # plugin list
- proxy-cache
- proxy-mirror
-
nic-chen commented on issue #498:
URL:
https://github.com/apache/apisix-dashboard/issues/498#issuecomment-699614196
not support relational query yet, so these APIs can't be implemented, and it
will take some time
This
juzhiyuan commented on issue #498:
URL:
https://github.com/apache/apisix-dashboard/issues/498#issuecomment-699612760
> @juzhiyuan
> For API parameters, please refer to:
https://github.com/apache/apisix/blob/master/doc/admin-api.md
I'd like to know only APIs listed in this file
spacewander opened a new pull request #2331:
URL: https://github.com/apache/apisix/pull/2331
### What this PR does / why we need it:
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features
have been added?
* [x]
nic-chen commented on issue #498:
URL:
https://github.com/apache/apisix-dashboard/issues/498#issuecomment-699611624
@juzhiyuan
For API parameters, please refer to:
https://github.com/apache/apisix/blob/master/doc/admin-api.md
nic-chen commented on issue #498:
URL:
https://github.com/apache/apisix-dashboard/issues/498#issuecomment-699611434
@juzhiyuan
I had deployed a online demo for refactored manager api, here is the host
and port: 40.73.92.163:8080
but there are some problems, such as:
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new bef6d84 feat: update pluginchart
juzhiyuan merged pull request #520:
URL: https://github.com/apache/apisix-dashboard/pull/520
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
juzhiyuan closed issue #490:
URL: https://github.com/apache/apisix-dashboard/issues/490
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
moonming commented on pull request #2304:
URL: https://github.com/apache/apisix/pull/2304#issuecomment-699607119
@liuhengloveyou why close this PR?
This is an automated message from the Apache Git Service.
To respond to the
moonming closed issue #2328:
URL: https://github.com/apache/apisix/issues/2328
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
moonming merged pull request #2271:
URL: https://github.com/apache/apisix/pull/2271
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
This is an automated email from the ASF dual-hosted git repository.
wenming pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 70bd980 bugfix: avoid overwriting Vary header
moonming commented on pull request #2329:
URL: https://github.com/apache/apisix/pull/2329#issuecomment-699605544
@idbeta you submit many useless codes. please ONLY submit code relate with
this PR.
This is an automated
moonming commented on a change in pull request #2329:
URL: https://github.com/apache/apisix/pull/2329#discussion_r495546079
##
File path: .github/workflows/build.yml
##
@@ -12,7 +12,7 @@ jobs:
fail-fast: false
matrix:
platform: [ubuntu-18.04]
-
liuhengloveyou closed pull request #2304:
URL: https://github.com/apache/apisix/pull/2304
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
MrJLuo closed issue #2207:
URL: https://github.com/apache/apisix/issues/2207
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
LiteSun opened a new pull request #520:
URL: https://github.com/apache/apisix-dashboard/pull/520
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bug fix
- [x] New feature provided
- [ ] Improve performance
- Related
moonming commented on a change in pull request #2177:
URL: https://github.com/apache/apisix/pull/2177#discussion_r495541329
##
File path: apisix/plugins/sls-logger.lua
##
@@ -0,0 +1,213 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+--
xyz2b opened a new issue #2330:
URL: https://github.com/apache/apisix/issues/2330
### Issue description
Apisix host configuration of route can not be '*' ?
I test
imjoey commented on pull request #2279:
URL: https://github.com/apache/apisix/pull/2279#issuecomment-699594693
@membphis @nic-chen @gxthrj PR updated and any feedback would be much
appreciated.
This is an automated
liuhengloveyou commented on a change in pull request #2177:
URL: https://github.com/apache/apisix/pull/2177#discussion_r495537365
##
File path: apisix/plugins/sls-logger.lua
##
@@ -0,0 +1,213 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+--
liuhengloveyou commented on a change in pull request #2177:
URL: https://github.com/apache/apisix/pull/2177#discussion_r495536938
##
File path: conf/config-default.yaml
##
@@ -185,6 +185,7 @@ plugins: # plugin list
- proxy-cache
- proxy-mirror
1 - 100 of 109 matches
Mail list logo
