[GitHub] [apisix-dashboard] nic-chen commented on issue #746: Bugs in GenericStore.Create and GenericStore.Update

2020-12-13 Thread GitBox
nic-chen commented on issue #746: URL: https://github.com/apache/apisix-dashboard/issues/746#issuecomment-744218492 ping @tokers This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [apisix-dashboard] nic-chen closed issue #777: user name is empty

2020-12-13 Thread GitBox
nic-chen closed issue #777: URL: https://github.com/apache/apisix-dashboard/issues/777 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] nic-chen commented on issue #777: user name is empty

2020-12-13 Thread GitBox
nic-chen commented on issue #777: URL: https://github.com/apache/apisix-dashboard/issues/777#issuecomment-744218059 close first. if you have the problem feel free to reopen This is an automated message from the Apache Git

[GitHub] [apisix-dashboard] nic-chen closed issue #941: test: need to do custom check for plugins

2020-12-13 Thread GitBox
nic-chen closed issue #941: URL: https://github.com/apache/apisix-dashboard/issues/941 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] nic-chen commented on issue #941: test: need to do custom check for plugins

2020-12-13 Thread GitBox
nic-chen commented on issue #941: URL: https://github.com/apache/apisix-dashboard/issues/941#issuecomment-744217366 fixing in APISIX: https://github.com/apache/apisix/pull/3021 This is an automated message from the Apache

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #93: chore: gofmt

2020-12-13 Thread GitBox
tokers commented on a change in pull request #93: URL: https://github.com/apache/apisix-ingress-controller/pull/93#discussion_r542150191 ## File path: .github/workflows/lint-checker.yml ## @@ -0,0 +1,28 @@ +name: lint-checker-ci + +on: + push: +branches: + - master

[GitHub] [apisix] idbeta opened a new issue #3035: bug: del upstream but not del route, request the route, return 500

2020-12-13 Thread GitBox
idbeta opened a new issue #3035: URL: https://github.com/apache/apisix/issues/3035 - Why do you submit this issue? - [ ] Question or discussion - [x] Bug - [ ] Requirements - [ ] Feature or performance improvement - [ ] Other ### Bug - Which version of Apache APISIX

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #792: bug: echo plugin can not set headers

2020-12-13 Thread GitBox
juzhiyuan commented on issue #792: URL: https://github.com/apache/apisix-dashboard/issues/792#issuecomment-744215006 closed by https://github.com/apache/apisix-dashboard/pull/898 This is an automated message from the Apache

[GitHub] [apisix-dashboard] nic-chen commented on issue #792: bug: echo plugin can not set headers

2020-12-13 Thread GitBox
nic-chen commented on issue #792: URL: https://github.com/apache/apisix-dashboard/issues/792#issuecomment-744214672 fixed by code-mirror This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix-dashboard] nic-chen closed issue #792: bug: echo plugin can not set headers

2020-12-13 Thread GitBox
nic-chen closed issue #792: URL: https://github.com/apache/apisix-dashboard/issues/792 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] nic-chen commented on issue #872: bug: manager-api should not allow create route with remote_addrs and remote_addr at the same time

2020-12-13 Thread GitBox
nic-chen commented on issue #872: URL: https://github.com/apache/apisix-dashboard/issues/872#issuecomment-744214399 should not support uri, host, remote_addr in Manager API This is an automated message from the Apache Git

[GitHub] [apisix] gewei2000 closed issue #3034: request help: how to set cookie path in apisix

2020-12-13 Thread GitBox
gewei2000 closed issue #3034: URL: https://github.com/apache/apisix/issues/3034 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix] gewei2000 commented on issue #3034: request help: how to set cookie path in apisix

2020-12-13 Thread GitBox
gewei2000 commented on issue #3034: URL: https://github.com/apache/apisix/issues/3034#issuecomment-744212377 > Maybe you can write a plugin to rewrite Set-Cookie response header. 3Q This is an automated message from

[GitHub] [apisix-dashboard] nic-chen closed issue #933: feat: not allowed to specify `create_time` and `update_time` when create/edit route, service, upstream and consumer

2020-12-13 Thread GitBox
nic-chen closed issue #933: URL: https://github.com/apache/apisix-dashboard/issues/933 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix] spacewander commented on issue #3034: request help: how to set cookie path in apisix

2020-12-13 Thread GitBox
spacewander commented on issue #3034: URL: https://github.com/apache/apisix/issues/3034#issuecomment-744209091 Maybe you can write a plugin to rewrite Set-Cookie response header. This is an automated message from the Apache

[GitHub] [apisix-dashboard] nic-chen commented on issue #571: [refactor]missing refactoring apis

2020-12-13 Thread GitBox
nic-chen commented on issue #571: URL: https://github.com/apache/apisix-dashboard/issues/571#issuecomment-744205512 has a new issue to track for it, so close this now. This is an automated message from the Apache Git

[GitHub] [apisix-dashboard] nic-chen closed issue #571: [refactor]missing refactoring apis

2020-12-13 Thread GitBox
nic-chen closed issue #571: URL: https://github.com/apache/apisix-dashboard/issues/571 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] nic-chen commented on issue #984: reject request data if it contains an empty array, eg: "remote_addrs": []

2020-12-13 Thread GitBox
nic-chen commented on issue #984: URL: https://github.com/apache/apisix-dashboard/issues/984#issuecomment-744201652 need e2e test to confirm This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix] gewei2000 commented on issue #3034: request help: how to set cookie path in apisix

2020-12-13 Thread GitBox
gewei2000 commented on issue #3034: URL: https://github.com/apache/apisix/issues/3034#issuecomment-744195647 @spacewander This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix-dashboard] membphis commented on issue #532: fetching category for plugins from APISIX

2020-12-13 Thread GitBox
membphis commented on issue #532: URL: https://github.com/apache/apisix-dashboard/issues/532#issuecomment-744194905 backend todo things: - [ ] sync tools: support to sync more field(eg: type) - [ ] API: `/plugins?all=true`

[GitHub] [apisix-ingress-controller] membphis commented on a change in pull request #93: chore: gofmt

2020-12-13 Thread GitBox
membphis commented on a change in pull request #93: URL: https://github.com/apache/apisix-ingress-controller/pull/93#discussion_r542127606 ## File path: .github/workflows/lint-checker.yml ## @@ -0,0 +1,28 @@ +name: lint-checker-ci + +on: + push: +branches: + -

[GitHub] [apisix-dashboard] tokers commented on pull request #773: chore: introduce corba as the cli scafford

2020-12-13 Thread GitBox
tokers commented on pull request #773: URL: https://github.com/apache/apisix-dashboard/pull/773#issuecomment-744185657 > @tokers conflict again.. Resolved. This is an automated message from the Apache Git Service. To

[GitHub] [apisix-dashboard] liuxiran closed pull request #1026: fix: login bg displayed imcompletely

2020-12-13 Thread GitBox
liuxiran closed pull request #1026: URL: https://github.com/apache/apisix-dashboard/pull/1026 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix-dashboard] liuxiran commented on pull request #1026: fix: login bg displayed imcompletely

2020-12-13 Thread GitBox
liuxiran commented on pull request #1026: URL: https://github.com/apache/apisix-dashboard/pull/1026#issuecomment-744173479 > This background issue is not reproduced in my local environment (latest master branch code), could you please provide more information? @liuxiran >

[GitHub] [apisix] gewei2000 commented on issue #3034: request help: how to set cookie path in apisix

2020-12-13 Thread GitBox
gewei2000 commented on issue #3034: URL: https://github.com/apache/apisix/issues/3034#issuecomment-744168363 > Add this directive to > > https://github.com/apache/apisix/blob/0222db7bf31e022bd69cc28cdac3b41be09b875f/conf/config-default.yaml#L141 > > ? I've added many

[GitHub] [apisix] spacewander commented on issue #3034: request help: how to set cookie path in apisix

2020-12-13 Thread GitBox
spacewander commented on issue #3034: URL: https://github.com/apache/apisix/issues/3034#issuecomment-744153659 Add this directive to https://github.com/apache/apisix/blob/0222db7bf31e022bd69cc28cdac3b41be09b875f/conf/config-default.yaml#L141?

[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #93: chore: gofmt

2020-12-13 Thread GitBox
codecov-io commented on pull request #93: URL: https://github.com/apache/apisix-ingress-controller/pull/93#issuecomment-744153610 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/93?src=pr=h1) Report > Merging

[GitHub] [apisix-ingress-controller] tokers opened a new pull request #93: chore: gofmt

2020-12-13 Thread GitBox
tokers opened a new pull request #93: URL: https://github.com/apache/apisix-ingress-controller/pull/93 Closing #42 . This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix] membphis commented on a change in pull request #2886: feat: provide the ability to view plug-in types

2020-12-13 Thread GitBox
membphis commented on a change in pull request #2886: URL: https://github.com/apache/apisix/pull/2886#discussion_r542099385 ## File path: t/admin/plugins.t ## @@ -166,9 +166,27 @@ plugins: === TEST 8: get all the attributes of all plugins Review comment: add a

[GitHub] [apisix-ingress-controller] Firstsawyou commented on issue #69: API specification for CRDs

2020-12-13 Thread GitBox
Firstsawyou commented on issue #69: URL: https://github.com/apache/apisix-ingress-controller/issues/69#issuecomment-744151110 assigned to me. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix-dashboard] LiteSun opened a new issue #1043: Check markdown links CI failed

2020-12-13 Thread GitBox
LiteSun opened a new issue #1043: URL: https://github.com/apache/apisix-dashboard/issues/1043 # Bug report ![image](https://user-images.githubusercontent.com/31329157/102038915-72655680-3e03-11eb-8e0f-21dc2de24c05.png)

[GitHub] [apisix] gewei2000 opened a new issue #3034: request help: how to set cookie path in apisix

2020-12-13 Thread GitBox
gewei2000 opened a new issue #3034: URL: https://github.com/apache/apisix/issues/3034 ### Issue description how to set cookie path in apisix, such as nginx `proxy_cookie_path /demo/ /` ### Environment * apisix version (cmd: `apisix version`):2.1 * OS:centos7.5

[GitHub] [apisix-ingress-controller] tokers edited a comment on issue #86: CI: code coverage

2020-12-13 Thread GitBox
tokers edited a comment on issue #86: URL: https://github.com/apache/apisix-ingress-controller/issues/86#issuecomment-744144956 Solved the unit test cases part. This is an automated message from the Apache Git Service. To

[GitHub] [apisix-ingress-controller] tokers commented on issue #86: CI: code coverage

2020-12-13 Thread GitBox
tokers commented on issue #86: URL: https://github.com/apache/apisix-ingress-controller/issues/86#issuecomment-744144956 Solved. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [apisix] spacewander commented on issue #3033: Can APISIX be used with The C module of Nginx?

2020-12-13 Thread GitBox
spacewander commented on issue #3033: URL: https://github.com/apache/apisix/issues/3033#issuecomment-744143833 And you can inject custom Nginx configuration via https://github.com/apache/apisix/blob/0222db7bf31e022bd69cc28cdac3b41be09b875f/conf/config-default.yaml#L135

[GitHub] [apisix-ingress-controller] tokers merged pull request #83: chore: api server module

2020-12-13 Thread GitBox
tokers merged pull request #83: URL: https://github.com/apache/apisix-ingress-controller/pull/83 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[apisix-ingress-controller] branch master updated: chore: api server module (#83)

2020-12-13 Thread tokers
This is an automated email from the ASF dual-hosted git repository. tokers pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git The following commit(s) were added to refs/heads/master by this push: new 5812cea chore: api server

[GitHub] [apisix-ingress-controller] tokers opened a new issue #92: project abstraction optimization

2020-12-13 Thread GitBox
tokers opened a new issue #92: URL: https://github.com/apache/apisix-ingress-controller/issues/92 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix] spacewander commented on issue #3033: Can APISIX be used with The C module of Nginx?

2020-12-13 Thread GitBox
spacewander commented on issue #3033: URL: https://github.com/apache/apisix/issues/3033#issuecomment-744143641 Yes. See https://github.com/apache/apisix/issues/2611 This is an automated message from the Apache Git Service.

[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #91: test: add test case for ingress command

2020-12-13 Thread GitBox
codecov-io commented on pull request #91: URL: https://github.com/apache/apisix-ingress-controller/pull/91#issuecomment-744143634 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/91?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base

[GitHub] [apisix] ShenAoScript opened a new issue #3033: Can APISIX be used with The C module of Nginx?

2020-12-13 Thread GitBox
ShenAoScript opened a new issue #3033: URL: https://github.com/apache/apisix/issues/3033 ### Issue description If it needs to be used together with C module, what are the precautions? ### Environment * apisix version (cmd: `apisix version`): 2.0+ * OS: linux

[GitHub] [apisix-ingress-controller] tokers opened a new pull request #91: test: add test case for ingress command

2020-12-13 Thread GitBox
tokers opened a new pull request #91: URL: https://github.com/apache/apisix-ingress-controller/pull/91 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [apisix-dashboard] nic-chen commented on pull request #773: chore: introduce corba as the cli scafford

2020-12-13 Thread GitBox
nic-chen commented on pull request #773: URL: https://github.com/apache/apisix-dashboard/pull/773#issuecomment-744142582 @tokers conflict again.. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix-dashboard] LiteSun commented on pull request #1026: fix: login bg displayed imcompletely

2020-12-13 Thread GitBox
LiteSun commented on pull request #1026: URL: https://github.com/apache/apisix-dashboard/pull/1026#issuecomment-744142188 This background issue is not reproduced in my local environment (latest master branch code), could you please provide more information? @liuxiran

[GitHub] [apisix-dashboard] nic-chen closed pull request #811: feat: support etcd username&

2020-12-13 Thread GitBox
nic-chen closed pull request #811: URL: https://github.com/apache/apisix-dashboard/pull/811 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix-dashboard] nic-chen commented on pull request #811: feat: support etcd username&

2020-12-13 Thread GitBox
nic-chen commented on pull request #811: URL: https://github.com/apache/apisix-dashboard/pull/811#issuecomment-744141743 we have support this feature by other PR #951 . closing this now. This is an automated message from the

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #958: feat: implement API to get apisix instances status

2020-12-13 Thread GitBox
nic-chen commented on a change in pull request #958: URL: https://github.com/apache/apisix-dashboard/pull/958#discussion_r542085785 ## File path: api/test/e2e/server_info_test.go ## @@ -0,0 +1,147 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #820: Support global plugin

2020-12-13 Thread GitBox
juzhiyuan commented on issue #820: URL: https://github.com/apache/apisix-dashboard/issues/820#issuecomment-744140781 after discussion with @membphis @moonming @nic-chen, we have reached an agreement in the general direction, I will update the proposal today: - UE - features in the

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #958: feat: implement API to get apisix instances status

2020-12-13 Thread GitBox
nic-chen commented on a change in pull request #958: URL: https://github.com/apache/apisix-dashboard/pull/958#discussion_r542085107 ## File path: api/internal/handler/server_info/server_info_test.go ## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #979: Refactor online debug be

2020-12-13 Thread GitBox
nic-chen commented on a change in pull request #979: URL: https://github.com/apache/apisix-dashboard/pull/979#discussion_r542083176 ## File path: api/internal/handler/route/route.go ## @@ -397,3 +401,61 @@ func Exist(c *gin.Context) (interface{}, error) { return nil,

[GitHub] [apisix-ingress-controller] gxthrj merged pull request #89: ci: go unit test coverage report

2020-12-13 Thread GitBox
gxthrj merged pull request #89: URL: https://github.com/apache/apisix-ingress-controller/pull/89 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[apisix-ingress-controller] branch master updated: ci: report go unit-test coverage profile (#89)

2020-12-13 Thread kvn
This is an automated email from the ASF dual-hosted git repository. kvn pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git The following commit(s) were added to refs/heads/master by this push: new 7a4000b ci: report go

[apisix-ingress-controller] branch master updated: CI: add spell checker (#90)

2020-12-13 Thread kvn
This is an automated email from the ASF dual-hosted git repository. kvn pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git The following commit(s) were added to refs/heads/master by this push: new 4f2fe71 CI: add spell checker

[GitHub] [apisix-ingress-controller] gxthrj merged pull request #90: c: add spell checker

2020-12-13 Thread GitBox
gxthrj merged pull request #90: URL: https://github.com/apache/apisix-ingress-controller/pull/90 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix] sober-wang closed pull request #3032: Add apisix configmaps yaml file.

2020-12-13 Thread GitBox
sober-wang closed pull request #3032: URL: https://github.com/apache/apisix/pull/3032 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix] spacewander commented on a change in pull request #3032: Add apisix configmaps yaml file.

2020-12-13 Thread GitBox
spacewander commented on a change in pull request #3032: URL: https://github.com/apache/apisix/pull/3032#discussion_r542067516 ## File path: kubernetes/README.md ## @@ -30,6 +30,8 @@ There are some yaml files for deploying apisix in Kubernetes. if you do not need to change

[GitHub] [apisix-ingress-controller] tokers opened a new pull request #90: c: add spell checker

2020-12-13 Thread GitBox
tokers opened a new pull request #90: URL: https://github.com/apache/apisix-ingress-controller/pull/90 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [apisix-ingress-controller] Firstsawyou commented on issue #67: Chore: change the module from `github.com/api7/ingress-controller` to `github.com/apache/apisix-ingress-controller`

2020-12-13 Thread GitBox
Firstsawyou commented on issue #67: URL: https://github.com/apache/apisix-ingress-controller/issues/67#issuecomment-744121959 This looks very interesting, let me try it. ^ _ ^ This is an automated message from the Apache

[GitHub] [apisix] sober-wang opened a new pull request #3032: Add apisix configmaps yaml file.

2020-12-13 Thread GitBox
sober-wang opened a new pull request #3032: URL: https://github.com/apache/apisix/pull/3032 ### What this PR does / why we need it: Add apisix configmaps yaml file. We no longer need to find configuration files from the apisix package

[GitHub] [apisix-dashboard] nic-chen opened a new issue #1042: feat: support global rule in Manager API

2020-12-13 Thread GitBox
nic-chen opened a new issue #1042: URL: https://github.com/apache/apisix-dashboard/issues/1042 # Feature request ## Please describe your feature In the refactoring of version 2.0, we left some APIs that were not implemented in m. Now we need to implement the `global

[GitHub] [apisix-dashboard] moonming commented on issue #820: Support global plugin

2020-12-13 Thread GitBox
moonming commented on issue #820: URL: https://github.com/apache/apisix-dashboard/issues/820#issuecomment-744118249 There is a more obvious problem in this design: The plugin menu bar on the left is not just for global plugins. It can also become a universal plug-in object like service

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #820: Support global plugin

2020-12-13 Thread GitBox
juzhiyuan commented on issue #820: URL: https://github.com/apache/apisix-dashboard/issues/820#issuecomment-744117869 The only difference between your comment and this proposal is, this proposal doesn't have the target rule id, as a global API, why there will have **multiple global**

[GitHub] [apisix] wfgydbu commented on pull request #2935: feat: Implement traffic splitting plugin

2020-12-13 Thread GitBox
wfgydbu commented on pull request #2935: URL: https://github.com/apache/apisix/pull/2935#issuecomment-744116293 > > Hi all, thansk for this great feature! One quick question, In this plugin, how do you deal with healthcheck and > > retry mechanism? are you planning to support it? >

[GitHub] [apisix] tokers commented on issue #3022: feat: support to export the JSON schema of APISIX via `CLI`

2020-12-13 Thread GitBox
tokers commented on issue #3022: URL: https://github.com/apache/apisix/issues/3022#issuecomment-744115550 > We can't load the plugin schema without loading `ngx.*` stuff. What about doing this in control API (#2798)? Agree, otherwise the code base of CLI has to be refactored.

[GitHub] [apisix] tokers commented on pull request #2935: feat: Implement traffic splitting plugin

2020-12-13 Thread GitBox
tokers commented on pull request #2935: URL: https://github.com/apache/apisix/pull/2935#issuecomment-744115371 > Hi all, thansk for this great feature! One quick question, In this plugin, how do you deal with healthcheck and > retry mechanism? are you planning to support it? This

[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #89: Ci/go unit test coverage report

2020-12-13 Thread GitBox
codecov-io edited a comment on pull request #89: URL: https://github.com/apache/apisix-ingress-controller/pull/89#issuecomment-744114416 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/89?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request

[GitHub] [apisix-dashboard] nic-chen commented on issue #842: feat: support run `manager api` as OS service

2020-12-13 Thread GitBox
nic-chen commented on issue #842: URL: https://github.com/apache/apisix-dashboard/issues/842#issuecomment-744115083 > @nic-chen @tokers It depends on building the package for the specific OS, eg: ubuntu, centos. > > I think we can remove milestone `2.3`. OK

[GitHub] [apisix-dashboard] nic-chen commented on issue #820: Support global plugin

2020-12-13 Thread GitBox
nic-chen commented on issue #820: URL: https://github.com/apache/apisix-dashboard/issues/820#issuecomment-744114823 I think the APIs should be consistent with the existing, [refer to](https://github.com/apache/apisix/blob/master/doc/architecture-design.md#Global-Rule): **API: set

[GitHub] [apisix-ingress-controller] tokers commented on pull request #89: Ci/go unit test coverage report

2020-12-13 Thread GitBox
tokers commented on pull request #89: URL: https://github.com/apache/apisix-ingress-controller/pull/89#issuecomment-744114703 @gxthrj @membphis This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #89: Ci/go unit test coverage report

2020-12-13 Thread GitBox
codecov-io commented on pull request #89: URL: https://github.com/apache/apisix-ingress-controller/pull/89#issuecomment-744114416 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/89?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base

[GitHub] [apisix] wfgydbu commented on pull request #2935: feat: Implement traffic splitting plugin

2020-12-13 Thread GitBox
wfgydbu commented on pull request #2935: URL: https://github.com/apache/apisix/pull/2935#issuecomment-744114244 Hi all, thansk for this great feature! One quick question, In this plugin, how do you deal with healthcheck and retry mechanism? are you planning to support it?

[GitHub] [apisix-ingress-controller] tokers opened a new pull request #89: Ci/go unit test coverage report

2020-12-13 Thread GitBox
tokers opened a new pull request #89: URL: https://github.com/apache/apisix-ingress-controller/pull/89 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1037: docs: update CHANGELOG for v2.2

2020-12-13 Thread GitBox
nic-chen commented on a change in pull request #1037: URL: https://github.com/apache/apisix-dashboard/pull/1037#discussion_r542054397 ## File path: CHANGELOG.md ## @@ -19,18 +19,46 @@ # Table of Contents +- [2.2.0](#220) - [2.1.1](#211) - [2.1.0](#210) - [2.0.0](#200)

[GitHub] [apisix] spacewander commented on issue #3022: feat: support to export the JSON schema of APISIX via `CLI`

2020-12-13 Thread GitBox
spacewander commented on issue #3022: URL: https://github.com/apache/apisix/issues/3022#issuecomment-744111790 We can't load the plugin schema without loading `ngx.*` stuff. What about doing this in control API (https://github.com/apache/apisix/issues/2798)?

[apisix-ingress-controller] branch master updated: fix: license header check broken (#88)

2020-12-13 Thread kvn
This is an automated email from the ASF dual-hosted git repository. kvn pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git The following commit(s) were added to refs/heads/master by this push: new ae32397 fix: license header

[GitHub] [apisix-ingress-controller] gxthrj merged pull request #88: fix: license header check broken

2020-12-13 Thread GitBox
gxthrj merged pull request #88: URL: https://github.com/apache/apisix-ingress-controller/pull/88 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix-ingress-controller] tokers opened a new pull request #88: fix: license header check broken

2020-12-13 Thread GitBox
tokers opened a new pull request #88: URL: https://github.com/apache/apisix-ingress-controller/pull/88 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [apisix-ingress-controller] tokers opened a new pull request #87: ci: add semantic.yml

2020-12-13 Thread GitBox
tokers opened a new pull request #87: URL: https://github.com/apache/apisix-ingress-controller/pull/87 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[apisix] branch master updated: docs: corrected typo in doc (#3030)

2020-12-13 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 0222db7 docs: corrected typo in doc

[GitHub] [apisix] spacewander closed issue #3024: bug: some typo errors in the document

2020-12-13 Thread GitBox
spacewander closed issue #3024: URL: https://github.com/apache/apisix/issues/3024 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] spacewander merged pull request #3030: docs: corrected typo in doc

2020-12-13 Thread GitBox
spacewander merged pull request #3030: URL: https://github.com/apache/apisix/pull/3030 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[apisix] branch master updated (2457aa1 -> 839c5d7)

2020-12-13 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 2457aa1 feat: check if Admin API is used with etcd config_center (#3018) add 839c5d7 feat: added

[GitHub] [apisix] spacewander merged pull request #3031: feat: added improve docs issue template

2020-12-13 Thread GitBox
spacewander merged pull request #3031: URL: https://github.com/apache/apisix/pull/3031 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix] tzssangglass commented on issue #3022: feat: support to export the JSON schema of APISIX via `CLI`

2020-12-13 Thread GitBox
tzssangglass commented on issue #3022: URL: https://github.com/apache/apisix/issues/3022#issuecomment-744040229 when APISIX is not running, can export the JSON schema? This is an automated message from the Apache Git

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1037: docs: update CHANGELOG for v2.2

2020-12-13 Thread GitBox
juzhiyuan commented on a change in pull request #1037: URL: https://github.com/apache/apisix-dashboard/pull/1037#discussion_r541946637 ## File path: CHANGELOG.md ## @@ -19,18 +19,46 @@ # Table of Contents +- [2.2.0](#220) - [2.1.1](#211) - [2.1.0](#210) - [2.0.0](#200)

[GitHub] [apisix] membphis merged pull request #3018: feat: check if Admin API is used with etcd config_center

2020-12-13 Thread GitBox
membphis merged pull request #3018: URL: https://github.com/apache/apisix/pull/3018 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[apisix] branch master updated: feat: check if Admin API is used with etcd config_center (#3018)

2020-12-13 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 2457aa1 feat: check if Admin API is used

[GitHub] [apisix-dashboard] juzhiyuan edited a comment on issue #820: Support global plugin

2020-12-13 Thread GitBox
juzhiyuan edited a comment on issue #820: URL: https://github.com/apache/apisix-dashboard/issues/820#issuecomment-744018803 @membphis np, I just updated the proposal about the API part. `Global Plugin` is easier to understand than `Global Rule` IMHO 樂 Let's wait for others

[GitHub] [apisix-dashboard] juzhiyuan edited a comment on issue #820: Support global plugin

2020-12-13 Thread GitBox
juzhiyuan edited a comment on issue #820: URL: https://github.com/apache/apisix-dashboard/issues/820#issuecomment-744018803 @membphis ~~np, I just updated the proposal.~~ `Global Plugin` is easier to understand than `Global Rule` IMHO 樂 Let's wait for others feedback.

[GitHub] [apisix-dashboard] juzhiyuan edited a comment on issue #820: Support global plugin

2020-12-13 Thread GitBox
juzhiyuan edited a comment on issue #820: URL: https://github.com/apache/apisix-dashboard/issues/820#issuecomment-744018803 @membphis ~~np, I just updated the proposal.~~ `Global Plugin` is easier to understand than `Global Rule` IMHO 樂

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #820: Support global plugin

2020-12-13 Thread GitBox
juzhiyuan commented on issue #820: URL: https://github.com/apache/apisix-dashboard/issues/820#issuecomment-744018803 @membphis np, I just updated the proposal. This is an automated message from the Apache Git Service. To

[GitHub] [apisix] membphis edited a comment on issue #3029: request help: Can apisixconvert mqtt protocol to other protocols?

2020-12-13 Thread GitBox
membphis edited a comment on issue #3029: URL: https://github.com/apache/apisix/issues/3029#issuecomment-744017149 The current open source APISIX does not support this feature. This requires additional development to support, if you need any technical support, you can contact me.

[GitHub] [apisix] membphis commented on issue #3029: request help: Can apisixconvert mqtt protocol to other protocols?

2020-12-13 Thread GitBox
membphis commented on issue #3029: URL: https://github.com/apache/apisix/issues/3029#issuecomment-744017149 This requires additional development to support, if you need any technical support, you can contact me. This is an

[GitHub] [apisix-dashboard] membphis edited a comment on issue #1036: Test Framework

2020-12-13 Thread GitBox
membphis edited a comment on issue #1036: URL: https://github.com/apache/apisix-dashboard/issues/1036#issuecomment-744016070 that is an important job, we really need it. I need a front-end testing framework based on visual elements so that community contributors who do not

[GitHub] [apisix-dashboard] membphis commented on issue #1036: Test Framework

2020-12-13 Thread GitBox
membphis commented on issue #1036: URL: https://github.com/apache/apisix-dashboard/issues/1036#issuecomment-744016070 that is an important job, we really need it This is an automated message from the Apache Git Service. To

[GitHub] [apisix-dashboard] membphis commented on issue #613: Deploy Dashboard using RPM package

2020-12-13 Thread GitBox
membphis commented on issue #613: URL: https://github.com/apache/apisix-dashboard/issues/613#issuecomment-744015999 It is an easy job, welcome to take a look at this project(build APISIX RPM): https://github.com/api7/build-tools

[GitHub] [apisix-dashboard] membphis commented on issue #842: feat: support run `manager api` as OS service

2020-12-13 Thread GitBox
membphis commented on issue #842: URL: https://github.com/apache/apisix-dashboard/issues/842#issuecomment-744015632 @nic-chen @tokers It depends on building the package for the specific OS, eg: ubuntu, centos. I think we can remove milestone `2.3`.

[GitHub] [apisix-dashboard] membphis commented on issue #571: [refactor]missing refactoring apis

2020-12-13 Thread GitBox
membphis commented on issue #571: URL: https://github.com/apache/apisix-dashboard/issues/571#issuecomment-744014517 `/apisix/admin/global_rules` we need this API in milestone `2.3`. @nic-chen I think we can create a new issue about this

[GitHub] [apisix] membphis commented on a change in pull request #3021: feat: rewrite handwriting validation with jsonschema

2020-12-13 Thread GitBox
membphis commented on a change in pull request #3021: URL: https://github.com/apache/apisix/pull/3021#discussion_r541933014 ## File path: apisix/plugins/jwt-auth.lua ## @@ -42,12 +42,11 @@ local schema = { local consumer_schema = { type = "object", -

[GitHub] [apisix-dashboard] membphis commented on issue #672: [discuss] use YAML or pretty JSON to store the JSONSchema data

2020-12-13 Thread GitBox
membphis commented on issue #672: URL: https://github.com/apache/apisix-dashboard/issues/672#issuecomment-744013139 I think the priority of this issue is not high, and it is recommended to remove it from the `2.3` milestone.

  1   2   >