[GitHub] [apisix] membphis commented on pull request #1810: feature: support backup node in upstream, the weight of backup node i…

2020-12-22 Thread GitBox
membphis commented on pull request #1810: URL: https://github.com/apache/apisix/pull/1810#issuecomment-749995191 close this PR first. if the community need it, then we can reopen and continue this PR This is an automated

[GitHub] [apisix] membphis closed pull request #1810: feature: support backup node in upstream, the weight of backup node i…

2020-12-22 Thread GitBox
membphis closed pull request #1810: URL: https://github.com/apache/apisix/pull/1810 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2935: feat: Implement traffic splitting plugin

2020-12-22 Thread GitBox
Firstsawyou commented on a change in pull request #2935: URL: https://github.com/apache/apisix/pull/2935#discussion_r547773973 ## File path: apisix/plugins/traffic-split.lua ## @@ -0,0 +1,294 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +--

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2935: feat: Implement traffic splitting plugin

2020-12-22 Thread GitBox
Firstsawyou commented on a change in pull request #2935: URL: https://github.com/apache/apisix/pull/2935#discussion_r547771484 ## File path: apisix/plugins/traffic-split.lua ## @@ -0,0 +1,294 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +--

[GitHub] [apisix-dashboard] membphis commented on a change in pull request #1057: feat: support global rules for Manager API

2020-12-22 Thread GitBox
membphis commented on a change in pull request #1057: URL: https://github.com/apache/apisix-dashboard/pull/1057#discussion_r547771052 ## File path: api/internal/handler/global_rule/global_rule.go ## @@ -50,7 +49,7 @@ func (h *Handler) ApplyRoute(r *gin.Engine) {

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2935: feat: Implement traffic splitting plugin

2020-12-22 Thread GitBox
Firstsawyou commented on a change in pull request #2935: URL: https://github.com/apache/apisix/pull/2935#discussion_r547771484 ## File path: apisix/plugins/traffic-split.lua ## @@ -0,0 +1,294 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +--

[GitHub] [apisix-dashboard] membphis commented on issue #825: [Proposal]: Import & Export route from OpenAPI Specification3.0

2020-12-22 Thread GitBox
membphis commented on issue #825: URL: https://github.com/apache/apisix-dashboard/issues/825#issuecomment-749993175 > cc @membphis LGTM, thx This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix] membphis commented on pull request #3061: draft: add ci on centos7

2020-12-22 Thread GitBox
membphis commented on pull request #3061: URL: https://github.com/apache/apisix/pull/3061#issuecomment-749992823 @idbeta please take a look at the output of CI: https://github.com/apache/apisix/pull/3061/checks?check_run_id=1594094992#step:10:910 ```shell bash:

[GitHub] [apisix-dashboard] starsz opened a new pull request #1107: feat: add spell checker (#1013)

2020-12-22 Thread GitBox
starsz opened a new pull request #1107: URL: https://github.com/apache/apisix-dashboard/pull/1107 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - Related

[GitHub] [apisix-dashboard] membphis commented on issue #1086: support EWMA in upstream balancer

2020-12-22 Thread GitBox
membphis commented on issue #1086: URL: https://github.com/apache/apisix-dashboard/issues/1086#issuecomment-749991743 > May I know what should happen after selecting EWMA? @juzhiyuan same as `roundrobin`

[GitHub] [apisix-docker] membphis commented on pull request #104: docs: fix spelling

2020-12-22 Thread GitBox
membphis commented on pull request #104: URL: https://github.com/apache/apisix-docker/pull/104#issuecomment-749986981 @jbampton CI failed, do you have time to fix it? thx This is an automated message from the Apache Git

[GitHub] [apisix] spacewander commented on a change in pull request #2935: feat: Implement traffic splitting plugin

2020-12-22 Thread GitBox
spacewander commented on a change in pull request #2935: URL: https://github.com/apache/apisix/pull/2935#discussion_r547752819 ## File path: apisix/plugins/traffic-split.lua ## @@ -0,0 +1,294 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +--

[GitHub] [apisix-dashboard] spacewander commented on issue #1085: Store the `script.ID` in the router entity?

2020-12-22 Thread GitBox
spacewander commented on issue #1085: URL: https://github.com/apache/apisix-dashboard/issues/1085#issuecomment-749985034 Yes. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [apisix-dashboard] idbeta commented on a change in pull request #1066: test: add frontend e2e test (create_and_delete_upstream)

2020-12-22 Thread GitBox
idbeta commented on a change in pull request #1066: URL: https://github.com/apache/apisix-dashboard/pull/1066#discussion_r547727677 ## File path: web/cypress/integration/upstream/create_and_delete_upstream.spec.js ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache Software

[GitHub] [apisix-dashboard] idbeta commented on a change in pull request #1066: test: add frontend e2e test (create_and_delete_upstream)

2020-12-22 Thread GitBox
idbeta commented on a change in pull request #1066: URL: https://github.com/apache/apisix-dashboard/pull/1066#discussion_r547725745 ## File path: web/cypress/integration/upstream/create_and_delete_upstream.spec.js ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache Software

[GitHub] [apisix-dashboard] idbeta commented on a change in pull request #1066: test: add frontend e2e test (create_and_delete_upstream)

2020-12-22 Thread GitBox
idbeta commented on a change in pull request #1066: URL: https://github.com/apache/apisix-dashboard/pull/1066#discussion_r547724259 ## File path: web/cypress/integration/upstream/create_and_delete_upstream.spec.js ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache Software

[GitHub] [apisix] moonming commented on pull request #1810: feature: support backup node in upstream, the weight of backup node i…

2020-12-22 Thread GitBox
moonming commented on pull request #1810: URL: https://github.com/apache/apisix/pull/1810#issuecomment-749971949 ping @membphis This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [apisix] moonming closed pull request #1909: Resolves #1902 Different upstreams use different discovery and customize the discovery schema

2020-12-22 Thread GitBox
moonming closed pull request #1909: URL: https://github.com/apache/apisix/pull/1909 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] moonming closed pull request #1372: modify: specify pool_size and backlog for plugin

2020-12-22 Thread GitBox
moonming closed pull request #1372: URL: https://github.com/apache/apisix/pull/1372 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] moonming commented on a change in pull request #3061: draft: add ci on centos7

2020-12-22 Thread GitBox
moonming commented on a change in pull request #3061: URL: https://github.com/apache/apisix/pull/3061#discussion_r547716128 ## File path: .github/workflows/centos7.yml ## @@ -0,0 +1,102 @@ +name: test_apisix_on_centos7 + +on: + push: +branches: + - master +

[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #127: chore: prometheus metrics handler

2020-12-22 Thread GitBox
codecov-io commented on pull request #127: URL: https://github.com/apache/apisix-ingress-controller/pull/127#issuecomment-749961833 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/127?src=pr=h1) Report > Merging

[GitHub] [apisix-ingress-controller] tokers opened a new pull request #127: chore: prometheus metrics handler

2020-12-22 Thread GitBox
tokers opened a new pull request #127: URL: https://github.com/apache/apisix-ingress-controller/pull/127 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [apisix-dashboard] idbeta commented on pull request #1093: test: add frontend e2e test (edit and search route)

2020-12-22 Thread GitBox
idbeta commented on pull request #1093: URL: https://github.com/apache/apisix-dashboard/pull/1093#issuecomment-749960712 @nic-chen Help me run the backend E2E test again for this PR. This is an automated message from the

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1066: test: add frontend e2e test (create_and_delete_upstream)

2020-12-22 Thread GitBox
codecov-io edited a comment on pull request #1066: URL: https://github.com/apache/apisix-dashboard/pull/1066#issuecomment-747915461 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1066?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] Hcreak commented on issue #1103: Select only wolf-rabc in the plugin list when creating consumer,Unable to continue

2020-12-22 Thread GitBox
Hcreak commented on issue #1103: URL: https://github.com/apache/apisix-dashboard/issues/1103#issuecomment-749959687 Thanks for your reply, Do you mean that the next version will put wolf-rbac into the Authentication category to fix this bug?

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1066: test: add frontend e2e test (create_and_delete_upstream)

2020-12-22 Thread GitBox
codecov-io edited a comment on pull request #1066: URL: https://github.com/apache/apisix-dashboard/pull/1066#issuecomment-747915461 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1066?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] idbeta commented on a change in pull request #1066: test: add frontend e2e test (create_and_delete_upstream)

2020-12-22 Thread GitBox
idbeta commented on a change in pull request #1066: URL: https://github.com/apache/apisix-dashboard/pull/1066#discussion_r547696315 ## File path: web/cypress/integration/upstream/create_and_delete_upstream.spec.js ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache Software

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1106: WIP: global plugin

2020-12-22 Thread GitBox
codecov-io commented on pull request #1106: URL: https://github.com/apache/apisix-dashboard/pull/1106#issuecomment-749959121 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1106?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] LiteSun opened a new pull request #1106: WIP: global plugin

2020-12-22 Thread GitBox
LiteSun opened a new pull request #1106: URL: https://github.com/apache/apisix-dashboard/pull/1106 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance -

[GitHub] [apisix-dashboard] idbeta commented on a change in pull request #1066: test: add frontend e2e test (create_and_delete_upstream)

2020-12-22 Thread GitBox
idbeta commented on a change in pull request #1066: URL: https://github.com/apache/apisix-dashboard/pull/1066#discussion_r547687019 ## File path: web/cypress/integration/upstream/create_and_delete_upstream.spec.js ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software

[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #126: chore: go profile

2020-12-22 Thread GitBox
codecov-io commented on pull request #126: URL: https://github.com/apache/apisix-ingress-controller/pull/126#issuecomment-749953311 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/126?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1103: Select only wolf-rabc in the plugin list when creating consumer,Unable to continue

2020-12-22 Thread GitBox
juzhiyuan commented on issue #1103: URL: https://github.com/apache/apisix-dashboard/issues/1103#issuecomment-749953075 BTW, yes, we must enable a Plugin under the Authentication category when creating consumer. This is an

[GitHub] [apisix-ingress-controller] tokers opened a new pull request #126: chore: go profile

2020-12-22 Thread GitBox
tokers opened a new pull request #126: URL: https://github.com/apache/apisix-ingress-controller/pull/126 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1103: Select only wolf-rabc in the plugin list when creating consumer,Unable to continue

2020-12-22 Thread GitBox
juzhiyuan commented on issue #1103: URL: https://github.com/apache/apisix-dashboard/issues/1103#issuecomment-749952723 Hi, please use the latest codes on the master branch. This is an automated message from the Apache Git

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1105: test: add frontend e2e test (smoke test for settings page)

2020-12-22 Thread GitBox
codecov-io commented on pull request #1105: URL: https://github.com/apache/apisix-dashboard/pull/1105#issuecomment-749952748 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1105?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] idbeta opened a new pull request #1105: test: add frontend e2e test (smoke test for settings page)

2020-12-22 Thread GitBox
idbeta opened a new pull request #1105: URL: https://github.com/apache/apisix-dashboard/pull/1105 Please answer these questions before submitting a pull request - Why submit this pull request? - [x] E2E test - [ ] New feature provided - [ ] Improve performance

[GitHub] [apisix-dashboard] membphis commented on a change in pull request #1066: test: add frontend e2e test (create_and_delete_upstream)

2020-12-22 Thread GitBox
membphis commented on a change in pull request #1066: URL: https://github.com/apache/apisix-dashboard/pull/1066#discussion_r547643536 ## File path: web/cypress/integration/upstream/create_and_delete_upstream.spec.js ## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache Software

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1066: test: add frontend e2e test (create_and_delete_upstream)

2020-12-22 Thread GitBox
codecov-io edited a comment on pull request #1066: URL: https://github.com/apache/apisix-dashboard/pull/1066#issuecomment-747915461 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1066?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] membphis commented on a change in pull request #1066: test: add frontend e2e test (create_and_delete_upstream)

2020-12-22 Thread GitBox
membphis commented on a change in pull request #1066: URL: https://github.com/apache/apisix-dashboard/pull/1066#discussion_r547640769 ## File path: web/cypress/integration/upstream/create_and_delete_upstream.spec.js ## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software

[GitHub] [apisix-dashboard] membphis commented on a change in pull request #1066: test: add frontend e2e test (create_and_delete_upstream)

2020-12-22 Thread GitBox
membphis commented on a change in pull request #1066: URL: https://github.com/apache/apisix-dashboard/pull/1066#discussion_r547639576 ## File path: web/cypress/integration/upstream/create_and_delete_upstream.spec.js ## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1104: test: add frontend e2e test (smoke test for metrics page)

2020-12-22 Thread GitBox
codecov-io commented on pull request #1104: URL: https://github.com/apache/apisix-dashboard/pull/1104#issuecomment-749930195 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1104?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] idbeta opened a new pull request #1104: test: add frontend e2e test (smoke test for metrics page)

2020-12-22 Thread GitBox
idbeta opened a new pull request #1104: URL: https://github.com/apache/apisix-dashboard/pull/1104 Please answer these questions before submitting a pull request - Why submit this pull request? - [x] E2E test - [ ] New feature provided - [ ] Improve performance

[GitHub] [apisix-dashboard] membphis commented on issue #1085: Store the `script.ID` in the router entity?

2020-12-22 Thread GitBox
membphis commented on issue #1085: URL: https://github.com/apache/apisix-dashboard/issues/1085#issuecomment-749924833 yes, we need this feature ^_^ APISIX needs to be updated for this feature, all right? @spacewander

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1097: feat: "upstream" i18n

2020-12-22 Thread GitBox
codecov-io edited a comment on pull request #1097: URL: https://github.com/apache/apisix-dashboard/pull/1097#issuecomment-749461997 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr=h1) Report > Merging

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2935: feat: Implement traffic splitting plugin

2020-12-22 Thread GitBox
Firstsawyou commented on a change in pull request #2935: URL: https://github.com/apache/apisix/pull/2935#discussion_r547627744 ## File path: apisix/plugins/traffic-split.lua ## @@ -0,0 +1,294 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +--

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1097: feat: "upstream" i18n

2020-12-22 Thread GitBox
codecov-io edited a comment on pull request #1097: URL: https://github.com/apache/apisix-dashboard/pull/1097#issuecomment-749461997 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] Hcreak opened a new issue #1103: Select only wolf-rabc in the plugin list when creating consumer,Unable to continue

2020-12-22 Thread GitBox
Hcreak opened a new issue #1103: URL: https://github.com/apache/apisix-dashboard/issues/1103 # Bug report ## Describe the bug I follow the steps of the official

[GitHub] [apisix] spacewander commented on issue #3106: consumer-restriction插件使用service_id类型限制不生效

2020-12-22 Thread GitBox
spacewander commented on issue #3106: URL: https://github.com/apache/apisix/issues/3106#issuecomment-749913058 I can reproduce with 2.0, but can't reproduce with master branch. The fix is only on the master branch. Can you try the master branch directly? Remember to stop and restart

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1013: add spell CI tool

2020-12-22 Thread GitBox
juzhiyuan commented on issue #1013: URL: https://github.com/apache/apisix-dashboard/issues/1013#issuecomment-749911321 1. `/web/src` 2. `/web/cypress` This is an automated message from the Apache Git Service. To respond

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1097: feat: "upstream" i18n

2020-12-22 Thread GitBox
codecov-io edited a comment on pull request #1097: URL: https://github.com/apache/apisix-dashboard/pull/1097#issuecomment-749461997 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1097?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1097: feat: "upstream" i18n

2020-12-22 Thread GitBox
juzhiyuan commented on pull request #1097: URL: https://github.com/apache/apisix-dashboard/pull/1097#issuecomment-749908753 ![image](https://user-images.githubusercontent.com/2106987/102956161-9b2bd100-4512-11eb-8f32-657a4bf5f95a.png)

[GitHub] [apisix-dashboard] starsz edited a comment on issue #1013: add spell CI tool

2020-12-22 Thread GitBox
starsz edited a comment on issue #1013: URL: https://github.com/apache/apisix-dashboard/issues/1013#issuecomment-749907366 @juzhiyuan Yes, I will. I want to know which directories should be checked under `web`. This is an

[GitHub] [apisix-dashboard] starsz commented on issue #1013: add spell CI tool

2020-12-22 Thread GitBox
starsz commented on issue #1013: URL: https://github.com/apache/apisix-dashboard/issues/1013#issuecomment-749907366 @juzhiyuan Yes, I will. I want to know which directories should be checked under "web". This is an

[GitHub] [apisix] whioue commented on issue #3106: consumer-restriction插件使用service_id类型限制不生效

2020-12-22 Thread GitBox
whioue commented on issue #3106: URL: https://github.com/apache/apisix/issues/3106#issuecomment-749901211 > Is it solved by #2905? You can try it on the master branch. @spacewander I tried it on version 2.0 and it seems that it has not been solved for the time being

[GitHub] [apisix] whioue removed a comment on issue #3106: consumer-restriction插件使用service_id类型限制不生效

2020-12-22 Thread GitBox
whioue removed a comment on issue #3106: URL: https://github.com/apache/apisix/issues/3106#issuecomment-749900750 > [#2905](https://github.com/apache/apisix/pull/2905)解决了吗?您可以在master分支上尝试。 I tried it on version 2.0 and it seems that it has not been solved for the time being

[GitHub] [apisix] whioue commented on issue #3106: consumer-restriction插件使用service_id类型限制不生效

2020-12-22 Thread GitBox
whioue commented on issue #3106: URL: https://github.com/apache/apisix/issues/3106#issuecomment-749900750 > [#2905](https://github.com/apache/apisix/pull/2905)解决了吗?您可以在master分支上尝试。 I tried it on version 2.0 and it seems that it has not been solved for the time being

[GitHub] [apisix] Firstsawyou opened a new issue #3108: bug: limit-count plugin does not take effect

2020-12-22 Thread GitBox
Firstsawyou opened a new issue #3108: URL: https://github.com/apache/apisix/issues/3108 ### Issue description When the `limit-count` plugin is enabled on `service` and `upstream` is the domain name. This will cause the `local key = (ctx.var[conf.key] or "") .. ctx.conf_type ..

[GitHub] [apisix] spacewander commented on issue #3106: consumer-restriction插件使用service_id类型限制不生效

2020-12-22 Thread GitBox
spacewander commented on issue #3106: URL: https://github.com/apache/apisix/issues/3106#issuecomment-749899492 Is it solved by https://github.com/apache/apisix/pull/2905? You can try it on the master branch. This is an

[GitHub] [apisix] spacewander commented on issue #3100: request help: update dependency: api7/lua-resty-prometheus

2020-12-22 Thread GitBox
spacewander commented on issue #3100: URL: https://github.com/apache/apisix/issues/3100#issuecomment-749899036 PR is welcome! This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [apisix] azura27 opened a new issue #3107: bug: zipkin sampler new delay, and cause error cannot autosolved

2020-12-22 Thread GitBox
azura27 opened a new issue #3107: URL: https://github.com/apache/apisix/issues/3107 ### Issue description When I put a route and visit it whthin 0.3 seconds, It would cause an error in zipkin plugin. Corresponding code is in apisix/apisix/plugins/zipkin.lua : ctx.opentracing_sample =

[GitHub] [apisix] whioue opened a new issue #3106: consumer-restriction插件使用service_id类型限制不生效

2020-12-22 Thread GitBox
whioue opened a new issue #3106: URL: https://github.com/apache/apisix/issues/3106 ### Issue description 想要consumer来绑定服务或路由,所以使用consumer-restriction插件来实现,使用这个插件有两种限制类型,一种是使用consumer_name这个没问题,另一种是service_id使用时,发现文档上实例是key-auth认证,这个没问题,但我使用此插件限制basic-auth时发现无法限制成功 ### Environment

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1089: feat(FE): add service module

2020-12-22 Thread GitBox
codecov-io edited a comment on pull request #1089: URL: https://github.com/apache/apisix-dashboard/pull/1089#issuecomment-748893636 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1089?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] Jaycean opened a new pull request #1102: Import & Export route from OpenAPI Specification3.0

2020-12-22 Thread GitBox
Jaycean opened a new pull request #1102: URL: https://github.com/apache/apisix-dashboard/pull/1102 Signed-off-by: Jacean Import & Export route from OpenAPI Specification3.0 - Why submit this pull request? - [ ] Bugfix - [x] New feature provided - [ ] Improve

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1013: add spell CI tool

2020-12-22 Thread GitBox
juzhiyuan commented on issue #1013: URL: https://github.com/apache/apisix-dashboard/issues/1013#issuecomment-749884647 Hi @starsz, would we invoke a CI to check every PR? This is an automated message from the Apache Git

[GitHub] [apisix-dashboard] juzhiyuan closed issue #1013: add spell CI tool

2020-12-22 Thread GitBox
juzhiyuan closed issue #1013: URL: https://github.com/apache/apisix-dashboard/issues/1013 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix-dashboard] LiteSun merged pull request #1101: fix(FE): misspelling

2020-12-22 Thread GitBox
LiteSun merged pull request #1101: URL: https://github.com/apache/apisix-dashboard/pull/1101 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[apisix-dashboard] branch master updated: fix: misspelling (#1101)

2020-12-22 Thread sunyi
This is an automated email from the ASF dual-hosted git repository. sunyi pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new 46bf1ef fix: misspelling (#1101)

[GitHub] [apisix-docker] gxthrj commented on issue #106: 9443 端口无法请求

2020-12-22 Thread GitBox
gxthrj commented on issue #106: URL: https://github.com/apache/apisix-docker/issues/106#issuecomment-749881174 > @liyin37 Just confirm, do `cert` and `key` use `pem-encoded`? @liyin37 I saw that your `cert` and `key` is RSA Encryption, the [admin

[GitHub] [apisix] spacewander commented on issue #3082: bug: Under certain conditions, plugin configured by route can't overwrite the same plugin configured by global rule

2020-12-22 Thread GitBox
spacewander commented on issue #3082: URL: https://github.com/apache/apisix/issues/3082#issuecomment-749879460 I open a discussion there: https://lists.apache.org/thread.html/r99e93b5bbade9e34a18e87b674bd999fdbe875a505c46664b731d9ff%40%3Cdev.apisix.apache.org%3E Let's go to the mail

[GitHub] [apisix] spacewander commented on issue #2711: request help: plugins in global rules are prioritized over those in routes, regardless of priority

2020-12-22 Thread GitBox
spacewander commented on issue #2711: URL: https://github.com/apache/apisix/issues/2711#issuecomment-749879370 @Gary-Airwallex I have changed my mind and open a discussion there:

[GitHub] [apisix-dashboard] LiteSun edited a comment on issue #861: feat: Route group feature

2020-12-22 Thread GitBox
LiteSun edited a comment on issue #861: URL: https://github.com/apache/apisix-dashboard/issues/861#issuecomment-749876653 FE is not merged now. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix-dashboard] LiteSun commented on issue #861: feat: Route group feature

2020-12-22 Thread GitBox
LiteSun commented on issue #861: URL: https://github.com/apache/apisix-dashboard/issues/861#issuecomment-749876653 FE is not ready now. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix-dashboard] LiteSun opened a new issue #861: feat: Route group feature

2020-12-22 Thread GitBox
LiteSun opened a new issue #861: URL: https://github.com/apache/apisix-dashboard/issues/861 # why In order to allow users to filter out routes with a specified group from a large number of routes, I propose to add the route groups feature. # how ## front-end In order to

[GitHub] [apisix] kuberxy closed issue #3097: How to define global rule in Stand-alone mode?

2020-12-22 Thread GitBox
kuberxy closed issue #3097: URL: https://github.com/apache/apisix/issues/3097 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[apisix-ingress-controller] tag 0.1.0 created (now 135cff4)

2020-12-22 Thread kvn
This is an automated email from the ASF dual-hosted git repository. kvn pushed a change to tag 0.1.0 in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git. at 135cff4 (commit) No new revisions were added by this update.

[GitHub] [apisix] spacewander commented on issue #297: feature(https): support for creating new SSL objects using certificate files.

2020-12-22 Thread GitBox
spacewander commented on issue #297: URL: https://github.com/apache/apisix/issues/297#issuecomment-749868002 This issue is marked as stale because it has not had activity for a long time. It will be closed in the next 7 days unless the label "stale" is removed. Thank you for your

[GitHub] [apisix] spacewander commented on issue #300: doc: How to verify that APISIX is properly forwarding requests to your service

2020-12-22 Thread GitBox
spacewander commented on issue #300: URL: https://github.com/apache/apisix/issues/300#issuecomment-749867971 This issue is marked as stale because it has not had activity for a long time. It will be closed in the next 7 days unless the label "stale" is removed. Thank you for your

[GitHub] [apisix] spacewander closed issue #1207: question: why not merge parameters of the same type in route management

2020-12-22 Thread GitBox
spacewander closed issue #1207: URL: https://github.com/apache/apisix/issues/1207 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1067: fix: error check to ensure path id doesn't conflict body id

2020-12-22 Thread GitBox
codecov-io edited a comment on pull request #1067: URL: https://github.com/apache/apisix-dashboard/pull/1067#issuecomment-748516852 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1067?src=pr=h1) Report > Merging

[GitHub] [apisix] spacewander commented on a change in pull request #3092: feat: expose schema via control API

2020-12-22 Thread GitBox
spacewander commented on a change in pull request #3092: URL: https://github.com/apache/apisix/pull/3092#discussion_r547586719 ## File path: apisix/control/v1.lua ## @@ -14,11 +14,33 @@ -- See the License for the specific language governing permissions and -- limitations

[GitHub] [apisix] spacewander commented on a change in pull request #3105: fix: ctx being contaminated due to a new feature of openresty 1.19

2020-12-22 Thread GitBox
spacewander commented on a change in pull request #3105: URL: https://github.com/apache/apisix/pull/3105#discussion_r547584817 ## File path: apisix/init.lua ## @@ -185,6 +185,9 @@ function _M.http_ssl_phase() end ngx_exit(-1) Review comment: Should we

[GitHub] [apisix] spacewander commented on issue #3104: Is there Docs ?

2020-12-22 Thread GitBox
spacewander commented on issue #3104: URL: https://github.com/apache/apisix/issues/3104#issuecomment-749859527 There is the doc: https://github.com/apache/apisix/tree/master/doc This is an automated message from the Apache

[GitHub] [apisix] spacewander closed issue #3104: Is there Docs ?

2020-12-22 Thread GitBox
spacewander closed issue #3104: URL: https://github.com/apache/apisix/issues/3104 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] spacewander merged pull request #3101: docs: when opening issue, also mention the Nginx version

2020-12-22 Thread GitBox
spacewander merged pull request #3101: URL: https://github.com/apache/apisix/pull/3101 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[apisix] branch master updated: docs: when opening issue, also mention the Nginx version (#3101)

2020-12-22 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 8eaa187 docs: when opening issue, also

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #999: feat: add route group

2020-12-22 Thread GitBox
liuxiran commented on a change in pull request #999: URL: https://github.com/apache/apisix-dashboard/pull/999#discussion_r547572147 ## File path: web/src/pages/Route/List.tsx ## @@ -90,6 +101,47 @@ const Page: React.FC = () => { dataIndex: 'desc', hideInSearch:

[GitHub] [apisix-docker] tokers commented on issue #106: 9443 端口无法请求

2020-12-22 Thread GitBox
tokers commented on issue #106: URL: https://github.com/apache/apisix-docker/issues/106#issuecomment-749857341 > I just change the cert and key ,the new result is below: > ![image](https://user-images.githubusercontent.com/42507175/102732067-a34e0a00-4374-11eb-993a-bad86c88f541.png)

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #999: feat: add route group

2020-12-22 Thread GitBox
liuxiran commented on a change in pull request #999: URL: https://github.com/apache/apisix-dashboard/pull/999#discussion_r547572147 ## File path: web/src/pages/Route/List.tsx ## @@ -90,6 +101,47 @@ const Page: React.FC = () => { dataIndex: 'desc', hideInSearch:

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #999: feat: add route group

2020-12-22 Thread GitBox
liuxiran commented on a change in pull request #999: URL: https://github.com/apache/apisix-dashboard/pull/999#discussion_r547572147 ## File path: web/src/pages/Route/List.tsx ## @@ -90,6 +101,47 @@ const Page: React.FC = () => { dataIndex: 'desc', hideInSearch:

[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #122: chore: hone e2e test scaffold and run cases in CI

2020-12-22 Thread GitBox
codecov-io edited a comment on pull request #122: URL: https://github.com/apache/apisix-ingress-controller/pull/122#issuecomment-748997502 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/122?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #999: feat: add route group

2020-12-22 Thread GitBox
liuxiran commented on a change in pull request #999: URL: https://github.com/apache/apisix-dashboard/pull/999#discussion_r547569358 ## File path: web/src/locales/en-US/component.ts ## @@ -32,6 +32,7 @@ export default { 'component.global.loading': 'Loading',

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #999: feat: add route group

2020-12-22 Thread GitBox
liuxiran commented on a change in pull request #999: URL: https://github.com/apache/apisix-dashboard/pull/999#discussion_r547568903 ## File path: web/src/pages/Route/transform.ts ## @@ -35,8 +44,14 @@ export const transformStepData = ({ }; } + const labels = {}; +

[GitHub] [apisix-dashboard] jinchizhou commented on pull request #1067: fix: error check to ensure path id doesn't conflict body id

2020-12-22 Thread GitBox
jinchizhou commented on pull request #1067: URL: https://github.com/apache/apisix-dashboard/pull/1067#issuecomment-749690818 I am only converting to a string if the type is float. The body id are guarantee to be a string or a float I assume? I use a new variable so that shouldn't be

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1098: The menu bar `consumer ` in Chinese view supports Chinese

2020-12-22 Thread GitBox
juzhiyuan commented on issue #1098: URL: https://github.com/apache/apisix-dashboard/issues/1098#issuecomment-749652581 oh yes, that's because we don't have a proper description in Chinese, what's your opinion? 樂 This is an

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1101: fix: misspelling

2020-12-22 Thread GitBox
codecov-io commented on pull request #1101: URL: https://github.com/apache/apisix-dashboard/pull/1101#issuecomment-749632542 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1101?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] guoqqqi opened a new pull request #1101: fix: misspelling

2020-12-22 Thread GitBox
guoqqqi opened a new pull request #1101: URL: https://github.com/apache/apisix-dashboard/pull/1101 Please answer these questions before submitting a pull request - Why submit this pull request? - [x] Bugfix - [ ] New feature provided - [ ] Improve performance -

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1097: feat: "upstream" i18n

2020-12-22 Thread GitBox
juzhiyuan commented on pull request #1097: URL: https://github.com/apache/apisix-dashboard/pull/1097#issuecomment-749609081 ![image](https://user-images.githubusercontent.com/2106987/102906504-adc0ee80-44af-11eb-9e38-0f6674754ba0.png) @guoqqqi After you update the i18n, you need to

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1013: add spell CI tool

2020-12-22 Thread GitBox
juzhiyuan commented on issue #1013: URL: https://github.com/apache/apisix-dashboard/issues/1013#issuecomment-749608322 Hi @guoqqqi, here has one misspelling in the `DebugDrawView` file, please fix this. As for misspellings in yarn.lock, ignore it because we couldn't modify it.

[GitHub] [apisix-dashboard] nic-chen commented on pull request #1067: fix: error check to ensure path id doesn't conflict body id

2020-12-22 Thread GitBox
nic-chen commented on pull request #1067: URL: https://github.com/apache/apisix-dashboard/pull/1067#issuecomment-749604190 > Not sure why these CI tests are blocking. I verified that these tests are failing locally even without my changes. I think it's due to

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #999: feat: add route group

2020-12-22 Thread GitBox
codecov-io edited a comment on pull request #999: URL: https://github.com/apache/apisix-dashboard/pull/999#issuecomment-742169695 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/999?src=pr=h1) Report > Merging

  1   2   >