codecov-io edited a comment on pull request #1245:
URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-757579417
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1245?src=pr=h1)
Report
> Merging
Firstsawyou commented on a change in pull request #3377:
URL: https://github.com/apache/apisix/pull/3377#discussion_r561665732
##
File path: rockspec/apisix-master-0.rockspec
##
@@ -43,7 +43,7 @@ dependencies = {
"lua-resty-cookie = 0.1.0",
"lua-resty-session =
nic-chen closed issue #887:
URL: https://github.com/apache/apisix-dashboard/issues/887
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
nic-chen commented on issue #887:
URL:
https://github.com/apache/apisix-dashboard/issues/887#issuecomment-764450029
fixed by
#906 and #1195
This is an automated message from the Apache Git Service.
To respond to the
codecov-io edited a comment on pull request #192:
URL:
https://github.com/apache/apisix-ingress-controller/pull/192#issuecomment-764447488
#
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/192?src=pr=h1)
Report
> Merging
tokers commented on pull request #192:
URL:
https://github.com/apache/apisix-ingress-controller/pull/192#issuecomment-764448797
@gxthrj Please take a look when you have time.
This is an automated message from the Apache Git
juzhiyuan commented on pull request #1102:
URL: https://github.com/apache/apisix-dashboard/pull/1102#issuecomment-764448583
> Do we need to add **test cases** about
>
> 1. import a error file
> 2. a file includes two or more APIs
Yep
codecov-io edited a comment on pull request #1245:
URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-757579417
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1245?src=pr=h1)
Report
> Merging
Jaycean edited a comment on pull request #1245:
URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-764447946
> it would be better to add three more test cases:
>
> * export a route created with upstream id
> * export a route created with service which is
nic-chen commented on issue #889:
URL:
https://github.com/apache/apisix-dashboard/issues/889#issuecomment-764448221
fixed by https://github.com/apache/apisix/pull/3008
This is an automated message from the Apache Git
nic-chen closed issue #889:
URL: https://github.com/apache/apisix-dashboard/issues/889
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
Jaycean commented on a change in pull request #1245:
URL: https://github.com/apache/apisix-dashboard/pull/1245#discussion_r561660169
##
File path: api/test/e2e/route_export_test.go
##
@@ -0,0 +1,716 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
Jaycean commented on pull request #1245:
URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-764447946
> it would be better to add three more test cases:
>
> * export a route created with upstream id
> * export a route created with service which is created with
codecov-io commented on pull request #192:
URL:
https://github.com/apache/apisix-ingress-controller/pull/192#issuecomment-764447488
#
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/192?src=pr=h1)
Report
> Merging
Yiyiyimu commented on a change in pull request #3372:
URL: https://github.com/apache/apisix/pull/3372#discussion_r561659098
##
File path: apisix/core/config_etcd.lua
##
@@ -241,7 +241,11 @@ local function sync_data(self)
else
if not dir_res.nodes then
-
tokers opened a new pull request #192:
URL: https://github.com/apache/apisix-ingress-controller/pull/192
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ]
nic-chen commented on issue #679:
URL:
https://github.com/apache/apisix-dashboard/issues/679#issuecomment-764445689
not urgent, we could move to next version
This is an automated message from the Apache Git Service.
To
Yiyiyimu commented on pull request #3372:
URL: https://github.com/apache/apisix/pull/3372#issuecomment-764445514
Hi @yongboy it would be better if you write some test case to prove it's
correctness
This is an automated
spacewander commented on a change in pull request #3377:
URL: https://github.com/apache/apisix/pull/3377#discussion_r561655865
##
File path: rockspec/apisix-master-0.rockspec
##
@@ -43,7 +43,7 @@ dependencies = {
"lua-resty-cookie = 0.1.0",
"lua-resty-session =
nic-chen commented on issue #706:
URL:
https://github.com/apache/apisix-dashboard/issues/706#issuecomment-764443679
fixed by #977
This is an automated message from the Apache Git Service.
To respond to the message, please
nic-chen closed issue #706:
URL: https://github.com/apache/apisix-dashboard/issues/706
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
liuxiran commented on pull request #1102:
URL: https://github.com/apache/apisix-dashboard/pull/1102#issuecomment-764442783
Do we need to add **test cases** about
1. import a error file
2. a file includes two or more APIs
Firstsawyou commented on a change in pull request #3377:
URL: https://github.com/apache/apisix/pull/3377#discussion_r561654367
##
File path: rockspec/apisix-master-0.rockspec
##
@@ -43,7 +43,7 @@ dependencies = {
"lua-resty-cookie = 0.1.0",
"lua-resty-session =
nic-chen commented on issue #886:
URL:
https://github.com/apache/apisix-dashboard/issues/886#issuecomment-764442067
We could handle it later, just before 3.0 version
This is an automated message from the Apache Git Service.
idbeta edited a comment on issue #3380:
URL: https://github.com/apache/apisix/issues/3380#issuecomment-764441819
> @idbeta
> Can this issue be reproduced in the latest version of dashboard? Is there
any error log in the APISIX size?
> 1、can not more than 200 characters
idbeta commented on issue #3380:
URL: https://github.com/apache/apisix/issues/3380#issuecomment-764441819
> @idbeta
> Can this issue be reproduced in the latest version of dashboard? Is there
any error log in the APISIX size?
> 1、Can not more than 200 characters
still can
juzhiyuan closed issue #1182:
URL: https://github.com/apache/apisix-dashboard/issues/1182
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
juzhiyuan commented on issue #1182:
URL:
https://github.com/apache/apisix-dashboard/issues/1182#issuecomment-764441363
The DockerHub maintains an image for Apache APISIX Dashboard[1], you could
pull that image instead of the building by hand, and here is the issue[2] to
track when to
moonming commented on pull request #3381:
URL: https://github.com/apache/apisix/pull/3381#issuecomment-764440900
@Yiyiyimu thanks for you help
This is an automated message from the Apache Git Service.
To respond to the
Yiyiyimu commented on issue #3362:
URL: https://github.com/apache/apisix/issues/3362#issuecomment-764439631
> I remember that if these keys (`/apisix/routes`, `/apisix/services`, etc.)
do not exist, the ETCD watch will fail.
> @Yiyiyimu please have a look.
Yeah I remember the
spacewander commented on issue #3383:
URL: https://github.com/apache/apisix/issues/3383#issuecomment-764439052
CC @juzhiyuan @nic-chen
This is an automated message from the Apache Git Service.
To respond to the message,
jaredhuang opened a new issue #3383:
URL: https://github.com/apache/apisix/issues/3383
### Issue description
how do i know plugin Orchestration condition variables 。
In the video:
juzhiyuan commented on issue #1238:
URL:
https://github.com/apache/apisix-dashboard/issues/1238#issuecomment-764437885
all right, ping @membphis @nic-chen, any ideas about this feature?
It seems a little cumbersome, if we could resolve this issue, there has no
need to sync the
liuxiran commented on a change in pull request #1102:
URL: https://github.com/apache/apisix-dashboard/pull/1102#discussion_r561648621
##
File path: api/test/e2e/import_test.go
##
@@ -0,0 +1,248 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
Firstsawyou opened a new pull request #3382:
URL: https://github.com/apache/apisix/pull/3382
### What this PR does / why we need it:
fix #3374
### Pre-submission checklist:
* [ ] Did you explain what problem does this PR solve? Or what new features
have
Yiyiyimu commented on a change in pull request #2101:
URL: https://github.com/apache/apisix/pull/2101#discussion_r561647161
##
File path: apisix/cli/ops.lua
##
@@ -390,6 +392,21 @@ local function start(env, ...)
end
end
+local parser = argparse()
+
starsz commented on issue #758:
URL:
https://github.com/apache/apisix-dashboard/issues/758#issuecomment-764434972
This will be discussed in M2.4 and finished in M2.5.
cc @juzhiyuan
This is an automated message from the
starsz commented on issue #1161:
URL:
https://github.com/apache/apisix-dashboard/issues/1161#issuecomment-764434550
This is a big project, I will finish part of them in M2.4
This is an automated message from the Apache Git
starsz commented on issue #1127:
URL:
https://github.com/apache/apisix-dashboard/issues/1127#issuecomment-764434256
@juzhiyuan Help me move to M2.5.
This is an automated message from the Apache Git Service.
To respond to
fukiki commented on a change in pull request #3335:
URL: https://github.com/apache/apisix/pull/3335#discussion_r561645938
##
File path: bin/apisix
##
@@ -1,36 +1,41 @@
-#!/usr/bin/env lua
+#!/bin/bash
---
--- Licensed to the Apache Software Foundation (ASF) under one or more
Yiyiyimu opened a new pull request #3381:
URL: https://github.com/apache/apisix/pull/3381
Signed-off-by: yiyiyimu
### What this PR does / why we need it:
Caused by #3368, an extra blank is not removed in time, so markdownlint
would keep failing
### Pre-submission
fukiki commented on pull request #3368:
URL: https://github.com/apache/apisix/pull/3368#issuecomment-764433368
@moonming
starsz commented on issue #1127:
URL:
https://github.com/apache/apisix-dashboard/issues/1127#issuecomment-764432654
Not urgent, I think this should be done in M2.5.
This is an automated message from the Apache Git Service.
liodo198592 opened a new pull request #191:
URL: https://github.com/apache/apisix-ingress-controller/pull/191
…w_clusterrole.yaml
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [x] Bugfix
- [ ] New feature provided
- [
spacewander commented on issue #3374:
URL: https://github.com/apache/apisix/issues/3374#issuecomment-764432581
OK, let's do it.
This is an automated message from the Apache Git Service.
To respond to the message, please log
spacewander commented on issue #1238:
URL:
https://github.com/apache/apisix-dashboard/issues/1238#issuecomment-764432147
I don't any idea unless we modify the code of APISIX and dump the data we
used.
This is an automated
spacewander commented on issue #3380:
URL: https://github.com/apache/apisix/issues/3380#issuecomment-764431095
@idbeta
Can this issue be reproduced in the latest version of dashboard? Is there
any error log in the APISIX size?
spacewander commented on issue #3380:
URL: https://github.com/apache/apisix/issues/3380#issuecomment-764428267
Hey guys. Something you don't make it correct from the beginning:
https://github.com/api7/jsonschema/blob/b9375642eb2da0f20486a38025e511a12687b5d4/lib/jsonschema.lua#L365
codecov-io commented on pull request #190:
URL:
https://github.com/apache/apisix-ingress-controller/pull/190#issuecomment-764424799
#
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/190?src=pr=h1)
Report
> Merging
imjoey commented on pull request #3365:
URL: https://github.com/apache/apisix/pull/3365#issuecomment-764424135
@idbeta Just FYI, for redis 5.x ARM64 image, simply run `docker pull
isrc.iscas.ac.cn/oepkgs/kubernetes/library/redis:5.0.5-alpine` to fetch the
pre-built image. Noted that it's
cao19881125 opened a new pull request #190:
URL: https://github.com/apache/apisix-ingress-controller/pull/190
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
juzhiyuan commented on issue #1238:
URL:
https://github.com/apache/apisix-dashboard/issues/1238#issuecomment-764423530
Hi @spacewander @starsz, do we have any quick ideas to export those test
cases from Lua?
This is an
juzhiyuan commented on issue #1165:
URL:
https://github.com/apache/apisix-dashboard/issues/1165#issuecomment-764418795
**Backend**
- Provide the `version_check` API;
**Frontend**
- Call the above API when the page first shows, once.
membphis commented on issue #3344:
URL: https://github.com/apache/apisix/issues/3344#issuecomment-764418234
I think we can fix this issue in milestone 2.3 (this month) @JanLi-air
This is an automated message from the Apache
juzhiyuan commented on issue #3380:
URL: https://github.com/apache/apisix/issues/3380#issuecomment-764413569
@nic-chen Please leave your comments :)
This is an automated message from the Apache Git Service.
To respond to the
idbeta opened a new issue #3380:
URL: https://github.com/apache/apisix/issues/3380
- Why do you submit this issue?
- [ ] Question or discussion
- [x] Bug
- [ ] Requirements
- [ ] Feature or performance improvement
- [ ] Other
Route's description can input more than 200
Yiyiyimu commented on a change in pull request #2101:
URL: https://github.com/apache/apisix/pull/2101#discussion_r561629722
##
File path: .travis/apisix_cli_test/test_main.sh
##
@@ -500,6 +500,43 @@ fi
sed -i 's/worker_processes: 2/worker_processes: auto/' conf/config.yaml
Yiyiyimu commented on a change in pull request #2101:
URL: https://github.com/apache/apisix/pull/2101#discussion_r561629415
##
File path: .travis/apisix_cli_test/test_main.sh
##
@@ -500,6 +500,43 @@ fi
sed -i 's/worker_processes: 2/worker_processes: auto/' conf/config.yaml
imjoey commented on pull request #3365:
URL: https://github.com/apache/apisix/pull/3365#issuecomment-764410536
> That is great, thank you. If want to run CI completely under ARM64, need
to solve another problem is many CI-dependent docker images do not have an
ARM64 version.
>
> >
This is an automated email from the ASF dual-hosted git repository.
wenming pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 985c354 doc: add good first issue links.
moonming merged pull request #3368:
URL: https://github.com/apache/apisix/pull/3368
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Fuchange commented on a change in pull request #3335:
URL: https://github.com/apache/apisix/pull/3335#discussion_r561623196
##
File path: bin/apisix
##
@@ -1,36 +1,41 @@
-#!/usr/bin/env lua
+#!/bin/bash
---
--- Licensed to the Apache Software Foundation (ASF) under one or
Fuchange commented on a change in pull request #3335:
URL: https://github.com/apache/apisix/pull/3335#discussion_r561623196
##
File path: bin/apisix
##
@@ -1,36 +1,41 @@
-#!/usr/bin/env lua
+#!/bin/bash
---
--- Licensed to the Apache Software Foundation (ASF) under one or
imjoey edited a comment on issue #1154:
URL:
https://github.com/apache/apisix-dashboard/issues/1154#issuecomment-764399950
Hi all, since both #1277 and #1322 had been merged, I would close this
issue. Please feel free to reopen it if anything unexpected. Thanks.
imjoey edited a comment on issue #1154:
URL:
https://github.com/apache/apisix-dashboard/issues/1154#issuecomment-764399950
@tokers @juzhiyuan since both #1277 and #1322 had been merged, I would
close this issue. Please feel free to reopen it if anything unexpected. Thanks.
imjoey commented on issue #1154:
URL:
https://github.com/apache/apisix-dashboard/issues/1154#issuecomment-764399950
@tokers @juzhiyuan since both #1277 and #1322 had been merged, I could
close this issue. Please feel free to reopen it if anything unexpected. Thanks.
imjoey closed issue #1154:
URL: https://github.com/apache/apisix-dashboard/issues/1154
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
idbeta edited a comment on pull request #3365:
URL: https://github.com/apache/apisix/pull/3365#issuecomment-764354513
> @idbeta Huawei is working on donating ARM CI resources to various open
source community to leverage the ARM ecosystem. AFAIK, Apache Flink and Apache
Kudu are both using
Firstsawyou commented on pull request #3379:
URL: https://github.com/apache/apisix/pull/3379#issuecomment-764396783
Looks good to me.
This is an automated message from the Apache Git Service.
To respond to the message,
tokers commented on a change in pull request #3335:
URL: https://github.com/apache/apisix/pull/3335#discussion_r561610634
##
File path: bin/apisix
##
@@ -1,36 +1,41 @@
-#!/usr/bin/env lua
+#!/bin/bash
---
--- Licensed to the Apache Software Foundation (ASF) under one or more
idbeta edited a comment on pull request #3365:
URL: https://github.com/apache/apisix/pull/3365#issuecomment-764354513
> @idbeta Huawei is working on donating ARM CI resources to various open
source community to leverage the ARM ecosystem. AFAIK, Apache Flink and Apache
Kudu are both using
idbeta commented on pull request #3365:
URL: https://github.com/apache/apisix/pull/3365#issuecomment-764354513
> @idbeta Huawei is working on donating ARM CI resources to various open
source community to leverage the ARM ecosystem. AFAIK, Apache Flink and Apache
Kudu are both using the
tokers commented on a change in pull request #3379:
URL: https://github.com/apache/apisix/pull/3379#discussion_r561607289
##
File path: apisix/schema_def.lua
##
@@ -81,7 +81,6 @@ local remote_addr_def = {
local label_value_def = {
description = "value of label",
Firstsawyou commented on issue #3374:
URL: https://github.com/apache/apisix/issues/3374#issuecomment-764351519
> This will break the compatibility. Is there a strong reason to do the
change?
The 500 response code represents a problem caused by an error in the program
code. However,
guoqqqi opened a new pull request #1341:
URL: https://github.com/apache/apisix-dashboard/pull/1341
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bugfix
- [x] New feature provided
- [ ] Improve performance
- [ ]
Yiyiyimu commented on a change in pull request #2101:
URL: https://github.com/apache/apisix/pull/2101#discussion_r561602243
##
File path: Makefile
##
@@ -98,7 +98,7 @@ endif
### stop: Stop the apisix server
.PHONY: stop
stop: default
- $(OR_EXEC) -p $$PWD/
imjoey commented on issue #1331:
URL:
https://github.com/apache/apisix-dashboard/issues/1331#issuecomment-764290323
@ShiningRush @starsz
I refer to the implementations of the `rest.Store` and `Storage` in
Kubernetes APIServer. From the following code snippet (refer to
spacewander opened a new pull request #3379:
URL: https://github.com/apache/apisix/pull/3379
Fix #3378.
Signed-off-by: spacewander
### What this PR does / why we need it:
### Pre-submission checklist:
* [x] Did you explain what problem does this PR
Firstsawyou commented on a change in pull request #3366:
URL: https://github.com/apache/apisix/pull/3366#discussion_r561595034
##
File path: doc/zh-cn/plugins/traffic-split.md
##
@@ -55,12 +55,15 @@ traffic-split 插件使用户可以逐步引导各个上游之间的流量百分
traffic-split 插件主要由 `match` 和
juzhiyuan opened a new issue #3378:
URL: https://github.com/apache/apisix/issues/3378
# Bug report
## Describe the bug
When I create a route with Label, an error occurred when using Chinese as
key.
## Expected behavior
A clear and concise description of what you
spacewander commented on issue #3373:
URL: https://github.com/apache/apisix/issues/3373#issuecomment-764257035
```
proxy_hide_header Cache-Control;
proxy_hide_header Expires;
add_header Cache-Control
imjoey commented on pull request #3365:
URL: https://github.com/apache/apisix/pull/3365#issuecomment-764245183
> —— I have talked with @membphis , it is not suitable for Apache project to
use self-hosted method for CI testing, so it is good to provide manual testing
script first.
unbeatablekb commented on pull request #3084:
URL: https://github.com/apache/apisix/pull/3084#issuecomment-764244848
@spacewander Thanks for your advice. I will do it.
This is an automated message from the Apache Git
unbeatablekb opened a new pull request #3084:
URL: https://github.com/apache/apisix/pull/3084
### What this PR does / why we need it:
fix: #2988
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features
have been added?
*
unbeatablekb commented on pull request #3084:
URL: https://github.com/apache/apisix/pull/3084#issuecomment-764242549
@spacewander
This is an automated message from the Apache Git Service.
To respond to the message, please
unbeatablekb removed a comment on pull request #3084:
URL: https://github.com/apache/apisix/pull/3084#issuecomment-764242549
@spacewander
This is an automated message from the Apache Git Service.
To respond to the message,
unbeatablekb closed pull request #3084:
URL: https://github.com/apache/apisix/pull/3084
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
spacewander commented on a change in pull request #3372:
URL: https://github.com/apache/apisix/pull/3372#discussion_r561589660
##
File path: apisix/core/config_etcd.lua
##
@@ -241,7 +241,11 @@ local function sync_data(self)
else
if not dir_res.nodes
codecov-io edited a comment on pull request #1102:
URL: https://github.com/apache/apisix-dashboard/pull/1102#issuecomment-752030848
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1102?src=pr=h1)
Report
> Merging
nic-chen commented on issue #1300:
URL:
https://github.com/apache/apisix-dashboard/issues/1300#issuecomment-764231399
cc @spacewander
This is an automated message from the Apache Git Service.
To respond to the message,
spacewander commented on issue #3375:
URL: https://github.com/apache/apisix/issues/3375#issuecomment-764228763
I am not quite understand what you need. But you can submit a PR first so we
can discuss with the code.
This is
membphis commented on issue #1300:
URL:
https://github.com/apache/apisix-dashboard/issues/1300#issuecomment-764226137
do we need to transfer this issue to APISIX?
This is an automated message from the Apache Git Service.
To
codecov-io edited a comment on pull request #1102:
URL: https://github.com/apache/apisix-dashboard/pull/1102#issuecomment-752030848
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1102?src=pr=h1)
Report
> Merging
membphis edited a comment on pull request #3335:
URL: https://github.com/apache/apisix/pull/3335#issuecomment-764218287
please merge the code of master branch, CI failed ^_^
This is an automated message from the Apache Git
spacewander opened a new pull request #3377:
URL: https://github.com/apache/apisix/pull/3377
Fix #3357.
Signed-off-by: spacewander
### What this PR does / why we need it:
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or
idbeta opened a new pull request #3376:
URL: https://github.com/apache/apisix/pull/3376
### What this PR does / why we need it:
automatically check performance in Actions.
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new
spacewander commented on issue #3374:
URL: https://github.com/apache/apisix/issues/3374#issuecomment-764218407
This will break the compatibility. Is there a strong reason to do the change?
This is an automated message from
membphis commented on pull request #3335:
URL: https://github.com/apache/apisix/pull/3335#issuecomment-764218287
please merge the code of master branch
This is an automated message from the Apache Git Service.
To respond to
nic-chen commented on issue #1300:
URL:
https://github.com/apache/apisix-dashboard/issues/1300#issuecomment-764217528
need support in APISIX first if we want to support it
This is an automated message from the Apache Git
codecov-io edited a comment on pull request #1102:
URL: https://github.com/apache/apisix-dashboard/pull/1102#issuecomment-752030848
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1102?src=pr=h1)
Report
> Merging
1 - 100 of 321 matches
Mail list logo
