[GitHub] [apisix] tzssangglass edited a comment on issue #3384: request help: unbalanced message in kafka partition using kafka-logger plugin

2021-01-21 Thread GitBox
tzssangglass edited a comment on issue #3384: URL: https://github.com/apache/apisix/issues/3384#issuecomment-765208824 assigned me This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [apisix] tzssangglass commented on issue #3384: request help: unbalanced message in kafka partition using kafka-logger plugin

2021-01-21 Thread GitBox
tzssangglass commented on issue #3384: URL: https://github.com/apache/apisix/issues/3384#issuecomment-765208824 assigned me this This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [apisix] fukiki commented on a change in pull request #3335: fix: Use luajit or lua 5.1 by default when run APISIX

2021-01-21 Thread GitBox
fukiki commented on a change in pull request #3335: URL: https://github.com/apache/apisix/pull/3335#discussion_r562442530 ## File path: bin/apisix ## @@ -1,36 +1,43 @@ -#!/usr/bin/env lua +#!/bin/bash --- --- Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1302: feat: user can skip upstream when select service_id

2021-01-21 Thread GitBox
codecov-io edited a comment on pull request #1302: URL: https://github.com/apache/apisix-dashboard/pull/1302#issuecomment-760639257 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1302?src=pr=h1) Report > Merging

[GitHub] [apisix] Yiyiyimu commented on issue #3391: [proposal]: add performance testing in CI

2021-01-21 Thread GitBox
Yiyiyimu commented on issue #3391: URL: https://github.com/apache/apisix/issues/3391#issuecomment-765199553 Waiting for the test result! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix-dashboard] imjoey opened a new pull request #1359: fix: Skip the data directly in Storage level

2021-01-21 Thread GitBox
imjoey opened a new pull request #1359: URL: https://github.com/apache/apisix-dashboard/pull/1359 Signed-off-by: imjoey Please answer these questions before submitting a pull request - Why submit this pull request? - [x] Bugfix - [ ] New feature provided - [ ]

[GitHub] [apisix] Firstsawyou commented on pull request #3394: fix(standalone): require consumer's id to be the same as username

2021-01-21 Thread GitBox
Firstsawyou commented on pull request #3394: URL: https://github.com/apache/apisix/pull/3394#issuecomment-765178140 LGTM. This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix-ingress-controller] liodo198592 commented on a change in pull request #191: fix:BUGFIX #182 ,add write permisson of resource:leases in apisix_vie…

2021-01-21 Thread GitBox
liodo198592 commented on a change in pull request #191: URL: https://github.com/apache/apisix-ingress-controller/pull/191#discussion_r562421744 ## File path: test/e2e/scaffold/ingress.go ## @@ -29,6 +29,141 @@ import ( const ( _serviceAccount =

[GitHub] [apisix-ingress-controller] gxthrj closed issue #197: docs: add milestone link in README

2021-01-21 Thread GitBox
gxthrj closed issue #197: URL: https://github.com/apache/apisix-ingress-controller/issues/197 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix-ingress-controller] lianghao208 opened a new pull request #198: doc:add milestone link

2021-01-21 Thread GitBox
lianghao208 opened a new pull request #198: URL: https://github.com/apache/apisix-ingress-controller/pull/198 Please answer these questions before submitting a pull request - Why submit this pull request? - [x] Bugfix - [ ] New feature provided - [ ] Improve

[GitHub] [apisix] gewei2000 commented on issue #3390: request help: does the proxy_cache plugin support static resource cache

2021-01-21 Thread GitBox
gewei2000 commented on issue #3390: URL: https://github.com/apache/apisix/issues/3390#issuecomment-765149345 > > Configure `location ~* /service_a/(.*)\.(png|jpg|js|css)$` in apisix, can it solve your problem? > > this is not a best way in APISIX. we can use the Route + proxy cache

[GitHub] [apisix-ingress-controller] gxthrj opened a new issue #197: docs: add milestone link in README

2021-01-21 Thread GitBox
gxthrj opened a new issue #197: URL: https://github.com/apache/apisix-ingress-controller/issues/197 As many friends wanted to know about the plan of our project, we need to put the [milestone link](https://github.com/apache/apisix-ingress-controller/milestones) in the readme, so that

[GitHub] [apisix] idbeta edited a comment on issue #3391: [proposal]: add performance testing in CI

2021-01-21 Thread GitBox
idbeta edited a comment on issue #3391: URL: https://github.com/apache/apisix/issues/3391#issuecomment-765087092 > @idbeta How could we know that "not differ too much" would happen, or "they are within an order of magnitude". Maybe we need some methods to get over those false positives,

[GitHub] [apisix-ingress-controller] gxthrj merged pull request #198: doc:add milestone link

2021-01-21 Thread GitBox
gxthrj merged pull request #198: URL: https://github.com/apache/apisix-ingress-controller/pull/198 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix-ingress-controller] gxthrj commented on issue #197: docs: add milestone link in README

2021-01-21 Thread GitBox
gxthrj commented on issue #197: URL: https://github.com/apache/apisix-ingress-controller/issues/197#issuecomment-765142414 Is anyone interested to help deal with this issue? This is an automated message from the Apache Git

[GitHub] [apisix] spacewander commented on issue #3392: bug: timeout in upstream_schema can be set to zero, but in fact not workable.

2021-01-21 Thread GitBox
spacewander commented on issue #3392: URL: https://github.com/apache/apisix/issues/3392#issuecomment-765062764 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [apisix-dashboard] imjoey closed issue #1154: Resource create request should return the ultimate data

2021-01-21 Thread GitBox
imjoey closed issue #1154: URL: https://github.com/apache/apisix-dashboard/issues/1154 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1302: WIP: user can skip upstream when select service_id

2021-01-21 Thread GitBox
codecov-io edited a comment on pull request #1302: URL: https://github.com/apache/apisix-dashboard/pull/1302#issuecomment-760639257 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1302?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1317: fix: cannot delete multiple plugins without page refreshing

2021-01-21 Thread GitBox
codecov-io edited a comment on pull request #1317: URL: https://github.com/apache/apisix-dashboard/pull/1317#issuecomment-761756678 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #191: fix:BUGFIX #182 ,add write permisson of resource:leases in apisix_vie…

2021-01-21 Thread GitBox
codecov-io commented on pull request #191: URL: https://github.com/apache/apisix-ingress-controller/pull/191#issuecomment-764482700 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/191?src=pr=h1) Report > Merging

[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #190: chore:add ginkgo check before e2e-test(apache #186)

2021-01-21 Thread GitBox
codecov-io edited a comment on pull request #190: URL: https://github.com/apache/apisix-ingress-controller/pull/190#issuecomment-764424799 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/190?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1182: Dockerfile source code is COPY from the current version instead of remote download

2021-01-21 Thread GitBox
juzhiyuan commented on issue #1182: URL: https://github.com/apache/apisix-dashboard/issues/1182#issuecomment-764441363 The DockerHub maintains an image for Apache APISIX Dashboard[1], you could pull that image instead of the building by hand, and here is the issue[2] to track when to

[GitHub] [apisix] Firstsawyou commented on pull request #3363: feat(fault-injection): support conditional fault injection using nginx variables

2021-01-21 Thread GitBox
Firstsawyou commented on pull request #3363: URL: https://github.com/apache/apisix/pull/3363#issuecomment-764712708 > ci failed I need to adjust the code logic and I will solve the ci problem later. This is an

[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #194: doc: Add Apache APISIX link in README

2021-01-21 Thread GitBox
codecov-io commented on pull request #194: URL: https://github.com/apache/apisix-ingress-controller/pull/194#issuecomment-764508833 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/194?src=pr=h1) Report > Merging

[GitHub] [apisix] wfgydbu commented on issue #3392: bug: timeout in upstream_schema can be set to zero, but in fact not workable.

2021-01-21 Thread GitBox
wfgydbu commented on issue #3392: URL: https://github.com/apache/apisix/issues/3392#issuecomment-765070897 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [apisix] gy09535 edited a comment on issue #3389: bug: get empty data from etcd when apisix init

2021-01-21 Thread GitBox
gy09535 edited a comment on issue #3389: URL: https://github.com/apache/apisix/issues/3389#issuecomment-764556332 > @gy09535 > Why the output of `env ETCDCTL_API=3 etcdctl --endpoints http://:2379 --user=apisix: get --from-key /apisix/upstreams` doesn't have: > > ```

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1348: fix: update description input box

2021-01-21 Thread GitBox
codecov-io commented on pull request #1348: URL: https://github.com/apache/apisix-dashboard/pull/1348#issuecomment-764790694 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1348?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] liuxiran edited a comment on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0

2021-01-21 Thread GitBox
liuxiran edited a comment on pull request #1245: URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-764207165 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [apisix] spacewander closed issue #1833: request help: how to proxy grpc to grpcs.

2021-01-21 Thread GitBox
spacewander closed issue #1833: URL: https://github.com/apache/apisix/issues/1833 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix-dashboard] nic-chen commented on issue #650: support different config for APISIX and manager api in e2e test

2021-01-21 Thread GitBox
nic-chen commented on issue #650: URL: https://github.com/apache/apisix-dashboard/issues/650#issuecomment-764473035 we use docker-compose to run env for e2e test now. and have supported different config test on cli test.

[GitHub] [apisix] unbeatablekb closed pull request #3084: feat: add proxy_ssl_server_name

2021-01-21 Thread GitBox
unbeatablekb closed pull request #3084: URL: https://github.com/apache/apisix/pull/3084 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix-dashboard] nic-chen commented on issue #1351: bug: some apis bypassed authentication

2021-01-21 Thread GitBox
nic-chen commented on issue #1351: URL: https://github.com/apache/apisix-dashboard/issues/1351#issuecomment-765059735 cc @starsz This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [apisix-dashboard] nic-chen commented on issue #1300: Label feature doesn't support Chinese as key?

2021-01-21 Thread GitBox
nic-chen commented on issue #1300: URL: https://github.com/apache/apisix-dashboard/issues/1300#issuecomment-764217528 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix] Firstsawyou commented on a change in pull request #3377: fix: ignore the case of configured host

2021-01-21 Thread GitBox
Firstsawyou commented on a change in pull request #3377: URL: https://github.com/apache/apisix/pull/3377#discussion_r561654367 ## File path: rockspec/apisix-master-0.rockspec ## @@ -43,7 +43,7 @@ dependencies = { "lua-resty-cookie = 0.1.0", "lua-resty-session =

[GitHub] [apisix] moonming commented on pull request #3381: fix: markdownlint issue

2021-01-21 Thread GitBox
moonming commented on pull request #3381: URL: https://github.com/apache/apisix/pull/3381#issuecomment-764440900 @Yiyiyimu thanks for you help This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix] Yiyiyimu commented on pull request #3372: feat: allow ETCD work without some special keys

2021-01-21 Thread GitBox
Yiyiyimu commented on pull request #3372: URL: https://github.com/apache/apisix/pull/3372#issuecomment-764445514 Hi @yongboy it would be better if you write some test case to prove it's correctness This is an automated

[GitHub] [apisix] jenskeiner commented on a change in pull request #3308: feat: authz-keycloak plugin - dynamic scope and resource mapping.

2021-01-21 Thread GitBox
jenskeiner commented on a change in pull request #3308: URL: https://github.com/apache/apisix/pull/3308#discussion_r561675160 ## File path: doc/plugins/authz-keycloak.md ## @@ -38,24 +38,37 @@ For more information on Keycloak, refer to [Keycloak Authorization Docs](https:/

[GitHub] [apisix-dashboard] Jaycean edited a comment on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0

2021-01-21 Thread GitBox
Jaycean edited a comment on pull request #1245: URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-764447946 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [apisix-dashboard] juzhiyuan closed issue #1182: Dockerfile source code is COPY from the current version instead of remote download

2021-01-21 Thread GitBox
juzhiyuan closed issue #1182: URL: https://github.com/apache/apisix-dashboard/issues/1182 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1348: fix: update description input box

2021-01-21 Thread GitBox
juzhiyuan merged pull request #1348: URL: https://github.com/apache/apisix-dashboard/pull/1348 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1339: feat: add domSelector and data for search-route

2021-01-21 Thread GitBox
juzhiyuan commented on a change in pull request #1339: URL: https://github.com/apache/apisix-dashboard/pull/1339#discussion_r561447686 ## File path: web/cypress/integration/route/search-route.spec.js ## @@ -17,8 +17,34 @@ /* eslint-disable no-undef */ context('Create and

[GitHub] [apisix-dashboard] nic-chen commented on issue #872: bug: manager-api should not allow create route with remote_addrs and remote_addr at the same time

2021-01-21 Thread GitBox
nic-chen commented on issue #872: URL: https://github.com/apache/apisix-dashboard/issues/872#issuecomment-764463114 fixed by https://github.com/apache/apisix/pull/3008 This is an automated message from the Apache Git

[GitHub] [apisix] membphis merged pull request #3385: test: avoid unstable case caused by delete upstream 1

2021-01-21 Thread GitBox
membphis merged pull request #3385: URL: https://github.com/apache/apisix/pull/3385 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix-dashboard] LiteSun commented on pull request #1341: test: user can skip upstream when select service_id

2021-01-21 Thread GitBox
LiteSun commented on pull request #1341: URL: https://github.com/apache/apisix-dashboard/pull/1341#issuecomment-764464109 The test code has been merged into the LiteSun:feat-route branch. see

[GitHub] [apisix] spacewander commented on issue #3370: bug: http service should not be started before etcd data is pulled

2021-01-21 Thread GitBox
spacewander commented on issue #3370: URL: https://github.com/apache/apisix/issues/3370#issuecomment-764153237 This is a known issue. We plan to start pulling etcd data in the `init_worker` phase. To achieve this, we need to implement two preconditions first: 1. add Chaos test so that

[GitHub] [apisix] moonming commented on pull request #3382: chore: the 500 response code in the upstream.lua file was changed to 503 response code

2021-01-21 Thread GitBox
moonming commented on pull request #3382: URL: https://github.com/apache/apisix/pull/3382#issuecomment-764675332 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [apisix] unbeatablekb commented on pull request #3084: feat: add proxy_ssl_server_name

2021-01-21 Thread GitBox
unbeatablekb commented on pull request #3084: URL: https://github.com/apache/apisix/pull/3084#issuecomment-764242549 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [apisix-website] juzhiyuan merged pull request #152: feat: add 2021-01-21-run-ingress-apisix-on-amazon-eks.md

2021-01-21 Thread GitBox
juzhiyuan merged pull request #152: URL: https://github.com/apache/apisix-website/pull/152 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1165: tip: display a warning message on the dashboard if the user is not using the recommended APISIX + Dashboard version

2021-01-21 Thread GitBox
juzhiyuan commented on issue #1165: URL: https://github.com/apache/apisix-dashboard/issues/1165#issuecomment-764418795 **Backend** - Provide the `version_check` API; **Frontend** - Call the above API when the page first shows, once.

[GitHub] [apisix] membphis commented on a change in pull request #2101: feat: customed config.yaml when apisix start

2021-01-21 Thread GitBox
membphis commented on a change in pull request #2101: URL: https://github.com/apache/apisix/pull/2101#discussion_r561775948 ## File path: .github/workflows/lint.yml ## @@ -1,6 +1,6 @@ name: ❄️ Lint -on: [pull_request] +on: [push, pull_request] Review comment: why do

[GitHub] [apisix] moonming commented on a change in pull request #3382: chore: the 500 response code in the upstream.lua file was changed to 503 response code

2021-01-21 Thread GitBox
moonming commented on a change in pull request #3382: URL: https://github.com/apache/apisix/pull/3382#discussion_r561885573 ## File path: apisix/upstream.lua ## @@ -131,21 +131,21 @@ function _M.set_by_route(route, api_ctx) local up_conf = api_ctx.matched_upstream

[GitHub] [apisix-ingress-controller] tokers closed issue #186: The Ginkgo tool is used in the e2e test script, but the pre-installation check is not performed in the makefile script

2021-01-21 Thread GitBox
tokers closed issue #186: URL: https://github.com/apache/apisix-ingress-controller/issues/186 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix] Firstsawyou commented on a change in pull request #3366: docs(traffic-split): update the vars example of the docs

2021-01-21 Thread GitBox
Firstsawyou commented on a change in pull request #3366: URL: https://github.com/apache/apisix/pull/3366#discussion_r561595034 ## File path: doc/zh-cn/plugins/traffic-split.md ## @@ -55,12 +55,15 @@ traffic-split 插件使用户可以逐步引导各个上游之间的流量百分 traffic-split 插件主要由 `match` 和

[GitHub] [apisix-dashboard] moonming commented on issue #1279: 当Route中存在被禁用的插件时Service里的同名插件失效

2021-01-21 Thread GitBox
moonming commented on issue #1279: URL: https://github.com/apache/apisix-dashboard/issues/1279#issuecomment-764496391 any PR for this? This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix-dashboard] juzhiyuan closed issue #1335: Align dashboard menu options to the left

2021-01-21 Thread GitBox
juzhiyuan closed issue #1335: URL: https://github.com/apache/apisix-dashboard/issues/1335 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix-dashboard] guoqqqi commented on a change in pull request #1308: test: Create Upstream in Route.

2021-01-21 Thread GitBox
guoqqqi commented on a change in pull request #1308: URL: https://github.com/apache/apisix-dashboard/pull/1308#discussion_r561898842 ## File path: web/cypress/integration/route/create-route-with-upstream.spec.js ## @@ -93,7 +93,7 @@ context('Create Route with Upstream', () =>

[GitHub] [apisix-docker] ClementeGao commented on issue #122: failed to paa rse yaml config: failed to merge, path[etcd->timeout] expect: number, but got: string

2021-01-21 Thread GitBox
ClementeGao commented on issue #122: URL: https://github.com/apache/apisix-docker/issues/122#issuecomment-765128154 一定要检查下配置文件 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1344: fix: ignore the init_dir event when watching etcd events

2021-01-21 Thread GitBox
juzhiyuan merged pull request #1344: URL: https://github.com/apache/apisix-dashboard/pull/1344 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix-ingress-controller] membphis merged pull request #194: doc: Add Apache APISIX link in README

2021-01-21 Thread GitBox
membphis merged pull request #194: URL: https://github.com/apache/apisix-ingress-controller/pull/194 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [apisix] tokers commented on a change in pull request #3335: fix: Use luajit or lua 5.1 by default when run APISIX

2021-01-21 Thread GitBox
tokers commented on a change in pull request #3335: URL: https://github.com/apache/apisix/pull/3335#discussion_r561456506 ## File path: apisix/cli/apisix.lua ## @@ -0,0 +1,36 @@ +#!/usr/bin/env /usr/local/Cellar/openresty/1.19.3.1_1/luajit/bin/luajit Review comment:

[GitHub] [apisix] spacewander commented on issue #3374: Modify the 500 response code in the upstream.lua file to 503 response code

2021-01-21 Thread GitBox
spacewander commented on issue #3374: URL: https://github.com/apache/apisix/issues/3374#issuecomment-764218407 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [apisix-dashboard] juzhiyuan closed issue #1290: Switch Language doesn't work 樂

2021-01-21 Thread GitBox
juzhiyuan closed issue #1290: URL: https://github.com/apache/apisix-dashboard/issues/1290 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix] pengtaochang closed issue #3364: request help: How to use apisix proxy apisix-dashboard

2021-01-21 Thread GitBox
pengtaochang closed issue #3364: URL: https://github.com/apache/apisix/issues/3364 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] idbeta edited a comment on issue #3391: [proposal]: add performance testing in CI

2021-01-21 Thread GitBox
idbeta edited a comment on issue #3391: URL: https://github.com/apache/apisix/issues/3391#issuecomment-765087092 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1347: fix: editing a Service, the upstream info will be lost.

2021-01-21 Thread GitBox
codecov-io commented on pull request #1347: URL: https://github.com/apache/apisix-dashboard/pull/1347#issuecomment-764777926 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1347?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] KishaniKandasamy commented on pull request #1358: fix: add maxlength={256} to Input.TextArea

2021-01-21 Thread GitBox
KishaniKandasamy commented on pull request #1358: URL: https://github.com/apache/apisix-dashboard/pull/1358#issuecomment-765134440 ![Screenshot (45)](https://user-images.githubusercontent.com/53715187/105450607-d4399b80-5ca0-11eb-97a5-38bc4e865d1c.png)

[GitHub] [apisix] membphis commented on issue #3390: request help: does the proxy_cache plugin support static resource cache

2021-01-21 Thread GitBox
membphis commented on issue #3390: URL: https://github.com/apache/apisix/issues/3390#issuecomment-764733027 > Configure `location ~* /service_a/(.*)\.(png|jpg|js|css)$` in apisix, can it solve your problem? this is not a best way in APISIX. we can use the Route + proxy cache plugin

[GitHub] [apisix-dashboard] nic-chen commented on pull request #1102: feat: import route from OpenAPI Specification3.0

2021-01-21 Thread GitBox
nic-chen commented on pull request #1102: URL: https://github.com/apache/apisix-dashboard/pull/1102#issuecomment-764209076 > @nic-chen Hi, the CI of your PR has not been passed. You need to rebase the master branch, and the get list method of store needs to add the `context` parameter

[GitHub] [apisix] tokers commented on issue #3393: Plugin enhance

2021-01-21 Thread GitBox
tokers commented on issue #3393: URL: https://github.com/apache/apisix/issues/3393#issuecomment-765067688 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [apisix] spacewander closed issue #3357: bug: failed to match the host which contains uppercase letters

2021-01-21 Thread GitBox
spacewander closed issue #3357: URL: https://github.com/apache/apisix/issues/3357 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] idbeta commented on issue #3391: [proposal]: add performance testing in CI

2021-01-21 Thread GitBox
idbeta commented on issue #3391: URL: https://github.com/apache/apisix/issues/3391#issuecomment-764523577 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [apisix-docker] ClementeGao closed issue #122: failed to paa rse yaml config: failed to merge, path[etcd->timeout] expect: number, but got: string

2021-01-21 Thread GitBox
ClementeGao closed issue #122: URL: https://github.com/apache/apisix-docker/issues/122 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix] Firstsawyou commented on issue #3390: request help: does the proxy_cache plugin support static resource cache

2021-01-21 Thread GitBox
Firstsawyou commented on issue #3390: URL: https://github.com/apache/apisix/issues/3390#issuecomment-764509337 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [apisix] juzhiyuan closed issue #3378: Label feature doesn't support Chinese as key?

2021-01-21 Thread GitBox
juzhiyuan closed issue #3378: URL: https://github.com/apache/apisix/issues/3378 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix-ingress-controller] membphis closed issue #193: request help: Need to add Apache APISIX link in README

2021-01-21 Thread GitBox
membphis closed issue #193: URL: https://github.com/apache/apisix-ingress-controller/issues/193 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix-ingress-controller] FeynmanZhou commented on pull request #195: doc: run ingress apisix on kubesphere

2021-01-21 Thread GitBox
FeynmanZhou commented on pull request #195: URL: https://github.com/apache/apisix-ingress-controller/pull/195#issuecomment-764530599 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1347: fix: editing a Service, the upstream info will be lost.

2021-01-21 Thread GitBox
codecov-io edited a comment on pull request #1347: URL: https://github.com/apache/apisix-dashboard/pull/1347#issuecomment-764777926 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1347?src=pr=h1) Report > Merging

[GitHub] [apisix] Fuchange commented on a change in pull request #3335: fix: Use luajit or lua 5.1 by default when run APISIX

2021-01-21 Thread GitBox
Fuchange commented on a change in pull request #3335: URL: https://github.com/apache/apisix/pull/3335#discussion_r561623196 ## File path: bin/apisix ## @@ -1,36 +1,41 @@ -#!/usr/bin/env lua +#!/bin/bash --- --- Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [apisix] spacewander closed issue #3389: bug: get empty data from etcd when apisix init

2021-01-21 Thread GitBox
spacewander closed issue #3389: URL: https://github.com/apache/apisix/issues/3389 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0

2021-01-21 Thread GitBox
codecov-io edited a comment on pull request #1245: URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-757579417 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [apisix-dashboard] starsz commented on issue #1161: Feat: remove the etcd dependency in the unit test

2021-01-21 Thread GitBox
starsz commented on issue #1161: URL: https://github.com/apache/apisix-dashboard/issues/1161#issuecomment-764434550 This is a big project, I will finish part of them in M2.4 This is an automated message from the Apache Git

[GitHub] [apisix-ingress-controller] tokers commented on pull request #192: chore: introduce ingress-types, rename ApisixTls to ApisixTLS

2021-01-21 Thread GitBox
tokers commented on pull request #192: URL: https://github.com/apache/apisix-ingress-controller/pull/192#issuecomment-764448797 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [apisix-dashboard] starsz commented on issue #1127: bug: manager-api doesn't support PATCH method

2021-01-21 Thread GitBox
starsz commented on issue #1127: URL: https://github.com/apache/apisix-dashboard/issues/1127#issuecomment-764432654 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[apisix-ingress-controller] branch master updated: add milestone link (#198)

2021-01-21 Thread kvn
This is an automated email from the ASF dual-hosted git repository. kvn pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git The following commit(s) were added to refs/heads/master by this push: new 009db9b add milestone link

[GitHub] [apisix-ingress-controller] gxthrj commented on issue #193: request help: Need to add Apache APISIX link in README

2021-01-21 Thread GitBox
gxthrj commented on issue #193: URL: https://github.com/apache/apisix-ingress-controller/issues/193#issuecomment-764462551 Is there anybody interested to deal with this issue? This is an automated message from the Apache

[GitHub] [apisix-helm-chart] tokers commented on a change in pull request #20: Modify Helm template to support multiple etcdhost, add anti-affinity

2021-01-21 Thread GitBox
tokers commented on a change in pull request #20: URL: https://github.com/apache/apisix-helm-chart/pull/20#discussion_r562338355 ## File path: README.md ## @@ -44,14 +44,15 @@ helm uninstall apisix ./chart/apisix -n default 1. How to install APISIX only? -The Charts will

[GitHub] [apisix-ingress-controller] tokers commented on pull request #190: chore:add ginkgo check before e2e-test(apache #186)

2021-01-21 Thread GitBox
tokers commented on pull request #190: URL: https://github.com/apache/apisix-ingress-controller/pull/190#issuecomment-764691393 Many thanks! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix] nic-chen commented on issue #3383: request help: how do i know plugin Orchestration condition variables

2021-01-21 Thread GitBox
nic-chen commented on issue #3383: URL: https://github.com/apache/apisix/issues/3383#issuecomment-764739359 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [apisix] idbeta commented on pull request #3365: test: add shell script for run APISIX testcases on ARM64

2021-01-21 Thread GitBox
idbeta commented on pull request #3365: URL: https://github.com/apache/apisix/pull/3365#issuecomment-764201065 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [apisix-dashboard] nic-chen closed issue #650: support different config for APISIX and manager api in e2e test

2021-01-21 Thread GitBox
nic-chen closed issue #650: URL: https://github.com/apache/apisix-dashboard/issues/650 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix] jaredhuang commented on issue #3383: request help: how do i know plugin Orchestration condition variables

2021-01-21 Thread GitBox
jaredhuang commented on issue #3383: URL: https://github.com/apache/apisix/issues/3383#issuecomment-765056916 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [apisix] pengtaochang commented on issue #3364: request help: How to use apisix proxy apisix-dashboard

2021-01-21 Thread GitBox
pengtaochang commented on issue #3364: URL: https://github.com/apache/apisix/issues/3364#issuecomment-764206385 thanks @Miss-you @Firstsawyou This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix-dashboard] imjoey commented on issue #1329: bug: non-json data causes error logs

2021-01-21 Thread GitBox
imjoey commented on issue #1329: URL: https://github.com/apache/apisix-dashboard/issues/1329#issuecomment-764195294 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [apisix] xingren23 commented on issue #3353: request help: do you want update skywalking plugin protocal from http1.1 to grpc ?

2021-01-21 Thread GitBox
xingren23 commented on issue #3353: URL: https://github.com/apache/apisix/issues/3353#issuecomment-764190325 > Proxy gRPC in C is different from communication via gRPC in Lua. > > BTW, we are not the maintainer of skywalking. We don't own

[GitHub] [apisix] dw-3 commented on issue #3359: issue of traffic split vars

2021-01-21 Thread GitBox
dw-3 commented on issue #3359: URL: https://github.com/apache/apisix/issues/3359#issuecomment-764195663 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [apisix-dashboard] Jaycean commented on a change in pull request #1245: feat(BE): Export route from OpenAPI Specification3.0

2021-01-21 Thread GitBox
Jaycean commented on a change in pull request #1245: URL: https://github.com/apache/apisix-dashboard/pull/1245#discussion_r561660169 ## File path: api/test/e2e/route_export_test.go ## @@ -0,0 +1,716 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1344: fix: ignore the init_dir event when watching etcd events

2021-01-21 Thread GitBox
codecov-io edited a comment on pull request #1344: URL: https://github.com/apache/apisix-dashboard/pull/1344#issuecomment-764618036 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [apisix] idbeta commented on issue #3380: bug: route's description input more than 200 Chinese characters, no error message, but the route is useless

2021-01-21 Thread GitBox
idbeta commented on issue #3380: URL: https://github.com/apache/apisix/issues/3380#issuecomment-764441819 > @idbeta > Can this issue be reproduced in the latest version of dashboard? Is there any error log in the APISIX size? > 1、Can not more than 200 characters still can

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1347: fix: editing a Service, the upstream info will be lost.

2021-01-21 Thread GitBox
juzhiyuan commented on a change in pull request #1347: URL: https://github.com/apache/apisix-dashboard/pull/1347#discussion_r562296901 ## File path: web/src/pages/Service/Create.tsx ## @@ -81,13 +81,12 @@ const Page: React.FC = (props) => { (serviceId ? update(serviceId,

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1102: feat: import route from OpenAPI Specification3.0

2021-01-21 Thread GitBox
juzhiyuan commented on pull request #1102: URL: https://github.com/apache/apisix-dashboard/pull/1102#issuecomment-764448583 > Do we need to add **test cases** about > > 1. import a error file > 2. a file includes two or more APIs Yep

  1   2   3   4   5   6   >