[GitHub] [apisix] syzh opened a new pull request #3398: fix: upstream dns resolver failed response 503

syzh opened a new pull request #3398: URL: https://github.com/apache/apisix/pull/3398 fixed issue #3342. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [apisix] gewei2000 commented on issue #3390: request help: does the proxy_cache plugin support static resource cache

gewei2000 commented on issue #3390: URL: https://github.com/apache/apisix/issues/3390#issuecomment-765876941 > The way of `/service_a/(.*)\\.(png|jpg|js|css)$` is correct, but I found that regular configuration is not supported in `uris`. bug?

[GitHub] [apisix] tokers commented on issue #3112: request help: what is the use of item_release in lrucache.lua

tokers commented on issue #3112: URL: https://github.com/apache/apisix/issues/3112#issuecomment-765872096 @HelloBug0 Feel free to post any problems here if you need. This is an automated message from the Apache Git Service.

[GitHub] [apisix] Firstsawyou commented on issue #3390: request help: does the proxy_cache plugin support static resource cache

Firstsawyou commented on issue #3390: URL: https://github.com/apache/apisix/issues/3390#issuecomment-765867436 The way of `/service_a/(.*)\\.(png|jpg|js|css)$` is correct, but I found that regular configuration is not supported in `uris`.

[GitHub] [apisix] Firstsawyou commented on issue #3390: request help: does the proxy_cache plugin support static resource cache

Firstsawyou commented on issue #3390: URL: https://github.com/apache/apisix/issues/3390#issuecomment-765857555 > @membphis @Firstsawyou Okay, let me check. This is an automated message from the Apache Git Service. To

[GitHub] [apisix] gewei2000 commented on issue #3390: request help: does the proxy_cache plugin support static resource cache

gewei2000 commented on issue #3390: URL: https://github.com/apache/apisix/issues/3390#issuecomment-765848337 @membphis @Firstsawyou This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [apisix] HelloBug0 commented on issue #3112: request help: what is the use of item_release in lrucache.lua

HelloBug0 commented on issue #3112: URL: https://github.com/apache/apisix/issues/3112#issuecomment-765838470 Sorry to replay this later and not make myself clearly. Yeah, I'm willing to submit a PR, but before that, I want to spend more time studying APISIX code which is I am doing now.

[GitHub] [apisix] HelloBug0 commented on issue #3229: request help: Here is a big confusion about self.running in config.etcd.lua?

HelloBug0 commented on issue #3229: URL: https://github.com/apache/apisix/issues/3229#issuecomment-765831602 It helps, really appreciated for you answers. This is an automated message from the Apache Git Service. To respond

[GitHub] [apisix-dashboard] LiteSun closed issue #1213: The process of creating routes using dashboard needs improvement

LiteSun closed issue #1213: URL: https://github.com/apache/apisix-dashboard/issues/1213 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[apisix-dashboard] branch master updated: feat: user can skip upstream when select service_id (#1302)

This is an automated email from the ASF dual-hosted git repository. sunyi pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new 6c3f35c feat: user can skip upstream

[GitHub] [apisix-dashboard] LiteSun merged pull request #1302: feat: user can skip upstream when select service_id

LiteSun merged pull request #1302: URL: https://github.com/apache/apisix-dashboard/pull/1302 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix-dashboard] LiteSun closed issue #1278: bug(fe): route created with service can not use the service upstream

LiteSun closed issue #1278: URL: https://github.com/apache/apisix-dashboard/issues/1278 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1240: feat(fe): import and export routes

codecov-io edited a comment on pull request #1240: URL: https://github.com/apache/apisix-dashboard/pull/1240#issuecomment-756554309 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1240?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1361: test: update code

juzhiyuan commented on a change in pull request #1361: URL: https://github.com/apache/apisix-dashboard/pull/1361#discussion_r562711279 ## File path: web/cypress/integration/route/create-route-can-skip-upstream.spec.js ## @@ -0,0 +1,141 @@ +/* Review comment: bad title

[GitHub] [apisix-dashboard] Jaycean commented on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0

Jaycean commented on pull request #1245: URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-765474916 > > > > > > Hi, @Jaycean. Need unit test. > > > > > > > > > > > > > > > At present, the function interface needs to export the existing route data and ensure

[GitHub] [apisix] spacewander closed issue #2916: request help: how to validates the requests by user

spacewander closed issue #2916: URL: https://github.com/apache/apisix/issues/2916 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix-dashboard] liuxiran commented on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0

liuxiran commented on pull request #1245: URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-765473883 Test cases are good for me This is an automated message from the Apache Git Service. To respond to

[GitHub] [apisix] spacewander commented on a change in pull request #3396: change: global rules should not be executed on the internal api

spacewander commented on a change in pull request #3396: URL: https://github.com/apache/apisix/pull/3396#discussion_r562699131 ## File path: apisix/init.lua ## @@ -324,6 +324,28 @@ function _M.http_access_phase() core.ctx.set_vars_meta(api_ctx) +local uri =

[GitHub] [apisix-dashboard] guoqqqi opened a new pull request #1361: test: update code

guoqqqi opened a new pull request #1361: URL: https://github.com/apache/apisix-dashboard/pull/1361 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - [ ]

[GitHub] [apisix] spacewander closed issue #2662: bug: Can't turn on Skywalking

spacewander closed issue #2662: URL: https://github.com/apache/apisix/issues/2662 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] spacewander closed issue #2118: request help: openid-connect JSON decode failed

spacewander closed issue #2118: URL: https://github.com/apache/apisix/issues/2118 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] spacewander closed issue #2487: request help: rpc error: code = Unavailable desc = connection closed

spacewander closed issue #2487: URL: https://github.com/apache/apisix/issues/2487 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] spacewander commented on issue #1861: Make admin APISIX response return JSON instead of HTML content

spacewander commented on issue #1861: URL: https://github.com/apache/apisix/issues/1861#issuecomment-765458582 Surpassed by #3316 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [apisix] spacewander closed issue #1861: Make admin APISIX response return JSON instead of HTML content

spacewander closed issue #1861: URL: https://github.com/apache/apisix/issues/1861 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix-dashboard] liuxiran edited a comment on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0

liuxiran edited a comment on pull request #1245: URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-765308727 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [apisix] spacewander closed issue #3388: bug: the balancer_ip is old, resulting in 504 timeout

spacewander closed issue #3388: URL: https://github.com/apache/apisix/issues/3388 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] spacewander closed issue #1780: consul serviece create route limit req report 502

spacewander closed issue #1780: URL: https://github.com/apache/apisix/issues/1780 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] spacewander commented on issue #1272: Support JWT scopes to allow or reject requests in OAuth2 plugin

spacewander commented on issue #1272: URL: https://github.com/apache/apisix/issues/1272#issuecomment-765454260 Is it still in need? This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0

codecov-io edited a comment on pull request #1245: URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-757579417 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1245?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1102: feat: import route from OpenAPI Specification3.0

codecov-io edited a comment on pull request #1102: URL: https://github.com/apache/apisix-dashboard/pull/1102#issuecomment-752030848 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1102?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] liuxiran edited a comment on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0

liuxiran edited a comment on pull request #1245: URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-765308727 checklist: - [x] export route with host **(test2 coverd)** - [x] export route with hosts **(test1 coverd)** - [x] export route with uri **(test2

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0

codecov-io edited a comment on pull request #1245: URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-757579417 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1245?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] liuxiran edited a comment on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0

liuxiran edited a comment on pull request #1245: URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-765308727 checklist: - [x] export route with host **(test2 coverd)** - [x] export route with hosts **(test1 coverd)** - [x] export route with uri **(test2

[GitHub] [apisix-dashboard] guoqqqi closed pull request #1360: feat: update code

guoqqqi closed pull request #1360: URL: https://github.com/apache/apisix-dashboard/pull/1360 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix-dashboard] liuxiran edited a comment on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0

liuxiran edited a comment on pull request #1245: URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-765308727 checklist: - [x] export route with host **(test2 coverd)** - [x] export route with hosts **(test1 coverd)** - [x] export route with uri **(test2

[GitHub] [apisix-dashboard] liuxiran edited a comment on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0

liuxiran edited a comment on pull request #1245: URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-765308727 checklist: - [x] export route with host **(test2 coverd)** - [x] export route with hosts **(test1 coverd)** - [x] export route with uri **(test2

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0

codecov-io edited a comment on pull request #1245: URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-757579417 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1245?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1360: feat: update code

codecov-io commented on pull request #1360: URL: https://github.com/apache/apisix-dashboard/pull/1360#issuecomment-765401949 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1360?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] guoqqqi opened a new pull request #1360: feat: update code

guoqqqi opened a new pull request #1360: URL: https://github.com/apache/apisix-dashboard/pull/1360 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - [ ]

[GitHub] [apisix] nic-chen commented on a change in pull request #3396: change: global rules should not be executed on the internal api

nic-chen commented on a change in pull request #3396: URL: https://github.com/apache/apisix/pull/3396#discussion_r562625641 ## File path: t/node/global-rule.t ## @@ -120,7 +120,34 @@ GET /hello -=== TEST 6: delete global rule +=== TEST 6: not limited +--- request +GET

[GitHub] [apisix] nic-chen commented on a change in pull request #3396: change: global rules should not be executed on the internal api

nic-chen commented on a change in pull request #3396: URL: https://github.com/apache/apisix/pull/3396#discussion_r562624813 ## File path: apisix/init.lua ## @@ -324,6 +324,28 @@ function _M.http_access_phase() core.ctx.set_vars_meta(api_ctx) +local uri =

[GitHub] [apisix-dashboard] LiteSun commented on pull request #1302: feat: user can skip upstream when select service_id

LiteSun commented on pull request #1302: URL: https://github.com/apache/apisix-dashboard/pull/1302#issuecomment-765382732 Ping This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [apisix-dashboard] nic-chen merged pull request #1359: fix: Skip the data directly in Storage level

nic-chen merged pull request #1359: URL: https://github.com/apache/apisix-dashboard/pull/1359 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[apisix-dashboard] branch master updated (81dbdbf -> bb0a057)

This is an automated email from the ASF dual-hosted git repository. chenjunxu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 81dbdbf fix: ignore the init_dir event when watching etcd events (#1344) add bb0a057 fix: Skip

[GitHub] [apisix-dashboard] nic-chen closed issue #1357: Why we need to skip it in store not storage?

nic-chen closed issue #1357: URL: https://github.com/apache/apisix-dashboard/issues/1357 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix-dashboard] nic-chen commented on pull request #1102: feat: import route from OpenAPI Specification3.0

nic-chen commented on pull request #1102: URL: https://github.com/apache/apisix-dashboard/pull/1102#issuecomment-765366914 > Do we need to add a test case about a route with as many props as possible sure This is an

[GitHub] [apisix] juzhiyuan opened a new issue #3397: Update Dashboard's screenshot

juzhiyuan opened a new issue #3397: URL: https://github.com/apache/apisix/issues/3397 # Improve Docs ## Please describe which part of docs should be improved or typo fixed I see there have some pages[1] which still include 1.0 Dashboard's screenshot. [1]

[GitHub] [apisix] tokers commented on a change in pull request #3335: fix: Use luajit or lua 5.1 by default when run APISIX

tokers commented on a change in pull request #3335: URL: https://github.com/apache/apisix/pull/3335#discussion_r562585645 ## File path: bin/apisix ## @@ -1,36 +1,43 @@ -#!/usr/bin/env lua +#!/bin/bash --- --- Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [apisix] tokers commented on a change in pull request #3396: change: global rules should not be executed on the internal api

tokers commented on a change in pull request #3396: URL: https://github.com/apache/apisix/pull/3396#discussion_r562583252 ## File path: t/node/global-rule.t ## @@ -120,7 +120,34 @@ GET /hello -=== TEST 6: delete global rule +=== TEST 6: not limited +--- request +GET

[GitHub] [apisix-ingress-controller] tokers closed issue #159: chore: implement a script shell to check the version

tokers closed issue #159: URL: https://github.com/apache/apisix-ingress-controller/issues/159 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix-ingress-controller] tokers merged pull request #200: chore: add check version script

tokers merged pull request #200: URL: https://github.com/apache/apisix-ingress-controller/pull/200 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[apisix-ingress-controller] branch master updated: chore: add check version script (#200)

This is an automated email from the ASF dual-hosted git repository. tokers pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git The following commit(s) were added to refs/heads/master by this push: new f0ed89f chore: add check

[GitHub] [apisix-dashboard] liuxiran commented on pull request #1102: feat: import route from OpenAPI Specification3.0

liuxiran commented on pull request #1102: URL: https://github.com/apache/apisix-dashboard/pull/1102#issuecomment-765343958 Do we need to add a test case about a route with as many props as possible? This is an automated

[GitHub] [apisix-ingress-controller] lianghao208 commented on pull request #200: chore: add check version script

lianghao208 commented on pull request #200: URL: https://github.com/apache/apisix-ingress-controller/pull/200#issuecomment-765337960 > Just make sure the file is assigned executable permissions by default. @gxthrj Yes, it's assigned executable permissions by default.

[GitHub] [apisix-dashboard] liuxiran edited a comment on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0

liuxiran edited a comment on pull request #1245: URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-765308727 checklist: - [x] export route with host **(test2 coverd)** - [x] export route with hosts **(test1 coverd)** - [x] export route with uri **(test2

[GitHub] [apisix-dashboard] liuxiran edited a comment on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0

liuxiran edited a comment on pull request #1245: URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-765308727 checklist: - [x] export route with host **(test2 coverd)** - [x] export route with hosts **(test1 coverd)** - [x] export route with uri **(test2

[GitHub] [apisix-dashboard] liuxiran edited a comment on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0

liuxiran edited a comment on pull request #1245: URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-765308727 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [apisix] spacewander commented on issue #2692: request help: got malformed version message: "" from etcd

spacewander commented on issue #2692: URL: https://github.com/apache/apisix/issues/2692#issuecomment-765332216 Consider solved This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [apisix] spacewander closed issue #2692: request help: got malformed version message: "" from etcd

spacewander closed issue #2692: URL: https://github.com/apache/apisix/issues/2692 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix-dashboard] liuxiran edited a comment on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0

liuxiran edited a comment on pull request #1245: URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-765308727 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [apisix-dashboard] liuxiran edited a comment on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0

liuxiran edited a comment on pull request #1245: URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-765308727 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [apisix-dashboard] liuxiran edited a comment on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0

liuxiran edited a comment on pull request #1245: URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-765308727 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [apisix-dashboard] liuxiran commented on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0

liuxiran commented on pull request #1245: URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-765308727 checklist: - [ ] export route with host - [ ] export route with hosts - [ ] export route with uri - [ ] export route with uris - [ ] export route

[GitHub] [apisix] Fuchange commented on a change in pull request #3335: fix: Use luajit or lua 5.1 by default when run APISIX

Fuchange commented on a change in pull request #3335: URL: https://github.com/apache/apisix/pull/3335#discussion_r562522817 ## File path: bin/apisix ## @@ -1,36 +1,43 @@ -#!/usr/bin/env lua +#!/bin/bash --- --- Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [apisix-ingress-controller] tokers merged pull request #192: chore: introduce ingress-types, rename ApisixTls to ApisixTLS

tokers merged pull request #192: URL: https://github.com/apache/apisix-ingress-controller/pull/192 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1302: feat: user can skip upstream when select service_id

codecov-io edited a comment on pull request #1302: URL: https://github.com/apache/apisix-dashboard/pull/1302#issuecomment-760639257 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1302?src=pr=h1) Report > Merging

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0

codecov-io edited a comment on pull request #1245: URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-757579417 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1245?src=pr=h1) Report > Merging

[GitHub] [apisix] idbeta commented on pull request #3365: test: add shell script for run APISIX testcases on ARM64

idbeta commented on pull request #3365: URL: https://github.com/apache/apisix/pull/3365#issuecomment-765280437 > why not use dockerfile for it？ This script is just a preliminary idea for the backup, not the final solution. If want to fully implement it, need to solve the problems

[GitHub] [apisix] idbeta commented on issue #3340: How to do fuzz testing on Apache APISIX

idbeta commented on issue #3340: URL: https://github.com/apache/apisix/issues/3340#issuecomment-765275479 > the `WHY` is not enough from your proposal. Generally speaking, fuzzing is an effective method of security testing, but for APISIX, because APISIX handles massive amounts of

[apisix] branch master updated (d698220 -> c8d35cd)

This is an automated email from the ASF dual-hosted git repository. membphis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from d698220 fix: ignore the case of configured host (#3377) add c8d35cd fix(standalone): require consumer's id

[GitHub] [apisix] membphis merged pull request #3394: fix(standalone): require consumer's id to be the same as username

membphis merged pull request #3394: URL: https://github.com/apache/apisix/pull/3394 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] gewei2000 commented on issue #3390: request help: does the proxy_cache plugin support static resource cache

gewei2000 commented on issue #3390: URL: https://github.com/apache/apisix/issues/3390#issuecomment-765268928 > > > > Configure `location ~* /service_a/(.*)\.(png|jpg|js|css)$` in apisix, can it solve your problem? > > > > > > > > > this is not a best way in APISIX. we can use

[GitHub] [apisix-dashboard] starsz commented on issue #1351: bug: some apis bypassed authentication

starsz commented on issue #1351: URL: https://github.com/apache/apisix-dashboard/issues/1351#issuecomment-765266321 Right. It's a bug. IMO, we can wrap those functions into droplet, because the droplet has updated before.

[GitHub] [apisix-dashboard] starsz commented on pull request #1245: feat(BE): Export route from OpenAPI Specification3.0

starsz commented on pull request #1245: URL: https://github.com/apache/apisix-dashboard/pull/1245#issuecomment-765262758 > > > > > Hi, @Jaycean. Need unit test. > > > > > > > > > > > > At present, the function interface needs to export the existing route data and ensure the

[GitHub] [apisix] spacewander commented on a change in pull request #3396: change: global rules should not be executed on the internal api

spacewander commented on a change in pull request #3396: URL: https://github.com/apache/apisix/pull/3396#discussion_r562493471 ## File path: apisix/init.lua ## @@ -324,6 +324,28 @@ function _M.http_access_phase() core.ctx.set_vars_meta(api_ctx) +local uri =

[GitHub] [apisix-ingress-controller] lianghao208 commented on pull request #200: chore: add check version script

lianghao208 commented on pull request #200: URL: https://github.com/apache/apisix-ingress-controller/pull/200#issuecomment-765257662 @gxthrj PTAL, thanks! This is an automated message from the Apache Git Service. To respond

[GitHub] [apisix] nic-chen commented on a change in pull request #3396: change: global rules should not be executed on the internal api

nic-chen commented on a change in pull request #3396: URL: https://github.com/apache/apisix/pull/3396#discussion_r562488874 ## File path: apisix/init.lua ## @@ -324,6 +324,28 @@ function _M.http_access_phase() core.ctx.set_vars_meta(api_ctx) +local uri =

[GitHub] [apisix] nic-chen commented on pull request #3396: change: global rules should not be executed on the internal api

nic-chen commented on pull request #3396: URL: https://github.com/apache/apisix/pull/3396#issuecomment-765255902 > We need a test case for it. we have [test

[GitHub] [apisix] spacewander commented on issue #2076: bug: service discovery duplicate request service information in Eureka

spacewander commented on issue #2076: URL: https://github.com/apache/apisix/issues/2076#issuecomment-765249902 Currently all the workers will fetch service info from Eureka. This is an automated message from the Apache Git

[GitHub] [apisix] idbeta commented on issue #3391: [proposal]: add performance testing in CI

idbeta commented on issue #3391: URL: https://github.com/apache/apisix/issues/3391#issuecomment-765239640 > I don’t think it’s a good idea to perform benchmark on github actions. > We cannot know the performance of the machine behind GH and how busy CI is. I quite agree with your

[GitHub] [apisix] spacewander commented on pull request #3396: change: global rules should not be executed on the internal api

spacewander commented on pull request #3396: URL: https://github.com/apache/apisix/pull/3396#issuecomment-765239386 We need a test case for it. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix] spacewander commented on a change in pull request #3396: chore: global rules should not be executed on the internal api

spacewander commented on a change in pull request #3396: URL: https://github.com/apache/apisix/pull/3396#discussion_r562470528 ## File path: apisix/init.lua ## @@ -324,6 +324,28 @@ function _M.http_access_phase() core.ctx.set_vars_meta(api_ctx) +local uri =

[GitHub] [apisix-docker] gxthrj commented on issue #122: failed to paa rse yaml config: failed to merge, path[etcd->timeout] expect: number, but got: string

gxthrj commented on issue #122: URL: https://github.com/apache/apisix-docker/issues/122#issuecomment-765235440 > 一定要检查下配置文件 haha,It is a fair suggestion. This is an automated message from the Apache Git Service. To

[GitHub] [apisix] moonming commented on issue #3391: [proposal]: add performance testing in CI

moonming commented on issue #3391: URL: https://github.com/apache/apisix/issues/3391#issuecomment-765231429 I don’t think it’s a good idea to perform benchmark on github actions. We cannot know the performance of the machine behind GH and how busy CI is.

[GitHub] [apisix-ingress-controller] tokers commented on pull request #199: chore: generate id instead let APISIX do it

tokers commented on pull request #199: URL: https://github.com/apache/apisix-ingress-controller/pull/199#issuecomment-765229502 @gxthrj Fixed. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix] idbeta commented on issue #3391: [proposal]: add performance testing in CI

idbeta commented on issue #3391: URL: https://github.com/apache/apisix/issues/3391#issuecomment-765228192 > > @idbeta How could we know that "not differ too much" would happen, or "they are within an order of magnitude". Maybe we need some methods to get over those false positives, but

[GitHub] [apisix] nic-chen opened a new pull request #3396: chore: global rules should not be executed on the internal api

nic-chen opened a new pull request #3396: URL: https://github.com/apache/apisix/pull/3396 ### What this PR does / why we need it: global rules should not be executed on the internal api, currently it will run `access` and `rewrite` of plugins in global rule, so we need to

[GitHub] [apisix] pengtaochang commented on issue #2208: Is Apache APISIX support strip_path in Kong?

pengtaochang commented on issue #2208: URL: https://github.com/apache/apisix/issues/2208#issuecomment-765227851  I using proxy_rewrite plugin achieve the strip_path feature.

[GitHub] [apisix] gewei2000 edited a comment on issue #3390: request help: does the proxy_cache plugin support static resource cache

gewei2000 edited a comment on issue #3390: URL: https://github.com/apache/apisix/issues/3390#issuecomment-765149345 > > Configure `location ~* /service_a/(.*)\.(png|jpg|js|css)$` in apisix, can it solve your problem? > > this is not a best way in APISIX. we can use the Route + proxy

[GitHub] [apisix] Firstsawyou commented on issue #3390: request help: does the proxy_cache plugin support static resource cache

Firstsawyou commented on issue #3390: URL: https://github.com/apache/apisix/issues/3390#issuecomment-765225039 > > > Configure `location ~* /service_a/(.*)\.(png|jpg|js|css)$` in apisix, can it solve your problem? > > > > > > this is not a best way in APISIX. we can use the

[GitHub] [apisix] Firstsawyou commented on issue #3390: request help: does the proxy_cache plugin support static resource cache

Firstsawyou commented on issue #3390: URL: https://github.com/apache/apisix/issues/3390#issuecomment-765220975 > > not find any matched route, > > Hi, @gewei2000 What is the `uri` you request for this route? Sorry, I saw it in the log information.

[GitHub] [apisix] Firstsawyou commented on issue #3390: request help: does the proxy_cache plugin support static resource cache

Firstsawyou commented on issue #3390: URL: https://github.com/apache/apisix/issues/3390#issuecomment-765220256 > not find any matched route, Hi, @gewei2000 What is the `uri` you request for this route? This is an

[GitHub] [apisix-ingress-controller] gxthrj commented on pull request #199: chore: generate id instead let APISIX do it

gxthrj commented on pull request #199: URL: https://github.com/apache/apisix-ingress-controller/pull/199#issuecomment-765218542 UT failed This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix-ingress-controller] gxthrj commented on pull request #192: chore: introduce ingress-types, rename ApisixTls to ApisixTLS

gxthrj commented on pull request #192: URL: https://github.com/apache/apisix-ingress-controller/pull/192#issuecomment-765218073 > > Need to update docs which contains `ApisixTls`. > > The docs are all about CRD `ApisixTls`, considering the compatiblity, i didn't change the CRD

[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #200: chore: add check version script

codecov-io commented on pull request #200: URL: https://github.com/apache/apisix-ingress-controller/pull/200#issuecomment-765218068 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/200?src=pr=h1) Report > Merging

[GitHub] [apisix-ingress-controller] lianghao208 opened a new pull request #200: chore: add check version script

lianghao208 opened a new pull request #200: URL: https://github.com/apache/apisix-ingress-controller/pull/200 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [x] New feature provided - [ ] Improve performance -

[GitHub] [apisix-dashboard] imjoey commented on pull request #1359: fix: Skip the data directly in Storage level

imjoey commented on pull request #1359: URL: https://github.com/apache/apisix-dashboard/pull/1359#issuecomment-765215648 ping @ShiningRush @tokers @nic-chen for reviewing. Thanks. BTW, regarding to the test cases, I had to admitted that at present I've no idea about how to check if

[GitHub] [apisix-ingress-controller] tokers opened a new pull request #199: chore: generate id instead let APISIX do it

tokers opened a new pull request #199: URL: https://github.com/apache/apisix-ingress-controller/pull/199 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - [ ]

[GitHub] [apisix-ingress-controller] tokers commented on pull request #199: chore: generate id instead let APISIX do it

tokers commented on pull request #199: URL: https://github.com/apache/apisix-ingress-controller/pull/199#issuecomment-765215598 @gxthrj This is an automated message from the Apache Git Service. To respond to the message,