Jaycean opened a new issue #1392:
URL: https://github.com/apache/apisix-dashboard/issues/1392
# Feature request
## Please describe your feature
When I look at the test cases, I find that the
jsonpatch(`github.com/api7/go-jsonpatch`) used by upstream and service when
calling
spacewander commented on issue #3455:
URL: https://github.com/apache/apisix/issues/3455#issuecomment-769642206
You should add the path of OpenResty to your root user's `$PATH` instead of
yours, as you call `make` with the sudo.
BTW, although you don't tell us why you use `make
tokers opened a new issue #217:
URL: https://github.com/apache/apisix-ingress-controller/issues/217
### Issue description
### Environment
* your apisix-ingress-controller version (output of
`apisix-ingress-controller version --long`);
* your Kubernetes cluster version
tokers commented on pull request #216:
URL:
https://github.com/apache/apisix-ingress-controller/pull/216#issuecomment-769639164
@starsz @membphis PTAL, thanks!
This is an automated message from the Apache Git Service.
To
codecov-io edited a comment on pull request #216:
URL:
https://github.com/apache/apisix-ingress-controller/pull/216#issuecomment-769617830
#
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/216?src=pr=h1)
Report
> Merging
tokers commented on pull request #212:
URL:
https://github.com/apache/apisix-ingress-controller/pull/212#issuecomment-769636330
Need to implement after some bugs in ApisixUpstreamController is fixed.
This is an automated
tokers closed pull request #212:
URL: https://github.com/apache/apisix-ingress-controller/pull/212
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
LutzWeischerFujitsu opened a new issue #3455:
URL: https://github.com/apache/apisix/issues/3455
### Issue description
### Environment
* apisix version (cmd: `apisix version`): current master
* OS: (cmd: `uname -a`): Fedora 33, AArch64
* OpenResty / Nginx version: (cmd:
spacewander opened a new pull request #3454:
URL: https://github.com/apache/apisix/pull/3454
Signed-off-by: spacewander
### What this PR does / why we need it:
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new
codecov-io commented on pull request #216:
URL:
https://github.com/apache/apisix-ingress-controller/pull/216#issuecomment-769617830
#
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/216?src=pr=h1)
Report
> Merging
tokers commented on a change in pull request #3415:
URL: https://github.com/apache/apisix/pull/3415#discussion_r566613696
##
File path: doc/install-dependencies.md
##
@@ -73,7 +78,10 @@ tar -xvf etcd-v3.4.13-linux-amd64.tar.gz && \
sudo cp -a etcd etcdctl /usr/bin/
#
tokers commented on a change in pull request #3415:
URL: https://github.com/apache/apisix/pull/3415#discussion_r566613614
##
File path: doc/install-dependencies.md
##
@@ -53,7 +53,7 @@ sudo yum install yum-utils
sudo yum-config-manager --add-repo
tokers opened a new pull request #216:
URL: https://github.com/apache/apisix-ingress-controller/pull/216
…etion
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bugfix
- [ ] New feature provided
- [ ] Improve
starsz commented on issue #1388:
URL:
https://github.com/apache/apisix-dashboard/issues/1388#issuecomment-769604851
Hi @Yiyiyimu,
>`using bare net/http pkg to access the route would always return "404 Route
not found", although the route is created, accessing the same URL with
codecov-io edited a comment on pull request #1385:
URL: https://github.com/apache/apisix-dashboard/pull/1385#issuecomment-768304330
#
[Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1385?src=pr=h1)
Report
> Merging
nic-chen commented on issue #1391:
URL:
https://github.com/apache/apisix-dashboard/issues/1391#issuecomment-769594418
looking forward to it，thanks
This is an automated message from the Apache Git Service.
To respond to the
idbeta edited a comment on issue #3452:
URL: https://github.com/apache/apisix/issues/3452#issuecomment-769591977
It is too strange, you should provide your environment and steps to locate
the problem @sandy420
```
* apisix version (cmd: `apisix version`):
* OS: (cmd: `uname -a`)
idbeta commented on issue #3452:
URL: https://github.com/apache/apisix/issues/3452#issuecomment-769591977
this issue is too strange, you should provide your environment and steps,
```
* apisix version (cmd: `apisix version`):
* OS: (cmd: `uname -a`)
* OpenResty / Nginx version:
Firstsawyou commented on issue #3452:
URL: https://github.com/apache/apisix/issues/3452#issuecomment-769582366
Based on the information provided, your problem cannot be determined. You
should provide a complete usage example.
Yiyiyimu edited a comment on pull request #3404:
URL: https://github.com/apache/apisix/pull/3404#issuecomment-769532063
> @Yiyiyimu It seems in this case you kill all etcd members. What about just
killing the leader (will recover overtime), killing the follower (no issue),
kill majority
Firstsawyou commented on issue #3452:
URL: https://github.com/apache/apisix/issues/3452#issuecomment-769566969
Have you changed the code of Apisix?
This is an automated message from the Apache Git Service.
To respond to the
fukiki commented on pull request #3335:
URL: https://github.com/apache/apisix/pull/3335#issuecomment-769566680
@membphis The `lua_package_path` of `stream` has already updated.
This is an automated message from the Apache
juzhiyuan commented on issue #1387:
URL:
https://github.com/apache/apisix-dashboard/issues/1387#issuecomment-769565649
fine, we may add this to the allowlist in FE first..
This is an automated message from the Apache Git
Yiyiyimu commented on a change in pull request #3404:
URL: https://github.com/apache/apisix/pull/3404#discussion_r566569721
##
File path: t/chaos/kill-etcd_test.go
##
@@ -0,0 +1,240 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor
Firstsawyou opened a new issue #3453:
URL: https://github.com/apache/apisix/issues/3453
### Issue description
limit-count:
When the `count` or `time_window` fields of the limit-count plugin are 0,
the plugin is not available.
Repair method:
It should be greater than
Yiyiyimu commented on a change in pull request #3404:
URL: https://github.com/apache/apisix/pull/3404#discussion_r566568269
##
File path: t/chaos/go.sum
##
@@ -0,0 +1,97 @@
+github.com/ajg/form v1.5.1 h1:t9c7v8JUKu/XxOGBU0yjNpaMloxGEJhUkqFRq0ibGeU=
Review comment:
imjoey commented on issue #1387:
URL:
https://github.com/apache/apisix-dashboard/issues/1387#issuecomment-769562041
> If it does not belong to `Auth`, users have to enable one auth plugin like
`key-auth`, strange IMO.
>
>
>
> The first thing that needs to confirm, whether
fukiki commented on a change in pull request #3335:
URL: https://github.com/apache/apisix/pull/3335#discussion_r566565097
##
File path: apisix/cli/ngx_tpl.lua
##
@@ -120,9 +120,12 @@ http {
# put extra_lua_path in front of the builtin path
# so user can override the
sandy420 opened a new issue #3452:
URL: https://github.com/apache/apisix/issues/3452
query through the interface (/apimix/admin/routes or /apimix/admin/upstreams
or /apimix/admin/services)
e.g. :
# etcdctl get --prefix "/apisix/upstreams/"
/apisix/upstreams/100
juzhiyuan edited a comment on issue #1387:
URL:
https://github.com/apache/apisix-dashboard/issues/1387#issuecomment-769554039
If it does not belong to `Auth`, users have to enable one auth plugin like
`key-auth`, strange IMO.
The first thing that needs to confirm, whether users
juzhiyuan commented on issue #1387:
URL:
https://github.com/apache/apisix-dashboard/issues/1387#issuecomment-769554039
If it does not belong to `Auth`, users have to enable one auth plugin like
`key-auth`, strange IMO.
The first thing that needs to confirm, whether users should use
spacewander commented on a change in pull request #3415:
URL: https://github.com/apache/apisix/pull/3415#discussion_r566559922
##
File path: doc/install-dependencies.md
##
@@ -53,7 +53,7 @@ sudo yum install yum-utils
sudo yum-config-manager --add-repo
juzhiyuan commented on issue #1387:
URL:
https://github.com/apache/apisix-dashboard/issues/1387#issuecomment-769552575
Here is the doc[1] for `openid-connect`.
[1]
https://github.com/apache/apisix/blob/master/doc/plugins/openid-connect.md
imjoey commented on issue #1332:
URL:
https://github.com/apache/apisix-dashboard/issues/1332#issuecomment-769552383
> I hope to help add more test cases.
@Jaycean thanks a lot.
This is an automated message from
membphis commented on issue #3434:
URL: https://github.com/apache/apisix/issues/3434#issuecomment-769552204
I have sent you the login information, then you can do this by yourself.
This is an automated message from the
imjoey commented on issue #1387:
URL:
https://github.com/apache/apisix-dashboard/issues/1387#issuecomment-769551787
@juzhiyuan This looks more like a critical bug. I was wondering that whether
only the openid-connect plugin is affected. If so, can we commit a PR in APISIX
and then sync
juzhiyuan commented on issue #1387:
URL:
https://github.com/apache/apisix-dashboard/issues/1387#issuecomment-769551826
This issue should be reconsidered, due to `openid-connect` will rely on
`OAuth Server`, then this plugin should not belong to `auth` type 樂
membphis commented on pull request #3335:
URL: https://github.com/apache/apisix/pull/3335#issuecomment-769551232
@fukiki I think we can merge this PR soon ^_^
This is an automated message from the Apache Git Service.
To
membphis commented on a change in pull request #3335:
URL: https://github.com/apache/apisix/pull/3335#discussion_r566556935
##
File path: apisix/cli/ngx_tpl.lua
##
@@ -120,9 +120,12 @@ http {
# put extra_lua_path in front of the builtin path
# so user can override
juzhiyuan commented on issue #1332:
URL:
https://github.com/apache/apisix-dashboard/issues/1332#issuecomment-769550831
@Jaycean Assign to you! Thanks a lot!
This is an automated message from the Apache Git Service.
To
idbeta edited a comment on pull request #3376:
URL: https://github.com/apache/apisix/pull/3376#issuecomment-769550393
Because the test environment provided by github action is random, I think
this test is not suitable for APISIX, could suitable for private repo by use
`self-hosted`
Yiyiyimu commented on issue #3449:
URL: https://github.com/apache/apisix/issues/3449#issuecomment-769550668
Hi @idbeta thx for explaination! Added to todo and I'll test it later. Is it
from certain issue so I could have some context to reproduce
idbeta edited a comment on pull request #3376:
URL: https://github.com/apache/apisix/pull/3376#issuecomment-769550393
Because the test environment provided by github action is random, I think
this test is not suitable for APISIX, could suitable for private repo
idbeta closed pull request #3376:
URL: https://github.com/apache/apisix/pull/3376
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
idbeta commented on pull request #3376:
URL: https://github.com/apache/apisix/pull/3376#issuecomment-769550393
I think this test is not suitable for APISIX, could suitable for private repo
This is an automated message from
hnlq715 commented on issue #1391:
URL:
https://github.com/apache/apisix-dashboard/issues/1391#issuecomment-769550255
@starsz @imjoey Get it
This is an automated message from the Apache Git Service.
To respond to the
membphis commented on pull request #3335:
URL: https://github.com/apache/apisix/pull/3335#issuecomment-769549206
> @membphis I've already done, could you review my pr please? Than you.
let me take a look. many thx for your nice job
Jaycean commented on issue #1332:
URL:
https://github.com/apache/apisix-dashboard/issues/1332#issuecomment-769548154
I hope to help add more test cases.
This is an automated message from the Apache Git Service.
To respond
idbeta commented on issue #3449:
URL: https://github.com/apache/apisix/issues/3449#issuecomment-769547865
> Hi @idbeta Thanks for the suggestions! The second one is great, but I
failed to get what we could benefit from the first idea. Could you explain a
little more
the current
fukiki commented on pull request #3335:
URL: https://github.com/apache/apisix/pull/3335#issuecomment-769547830
> > About the bug of `openresty-debug`, there are two suggestions:
> >
> > 1. Add conditions: when OpenResty version is not 1.19 , allow to use Lua
5.1
> > 2. Modify
fukiki removed a comment on pull request #3335:
URL: https://github.com/apache/apisix/pull/3335#issuecomment-768812660
@membphis @spacewander @tokers
About run APISIX CLI, Luajit of OpenResty 1.19 is absolutely recommended.
But In other cases, such as the bug of `opentesty-bug`,
membphis commented on pull request #2101:
URL: https://github.com/apache/apisix/pull/2101#issuecomment-769547213
@Yiyiyimu merged, many thx
This is an automated message from the Apache Git Service.
To respond to the message,
membphis closed issue #2034:
URL: https://github.com/apache/apisix/issues/2034
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
membphis merged pull request #2101:
URL: https://github.com/apache/apisix/pull/2101
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
spacewander opened a new pull request #3451:
URL: https://github.com/apache/apisix/pull/3451
Fix #3238
Signed-off-by: spacewander
### What this PR does / why we need it:
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve?
This is an automated email from the ASF dual-hosted git repository.
membphis pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git.
from 75c6923 test: sort the output data of the plugin_proxy_rewrite_args
method (#3448)
add 6415b29 feat:
juzhiyuan commented on a change in pull request #1385:
URL: https://github.com/apache/apisix-dashboard/pull/1385#discussion_r566553538
##
File path: web/src/pages/Route/locales/zh-CN.ts
##
@@ -26,6 +26,7 @@ export default {
'page.route.greaterThan': '大于',
juzhiyuan merged pull request #1381:
URL: https://github.com/apache/apisix-dashboard/pull/1381
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
juzhiyuan closed issue #1380:
URL: https://github.com/apache/apisix-dashboard/issues/1380
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new 619165a docs: improve E2E test
hnlq715 commented on a change in pull request #3300:
URL: https://github.com/apache/apisix/pull/3300#discussion_r566543075
##
File path: apisix/balancer/ewma.lua
##
@@ -35,73 +58,69 @@ local function decay_ewma(ewma, last_touched_at, rtt, now)
return ewma
end
-
local
Yiyiyimu commented on issue #3449:
URL: https://github.com/apache/apisix/issues/3449#issuecomment-769544390
Hi @idbeta Thanks for the suggestions! The second one is great, but I failed
to get what we could benefit from the first idea. Could you explain a little
more
juzhiyuan commented on pull request #1376:
URL: https://github.com/apache/apisix-dashboard/pull/1376#issuecomment-769544322
> @guoqqqi Thank you very much for the work. While could you please provide
more details about why to do this and what this PR will do? An elaborated
description
hnlq715 commented on a change in pull request #3300:
URL: https://github.com/apache/apisix/pull/3300#discussion_r566543075
##
File path: apisix/balancer/ewma.lua
##
@@ -35,73 +58,69 @@ local function decay_ewma(ewma, last_touched_at, rtt, now)
return ewma
end
-
local
spacewander commented on issue #2119:
URL: https://github.com/apache/apisix/issues/2119#issuecomment-769544191
Now we can use:
```lua
matched_uri = ctx.curr_req_matched._path or ""
matched_host = ctx.curr_req_matched._host or ""
```
instead.
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new a3a135d feat: update the menu
juzhiyuan merged pull request #1376:
URL: https://github.com/apache/apisix-dashboard/pull/1376
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
imjoey commented on pull request #1376:
URL: https://github.com/apache/apisix-dashboard/pull/1376#issuecomment-769542796
@guoqqqi Thank you very much for the work. While could you please provide
more details about why to do this and what this PR will do? An elaborated
description would
idbeta edited a comment on issue #3449:
URL: https://github.com/apache/apisix/issues/3449#issuecomment-769542347
two ideas
1. kill one or two pods of etcd cluster , then check CRUD for routes, and
then start the etcd pods again，check CRUD for routes again.
2. when the network
idbeta commented on issue #3449:
URL: https://github.com/apache/apisix/issues/3449#issuecomment-769542347
two ideas
1. kill one or two pods of etcd cluster , then check CRUD for routes, and
then start etcd again，check CRUD for routes again.
2. when the network connected to etcd
imjoey commented on issue #1391:
URL:
https://github.com/apache/apisix-dashboard/issues/1391#issuecomment-769540728
@hnlq715 this is great and I love this feature. Thanks and looking forward
to your contributions.
This
hnlq715 commented on a change in pull request #3300:
URL: https://github.com/apache/apisix/pull/3300#discussion_r566017006
##
File path: t/node/ewma.t
##
@@ -215,3 +215,79 @@ GET /t
--- error_code: 200
--- no_error_log
[error]
+
+
+
+=== TEST 4: about filter tried servers
spacewander commented on pull request #3442:
URL: https://github.com/apache/apisix/pull/3442#issuecomment-769539012
We are planning to release 2.3, so this PR will be merged later. There will
be more DNS relative new features in the coming 2.4 version.
CC @gy09535
hnlq715 commented on a change in pull request #3300:
URL: https://github.com/apache/apisix/pull/3300#discussion_r566543075
##
File path: apisix/balancer/ewma.lua
##
@@ -35,73 +58,69 @@ local function decay_ewma(ewma, last_touched_at, rtt, now)
return ewma
end
-
local
imjoey commented on a change in pull request #1381:
URL: https://github.com/apache/apisix-dashboard/pull/1381#discussion_r566545680
##
File path: docs/back-end-e2e.md
##
@@ -0,0 +1,106 @@
+
+
+This document describes how to use E2E test locally.
+
+## Start with source code
+
hnlq715 commented on a change in pull request #3300:
URL: https://github.com/apache/apisix/pull/3300#discussion_r566543075
##
File path: apisix/balancer/ewma.lua
##
@@ -35,73 +58,69 @@ local function decay_ewma(ewma, last_touched_at, rtt, now)
return ewma
end
-
local
tokers commented on a change in pull request #3415:
URL: https://github.com/apache/apisix/pull/3415#discussion_r566543085
##
File path: doc/install-dependencies.md
##
@@ -55,6 +55,15 @@ sudo yum-config-manager --add-repo
https://openresty.org/package/centos/openrest
#
hnlq715 commented on a change in pull request #3300:
URL: https://github.com/apache/apisix/pull/3300#discussion_r566542656
##
File path: apisix/balancer/ewma.lua
##
@@ -119,38 +137,75 @@ local function _trans_format(up_nodes)
return next(peers) and peers or nil
end
-
spacewander commented on a change in pull request #3429:
URL: https://github.com/apache/apisix/pull/3429#discussion_r566539621
##
File path: apisix/plugins/kafka-logger.lua
##
@@ -66,33 +70,28 @@ function _M.check_schema(conf)
end
-local function send_kafka_data(conf,
starsz commented on issue #1391:
URL:
https://github.com/apache/apisix-dashboard/issues/1391#issuecomment-769532643
That's sounds so great. PRs are welcomed.
This is an automated message from the Apache Git Service.
To
Yiyiyimu commented on pull request #3404:
URL: https://github.com/apache/apisix/pull/3404#issuecomment-769532063
> @Yiyiyimu It seems in this case you kill all etcd members. What about just
killing the leader (will recover overtime), killing the follower (no issue),
kill majority members
membphis commented on a change in pull request #3404:
URL: https://github.com/apache/apisix/pull/3404#discussion_r565366473
##
File path: t/chaos/go.sum
##
@@ -0,0 +1,97 @@
+github.com/ajg/form v1.5.1 h1:t9c7v8JUKu/XxOGBU0yjNpaMloxGEJhUkqFRq0ibGeU=
Review comment:
need
hnlq715 commented on a change in pull request #3300:
URL: https://github.com/apache/apisix/pull/3300#discussion_r566533815
##
File path: apisix/balancer/ewma.lua
##
@@ -35,73 +57,69 @@ local function decay_ewma(ewma, last_touched_at, rtt, now)
return ewma
end
-
local
spacewander commented on issue #3450:
URL: https://github.com/apache/apisix/issues/3450#issuecomment-769526238
This is a known issue:
https://github.com/apache/apisix/issues/3370
We have discussed this internally before, and already put it on the roadmap.
LiteSun edited a comment on pull request #1381:
URL: https://github.com/apache/apisix-dashboard/pull/1381#issuecomment-769525482
> @juzhiyuan @LiteSun Please take a look at the FE test.
ok.
ping @guoqqqi
spacewander commented on issue #3437:
URL: https://github.com/apache/apisix/issues/3437#issuecomment-769525662
Consider solved
This is an automated message from the Apache Git Service.
To respond to the message, please log
spacewander closed issue #3437:
URL: https://github.com/apache/apisix/issues/3437
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
LiteSun commented on pull request #1381:
URL: https://github.com/apache/apisix-dashboard/pull/1381#issuecomment-769525482
> @juzhiyuan @LiteSun Please take a look at the FE test.
ok
This is an automated message from
tokers commented on issue #3445:
URL: https://github.com/apache/apisix/issues/3445#issuecomment-769524669
@123libohan What's the quota you mentioned above? Is the limited QPS?
This is an automated message from the Apache Git
Yiyiyimu commented on issue #3449:
URL: https://github.com/apache/apisix/issues/3449#issuecomment-769524385
> @Yiyiyimu Have you tried to make the network partition for the etcd
cluster? To see the behavior of APISIX.
Thanks for the suggestion!! Added to todo and I'll try it later
spacewander commented on a change in pull request #3300:
URL: https://github.com/apache/apisix/pull/3300#discussion_r566531369
##
File path: apisix/balancer/ewma.lua
##
@@ -119,38 +137,75 @@ local function _trans_format(up_nodes)
return next(peers) and peers or nil
end
tokers commented on a change in pull request #2101:
URL: https://github.com/apache/apisix/pull/2101#discussion_r566531425
##
File path: apisix/cli/etcd.lua
##
@@ -246,9 +246,6 @@ function _M.init(env, show_output)
break
end
-if
starsz commented on pull request #1381:
URL: https://github.com/apache/apisix-dashboard/pull/1381#issuecomment-769523392
@juzhiyuan @LiteSun Please take a look at the FE test.
This is an automated message from the Apache Git
tokers commented on pull request #3404:
URL: https://github.com/apache/apisix/pull/3404#issuecomment-769523230
@Yiyiyimu It seems in this case you kill all etcd members. What about just
killing the leader (will recover overtime), killing the follower (no issue),
kill majority members
yongboy commented on pull request #3372:
URL: https://github.com/apache/apisix/pull/3372#issuecomment-769523029
Maybe I did something wrong on the github workflow, and maybe I did not copy
your meaning :((
This is an
starsz commented on a change in pull request #1381:
URL: https://github.com/apache/apisix-dashboard/pull/1381#discussion_r566530836
##
File path: docs/back-end-e2e.md
##
@@ -0,0 +1,106 @@
+
+
+This document describes how to use E2E test locally.
+
+## Start with source code
+
tokers commented on a change in pull request #3404:
URL: https://github.com/apache/apisix/pull/3404#discussion_r566529868
##
File path: t/chaos/kill-etcd_test.go
##
@@ -0,0 +1,240 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor
tokers commented on issue #3449:
URL: https://github.com/apache/apisix/issues/3449#issuecomment-769519310
@Yiyiyimu Have you tried to make the network partition for the etcd cluster?
To see the behavior of APISIX.
This is
hnlq715 commented on issue #1391:
URL:
https://github.com/apache/apisix-dashboard/issues/1391#issuecomment-769517739
And the origin html files have 15M
```
➜ apisix-dashboard git:(master) ✗ du -sh output/html
15M output/html
```
hnlq715 edited a comment on issue #1391:
URL:
https://github.com/apache/apisix-dashboard/issues/1391#issuecomment-769516504
I did a simple test with go-bindata, the api binary size increases about 4MB
I think this should be acceptable :-)
Before
```
-rwxr-xr-x 1 root
1 - 100 of 200 matches
Mail list logo
