[GitHub] [apisix] membphis commented on issue #3550: change to a different port for controling API

2021-02-13 Thread GitBox
membphis commented on issue #3550: URL: https://github.com/apache/apisix/issues/3550#issuecomment-778737207 @starsz please know this This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [apisix] membphis closed issue #3550: change to a different port for controling API

2021-02-13 Thread GitBox
membphis closed issue #3550: URL: https://github.com/apache/apisix/issues/3550 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [apisix] membphis commented on pull request #3591: docs: typo, `customs plugin` -> `custom plugin`.

2021-02-13 Thread GitBox
membphis commented on pull request #3591: URL: https://github.com/apache/apisix/pull/3591#issuecomment-778718714 ![image](https://user-images.githubusercontent.com/6814606/107867932-686edb00-6eba-11eb-999d-754e0e1b7f66.png) -

[GitHub] [apisix] juzhiyuan merged pull request #3589: docs: fix spelling 'filer' should be 'filter'

2021-02-13 Thread GitBox
juzhiyuan merged pull request #3589: URL: https://github.com/apache/apisix/pull/3589 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] juzhiyuan closed issue #3588: typo: update filer to filter

2021-02-13 Thread GitBox
juzhiyuan closed issue #3588: URL: https://github.com/apache/apisix/issues/3588 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[apisix] branch master updated: docs: fix spelling 'filer' should be 'filter' (#3589)

2021-02-13 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 78e544b docs: fix spelling 'filer' should be

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1473: docs: update architecture diagram.

2021-02-13 Thread GitBox
juzhiyuan commented on pull request #1473: URL: https://github.com/apache/apisix-dashboard/pull/1473#issuecomment-778717048 cc @nic-chen @starsz to check the Backend E2E. This is an automated message from the Apache Git Serv

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1473: docs: update architecture diagram.

2021-02-13 Thread GitBox
codecov-io edited a comment on pull request #1473: URL: https://github.com/apache/apisix-dashboard/pull/1473#issuecomment-778714632 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1473?src=pr&el=h1) Report > Merging [#1473](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1473: docs: update architecture diagram.

2021-02-13 Thread GitBox
codecov-io commented on pull request #1473: URL: https://github.com/apache/apisix-dashboard/pull/1473#issuecomment-778714632 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1473?src=pr&el=h1) Report > Merging [#1473](https://codecov.io/gh/apache/apisix-dashboard/pull/147

[GitHub] [apisix-dashboard] membphis commented on pull request #1473: docs: update architecture diagram.

2021-02-13 Thread GitBox
membphis commented on pull request #1473: URL: https://github.com/apache/apisix-dashboard/pull/1473#issuecomment-778714530 ![image](https://user-images.githubusercontent.com/6814606/107867245-43776980-6eb4-11eb-9702-de098060238f.png) ---

[GitHub] [apisix-dashboard] membphis opened a new pull request #1473: docs: update architecture diagram.

2021-02-13 Thread GitBox
membphis opened a new pull request #1473: URL: https://github.com/apache/apisix-dashboard/pull/1473 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backpo

[apisix-dashboard] branch docs-main-image created (now f26643a)

2021-02-13 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a change to branch docs-main-image in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. at f26643a docs: update architecture diagram. This branch includes the following new commits:

[apisix-dashboard] 01/01: docs: update architecture diagram.

2021-02-13 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch docs-main-image in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git commit f26643a46f21b6e9e7db9c212800849c91daba14 Author: Yuansheng AuthorDate: Sun Feb 14 11:01:58 2021 +08

[GitHub] [apisix] membphis opened a new pull request #3591: docs: typo, `customs plugin` -> `custom plugin`.

2021-02-13 Thread GitBox
membphis opened a new pull request #3591: URL: https://github.com/apache/apisix/pull/3591 ### What this PR does / why we need it: ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have yo

[GitHub] [apisix] membphis commented on pull request #3577: feat: support conditional response rewrite

2021-02-13 Thread GitBox
membphis commented on pull request #3577: URL: https://github.com/apache/apisix/pull/3577#issuecomment-778711546 This PR only changes the response HTTP status, and we still cannot use `proxy_next_upstream`. This is an autom

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1470: Backend E2E failed

2021-02-13 Thread GitBox
juzhiyuan commented on issue #1470: URL: https://github.com/apache/apisix-dashboard/issues/1470#issuecomment-778695186 I see a bundle of PRs is failed due to backend E2E, please take a look when you are free. ![image](https://user-images.githubusercontent.com/2106987/107864671-968f

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1472: feat: Press Enter key can trigger the Login button

2021-02-13 Thread GitBox
juzhiyuan commented on a change in pull request #1472: URL: https://github.com/apache/apisix-dashboard/pull/1472#discussion_r575729095 ## File path: web/src/pages/User/Login.tsx ## @@ -73,6 +73,12 @@ const Page: React.FC = () => { }); }; + const onKeyDown = (e: any)

[GitHub] [apisix-dashboard] guoqqqi opened a new pull request #1472: feat: Press Enter key can trigger the Login button

2021-02-13 Thread GitBox
guoqqqi opened a new pull request #1472: URL: https://github.com/apache/apisix-dashboard/pull/1472 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - [ ] Backpor

[GitHub] [apisix-website] juzhiyuan commented on a change in pull request #187: feat: add Dependabot config file and configure updates to Actions eve…

2021-02-13 Thread GitBox
juzhiyuan commented on a change in pull request #187: URL: https://github.com/apache/apisix-website/pull/187#discussion_r575652562 ## File path: .github/dependabot.yml ## @@ -0,0 +1,10 @@ +# Set update schedule for GitHub Actions + +version: 2 +updates: + + - package-ecosystem

[GitHub] [apisix-website] jbampton opened a new pull request #187: feat: add Dependabot config file and configure updates to Actions eve…

2021-02-13 Thread GitBox
jbampton opened a new pull request #187: URL: https://github.com/apache/apisix-website/pull/187 …ryday Fix missing HTTPS on link. This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [apisix-docker] sober-wang commented on pull request #128: feat: we can use kubectl logs and docker logs review apisix container's logs.

2021-02-13 Thread GitBox
sober-wang commented on pull request #128: URL: https://github.com/apache/apisix-docker/pull/128#issuecomment-778589910 I know your mean's. But can you help me ,how to create a test cases in CI. This is an automated message

[GitHub] [apisix-website] qier222 commented on pull request #186: fix: remove global shadow on mobile

2021-02-13 Thread GitBox
qier222 commented on pull request #186: URL: https://github.com/apache/apisix-website/pull/186#issuecomment-778588034 well done👍 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [apisix] jbampton opened a new pull request #3590: refactor: combine the Lint and Markdown link checker GitHub Actions i…

2021-02-13 Thread GitBox
jbampton opened a new pull request #3590: URL: https://github.com/apache/apisix/pull/3590 …nto one file ### What this PR does / why we need it: Easier to maintain, less files to maintain ### Pre-submission checklist: * [X] Did you explain what problem does this PR

[GitHub] [apisix] juzhiyuan commented on pull request #3589: docs: fix spelling 'filer' should be 'filter'

2021-02-13 Thread GitBox
juzhiyuan commented on pull request #3589: URL: https://github.com/apache/apisix/pull/3589#issuecomment-778582601 big thanks to @jbampton This is an automated message from the Apache Git Service. To respond to the message, p

[apisix-website] branch asf-site updated: deploy: 20c77d78b8323f2e09e98e47c252ded2ee7b3806

2021-02-13 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/asf-site by this push: new eeafd64 deploy: 20c77d78b8323f2

[GitHub] [apisix-website] juzhiyuan merged pull request #186: fix: remove global shadow on mobile

2021-02-13 Thread GitBox
juzhiyuan merged pull request #186: URL: https://github.com/apache/apisix-website/pull/186 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[apisix-website] branch master updated: fix: remove global shadow on mobile (#186)

2021-02-13 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/master by this push: new 20c77d7 fix: remove global shadow on

[GitHub] [apisix-website] juzhiyuan closed issue #185: bug: incorrect shadow on mobile device

2021-02-13 Thread GitBox
juzhiyuan closed issue #185: URL: https://github.com/apache/apisix-website/issues/185 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [apisix-website] juzhiyuan commented on pull request #186: fix: remove global shadow on mobile

2021-02-13 Thread GitBox
juzhiyuan commented on pull request #186: URL: https://github.com/apache/apisix-website/pull/186#issuecomment-778580422 cc @qier222, this issue is fixed by @bzp2010 This is an automated message from the Apache Git Service. T