[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1502: feat: rewrite e2e test(upstream_test) with ginkgo

2021-02-24 Thread GitBox
nic-chen commented on a change in pull request #1502: URL: https://github.com/apache/apisix-dashboard/pull/1502#discussion_r582612763 ## File path: api/test/e2enew/upstream/upstream_test.go ## @@ -0,0 +1,606 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [apisix-dashboard] nic-chen commented on issue #1512: Plugin template configuration

2021-02-24 Thread GitBox
nic-chen commented on issue #1512: URL: https://github.com/apache/apisix-dashboard/issues/1512#issuecomment-785693420 > May need to update Create and update routing interface, need @nic-chen to confirm need to update entity and schema for route. ---

[GitHub] [apisix-dashboard] nic-chen opened a new pull request #1513: feat: support configure enabled plugin list

2021-02-24 Thread GitBox
nic-chen opened a new pull request #1513: URL: https://github.com/apache/apisix-dashboard/pull/1513 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - [ ] Backpo

[apisix-ingress-controller] branch master updated: docs: added meta info (#269)

2021-02-24 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git The following commit(s) were added to refs/heads/master by this push: new c30636c docs: added meta

[GitHub] [apisix-ingress-controller] juzhiyuan merged pull request #269: docs: added meta info

2021-02-24 Thread GitBox
juzhiyuan merged pull request #269: URL: https://github.com/apache/apisix-ingress-controller/pull/269 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[apisix-website] branch feat-sync-docs updated (200daa9 -> a1b7b70)

2021-02-24 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch feat-sync-docs in repository https://gitbox.apache.org/repos/asf/apisix-website.git. from 200daa9 chore: remove unused files add a1b7b70 docs: added ignore docs No new revisions we

[apisix-ingress-controller] branch docs-added-meta updated (4442d5d -> dc26f53)

2021-02-24 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch docs-added-meta in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git. from 4442d5d docs: added meta info add dc26f53 CI: ignore MD041 No new revisions we

[GitHub] [apisix] cverdela opened a new issue #3670: request help:

2021-02-24 Thread GitBox
cverdela opened a new issue #3670: URL: https://github.com/apache/apisix/issues/3670 ### Issue description wolf-rbac is an authentication and authorization (rbac) plugin I used it for rbac,but QPS down to 300/s how to do for rbac without losing performance ### Environment * a

[GitHub] [apisix-ingress-controller] juzhiyuan opened a new pull request #269: docs: added meta info

2021-02-24 Thread GitBox
juzhiyuan opened a new pull request #269: URL: https://github.com/apache/apisix-ingress-controller/pull/269 - [x] added meta info for website This is an automated message from the Apache Git Service. To respond to the message

[apisix-ingress-controller] 01/01: docs: added meta info

2021-02-24 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch docs-added-meta in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git commit 4442d5d3af01163b2b95f00c01b1293e19ec6696 Author: juzhiyuan AuthorDate: Thu Feb 25 15:22:3

[apisix-ingress-controller] branch docs-added-meta created (now 4442d5d)

2021-02-24 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch docs-added-meta in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git. at 4442d5d docs: added meta info This branch includes the following new commits:

[GitHub] [apisix-dashboard] LiteSun commented on issue #1512: Plugin template configuration

2021-02-24 Thread GitBox
LiteSun commented on issue #1512: URL: https://github.com/apache/apisix-dashboard/issues/1512#issuecomment-785677739 > will pugin support `tag`? > In this way, the management and grouping of plug-ins can be completed, which is more flexible Good catch! Does apisix plugin con

[GitHub] [apisix] starsz closed issue #3669: feat: support environment variable to override the config

2021-02-24 Thread GitBox
starsz closed issue #3669: URL: https://github.com/apache/apisix/issues/3669 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [apisix] starsz commented on issue #3669: feat: support environment variable to override the config

2021-02-24 Thread GitBox
starsz commented on issue #3669: URL: https://github.com/apache/apisix/issues/3669#issuecomment-785676107 Now the conf.yaml support the environment variable. https://github.com/apache/apisix/blob/de9ea132845202bd79624ddb780096882d50288c/conf/config.yaml#L24 So I think I can cl

[apisix-website] branch feat-sync-docs updated (20f8e6e -> 200daa9)

2021-02-24 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch feat-sync-docs in repository https://gitbox.apache.org/repos/asf/apisix-website.git. from 20f8e6e docs: remove test add 200daa9 chore: remove unused files No new revisions were add

[apisix-website] branch feat-sync-docs updated (eda04d9 -> 20f8e6e)

2021-02-24 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch feat-sync-docs in repository https://gitbox.apache.org/repos/asf/apisix-website.git. from eda04d9 fix: sync docs js add 20f8e6e docs: remove test No new revisions were added by thi

[GitHub] [apisix-dashboard] moonming commented on issue #1512: Plugin template configuration

2021-02-24 Thread GitBox
moonming commented on issue #1512: URL: https://github.com/apache/apisix-dashboard/issues/1512#issuecomment-785662803 will pugin support `tag`? In this way, the management and grouping of plug-ins can be completed, which is more flexible --

[apisix-website] branch feat-sync-docs updated (55c0edb -> eda04d9)

2021-02-24 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch feat-sync-docs in repository https://gitbox.apache.org/repos/asf/apisix-website.git. from 55c0edb fix: use node env add eda04d9 fix: sync docs js No new revisions were added by thi

[GitHub] [apisix] starsz opened a new issue #3669: feat: support environment variable to override the config

2021-02-24 Thread GitBox
starsz opened a new issue #3669: URL: https://github.com/apache/apisix/issues/3669 # Feature request ## Please describe your feature We can support the environment variable to override the config. In some situations use the environment variable would be more convenient than

[GitHub] [apisix-dashboard] LiteSun opened a new issue #1512: Plugin template configuration

2021-02-24 Thread GitBox
LiteSun opened a new issue #1512: URL: https://github.com/apache/apisix-dashboard/issues/1512 ## Background and purpose To allow users to configure plugin templates in advance and bind the corresponding plugin templates when creating routes to achieve the fast configuration of routi

[apisix-website] branch feat-sync-docs updated (fa3f2fb -> 55c0edb)

2021-02-24 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch feat-sync-docs in repository https://gitbox.apache.org/repos/asf/apisix-website.git. from fa3f2fb fix: use node env add 55c0edb fix: use node env No new revisions were added by thi

[apisix-dashboard] branch chore-docs updated (8459bbc -> 3c76460)

2021-02-24 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch chore-docs in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 8459bbc docs: added meta add 3c76460 docs: added meta No new revisions were added by this up

[apisix-dashboard] branch chore-docs updated (a78f2f8 -> 8459bbc)

2021-02-24 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch chore-docs in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from a78f2f8 fix: link add 8459bbc docs: added meta No new revisions were added by this update.

[GitHub] [apisix] tzssangglass commented on issue #3663: bug: script does not work

2021-02-24 Thread GitBox
tzssangglass commented on issue #3663: URL: https://github.com/apache/apisix/issues/3663#issuecomment-785645709 According to the script documentation, on the route, script and plugin are mutually exclusive, so if there is script on the route and plugins on the service, and the route is bou

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1465: feat(be): Online debug function adds support for transfer files

2021-02-24 Thread GitBox
nic-chen commented on a change in pull request #1465: URL: https://github.com/apache/apisix-dashboard/pull/1465#discussion_r582571180 ## File path: api/test/e2enew/route_online_debug/route_online_debug_test.go ## @@ -0,0 +1,785 @@ +/* + * Licensed to the Apache Software Foundat

[GitHub] [apisix-docker] Yiyiyimu commented on a change in pull request #137: feat: support build apisix image from local code

2021-02-24 Thread GitBox
Yiyiyimu commented on a change in pull request #137: URL: https://github.com/apache/apisix-docker/pull/137#discussion_r582560334 ## File path: .github/workflows/apisix-alpine-local-docker-test.yaml ## @@ -0,0 +1,43 @@ +name: APISIX Alpine local docker Test + +on: + push: +

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1511: chore: improve docs structure

2021-02-24 Thread GitBox
codecov-io edited a comment on pull request #1511: URL: https://github.com/apache/apisix-dashboard/pull/1511#issuecomment-785640792 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1511?src=pr&el=h1) Report > Merging [#1511](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] nic-chen commented on issue #1039: Build plugin form according to its jsonschema

2021-02-24 Thread GitBox
nic-chen commented on issue #1039: URL: https://github.com/apache/apisix-dashboard/issues/1039#issuecomment-785644028 > Thanks @nic-chen, and your concern is really a problem indeed. > We originally envisioned automatically generating templates through schema, and we got a scheme to gen

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1511: chore: improve docs structure

2021-02-24 Thread GitBox
codecov-io edited a comment on pull request #1511: URL: https://github.com/apache/apisix-dashboard/pull/1511#issuecomment-785640792 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1511?src=pr&el=h1) Report > Merging [#1511](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1511: chore: improve docs structure

2021-02-24 Thread GitBox
codecov-io edited a comment on pull request #1511: URL: https://github.com/apache/apisix-dashboard/pull/1511#issuecomment-785640792 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1511?src=pr&el=h1) Report > Merging [#1511](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1511: chore: improve docs structure

2021-02-24 Thread GitBox
codecov-io commented on pull request #1511: URL: https://github.com/apache/apisix-dashboard/pull/1511#issuecomment-785640792 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1511?src=pr&el=h1) Report > Merging [#1511](https://codecov.io/gh/apache/apisix-dashboard/pull/151

[apisix-dashboard] branch chore-docs updated (b445c7f -> a78f2f8)

2021-02-24 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch chore-docs in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from b445c7f chore: improve docs structure add a78f2f8 fix: link No new revisions were added by t

[GitHub] [apisix-dashboard] juzhiyuan opened a new pull request #1511: chore: improve docs structure

2021-02-24 Thread GitBox
juzhiyuan opened a new pull request #1511: URL: https://github.com/apache/apisix-dashboard/pull/1511 refactor docs structure This is an automated message from the Apache Git Service. To respond to the message, please log on t

[apisix-dashboard] 01/01: chore: improve docs structure

2021-02-24 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch chore-docs in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git commit b445c7f7345f42f5934da933c33b6774ccc70971 Author: juzhiyuan AuthorDate: Thu Feb 25 14:06:35 2021 +0800

[apisix-dashboard] branch chore-docs created (now b445c7f)

2021-02-24 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch chore-docs in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. at b445c7f chore: improve docs structure This branch includes the following new commits: new b4

[GitHub] [apisix-docker] Yiyiyimu commented on a change in pull request #137: feat: support build apisix image from local code

2021-02-24 Thread GitBox
Yiyiyimu commented on a change in pull request #137: URL: https://github.com/apache/apisix-docker/pull/137#discussion_r582560334 ## File path: .github/workflows/apisix-alpine-local-docker-test.yaml ## @@ -0,0 +1,43 @@ +name: APISIX Alpine local docker Test + +on: + push: +

[GitHub] [apisix-dashboard] LiteSun merged pull request #1505: feat: add rawDataEditor for route, consumer, upstream and service

2021-02-24 Thread GitBox
LiteSun merged pull request #1505: URL: https://github.com/apache/apisix-dashboard/pull/1505 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[apisix-dashboard] branch master updated (190c84d -> b6cb345)

2021-02-24 Thread sunyi
This is an automated email from the ASF dual-hosted git repository. sunyi pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 190c84d feat: rewrite e2e test(version_test) with ginkgo (#1501) add b6cb345 feat: add rawDataEditor

[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #1490: feat: support yaml to config plugin in plugin config page

2021-02-24 Thread GitBox
LiteSun commented on a change in pull request #1490: URL: https://github.com/apache/apisix-dashboard/pull/1490#discussion_r582563832 ## File path: web/src/helpers.tsx ## @@ -130,3 +132,20 @@ export const timestampToLocaleString = (timestamp: number) => { return moment.uni

[apisix-website] branch feat-sync-docs updated (fbae563 -> fa3f2fb)

2021-02-24 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch feat-sync-docs in repository https://gitbox.apache.org/repos/asf/apisix-website.git. from fbae563 fix: script running position add fa3f2fb fix: use node env No new revisions were a

[GitHub] [apisix-docker] Yiyiyimu commented on a change in pull request #137: feat: support build apisix image from local code

2021-02-24 Thread GitBox
Yiyiyimu commented on a change in pull request #137: URL: https://github.com/apache/apisix-docker/pull/137#discussion_r582560334 ## File path: .github/workflows/apisix-alpine-local-docker-test.yaml ## @@ -0,0 +1,43 @@ +name: APISIX Alpine local docker Test + +on: + push: +

[GitHub] [apisix-dashboard] liuxiran commented on issue #1039: Build plugin form according to its jsonschema

2021-02-24 Thread GitBox
liuxiran commented on issue #1039: URL: https://github.com/apache/apisix-dashboard/issues/1039#issuecomment-785629052 > @liuxiran > Thanks for the explanation. > Maintaining a separate template is troublesome, and after the plugin schema is updated in APISIX, it may be easier to miss

[GitHub] [apisix-docker] Yiyiyimu commented on a change in pull request #137: feat: support build apisix image from local code

2021-02-24 Thread GitBox
Yiyiyimu commented on a change in pull request #137: URL: https://github.com/apache/apisix-docker/pull/137#discussion_r582559814 ## File path: Makefile ## @@ -28,6 +28,10 @@ build-on-centos: build-on-alpine: docker build -t $(IMAGE_NAME):$(APISIX_VERSION)-alpine -f ./

[GitHub] [apisix-docker] Yiyiyimu commented on a change in pull request #137: feat: support build apisix image from local code

2021-02-24 Thread GitBox
Yiyiyimu commented on a change in pull request #137: URL: https://github.com/apache/apisix-docker/pull/137#discussion_r582559814 ## File path: Makefile ## @@ -28,6 +28,10 @@ build-on-centos: build-on-alpine: docker build -t $(IMAGE_NAME):$(APISIX_VERSION)-alpine -f ./

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1465: feat(be): Online debug function adds support for transfer files

2021-02-24 Thread GitBox
starsz commented on a change in pull request #1465: URL: https://github.com/apache/apisix-dashboard/pull/1465#discussion_r582559727 ## File path: api/test/e2enew/base/http.go ## @@ -92,3 +104,44 @@ func BatchTestServerPort(times int) map[string]int { return res } + +

[apisix-website] branch feat-sync-docs updated (4b88942 -> fbae563)

2021-02-24 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch feat-sync-docs in repository https://gitbox.apache.org/repos/asf/apisix-website.git. from 4b88942 temp: trigger CI add fbae563 fix: script running position No new revisions were ad

[apisix-website] branch feat-sync-docs updated (ffd94c7 -> 4b88942)

2021-02-24 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch feat-sync-docs in repository https://gitbox.apache.org/repos/asf/apisix-website.git. from ffd94c7 feat: sync docs & deploy add 4b88942 temp: trigger CI No new revisions were added

[GitHub] [apisix-website] juzhiyuan opened a new pull request #205: feat: sync docs & deploy

2021-02-24 Thread GitBox
juzhiyuan opened a new pull request #205: URL: https://github.com/apache/apisix-website/pull/205 sync docs first then deploy This is an automated message from the Apache Git Service. To respond to the message, please log on t

[apisix-website] branch feat-sync-docs created (now ffd94c7)

2021-02-24 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch feat-sync-docs in repository https://gitbox.apache.org/repos/asf/apisix-website.git. at ffd94c7 feat: sync docs & deploy This branch includes the following new commits: new ffd94

[apisix-website] 01/01: feat: sync docs & deploy

2021-02-24 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch feat-sync-docs in repository https://gitbox.apache.org/repos/asf/apisix-website.git commit ffd94c7fb95a99d4d8f3822890b953978056aef7 Author: juzhiyuan AuthorDate: Thu Feb 25 13:36:14 2021 +0800

[GitHub] [apisix] Firstsawyou opened a new pull request #3668: chore: remove the useless configuration in the ngx_tpl.lua file

2021-02-24 Thread GitBox
Firstsawyou opened a new pull request #3668: URL: https://github.com/apache/apisix/pull/3668 ### What this PR does / why we need it: close #3662 Since APISIX and APISIX Dashboard are currently deployed independently of each other, the old /apisix/dashboard API interfa

[GitHub] [apisix-website] juzhiyuan closed pull request #204: Update updateDocs.yaml

2021-02-24 Thread GitBox
juzhiyuan closed pull request #204: URL: https://github.com/apache/apisix-website/pull/204 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix-website] juzhiyuan opened a new pull request #204: Update updateDocs.yaml

2021-02-24 Thread GitBox
juzhiyuan opened a new pull request #204: URL: https://github.com/apache/apisix-website/pull/204 fix pull docs This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[apisix-website] branch juzhiyuan-patch-1 created (now 1624b5c)

2021-02-24 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch juzhiyuan-patch-1 in repository https://gitbox.apache.org/repos/asf/apisix-website.git. at 1624b5c Update updateDocs.yaml This branch includes the following new commits: new 1624

[apisix-website] 01/01: Update updateDocs.yaml

2021-02-24 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch juzhiyuan-patch-1 in repository https://gitbox.apache.org/repos/asf/apisix-website.git commit 1624b5cc71099323c1d74d9a8e7244c1e7294517 Author: 琚致远 AuthorDate: Thu Feb 25 13:28:27 2021 +0800

[GitHub] [apisix] idbeta commented on pull request #3667: test: add fuzzing case for the route with vars

2021-02-24 Thread GitBox
idbeta commented on pull request #3667: URL: https://github.com/apache/apisix/pull/3667#issuecomment-785621939 ping @spacewander can you check the CI fail? It seems that the case is unstable. This is an automated message fro

[apisix-website] branch master updated: fix: Sync Docs action issue and other issues (#203)

2021-02-24 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/master by this push: new 55b53c5 fix: Sync Docs action issue

[GitHub] [apisix-website] juzhiyuan merged pull request #203: fix: Sync Docs action issue and other issues

2021-02-24 Thread GitBox
juzhiyuan merged pull request #203: URL: https://github.com/apache/apisix-website/pull/203 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix-docker] tokers commented on a change in pull request #137: feat: support build apisix image from local code

2021-02-24 Thread GitBox
tokers commented on a change in pull request #137: URL: https://github.com/apache/apisix-docker/pull/137#discussion_r582552183 ## File path: .github/workflows/apisix-alpine-local-docker-test.yaml ## @@ -0,0 +1,43 @@ +name: APISIX Alpine local docker Test + +on: + push: +br

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1501: feat: rewrite e2e test(version_test) with ginkgo

2021-02-24 Thread GitBox
juzhiyuan merged pull request #1501: URL: https://github.com/apache/apisix-dashboard/pull/1501 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[apisix-dashboard] branch master updated: feat: rewrite e2e test(version_test) with ginkgo (#1501)

2021-02-24 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new 190c84d feat: rewrite e2e test(ver

[GitHub] [apisix] tokers commented on a change in pull request #3660: chore: update makefile install to install everything in conf

2021-02-24 Thread GitBox
tokers commented on a change in pull request #3660: URL: https://github.com/apache/apisix/pull/3660#discussion_r582551397 ## File path: Makefile ## @@ -143,9 +143,7 @@ install: default $(INSTALL) -d /usr/local/apisix/ $(INSTALL) -d /usr/local/apisix/logs/

[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #262: feat: ApisixRoute v2alpha1

2021-02-24 Thread GitBox
tokers commented on a change in pull request #262: URL: https://github.com/apache/apisix-ingress-controller/pull/262#discussion_r582551116 ## File path: pkg/ingress/controller/controller.go ## @@ -338,17 +340,6 @@ type Api6Controller struct { Stop

[GitHub] [apisix-ingress-controller] tokers merged pull request #258: chore: migrate chart to repo apisix-helm-charts

2021-02-24 Thread GitBox
tokers merged pull request #258: URL: https://github.com/apache/apisix-ingress-controller/pull/258 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[apisix-ingress-controller] branch master updated: chore: migrate chart to repo apisix-helm-charts (#258)

2021-02-24 Thread tokers
This is an automated email from the ASF dual-hosted git repository. tokers pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git The following commit(s) were added to refs/heads/master by this push: new 6d926db chore: migrate chart

[GitHub] [apisix-ingress-controller] tokers merged pull request #268: docs: move install.md location to top level directory

2021-02-24 Thread GitBox
tokers merged pull request #268: URL: https://github.com/apache/apisix-ingress-controller/pull/268 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix-ingress-controller] tokers closed issue #257: Change the location of install.md

2021-02-24 Thread GitBox
tokers closed issue #257: URL: https://github.com/apache/apisix-ingress-controller/issues/257 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[apisix-ingress-controller] branch master updated: docs: move install.md location to top level directory (#268)

2021-02-24 Thread tokers
This is an automated email from the ASF dual-hosted git repository. tokers pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git The following commit(s) were added to refs/heads/master by this push: new df5f894 docs: move install.m

[GitHub] [apisix-ingress-controller] tokers commented on pull request #268: docs: move install.md location to top level directory

2021-02-24 Thread GitBox
tokers commented on pull request #268: URL: https://github.com/apache/apisix-ingress-controller/pull/268#issuecomment-785617394 @stu01509 Thanks so much! This is an automated message from the Apache Git Service. To respond t

[GitHub] [apisix-helm-chart] tokers commented on issue #6: Discuss: Add APISIX-helm-chart to the Charts repo.

2021-02-24 Thread GitBox
tokers commented on issue #6: URL: https://github.com/apache/apisix-helm-chart/issues/6#issuecomment-785616456 @gxthrj Currently only apisix-ingress-controller doesn't be added, others were already added. This is an automate

[GitHub] [apisix] juzhiyuan commented on pull request #3661: docs: modify the docs directory

2021-02-24 Thread GitBox
juzhiyuan commented on pull request #3661: URL: https://github.com/apache/apisix/pull/3661#issuecomment-785616142 https://github.com/apache/apisix/pull/3661/checks?check_run_id=1975897061#step:14:733 cc @spacewander to take a look at this CI

[GitHub] [apisix] spacewander merged pull request #3666: test: make key-auth-upstream-domain-node stable

2021-02-24 Thread GitBox
spacewander merged pull request #3666: URL: https://github.com/apache/apisix/pull/3666 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[apisix] branch master updated: test: make key-auth-upstream-domain-node stable (#3666)

2021-02-24 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new de9ea13 test: make key-auth-upstream-domai

[apisix] branch master updated (e146893 -> 7bef1b1)

2021-02-24 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from e146893 docs: plugin-develop.md adds ctx and conf descriptions (#3650) add 7bef1b1 feat: don't log uninitial

[GitHub] [apisix] membphis merged pull request #3641: feat: don't log uninitialized access log variable when the HTTP reque…

2021-02-24 Thread GitBox
membphis merged pull request #3641: URL: https://github.com/apache/apisix/pull/3641 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix] membphis commented on pull request #3627: docs: add Slack to the communication channels

2021-02-24 Thread GitBox
membphis commented on pull request #3627: URL: https://github.com/apache/apisix/pull/3627#issuecomment-785611751 need to merge the master branch This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [apisix] membphis commented on pull request #3624: feat: add pre-commit framework

2021-02-24 Thread GitBox
membphis commented on pull request #3624: URL: https://github.com/apache/apisix/pull/3624#issuecomment-785611402 need to resolve the Conflicting files This is an automated message from the Apache Git Service. To respond to th

[GitHub] [apisix-dashboard] Jaycean commented on pull request #1501: feat: rewrite e2e test(version_test) with ginkgo

2021-02-24 Thread GitBox
Jaycean commented on pull request #1501: URL: https://github.com/apache/apisix-dashboard/pull/1501#issuecomment-785611294 @starsz @imjoey PTAL. Thks. This is an automated message from the Apache Git Service. To respond to th

[GitHub] [apisix] membphis commented on pull request #3622: docs: fix markdown links

2021-02-24 Thread GitBox
membphis commented on pull request #3622: URL: https://github.com/apache/apisix/pull/3622#issuecomment-785610985 need to merge the master branch This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [apisix-dashboard] Jaycean commented on a change in pull request #1502: feat: rewrite e2e test(upstream_test) with ginkgo

2021-02-24 Thread GitBox
Jaycean commented on a change in pull request #1502: URL: https://github.com/apache/apisix-dashboard/pull/1502#discussion_r582544537 ## File path: api/test/e2enew/upstream/upstream_test.go ## @@ -0,0 +1,591 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[GitHub] [apisix-helm-chart] gxthrj commented on issue #6: Discuss: Add APISIX-helm-chart to the Charts repo.

2021-02-24 Thread GitBox
gxthrj commented on issue #6: URL: https://github.com/apache/apisix-helm-chart/issues/6#issuecomment-785609090 @tokers Need to update the helm chart repo which we are using. This is an automated message from the Apache Git Se

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1502: feat: rewrite e2e test(upstream_test) with ginkgo

2021-02-24 Thread GitBox
nic-chen commented on a change in pull request #1502: URL: https://github.com/apache/apisix-dashboard/pull/1502#discussion_r582540633 ## File path: api/test/e2enew/upstream/upstream_test.go ## @@ -0,0 +1,591 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [apisix-docker] gxthrj commented on pull request #128: feat: we can use kubectl logs and docker logs review apisix container's logs.

2021-02-24 Thread GitBox
gxthrj commented on pull request #128: URL: https://github.com/apache/apisix-docker/pull/128#issuecomment-785606901 We can continue to review this pr, @sober-wang Need to modify the document format as @imjoey suggest. As #133 has been merged, we need to rebase master. ---

[GitHub] [apisix-helm-chart] gxthrj edited a comment on pull request #26: chore: fix the template of deployment.yaml and add hints for affinity setting in values.yaml

2021-02-24 Thread GitBox
gxthrj edited a comment on pull request #26: URL: https://github.com/apache/apisix-helm-chart/pull/26#issuecomment-785604960 Any updates ? @TkClark Please check the review comments in the README section. This is an automated

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1498: ci: add ci check for gofmt

2021-02-24 Thread GitBox
nic-chen commented on a change in pull request #1498: URL: https://github.com/apache/apisix-dashboard/pull/1498#discussion_r582539035 ## File path: .github/workflows/go-lint.yml ## @@ -10,9 +10,26 @@ on: jobs: golangci: runs-on: ubuntu-latest - steps: - use

[GitHub] [apisix-helm-chart] gxthrj commented on pull request #26: chore: fix the template of deployment.yaml and add hints for affinity setting in values.yaml

2021-02-24 Thread GitBox
gxthrj commented on pull request #26: URL: https://github.com/apache/apisix-helm-chart/pull/26#issuecomment-785604960 Any updates ? @TkClark This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1465: feat(be): Online debug function adds support for transfer files

2021-02-24 Thread GitBox
liuxiran commented on a change in pull request #1465: URL: https://github.com/apache/apisix-dashboard/pull/1465#discussion_r582538635 ## File path: api/test/e2enew/base/http.go ## @@ -92,3 +104,44 @@ func BatchTestServerPort(times int) map[string]int { return res } +

[GitHub] [apisix-docker] gxthrj commented on a change in pull request #137: feat: support build apisix image from local code

2021-02-24 Thread GitBox
gxthrj commented on a change in pull request #137: URL: https://github.com/apache/apisix-docker/pull/137#discussion_r582537401 ## File path: .github/workflows/apisix-alpine-local-docker-test.yaml ## @@ -0,0 +1,43 @@ +name: APISIX Alpine local docker Test + +on: + push: +br

[GitHub] [apisix-website] qier222 opened a new pull request #203: fix: CI issue and other issues

2021-02-24 Thread GitBox
qier222 opened a new pull request #203: URL: https://github.com/apache/apisix-website/pull/203 Fixes: #[Add issue number here] Changes: Screenshots of the change: This is an automated message

[GitHub] [apisix-dashboard] nic-chen commented on issue #1450: feat: support exposing schema of route, upstream, service and ssl through Manager API

2021-02-24 Thread GitBox
nic-chen commented on issue #1450: URL: https://github.com/apache/apisix-dashboard/issues/1450#issuecomment-785600752 @membphis updated. This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #262: feat: ApisixRoute v2alpha1

2021-02-24 Thread GitBox
gxthrj commented on a change in pull request #262: URL: https://github.com/apache/apisix-ingress-controller/pull/262#discussion_r582535841 ## File path: pkg/ingress/controller/controller.go ## @@ -338,17 +340,6 @@ type Api6Controller struct { Stop

[GitHub] [apisix-dashboard] Jaycean commented on a change in pull request #1502: feat: rewrite e2e test(upstream_test) with ginkgo

2021-02-24 Thread GitBox
Jaycean commented on a change in pull request #1502: URL: https://github.com/apache/apisix-dashboard/pull/1502#discussion_r582535566 ## File path: api/test/e2enew/upstream/upstream_test.go ## @@ -0,0 +1,591 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[GitHub] [apisix-ingress-controller] gxthrj commented on pull request #262: feat: ApisixRoute v2alpha1

2021-02-24 Thread GitBox
gxthrj commented on pull request #262: URL: https://github.com/apache/apisix-ingress-controller/pull/262#issuecomment-785590961 Conflicting files This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [apisix-dashboard] nic-chen commented on issue #1487: Support duplicate one existing Route

2021-02-24 Thread GitBox
nic-chen commented on issue #1487: URL: https://github.com/apache/apisix-dashboard/issues/1487#issuecomment-785586397 Is it possible to just copy the data on the page, and the user can modify it before submitting it? Instead of directly cloning the route data first. -

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1498: ci: add ci check for gofmt

2021-02-24 Thread GitBox
nic-chen commented on a change in pull request #1498: URL: https://github.com/apache/apisix-dashboard/pull/1498#discussion_r582533107 ## File path: .github/workflows/go-lint.yml ## @@ -10,9 +10,26 @@ on: jobs: golangci: runs-on: ubuntu-latest - steps: - use

[GitHub] [apisix-ingress-controller] gxthrj commented on issue #261: request help: ingress-ui

2021-02-24 Thread GitBox
gxthrj commented on issue #261: URL: https://github.com/apache/apisix-ingress-controller/issues/261#issuecomment-785577766 @zhangxiaohui123456 We mainly support declarative configuration in this version. What kind of interface do you want? Can you give me an example? ---

[GitHub] [apisix] idbeta opened a new pull request #3667: test: add fuzzing case for the route with vars

2021-02-24 Thread GitBox
idbeta opened a new pull request #3667: URL: https://github.com/apache/apisix/pull/3667 ### What this PR does / why we need it: relate #3340 fuzzing for the route with vars ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new fe

[GitHub] [apisix-ingress-controller] gxthrj commented on issue #259: request help: Getting route not found issue

2021-02-24 Thread GitBox
gxthrj commented on issue #259: URL: https://github.com/apache/apisix-ingress-controller/issues/259#issuecomment-785572839 @Bhanuji95 Has the problem of not finding the route been resolved? If so, we can close this issue.

[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #268: docs: move install.md location to top level directory

2021-02-24 Thread GitBox
codecov-io commented on pull request #268: URL: https://github.com/apache/apisix-ingress-controller/pull/268#issuecomment-785569862 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/268?src=pr&el=h1) Report > Merging [#268](https://codecov.io/gh/apache/apisix-ing

[GitHub] [apisix-website] qier222 edited a comment on pull request #202: feat: multiple features for docs

2021-02-24 Thread GitBox
qier222 edited a comment on pull request #202: URL: https://github.com/apache/apisix-website/pull/202#issuecomment-785559570 General English docs 👉 /website/docs/general APISIX English docs 👉 /website/docs/apisix APISIX English Dashboard docs 👉 /website/docs/apisix-dashboard APISIX

  1   2   3   >