qier222 edited a comment on pull request #202:
URL: https://github.com/apache/apisix-website/pull/202#issuecomment-785559570
General English docs ๐ /website/docs/general
APISIX English docs ๐ /website/docs/apisix
APISIX English Dashboard docs ๐ /website/docs/apisix-dashboard
APISIX
gxthrj closed issue #264:
URL: https://github.com/apache/apisix-ingress-controller/issues/264
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
gxthrj commented on issue #264:
URL:
https://github.com/apache/apisix-ingress-controller/issues/264#issuecomment-785561933
Close this issue now
This is an automated message from the Apache Git Service.
To respond to the mess
stu01509 opened a new pull request #268:
URL: https://github.com/apache/apisix-ingress-controller/pull/268
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bugfix
- [x] New feature provided
- [ ] Improve performance
- [ ]
gxthrj merged pull request #267:
URL: https://github.com/apache/apisix-ingress-controller/pull/267
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
This is an automated email from the ASF dual-hosted git repository.
kvn pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git
The following commit(s) were added to refs/heads/master by this push:
new d5ea70b chore: remove unless co
Firstsawyou commented on pull request #3666:
URL: https://github.com/apache/apisix/pull/3666#issuecomment-785559698
LGTM.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
Yiyiyimu commented on a change in pull request #3660:
URL: https://github.com/apache/apisix/pull/3660#discussion_r582529217
##
File path: Makefile
##
@@ -143,9 +143,8 @@ install: default
$(INSTALL) -d /usr/local/apisix/
$(INSTALL) -d /usr/local/apisix/logs/
qier222 commented on pull request #202:
URL: https://github.com/apache/apisix-website/pull/202#issuecomment-785559570
General docs ๐
APISIX English docs ๐ /website/
๐
๐
๐
This is an automated message from the Apac
qier222 commented on a change in pull request #202:
URL: https://github.com/apache/apisix-website/pull/202#discussion_r582526418
##
File path: website/i18n/zh-cn/docusaurus-plugin-content-docs/version-2.3.json
##
@@ -0,0 +1,10 @@
+{
+ "version.label": {
+"message": "2.3",
Jaycean commented on a change in pull request #1502:
URL: https://github.com/apache/apisix-dashboard/pull/1502#discussion_r582525738
##
File path: api/test/e2enew/upstream/upstream_test.go
##
@@ -0,0 +1,591 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one o
codecov-io commented on pull request #267:
URL:
https://github.com/apache/apisix-ingress-controller/pull/267#issuecomment-785558562
#
[Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/267?src=pr&el=h1)
Report
> Merging
[#267](https://codecov.io/gh/apache/apisix-ing
spacewander commented on a change in pull request #3660:
URL: https://github.com/apache/apisix/pull/3660#discussion_r582524375
##
File path: Makefile
##
@@ -143,9 +143,8 @@ install: default
$(INSTALL) -d /usr/local/apisix/
$(INSTALL) -d /usr/local/apisix/logs/
LiteSun commented on a change in pull request #1505:
URL: https://github.com/apache/apisix-dashboard/pull/1505#discussion_r582521980
##
File path: web/src/components/RawDataEditor/RawDataEditor.tsx
##
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
starsz commented on a change in pull request #1465:
URL: https://github.com/apache/apisix-dashboard/pull/1465#discussion_r582517913
##
File path: api/test/e2enew/base/http.go
##
@@ -92,3 +104,44 @@ func BatchTestServerPort(times int) map[string]int {
return res
}
+
+
nic-chen commented on issue #1508:
URL:
https://github.com/apache/apisix-dashboard/issues/1508#issuecomment-78535
> > When exporting the JSON Schema from APISIX, only the schema of the
plugins that APISIX has been enabled are exported.
>
> Because APISIX will only export enabled
nic-chen commented on issue #1508:
URL:
https://github.com/apache/apisix-dashboard/issues/1508#issuecomment-78347
> Do Dashboard users care about plugins that are not enabled? it is
reasonable for Dashboard to only display enabled plugins to me.
some of them do care about it, It
spacewander opened a new pull request #3666:
URL: https://github.com/apache/apisix/pull/3666
The www.apiseven.com can't be accessed as soon as the Apple's domain.
As limit-count also hit the lrucache.plugin_ctx, we can remove limit-req
with it safely.
Signed-off-by: spacewan
nic-chen commented on issue #1508:
URL:
https://github.com/apache/apisix-dashboard/issues/1508#issuecomment-785554905
> If we add a plugin in apisix, we should sync with the plugins
configuration?
yes
This is an auto
juzhiyuan commented on issue #1508:
URL:
https://github.com/apache/apisix-dashboard/issues/1508#issuecomment-785554332
> When exporting the JSON Schema from APISIX, only the schema of the plugins
that APISIX has been enabled are exported.
Because APISIX will only export enabled plu
nic-chen commented on issue #1510:
URL:
https://github.com/apache/apisix-dashboard/issues/1510#issuecomment-785554219
> I would prefer to keep the current default value, once users use the
following configuration:
>
> * listen.host == 0.0.0.0
> * The ManagerAPI is running in publ
ShiningRush commented on issue #1508:
URL:
https://github.com/apache/apisix-dashboard/issues/1508#issuecomment-785553635
Do Dashboard users care about plugins that are not enabled? it is reasonable
for Dashboard to only display enabled plugins to me.
-
nic-chen commented on pull request #1420:
URL: https://github.com/apache/apisix-dashboard/pull/1420#issuecomment-785553565
we need some test cases for it.
This is an automated message from the Apache Git Service.
To respond t
starsz commented on pull request #1420:
URL: https://github.com/apache/apisix-dashboard/pull/1420#issuecomment-785552818
I think we can merge it first.
What do you think? @nic-chen @juzhiyuan @liuxiran @imjoey
This is an
juzhiyuan commented on a change in pull request #1505:
URL: https://github.com/apache/apisix-dashboard/pull/1505#discussion_r582503212
##
File path: web/src/pages/Consumer/List.tsx
##
@@ -23,12 +23,15 @@ import { history, useIntl } from 'umi';
import { PlusOutlined } from '@an
stu01509 opened a new pull request #267:
URL: https://github.com/apache/apisix-ingress-controller/pull/267
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bugfix
- [x] New feature provided
- [ ] Improve performance
- [ ]
juzhiyuan commented on a change in pull request #1505:
URL: https://github.com/apache/apisix-dashboard/pull/1505#discussion_r582502327
##
File path: web/src/components/RawDataEditor/RawDataEditor.tsx
##
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
starsz commented on a change in pull request #1509:
URL: https://github.com/apache/apisix-dashboard/pull/1509#discussion_r582494143
##
File path: api/internal/core/store/storehub.go
##
@@ -36,6 +36,7 @@ const (
HubKeyScript HubKey = "script"
HubKeyGlobalRule
spacewander opened a new pull request #3665:
URL: https://github.com/apache/apisix/pull/3665
Signed-off-by: spacewander
### What this PR does / why we need it:
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new featu
Firstsawyou commented on issue #1510:
URL:
https://github.com/apache/apisix-dashboard/issues/1510#issuecomment-785551397
> They are two different configurations.
>
> Maybe we can set the default value of `listen.host` to `0.0.0.0`.
I think it would be better to explain the `al
juzhiyuan commented on issue #1510:
URL:
https://github.com/apache/apisix-dashboard/issues/1510#issuecomment-785551302
We'd better update the documentation and configuration file more clear about
this issue, no matter use 127.0.0.1 or 0.0.0.0
-
juzhiyuan commented on issue #1510:
URL:
https://github.com/apache/apisix-dashboard/issues/1510#issuecomment-785551052
I would prefer to keep the current default value, once users use the
following configuration:
- listen.host == 0.0.0.0
- The ManagerAPI is running in public IP
LiteSun commented on a change in pull request #1505:
URL: https://github.com/apache/apisix-dashboard/pull/1505#discussion_r582498175
##
File path: web/src/pages/Consumer/List.tsx
##
@@ -23,12 +23,15 @@ import { history, useIntl } from 'umi';
import { PlusOutlined } from '@ant-
juzhiyuan commented on issue #1508:
URL:
https://github.com/apache/apisix-dashboard/issues/1508#issuecomment-785549662
How about loop the schema.json and get the enabled plugin list?
This is an automated message from the Apa
juzhiyuan commented on a change in pull request #3661:
URL: https://github.com/apache/apisix/pull/3661#discussion_r582480110
##
File path: docs/zh/latest/config.json
##
@@ -0,0 +1,4 @@
+{
+ "version": 2.3,
+ "sidebar": {}
Review comment:
We could fill this sidebar in
Jaycean edited a comment on issue #1500:
URL:
https://github.com/apache/apisix-dashboard/issues/1500#issuecomment-783995871
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
LiteSun commented on pull request #1505:
URL: https://github.com/apache/apisix-dashboard/pull/1505#issuecomment-785548711
> @LiteSun you could fix those comments in another PR.
will fix typo soon in this pr.
This is an
starsz commented on issue #1508:
URL:
https://github.com/apache/apisix-dashboard/issues/1508#issuecomment-785548520
If we add a plugin in apisix, we should sync with the plugins configuration?
This is an automated message fr
LiteSun commented on a change in pull request #1505:
URL: https://github.com/apache/apisix-dashboard/pull/1505#discussion_r582487747
##
File path: web/src/components/RawDataEditor/RawDataEditor.tsx
##
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
starsz commented on issue #1510:
URL:
https://github.com/apache/apisix-dashboard/issues/1510#issuecomment-785545516
> They are two different configurations.
>
> Maybe we can set the default value of `listen.host` to `0.0.0.0`.
Agree +1.
--
nic-chen commented on a change in pull request #1502:
URL: https://github.com/apache/apisix-dashboard/pull/1502#discussion_r582478499
##
File path: api/test/e2enew/upstream/upstream_test.go
##
@@ -0,0 +1,591 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
juzhiyuan commented on pull request #202:
URL: https://github.com/apache/apisix-website/pull/202#issuecomment-785544369
@qier222 Please add a blank line in another PR if needed.
This is an automated message from the Apache Gi
juzhiyuan commented on pull request #202:
URL: https://github.com/apache/apisix-website/pull/202#issuecomment-785544204
> Where are these documents placed? ping @qier222
>
>
membphis edited a comment on pull request #202:
URL: https://github.com/apache/apisix-website/pull/202#issuecomment-785544058
Where are these documents placed? ping @qier222
 were added to refs/heads/master by this push:
new 442a0a0 feat: multiple features for
membphis commented on pull request #202:
URL: https://github.com/apache/apisix-website/pull/202#issuecomment-785544058
Where are these documents placed?
-
juzhiyuan commented on pull request #1505:
URL: https://github.com/apache/apisix-dashboard/pull/1505#issuecomment-785543807
@LiteSun you could fix those comments in another PR.
This is an automated message from the Apache Git
juzhiyuan commented on a change in pull request #1505:
URL: https://github.com/apache/apisix-dashboard/pull/1505#discussion_r582467887
##
File path: web/src/components/RawDataEditor/RawDataEditor.tsx
##
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
nic-chen commented on issue #1508:
URL:
https://github.com/apache/apisix-dashboard/issues/1508#issuecomment-785543200
cc @membphis @imjoey @liuxiran @ShiningRush
This is an automated message from the Apache Git Service.
To
nic-chen commented on issue #1510:
URL:
https://github.com/apache/apisix-dashboard/issues/1510#issuecomment-785542974
They are two different configurations.
Maybe we can set the default value of `listen.host` to `0.0.0.0`.
---
membphis commented on a change in pull request #202:
URL: https://github.com/apache/apisix-website/pull/202#discussion_r582470908
##
File path: website/i18n/zh-cn/docusaurus-plugin-content-docs/version-2.3.json
##
@@ -0,0 +1,10 @@
+{
+ "version.label": {
+"message": "2.3",
nic-chen commented on pull request #1477:
URL: https://github.com/apache/apisix-dashboard/pull/1477#issuecomment-785542004
@liuyang211
More contributions are welcome ! : )
This is an automated message from the Apache Git
nic-chen commented on issue #1039:
URL:
https://github.com/apache/apisix-dashboard/issues/1039#issuecomment-785541044
@liuxiran
Thanks for the explanation.
Maintaining a separate template is troublesome, and after the plugin schema
is updated in APISIX, it may be easier to miss here
nic-chen commented on issue #1399:
URL:
https://github.com/apache/apisix-dashboard/issues/1399#issuecomment-785539394
@LiteSun
The api cannot verify whether the submitted data is missing fields.
Only required fields can be checked if they are missing.
-
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git.
from 2a6e2b4 feat: add dns discovery (#3629)
add e146893 docs: plugin-develop.md adds ctx and conf description
spacewander merged pull request #3650:
URL: https://github.com/apache/apisix/pull/3650
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
spacewander closed issue #3608:
URL: https://github.com/apache/apisix/issues/3608
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
gxthrj merged pull request #265:
URL: https://github.com/apache/apisix-ingress-controller/pull/265
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
This is an automated email from the ASF dual-hosted git repository.
kvn pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git
The following commit(s) were added to refs/heads/master by this push:
new 121bda3 feat: use unified trans
juzhiyuan commented on a change in pull request #3661:
URL: https://github.com/apache/apisix/pull/3661#discussion_r582445884
##
File path: docs/zh/latest/plugins/proxy-rewrite.md
##
@@ -17,9 +17,13 @@
#
-->
+<<< HEAD:docs/zh/latest/plugins/proxy-rewrite.md
+# proxy-rewr
Yiyiyimu commented on a change in pull request #3660:
URL: https://github.com/apache/apisix/pull/3660#discussion_r582442941
##
File path: Makefile
##
@@ -143,9 +143,7 @@ install: default
$(INSTALL) -d /usr/local/apisix/
$(INSTALL) -d /usr/local/apisix/logs/
juzhiyuan commented on issue #3659:
URL: https://github.com/apache/apisix/issues/3659#issuecomment-785525673
ok
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
Yiyiyimu commented on a change in pull request #137:
URL: https://github.com/apache/apisix-docker/pull/137#discussion_r582440504
##
File path: .github/workflows/apisix-alpine-local-docker-test.yaml
##
@@ -0,0 +1,43 @@
+name: APISIX Alpine local docker Test
+
+on:
+ push:
+
Yiyiyimu commented on a change in pull request #137:
URL: https://github.com/apache/apisix-docker/pull/137#discussion_r582440327
##
File path: Makefile
##
@@ -28,6 +28,10 @@ build-on-centos:
build-on-alpine:
docker build -t $(IMAGE_NAME):$(APISIX_VERSION)-alpine -f
./
juzhiyuan commented on issue #3662:
URL: https://github.com/apache/apisix/issues/3662#issuecomment-785519124
It seems that this location is a historical issue, we could remove it IMO.
This is an automated message from the Apa
Firstsawyou commented on issue #3652:
URL: https://github.com/apache/apisix/issues/3652#issuecomment-785517968
> Maybe we can automatically generate a priority list of plugins
> @Firstsawyou
Yes, I will try it.
This
spacewander commented on issue #2947:
URL: https://github.com/apache/apisix/issues/2947#issuecomment-785517131
Done as luarocks.cn.
This is an automated message from the Apache Git Service.
To respond to the message, please l
spacewander closed issue #2947:
URL: https://github.com/apache/apisix/issues/2947
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
spacewander closed issue #2973:
URL: https://github.com/apache/apisix/issues/2973
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
spacewander commented on issue #2973:
URL: https://github.com/apache/apisix/issues/2973#issuecomment-785516688
Now we cache the record according to the TTL. Feel free to reopen it if the
problem is still exist.
This is an au
spacewander closed issue #3515:
URL: https://github.com/apache/apisix/issues/3515
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
spacewander commented on issue #3515:
URL: https://github.com/apache/apisix/issues/3515#issuecomment-785515732
Consider solved
This is an automated message from the Apache Git Service.
To respond to the message, please log on
spacewander closed issue #3517:
URL: https://github.com/apache/apisix/issues/3517
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
LiteSun commented on issue #1399:
URL:
https://github.com/apache/apisix-dashboard/issues/1399#issuecomment-785513280
1. I submitted a PR for rawDataEditor's view mode. #1505
2. `edit` mode needs @nic-chen's support to validate data.
---
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 2a6e2b4 feat: add dns discovery (#3629)
2a
spacewander merged pull request #3629:
URL: https://github.com/apache/apisix/pull/3629
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
membphis commented on issue #1039:
URL:
https://github.com/apache/apisix-dashboard/issues/1039#issuecomment-785512082
ping @nic-chen
This is an automated message from the Apache Git Service.
To respond to the message, pleas
membphis commented on issue #259:
URL:
https://github.com/apache/apisix-ingress-controller/issues/259#issuecomment-785511787
@Bhanuji95 the APISIX does not support AzureAD/Azure OIDC authentication
now. if you need it, you can create a new issue for discussion.
link: https://github
membphis commented on issue #1399:
URL:
https://github.com/apache/apisix-dashboard/issues/1399#issuecomment-785510790
ping @LiteSun
This is an automated message from the Apache Git Service.
To respond to the message, please
membphis merged pull request #3639:
URL: https://github.com/apache/apisix/pull/3639
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
This is an automated email from the ASF dual-hosted git repository.
membphis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 5591595 test: add fuzzing case for the route
membphis commented on a change in pull request #3629:
URL: https://github.com/apache/apisix/pull/3629#discussion_r582423351
##
File path: apisix/upstream.lua
##
@@ -179,7 +179,12 @@ function _M.set_by_route(route, api_ctx)
if not dis then
return 500, "disc
belongwqz opened a new issue #3664:
URL: https://github.com/apache/apisix/issues/3664
### Issue description
If I want to enable my plugin, I have two choices:
1.modify the `config-default.yaml` and append my plugin name to the
`plugins`, it's easy, but not recommended .
2.copy all
nic-chen commented on issue #1508:
URL:
https://github.com/apache/apisix-dashboard/issues/1508#issuecomment-785505738
> maintain a yaml file or filter from schema.json?
1. All plugins are included in schema.json
2. Add a new configuration item `plugins` in `conf.yaml` to control w
spacewander merged pull request #3649:
URL: https://github.com/apache/apisix/pull/3649
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new fdb0d25 docs: update admin-api.md (#3649)
tokers commented on a change in pull request #265:
URL:
https://github.com/apache/apisix-ingress-controller/pull/265#discussion_r582413984
##
File path: pkg/ingress/apisix/tls_test.go
##
@@ -69,46 +69,6 @@ spec:
assert.EqualValues(t, sslExpect.Group, ssl.Group, "group
spacewander commented on issue #3662:
URL: https://github.com/apache/apisix/issues/3662#issuecomment-785500317
@juzhiyuan
What about your opinion?
This is an automated message from the Apache Git Service.
To respond to th
tzssangglass edited a comment on issue #3663:
URL: https://github.com/apache/apisix/issues/3663#issuecomment-785499851
> PR is welcome!
assign to me
This is an automated message from the Apache Git Service.
To respond
tzssangglass commented on issue #3663:
URL: https://github.com/apache/apisix/issues/3663#issuecomment-785499851
> PR is welcome!
assign to me
This is an automated message from the Apache Git Service.
To respond to the
tokers commented on issue #3659:
URL: https://github.com/apache/apisix/issues/3659#issuecomment-785499624
OK, will do it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
spacewander commented on issue #3659:
URL: https://github.com/apache/apisix/issues/3659#issuecomment-785499352
Thanks for your report!
We will remove the obsolete release soon.
As for dashboard and ingress-controller, CC @juzhiyuan @tokers
---
tokers commented on a change in pull request #3660:
URL: https://github.com/apache/apisix/pull/3660#discussion_r582415967
##
File path: Makefile
##
@@ -143,9 +143,7 @@ install: default
$(INSTALL) -d /usr/local/apisix/
$(INSTALL) -d /usr/local/apisix/logs/
tokers commented on a change in pull request #3650:
URL: https://github.com/apache/apisix/pull/3650#discussion_r582415433
##
File path: doc/plugin-develop.md
##
@@ -295,7 +295,65 @@ end
## implement the logic
-Write the logic of the plugin in the corresponding phase.
+Writ
tokers commented on issue #264:
URL:
https://github.com/apache/apisix-ingress-controller/issues/264#issuecomment-785498097
@stu01509 Assigned.
This is an automated message from the Apache Git Service.
To respond to the messa
spacewander commented on issue #3663:
URL: https://github.com/apache/apisix/issues/3663#issuecomment-785497946
PR is welcome!
This is an automated message from the Apache Git Service.
To respond to the message, please log on
This is an automated email from the ASF dual-hosted git repository.
tokers pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git
The following commit(s) were added to refs/heads/master by this push:
new 5e43d78 docs: fix SDK doc li
tokers commented on pull request #266:
URL:
https://github.com/apache/apisix-ingress-controller/pull/266#issuecomment-785497649
@stu01509 Well done!
This is an automated message from the Apache Git Service.
To respond to the
tokers merged pull request #266:
URL: https://github.com/apache/apisix-ingress-controller/pull/266
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
101 - 200 of 271 matches
Mail list logo
