[GitHub] [apisix-dashboard] nic-chen opened a new pull request #1594: fix: use APISIX 2.4 to run backend E2E test

2021-03-14 Thread GitBox
nic-chen opened a new pull request #1594: URL: https://github.com/apache/apisix-dashboard/pull/1594 Please answer these questions before submitting a pull request - Why submit this pull request? - [x] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backpo

[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #1591: fix: fix CYPRESS cross platform env error

2021-03-14 Thread GitBox
LiteSun commented on a change in pull request #1591: URL: https://github.com/apache/apisix-dashboard/pull/1591#discussion_r594085031 ## File path: web/package.json ## @@ -29,9 +29,9 @@ "start:test": "cross-env REACT_APP_ENV=test MOCK=none umi dev", "test:component": "

[GitHub] [apisix] spacewander closed issue #3777: request help: plz ,i wanne konw why this result linear .can u offer more detail configuration parameter?

2021-03-14 Thread GitBox
spacewander closed issue #3777: URL: https://github.com/apache/apisix/issues/3777 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [apisix] spacewander closed issue #3811: request help: is there dbless version for apisix

2021-03-14 Thread GitBox
spacewander closed issue #3811: URL: https://github.com/apache/apisix/issues/3811 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [apisix-dashboard] guoqqqi edited a comment on issue #1503: Build v2.4 error.

2021-03-14 Thread GitBox
guoqqqi edited a comment on issue #1503: URL: https://github.com/apache/apisix-dashboard/issues/1503#issuecomment-799157048 Hi, @wannianma, I followed the build guide https://apisix.apache.org/docs/dashboard/deploy/ and it built successfully on the server, can you give more details on wh

[GitHub] [apisix-dashboard] guoqqqi commented on issue #1503: Build v2.4 error.

2021-03-14 Thread GitBox
guoqqqi commented on issue #1503: URL: https://github.com/apache/apisix-dashboard/issues/1503#issuecomment-799157048 Hi, @wannianma, I followed the build guide https://apisix.apache.org/docs/dashboard/deploy/ and it built successfully on the server, can you give more details on what you

[GitHub] [apisix] jbampton commented on pull request #3825: feat: first attempt at APISIX overall GitHub leaderboard

2021-03-14 Thread GitBox
jbampton commented on pull request #3825: URL: https://github.com/apache/apisix/pull/3825#issuecomment-799155092 This list shows all contributors not just 100 This is an automated message from the Apache Git Service. To respo

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1580: fix: fix the upstream timeout unit

2021-03-14 Thread GitBox
codecov-io edited a comment on pull request #1580: URL: https://github.com/apache/apisix-dashboard/pull/1580#issuecomment-797511954 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr&el=h1) Report > Merging [#1580](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1591: fix: fix CYPRESS cross platform env error

2021-03-14 Thread GitBox
juzhiyuan commented on a change in pull request #1591: URL: https://github.com/apache/apisix-dashboard/pull/1591#discussion_r594070690 ## File path: web/package.json ## @@ -29,9 +29,9 @@ "start:test": "cross-env REACT_APP_ENV=test MOCK=none umi dev", "test:component":

[GitHub] [apisix] batman-ezio commented on issue #3763: feat: add "allow_origins_by_regex" to cors plugin

2021-03-14 Thread GitBox
batman-ezio commented on issue #3763: URL: https://github.com/apache/apisix/issues/3763#issuecomment-799132045 @spacewander can you assign this to me This is an automated message from the Apache Git Service. To respond to th

[GitHub] [apisix] jbampton opened a new pull request #3825: feat: first attempt at APISIX overall GitHub leaderboard

2021-03-14 Thread GitBox
jbampton opened a new pull request #3825: URL: https://github.com/apache/apisix/pull/3825 - Thought it would be good to have an AUTHORS file and I think that RAILS does it well: https://contributors.rubyonrails.org/ - Could be expanded in future to match on names too - Was a quick Rub

[GitHub] [apisix] Firstsawyou commented on issue #3787: [discuss]: does the traffic-split plugin has a way to implement the original capabilities without corrupting the data?

2021-03-14 Thread GitBox
Firstsawyou commented on issue #3787: URL: https://github.com/apache/apisix/issues/3787#issuecomment-799131511 @tzssangglass uses the method of `"when the route is configured with an upstream_id, the upstream_id is passed into the server_list"` to solve it. Thank you very much @tzssangg

[GitHub] [apisix-dashboard] stu01509 commented on a change in pull request #1591: fix: fix CYPRESS cross platform env error

2021-03-14 Thread GitBox
stu01509 commented on a change in pull request #1591: URL: https://github.com/apache/apisix-dashboard/pull/1591#discussion_r594059146 ## File path: web/package.json ## @@ -29,9 +29,9 @@ "start:test": "cross-env REACT_APP_ENV=test MOCK=none umi dev", "test:component":

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1538: fix: Incomplete i18n coverage

2021-03-14 Thread GitBox
codecov-io edited a comment on pull request #1538: URL: https://github.com/apache/apisix-dashboard/pull/1538#issuecomment-788590625 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr&el=h1) Report > Merging [#1538](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1538: fix: Incomplete i18n coverage

2021-03-14 Thread GitBox
codecov-io edited a comment on pull request #1538: URL: https://github.com/apache/apisix-dashboard/pull/1538#issuecomment-788590625 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr&el=h1) Report > Merging [#1538](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1538: fix: Incomplete i18n coverage

2021-03-14 Thread GitBox
codecov-io edited a comment on pull request #1538: URL: https://github.com/apache/apisix-dashboard/pull/1538#issuecomment-788590625 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr&el=h1) Report > Merging [#1538](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] tokers commented on issue #746: Bugs in GenericStore.Create and GenericStore.Update

2021-03-14 Thread GitBox
tokers commented on issue #746: URL: https://github.com/apache/apisix-dashboard/issues/746#issuecomment-799081930 @nic-chen I'm still busying on other things, if this stuff is not so emergency, maybe we can do it later. Thi

[GitHub] [apisix-dashboard] nic-chen commented on pull request #1558: feat:Support duplicate one existing Route

2021-03-14 Thread GitBox
nic-chen commented on pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-799079221 > Why backend failed? need some time to check for it This is an automated message from the Apac

[GitHub] [apisix-dashboard] nic-chen commented on issue #1554: bug: 通过API创建的upstream和route,在dashboard的route详情页面中显示不完整

2021-03-14 Thread GitBox
nic-chen commented on issue #1554: URL: https://github.com/apache/apisix-dashboard/issues/1554#issuecomment-799077359 @miaoyb could you provide the version of APISIX and Dashboard, and the config you created the route and upstream ? ---

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1580: fix: fix the upstream timeout unit

2021-03-14 Thread GitBox
codecov-io edited a comment on pull request #1580: URL: https://github.com/apache/apisix-dashboard/pull/1580#issuecomment-797511954 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr&el=h1) Report > Merging [#1580](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-ingress-controller] membphis commented on pull request #300: add chinese version of decument

2021-03-14 Thread GitBox
membphis commented on pull request #300: URL: https://github.com/apache/apisix-ingress-controller/pull/300#issuecomment-799074256 @soulsoul this pr is big, and I think you can split it into multiple small PRs. it is easier to review and merge.

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1580: fix: fix the upstream timeout unit

2021-03-14 Thread GitBox
codecov-io edited a comment on pull request #1580: URL: https://github.com/apache/apisix-dashboard/pull/1580#issuecomment-797511954 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr&el=h1) Report > Merging [#1580](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1558: feat:Support duplicate one existing Route

2021-03-14 Thread GitBox
juzhiyuan commented on pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-799073507 Why backend failed? This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [apisix-dashboard] starsz commented on pull request #1558: feat:Support duplicate one existing Route

2021-03-14 Thread GitBox
starsz commented on pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-799072311 Wait for CI. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [apisix-dashboard] LiteSun commented on pull request #1558: feat:Support duplicate one existing Route

2021-03-14 Thread GitBox
LiteSun commented on pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-799069875 > @batman-ezio you can make a try to merge the `master` branch Just help you sync master branch code. let's wait for CI report 😊

[GitHub] [apisix-dashboard] membphis commented on pull request #1558: feat:Support duplicate one existing Route

2021-03-14 Thread GitBox
membphis commented on pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-799067440 @batman-ezio you can make a try to merge the `master` branch This is an automated message from the Apa

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1490: feat: support yaml to config plugin in plugin config page

2021-03-14 Thread GitBox
juzhiyuan merged pull request #1490: URL: https://github.com/apache/apisix-dashboard/pull/1490 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[apisix-dashboard] branch master updated (07e55f2 -> e22de29)

2021-03-14 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 07e55f2 fix: fe e2e error for pr 1538 (#1590) add e22de29 feat: support yaml to config plugin in

[GitHub] [apisix-dashboard] juzhiyuan closed issue #1512: Plugin template configuration

2021-03-14 Thread GitBox
juzhiyuan closed issue #1512: URL: https://github.com/apache/apisix-dashboard/issues/1512 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1584: feat: save list page's meta status

2021-03-14 Thread GitBox
juzhiyuan commented on pull request #1584: URL: https://github.com/apache/apisix-dashboard/pull/1584#issuecomment-799066671 @guoqqqi You should mark this PR ready for review. This is an automated message from the Apache Git S

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1591: fix: fix CYPRESS cross platform env error

2021-03-14 Thread GitBox
juzhiyuan commented on a change in pull request #1591: URL: https://github.com/apache/apisix-dashboard/pull/1591#discussion_r594028620 ## File path: web/package.json ## @@ -29,9 +29,9 @@ "start:test": "cross-env REACT_APP_ENV=test MOCK=none umi dev", "test:component":

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1590: fix: fe e2e error for pr 1538

2021-03-14 Thread GitBox
juzhiyuan merged pull request #1590: URL: https://github.com/apache/apisix-dashboard/pull/1590 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[apisix-dashboard] branch master updated: fix: fe e2e error for pr 1538 (#1590)

2021-03-14 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new 07e55f2 fix: fe e2e error for pr

[GitHub] [apisix-dashboard] LiteSun commented on pull request #1584: feat: save list page's meta status

2021-03-14 Thread GitBox
LiteSun commented on pull request #1584: URL: https://github.com/apache/apisix-dashboard/pull/1584#issuecomment-799053245 > @LiteSun When you have time, please help me check this PR. ok, you mean review? This is an aut

[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #1576: fix: config proxy-rewrite out of the plugin market in route module

2021-03-14 Thread GitBox
LiteSun commented on a change in pull request #1576: URL: https://github.com/apache/apisix-dashboard/pull/1576#discussion_r594013700 ## File path: web/src/pages/Route/components/Step1/ProxyRewrite.tsx ## @@ -0,0 +1,291 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [apisix] Miss-you opened a new pull request #3824: typo: fix table format in plugin limit-count-redis-cluster.lua and limit-count-redis.lua

2021-03-14 Thread GitBox
Miss-you opened a new pull request #3824: URL: https://github.com/apache/apisix/pull/3824 typo: fix table format in plugin limit-count-redis-cluster.lua and limit-count-redis.lua ### What this PR does / why we need it: ### Pre-submission checklist: * [ ] Did you

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1582: feat: rewrite e2e test(rewrite-e2e-test-route-with-priority-test) with ginkgo

2021-03-14 Thread GitBox
codecov-io edited a comment on pull request #1582: URL: https://github.com/apache/apisix-dashboard/pull/1582#issuecomment-799045704 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1582?src=pr&el=h1) Report > Merging [#1582](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] Jaycean opened a new pull request #1593: feat: rewrite e2e test(rewrite-e2e-test-route-with-proxy-test) with ginkgo

2021-03-14 Thread GitBox
Jaycean opened a new pull request #1593: URL: https://github.com/apache/apisix-dashboard/pull/1593 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - [ ] Backpor

[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #275: updated technical architecture of apisix-ingress-controller

2021-03-14 Thread GitBox
codecov-io edited a comment on pull request #275: URL: https://github.com/apache/apisix-ingress-controller/pull/275#issuecomment-787224463 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275?src=pr&el=h1) Report > Merging [#275](https://codecov.io/gh/apache/api

[GitHub] [apisix-ingress-controller] iamayushdas edited a comment on pull request #275: updated technical architecture of apisix-ingress-controller

2021-03-14 Thread GitBox
iamayushdas edited a comment on pull request #275: URL: https://github.com/apache/apisix-ingress-controller/pull/275#issuecomment-799046244 @gxthrj i have done the change according to helm repo ,can i have a review please?

[GitHub] [apisix-ingress-controller] iamayushdas commented on pull request #275: updated technical architecture of apisix-ingress-controller

2021-03-14 Thread GitBox
iamayushdas commented on pull request #275: URL: https://github.com/apache/apisix-ingress-controller/pull/275#issuecomment-799046244 @gxthrj can i have a review on this? This is an automated message from the Apache Git Servi

[GitHub] [apisix-dashboard] LiteSun commented on issue #1512: Plugin template configuration

2021-03-14 Thread GitBox
LiteSun commented on issue #1512: URL: https://github.com/apache/apisix-dashboard/issues/1512#issuecomment-799045795 > @LiteSun can we close this issue now? Sure. This is an automated message from the Apache Git Servi

[GitHub] [apisix-dashboard] LiteSun commented on issue #1512: Plugin template configuration

2021-03-14 Thread GitBox
LiteSun commented on issue #1512: URL: https://github.com/apache/apisix-dashboard/issues/1512#issuecomment-799045638 closed by #1540 This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1582: feat: rewrite e2e test(rewrite-e2e-test-route-with-priority-test) with ginkgo

2021-03-14 Thread GitBox
codecov-io commented on pull request #1582: URL: https://github.com/apache/apisix-dashboard/pull/1582#issuecomment-799045704 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1582?src=pr&el=h1) Report > Merging [#1582](https://codecov.io/gh/apache/apisix-dashboard/pull/158

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1592: feat: expose JSON Schema through API

2021-03-14 Thread GitBox
codecov-io edited a comment on pull request #1592: URL: https://github.com/apache/apisix-dashboard/pull/1592#issuecomment-798933657 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1592?src=pr&el=h1) Report > Merging [#1592](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix] spacewander opened a new pull request #3823: test: don't crash when dubbo upstream returns integer status code

2021-03-14 Thread GitBox
spacewander opened a new pull request #3823: URL: https://github.com/apache/apisix/pull/3823 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new featu

[GitHub] [apisix] jbampton opened a new pull request #3822: chore: sort imports in the Markdown examples

2021-03-14 Thread GitBox
jbampton opened a new pull request #3822: URL: https://github.com/apache/apisix/pull/3822 ### What this PR does / why we need it: Standardizes the codebase ### Pre-submission checklist: * [X] Did you explain what problem does this PR solve? Or what new features have bee

[GitHub] [apisix] spacewander merged pull request #3809: feat: upgrade lua-resty-expr/radixtree to support logical expression

2021-03-14 Thread GitBox
spacewander merged pull request #3809: URL: https://github.com/apache/apisix/pull/3809 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[apisix] branch master updated: feat: upgrade lua-resty-expr/radixtree to support logical expression (#3809)

2021-03-14 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 7047932 feat: upgrade lua-resty-expr/radix

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1592: feat: expose JSON Schema through API

2021-03-14 Thread GitBox
starsz commented on a change in pull request #1592: URL: https://github.com/apache/apisix-dashboard/pull/1592#discussion_r594002376 ## File path: api/internal/handler/schema/schema.go ## @@ -0,0 +1,76 @@ +/* Review comment: I think you can merge `plugin.go` to `schema.g

[GitHub] [apisix-dashboard] nic-chen commented on pull request #1583: fest: rewrite e2e test(route_import_test) with ginkgo

2021-03-14 Thread GitBox
nic-chen commented on pull request #1583: URL: https://github.com/apache/apisix-dashboard/pull/1583#issuecomment-799033939 > Thank you @membphis :) > > It seems few recently added tests are failing. I am going to push the changes really soon after rechecking the code. > > Btw,

[GitHub] [apisix-dashboard] nic-chen commented on pull request #1592: feat: expose JSON Schema through API

2021-03-14 Thread GitBox
nic-chen commented on pull request #1592: URL: https://github.com/apache/apisix-dashboard/pull/1592#issuecomment-799033033 > why this PR will decrease coverage by 12.25%? Because the coverage of the last PR merged into the master only counts the coverage of `frontend-e2e-test`, see:

[GitHub] [apisix-dashboard] membphis commented on pull request #1583: fest: rewrite e2e test(route_import_test) with ginkgo

2021-03-14 Thread GitBox
membphis commented on pull request #1583: URL: https://github.com/apache/apisix-dashboard/pull/1583#issuecomment-799030114 > Here I have used [`gomega`](https://onsi.github.io/gomega/) with ginkgo as a matcher library (as they are widely used as a combo for being more bdd style), will that

[GitHub] [apisix-dashboard] batman-ezio commented on pull request #1558: feat:Support duplicate one existing Route

2021-03-14 Thread GitBox
batman-ezio commented on pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-799028747 > ping @LiteSun I see he fire the PR for fix, https://github.com/apache/apisix-dashboard/pull/1590/files ---

[GitHub] [apisix] spacewander commented on a change in pull request #3766: docs: add --server option for the use of luarocks

2021-03-14 Thread GitBox
spacewander commented on a change in pull request #3766: URL: https://github.com/apache/apisix/pull/3766#discussion_r593997301 ## File path: Makefile ## @@ -60,6 +60,7 @@ help: default ### deps: Installation dependencies .PHONY: deps deps: default +luarocks insta

[GitHub] [apisix] spacewander commented on pull request #3809: feat: upgrade lua-resty-expr/radixtree to support logical expression

2021-03-14 Thread GitBox
spacewander commented on pull request #3809: URL: https://github.com/apache/apisix/pull/3809#issuecomment-799026854 > > > > do we need to add doc for this PR? > > We may add a link to refer to the lua-resty-expr. We have already done it in the doc. ---

[GitHub] [apisix] spacewander merged pull request #3817: test: make control/discovery.t stable

2021-03-14 Thread GitBox
spacewander merged pull request #3817: URL: https://github.com/apache/apisix/pull/3817 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[apisix] branch master updated: test: make control/discovery.t stable (#3817)

2021-03-14 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new ecb04f3 test: make control/discovery.t sta

[GitHub] [apisix] tokers merged pull request #3821: chore: fix spelling, grammar and JSON example

2021-03-14 Thread GitBox
tokers merged pull request #3821: URL: https://github.com/apache/apisix/pull/3821 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[apisix] branch master updated: chore: fix spelling, grammar and JSON example (#3821)

2021-03-14 Thread tokers
This is an automated email from the ASF dual-hosted git repository. tokers pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 9fafa43 chore: fix spelling, grammar and JSON e

[GitHub] [apisix] tokers merged pull request #3758: fix: the traffic-split plugin is invalid to bind upstream via upstream_id

2021-03-14 Thread GitBox
tokers merged pull request #3758: URL: https://github.com/apache/apisix/pull/3758 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [apisix] tokers closed issue #3740: bug: the traffic-split plugin is invalid to bind upstream via upstream_id

2021-03-14 Thread GitBox
tokers closed issue #3740: URL: https://github.com/apache/apisix/issues/3740 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[apisix] branch master updated (4ebccaf -> 210ca46)

2021-03-14 Thread tokers
This is an automated email from the ASF dual-hosted git repository. tokers pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 4ebccaf chore: fix spelling (#3253) add 210ca46 fix: the traffic-split plugin is invalid to bind upstream via

[GitHub] [apisix] tokers commented on pull request #3809: feat: upgrade lua-resty-expr/radixtree to support logical expression

2021-03-14 Thread GitBox
tokers commented on pull request #3809: URL: https://github.com/apache/apisix/pull/3809#issuecomment-799020165 > do we need to add doc for this PR? We may add a link to refer to the lua-resty-expr. This is an automated

[GitHub] [apisix-dashboard] batman-ezio edited a comment on pull request #1558: feat:Support duplicate one existing Route

2021-03-14 Thread GitBox
batman-ezio edited a comment on pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-799015546 after rebase from latest master, the frontend test case is still failed. `should import route(s) from be test files` failed because click from multi

[GitHub] [apisix-dashboard] batman-ezio commented on pull request #1558: feat:Support duplicate one existing Route

2021-03-14 Thread GitBox
batman-ezio commented on pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-799015546 after rebase from latest master, the frontend test case is still failed. `should import route(s) from be test files` failed because from click multi routes

[GitHub] [apisix] moonming commented on pull request #3809: feat: upgrade lua-resty-expr/radixtree to support logical expression

2021-03-14 Thread GitBox
moonming commented on pull request #3809: URL: https://github.com/apache/apisix/pull/3809#issuecomment-799014965 do we need to add doc for this PR? This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [apisix-dashboard] guoqqqi commented on issue #1554: bug: 通过API创建的upstream和route,在dashboard的route详情页面中显示不完整

2021-03-14 Thread GitBox
guoqqqi commented on issue #1554: URL: https://github.com/apache/apisix-dashboard/issues/1554#issuecomment-799014895 Hi @miaoyb @membphis , sorry for the late reply. Do you mean you tried this guide: https://apisix.apache.org/docs/apisix/getting-started#create-an-upstream ? if yes, then t

[GitHub] [apisix] stu01509 commented on a change in pull request #3766: docs: add --server option for the use of luarocks

2021-03-14 Thread GitBox
stu01509 commented on a change in pull request #3766: URL: https://github.com/apache/apisix/pull/3766#discussion_r593988469 ## File path: Makefile ## @@ -60,6 +60,7 @@ help: default ### deps: Installation dependencies .PHONY: deps deps: default +luarocks install

[GitHub] [apisix] stu01509 commented on a change in pull request #3766: docs: add --server option for the use of luarocks

2021-03-14 Thread GitBox
stu01509 commented on a change in pull request #3766: URL: https://github.com/apache/apisix/pull/3766#discussion_r593988469 ## File path: Makefile ## @@ -60,6 +60,7 @@ help: default ### deps: Installation dependencies .PHONY: deps deps: default +luarocks install

[GitHub] [apisix-dashboard] moonming commented on pull request #1592: feat: expose JSON Schema through API

2021-03-14 Thread GitBox
moonming commented on pull request #1592: URL: https://github.com/apache/apisix-dashboard/pull/1592#issuecomment-799013592 why this PR will decrease coverage by 12.25%? This is an automated message from the Apache Git Service

[GitHub] [apisix-dashboard] stu01509 commented on a change in pull request #1591: fix: fix CYPRESS cross platform env error

2021-03-14 Thread GitBox
stu01509 commented on a change in pull request #1591: URL: https://github.com/apache/apisix-dashboard/pull/1591#discussion_r593988141 ## File path: web/package.json ## @@ -29,9 +29,9 @@ "start:test": "cross-env REACT_APP_ENV=test MOCK=none umi dev", "test:component":

[GitHub] [apisix-dashboard] nic-chen commented on pull request #1580: fix: fix the upstream timeout unit

2021-03-14 Thread GitBox
nic-chen commented on pull request #1580: URL: https://github.com/apache/apisix-dashboard/pull/1580#issuecomment-799003391 thanks @liuxiran This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1590: fix: fe e2e error for pr 1538

2021-03-14 Thread GitBox
codecov-io edited a comment on pull request #1590: URL: https://github.com/apache/apisix-dashboard/pull/1590#issuecomment-798638590 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1590?src=pr&el=h1) Report > Merging [#1590](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1590: fix: fe e2e error for pr 1538

2021-03-14 Thread GitBox
codecov-io edited a comment on pull request #1590: URL: https://github.com/apache/apisix-dashboard/pull/1590#issuecomment-798638590 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1590?src=pr&el=h1) Report > Merging [#1590](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] liuxiran commented on pull request #1580: fix: fix the upstream timeout unit

2021-03-14 Thread GitBox
liuxiran commented on pull request #1580: URL: https://github.com/apache/apisix-dashboard/pull/1580#issuecomment-798992193 > Hi @liuxiran and @nic-chen > > Thanks for point out, so should I fix the E2E test error or waiting for @nic-chen to solve it? you can try to fix the e2

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1576: fix: config proxy-rewrite out of the plugin market in route module

2021-03-14 Thread GitBox
codecov-io edited a comment on pull request #1576: URL: https://github.com/apache/apisix-dashboard/pull/1576#issuecomment-795836615 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1576?src=pr&el=h1) Report > Merging [#1576](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1590: fix: fe e2e error for pr 1538

2021-03-14 Thread GitBox
codecov-io edited a comment on pull request #1590: URL: https://github.com/apache/apisix-dashboard/pull/1590#issuecomment-798638590 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1590?src=pr&el=h1) Report > Merging [#1590](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1576: fix: config proxy-rewrite out of the plugin market in route module

2021-03-14 Thread GitBox
codecov-io edited a comment on pull request #1576: URL: https://github.com/apache/apisix-dashboard/pull/1576#issuecomment-795836615 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1576?src=pr&el=h1) Report > Merging [#1576](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1590: fix: fe e2e error for pr 1538

2021-03-14 Thread GitBox
liuxiran commented on a change in pull request #1590: URL: https://github.com/apache/apisix-dashboard/pull/1590#discussion_r593971033 ## File path: web/cypress/integration/route/import_export_route.spec.js ## @@ -159,7 +159,7 @@ context('import and export routes', () => {

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1576: fix: config proxy-rewrite out of the plugin market in route module

2021-03-14 Thread GitBox
codecov-io edited a comment on pull request #1576: URL: https://github.com/apache/apisix-dashboard/pull/1576#issuecomment-795836615 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1576?src=pr&el=h1) Report > Merging [#1576](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] bisakhmondal commented on a change in pull request #1592: feat: expose JSON Schema through API

2021-03-14 Thread GitBox
bisakhmondal commented on a change in pull request #1592: URL: https://github.com/apache/apisix-dashboard/pull/1592#discussion_r593944343 ## File path: api/test/e2enew/schema/plugin_test.go ## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[GitHub] [apisix-dashboard] bisakhmondal commented on pull request #1583: fest: rewrite e2e test(route_import_test) with ginkgo

2021-03-14 Thread GitBox
bisakhmondal commented on pull request #1583: URL: https://github.com/apache/apisix-dashboard/pull/1583#issuecomment-798957791 Thank you @membphis :) It seems few recently added tests are failing. I am going to push the changes really soon after rechecking the code. Btw, I hav

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1592: feat: expose JSON Schema through API

2021-03-14 Thread GitBox
codecov-io edited a comment on pull request #1592: URL: https://github.com/apache/apisix-dashboard/pull/1592#issuecomment-798933657 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1592?src=pr&el=h1) Report > Merging [#1592](https://codecov.io/gh/apache/apisix-dashboard/p

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1592: feat: expose JSON Schema through API

2021-03-14 Thread GitBox
codecov-io commented on pull request #1592: URL: https://github.com/apache/apisix-dashboard/pull/1592#issuecomment-798933657 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1592?src=pr&el=h1) Report > Merging [#1592](https://codecov.io/gh/apache/apisix-dashboard/pull/159

[GitHub] [apisix] membphis commented on a change in pull request #3766: docs: add --server option for the use of luarocks

2021-03-14 Thread GitBox
membphis commented on a change in pull request #3766: URL: https://github.com/apache/apisix/pull/3766#discussion_r593922682 ## File path: Makefile ## @@ -60,6 +60,7 @@ help: default ### deps: Installation dependencies .PHONY: deps deps: default +luarocks install

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1592: feat: expose JSON Schema through API

2021-03-14 Thread GitBox
juzhiyuan commented on pull request #1592: URL: https://github.com/apache/apisix-dashboard/pull/1592#issuecomment-798932681 also cc @guoqqqi to review This is an automated message from the Apache Git Service. To respond to th

[GitHub] [apisix-dashboard] nic-chen opened a new pull request #1592: feat: expose JSON Schema through API

2021-03-14 Thread GitBox
nic-chen opened a new pull request #1592: URL: https://github.com/apache/apisix-dashboard/pull/1592 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - [ ] Backpo

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1512: Plugin template configuration

2021-03-14 Thread GitBox
juzhiyuan commented on issue #1512: URL: https://github.com/apache/apisix-dashboard/issues/1512#issuecomment-798932003 @LiteSun Do remember to use `close/resolve/fix #xxx` to link issue in PR. This is an automated message fr

[GitHub] [apisix] membphis commented on issue #3787: [discuss]: does the traffic-split plugin has a way to implement the original capabilities without corrupting the data?

2021-03-14 Thread GitBox
membphis commented on issue #3787: URL: https://github.com/apache/apisix/issues/3787#issuecomment-798931154 ping @Firstsawyou This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1591: fix: fix CYPRESS cross platform env error

2021-03-14 Thread GitBox
juzhiyuan commented on a change in pull request #1591: URL: https://github.com/apache/apisix-dashboard/pull/1591#discussion_r593920864 ## File path: web/package.json ## @@ -29,9 +29,9 @@ "start:test": "cross-env REACT_APP_ENV=test MOCK=none umi dev", "test:component":

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1591: fix: fix CYPRESS cross platform env error

2021-03-14 Thread GitBox
juzhiyuan commented on a change in pull request #1591: URL: https://github.com/apache/apisix-dashboard/pull/1591#discussion_r593920843 ## File path: web/package.json ## @@ -29,9 +29,9 @@ "start:test": "cross-env REACT_APP_ENV=test MOCK=none umi dev", "test:component":

[GitHub] [apisix] membphis commented on issue #3732: bug: plugin ip-restriction cannot work on HTTPS

2021-03-14 Thread GitBox
membphis commented on issue #3732: URL: https://github.com/apache/apisix/issues/3732#issuecomment-798930218 ping @chenyicai This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1554: bug: 通过API创建的upstream和route,在dashboard的route详情页面中显示不完整

2021-03-14 Thread GitBox
juzhiyuan commented on issue #1554: URL: https://github.com/apache/apisix-dashboard/issues/1554#issuecomment-798930164 I remember @guoqqqi has been checking on this issue, what's your feedback? This is an automated message f

[GitHub] [apisix] membphis commented on issue #3673: request help: A node in the K8S environment ETCD cluster died, causing Apisix to fail

2021-03-14 Thread GitBox
membphis commented on issue #3673: URL: https://github.com/apache/apisix/issues/3673#issuecomment-798930161 ping @Yiyiyimu This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix-dashboard] membphis commented on pull request #1583: fest: rewrite e2e test(route_import_test) with ginkgo

2021-03-14 Thread GitBox
membphis commented on pull request #1583: URL: https://github.com/apache/apisix-dashboard/pull/1583#issuecomment-798928940 @bisakhmondal ci failed This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [apisix-dashboard] membphis commented on pull request #1558: feat:Support duplicate one existing Route

2021-03-14 Thread GitBox
membphis commented on pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-798928415 ping @LiteSun This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [apisix-dashboard] membphis commented on pull request #1490: feat: support yaml to config plugin in plugin config page

2021-03-14 Thread GitBox
membphis commented on pull request #1490: URL: https://github.com/apache/apisix-dashboard/pull/1490#issuecomment-798928256 ping @LiteSun This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [apisix-dashboard] membphis commented on issue #1554: bug: 通过API创建的upstream和route,在dashboard的route详情页面中显示不完整

2021-03-14 Thread GitBox
membphis commented on issue #1554: URL: https://github.com/apache/apisix-dashboard/issues/1554#issuecomment-798928119 any news? @juzhiyuan @guoqqqi This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix-dashboard] membphis commented on issue #1512: Plugin template configuration

2021-03-14 Thread GitBox
membphis commented on issue #1512: URL: https://github.com/apache/apisix-dashboard/issues/1512#issuecomment-798928006 @litesun can we close this issue now? This is an automated message from the Apache Git Service. To respond

  1   2   >