[GitHub] [apisix-helm-chart] KishaniKandasamy commented on issue #56: Duplicate titles appear in the website

2021-04-12 Thread GitBox
KishaniKandasamy commented on issue #56: URL: https://github.com/apache/apisix-helm-chart/issues/56#issuecomment-818459343 > Hi, does this title removed from original markdown file content? #57 -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1733: feat: added cors plugin form

2021-04-12 Thread GitBox
netlify[bot] edited a comment on pull request #1733: URL: https://github.com/apache/apisix-dashboard/pull/1733#issuecomment-817283838 Deploy preview for *apisix-dashboard* processing. Building with commit f16001d32a5266d8e0112ccace094add4bed5d9d

[GitHub] [apisix-helm-chart] juzhiyuan commented on issue #56: Duplicate titles appear in the website

2021-04-12 Thread GitBox
juzhiyuan commented on issue #56: URL: https://github.com/apache/apisix-helm-chart/issues/56#issuecomment-818457758 Hi, does this title removed from original markdown file content? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix] Yiyiyimu commented on pull request #4029: ci: more retry on fetching lua rocks

2021-04-12 Thread GitBox
Yiyiyimu commented on pull request #4029: URL: https://github.com/apache/apisix/pull/4029#issuecomment-818456531 Add retry for all places, re-run for three times and all passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix-helm-chart] KishaniKandasamy commented on issue #56: Duplicate titles appear in the website

2021-04-12 Thread GitBox
KishaniKandasamy commented on issue #56: URL: https://github.com/apache/apisix-helm-chart/issues/56#issuecomment-818455660 Hi , even the commit was merged it still shows the same(like Duplicate titles ) as before樂 @juzhiyuan @tokers @membphis ![Screenshot

[GitHub] [apisix-dashboard] stu01509 commented on pull request #1633: feat: add the service page upstream select option

2021-04-12 Thread GitBox
stu01509 commented on pull request #1633: URL: https://github.com/apache/apisix-dashboard/pull/1633#issuecomment-818450332 Ok, I will solve it later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix] Firstsawyou commented on a change in pull request #4034: feat: support client certificate verification

2021-04-12 Thread GitBox
Firstsawyou commented on a change in pull request #4034: URL: https://github.com/apache/apisix/pull/4034#discussion_r612141003 ## File path: docs/en/latest/admin-api.md ## @@ -784,6 +784,8 @@ Return response from etcd currently. | key | True | Private key

[GitHub] [apisix] spacewander commented on issue #3260: request help: how support cas?

2021-04-12 Thread GitBox
spacewander commented on issue #3260: URL: https://github.com/apache/apisix/issues/3260#issuecomment-818442795 The CAS seems to use standard protocols like JWT and OpenID-Connect Maybe we can integrate with it via plugins:

[GitHub] [apisix] spacewander commented on a change in pull request #4034: feat: support client certificate verification

2021-04-12 Thread GitBox
spacewander commented on a change in pull request #4034: URL: https://github.com/apache/apisix/pull/4034#discussion_r612134869 ## File path: t/node/client-mtls.t ## @@ -0,0 +1,310 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor

[GitHub] [apisix] spacewander commented on a change in pull request #4034: feat: support client certificate verification

2021-04-12 Thread GitBox
spacewander commented on a change in pull request #4034: URL: https://github.com/apache/apisix/pull/4034#discussion_r612134431 ## File path: docs/en/latest/admin-api.md ## @@ -784,6 +784,8 @@ Return response from etcd currently. | key | True | Private key

[GitHub] [apisix-ingress-controller] tokers edited a comment on issue #356: request help: KubeSphere setup

2021-04-12 Thread GitBox
tokers edited a comment on issue #356: URL: https://github.com/apache/apisix-ingress-controller/issues/356#issuecomment-818440741 I found these routes were created by apisix-dashboard, just do not mix the use of apisix-ingress-controller and manual configurations from apisix-dashboard.

[GitHub] [apisix-ingress-controller] tokers commented on issue #356: request help: KubeSphere setup

2021-04-12 Thread GitBox
tokers commented on issue #356: URL: https://github.com/apache/apisix-ingress-controller/issues/356#issuecomment-818440741 I found these routes were created by apisix-dashboard, just do not mix the use of apisix-ingress-controller and manual dashboard confiugration. -- This is an

[GitHub] [apisix-ingress-controller] tokers commented on issue #356: request help: KubeSphere setup

2021-04-12 Thread GitBox
tokers commented on issue #356: URL: https://github.com/apache/apisix-ingress-controller/issues/356#issuecomment-818440525 It seems that there are some other routes in your APISIX cluster? How are they created? -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [apisix-helm-chart] tokers commented on pull request #60: feat: add namespace support for apisix-dashboard when using helm

2021-04-12 Thread GitBox
tokers commented on pull request #60: URL: https://github.com/apache/apisix-helm-chart/pull/60#issuecomment-818437903 @totemofwolf Please also update the chart version in `Chart.yaml`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [apisix] tokers commented on a change in pull request #4034: feat: support client certificate verification

2021-04-12 Thread GitBox
tokers commented on a change in pull request #4034: URL: https://github.com/apache/apisix/pull/4034#discussion_r612131312 ## File path: apisix/admin/ssl.lua ## @@ -70,6 +70,17 @@ local function check_conf(id, conf, need_id) end end +if conf.client then +

[GitHub] [apisix] tokers commented on a change in pull request #4034: feat: support client certificate verification

2021-04-12 Thread GitBox
tokers commented on a change in pull request #4034: URL: https://github.com/apache/apisix/pull/4034#discussion_r612131210 ## File path: apisix/schema_def.lua ## @@ -642,6 +642,18 @@ _M.ssl = { type = "array", items = private_key_schema, }, +

[GitHub] [apisix-helm-chart] tokers opened a new pull request #61: doc: update readme

2021-04-12 Thread GitBox
tokers opened a new pull request #61: URL: https://github.com/apache/apisix-helm-chart/pull/61 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [apisix-helm-chart] tokers merged pull request #59: feat: add new configs for ingress

2021-04-12 Thread GitBox
tokers merged pull request #59: URL: https://github.com/apache/apisix-helm-chart/pull/59 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[apisix-helm-chart] branch master updated: feat: add new configs for ingress (#59)

2021-04-12 Thread tokers
This is an automated email from the ASF dual-hosted git repository. tokers pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-helm-chart.git The following commit(s) were added to refs/heads/master by this push: new 6a27910 feat: add new configs for

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1730: feat: add api-breaker plugin form

2021-04-12 Thread GitBox
juzhiyuan commented on a change in pull request #1730: URL: https://github.com/apache/apisix-dashboard/pull/1730#discussion_r612123162 ## File path: web/src/components/Plugin/locales/zh-CN.ts ## @@ -29,6 +29,12 @@ export default {

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1730: feat: add api-breaker plugin form

2021-04-12 Thread GitBox
nic-chen commented on a change in pull request #1730: URL: https://github.com/apache/apisix-dashboard/pull/1730#discussion_r612122819 ## File path: web/src/components/Plugin/locales/zh-CN.ts ## @@ -29,6 +29,12 @@ export default {

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1761: fix: online debug test case

2021-04-12 Thread GitBox
codecov-io commented on pull request #1761: URL: https://github.com/apache/apisix-dashboard/pull/1761#issuecomment-818427037 #

[GitHub] [apisix-dashboard] nic-chen commented on issue #1706: security: support HTTPS for dashboard

2021-04-12 Thread GitBox
nic-chen commented on issue #1706: URL: https://github.com/apache/apisix-dashboard/issues/1706#issuecomment-818426644 sure. here is the discussion thread: https://lists.apache.org/thread.html/r082c75e50b3c2445a4e15c012a267ea1f4844f2dac5ab02fa6508a41%40%3Cdev.apisix.apache.org%3E

[GitHub] [apisix] Firstsawyou commented on a change in pull request #4034: feat: support client certificate verification

2021-04-12 Thread GitBox
Firstsawyou commented on a change in pull request #4034: URL: https://github.com/apache/apisix/pull/4034#discussion_r612110910 ## File path: docs/en/latest/admin-api.md ## @@ -784,6 +784,8 @@ Return response from etcd currently. | key | True | Private key

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1732: feat: added limit-req plugin form

2021-04-12 Thread GitBox
netlify[bot] edited a comment on pull request #1732: URL: https://github.com/apache/apisix-dashboard/pull/1732#issuecomment-817284488 Deploy preview for *apisix-dashboard* ready! Built with commit c8cdac674ba05e5108abd6ff499b280d5092d6fd

[GitHub] [apisix] bfcx opened a new issue #4037: [discuss]: keep backward compatibility of apisix admin api or manager api

2021-04-12 Thread GitBox
bfcx opened a new issue #4037: URL: https://github.com/apache/apisix/issues/4037 When upgrading APISIX form v1.5 to v2.4, I find that the response body of admin api in APISIX2.4 are not keep compatibility with that in v1.5. In APISIX 1.5, config restored by etcd v2, response body

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1732: feat: added limit-req plugin form

2021-04-12 Thread GitBox
netlify[bot] edited a comment on pull request #1732: URL: https://github.com/apache/apisix-dashboard/pull/1732#issuecomment-817284488 Deploy preview for *apisix-dashboard* processing. Building with commit c8cdac674ba05e5108abd6ff499b280d5092d6fd

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1732: feat: added limit-req plugin form

2021-04-12 Thread GitBox
netlify[bot] edited a comment on pull request #1732: URL: https://github.com/apache/apisix-dashboard/pull/1732#issuecomment-817284488 Deploy preview for *apisix-dashboard* ready! Built with commit b722526f5f005ab40b1a025abbf9b86401056743

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1732: feat: added limit-req plugin form

2021-04-12 Thread GitBox
netlify[bot] edited a comment on pull request #1732: URL: https://github.com/apache/apisix-dashboard/pull/1732#issuecomment-817284488 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1732: feat: added limit-req plugin form

2021-04-12 Thread GitBox
netlify[bot] edited a comment on pull request #1732: URL: https://github.com/apache/apisix-dashboard/pull/1732#issuecomment-817284488 Deploy preview for *apisix-dashboard* processing. Building with commit 9461c24242ca8102a20a6e15c323798b5c55616b

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1748: chore: update Consumer

2021-04-12 Thread GitBox
netlify[bot] edited a comment on pull request #1748: URL: https://github.com/apache/apisix-dashboard/pull/1748#issuecomment-817897362 Deploy preview for *apisix-dashboard* ready! Built with commit 180aae7e2c1fcb9266ffa862c1d7df3957db15ef

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1730: feat: add api-breaker plugin form

2021-04-12 Thread GitBox
netlify[bot] edited a comment on pull request #1730: URL: https://github.com/apache/apisix-dashboard/pull/1730#issuecomment-817653772 Deploy preview for *apisix-dashboard* ready! Built with commit 40724664d2b55e5f6a61d8340707e2c99c6e6a45

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1727: feat: add referer-restriction plugin form

2021-04-12 Thread GitBox
codecov-io edited a comment on pull request #1727: URL: https://github.com/apache/apisix-dashboard/pull/1727#issuecomment-817269980 #

[apisix-dashboard] branch master updated: fix: null value instead of empty slice during JSON marshalling for GET labels (#1741)

2021-04-12 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new 537b4ff fix: null value instead

[GitHub] [apisix-dashboard] juzhiyuan closed issue #1737: Bug: the row field is nil when request to get the label list

2021-04-12 Thread GitBox
juzhiyuan closed issue #1737: URL: https://github.com/apache/apisix-dashboard/issues/1737 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1741: fix: null value instead of empty slice during JSON marshalling for GET labels

2021-04-12 Thread GitBox
juzhiyuan merged pull request #1741: URL: https://github.com/apache/apisix-dashboard/pull/1741 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1610: feat: improve the config plugin button enable disable status

2021-04-12 Thread GitBox
juzhiyuan commented on pull request #1610: URL: https://github.com/apache/apisix-dashboard/pull/1610#issuecomment-818404052 ping @liuxiran @bzp2010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [apisix] riskgod commented on issue #4036: request help: hmac sha256 "Invalid signature"

2021-04-12 Thread GitBox
riskgod commented on issue #4036: URL: https://github.com/apache/apisix/issues/4036#issuecomment-818403800 > > -H "Tue Apr 13 2021 09:56:35 GMT+0800 (China Standard Time)" \ > > In the plug-in test, the format of your GMT time request header seems to be incorrect, it needs to be

[GitHub] [apisix] riskgod closed issue #4036: request help: hmac sha256 "Invalid signature"

2021-04-12 Thread GitBox
riskgod closed issue #4036: URL: https://github.com/apache/apisix/issues/4036 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1748: chore: update Consumer

2021-04-12 Thread GitBox
juzhiyuan commented on a change in pull request #1748: URL: https://github.com/apache/apisix-dashboard/pull/1748#discussion_r612100751 ## File path: web/src/pages/Consumer/locales/zh-CN.ts ## @@ -20,6 +20,10 @@ export default {

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1748: chore: update Consumer

2021-04-12 Thread GitBox
netlify[bot] edited a comment on pull request #1748: URL: https://github.com/apache/apisix-dashboard/pull/1748#issuecomment-817897362 Deploy preview for *apisix-dashboard* processing. Building with commit 180aae7e2c1fcb9266ffa862c1d7df3957db15ef

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1730: feat: add api-breaker plugin form

2021-04-12 Thread GitBox
netlify[bot] edited a comment on pull request #1730: URL: https://github.com/apache/apisix-dashboard/pull/1730#issuecomment-817653772 Deploy preview for *apisix-dashboard* processing. Building with commit 40724664d2b55e5f6a61d8340707e2c99c6e6a45

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1748: chore: update Consumer

2021-04-12 Thread GitBox
starsz commented on a change in pull request #1748: URL: https://github.com/apache/apisix-dashboard/pull/1748#discussion_r612099802 ## File path: web/src/pages/Consumer/locales/zh-CN.ts ## @@ -20,6 +20,10 @@ export default { 'page.consumer.form.itemExtraMessage.username':

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1727: feat: add referer-restriction plugin form

2021-04-12 Thread GitBox
codecov-io edited a comment on pull request #1727: URL: https://github.com/apache/apisix-dashboard/pull/1727#issuecomment-817269980 #

[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #363: test: add e2e test cases for request-validation plugin

2021-04-12 Thread GitBox
codecov-io commented on pull request #363: URL: https://github.com/apache/apisix-ingress-controller/pull/363#issuecomment-818401478 #

[apisix-dashboard] branch master updated: chore: added fields for SSL (#1751)

2021-04-12 Thread starsz
This is an automated email from the ASF dual-hosted git repository. starsz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new 62e94af chore: added fields for SSL

[GitHub] [apisix-dashboard] starsz merged pull request #1751: chore: added fields for SSL

2021-04-12 Thread GitBox
starsz merged pull request #1751: URL: https://github.com/apache/apisix-dashboard/pull/1751 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [apisix-helm-chart] totemofwolf opened a new pull request #60: feat: add namespace support for apisix-dashboard when using helm

2021-04-12 Thread GitBox
totemofwolf opened a new pull request #60: URL: https://github.com/apache/apisix-helm-chart/pull/60 ``` # debug $ helm install --debug --name apisix-dashboard . --namespace edge --dry-run > /tmp/apisix-dashboard.sh ``` -- This is an automated message from the Apache Git

[GitHub] [apisix-dashboard] starsz commented on pull request #1758: chore: remove service worker

2021-04-12 Thread GitBox
starsz commented on pull request #1758: URL: https://github.com/apache/apisix-dashboard/pull/1758#issuecomment-818400468 Fix: https://github.com/apache/apisix-dashboard/security/code-scanning/5?query=ref%3Arefs%2Fheads%2Fmaster

[GitHub] [apisix-ingress-controller] tokers merged pull request #361: chore: controller tree

2021-04-12 Thread GitBox
tokers merged pull request #361: URL: https://github.com/apache/apisix-ingress-controller/pull/361 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[apisix-ingress-controller] branch master updated: chore: controller tree (#361)

2021-04-12 Thread tokers
This is an automated email from the ASF dual-hosted git repository. tokers pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git The following commit(s) were added to refs/heads/master by this push: new 2dd7f14 chore: controller

[GitHub] [apisix-ingress-controller] tokers opened a new pull request #363: test: add e2e test cases for request-validation plugin

2021-04-12 Thread GitBox
tokers opened a new pull request #363: URL: https://github.com/apache/apisix-ingress-controller/pull/363 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ]

[GitHub] [apisix] Firstsawyou commented on issue #4036: request help: hmac sha256 "Invalid signature"

2021-04-12 Thread GitBox
Firstsawyou commented on issue #4036: URL: https://github.com/apache/apisix/issues/4036#issuecomment-818399987 > -H "Tue Apr 13 2021 09:56:35 GMT+0800 (China Standard Time)" \ In the plug-in test, the format of your GMT time request header seems to be incorrect, it needs to be like

[GitHub] [apisix] jbampton commented on issue #3587: docs: add Spanish translations

2021-04-12 Thread GitBox
jbampton commented on issue #3587: URL: https://github.com/apache/apisix/issues/3587#issuecomment-818397330 Hello everyone. A very sad day has come and our dear friend Jorge @summerhill5 has died of COVID-19 in Venezuela. Jorge died in hospital and was sick for over 3

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1730: feat: add api-breaker plugin form

2021-04-12 Thread GitBox
juzhiyuan commented on a change in pull request #1730: URL: https://github.com/apache/apisix-dashboard/pull/1730#discussion_r612095039 ## File path: web/src/components/Plugin/locales/zh-CN.ts ## @@ -29,6 +29,12 @@ export default {

[GitHub] [apisix-website] juzhiyuan commented on issue #156: https for website

2021-04-12 Thread GitBox
juzhiyuan commented on issue #156: URL: https://github.com/apache/apisix-website/issues/156#issuecomment-818396905  Apache Infra uses asf-site branch as HTML branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [apisix-helm-chart] tokers opened a new pull request #59: feat: add new configs for ingress

2021-04-12 Thread GitBox
tokers opened a new pull request #59: URL: https://github.com/apache/apisix-helm-chart/pull/59 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1762: chore: reduce CI time

2021-04-12 Thread GitBox
netlify[bot] edited a comment on pull request #1762: URL: https://github.com/apache/apisix-dashboard/pull/1762#issuecomment-818367527 Deploy preview for *apisix-dashboard* ready! Built with commit cea8de0381f0645ba2625496e003dafdb84946c2

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1730: feat: add api-breaker plugin form

2021-04-12 Thread GitBox
netlify[bot] edited a comment on pull request #1730: URL: https://github.com/apache/apisix-dashboard/pull/1730#issuecomment-817653772 Deploy preview for *apisix-dashboard* ready! Built with commit c542e14bf0cec175b2c894d6941ffc354931cbb4

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1761: fix: online debug test case

2021-04-12 Thread GitBox
netlify[bot] edited a comment on pull request #1761: URL: https://github.com/apache/apisix-dashboard/pull/1761#issuecomment-818361132 Deploy preview for *apisix-dashboard* ready! Built with commit c5a746bd6b63e61f61f6142d2f714b7206ff4c54

[GitHub] [apisix-ingress-controller] wjx8382 commented on issue #356: request help: KubeSphere setup

2021-04-12 Thread GitBox
wjx8382 commented on issue #356: URL: https://github.com/apache/apisix-ingress-controller/issues/356#issuecomment-818391921 > > @tokers Why does `kubectl exec -it -n tools apisix-7987b5b7f-tmrk7 -- curl http://127.0.0.1:9080/headers -H 'Host: local.httpbin.org'` returns

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1762: chore: reduce CI time

2021-04-12 Thread GitBox
netlify[bot] edited a comment on pull request #1762: URL: https://github.com/apache/apisix-dashboard/pull/1762#issuecomment-818367527 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1730: feat: add api-breaker plugin form

2021-04-12 Thread GitBox
netlify[bot] edited a comment on pull request #1730: URL: https://github.com/apache/apisix-dashboard/pull/1730#issuecomment-817653772 Deploy preview for *apisix-dashboard* processing. Building with commit c542e14bf0cec175b2c894d6941ffc354931cbb4

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1727: feat: add referer-restriction plugin form

2021-04-12 Thread GitBox
netlify[bot] edited a comment on pull request #1727: URL: https://github.com/apache/apisix-dashboard/pull/1727#issuecomment-817649660 Deploy preview for *apisix-dashboard* ready! Built with commit 308d4d67b97deff5c348599cc73ebf00dbca9d3a

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1762: chore: reduce CI time

2021-04-12 Thread GitBox
juzhiyuan commented on pull request #1762: URL: https://github.com/apache/apisix-dashboard/pull/1762#issuecomment-818389575 wait for #1761 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix] riskgod opened a new issue #4036: request help: hmac sha256 "Invalid signature"

2021-04-12 Thread GitBox
riskgod opened a new issue #4036: URL: https://github.com/apache/apisix/issues/4036 ### Issue description hey, I am using node to create the X-HMAC-SIGNATURE, but it always return "Invalid signature" create one consumer ``` curl

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1761: fix: online debug test case

2021-04-12 Thread GitBox
netlify[bot] edited a comment on pull request #1761: URL: https://github.com/apache/apisix-dashboard/pull/1761#issuecomment-818361132 Deploy preview for *apisix-dashboard* processing. Building with commit c5a746bd6b63e61f61f6142d2f714b7206ff4c54

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1762: chore: reduce CI time

2021-04-12 Thread GitBox
netlify[bot] edited a comment on pull request #1762: URL: https://github.com/apache/apisix-dashboard/pull/1762#issuecomment-818367527 Deploy preview for *apisix-dashboard* processing. Building with commit a858d33361277c83f12571fe6ffbee4f54128a34

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1727: feat: add referer-restriction plugin form

2021-04-12 Thread GitBox
netlify[bot] edited a comment on pull request #1727: URL: https://github.com/apache/apisix-dashboard/pull/1727#issuecomment-817649660 Deploy preview for *apisix-dashboard* processing. Building with commit 308d4d67b97deff5c348599cc73ebf00dbca9d3a

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1762: chore: reduce CI time

2021-04-12 Thread GitBox
codecov-io commented on pull request #1762: URL: https://github.com/apache/apisix-dashboard/pull/1762#issuecomment-818385237 #

[GitHub] [apisix-ingress-controller] wjx8382 commented on issue #356: request help: KubeSphere setup

2021-04-12 Thread GitBox
wjx8382 commented on issue #356: URL: https://github.com/apache/apisix-ingress-controller/issues/356#issuecomment-818384772 > > @tokers Why does `kubectl exec -it -n tools apisix-7987b5b7f-tmrk7 -- curl http://127.0.0.1:9080/headers -H 'Host: local.httpbin.org'` returns

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1661: feat: add scheme field test case

2021-04-12 Thread GitBox
codecov-io edited a comment on pull request #1661: URL: https://github.com/apache/apisix-dashboard/pull/1661#issuecomment-805419276 #

[GitHub] [apisix-ingress-controller] tokers commented on issue #356: request help: KubeSphere setup

2021-04-12 Thread GitBox
tokers commented on issue #356: URL: https://github.com/apache/apisix-ingress-controller/issues/356#issuecomment-818383744 > @tokers Why does `kubectl exec -it -n tools apisix-7987b5b7f-tmrk7 -- curl http://127.0.0.1:9080/headers -H 'Host: local.httpbin.org'` returns `{"error_msg":"404

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1661: feat: add scheme field test case

2021-04-12 Thread GitBox
codecov-io edited a comment on pull request #1661: URL: https://github.com/apache/apisix-dashboard/pull/1661#issuecomment-805419276 #

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1661: feat: add scheme field test case

2021-04-12 Thread GitBox
codecov-io edited a comment on pull request #1661: URL: https://github.com/apache/apisix-dashboard/pull/1661#issuecomment-805419276 #

[GitHub] [apisix-ingress-controller] wjx8382 commented on issue #356: request help: KubeSphere setup

2021-04-12 Thread GitBox
wjx8382 commented on issue #356: URL: https://github.com/apache/apisix-ingress-controller/issues/356#issuecomment-818383007 @tokers Why does `kubectl exec -it -n tools apisix-7987b5b7f-tmrk7 -- curl http://127.0.0.1:9080/headers -H 'Host: local.httpbin.org'` returns `{"error_msg":"404

[GitHub] [apisix-ingress-controller] tokers commented on issue #324: bug: secret controller doesn't update ApisixTls but just re-push the old one

2021-04-12 Thread GitBox
tokers commented on issue #324: URL: https://github.com/apache/apisix-ingress-controller/issues/324#issuecomment-818377821 Fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [apisix-ingress-controller] tokers closed issue #324: bug: secret controller doesn't update ApisixTls but just re-push the old one

2021-04-12 Thread GitBox
tokers closed issue #324: URL: https://github.com/apache/apisix-ingress-controller/issues/324 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [apisix] spacewander commented on a change in pull request #4034: feat: support client certificate verification

2021-04-12 Thread GitBox
spacewander commented on a change in pull request #4034: URL: https://github.com/apache/apisix/pull/4034#discussion_r612076873 ## File path: apisix/admin/ssl.lua ## @@ -70,6 +70,17 @@ local function check_conf(id, conf, need_id) end end +if conf.client then

[GitHub] [apisix-website] Yiyiyimu commented on issue #156: https for website

2021-04-12 Thread GitBox
Yiyiyimu commented on issue #156: URL: https://github.com/apache/apisix-website/issues/156#issuecomment-818376580 My bad.. I noticed Github Page on the front page of the repo, but it seems two years ago when it got deployed last time 藍

[GitHub] [apisix] spacewander commented on a change in pull request #4034: feat: support client certificate verification

2021-04-12 Thread GitBox
spacewander commented on a change in pull request #4034: URL: https://github.com/apache/apisix/pull/4034#discussion_r612075931 ## File path: apisix/schema_def.lua ## @@ -642,6 +642,18 @@ _M.ssl = { type = "array", items = private_key_schema,

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1727: feat: add referer-restriction plugin form

2021-04-12 Thread GitBox
netlify[bot] edited a comment on pull request #1727: URL: https://github.com/apache/apisix-dashboard/pull/1727#issuecomment-817649660 Deploy preview for *apisix-dashboard* ready! Built with commit d0d70a6806731d70721a8f6893a50607ad3918c8

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1661: feat: add scheme field test case

2021-04-12 Thread GitBox
netlify[bot] edited a comment on pull request #1661: URL: https://github.com/apache/apisix-dashboard/pull/1661#issuecomment-818307502 Deploy preview for *apisix-dashboard* ready! Built with commit ec569b19fb0e6b8ddc0cabc357202fe3a6c88973

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1727: feat: add referer-restriction plugin form

2021-04-12 Thread GitBox
netlify[bot] edited a comment on pull request #1727: URL: https://github.com/apache/apisix-dashboard/pull/1727#issuecomment-817649660 Deploy preview for *apisix-dashboard* processing. Building with commit d0d70a6806731d70721a8f6893a50607ad3918c8

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1762: chore: reduce CI time

2021-04-12 Thread GitBox
netlify[bot] edited a comment on pull request #1762: URL: https://github.com/apache/apisix-dashboard/pull/1762#issuecomment-818367527 Deploy preview for *apisix-dashboard* ready! Built with commit 56c4d3d69abfa8a664eb5f830596ae6413c5de38

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1710: feat: duplicate upstream service consumer

2021-04-12 Thread GitBox
netlify[bot] edited a comment on pull request #1710: URL: https://github.com/apache/apisix-dashboard/pull/1710#issuecomment-818368730 Deploy preview for *apisix-dashboard* ready! Built with commit 5bde2d483d7d7c183cf99c26471615066511e440

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1661: feat: add scheme field test case

2021-04-12 Thread GitBox
netlify[bot] edited a comment on pull request #1661: URL: https://github.com/apache/apisix-dashboard/pull/1661#issuecomment-818307502 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1762: chore: reduce CI time

2021-04-12 Thread GitBox
juzhiyuan commented on a change in pull request #1762: URL: https://github.com/apache/apisix-dashboard/pull/1762#discussion_r612069815 ## File path: .github/workflows/markdown-link-checker.yml ## @@ -1,14 +0,0 @@ -name: Check markdown links Review comment: See this

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1762: chore: reduce CI time

2021-04-12 Thread GitBox
juzhiyuan commented on a change in pull request #1762: URL: https://github.com/apache/apisix-dashboard/pull/1762#discussion_r612069617 ## File path: .github/workflows/markdown-link-checker.yml ## @@ -1,14 +0,0 @@ -name: Check markdown links Review comment: yes, because

[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1762: chore: reduce CI time

2021-04-12 Thread GitBox
nic-chen commented on a change in pull request #1762: URL: https://github.com/apache/apisix-dashboard/pull/1762#discussion_r612069390 ## File path: .github/workflows/markdown-link-checker.yml ## @@ -1,14 +0,0 @@ -name: Check markdown links Review comment: we don't need

[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1710: feat: duplicate upstream service consumer

2021-04-12 Thread GitBox
netlify[bot] commented on pull request #1710: URL: https://github.com/apache/apisix-dashboard/pull/1710#issuecomment-818368730 Deploy preview for *apisix-dashboard* processing. Building with commit 5bde2d483d7d7c183cf99c26471615066511e440

[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1762: chore: reduce CI time

2021-04-12 Thread GitBox
netlify[bot] commented on pull request #1762: URL: https://github.com/apache/apisix-dashboard/pull/1762#issuecomment-818367527 Deploy preview for *apisix-dashboard* processing. Building with commit 56c4d3d69abfa8a664eb5f830596ae6413c5de38

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1661: feat: add scheme field test case

2021-04-12 Thread GitBox
netlify[bot] edited a comment on pull request #1661: URL: https://github.com/apache/apisix-dashboard/pull/1661#issuecomment-818307502 Deploy preview for *apisix-dashboard* processing. Building with commit 26afa8dba021aeddac8782af44884c87f200d0ff

[GitHub] [apisix-dashboard] juzhiyuan opened a new pull request #1762: chore: reduce CI time

2021-04-12 Thread GitBox
juzhiyuan opened a new pull request #1762: URL: https://github.com/apache/apisix-dashboard/pull/1762 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [ ] Bugfix - [ ] New feature provided

[GitHub] [apisix] spacewander commented on pull request #4026: ci: cache deps

2021-04-12 Thread GitBox
spacewander commented on pull request #4026: URL: https://github.com/apache/apisix/pull/4026#issuecomment-818366833 Look like something wrong is cached? https://github.com/apache/apisix/pull/4026/checks?check_run_id=2329191183 -- This is an automated message from the Apache Git

[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #1725: feat: add proxy-mirror plugin form

2021-04-12 Thread GitBox
LiteSun commented on a change in pull request #1725: URL: https://github.com/apache/apisix-dashboard/pull/1725#discussion_r612067202 ## File path: web/src/components/Plugin/locales/zh-CN.ts ## @@ -21,4 +21,7 @@ export default {

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1740: feat: Added fault-injection plugin form

2021-04-12 Thread GitBox
netlify[bot] edited a comment on pull request #1740: URL: https://github.com/apache/apisix-dashboard/pull/1740#issuecomment-817315630 Deploy preview for *apisix-dashboard* ready! Built with commit 1bb8b879b44362f5a351dabe78255830d3fa6c17

[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1761: fix: online debug test case

2021-04-12 Thread GitBox
netlify[bot] edited a comment on pull request #1761: URL: https://github.com/apache/apisix-dashboard/pull/1761#issuecomment-818361132 Deploy preview for *apisix-dashboard* ready! Built with commit 66d21c8fa2c75fabd6d6bde78cac1d91534d6f8c

[GitHub] [apisix-dashboard] Firstsawyou edited a comment on issue #1759: default login page return 404 when using APISIX for http/https proxy

2021-04-12 Thread GitBox
Firstsawyou edited a comment on issue #1759: URL: https://github.com/apache/apisix-dashboard/issues/1759#issuecomment-818361900 > It works. I am wondering why should this happen...? Port conflict or? Because Dashboard access needs to occupy the port of `/apisix/admin/xxx`, and on

[GitHub] [apisix-dashboard] guoqqqi commented on a change in pull request #1733: feat: added cors plugin form

2021-04-12 Thread GitBox
guoqqqi commented on a change in pull request #1733: URL: https://github.com/apache/apisix-dashboard/pull/1733#discussion_r612054702 ## File path: web/src/components/Plugin/locales/en-US.ts ## @@ -21,6 +21,19 @@ export default {

  1   2   3   4   >