[GitHub] [apisix-dashboard] nimohunter commented on a change in pull request #2247: update the kin-openapi to v0.86.0

2021-12-16 Thread GitBox
nimohunter commented on a change in pull request #2247: URL: https://github.com/apache/apisix-dashboard/pull/2247#discussion_r771164853 ## File path: api/internal/handler/data_loader/route_import.go ## @@ -147,7 +147,7 @@ func (h *ImportHandler) Import(c droplet.Context) (inte

[GitHub] [apisix] shuaijinchao commented on a change in pull request #5839: fix(google-cloud-logging): move ssl_verify to plugin configuration top level

2021-12-16 Thread GitBox
shuaijinchao commented on a change in pull request #5839: URL: https://github.com/apache/apisix/pull/5839#discussion_r771161510 ## File path: apisix/plugins/google-cloud-logging.lua ## @@ -162,6 +163,7 @@ local function get_auth_config(config) end auth_config_cache

[GitHub] [apisix-dashboard] zaunist commented on issue #2252: When will GM SSL be supported

2021-12-16 Thread GitBox
zaunist commented on issue #2252: URL: https://github.com/apache/apisix-dashboard/issues/2252#issuecomment-996490618 Hi, @532810439 Could you please provide more info ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [apisix-dashboard] zaunist commented on pull request #2251: ci: remove push docker image to demo env

2021-12-16 Thread GitBox
zaunist commented on pull request #2251: URL: https://github.com/apache/apisix-dashboard/pull/2251#issuecomment-996489601 /LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

[GitHub] [apisix] leslie-tsang opened a new pull request #5848: fix(install-dependencies): the execution of the script should not be interrupted

2021-12-16 Thread GitBox
leslie-tsang opened a new pull request #5848: URL: https://github.com/apache/apisix/pull/5848 ### What this PR does / why we need it: The execution of `install-dependencies.sh` shouldn't be interrupted, add `-y` to fix it. ### Pre-submission checklist:

[GitHub] [apisix-dashboard] nic-chen commented on pull request #2251: ci: remove push docker image to demo env

2021-12-16 Thread GitBox
nic-chen commented on pull request #2251: URL: https://github.com/apache/apisix-dashboard/pull/2251#issuecomment-996484208 > If we delete the push step, the deploy-with-docker.yaml maybe delete together. Otherwise it doesn't make sense We still need to test Manager API under docker,

[GitHub] [apisix] Horus-K commented on issue #5847: request help: proxy_pass cannot use https

2021-12-16 Thread GitBox
Horus-K commented on issue #5847: URL: https://github.com/apache/apisix/issues/5847#issuecomment-996483968 i see this https://github.com/apache/apisix/issues/2257 but ret_code still not work ![image](https://user-images.githubusercontent.com/48319268/146503014-7d7c15f9-b70b-4f81-9b89-b

[GitHub] [apisix-dashboard] nic-chen commented on pull request #2251: ci: remove push docker image to demo env

2021-12-16 Thread GitBox
nic-chen commented on pull request #2251: URL: https://github.com/apache/apisix-dashboard/pull/2251#issuecomment-996483437 > Hi, may I know visitors how to use the manager-api? They can still use the demo site, but we no longer push to deploy each commit, but use the release image on

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #814: docs: add Istio with APISIX Ingress blog

2021-12-16 Thread GitBox
netlify[bot] edited a comment on pull request #814: URL: https://github.com/apache/apisix-website/pull/814#issuecomment-996461821 ✔️ Deploy Preview for *apache-apisix* ready! 🔨 Explore the source changes: 183bb43d2514b9f82f561f5feae21b65240ffab4 🔍 Inspect the deploy log: [

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #814: docs: add Istio with APISIX Ingress blog

2021-12-16 Thread GitBox
netlify[bot] edited a comment on pull request #814: URL: https://github.com/apache/apisix-website/pull/814#issuecomment-996461821 👷 Deploy Preview for *apache-apisix* processing. 🔨 Explore the source changes: 183bb43d2514b9f82f561f5feae21b65240ffab4 🔍 Inspect the deploy log

[GitHub] [apisix] shuaijinchao commented on a change in pull request #5819: feat(splunk): support splunk hec logging plugin

2021-12-16 Thread GitBox
shuaijinchao commented on a change in pull request #5819: URL: https://github.com/apache/apisix/pull/5819#discussion_r771114819 ## File path: apisix/plugins/splunk-hec-logging.lua ## @@ -0,0 +1,189 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-

[GitHub] [apisix-website] SylviaBABY commented on pull request #814: docs: add Istio with APISIX Ingress blog

2021-12-16 Thread GitBox
SylviaBABY commented on pull request #814: URL: https://github.com/apache/apisix-website/pull/814#issuecomment-996477588 @juzhiyuan @bzp2010 There is still a picture not put in, please do not merge it right now. I will inform you when it is all done. -- This is an automated message from

[GitHub] [apisix] Horus-K commented on issue #5847: request help: proxy_pass cannot use https

2021-12-16 Thread GitBox
Horus-K commented on issue #5847: URL: https://github.com/apache/apisix/issues/5847#issuecomment-996475958 I used ingress-nginx to start force https, return code 308, proxy_pass can use https On apisix, I used https forwarding and set ret_code 308. In the end, proxy_pass still redirecte

[GitHub] [apisix] GhangZh commented on issue #5708: request help: go-plugin-runner error after starting in debug mode

2021-12-16 Thread GitBox
GhangZh commented on issue #5708: URL: https://github.com/apache/apisix/issues/5708#issuecomment-996475209 > Bro, I also met the general problem, can you tell me how to solve it? Check that apisix config.yaml is correctly configured, the main reason for this error is that your config

[GitHub] [apisix] spacewander commented on a change in pull request #5839: fix(google-cloud-logging): move ssl_verify to plugin configuration top level

2021-12-16 Thread GitBox
spacewander commented on a change in pull request #5839: URL: https://github.com/apache/apisix/pull/5839#discussion_r771132235 ## File path: apisix/plugins/google-cloud-logging.lua ## @@ -162,6 +163,7 @@ local function get_auth_config(config) end auth_config_cache =

[GitHub] [apisix] Horus-K commented on issue #5847: request help: proxy_pass cannot use https

2021-12-16 Thread GitBox
Horus-K commented on issue #5847: URL: https://github.com/apache/apisix/issues/5847#issuecomment-996469750 If proxy_pass uses http, then the route cannot be enabled to force https, otherwise there will be too many 301 redirects -- This is an automated message from the Apache Git Service.

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #814: docs: add Istio with APISIX Ingress blog

2021-12-16 Thread GitBox
netlify[bot] edited a comment on pull request #814: URL: https://github.com/apache/apisix-website/pull/814#issuecomment-996461821 ✔️ Deploy Preview for *apache-apisix* ready! 🔨 Explore the source changes: 36f7538391be9830e9ab6fa76078240119627346 🔍 Inspect the deploy log: [

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #814: docs: add Istio with APISIX Ingress blog

2021-12-16 Thread GitBox
netlify[bot] edited a comment on pull request #814: URL: https://github.com/apache/apisix-website/pull/814#issuecomment-996461821 👷 Deploy Preview for *apache-apisix* processing. 🔨 Explore the source changes: 36f7538391be9830e9ab6fa76078240119627346 🔍 Inspect the deploy log

[GitHub] [apisix] shuaijinchao commented on a change in pull request #5819: feat(splunk): support splunk hec logging plugin

2021-12-16 Thread GitBox
shuaijinchao commented on a change in pull request #5819: URL: https://github.com/apache/apisix/pull/5819#discussion_r771114819 ## File path: apisix/plugins/splunk-hec-logging.lua ## @@ -0,0 +1,189 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #814: docs: add Istio with APISIX Ingress blog

2021-12-16 Thread GitBox
netlify[bot] edited a comment on pull request #814: URL: https://github.com/apache/apisix-website/pull/814#issuecomment-996461821 ✔️ Deploy Preview for *apache-apisix* ready! 🔨 Explore the source changes: 5dc1663ea1d7a1e7accc6c4d141311bd8c0e7d89 🔍 Inspect the deploy log: [

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #814: docs: add Istio with APISIX Ingress blog

2021-12-16 Thread GitBox
netlify[bot] edited a comment on pull request #814: URL: https://github.com/apache/apisix-website/pull/814#issuecomment-996461821 👷 Deploy Preview for *apache-apisix* processing. 🔨 Explore the source changes: 5dc1663ea1d7a1e7accc6c4d141311bd8c0e7d89 🔍 Inspect the deploy log

[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #814: docs: add Istio with APISIX Ingress blog

2021-12-16 Thread GitBox
netlify[bot] edited a comment on pull request #814: URL: https://github.com/apache/apisix-website/pull/814#issuecomment-996461821 ✔️ Deploy Preview for *apache-apisix* ready! 🔨 Explore the source changes: 7d1670149c3a617d844ad4115b4d87eb07767a14 🔍 Inspect the deploy log: [

[GitHub] [apisix] Horus-K opened a new issue #5847: request help: proxy_pass cannot use https

2021-12-16 Thread GitBox
Horus-K opened a new issue #5847: URL: https://github.com/apache/apisix/issues/5847 ### Issue description ![image](https://user-images.githubusercontent.com/48319268/146496223-e54e935b-82c2-4a5d-afc7-fdebc6f472d2.png) nginx returen 502 ![image](https://user-images.githubuserc

[GitHub] [apisix-website] netlify[bot] commented on pull request #814: docs: add Istio with APISIX Ingress blog

2021-12-16 Thread GitBox
netlify[bot] commented on pull request #814: URL: https://github.com/apache/apisix-website/pull/814#issuecomment-996461821 👷 Deploy Preview for *apache-apisix* processing. 🔨 Explore the source changes: 7d1670149c3a617d844ad4115b4d87eb07767a14 🔍 Inspect the deploy log: [htt

[GitHub] [apisix-website] SylviaBABY opened a new pull request #814: docs: add Istio with APISIX Ingress blog

2021-12-16 Thread GitBox
SylviaBABY opened a new pull request #814: URL: https://github.com/apache/apisix-website/pull/814 Changes: add Istio with APISIX Ingress blog -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [apisix-java-plugin-runner] tzssangglass commented on pull request #100: [WIP]refactor: switch from reactor-netty to netty, and support fetching var and body

2021-12-16 Thread GitBox
tzssangglass commented on pull request #100: URL: https://github.com/apache/apisix-java-plugin-runner/pull/100#issuecomment-996455128 @nic-6443 @dmsolr here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [apisix] shuaijinchao commented on a change in pull request #5819: feat(splunk): support splunk hec logging plugin

2021-12-16 Thread GitBox
shuaijinchao commented on a change in pull request #5819: URL: https://github.com/apache/apisix/pull/5819#discussion_r771114819 ## File path: apisix/plugins/splunk-hec-logging.lua ## @@ -0,0 +1,189 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-

[GitHub] [apisix] tzssangglass commented on a change in pull request #5793: docs: sync stream proxy Chinese version

2021-12-16 Thread GitBox
tzssangglass commented on a change in pull request #5793: URL: https://github.com/apache/apisix/pull/5793#discussion_r771114198 ## File path: docs/zh/latest/stream-proxy.md ## @@ -72,7 +72,11 @@ curl http://127.0.0.1:9080/apisix/admin/stream_routes/1 -H 'X-API-KEY: edd1c9f03

[GitHub] [apisix-java-plugin-runner] tzssangglass opened a new pull request #100: [WIP]refactor: switch from reactor-netty to netty, and support fetching var and body

2021-12-16 Thread GitBox
tzssangglass opened a new pull request #100: URL: https://github.com/apache/apisix-java-plugin-runner/pull/100 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance

[GitHub] [apisix] shuaijinchao commented on a change in pull request #5819: feat(splunk): support splunk hec logging plugin

2021-12-16 Thread GitBox
shuaijinchao commented on a change in pull request #5819: URL: https://github.com/apache/apisix/pull/5819#discussion_r771110588 ## File path: docs/en/latest/plugins/splunk-hec-logging.md ## @@ -0,0 +1,143 @@ +--- +title: splunk-hec-logging +--- + + + +## Summary + +- [**Name**]

[GitHub] [apisix] leslie-tsang commented on a change in pull request #5840: fix(core.log): log level need to be updated in some scenario

2021-12-16 Thread GitBox
leslie-tsang commented on a change in pull request #5840: URL: https://github.com/apache/apisix/pull/5840#discussion_r771108042 ## File path: apisix/core/log.lua ## @@ -42,17 +43,27 @@ local log_levels = { } -local cur_level = ngx.config.subsystem == "http" and -

[GitHub] [apisix] spacewander edited a comment on issue #953: request help: Any plan for supporting the SM1/SM2/SM3/SM4 cryptographic algorithm?

2021-12-16 Thread GitBox
spacewander edited a comment on issue #953: URL: https://github.com/apache/apisix/issues/953#issuecomment-996442219 For people who are interested in the GMSSL support feature: This task is in the TODO list but doesn't have a deadline. It looks like the modification of GMSSL has bee

[GitHub] [apisix] spacewander commented on issue #953: request help: Any plan for supporting the SM1/SM2/SM3/SM4 cryptographic algorithm?

2021-12-16 Thread GitBox
spacewander commented on issue #953: URL: https://github.com/apache/apisix/issues/953#issuecomment-996442219 For people who are interested in the GMSSL support feature: This task is in the TODO list but doesn't have a plan. It looks like the modification of GMSSL has been merged in

[GitHub] [apisix] spacewander commented on issue #5844: bug: When will GM SSL be supported

2021-12-16 Thread GitBox
spacewander commented on issue #5844: URL: https://github.com/apache/apisix/issues/5844#issuecomment-996438915 Let's move to https://github.com/apache/apisix/issues/953 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [apisix] spacewander closed issue #5844: bug: When will GM SSL be supported

2021-12-16 Thread GitBox
spacewander closed issue #5844: URL: https://github.com/apache/apisix/issues/5844 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-un

[GitHub] [apisix] spacewander commented on a change in pull request #5819: feat(splunk): support splunk hec logging plugin

2021-12-16 Thread GitBox
spacewander commented on a change in pull request #5819: URL: https://github.com/apache/apisix/pull/5819#discussion_r771086695 ## File path: apisix/plugins/splunk-hec-logging.lua ## @@ -0,0 +1,189 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +--

[GitHub] [apisix] spacewander edited a comment on pull request #5825: feat: upgrade luarocks to 3.8.0 which converts git:// to https://

2021-12-16 Thread GitBox
spacewander edited a comment on pull request #5825: URL: https://github.com/apache/apisix/pull/5825#issuecomment-996420133 The luarocks 2.x has been broken for a time. This PR just admitted it. In fact, it doesn't handle the new rockspec format and the dependency management which have b

[GitHub] [apisix] spacewander commented on a change in pull request #5840: fix(core.log): log level need to be updated in some scenario

2021-12-16 Thread GitBox
spacewander commented on a change in pull request #5840: URL: https://github.com/apache/apisix/pull/5840#discussion_r771102522 ## File path: apisix/core/log.lua ## @@ -42,17 +43,27 @@ local log_levels = { } -local cur_level = ngx.config.subsystem == "http" and -

[GitHub] [apisix] 532810439 commented on issue #5844: bug: When will GM SSL be supported

2021-12-16 Thread GitBox
532810439 commented on issue #5844: URL: https://github.com/apache/apisix/issues/5844#issuecomment-996433121 http://www.gb688.cn/bzgk/gb/newGbInfo?hcno=778097598DA2761E94A5FF3F77BD66DA -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix-dashboard] zaunist commented on pull request #2251: ci: remove push docker image to demo env

2021-12-16 Thread GitBox
zaunist commented on pull request #2251: URL: https://github.com/apache/apisix-dashboard/pull/2251#issuecomment-996428789 If we delete the push step, the deploy-with-docker.yaml maybe delete together. Otherwise it doesn't make sense -- This is an automated message from the Apache Git Ser

[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2251: ci: remove push docker image to demo env

2021-12-16 Thread GitBox
codecov-commenter commented on pull request #2251: URL: https://github.com/apache/apisix-dashboard/pull/2251#issuecomment-996427538 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2251?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comm

[apisix] branch master updated (c3ba11f -> 07630c7)

2021-12-16 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from c3ba11f docs(logging): supplement the supported logging service (#5843) add 07630c7 docs: add offline in

[GitHub] [apisix] spacewander merged pull request #5829: docs: add offline install to 'how-to-build.md'

2021-12-16 Thread GitBox
spacewander merged pull request #5829: URL: https://github.com/apache/apisix/pull/5829 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[GitHub] [apisix] spacewander closed issue #5785: request help: add offline installation for `how-to-build.md`

2021-12-16 Thread GitBox
spacewander closed issue #5785: URL: https://github.com/apache/apisix/issues/5785 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-un

[GitHub] [apisix] shuaijinchao commented on a change in pull request #5819: feat(splunk): support splunk hec logging plugin

2021-12-16 Thread GitBox
shuaijinchao commented on a change in pull request #5819: URL: https://github.com/apache/apisix/pull/5819#discussion_r771091241 ## File path: docs/en/latest/plugins/splunk-hec-logging.md ## @@ -0,0 +1,143 @@ +--- +title: splunk-hec-logging +--- + + + +## Summary + +- [**Name**]

[GitHub] [apisix] spacewander commented on pull request #5825: feat: upgrade luarocks to 3.8.0 which converts git:// to https://

2021-12-16 Thread GitBox
spacewander commented on pull request #5825: URL: https://github.com/apache/apisix/pull/5825#issuecomment-996420133 The luarocks 2.x doesn't be broken because of the git URL. In fact, it doesn't handle the new rockspec format and the dependency management which have been reported by the us

[GitHub] [apisix] spacewander commented on pull request #5825: feat: upgrade luarocks to 3.8.0 which converts git:// to https://

2021-12-16 Thread GitBox
spacewander commented on pull request #5825: URL: https://github.com/apache/apisix/pull/5825#issuecomment-996419334 No, as I mentioned in the commit message. The luarocks 2.x is actually broken. We just make sure people won't be trapped in it. -- This is an automated message from the Apa

[GitHub] [apisix] tokers commented on issue #5844: bug: When will GM SSL be supported

2021-12-16 Thread GitBox
tokers commented on issue #5844: URL: https://github.com/apache/apisix/issues/5844#issuecomment-996417546 I'm not so familiar with the GM SSL, could you give us the white paper, or the specification link, and some implementations? -- This is an automated message from the Apache Git Servi

[apisix] branch master updated (4855813 -> c3ba11f)

2021-12-16 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 4855813 docs(request-id): fix typo in request-id plugin documents. (#5832) add c3ba11f docs(logging): suppl

[GitHub] [apisix] 532810439 opened a new issue #5844: bug: When will GM SSL be supported

2021-12-16 Thread GitBox
532810439 opened a new issue #5844: URL: https://github.com/apache/apisix/issues/5844 ### Issue description GM/T 0024-2014 SSL VPN specification ### Environment - apisix version (cmd: `apisix version`): - OS (cmd: `uname -a`): - OpenResty / Nginx version (cmd: `ngi

[GitHub] [apisix] membphis merged pull request #5843: docs(logging): supplement the supported logging service

2021-12-16 Thread GitBox
membphis merged pull request #5843: URL: https://github.com/apache/apisix/pull/5843 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-

[GitHub] [apisix-dashboard] 532810439 opened a new issue #2252: When will GM SSL be supported

2021-12-16 Thread GitBox
532810439 opened a new issue #2252: URL: https://github.com/apache/apisix-dashboard/issues/2252 ### Issue description GM/T 0024-2014 SSL VPN specification ### Expected behavior GM SSL be supported ### How to Reproduce 2.8 ### Screenshots apisi

[GitHub] [apisix-dashboard] zaunist commented on pull request #2251: ci: remove push docker image to demo env

2021-12-16 Thread GitBox
zaunist commented on pull request #2251: URL: https://github.com/apache/apisix-dashboard/pull/2251#issuecomment-996415535 If we delete the push step, the deploy-with-docker.yaml maybe delete together. Otherwise it doesn't make sense -- This is an automated message from the Apache Git Ser

[GitHub] [apisix] shuaijinchao opened a new pull request #5843: docs(logging): supplement the supported logging service

2021-12-16 Thread GitBox
shuaijinchao opened a new pull request #5843: URL: https://github.com/apache/apisix/pull/5843 ### What this PR does / why we need it: ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been added? *

[GitHub] [apisix] membphis commented on a change in pull request #5819: feat(splunk): support splunk hec logging plugin

2021-12-16 Thread GitBox
membphis commented on a change in pull request #5819: URL: https://github.com/apache/apisix/pull/5819#discussion_r771085017 ## File path: docs/en/latest/plugins/splunk-hec-logging.md ## @@ -0,0 +1,143 @@ +--- +title: splunk-hec-logging +--- + + + +## Summary + +- [**Name**](#na

[GitHub] [apisix] juzhiyuan opened a new issue #5842: docs: fold phrase in Chinese into one line

2021-12-16 Thread GitBox
juzhiyuan opened a new issue #5842: URL: https://github.com/apache/apisix/issues/5842 ### Improved or typo fixed. Hi, In our Chinese Documentations, we have `breaking lines` in original markdowns, e.g ```text `Plugin` 配置可直接绑定在 `Route` 上,也可以被绑定在 `Service` 或 `Consumer`

[GitHub] [apisix] membphis merged pull request #5832: docs: Fix typo in request-id plugin documents.

2021-12-16 Thread GitBox
membphis merged pull request #5832: URL: https://github.com/apache/apisix/pull/5832 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-

[apisix] branch master updated: docs(request-id): fix typo in request-id plugin documents. (#5832)

2021-12-16 Thread membphis
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 4855813 docs(request-id): fix typo in request

[GitHub] [apisix] gxthrj commented on issue #5780: DISCUSS: Add a plugin that filters specific requests through regular matching

2021-12-16 Thread GitBox
gxthrj commented on issue #5780: URL: https://github.com/apache/apisix/issues/5780#issuecomment-996409398 > I think it's a big thing, so please send this discussion to ML too, thanks. OK, will send to ML today. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [apisix] gxthrj commented on issue #5780: DISCUSS: Add a plugin that filters specific requests through regular matching

2021-12-16 Thread GitBox
gxthrj commented on issue #5780: URL: https://github.com/apache/apisix/issues/5780#issuecomment-996409264 > so do you means Apache APISIX needs a WAF plugin? I think APISIX needs WAF plugin,but it is a universal plug-in with regular matching conditions, not enough to solve all WAF pr

[GitHub] [apisix] juzhiyuan commented on pull request #5823: docs: remove the redundant space between Chinese characters

2021-12-16 Thread GitBox
juzhiyuan commented on pull request #5823: URL: https://github.com/apache/apisix/pull/5823#issuecomment-996404873 Get it, I will create an issue to track this 🥳 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix] Josh-Cena commented on pull request #5823: docs: remove the redundant space between Chinese characters

2021-12-16 Thread GitBox
Josh-Cena commented on pull request #5823: URL: https://github.com/apache/apisix/pull/5823#issuecomment-996403699 Yeah, that could be helpful 🤪 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [apisix] juzhiyuan edited a comment on pull request #5823: docs: remove the redundant space between Chinese characters

2021-12-16 Thread GitBox
juzhiyuan edited a comment on pull request #5823: URL: https://github.com/apache/apisix/pull/5823#issuecomment-996403248 > So if you use [Prettier](https://prettier.io/) in the website, you can just configure it to `proseWrap: 'none'` and it will collapse all wrapping line breaks. J

[GitHub] [apisix] juzhiyuan commented on pull request #5823: docs: remove the redundant space between Chinese characters

2021-12-16 Thread GitBox
juzhiyuan commented on pull request #5823: URL: https://github.com/apache/apisix/pull/5823#issuecomment-996403248 > So if you use [Prettier](https://prettier.io/) in the website, you can just configure it to `proseWrap: 'none'` and it will collapse all wrapping line breaks. Just to

[GitHub] [apisix] Josh-Cena edited a comment on pull request #5823: docs: remove the redundant space between Chinese characters

2021-12-16 Thread GitBox
Josh-Cena edited a comment on pull request #5823: URL: https://github.com/apache/apisix/pull/5823#issuecomment-996402605 So if you use [Prettier](https://prettier.io/) in the website, you can just configure it to `"proseWrap": "never"` and it will collapse all wrapping line breaks. -- T

[GitHub] [apisix] Josh-Cena commented on pull request #5823: docs: remove the redundant space between Chinese characters

2021-12-16 Thread GitBox
Josh-Cena commented on pull request #5823: URL: https://github.com/apache/apisix/pull/5823#issuecomment-996402605 So if you use [Prettier](https://prettier.io/) in the website, you can just configure it to `proseWrap: 'none'` and it will collapse all wrapping line breaks. -- This is an

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #2248: feat(plugin): change button desc

2021-12-16 Thread GitBox
juzhiyuan merged pull request #2248: URL: https://github.com/apache/apisix-dashboard/pull/2248 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: not

[GitHub] [apisix-dashboard] juzhiyuan closed issue #2245: The `禁用` button on the plugin list page has ambiguity issues

2021-12-16 Thread GitBox
juzhiyuan closed issue #2245: URL: https://github.com/apache/apisix-dashboard/issues/2245 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifica

[apisix-dashboard] branch master updated: feat(plugin): change button desc (#2248)

2021-12-16 Thread juzhiyuan
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new 40822d7 feat(plugin): change butto

[GitHub] [apisix] juzhiyuan commented on issue #5834: request help: how to set redirect_uri, when i use openid-connect

2021-12-16 Thread GitBox
juzhiyuan commented on issue #5834: URL: https://github.com/apache/apisix/issues/5834#issuecomment-996401543 Hi @leslie-tsang, would you please take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [apisix] juzhiyuan commented on pull request #5823: docs: remove the redundant space between Chinese characters

2021-12-16 Thread GitBox
juzhiyuan commented on pull request #5823: URL: https://github.com/apache/apisix/pull/5823#issuecomment-996398822 > I honestly think this is a legitimate fix and we can just fix this everywhere if needed Hi @Josh-Cena, I can't clearly remember why we have breaking lines in our docs

[GitHub] [apisix-helm-chart] webup commented on issue #182: feat: add service monitor for main chart

2021-12-16 Thread GitBox
webup commented on issue #182: URL: https://github.com/apache/apisix-helm-chart/issues/182#issuecomment-996397990 Closed with #192. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [apisix-helm-chart] webup closed issue #182: feat: add service monitor for main chart

2021-12-16 Thread GitBox
webup closed issue #182: URL: https://github.com/apache/apisix-helm-chart/issues/182 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications

[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #2251: ci: remove push docker image to demo env

2021-12-16 Thread GitBox
juzhiyuan commented on pull request #2251: URL: https://github.com/apache/apisix-dashboard/pull/2251#issuecomment-996395345 Hi, may I know visitors how to use the manager-api? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [apisix] leslie-tsang opened a new pull request #5840: fix(core.log): log level need to be updated in some scenario

2021-12-16 Thread GitBox
leslie-tsang opened a new pull request #5840: URL: https://github.com/apache/apisix/pull/5840 ### What this PR does / why we need it: log level need to be update in some scenario, such as called in init phase. POC: > set error_log log level as `error` ```yaml ext

[GitHub] [apisix] dmsolr removed a comment on issue #4301: bug: skywalking not work when upsteam timeout

2021-12-16 Thread GitBox
dmsolr removed a comment on issue #4301: URL: https://github.com/apache/apisix/issues/4301#issuecomment-996393391 I am sorry for pending long time. I am going to release a version before next week. -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [apisix] dmsolr commented on issue #4301: bug: skywalking not work when upsteam timeout

2021-12-16 Thread GitBox
dmsolr commented on issue #4301: URL: https://github.com/apache/apisix/issues/4301#issuecomment-996393391 I am sorry for pending long time. I am going to release a version before next week. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [apisix] dmsolr commented on issue #4301: bug: skywalking not work when upsteam timeout

2021-12-16 Thread GitBox
dmsolr commented on issue #4301: URL: https://github.com/apache/apisix/issues/4301#issuecomment-996392753 I am sorry for pending long time. I am going to release a version before next week. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [apisix] membphis commented on issue #3498: apisix access have 500 status code

2021-12-16 Thread GitBox
membphis commented on issue #3498: URL: https://github.com/apache/apisix/issues/3498#issuecomment-996392247 ok, got it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [apisix] membphis closed issue #3498: apisix access have 500 status code

2021-12-16 Thread GitBox
membphis closed issue #3498: URL: https://github.com/apache/apisix/issues/3498 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsub

[GitHub] [apisix] shuaijinchao opened a new pull request #5839: chore(google-cloud-logging): move ssl_verify to plugin configuration top level

2021-12-16 Thread GitBox
shuaijinchao opened a new pull request #5839: URL: https://github.com/apache/apisix/pull/5839 ### What this PR does / why we need it: FIX #5838 ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have

[GitHub] [apisix] shuaijinchao opened a new issue #5838: improve: google-cloud-logging unable to set up SSL Verify

2021-12-16 Thread GitBox
shuaijinchao opened a new issue #5838: URL: https://github.com/apache/apisix/issues/5838 ### Issue description `google-cloud-logging` SSL verification settings currently need to be configured in the auth_config structure or auth_file configuration file to take effect. Currently, whe

[GitHub] [apisix] chanjet1213 opened a new issue #5837: 期待监控指标添加对nginx共享内存使用情况的监控

2021-12-16 Thread GitBox
chanjet1213 opened a new issue #5837: URL: https://github.com/apache/apisix/issues/5837 ### Issue description 期待监控指标添加对nginx共享内存使用情况的监控 ### Environment - apisix version (cmd: `apisix version`): - OS (cmd: `uname -a`): - OpenResty / Nginx version (cmd: `nginx -V` or

[GitHub] [apisix] wu-sheng commented on issue #4301: bug: skywalking not work when upsteam timeout

2021-12-16 Thread GitBox
wu-sheng commented on issue #4301: URL: https://github.com/apache/apisix/issues/4301#issuecomment-996378124 @dmsolr Any update about this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [apisix-dashboard] nic-chen opened a new pull request #2251: ci: remove push docker image to demo env

2021-12-16 Thread GitBox
nic-chen opened a new pull request #2251: URL: https://github.com/apache/apisix-dashboard/pull/2251 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [x] Bugfix - [ ] New feature provided -

[GitHub] [apisix] zjzwjcbj commented on issue #5817: request help: mac m1 make install error cannot mkdir /usr/share/lua

2021-12-16 Thread GitBox
zjzwjcbj commented on issue #5817: URL: https://github.com/apache/apisix/issues/5817#issuecomment-996357675 > @zjzwjcbj we can close this? Ok,thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [apisix] zjzwjcbj closed issue #5817: request help: mac m1 make install error cannot mkdir /usr/share/lua

2021-12-16 Thread GitBox
zjzwjcbj closed issue #5817: URL: https://github.com/apache/apisix/issues/5817 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsub

[GitHub] [apisix] spacewander edited a comment on issue #5802: bug: no connection to MQTT broker possible by using mqtt_proxy

2021-12-16 Thread GitBox
spacewander edited a comment on issue #5802: URL: https://github.com/apache/apisix/issues/5802#issuecomment-996355964 Interesting. Here is the result running on my machine: ``` incubator-apisix (master) 0 ¥ mosquitto_sub -t test -v & [1] 23990 incubator-apisix (master) 0

[GitHub] [apisix] tzssangglass commented on issue #5814: bug: java plugin error permission denied

2021-12-16 Thread GitBox
tzssangglass commented on issue #5814: URL: https://github.com/apache/apisix/issues/5814#issuecomment-996356616 @sunyu-2020 If you verify this is complete, would you be willing to submit a PR to add documentation about this? -- This is an automated message from the Apache Git Service. To

[GitHub] [apisix] tzssangglass commented on issue #5827: init_worker_by_lua error: ./apisix/plugins/prometheus/exporter.lua:17: module 'prometheus' not found:

2021-12-16 Thread GitBox
tzssangglass commented on issue #5827: URL: https://github.com/apache/apisix/issues/5827#issuecomment-996355925 zip file is source code of APISIX, as @spacewander said, you need to build APISIX form source code. -- This is an automated message from the Apache Git Service. To respond to t

[GitHub] [apisix] spacewander commented on issue #5802: bug: no connection to MQTT broker possible by using mqtt_proxy

2021-12-16 Thread GitBox
spacewander commented on issue #5802: URL: https://github.com/apache/apisix/issues/5802#issuecomment-996355964 Interesting. Here is the result running on my machine: ``` incubator-apisix (master) 0 ¥ mosquitto_sub -t test -v & [1] 23990 incubator-apisix (master) 0 ¥ mos

[GitHub] [apisix] leslie-tsang commented on a change in pull request #5829: docs: add offline install to 'how-to-build.md'

2021-12-16 Thread GitBox
leslie-tsang commented on a change in pull request #5829: URL: https://github.com/apache/apisix/pull/5829#discussion_r771035675 ## File path: docs/en/latest/how-to-build.md ## @@ -54,6 +54,23 @@ $ sudo yum --showduplicates list apisix $ sudo yum install apisix ``` +### Inst

[GitHub] [apisix] spacewander commented on pull request #5823: docs: remove the redundant space between Chinese characters

2021-12-16 Thread GitBox
spacewander commented on pull request #5823: URL: https://github.com/apache/apisix/pull/5823#issuecomment-996346967 What about providing a check to the Chinese doc? We can add a script to check if 1. the last char of the line is not ascii 2. the next line is not empty 3. the first

[GitHub] [apisix] juzhiyuan commented on a change in pull request #5829: docs: add offline install to 'how-to-build.md'

2021-12-16 Thread GitBox
juzhiyuan commented on a change in pull request #5829: URL: https://github.com/apache/apisix/pull/5829#discussion_r771032942 ## File path: docs/en/latest/how-to-build.md ## @@ -54,6 +54,23 @@ $ sudo yum --showduplicates list apisix $ sudo yum install apisix ``` +### Install

[GitHub] [apisix] juzhiyuan commented on a change in pull request #5793: docs: sync stream proxy Chinese version

2021-12-16 Thread GitBox
juzhiyuan commented on a change in pull request #5793: URL: https://github.com/apache/apisix/pull/5793#discussion_r771032513 ## File path: docs/zh/latest/stream-proxy.md ## @@ -72,7 +72,11 @@ curl http://127.0.0.1:9080/apisix/admin/stream_routes/1 -H 'X-API-KEY: edd1c9f03 #

[GitHub] [apisix] tzssangglass commented on issue #5826: request help: How to get request header and response header?

2021-12-16 Thread GitBox
tzssangglass commented on issue #5826: URL: https://github.com/apache/apisix/issues/5826#issuecomment-996345395 `core.request.header()` or `core.request.headers()`, it is easy to search in the code. -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [apisix] tzssangglass commented on issue #5817: request help: mac m1 make install error cannot mkdir /usr/share/lua

2021-12-16 Thread GitBox
tzssangglass commented on issue #5817: URL: https://github.com/apache/apisix/issues/5817#issuecomment-996344675 @zjzwjcbj we can close this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix] tzssangglass commented on issue #5817: request help: mac m1 make install error cannot mkdir /usr/share/lua

2021-12-16 Thread GitBox
tzssangglass commented on issue #5817: URL: https://github.com/apache/apisix/issues/5817#issuecomment-996344485 Recommended for development on x86 systems, dependency support on M1 is not complete. -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [apisix] spacewander merged pull request #5820: fix(sls-logger): log entry unable get millisecond timestamp

2021-12-16 Thread GitBox
spacewander merged pull request #5820: URL: https://github.com/apache/apisix/pull/5820 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notificatio

[apisix] branch master updated: fix(sls-logger): log entry unable get millisecond timestamp (#5820)

2021-12-16 Thread spacewander
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new fce2b44 fix(sls-logger): log entry unable

  1   2   >