Re: [PR] blog: Add forgotten canonical link [apisix-website]

2023-11-29 Thread via GitHub
yzeng25 merged PR #1733: URL: https://github.com/apache/apisix-website/pull/1733 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr.

(apisix-website) branch master updated: blog: Add forgotten canonical link (#1733)

2023-11-29 Thread yilinzeng
This is an automated email from the ASF dual-hosted git repository. yilinzeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/master by this push: new a6c5b18ad33 blog: Add forgotten canon

Re: [PR] feat: add jwe decrypt plugin [apisix]

2023-11-29 Thread via GitHub
monkeyDluffy6017 commented on code in PR #10252: URL: https://github.com/apache/apisix/pull/10252#discussion_r1410275714 ## apisix/plugins/jwe-decrypt.lua: ## @@ -0,0 +1,250 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor license agr

Re: [PR] feat: add jwe decrypt plugin [apisix]

2023-11-29 Thread via GitHub
monkeyDluffy6017 commented on code in PR #10252: URL: https://github.com/apache/apisix/pull/10252#discussion_r1410273045 ## t/plugin/jwt-auth.t: ## @@ -103,7 +103,7 @@ passed -=== TEST 4: enable jwt auth plugin using admin api +=== TEST 4: enable jwt-decrypt plugin using a

Re: [I] bug: The HTTP routing host field cannot match the port [apisix]

2023-11-29 Thread via GitHub
theweakgod commented on issue #10531: URL: https://github.com/apache/apisix/issues/10531#issuecomment-1833261006 > @DokiDoki1103 Did you try to configure host=8.130.141.31 instead of host=8.130.141.31:7070? I don't think it's a good practice to add port matching in host because I feel it ca

Re: [I] bug: The HTTP routing host field cannot match the port [apisix]

2023-11-29 Thread via GitHub
DokiDoki1103 commented on issue #10531: URL: https://github.com/apache/apisix/issues/10531#issuecomment-1833258570 like this? ``` - name: rbd-app-ui match: exprs: - subject: scope: ScopeHeader name: server_port

Re: [I] bug: The HTTP routing host field cannot match the port [apisix]

2023-11-29 Thread via GitHub
DokiDoki1103 commented on issue #10531: URL: https://github.com/apache/apisix/issues/10531#issuecomment-1833255345 > server_port > @DokiDoki1103 Did you try to configure host=8.130.141.31 instead of host=8.130.141.31:7070? I don't think it's a good practice to add port matchin

Re: [PR] feat: add jwe decrypt plugin [apisix]

2023-11-29 Thread via GitHub
monkeyDluffy6017 commented on code in PR #10252: URL: https://github.com/apache/apisix/pull/10252#discussion_r1410266010 ## apisix/plugins/jwe-decrypt.lua: ## @@ -0,0 +1,250 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor license agr

Re: [PR] fix(router/radixtree_uri_with_parameter): use encoded_uri for radixtree match [apisix]

2023-11-29 Thread via GitHub
wklken commented on code in PR #10561: URL: https://github.com/apache/apisix/pull/10561#discussion_r1410241036 ## apisix/http/route.lua: ## @@ -111,7 +111,8 @@ function _M.match_uri(uri_router, api_ctx) match_opts.vars = api_ctx.var match_opts.matched = core.tablepool.

Re: [I] bug: Routing configuration not taking effect, and the backend reports an etcd error. [apisix-ingress-controller]

2023-11-29 Thread via GitHub
wumengchao commented on issue #2071: URL: https://github.com/apache/apisix-ingress-controller/issues/2071#issuecomment-1833210234 I intentionally configured an incorrect path. After encountering "failed to find route in cache," the following error immediately appears: "failed to create obj

Re: [I] Is this project still maintained? [apisix-dashboard]

2023-11-29 Thread via GitHub
make3782 commented on issue #2891: URL: https://github.com/apache/apisix-dashboard/issues/2891#issuecomment-1833208221 So far, it hasn't been rolled back yet. How can I install apisix+dashboard using docker compose? -- This is an automated message from the Apache Git Service. To respond

[PR] docs: add migu-video-utilizes-apisix.md [apisix-website]

2023-11-29 Thread via GitHub
Yilialinn opened a new pull request, #1734: URL: https://github.com/apache/apisix-website/pull/1734 Fixes: #[Add issue number here] Changes: Screenshots of the change: -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] fix(router/radixtree_uri_with_parameter): use encoded_uri for radixtree match [apisix]

2023-11-29 Thread via GitHub
moonming commented on code in PR #10561: URL: https://github.com/apache/apisix/pull/10561#discussion_r1410190997 ## apisix/http/route.lua: ## @@ -111,7 +111,8 @@ function _M.match_uri(uri_router, api_ctx) match_opts.vars = api_ctx.var match_opts.matched = core.tablepoo

Re: [I] docs: the clickhouse-logger's default password was wrong [apisix]

2023-11-29 Thread via GitHub
shreemaan-abhishek commented on issue #10568: URL: https://github.com/apache/apisix/issues/10568#issuecomment-1833124610 please raise a PR with the fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [I] docs: rocketmq-logger's Enable plugin request was wrong [apisix]

2023-11-29 Thread via GitHub
shreemaan-abhishek commented on issue #10567: URL: https://github.com/apache/apisix/issues/10567#issuecomment-1833124410 you can raise a PR directly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[I] help request: APISIX Dashboard ->Grafana Address url issue [apisix-dashboard]

2023-11-29 Thread via GitHub
deekayzain opened a new issue, #2894: URL: https://github.com/apache/apisix-dashboard/issues/2894 ### Description Kindly help us to figure out what address we need to place on APISIX Dashboard ->Grafana Address. We have tried with many options like with links taken from Grafana af

Re: [PR] fix: missing etcd init_dir and unable to list resource [apisix]

2023-11-29 Thread via GitHub
AlinsRan closed pull request #10569: fix: missing etcd init_dir and unable to list resource URL: https://github.com/apache/apisix/pull/10569 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[PR] fix: missing etcd init_dir and unable to list resource [apisix]

2023-11-29 Thread via GitHub
AlinsRan opened a new pull request, #10569: URL: https://github.com/apache/apisix/pull/10569 ### Description Fixes # (issue) ### Checklist - [ ] I have explained the need for this PR and the problem it solves - [ ] I have explained the changes or the new fe

(apisix) branch release-3.7 deleted (was 39a4835b5)

2023-11-29 Thread alinsran
This is an automated email from the ASF dual-hosted git repository. alinsran pushed a change to branch release-3.7 in repository https://gitbox.apache.org/repos/asf/apisix.git was 39a4835b5 update changelog The revisions that were on this branch are still contained in other references; the

(apisix) branch fix/admin-list deleted (was 5b41ae6bf)

2023-11-29 Thread alinsran
This is an automated email from the ASF dual-hosted git repository. alinsran pushed a change to branch fix/admin-list in repository https://gitbox.apache.org/repos/asf/apisix.git was 5b41ae6bf fix: missing etcd init_dir and unable to list resource This change permanently discards the follo

(apisix) branch fix/admin-list created (now 5b41ae6bf)

2023-11-29 Thread alinsran
This is an automated email from the ASF dual-hosted git repository. alinsran pushed a change to branch fix/admin-list in repository https://gitbox.apache.org/repos/asf/apisix.git at 5b41ae6bf fix: missing etcd init_dir and unable to list resource This branch includes the following new com

(apisix) 01/01: fix: missing etcd init_dir and unable to list resource

2023-11-29 Thread alinsran
This is an automated email from the ASF dual-hosted git repository. alinsran pushed a commit to branch fix/admin-list in repository https://gitbox.apache.org/repos/asf/apisix.git commit 5b41ae6bfba0f03b3e9ed8af1216a634212f8f8c Author: AlinsRan AuthorDate: Wed Nov 29 19:55:56 2023 +0800 fix:

Re: [I] bug: The certificate type does not support Opaque [apisix-ingress-controller]

2023-11-29 Thread via GitHub
DokiDoki1103 commented on issue #2075: URL: https://github.com/apache/apisix-ingress-controller/issues/2075#issuecomment-1833112678 https://github.com/apache/apisix-ingress-controller/assets/62740231/171cf850-efdd-441f-858e-09d96ab2b367";> But there is a key field in the certificate I am

[I] bug: The certificate type does not support Opaque [apisix-ingress-controller]

2023-11-29 Thread via GitHub
DokiDoki1103 opened a new issue, #2075: URL: https://github.com/apache/apisix-ingress-controller/issues/2075 ### Current Behavior ``` [root@iZ0jl45fhsg64jjbkm1y1gZ ~]# kubectl get secrets -n rbd-system hub-image-repository NAME TYPE DATA AGE hub-image

Re: [PR] docs: Add doc for ApisixConsumer [apisix-ingress-controller]

2023-11-29 Thread via GitHub
kayx23 commented on code in PR #2074: URL: https://github.com/apache/apisix-ingress-controller/pull/2074#discussion_r1410137805 ## docs/en/latest/references/apisix_consumer_v2.md: ## @@ -0,0 +1,46 @@ +--- +title: ApisixConsumer/v2 +keywords: + - APISIX ingress + - Apache APIS

Re: [I] help request: APISIX Dashboard ->Grafana Address url issue [apisix]

2023-11-29 Thread via GitHub
deekayzain closed issue #10545: help request: APISIX Dashboard ->Grafana Address url issue URL: https://github.com/apache/apisix/issues/10545 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [I] help request: APISIX Dashboard ->Grafana Address url issue [apisix]

2023-11-29 Thread via GitHub
deekayzain commented on issue #10545: URL: https://github.com/apache/apisix/issues/10545#issuecomment-1833082190 > essentially what are you trying to do? Configuring grafana with prometheus? Could you please share any relevant configurations? We are just trying to put url on APISIX da

Re: [I] request help: auditlog not working in apisix with coraza-filter [apisix-ingress-controller]

2023-11-29 Thread via GitHub
donghuuhieu137 commented on issue #2073: URL: https://github.com/apache/apisix-ingress-controller/issues/2073#issuecomment-1833069335 > Do you have a wasm plugin in your container yes, I added wasm configuration in /usr/local/apisix/conf/config.yaml ``` wasm: plugins:

Re: [PR] docs: Add doc for ApisixConsumer [apisix-ingress-controller]

2023-11-29 Thread via GitHub
Revolyssup commented on code in PR #2074: URL: https://github.com/apache/apisix-ingress-controller/pull/2074#discussion_r1410124460 ## docs/en/latest/references/apisix_consumer_v2.md: ## @@ -0,0 +1,46 @@ +--- +title: ApisixConsumer/v2 +keywords: + - APISIX ingress + - Apache

Re: [PR] docs: Add doc for ApisixConsumer [apisix-ingress-controller]

2023-11-29 Thread via GitHub
Revolyssup commented on code in PR #2074: URL: https://github.com/apache/apisix-ingress-controller/pull/2074#discussion_r1410124035 ## docs/en/latest/references/apisix_consumer_v2.md: ## @@ -0,0 +1,46 @@ +--- +title: ApisixConsumer/v2 +keywords: + - APISIX ingress + - Apache

Re: [PR] docs: Add doc for ApisixConsumer [apisix-ingress-controller]

2023-11-29 Thread via GitHub
Revolyssup commented on code in PR #2074: URL: https://github.com/apache/apisix-ingress-controller/pull/2074#discussion_r1410123553 ## docs/en/latest/concepts/apisix_consumer.md: ## @@ -0,0 +1,107 @@ +--- +title: ApisixConsumer +keywords: + - APISIX ingress + - Apache APISIX

Re: [PR] docs: Add doc for ApisixConsumer [apisix-ingress-controller]

2023-11-29 Thread via GitHub
Revolyssup commented on code in PR #2074: URL: https://github.com/apache/apisix-ingress-controller/pull/2074#discussion_r1410123458 ## docs/en/latest/concepts/apisix_consumer.md: ## @@ -0,0 +1,107 @@ +--- +title: ApisixConsumer +keywords: + - APISIX ingress + - Apache APISIX

Re: [PR] docs: Add doc for ApisixConsumer [apisix-ingress-controller]

2023-11-29 Thread via GitHub
Revolyssup commented on code in PR #2074: URL: https://github.com/apache/apisix-ingress-controller/pull/2074#discussion_r1410123332 ## docs/en/latest/references/apisix_consumer_v2.md: ## @@ -0,0 +1,46 @@ +--- +title: ApisixConsumer/v2 +keywords: + - APISIX ingress + - Apache

Re: [I] request help: auditlog not working in apisix with coraza-filter [apisix-ingress-controller]

2023-11-29 Thread via GitHub
DokiDoki1103 commented on issue #2073: URL: https://github.com/apache/apisix-ingress-controller/issues/2073#issuecomment-1833060164 Do you have a wasm plugin in your container -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [I] bug: Host matching cannot carry ports [apisix-ingress-controller]

2023-11-29 Thread via GitHub
DokiDoki1103 commented on issue #2064: URL: https://github.com/apache/apisix-ingress-controller/issues/2064#issuecomment-1833059404 @Revolyssup You're welcome, I'm using Apisix extensively. If I encounter any problems, I'll give you feedback promptly -- This is an automated message from

Re: [I] request help: How to generate the apisix schema.json file [apisix-ingress-controller]

2023-11-29 Thread via GitHub
DokiDoki1103 commented on issue #2072: URL: https://github.com/apache/apisix-ingress-controller/issues/2072#issuecomment-1833058079 thank you ,I can test it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [I] bug: failed to list routes: Get http://apisix-admin:9180/apisix/admin/routes: context canceled [apisix-ingress-controller]

2023-11-29 Thread via GitHub
liyuan231 commented on issue #695: URL: https://github.com/apache/apisix-ingress-controller/issues/695#issuecomment-1833056015 Follow the guide of https://apisix.apache.org/zh/docs/helm-chart/apisix-ingress-controller/ Also throw `Get http://apisix-admin:9180/apisix/admin/routes: context

[I] docs: the clickhouse-logger's default password was wrong [apisix]

2023-11-29 Thread via GitHub
Vacant2333 opened a new issue, #10568: URL: https://github.com/apache/apisix/issues/10568 ### Current State if we do the request as follow: https://apisix.apache.org/docs/apisix/next/plugins/clickhouse-logger/#example-usage apisix will throw a **error**: ![image](https://git

Re: [PR] feat: create new event module for decouple logic and specific library [apisix]

2023-11-29 Thread via GitHub
bzp2010 commented on code in PR #10558: URL: https://github.com/apache/apisix/pull/10558#discussion_r1410074794 ## apisix/event.lua: ## @@ -0,0 +1,70 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor license agreements. See the NOTICE

Re: [I] What are the best practices for export/import in apisix-dashboard? [apisix-dashboard]

2023-11-29 Thread via GitHub
NotFound403 commented on issue #2728: URL: https://github.com/apache/apisix-dashboard/issues/2728#issuecomment-1833025355 > > i have done it , the export json file is not a pure json, it contains a checksum (4 bit) at the end , if u modify the contents u need to update the checksum > >

Re: [PR] fix: forward-auth request body is too large [apisix]

2023-11-29 Thread via GitHub
shreemaan-abhishek commented on code in PR #10425: URL: https://github.com/apache/apisix/pull/10425#discussion_r1410094460 ## apisix/plugins/forward-auth.lua: ## @@ -106,16 +106,20 @@ function _M.access(conf, ctx) method = conf.request_method } +local httpc =

(apisix) branch master updated: fix(plugin/opa): safely remove upstream when sending route to opa (#10552)

2023-11-29 Thread wenming
This is an automated email from the ASF dual-hosted git repository. wenming pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new fc5bf2b8f fix(plugin/opa): safely remove upstre

Re: [I] bug: OPA Plugin with the attribute "with_route" set to true causes a 500 status error [apisix]

2023-11-29 Thread via GitHub
moonming closed issue #10483: bug: OPA Plugin with the attribute "with_route" set to true causes a 500 status error URL: https://github.com/apache/apisix/issues/10483 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] fix(plugin/opa): safely remove upstream when sending route to opa [apisix]

2023-11-29 Thread via GitHub
moonming merged PR #10552: URL: https://github.com/apache/apisix/pull/10552 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ap

Re: [PR] feat: create new event module for decouple logic and specific library [apisix]

2023-11-29 Thread via GitHub
bzp2010 commented on code in PR #10558: URL: https://github.com/apache/apisix/pull/10558#discussion_r1410074794 ## apisix/event.lua: ## @@ -0,0 +1,70 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor license agreements. See the NOTICE

Re: [I] What are the best practices for export/import in apisix-dashboard? [apisix-dashboard]

2023-11-29 Thread via GitHub
saytesnake commented on issue #2728: URL: https://github.com/apache/apisix-dashboard/issues/2728#issuecomment-1832992423 > i have done it , the export json file is not a pure json, it contains a checksum (4 bit) at the end , if u modify the contents u need to update the checksum > >

(apisix) branch master updated: docs: update xargs command and add `#END` to `debug.yaml` example (#10565)

2023-11-29 Thread traky
This is an automated email from the ASF dual-hosted git repository. traky pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 95d7612ed docs: update xargs command and add `#EN

Re: [PR] docs: update xargs command and add `#END` to `debug.yaml` example [apisix]

2023-11-29 Thread via GitHub
kayx23 merged PR #10565: URL: https://github.com/apache/apisix/pull/10565 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apis

Re: [PR] docs: update xargs command and add `#END` to `debug.yaml` example [apisix]

2023-11-29 Thread via GitHub
kayx23 commented on PR #10565: URL: https://github.com/apache/apisix/pull/10565#issuecomment-1832990720 Updated the PR title and description. Hope that's alright with all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

Re: [PR] feat(openid-connect): Add `symmetric_key` option to support verifying tokens with symmetric algorithms [apisix]

2023-11-29 Thread via GitHub
kayx23 commented on PR #7691: URL: https://github.com/apache/apisix/pull/7691#issuecomment-1832983472 Re-opened as this is a meaningful contribution. Helped resolve conflicts and update the explanation for the `symmetric_key` to be a bit more readable, because the PR author mentioned

Re: [PR] feat(openid-connect): Add `symmetric_key` option to support verifying tokens with symmetric algorithms [apisix]

2023-11-29 Thread via GitHub
kayx23 commented on code in PR #7691: URL: https://github.com/apache/apisix/pull/7691#discussion_r1410063225 ## apisix/plugins/openid-connect.lua: ## @@ -71,6 +72,10 @@ local schema = { type = "string", description = "the URI will be redirect when reque

Re: [I] bug: restart etcd admin api /apisix/admin/routes response is error [apisix]

2023-11-29 Thread via GitHub
AlinsRan commented on issue #9618: URL: https://github.com/apache/apisix/issues/9618#issuecomment-1832969398 @shreemaan-abhishek I have reproduced it, please let me fix this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[PR] feat(openid-connect): Add 'symmetric_key' option to support HS??? tokens [apisix]

2023-11-29 Thread via GitHub
liweitianux opened a new pull request, #7691: URL: https://github.com/apache/apisix/pull/7691 ### Description The underlying `lua-resty-openidc` module already supports the `symmetric_key` option to specify the HMAC key for verifying HS??? tokens. However, note that `lua-resty-o

Re: [I] discuss: clean up meaningless logic about `init_dir` [apisix]

2023-11-29 Thread via GitHub
bzp2010 commented on issue #10566: URL: https://github.com/apache/apisix/issues/10566#issuecomment-1832964660 Hi, @AlinsRan. Please move this issue https://github.com/apache/apisix/issues/9618 instead of this discussion. -- This is an automated message from the Apache Git Service. To resp

Re: [I] request help: How to deploy multiple in an environment apisix Ingress Controller + apisix [apisix-ingress-controller]

2023-11-29 Thread via GitHub
github-actions[bot] commented on issue #1884: URL: https://github.com/apache/apisix-ingress-controller/issues/1884#issuecomment-1832957487 This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at

Re: [I] request help: How to deploy multiple in an environment apisix Ingress Controller + apisix [apisix-ingress-controller]

2023-11-29 Thread via GitHub
github-actions[bot] closed issue #1884: request help: How to deploy multiple in an environment apisix Ingress Controller + apisix URL: https://github.com/apache/apisix-ingress-controller/issues/1884 -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] fix: forward-auth request body is too large [apisix]

2023-11-29 Thread via GitHub
shreemaan-abhishek commented on code in PR #10425: URL: https://github.com/apache/apisix/pull/10425#discussion_r1410030305 ## apisix/plugins/forward-auth.lua: ## @@ -106,16 +106,20 @@ function _M.access(conf, ctx) method = conf.request_method } +local httpc =

Re: [PR] docs: Add doc for ApisixConsumer [apisix-ingress-controller]

2023-11-29 Thread via GitHub
kayx23 commented on code in PR #2074: URL: https://github.com/apache/apisix-ingress-controller/pull/2074#discussion_r1409922765 ## docs/en/latest/concepts/apisix_consumer.md: ## @@ -0,0 +1,107 @@ +--- +title: ApisixConsumer +keywords: + - APISIX ingress + - Apache APISIX + -

Re: [PR] blog: Add Chopping the monolith in a smarter way post [apisix-website]

2023-11-29 Thread via GitHub
nfrankel merged PR #1732: URL: https://github.com/apache/apisix-website/pull/1732 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr

(apisix-website) branch master updated: blog: Add Chopping the monolith in a smarter way post (#1732)

2023-11-29 Thread nfrankel
This is an automated email from the ASF dual-hosted git repository. nfrankel pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-website.git The following commit(s) were added to refs/heads/master by this push: new 08b2a7f1904 blog: Add Chopping the mon

Re: [PR] docs: update xargs command in "Getting Started" documentation [apisix]

2023-11-29 Thread via GitHub
kayx23 commented on code in PR #10565: URL: https://github.com/apache/apisix/pull/10565#discussion_r1409802055 ## docs/en/latest/debug-mode.md: ## @@ -36,6 +36,7 @@ You can enable the basic debug mode by adding this line to your debug configurat ```yaml title="conf/debug.yaml"

[PR] blog: Add forgotten canonical link [apisix-website]

2023-11-29 Thread via GitHub
nfrankel opened a new pull request, #1733: URL: https://github.com/apache/apisix-website/pull/1733 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[PR] blog: Add Chopping the monolith in a smarter way post [apisix-website]

2023-11-29 Thread via GitHub
nfrankel opened a new pull request, #1732: URL: https://github.com/apache/apisix-website/pull/1732 https://github.com/apache/apisix-website/assets/752258/8dcab550-a5a1-4122-aeb7-823c71c41611";> -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] feat: support for the Timing-Allow-Origin header in CORS plugin [apisix]

2023-11-29 Thread via GitHub
skimdz86 commented on PR #9365: URL: https://github.com/apache/apisix/pull/9365#issuecomment-1832387019 > I will approve this pr after you resolve the review comments @monkeyDluffy6017 PR updated -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] feat: support for the Timing-Allow-Origin header in CORS plugin [apisix]

2023-11-29 Thread via GitHub
skimdz86 commented on code in PR #9365: URL: https://github.com/apache/apisix/pull/9365#discussion_r1409626407 ## docs/en/latest/plugins/cors.md: ## @@ -42,6 +42,8 @@ The `cors` Plugins lets you enable [CORS](https://developer.mozilla.org/en-US/do | allow_credential |

Re: [PR] feat: support for the Timing-Allow-Origin header in CORS plugin [apisix]

2023-11-29 Thread via GitHub
skimdz86 commented on code in PR #9365: URL: https://github.com/apache/apisix/pull/9365#discussion_r1409618557 ## apisix/plugins/cors.lua: ## @@ -202,9 +236,20 @@ local function set_cors_headers(conf, ctx) if conf.allow_credential then core.response.set_header("Acc

Re: [PR] docs: update xargs command in "Getting Started" documentation [apisix]

2023-11-29 Thread via GitHub
Fabriceli commented on code in PR #10565: URL: https://github.com/apache/apisix/pull/10565#discussion_r1409570104 ## docs/zh/latest/debug-mode.md: ## @@ -28,6 +28,7 @@ title: Debug Mode ``` basic: enable: true +#END Review Comment: ditto ## docs/en/latest/deb

Re: [I] discuss: clean up meaningless logic about `init_dir` [apisix]

2023-11-29 Thread via GitHub
bzp2010 commented on issue #10566: URL: https://github.com/apache/apisix/issues/10566#issuecomment-1832281994 The bug mentioned in the text is tracked by https://github.com/apache/apisix/issues/9618. -- This is an automated message from the Apache Git Service. To respond to the message, p

[I] bug: restart etcd admin api /apisix/admin/routes response is error [apisix]

2023-11-29 Thread via GitHub
Xusq513 opened a new issue, #9618: URL: https://github.com/apache/apisix/issues/9618 ### Current Behavior ``` { "createdIndex": 10, "value": { "uri": "/test/*", "name": "test-默认路由", "id": "test", "priority": 0, "la

Re: [I] bug: restart etcd admin api /apisix/admin/routes response is error [apisix]

2023-11-29 Thread via GitHub
bzp2010 commented on issue #9618: URL: https://github.com/apache/apisix/issues/9618#issuecomment-1832279138 This bug has been identified, so I reopened this issue to track progress. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[I] discuss: clean up meaningless logic about `init_dir` [apisix]

2023-11-29 Thread via GitHub
bzp2010 opened a new issue, #10566: URL: https://github.com/apache/apisix/issues/10566 ### Description Some years ago, APISIX started using the etcd v2 API, which is somewhat different from the current etcd v3 API. APISIX creates a special key for each resource to "emphasize" that it

Re: [PR] feat: add ldap-auth-advanced plugin [apisix]

2023-11-29 Thread via GitHub
bzp2010 closed pull request #9022: feat: add ldap-auth-advanced plugin URL: https://github.com/apache/apisix/pull/9022 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[PR] docs: Add doc for ApisixConsumer [apisix-ingress-controller]

2023-11-29 Thread via GitHub
Revolyssup opened a new pull request, #2074: URL: https://github.com/apache/apisix-ingress-controller/pull/2074 ### Type of change: - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches - [ ] Documentation - [ ]

Re: [PR] feat: create new event module for decouple logic and specific library [apisix]

2023-11-29 Thread via GitHub
bzp2010 commented on code in PR #10558: URL: https://github.com/apache/apisix/pull/10558#discussion_r1409347315 ## apisix/event.lua: ## @@ -0,0 +1,70 @@ +-- +-- Licensed to the Apache Software Foundation (ASF) under one or more +-- contributor license agreements. See the NOTICE

Re: [PR] fix(plugin/opa): safely remove upstream when sending route to opa [apisix]

2023-11-29 Thread via GitHub
bzp2010 commented on code in PR #10552: URL: https://github.com/apache/apisix/pull/10552#discussion_r1409335011 ## ci/pod/opa/allow_get.rego: ## @@ -0,0 +1,20 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the

Re: [I] bug: Routing configuration not taking effect, and the backend reports an etcd error. [apisix-ingress-controller]

2023-11-29 Thread via GitHub
wumengchao commented on issue #2071: URL: https://github.com/apache/apisix-ingress-controller/issues/2071#issuecomment-1831955354 15 pods refer to ingress-apisix-composite. When the pod routing configuration became invalid, I connected to the problematic pod's 12379 port using etcdkeeper

Re: [PR] fix: use proxy_protocol_addr instead of remote_addr in proxy-protocol case [apisix]

2023-11-29 Thread via GitHub
bzp2010 commented on PR #10543: URL: https://github.com/apache/apisix/pull/10543#issuecomment-1831951538 @heresie Excellent discussion, but perhaps there are some misunderstandings here. We discuss this in two dimensions: Nginx and APISIX. -- For Nginx, when you conf

Re: [I] discuss: the requirement of `client_secret` in `openid-connect` plugin [apisix]

2023-11-29 Thread via GitHub
kayx23 commented on issue #10563: URL: https://github.com/apache/apisix/issues/10563#issuecomment-1831840990 Maybe? But it won't just be simply adding cases to `.t` file. For example for private key JWT, the keycloak instance provisioned for CI would need to be updated as well. Probab

Re: [I] bug: response-rewrite filters.regex does not apply when content-encoding: gzip [apisix]

2023-11-29 Thread via GitHub
JoonaHa commented on issue #10562: URL: https://github.com/apache/apisix/issues/10562#issuecomment-1831820995 @yuweizzz By default APISIX seems to accepts gzip encoded data so the ideal situation would be for `response-rewrite` to also support different encoding methods. Or at least men

Re: [I] bug: response-rewrite filters.regex does not apply when content-encoding: gzip [apisix]

2023-11-29 Thread via GitHub
yuweizzz commented on issue #10562: URL: https://github.com/apache/apisix/issues/10562#issuecomment-1831777095 Do you think we still need to support encoded data in `response-rewrite`? @shreemaan-abhishek @JoonaHa -- This is an automated message from the Apache Git Service. To respond to

Re: [I] bug: response-rewrite filters.regex does not apply when content-encoding: gzip [apisix]

2023-11-29 Thread via GitHub
yuweizzz commented on issue #10562: URL: https://github.com/apache/apisix/issues/10562#issuecomment-1831772928 use `"Accept-Encoding": ""` tell upstream don't compress the payload, it need to work with `proxy-rewrite`, the another way is disable compression on upstream, it doesn't need a ne

Re: [I] discuss: the requirement of `client_secret` in `openid-connect` plugin [apisix]

2023-11-29 Thread via GitHub
shreemaan-abhishek commented on issue #10563: URL: https://github.com/apache/apisix/issues/10563#issuecomment-1831764537 > add relevant test cases if needed. I agree. Can this be a good first issue? -- This is an automated message from the Apache Git Service. To respond to th

Re: [PR] fix(plugin/opa): safely remove upstream when sending route to opa [apisix]

2023-11-29 Thread via GitHub
shreemaan-abhishek commented on code in PR #10552: URL: https://github.com/apache/apisix/pull/10552#discussion_r1409163887 ## ci/pod/opa/allow_get.rego: ## @@ -0,0 +1,20 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements

Re: [PR] fix(plugin/opa): safely remove upstream when sending route to opa [apisix]

2023-11-29 Thread via GitHub
shreemaan-abhishek commented on code in PR #10552: URL: https://github.com/apache/apisix/pull/10552#discussion_r1409163887 ## ci/pod/opa/allow_get.rego: ## @@ -0,0 +1,20 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements

Re: [I] help request: cannot use traditional mode with apisix.yaml configuration [apisix]

2023-11-29 Thread via GitHub
yazebochan closed issue #10468: help request: cannot use traditional mode with apisix.yaml configuration URL: https://github.com/apache/apisix/issues/10468 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] feat: add brotli plugin [apisix]

2023-11-29 Thread via GitHub
monkeyDluffy6017 commented on code in PR #10515: URL: https://github.com/apache/apisix/pull/10515#discussion_r1409088004 ## .github/workflows/fuzzing-ci.yaml: ## @@ -64,7 +64,7 @@ jobs: sudo apt-get install -y git curl openresty-openssl111-dev unzip make gcc libldap2-d

Re: [I] bug: response-rewrite filters.regex does not apply when content-encoding: gzip [apisix]

2023-11-29 Thread via GitHub
JoonaHa commented on issue #10562: URL: https://github.com/apache/apisix/issues/10562#issuecomment-1831618411 For a workaround I used `proxy-rewrite`'s `headers` to set `Accept-Encoding` to an empty value so the upstream server doesn't respond with an compressed payload. ```json {

Re: [PR] fix: forward-auth request body is too large [apisix]

2023-11-29 Thread via GitHub
monkeyDluffy6017 commented on code in PR #10425: URL: https://github.com/apache/apisix/pull/10425#discussion_r1409069915 ## t/plugin/forward-auth.t: ## @@ -374,3 +403,34 @@ GET /hello --- more_headers Authorization: 111 --- error_code: 200 + + + +=== TEST 13: test large body

[I] request help: auditlog not working in apisix with coraza-filter [apisix-ingress-controller]

2023-11-29 Thread via GitHub
donghuuhieu137 opened a new issue, #2073: URL: https://github.com/apache/apisix-ingress-controller/issues/2073 ### Issue description I am using Openshift version 4.13, I deployed apisix using HelmChart apisix and added coroza-filter plugin, below is the route configuration: ```

Re: [I] help request: how to upgrade the dependencies of apisix [apisix]

2023-11-29 Thread via GitHub
shreemaan-abhishek commented on issue #10532: URL: https://github.com/apache/apisix/issues/10532#issuecomment-1831587848 any updates @gliffcheung -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [I] chore: metadata log format is irrelevant [apisix]

2023-11-29 Thread via GitHub
Vacant2333 commented on issue #10494: URL: https://github.com/apache/apisix/issues/10494#issuecomment-1831585085 I have found the same issue in other logger plugins, and some plugins use this format(https://github.com/Vacant2333/apisix/blob/94fc894889d75422ee9b64f91ec3369158d19648/apisix/pl

Re: [I] request help: How to generate the apisix schema.json file [apisix-ingress-controller]

2023-11-29 Thread via GitHub
donghuuhieu137 commented on issue #2072: URL: https://github.com/apache/apisix-ingress-controller/issues/2072#issuecomment-1831578286 you can manually create a schema.json and mount to /usr/local/apisix-dashboard/conf/schema.json in apisix-dashboard, here's what I'm using: ``` "cora

Re: [I] request help: How to generate the apisix schema.json file [apisix-ingress-controller]

2023-11-29 Thread via GitHub
donghuuhieu137 commented on issue #2072: URL: https://github.com/apache/apisix-ingress-controller/issues/2072#issuecomment-1831572527 you can manually generate a schema to /usr/local/apisix/conf/config.yaml for coraza -- This is an automated message from the Apache Git Service. To respon

Re: [I] feat: support Discovery Center - PolarisMesh [apisix]

2023-11-29 Thread via GitHub
pemako commented on issue #7574: URL: https://github.com/apache/apisix/issues/7574#issuecomment-1831564453 @tokers the feat has been closed without any description, can this feature be supported? I really hope that this feat can be supported. Thank you very much. Looking forward to your re

Re: [PR] fix: forward-auth request body is too large [apisix]

2023-11-29 Thread via GitHub
monkeyDluffy6017 commented on code in PR #10425: URL: https://github.com/apache/apisix/pull/10425#discussion_r1409012266 ## apisix/plugins/forward-auth.lua: ## @@ -106,16 +106,20 @@ function _M.access(conf, ctx) method = conf.request_method } +local httpc = h

Re: [PR] fix: forward-auth request body is too large [apisix]

2023-11-29 Thread via GitHub
monkeyDluffy6017 commented on code in PR #10425: URL: https://github.com/apache/apisix/pull/10425#discussion_r1409012266 ## apisix/plugins/forward-auth.lua: ## @@ -106,16 +106,20 @@ function _M.access(conf, ctx) method = conf.request_method } +local httpc = h

Re: [PR] fix: forward-auth request body is too large [apisix]

2023-11-29 Thread via GitHub
monkeyDluffy6017 commented on code in PR #10425: URL: https://github.com/apache/apisix/pull/10425#discussion_r1409012266 ## apisix/plugins/forward-auth.lua: ## @@ -106,16 +106,20 @@ function _M.access(conf, ctx) method = conf.request_method } +local httpc = h

Re: [PR] fix: forward-auth request body is too large [apisix]

2023-11-29 Thread via GitHub
monkeyDluffy6017 commented on code in PR #10425: URL: https://github.com/apache/apisix/pull/10425#discussion_r1409012266 ## apisix/plugins/forward-auth.lua: ## @@ -106,16 +106,20 @@ function _M.access(conf, ctx) method = conf.request_method } +local httpc = h

Re: [PR] fix: forward-auth request body is too large [apisix]

2023-11-29 Thread via GitHub
monkeyDluffy6017 commented on code in PR #10425: URL: https://github.com/apache/apisix/pull/10425#discussion_r1409012266 ## apisix/plugins/forward-auth.lua: ## @@ -106,16 +106,20 @@ function _M.access(conf, ctx) method = conf.request_method } +local httpc = h

Re: [I] bug: Routing configuration not taking effect, and the backend reports an etcd error. [apisix-ingress-controller]

2023-11-29 Thread via GitHub
Revolyssup commented on issue #2071: URL: https://github.com/apache/apisix-ingress-controller/issues/2071#issuecomment-1831489893 @wumengchao something like this ![Uploading Screenshot 2023-11-29 at 2.33.34 PM.png…]() -- This is an automated message from the Apache Git Service. To

  1   2   >