[GitHub] [apisix] mscb402 commented on issue #8710: 前后端跨域问题 CORS policy

2023-01-18 Thread GitBox
mscb402 commented on issue #8710: URL: https://github.com/apache/apisix/issues/8710#issuecomment-1396483717 You can close this issue now :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix] githubxubin closed issue #8710: 前后端跨域问题 CORS policy

2023-01-18 Thread GitBox
githubxubin closed issue #8710: 前后端跨域问题 CORS policy URL: https://github.com/apache/apisix/issues/8710 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [apisix] githubxubin commented on issue #8710: 前后端跨域问题 CORS policy

2023-01-18 Thread GitBox
githubxubin commented on issue #8710: URL: https://github.com/apache/apisix/issues/8710#issuecomment-1396470001 > If still have a problem, you can set `Access-Control-Allow-Origin: http://domain.com`. Change domain.com to your domain okey ~ thanks it is ok -- This is an automated

[GitHub] [apisix] mscb402 commented on issue #8710: 前后端跨域问题 CORS policy

2023-01-18 Thread GitBox
mscb402 commented on issue #8710: URL: https://github.com/apache/apisix/issues/8710#issuecomment-1396469247 If still have a problem, you can set `Access-Control-Allow-Origin: http://domain.com`. Change domain.com to your domain -- This is an automated message from the Apache Git

[GitHub] [apisix] mscb402 commented on issue #8709: help request: Setting up routing path

2023-01-18 Thread GitBox
mscb402 commented on issue #8709: URL: https://github.com/apache/apisix/issues/8709#issuecomment-1396406154 This is a example of how to config `regex_uri` in proxy_rewrite `regex_uri :["^/food/(.*)$", "/$1"]` -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [apisix] mscb402 commented on issue #8709: help request: Setting up routing path

2023-01-18 Thread GitBox
mscb402 commented on issue #8709: URL: https://github.com/apache/apisix/issues/8709#issuecomment-1396404919 If you want to access `/food/v1/dashes` and return contents by path `/v1/dashes`. You need to add a proxy-rewrite plugin. https://apisix.apache.org/docs/apisix/plugins/proxy-rewrite/

[GitHub] [apisix] mscb402 commented on issue #8709: help request: Setting up routing path

2023-01-18 Thread GitBox
mscb402 commented on issue #8709: URL: https://github.com/apache/apisix/issues/8709#issuecomment-1396403642 Does this `Whitelabel Error Page` is your upstream response? If so, that means your config is not right. If your upstream is "example.com" if you set `/*` and access `/v1/dashes`

[GitHub] [apisix-website] juzhiyuan merged pull request #1468: Add blog post "Accessing Apisix-dashboard from everywhere with Keycloak authentication"

2023-01-18 Thread GitBox
juzhiyuan merged PR #1468: URL: https://github.com/apache/apisix-website/pull/1468 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [apisix-website] juzhiyuan commented on a diff in pull request #1468: Add blog post "Accessing Apisix-dashboard from everywhere with Keycloak authentication"

2023-01-18 Thread GitBox
juzhiyuan commented on code in PR #1468: URL: https://github.com/apache/apisix-website/pull/1468#discussion_r1080776370 ## blog/en/blog/2023/01/02/accessing_apisix-dashboard_from_everywhere_with_keycloak_authentication.md: ## @@ -0,0 +1,1152 @@ +--- +title: "Accessing

[GitHub] [apisix] mscb402 opened a new pull request, #8711: feat: file logger plugin support response body in variable

2023-01-18 Thread GitBox
mscb402 opened a new pull request, #8711: URL: https://github.com/apache/apisix/pull/8711 ### Description We need to add a new var resp_body to let the user put it in a log format which let the user use the response in the way there want. Fixes #8705 ### Checklist

[GitHub] [apisix] mscb402 commented on issue #8710: 前后端跨域问题 CORS policy

2023-01-18 Thread GitBox
mscb402 commented on issue #8710: URL: https://github.com/apache/apisix/issues/8710#issuecomment-1396397833 Maybe you can set allow credentials to true. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [apisix-website] juzhiyuan commented on pull request #1468: Add blog post "Accessing Apisix-dashboard from everywhere with Keycloak authentication"

2023-01-18 Thread GitBox
juzhiyuan commented on PR #1468: URL: https://github.com/apache/apisix-website/pull/1468#issuecomment-1396397685 Thanks to @MirtoBusico and @Yilialinn! > Hi @juzhiyuan, I've done my review. Hope you can change the status from draft to approve if you have no questions I just

[GitHub] [apisix-website] KID-G opened a new pull request, #1480: docs:add what is service mesh blog

2023-01-18 Thread GitBox
KID-G opened a new pull request, #1480: URL: https://github.com/apache/apisix-website/pull/1480 Changes: Add what is service mesh blog -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix-website] netlify[bot] commented on pull request #1480: docs:add what is service mesh blog

2023-01-18 Thread GitBox
netlify[bot] commented on PR #1480: URL: https://github.com/apache/apisix-website/pull/1480#issuecomment-1396395376 ###  Deploy Preview for *apache-apisix* processing. | Name | Link | |-|| | Latest commit |

[GitHub] [apisix] githubxubin opened a new issue, #8710: 前后端跨域问题 CORS policy

2023-01-18 Thread GitBox
githubxubin opened a new issue, #8710: URL: https://github.com/apache/apisix/issues/8710 ### Description 1.新建路由 开启cors 插件 `{ "uri": "/cor/*", "name": "test", "desc": "test", "methods": [ "GET", "POST", "PUT", "DELETE", "PATCH",

[GitHub] [apisix-website] Fabriceli commented on a diff in pull request #1478: docs: add apisix with consul blog

2023-01-18 Thread GitBox
Fabriceli commented on code in PR #1478: URL: https://github.com/apache/apisix-website/pull/1478#discussion_r1080763913 ## blog/zh/blog/2023/01/18/consul-with-apisix.md: ## @@ -0,0 +1,271 @@ +--- +title: "Apache APISIX 集成原生 Consul 服务发现能力" +authors: + - name: "李奕浩" +title:

[GitHub] [apisix-website] Fabriceli commented on a diff in pull request #1478: docs: add apisix with consul blog

2023-01-18 Thread GitBox
Fabriceli commented on code in PR #1478: URL: https://github.com/apache/apisix-website/pull/1478#discussion_r1080763797 ## blog/zh/blog/2023/01/18/consul-with-apisix.md: ## @@ -0,0 +1,271 @@ +--- +title: "Apache APISIX 集成原生 Consul 服务发现能力" +authors: + - name: "李奕浩" +title:

[GitHub] [apisix-website] netlify[bot] commented on pull request #1479: docs:add weekly report 20230115

2023-01-18 Thread GitBox
netlify[bot] commented on PR #1479: URL: https://github.com/apache/apisix-website/pull/1479#issuecomment-1396377833 ###  Deploy Preview for *apache-apisix* processing. | Name | Link | |-|| | Latest commit |

[GitHub] [apisix-website] KID-G opened a new pull request, #1479: docs:add weekly report 20230115

2023-01-18 Thread GitBox
KID-G opened a new pull request, #1479: URL: https://github.com/apache/apisix-website/pull/1479 Changes: Add weekly report 20230115 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [apisix-website] SylviaBABY commented on a diff in pull request #1478: docs: add apisix with consul blog

2023-01-18 Thread GitBox
SylviaBABY commented on code in PR #1478: URL: https://github.com/apache/apisix-website/pull/1478#discussion_r1080753000 ## blog/en/blog/2023/01/18/consul-with-apisix.md: ## @@ -0,0 +1,278 @@ +--- +title: "How to Integrate API Gateway and Consul? Not Consul K/V" +authors: + -

[GitHub] [apisix-website] Fabriceli commented on pull request #1478: docs: add apisix with consul blog

2023-01-18 Thread GitBox
Fabriceli commented on PR #1478: URL: https://github.com/apache/apisix-website/pull/1478#issuecomment-1396349413 > @Fabriceli thanks for your contribution! Looking forward to this article. > > You can check this part to fix Lint errors

[GitHub] [apisix-ingress-controller] Fabriceli commented on issue #1587: feat request: ApisixConsumer CRD add openid-connect support

2023-01-18 Thread GitBox
Fabriceli commented on issue #1587: URL: https://github.com/apache/apisix-ingress-controller/issues/1587#issuecomment-1396348718 > @Fabriceli APISIX consumer is used for those built-in **internal** authentication, which replies on users to configure the auth credentials on the consumer,

[GitHub] [apisix] SylviaBABY commented on issue #8698: [docs]: deployment-role.md is not exist

2023-01-18 Thread GitBox
SylviaBABY commented on issue #8698: URL: https://github.com/apache/apisix/issues/8698#issuecomment-1396345588 > @SylviaBABY @yzeng25 Hi, do you have time to fix this? will fix it this week, thanks for remind -- This is an automated message from the Apache Git Service. To respond

[GitHub] [apisix-dashboard] ronething commented on issue #2716: Support configuring multiple prefixes of etcd for apisix-dashboard

2023-01-18 Thread GitBox
ronething commented on issue #2716: URL: https://github.com/apache/apisix-dashboard/issues/2716#issuecomment-1396339009 same as https://github.com/apache/apisix-dashboard/issues/2549 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix] SkyeYoung commented on issue #8698: [docs]: deployment-role.md is not exist

2023-01-18 Thread GitBox
SkyeYoung commented on issue #8698: URL: https://github.com/apache/apisix/issues/8698#issuecomment-1396333688 @SylviaBABY @yzeng25 Hi, do you have time to fix this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [apisix-ingress-controller] tokers commented on issue #1587: feat request: ApisixConsumer CRD add openid-connect support

2023-01-18 Thread GitBox
tokers commented on issue #1587: URL: https://github.com/apache/apisix-ingress-controller/issues/1587#issuecomment-1396326953 @Fabriceli APISIX consumer is used for those built-in **internal** authentication, which replies on users to configure the auth credentials on the consumer, while

[GitHub] [apisix-website] SylviaBABY commented on pull request #1478: docs: add apisix with consul blog

2023-01-18 Thread GitBox
SylviaBABY commented on PR #1478: URL: https://github.com/apache/apisix-website/pull/1478#issuecomment-1396326549 @Fabriceli thanks for your contribution! Looking forward to this article. You can check this part to fix Lint errors

[GitHub] [apisix-ingress-controller] AlinsRan opened a new pull request, #1605: doc: add svc-namespace description to the annotations

2023-01-18 Thread GitBox
AlinsRan opened a new pull request, #1605: URL: https://github.com/apache/apisix-ingress-controller/pull/1605 ### Type of change: - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches ### What this PR does / why we

[GitHub] [apisix-ingress-controller] jensg-st commented on issue #1602: bug: DNS resolution on Ubuntu 22.04.1 LTS

2023-01-18 Thread GitBox
jensg-st commented on issue #1602: URL: https://github.com/apache/apisix-ingress-controller/issues/1602#issuecomment-1387359424 The `etc/resolv.conf` looks alright: ``` search apisix.svc.cluster.local svc.cluster.local cluster.local local.ds-networks.de nameserver 10.43.0.10

[GitHub] [apisix] tao12345666333 commented on issue #8686: feat: As a user, I want to the consumer support openid-connect plugin as an auth plugin, so that we can use openid-connect plugin to config c

2023-01-18 Thread GitBox
tao12345666333 commented on issue #8686: URL: https://github.com/apache/apisix/issues/8686#issuecomment-1387230513 cc @soulbird @spacewander -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #1587: feat request: ApisixConsumer CRD add openid-connect support

2023-01-18 Thread GitBox
tao12345666333 commented on issue #1587: URL: https://github.com/apache/apisix-ingress-controller/issues/1587#issuecomment-1387229094 Thanks, I will back tomorrow -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [apisix] mgonzaga1990 opened a new issue, #8709: help request: Setting up routing path

2023-01-18 Thread GitBox
mgonzaga1990 opened a new issue, #8709: URL: https://github.com/apache/apisix/issues/8709 ### Description I have Apache APISIX setup in docker and it is using consul service discovery. Everything works fine if my route is **/*** however if I changed it to something like

[GitHub] [apisix-website] Yilialinn commented on pull request #1468: Add blog post "Accessing Apisix-dashboard from everywhere with Keycloak authentication"

2023-01-18 Thread GitBox
Yilialinn commented on PR #1468: URL: https://github.com/apache/apisix-website/pull/1468#issuecomment-1386887578 Hi @juzhiyuan, I've done my review. Hope you can change the status from draft to approve if you have no questions -- This is an automated message from the Apache Git Service.

[GitHub] [apisix-ingress-controller] Gallardot opened a new pull request, #1604: docs: update prowered-by.md

2023-01-18 Thread GitBox
Gallardot opened a new pull request, #1604: URL: https://github.com/apache/apisix-ingress-controller/pull/1604 Thanks to the community, great job! ### Type of change: - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #1602: bug: DNS resolution on Ubuntu 22.04.1 LTS

2023-01-18 Thread GitBox
tao12345666333 commented on issue #1602: URL: https://github.com/apache/apisix-ingress-controller/issues/1602#issuecomment-1386734933 Can you try to exec into the pod and look at `/etc/resolv.conf` ? > Other than that you can close the issue because we are building our own

[GitHub] [apisix-website] netlify[bot] commented on pull request #1478: docs: add apisix with consul blog

2023-01-18 Thread GitBox
netlify[bot] commented on PR #1478: URL: https://github.com/apache/apisix-website/pull/1478#issuecomment-1386727588 ###  Deploy Preview for *apache-apisix* processing. | Name | Link | |-|| | Latest commit |

[GitHub] [apisix-website] Fabriceli opened a new pull request, #1478: docs: add apisix with consul blog

2023-01-18 Thread GitBox
Fabriceli opened a new pull request, #1478: URL: https://github.com/apache/apisix-website/pull/1478 Fixes: #[Add issue number here] Changes: add apisix with consul blog Screenshots of the change: -- This is an automated message from the Apache Git

[GitHub] [apisix] monkeyDluffy6017 commented on issue #8702: if etcd is down,the apisix not affect service?

2023-01-18 Thread GitBox
monkeyDluffy6017 commented on issue #8702: URL: https://github.com/apache/apisix/issues/8702#issuecomment-1386726390 > if etcd cluster is down ,the apisix also can handle the requests Yes, Just can't update the data anymore after the etcd cluster is down -- This is an automated

[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #1603: chore(deps): bump some dependencies

2023-01-18 Thread GitBox
codecov-commenter commented on PR #1603: URL: https://github.com/apache/apisix-ingress-controller/pull/1603#issuecomment-1386716080 #

[GitHub] [apisix] snail2sky opened a new issue, #8708: apisix 能否支持对管理人员更细粒度的授权

2023-01-18 Thread GitBox
snail2sky opened a new issue, #8708: URL: https://github.com/apache/apisix/issues/8708 ### Description 1. 目前只要能登陆到apisix的dashboard,那么就能操作dashboard的所有功能,这其实在生产环境中是很危险的,目前是否支持更细粒度的授权? 2.

[GitHub] [apisix-ingress-controller] tao12345666333 opened a new pull request, #1603: chore(deps): bump some dependencies

2023-01-18 Thread GitBox
tao12345666333 opened a new pull request, #1603: URL: https://github.com/apache/apisix-ingress-controller/pull/1603 ### Type of change: - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches ### What this PR does / why

[GitHub] [apisix-website] Yilialinn commented on a diff in pull request #1468: Add blog post "Accessing Apisix-dashboard from everywhere with Keycloak authentication"

2023-01-18 Thread GitBox
Yilialinn commented on code in PR #1468: URL: https://github.com/apache/apisix-website/pull/1468#discussion_r1073252529 ## blog/en/blog/2023/01/02/accessing_apisix-dashboard_from_everywhere_with_keycloak_authentication.md: ## @@ -0,0 +1,1152 @@ +--- +title: "Accessing

[GitHub] [apisix-helm-chart] tokers merged pull request #413: doc: update apisix doc for new users

2023-01-18 Thread GitBox
tokers merged PR #413: URL: https://github.com/apache/apisix-helm-chart/pull/413 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [apisix] unsw-luopan commented on issue #8540: bug: can't run apifix by offical document

2023-01-18 Thread GitBox
unsw-luopan commented on issue #8540: URL: https://github.com/apache/apisix/issues/8540#issuecomment-1386679494 save my life..same error, same mirror -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix] uran0sH commented on issue #5453: request help: proxy-cache plugin, why the cache expiration time cannot be configured dynamically?

2023-01-18 Thread GitBox
uran0sH commented on issue #5453: URL: https://github.com/apache/apisix/issues/5453#issuecomment-1386676004 So do I need to modify the config of Nginx and reload it in `header_filter`? Are there some operations to modify the config of Nginx? I am so confused about it. Could you give me

[GitHub] [apisix] huacnlee opened a new pull request, #8707: Improve autocorrect

2023-01-17 Thread GitBox
huacnlee opened a new pull request, #8707: URL: https://github.com/apache/apisix/pull/8707 ### Description Fixes # (issue) ### Checklist - [ ] I have explained the need for this PR and the problem it solves - [ ] I have explained the changes or the new

[GitHub] [apisix] JohnQI8888 commented on issue #8680: help request: 是否有文档可以指导实现多环境

2023-01-17 Thread GitBox
JohnQI commented on issue #8680: URL: https://github.com/apache/apisix/issues/8680#issuecomment-1386565194 > > 支持 /* 这样的通配符吗? > > you can have a try Thanks for help, and another problem is we still work in apisix 1.6.x, I don't think it can work for us. -- This is an

[GitHub] [apisix] Fabriceli commented on a diff in pull request #8651: fix: fix fetch all service info from consul

2023-01-17 Thread GitBox
Fabriceli commented on code in PR #8651: URL: https://github.com/apache/apisix/pull/8651#discussion_r1073110176 ## apisix/discovery/consul/init.lua: ## @@ -242,48 +215,76 @@ function _M.connect(premature, consul_server, retry_delay) -- if current index different last

[GitHub] [apisix] e1ijah1 commented on a diff in pull request #8681: feat(file-logger): support standard output for file logger plugins

2023-01-17 Thread GitBox
e1ijah1 commented on code in PR #8681: URL: https://github.com/apache/apisix/pull/8681#discussion_r1073070382 ## t/cli/plugin/test_file_logger_std_output.sh: ## @@ -0,0 +1,75 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF) under one or more +#

[GitHub] [apisix-website] netlify[bot] commented on pull request #1477: chore(deps): bump peaceiris/actions-gh-pages from 3.9.0 to 3.9.2

2023-01-17 Thread GitBox
netlify[bot] commented on PR #1477: URL: https://github.com/apache/apisix-website/pull/1477#issuecomment-1386453065 ###  Deploy Preview for *apache-apisix* processing. | Name | Link | |-|| | Latest commit |

[GitHub] [apisix-website] dependabot[bot] commented on pull request #1465: chore(deps): bump peaceiris/actions-gh-pages from 3.9.0 to 3.9.1

2023-01-17 Thread GitBox
dependabot[bot] commented on PR #1465: URL: https://github.com/apache/apisix-website/pull/1465#issuecomment-1386452168 Superseded by #1477. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix-website] dependabot[bot] closed pull request #1465: chore(deps): bump peaceiris/actions-gh-pages from 3.9.0 to 3.9.1

2023-01-17 Thread GitBox
dependabot[bot] closed pull request #1465: chore(deps): bump peaceiris/actions-gh-pages from 3.9.0 to 3.9.1 URL: https://github.com/apache/apisix-website/pull/1465 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix-website] dependabot[bot] opened a new pull request, #1477: chore(deps): bump peaceiris/actions-gh-pages from 3.9.0 to 3.9.2

2023-01-17 Thread GitBox
dependabot[bot] opened a new pull request, #1477: URL: https://github.com/apache/apisix-website/pull/1477 Bumps [peaceiris/actions-gh-pages](https://github.com/peaceiris/actions-gh-pages) from 3.9.0 to 3.9.2. Release notes Sourced from

[GitHub] [apisix] e1ijah1 commented on a diff in pull request #8681: feat(file-logger): support standard output for file logger plugins

2023-01-17 Thread GitBox
e1ijah1 commented on code in PR #8681: URL: https://github.com/apache/apisix/pull/8681#discussion_r1073070382 ## t/cli/plugin/test_file_logger_std_output.sh: ## @@ -0,0 +1,75 @@ +#!/usr/bin/env bash + +# +# Licensed to the Apache Software Foundation (ASF) under one or more +#

[GitHub] [apisix] ronething commented on pull request #8640: feat: stream subsystem support kubernetes service discovery

2023-01-17 Thread GitBox
ronething commented on PR #8640: URL: https://github.com/apache/apisix/pull/8640#issuecomment-1386445246 @tokers @soulbird Could you please take a look, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [apisix] shreemaan-abhishek commented on a diff in pull request #8660: change(jwt-auth): unify apisix/core/vault.lua and apisix/secret/vault.lua

2023-01-17 Thread GitBox
shreemaan-abhishek commented on code in PR #8660: URL: https://github.com/apache/apisix/pull/8660#discussion_r1073068637 ## apisix/plugins/jwt-auth.lua: ## @@ -274,32 +234,16 @@ end local function get_rsa_or_ecdsa_keypair(conf, consumer_name) local public_key =

[GitHub] [apisix] shreemaan-abhishek commented on a diff in pull request #8660: change(jwt-auth): unify apisix/core/vault.lua and apisix/secret/vault.lua

2023-01-17 Thread GitBox
shreemaan-abhishek commented on code in PR #8660: URL: https://github.com/apache/apisix/pull/8660#discussion_r1073068637 ## apisix/plugins/jwt-auth.lua: ## @@ -274,32 +234,16 @@ end local function get_rsa_or_ecdsa_keypair(conf, consumer_name) local public_key =

[GitHub] [apisix] shreemaan-abhishek commented on a diff in pull request #8660: change(jwt-auth): unify apisix/core/vault.lua and apisix/secret/vault.lua

2023-01-17 Thread GitBox
shreemaan-abhishek commented on code in PR #8660: URL: https://github.com/apache/apisix/pull/8660#discussion_r1073068429 ## apisix/plugins/jwt-auth.lua: ## @@ -274,32 +234,16 @@ end local function get_rsa_or_ecdsa_keypair(conf, consumer_name) local public_key =

[GitHub] [apisix] spacewander commented on a diff in pull request #8681: feat(file-logger): support standard output for file logger plugins

2023-01-17 Thread GitBox
spacewander commented on code in PR #8681: URL: https://github.com/apache/apisix/pull/8681#discussion_r1073059505 ## apisix/plugins/file-logger.lua: ## @@ -39,7 +41,7 @@ local schema = { } } }, -required = {"path"} +required = { "path" }

[GitHub] [apisix-website] yzeng25 merged pull request #1476: docs:add mafengwo usercase blog

2023-01-17 Thread GitBox
yzeng25 merged PR #1476: URL: https://github.com/apache/apisix-website/pull/1476 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [apisix] mscb402 commented on issue #8705: feat: As a user, I want file-logger plugin support record response body in a custom format, so that make the log format more flexible

2023-01-17 Thread GitBox
mscb402 commented on issue #8705: URL: https://github.com/apache/apisix/issues/8705#issuecomment-1386436970 @spacewander -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [apisix] mscb402 commented on issue #8705: feat: As a user, I want file-logger plugin support record response body in a custom format, so that make the log format more flexible

2023-01-17 Thread GitBox
mscb402 commented on issue #8705: URL: https://github.com/apache/apisix/issues/8705#issuecomment-1386436647 @tokers -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [apisix] mscb402 opened a new issue, #8705: feat: As a user, I want file-logger plugin support record response body in a custom format, so that make the log format more flexible

2023-01-17 Thread GitBox
mscb402 opened a new issue, #8705: URL: https://github.com/apache/apisix/issues/8705 ### Description As a user, I would like the file-logger plugin to support logging the response body in a custom format to make the logging format more flexible. Currently the file-logger plugin

[GitHub] [apisix] spacewander commented on a diff in pull request #8651: fix: fix fetch all service info from consul

2023-01-17 Thread GitBox
spacewander commented on code in PR #8651: URL: https://github.com/apache/apisix/pull/8651#discussion_r1073064191 ## apisix/discovery/consul/init.lua: ## @@ -242,48 +215,76 @@ function _M.connect(premature, consul_server, retry_delay) -- if current index different last

[GitHub] [apisix] spacewander commented on issue #5453: request help: proxy-cache plugin, why the cache expiration time cannot be configured dynamically?

2023-01-17 Thread GitBox
spacewander commented on issue #5453: URL: https://github.com/apache/apisix/issues/5453#issuecomment-1386432946 It uses nginx's proxy-cache -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix-website] yzeng25 commented on pull request #1476: docs:add mafengwo usercase blog

2023-01-17 Thread GitBox
yzeng25 commented on PR #1476: URL: https://github.com/apache/apisix-website/pull/1476#issuecomment-1386426670 PTAL @SylviaBABY , cc @SkyeYoung @juzhiyuan . - Displayed properly under **Blog** and **Case Studies** page - Author's properties all checked valid - Blog content all

[GitHub] [apisix] e1ijah1 commented on pull request #8681: feat(file-logger): support standard output for file logger plugins

2023-01-17 Thread GitBox
e1ijah1 commented on PR #8681: URL: https://github.com/apache/apisix/pull/8681#issuecomment-1386421353 > Can you add a test in https://github.com/apache/apisix/tree/master/t/cli? The test has been added. Please take a look if you're available. @spacewander -- This is an automated

[GitHub] [apisix-helm-chart] tao12345666333 commented on pull request #297: #296: added admin ingress

2023-01-17 Thread GitBox
tao12345666333 commented on PR #297: URL: https://github.com/apache/apisix-helm-chart/pull/297#issuecomment-1386418081 Hi, #442 has been merged, which allows exposing admin API through Ingress. https://github.com/apache/apisix-helm-chart/pull/442#issuecomment-1376806537 This reason

[GitHub] [apisix-helm-chart] tao12345666333 closed issue #441: feat: allow exposing admin api via ingress resource

2023-01-17 Thread GitBox
tao12345666333 closed issue #441: feat: allow exposing admin api via ingress resource URL: https://github.com/apache/apisix-helm-chart/issues/441 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix-helm-chart] tao12345666333 commented on issue #441: feat: allow exposing admin api via ingress resource

2023-01-17 Thread GitBox
tao12345666333 commented on issue #441: URL: https://github.com/apache/apisix-helm-chart/issues/441#issuecomment-1386413589 ok, #442 has been merged, I will close this one, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [apisix-helm-chart] tao12345666333 merged pull request #401: fix: enable tls for the tcp address

2023-01-17 Thread GitBox
tao12345666333 merged PR #401: URL: https://github.com/apache/apisix-helm-chart/pull/401 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [apisix] spacewander commented on a diff in pull request #8660: change(jwt-auth): unify apisix/core/vault.lua and apisix/secret/vault.lua

2023-01-17 Thread GitBox
spacewander commented on code in PR #8660: URL: https://github.com/apache/apisix/pull/8660#discussion_r1073050987 ## apisix/plugins/jwt-auth.lua: ## @@ -274,32 +234,16 @@ end local function get_rsa_or_ecdsa_keypair(conf, consumer_name) local public_key = conf.public_key

[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #610: proposal: New architecture of Apache APISIX Ingress controller

2023-01-17 Thread GitBox
tao12345666333 commented on issue #610: URL: https://github.com/apache/apisix-ingress-controller/issues/610#issuecomment-1386361494 ![2023-01-18 09-56-25屏幕截图](https://user-images.githubusercontent.com/3264292/213062313-eb915ee9-560f-47d3-976d-94cf8f9b939a.png) I have a new idea.

[GitHub] [apisix-website] yzeng25 commented on a diff in pull request #1476: docs:add mafengwo usercase blog

2023-01-17 Thread GitBox
yzeng25 commented on code in PR #1476: URL: https://github.com/apache/apisix-website/pull/1476#discussion_r1073010881 ## blog/zh/blog/2023/01/15/mafengwo-with-apisix.md: ## @@ -0,0 +1,140 @@ +--- +title: "马蜂窝如何利用 APISIX 网关实现微服务架构升级 +" Review Comment: ```suggestion title:

[GitHub] [apisix] spacewander closed issue #7785: bug: The `/` in the log will be added with an extra `\` when enabled file-logger and sls-logger

2023-01-17 Thread GitBox
spacewander closed issue #7785: bug: The `/` in the log will be added with an extra `\` when enabled file-logger and sls-logger URL: https://github.com/apache/apisix/issues/7785 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [apisix] spacewander merged pull request #8684: fix: remove backslash before slash when encoding

2023-01-17 Thread GitBox
spacewander merged PR #8684: URL: https://github.com/apache/apisix/pull/8684 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [apisix] spacewander merged pull request #8672: ci: kafka should register port in the zookeeper same as exposed

2023-01-17 Thread GitBox
spacewander merged PR #8672: URL: https://github.com/apache/apisix/pull/8672 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [apisix-website] yzeng25 commented on a diff in pull request #1471: docs:add four blogs

2023-01-17 Thread GitBox
yzeng25 commented on code in PR #1471: URL: https://github.com/apache/apisix-website/pull/1471#discussion_r1073009544 ## blog/zh/blog/2023/01/11/apisix-amesh-introduction.md: ## @@ -0,0 +1,87 @@ +--- +title: "基于 APISIX 的服务网格方案 Amesh 积极开发中!" +authors: + - name: "lingsamuel" +

[GitHub] [apisix-website] SkyeYoung commented on a diff in pull request #1474: fix the display of apisix-dashboard's version and download url

2023-01-17 Thread GitBox
SkyeYoung commented on code in PR #1474: URL: https://github.com/apache/apisix-website/pull/1474#discussion_r1073008099 ## package.json: ## @@ -17,6 +17,7 @@ "scripts": { "sync-docs": "yarn workspace scripts sync-docs", "generate-repos-info": "yarn workspace

[GitHub] [apisix-website] SkyeYoung commented on a diff in pull request #1474: fix the display of apisix-dashboard's version and download url

2023-01-17 Thread GitBox
SkyeYoung commented on code in PR #1474: URL: https://github.com/apache/apisix-website/pull/1474#discussion_r1073007163 ## config/docs.json: ## @@ -0,0 +1 @@ +[{"name":"APISIX®","nameInParamCase":"apisix","description":"A dynamic, real-time, high-performance API

[GitHub] [apisix-website] yzeng25 commented on pull request #1471: docs:add four blogs

2023-01-17 Thread GitBox
yzeng25 commented on PR #1471: URL: https://github.com/apache/apisix-website/pull/1471#issuecomment-1386343155 Hi @SylviaBABY @SkyeYoung @juzhiyuan , need further review and approvals for this pull request. Review contents can be found at

[GitHub] [apisix-ingress-controller] github-actions[bot] closed issue #1322: bug: controller will erase status from ingress that uses another class

2023-01-17 Thread GitBox
github-actions[bot] closed issue #1322: bug: controller will erase status from ingress that uses another class URL: https://github.com/apache/apisix-ingress-controller/issues/1322 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [apisix-ingress-controller] github-actions[bot] commented on issue #1322: bug: controller will erase status from ingress that uses another class

2023-01-17 Thread GitBox
github-actions[bot] commented on issue #1322: URL: https://github.com/apache/apisix-ingress-controller/issues/1322#issuecomment-1386333626 This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue

[GitHub] [apisix] SylviaBABY merged pull request #8701: docs: fix plugin config naming

2023-01-17 Thread GitBox
SylviaBABY merged PR #8701: URL: https://github.com/apache/apisix/pull/8701 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [apisix] SylviaBABY merged pull request #8700: docs: fix code block

2023-01-17 Thread GitBox
SylviaBABY merged PR #8700: URL: https://github.com/apache/apisix/pull/8700 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [apisix-dashboard] cherishman2005 closed issue #2712: error An unexpected error occurred: "https://registry.yarnpkg.com/@ant-design/icons/-/icons-4.6.2.tgz: self signed certificate in certifi

2023-01-17 Thread GitBox
cherishman2005 closed issue #2712: error An unexpected error occurred: "https://registry.yarnpkg.com/@ant-design/icons/-/icons-4.6.2.tgz: self signed certificate in certificate chain". URL: https://github.com/apache/apisix-dashboard/issues/2712 -- This is an automated message from the

[GitHub] [apisix] flechter opened a new issue, #8703: Support plugin opend-id connect in stream proxy route

2023-01-17 Thread GitBox
flechter opened a new issue, #8703: URL: https://github.com/apache/apisix/issues/8703 ### Description We try to use stream proxy, but we would like to add a keycloak autorisation for using the route. When we try to add the plugin openid-connect we have the error :

[GitHub] [apisix] elkh510 commented on issue #8081: help request: access static file by custom nginx.conf but error

2023-01-17 Thread GitBox
elkh510 commented on issue #8081: URL: https://github.com/apache/apisix/issues/8081#issuecomment-1385522538 figured so in our test environment we have apisix ingress that point to test deployment. apisix contains nginx and test deployment contains nginx after we added

[GitHub] [apisix-ingress-controller] wnz27 commented on issue #1568: request help: how to define ApisixPluginConfig and in apisixroute use some other param to overwrite some param

2023-01-17 Thread GitBox
wnz27 commented on issue #1568: URL: https://github.com/apache/apisix-ingress-controller/issues/1568#issuecomment-1385478748 > > ### Issue description > > if i want to 1、define a ApisixPluginConfig use some plugin 2、define a apisixRoute and set same plugin in ApisixPluginConfig with

[GitHub] [apisix-ingress-controller] wnz27 commented on issue #1568: request help: how to define ApisixPluginConfig and in apisixroute use some other param to overwrite some param

2023-01-17 Thread GitBox
wnz27 commented on issue #1568: URL: https://github.com/apache/apisix-ingress-controller/issues/1568#issuecomment-1385477785 > You can actually try it out, they have different priorities i try it, but dont take effect. the plugin config not auto merge -- This is an automated

[GitHub] [apisix] kellyseeme opened a new issue, #8702: if etcd is down,the apisix not affect service?

2023-01-17 Thread GitBox
kellyseeme opened a new issue, #8702: URL: https://github.com/apache/apisix/issues/8702 ### Description if etcd cluster is down ,the apisix also can handle the requests?just affect if the apisix is restart or reload?how much time will be ok if etcd cluster down? ###

[GitHub] [apisix-docker] sashokbg commented on a diff in pull request #405: fix: config files overwritten by docker-entrypoint.sh

2023-01-17 Thread GitBox
sashokbg commented on code in PR #405: URL: https://github.com/apache/apisix-docker/pull/405#discussion_r1072157494 ## centos/docker-entrypoint.sh: ## @@ -22,18 +22,22 @@ PREFIX=${APISIX_PREFIX:=/usr/local/apisix} if [[ "$1" == "docker-start" ]]; then if [

[GitHub] [apisix-docker] sashokbg commented on a diff in pull request #405: fix: config files overwritten by docker-entrypoint.sh

2023-01-17 Thread GitBox
sashokbg commented on code in PR #405: URL: https://github.com/apache/apisix-docker/pull/405#discussion_r1072156896 ## centos/docker-entrypoint.sh: ## @@ -22,18 +22,22 @@ PREFIX=${APISIX_PREFIX:=/usr/local/apisix} if [[ "$1" == "docker-start" ]]; then if [

[GitHub] [apisix] ronething commented on issue #8680: help request: 是否有文档可以指导实现多环境

2023-01-17 Thread GitBox
ronething commented on issue #8680: URL: https://github.com/apache/apisix/issues/8680#issuecomment-1385255160 > 支持 /* 这样的通配符吗? you can have a try -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [apisix] JohnQI8888 commented on issue #8680: help request: 是否有文档可以指导实现多环境

2023-01-17 Thread GitBox
JohnQI commented on issue #8680: URL: https://github.com/apache/apisix/issues/8680#issuecomment-1385185623 支持 /* 这样的通配符吗? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [apisix-dashboard] huweihuang opened a new issue, #2716: Support configuring multiple prefixes of etcd for apisix-dashboard

2023-01-17 Thread GitBox
huweihuang opened a new issue, #2716: URL: https://github.com/apache/apisix-dashboard/issues/2716 Background: Because we have deployed multiple sets of apisix in a k8s cluster and used different prefixes to distinguish different apisix services. So I want to configure multiple sets of

[GitHub] [apisix] shreemaan-abhishek opened a new pull request, #8701: docs: fix plugin config naming

2023-01-17 Thread GitBox
shreemaan-abhishek opened a new pull request, #8701: URL: https://github.com/apache/apisix/pull/8701 ### Description Fixed plugin config naming. ### Checklist - [ ] I have explained the need for this PR and the problem it solves - [ ] I have explained the changes or

[GitHub] [apisix] github-actions[bot] commented on issue #5879: docs: Mention four features that can be added later

2023-01-17 Thread GitBox
github-actions[bot] commented on issue #5879: URL: https://github.com/apache/apisix/issues/5879#issuecomment-1385138777 This issue has been closed due to lack of activity. If you think that is incorrect, or the issue requires additional review, you can revive the issue at any time. --

[GitHub] [apisix] github-actions[bot] closed issue #5879: docs: Mention four features that can be added later

2023-01-17 Thread GitBox
github-actions[bot] closed issue #5879: docs: Mention four features that can be added later URL: https://github.com/apache/apisix/issues/5879 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [apisix] shreemaan-abhishek opened a new pull request, #8700: docs: fix code block

2023-01-17 Thread GitBox
shreemaan-abhishek opened a new pull request, #8700: URL: https://github.com/apache/apisix/pull/8700 ### Description The documentation for plugin config looks like this currently (inappropriate code block formatting):

<    1   2   3   4   5   6   7   8   9   10   >