[GitHub] [apisix] Firstsawyou commented on a change in pull request #2209: feature: allow empty `service` object, it does not contain any `upstream` and `plugin`.

2020-09-16 Thread GitBox
Firstsawyou commented on a change in pull request #2209: URL: https://github.com/apache/apisix/pull/2209#discussion_r489496814 ## File path: t/admin/routes.t ## @@ -1557,8 +1557,7 @@ location /t { ngx.say("code: ", code) ngx.say(body) --- etcd v3 wou

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2209: feature: allow empty `service` object, it does not contain any `upstream` and `plugin`.

2020-09-16 Thread GitBox
Firstsawyou commented on a change in pull request #2209: URL: https://github.com/apache/apisix/pull/2209#discussion_r489452597 ## File path: t/admin/routes.t ## @@ -2180,3 +2180,65 @@ GET /t --- error_code: 400 --- no_error_log [error] + + + +=== TEST 60: set empty service.

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2209: feature: allow empty `service` object, it does not contain any `upstream` and `plugin`.

2020-09-15 Thread GitBox
Firstsawyou commented on a change in pull request #2209: URL: https://github.com/apache/apisix/pull/2209#discussion_r488819427 ## File path: t/admin/schema.t ## @@ -37,10 +37,47 @@ qr/"plugins":\{"type":"object"}/ === TEST 2: get service schema +--- config +location /t

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2209: feature: allow empty `service` object, it does not contain any `upstream` and `plugin`.

2020-09-15 Thread GitBox
Firstsawyou commented on a change in pull request #2209: URL: https://github.com/apache/apisix/pull/2209#discussion_r488599115 ## File path: t/admin/services.t ## @@ -1085,3 +1085,50 @@ GET /t --- error_code: 400 --- no_error_log [error] + + + +=== TEST 31: set service(id: 1

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2209: feature: allow empty `service` object, it does not contain any `upstream` and `plugin`.

2020-09-13 Thread GitBox
Firstsawyou commented on a change in pull request #2209: URL: https://github.com/apache/apisix/pull/2209#discussion_r487616802 ## File path: t/admin/services.t ## @@ -1085,3 +1085,50 @@ GET /t --- error_code: 400 --- no_error_log [error] + + + +=== TEST 31: set service(id: 1

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2209: feature: allow empty `service` object, it does not contain any `upstream` and `plugin`.

2020-09-13 Thread GitBox
Firstsawyou commented on a change in pull request #2209: URL: https://github.com/apache/apisix/pull/2209#discussion_r487616083 ## File path: t/admin/schema.t ## @@ -40,7 +40,7 @@ qr/"plugins":\{"type":"object"}/ --- request GET /apisix/admin/schema/service --- response_body