[GitHub] [apisix] nic-chen commented on pull request #2036: feature: support etcd v3, by mocking v2 API

2020-09-15 Thread GitBox
nic-chen commented on pull request #2036: URL: https://github.com/apache/apisix/pull/2036#issuecomment-693018270 > Currently the log produced by lua-resty-etcd would show message without base64 decode. For example > > ``` > > 2020/09/15 23:18:52 [info] 1964#1964: *2 [lua] v3.l

[GitHub] [apisix] nic-chen commented on pull request #2036: feature: support etcd v3, by mocking v2 API

2020-09-14 Thread GitBox
nic-chen commented on pull request #2036: URL: https://github.com/apache/apisix/pull/2036#issuecomment-692401902 Note: I found that run `etcd` v3 on docker for mac cause high CPU usage, like: https://github.com/etcd-io/etcd/issues/11460 Running on Linux is ok.

[GitHub] [apisix] nic-chen commented on pull request #2036: feature: support etcd v3, by mocking v2 API

2020-08-22 Thread GitBox
nic-chen commented on pull request #2036: URL: https://github.com/apache/apisix/pull/2036#issuecomment-678712944 > I think we can merge this PR at next week. I think we should create a new branch that using etcd v2 before the merge,and maintain it for a while,for the users who ca

[GitHub] [apisix] nic-chen commented on pull request #2036: feature: support etcd v3, by mocking v2 API

2020-08-12 Thread GitBox
nic-chen commented on pull request #2036: URL: https://github.com/apache/apisix/pull/2036#issuecomment-673298480 > Currently there is only one error in test file, which is the last test of t/plugin/key-auth.t. Normally in etcd v2, it would add 20 consumers and find the 13th. But in current