[GitHub] [incubator-apisix] membphis commented on a change in pull request #1892: change: the timeout of `healthcheck` should be number type.

membphis commented on a change in pull request #1892: URL: https://github.com/apache/incubator-apisix/pull/1892#discussion_r460522256 ## File path: doc/health-check.md ## @@ -78,6 +78,8 @@ contains: `active` or `passive`. * `active`: To enable active health checks, you need

[GitHub] [incubator-apisix] membphis commented on issue #1901: bug: 500 error when bench limit-count plugin

membphis commented on issue #1901: URL: https://github.com/apache/incubator-apisix/issues/1901#issuecomment-663985581 one issue focus on one thing. if you have another question, please create a new issue. This is an

[GitHub] [incubator-apisix] membphis commented on issue #1836: bug: should not save the runtime data of plugin into etcd

membphis commented on issue #1836: URL: https://github.com/apache/incubator-apisix/issues/1836#issuecomment-663994064 I will fix this bug This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-apisix] membphis commented on issue #1836: bug: should not save the runtime data of plugin into etcd

membphis commented on issue #1836: URL: https://github.com/apache/incubator-apisix/issues/1836#issuecomment-663993992 @wrl96 Your way is dangerous, we don't allow dirty data to be stored in etcd. This is an automated

[GitHub] [incubator-apisix] membphis edited a comment on issue #1868: request help: do you have any plan to add waf feature?

membphis edited a comment on issue #1868: URL: https://github.com/apache/incubator-apisix/issues/1868#issuecomment-660653983 @UnderTreeTech welcome PR for them we have supported the IP Restriction and URI blocker now.

[GitHub] [incubator-apisix] membphis opened a new pull request #1910: bugfix: should not save the runtime data of plugin into `etcd`.

membphis opened a new pull request #1910: URL: https://github.com/apache/incubator-apisix/pull/1910 ### What this PR does / why we need it: as title. fixed #1836 . ### Pre-submission checklist: * [ ] Did you explain what problem does this PR

[GitHub] [incubator-apisix] membphis commented on pull request #1874: Adding CODE_STYLE.md and CODE_STYLE_CN.md for APISIX

membphis commented on pull request #1874: URL: https://github.com/apache/incubator-apisix/pull/1874#issuecomment-663986356 @yongboy many thx This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-apisix] totemofwolf commented on a change in pull request #1867: change: fix wrong info `Warning! Running apisix under /root ...`when `make init` at non-root path

totemofwolf commented on a change in pull request #1867: URL: https://github.com/apache/incubator-apisix/pull/1867#discussion_r460537412 ## File path: bin/apisix ## @@ -52,7 +52,7 @@ if script_path:sub(1, 2) == './' then error("failed to fetch current path") end

[GitHub] [incubator-apisix] membphis closed issue #1899: request help: what's the difference between conf and lru cache

membphis closed issue #1899: URL: https://github.com/apache/incubator-apisix/issues/1899 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-apisix] membphis commented on issue #1899: request help: what's the difference between conf and lru cache

membphis commented on issue #1899: URL: https://github.com/apache/incubator-apisix/issues/1899#issuecomment-663985459 of course, you can do in this way. and we can close this issue. This is an automated message from

[GitHub] [incubator-apisix] moonming commented on pull request #1909: Resolves #1902 Different upstreams use different discovery and customize the discovery schema

moonming commented on pull request #1909: URL: https://github.com/apache/incubator-apisix/pull/1909#issuecomment-664089171 > Now discovery can only use one of them at the same time @shoogoome I'm not quite sure why we need to support multiple service discoveries at the same time,

[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on pull request #327: feat(i18n): route module

juzhiyuan commented on pull request #327: URL: https://github.com/apache/incubator-apisix-dashboard/pull/327#issuecomment-664077648 Any updates? This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-apisix] UnderTreeTech opened a new issue #1911: request help: too many redis connections while using limit-count plugin

UnderTreeTech opened a new issue #1911: URL: https://github.com/apache/incubator-apisix/issues/1911 I benched limit-count plugin by 100K request, 1K concurrency and found that the redis connections is much more than pool size, there are many timewait , close wait connections, Is pool

[GitHub] [incubator-apisix] membphis commented on pull request #1867: change: fix wrong info `Warning! Running apisix under /root ...`when `make init` at non-root path

membphis commented on pull request #1867: URL: https://github.com/apache/incubator-apisix/pull/1867#issuecomment-664091485 @totemofwolf I think we can close this PR and push a new PR. I don't have the ability to review this PR, it is too big.

[GitHub] [incubator-apisix] membphis commented on issue #1911: request help: too many redis connections while using limit-count plugin

membphis commented on issue #1911: URL: https://github.com/apache/incubator-apisix/issues/1911#issuecomment-664090859 please take a look at the option `backlog` of `tcpsock:connect`: https://github.com/openresty/lua-nginx-module#tcpsockconnect it maybe useful for you.

[GitHub] [incubator-apisix] UnderTreeTech commented on issue #1911: request help: too many redis connections while using limit-count plugin

UnderTreeTech commented on issue #1911: URL: https://github.com/apache/incubator-apisix/issues/1911#issuecomment-664095683 Gotcha, I'll reply after test it. This is an automated message from the Apache Git Service. To

[GitHub] [incubator-apisix-dashboard] TikWind commented on pull request #327: feat(i18n): route module

TikWind commented on pull request #327: URL: https://github.com/apache/incubator-apisix-dashboard/pull/327#issuecomment-664077929 > Any updates? I am doing this, wait a moment. This is an automated message from the

[GitHub] [incubator-apisix] moonming commented on a change in pull request #1910: bugfix: should not save the runtime data of plugin into `etcd`.

moonming commented on a change in pull request #1910: URL: https://github.com/apache/incubator-apisix/pull/1910#discussion_r460609651 ## File path: apisix/core/json.lua ## @@ -26,6 +27,7 @@ local cached_tab = {} local _M = { version = 0.1, decode =

[GitHub] [incubator-apisix] spacewander commented on a change in pull request #1910: bugfix: should not save the runtime data of plugin into `etcd`.

spacewander commented on a change in pull request #1910: URL: https://github.com/apache/incubator-apisix/pull/1910#discussion_r460601114 ## File path: apisix/core/json.lua ## @@ -26,6 +27,7 @@ local cached_tab = {} local _M = { version = 0.1, decode =

[GitHub] [incubator-apisix] shoogoome commented on pull request #1909: Resolves #1902 Different upstreams use different discovery and customize the discovery schema

shoogoome commented on pull request #1909: URL: https://github.com/apache/incubator-apisix/pull/1909#issuecomment-664116222 @moonming Taking my company as an example, different service discovery systems have been produced under long-term operation, and different service discovery

[GitHub] [incubator-apisix] gxthrj commented on issue #1898: bug:

gxthrj commented on issue #1898: URL: https://github.com/apache/incubator-apisix/issues/1898#issuecomment-664127475 ok, get it This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-apisix-docker] membphis commented on a change in pull request #66: change: config.yaml always from the latest version of apisix

membphis commented on a change in pull request #66: URL: https://github.com/apache/incubator-apisix-docker/pull/66#discussion_r460657959 ## File path: example/README.md ## @@ -1,6 +1,8 @@ ### Run ``` +$ chmod +x config.sh +$ sh config.sh Review comment:

[GitHub] [incubator-apisix] shuaijinchao commented on pull request #1871: bugfix: failed to get `host` in health check configuration.

shuaijinchao commented on pull request #1871: URL: https://github.com/apache/incubator-apisix/pull/1871#issuecomment-664131106 > @shuaijinchao > > > Is this PR backward compatible? > > I think this PR is not backward compatible. please confirm this. @membphis this is a

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1867: change: fix wrong info `Warning! Running apisix under /root ...`when `make init` at non-root path

membphis commented on a change in pull request #1867: URL: https://github.com/apache/incubator-apisix/pull/1867#discussion_r460656236 ## File path: bin/apisix ## @@ -52,7 +52,7 @@ if script_path:sub(1, 2) == './' then error("failed to fetch current path") end -

[GitHub] [incubator-apisix] membphis merged pull request #1871: bugfix: failed to get `host` in health check configuration.

membphis merged pull request #1871: URL: https://github.com/apache/incubator-apisix/pull/1871 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-apisix] membphis closed issue #1869: bug: failed to get `host` in health check configuration.

membphis closed issue #1869: URL: https://github.com/apache/incubator-apisix/issues/1869 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[incubator-apisix] branch master updated: bugfix: failed to get `host` in health check configuration. (#1871)

This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-apisix.git The following commit(s) were added to refs/heads/master by this push: new a108d2e bugfix: failed to get

[GitHub] [incubator-apisix] membphis commented on pull request #1871: bugfix: failed to get `host` in health check configuration.

membphis commented on pull request #1871: URL: https://github.com/apache/incubator-apisix/pull/1871#issuecomment-664133602 @shuaijinchao merged, many thx This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-apisix-docker] gxthrj commented on a change in pull request #66: change: config.yaml always from the latest version of apisix

gxthrj commented on a change in pull request #66: URL: https://github.com/apache/incubator-apisix-docker/pull/66#discussion_r460655008 ## File path: example/README.md ## @@ -1,6 +1,8 @@ ### Run ``` +$ chmod +x config.sh +$ sh config.sh Review comment: the

[GitHub] [incubator-apisix] membphis commented on pull request #1871: bugfix: failed to get `host` in health check configuration.

membphis commented on pull request #1871: URL: https://github.com/apache/incubator-apisix/pull/1871#issuecomment-664132215 > @membphis this is a bug fix, using the previous data structure, so it is backward compatible. ok, got it. let us merge this PR.