nic-chen commented on a change in pull request #2239:
URL: https://github.com/apache/apisix/pull/2239#discussion_r490010272
##
File path: doc/zh-cn/plugins/hmac-auth.md
##
@@ -41,6 +41,8 @@
| `secret_key`| 必须 | 无 | 与 `access_key` 配对使用。|
| `algorithm` | 可选 | hmac-sha256 |
tokers commented on issue #2227:
URL: https://github.com/apache/apisix/issues/2227#issuecomment-693991799
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
tokers commented on issue #2245:
URL: https://github.com/apache/apisix/issues/2245#issuecomment-694019395
@membphis Sure.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
membphis opened a new issue #2247:
URL: https://github.com/apache/apisix/issues/2247
I write an example, @ShiningRush please take a look at this design.
```shell
$ ./apisix-schema help
route # fetch route schema
service # fetch service schema
tokers commented on pull request #2216:
URL: https://github.com/apache/apisix/pull/2216#issuecomment-694089015
@membphis @moonming Please help me to retry the checks , it's weird that
this failure only in linux_tengine.
membphis closed pull request #2230:
URL: https://github.com/apache/apisix/pull/2230
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
membphis commented on pull request #2230:
URL: https://github.com/apache/apisix/pull/2230#issuecomment-693935676
> In this pr, we only need to modify one file, and only need to make one
change, which is to print a warning when the Admin IP is not 127.0.0.1 and
using default token
Miss-you opened a new issue #74:
URL: https://github.com/apache/apisix-website/issues/74
Apache APISIX's official webpage is at risk of hijacking
Phenomena.
1. search the Apache APISIX website through Baidu or Google, the default is
to use the http protocol to access.
membphis opened a new pull request #2244:
URL: https://github.com/apache/apisix/pull/2244
…s Admin API,
will show a WARNING message.
### What this PR does / why we need it:
if the user used the default token and allow any IP to access Admin API,
will show a
GBXing commented on issue #2175:
URL: https://github.com/apache/apisix/issues/2175#issuecomment-693988595
@moonming
Finding that the result is not returned in
[(https://github.com/apache/apisix/blob/master/apisix/plugins/kafka-logger.lua#L91)]
results in the failure of the
juzhiyuan commented on issue #74:
URL: https://github.com/apache/apisix-website/issues/74#issuecomment-694081497
need to create an infra ticket if this issue should be fixed.
This is an automated message from the Apache Git
Caelebs commented on issue #478:
URL:
https://github.com/apache/apisix-dashboard/issues/478#issuecomment-694095697
我重新部署了一下，manager-api的镜像是基于**apisix-dashboard-1.5**这个包里面的/api目录下的Dockerfile构建的，运行起来之后/root/manager-api目录下的conf.json配置看起来应该是正常的
```
{
"conf": {
"mysql":{
membphis commented on a change in pull request #2239:
URL: https://github.com/apache/apisix/pull/2239#discussion_r48348
##
File path: doc/zh-cn/plugins/hmac-auth.md
##
@@ -41,6 +41,8 @@
| `secret_key`| 必须 | 无 | 与 `access_key` 配对使用。|
| `algorithm` | 可选 | hmac-sha256 |
membphis commented on pull request #2099:
URL: https://github.com/apache/apisix/pull/2099#issuecomment-694025952
@nic-chen do you have time to review this PR ?
This is an automated message from the Apache Git Service.
To
juzhiyuan commented on issue #473:
URL:
https://github.com/apache/apisix-dashboard/issues/473#issuecomment-694054307
Very crowded I think if removed the description.
ShiningRush commented on issue #2247:
URL: https://github.com/apache/apisix/issues/2247#issuecomment-694053177
We maybe need a command to export all resources to a json file at once, such
as
`./apisix-schem all`
It will automatically write the schema into the default directory for
moonming commented on issue #473:
URL:
https://github.com/apache/apisix-dashboard/issues/473#issuecomment-694064330
We can merge the switch and configuration together; or add the logo to the
original description position
Thanks,
Ming Wen
Twitter: _WenMing
琚致远
sshniro commented on issue #2175:
URL: https://github.com/apache/apisix/issues/2175#issuecomment-694064180
@GBXing I assume the issue relies on the connectivity to the Kafka or a bug
inside the logger. The batch processor is a standalone module that is used in
other loggers and does not
juzhiyuan commented on a change in pull request #2099:
URL: https://github.com/apache/apisix/pull/2099#discussion_r490067745
##
File path: t/admin/plugins.t
##
@@ -61,6 +61,16 @@ GET /apisix/admin/plugins/limit-req
--- request
GET /apisix/admin/plugins/node-status
---
griffenliu closed issue #1667:
URL: https://github.com/apache/apisix/issues/1667
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
moonming opened a new pull request #2246:
URL: https://github.com/apache/apisix/pull/2246
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
juzhiyuan commented on issue #473:
URL:
https://github.com/apache/apisix-dashboard/issues/473#issuecomment-694073003
How about this one?
membphis opened a new issue #2245:
URL: https://github.com/apache/apisix/issues/2245
https://github.com/apache/apisix/pull/2179#issuecomment-693767787
This is an automated message from the Apache Git Service.
To respond to
membphis commented on issue #2245:
URL: https://github.com/apache/apisix/issues/2245#issuecomment-693953894
@tokers would like to handle this issue?
This is an automated message from the Apache Git Service.
To respond to the
nic-chen commented on pull request #2239:
URL: https://github.com/apache/apisix/pull/2239#issuecomment-693954128
@membphis @gxthrj Chinese doc has updated. please take a look.
This is an automated message from the Apache
membphis commented on a change in pull request #2241:
URL: https://github.com/apache/apisix/pull/2241#discussion_r489997687
##
File path: apisix/plugins/consumer-restriction.lua
##
@@ -29,25 +34,33 @@ local schema = {
type = "array",
items = {type =
moonming commented on pull request #:
URL: https://github.com/apache/apisix/pull/#issuecomment-693997066
@ShiningRush please take a look, thx
This is an automated message from the Apache Git Service.
To respond to
This is an automated email from the ASF dual-hosted git repository.
wenming pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new d050718 fix: return ok in kafka-logger
moonming merged pull request #:
URL: https://github.com/apache/apisix/pull/
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
moonming commented on a change in pull request #2244:
URL: https://github.com/apache/apisix/pull/2244#discussion_r490026730
##
File path: conf/config.yaml
##
@@ -21,3 +21,9 @@
# host:
# - "http://127.0.0.1:2379;
#
+apisix:
+ admin_key:
+-
+ name: "admin"
moonming commented on a change in pull request #2244:
URL: https://github.com/apache/apisix/pull/2244#discussion_r490027799
##
File path: bin/apisix
##
@@ -799,6 +799,8 @@ version:print the version of apisix
]])
end
+
+local is_checked_admin_key
Review comment:
liuxiran commented on pull request #479:
URL: https://github.com/apache/apisix-dashboard/pull/479#issuecomment-694085272
create a route without host in on line demo: http://139.217.190.60/ has got
an 500 error:
moonming commented on pull request #479:
URL: https://github.com/apache/apisix-dashboard/pull/479#issuecomment-694093851
> create a route without host in on line demo: http://139.217.190.60/ has
got an 500 error:
>
>
swayamraina commented on a change in pull request #2221:
URL: https://github.com/apache/apisix/pull/2221#discussion_r490512498
##
File path: apisix/utils/log-util.lua
##
@@ -64,7 +64,11 @@ local function get_full_log(ngx, conf)
else
local body_file =
liuxiran opened a new pull request #485:
URL: https://github.com/apache/apisix-dashboard/pull/485
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bug fix
- [ ] New feature provided
- [ ] Improve performance
-
huzhewei commented on issue #2248:
URL: https://github.com/apache/apisix/issues/2248#issuecomment-694120286
我加了--with-pcre=../pcre-8.4.2后修复了此问题，但是抛出了新问题
nginx[error]: init_by_lua error: ../lualib/ngx/re.lua:47 : missing
declaration for symbol hnx_http_lua_ffi_exec_regex''
juzhiyuan commented on issue #473:
URL:
https://github.com/apache/apisix-dashboard/issues/473#issuecomment-694152749
Sort the category has been implemented, waiting for Plugin's PR review.
This is an automated message from
juzhiyuan commented on issue #478:
URL:
https://github.com/apache/apisix-dashboard/issues/478#issuecomment-694171074
> 。。。
>
发现是apisix-dashboard-1.5这个包构建出来的manager-api和apisix1.5可能不配套，用当前最新代码重新构建了一下manager-api的镜像现在可以登录了，数据库的表多了一张。。。
Yep, codes between the master and the 1.5
juzhiyuan commented on issue #458:
URL:
https://github.com/apache/apisix-dashboard/issues/458#issuecomment-694170396
ping @LiteSun
This is an automated message from the Apache Git Service.
To respond to the message, please
juzhiyuan closed issue #478:
URL: https://github.com/apache/apisix-dashboard/issues/478
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
juzhiyuan closed issue #473:
URL: https://github.com/apache/apisix-dashboard/issues/473
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
juzhiyuan opened a new pull request #482:
URL: https://github.com/apache/apisix-dashboard/pull/482
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bug fix
- [ ] New feature provided
- [ ] Improve performance
-
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a change to branch feat-plugin
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git.
at f1c15e3 feat: update plugin
No new revisions were added by this update.
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a change to branch feat-plugin
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git.
from 5b24ece fix: host should not be required (#479)
add 744af48 feat: update plugin
No new
huzhewei edited a comment on issue #2248:
URL: https://github.com/apache/apisix/issues/2248#issuecomment-694120286
我加了--with-pcre=../pcre-8.4.2后修复了此问题，但是抛出了新问题
nginx[error]: init_by_lua error: ../lualib/ngx/re.lua:47 : missing
declaration for symbol 'ngx_http_lua_ffi_exec_regex'
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a change to branch feat-plugin
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git.
at 5b24ece fix: host should not be required (#479)
No new revisions were added by this update.
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a change to branch feat-plugin
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git.
at f1c15e3 feat: update plugin
No new revisions were added by this update.
Caelebs commented on issue #478:
URL:
https://github.com/apache/apisix-dashboard/issues/478#issuecomment-694116308
。。。
发现是apisix-dashboard-1.5这个包构建出来的manager-api和apisix1.5可能不配套，用当前最新代码重新构建了一下manager-api的镜像现在可以登录了，数据库的表多了一张。。。
juzhiyuan commented on issue #473:
URL:
https://github.com/apache/apisix-dashboard/issues/473#issuecomment-694140592
huzhewei opened a new issue #2248:
URL: https://github.com/apache/apisix/issues/2248
### Issue description
apisix start出现no pcre jit support found，但我本地已经安装了pcre和pcre-devel了
### Environment
* apisix version (cmd: `apisix version`):1.5
* OS:centos6.9
moonming commented on issue #473:
URL:
https://github.com/apache/apisix-dashboard/issues/473#issuecomment-694145651
Looks good for me
琚致远 于2020年9月17日 周四下午6:21写道：
>
>
> [image: image]
>
juzhiyuan commented on issue #478:
URL:
https://github.com/apache/apisix-dashboard/issues/478#issuecomment-694171355
It looks working for you when using codes from the master branch, I will
close this issue, feel free to reopen it.
nic-chen commented on a change in pull request #2239:
URL: https://github.com/apache/apisix/pull/2239#discussion_r490192846
##
File path: apisix/plugins/hmac-auth.lua
##
@@ -182,13 +201,25 @@ local function generate_signature(ctx, secret_key, params)
juzhiyuan commented on a change in pull request #485:
URL: https://github.com/apache/apisix-dashboard/pull/485#discussion_r490637289
##
File path: src/pages/Route/transform.ts
##
@@ -252,3 +252,131 @@ export const transformRouteData = (data:
RouteModule.Body) => {
ShiningRush commented on a change in pull request #484:
URL: https://github.com/apache/apisix-dashboard/pull/484#discussion_r490658451
##
File path: api/internal/core/entity/entity.go
##
@@ -11,16 +11,107 @@ type Route struct {
Hoststring
membphis commented on a change in pull request #2241:
URL: https://github.com/apache/apisix/pull/2241#discussion_r490674241
##
File path: t/plugin/consumer-restriction.t
##
@@ -540,3 +541,256 @@ GET /hello
hello world
--- no_error_log
[error]
+
+
+
+=== TEST 25: create
moonming commented on a change in pull request #2241:
URL: https://github.com/apache/apisix/pull/2241#discussion_r490671665
##
File path: apisix/plugins/consumer-restriction.lua
##
@@ -67,26 +81,33 @@ function _M.check_schema(conf)
return true
end
+
function
membphis commented on pull request #2239:
URL: https://github.com/apache/apisix/pull/2239#issuecomment-694629791
@gxthrj do you have time to take a look at this PR?
This is an automated message from the Apache Git Service.
spacewander opened a new pull request #2252:
URL: https://github.com/apache/apisix/pull/2252
Close #2215.
### What this PR does / why we need it:
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features
have been
liuxiran commented on a change in pull request #485:
URL: https://github.com/apache/apisix-dashboard/pull/485#discussion_r490645695
##
File path: src/pages/Route/transform.ts
##
@@ -252,3 +252,131 @@ export const transformRouteData = (data:
RouteModule.Body) => {
Caelebs opened a new issue #2255:
URL: https://github.com/apache/apisix/issues/2255
### Issue description
K8s deploy apisix create upstream returns error code 500
```
{"app":"manager-api","level":"error","line":"route/upstream.go:162","msg":"apisix
upstream create failed: Put
membphis commented on a change in pull request #2239:
URL: https://github.com/apache/apisix/pull/2239#discussion_r490681896
##
File path: apisix/plugins/hmac-auth.lua
##
@@ -182,13 +201,25 @@ local function generate_signature(ctx, secret_key, params)
gxthrj commented on pull request #2239:
URL: https://github.com/apache/apisix/pull/2239#issuecomment-694633423
> @gxthrj do you have time to take a look at this PR?
ok
This is an automated message from the Apache
Firstsawyou commented on a change in pull request #2241:
URL: https://github.com/apache/apisix/pull/2241#discussion_r490685981
##
File path: t/plugin/consumer-restriction.t
##
@@ -540,3 +540,256 @@ GET /hello
hello world
--- no_error_log
[error]
+
+
+
+=== TEST 25: create
moonming commented on issue #2249:
URL: https://github.com/apache/apisix/issues/2249#issuecomment-694633629
is https://github.com/apache/apisix-docker good for you?
This is an automated message from the Apache Git Service.
Firstsawyou commented on a change in pull request #2241:
URL: https://github.com/apache/apisix/pull/2241#discussion_r490686675
##
File path: apisix/plugins/consumer-restriction.lua
##
@@ -67,26 +81,33 @@ function _M.check_schema(conf)
return true
end
+
function
membphis commented on a change in pull request #2241:
URL: https://github.com/apache/apisix/pull/2241#discussion_r490686228
##
File path: apisix/plugins/consumer-restriction.lua
##
@@ -67,26 +81,33 @@ function _M.check_schema(conf)
return true
end
+
function
juzhiyuan commented on a change in pull request #485:
URL: https://github.com/apache/apisix-dashboard/pull/485#discussion_r490655427
##
File path: src/pages/Route/transform.ts
##
@@ -252,3 +252,131 @@ export const transformRouteData = (data:
RouteModule.Body) => {
huzhewei commented on issue #2248:
URL: https://github.com/apache/apisix/issues/2248#issuecomment-694601507
> Hi @huzhewei I think I met same problem before. I suggest to follow
instructions in
juzhiyuan commented on issue #480:
URL:
https://github.com/apache/apisix-dashboard/issues/480#issuecomment-694608787
cc @LiteSun please set category for plugin orchestration
This is an automated message from the Apache Git
membphis opened a new pull request #2253:
URL: https://github.com/apache/apisix/pull/2253
### What this PR does / why we need it:
the test case is unstable, it runs fail sometimes.
current way: before creating and deleting routes in batches, clear all
routes first.
membphis opened a new issue #2254:
URL: https://github.com/apache/apisix/issues/2254
this field is used for dashboard, it looks more user-friendly.
For example, the `name` field of `limit-req` is `Rate Limiting`.
moonming commented on issue #2006:
URL: https://github.com/apache/apisix/issues/2006#issuecomment-694633467
@membphis please take a look
This is an automated message from the Apache Git Service.
To respond to the message,
membphis commented on a change in pull request #2241:
URL: https://github.com/apache/apisix/pull/2241#discussion_r490685703
##
File path: t/plugin/consumer-restriction.t
##
@@ -540,3 +540,256 @@ GET /hello
hello world
--- no_error_log
[error]
+
+
+
+=== TEST 25: create
ShiningRush commented on issue #2006:
URL: https://github.com/apache/apisix/issues/2006#issuecomment-694634705
I think this is the same problem, the key point is related with [this
comment](https://github.com/apache/apisix/issues/2006#issuecomment-669769777)
Firstsawyou commented on a change in pull request #2241:
URL: https://github.com/apache/apisix/pull/2241#discussion_r490688992
##
File path: apisix/plugins/consumer-restriction.lua
##
@@ -67,26 +81,33 @@ function _M.check_schema(conf)
return true
end
+
function
Firstsawyou commented on a change in pull request #2241:
URL: https://github.com/apache/apisix/pull/2241#discussion_r490713892
##
File path: t/plugin/consumer-restriction.t
##
@@ -540,3 +540,256 @@ GET /hello
hello world
--- no_error_log
[error]
+
+
+
+=== TEST 25: create
moonming commented on issue #2254:
URL: https://github.com/apache/apisix/issues/2254#issuecomment-694667337
I don't think so, which should be the job of dashboard, especially
considering i18n
This is an automated message
moonming commented on issue #2255:
URL: https://github.com/apache/apisix/issues/2255#issuecomment-694667634
@nic-chen please take a look
This is an automated message from the Apache Git Service.
To respond to the message,
griffenliu edited a comment on issue #2006:
URL: https://github.com/apache/apisix/issues/2006#issuecomment-694208133
I want to use the prometheus plug-ins.
But when I access http://localhost:9080/apisix/prometheus/metrics by
document
griffenliu commented on issue #2006:
URL: https://github.com/apache/apisix/issues/2006#issuecomment-694208133
I want to use the prometheus plug-ins.
But when I access http://localhost:9080/apisix/prometheus/metrics by
document
gy09535 opened a new pull request #2250:
URL: https://github.com/apache/apisix/pull/2250
### What this PR does / why we need it:
fix:https://github.com/apache/apisix/issues/2249
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new
gy09535 opened a new issue #2249:
URL: https://github.com/apache/apisix/issues/2249
### Issue description
Sometime we should add some special logical for ourself business, we should
build docker image with source code. So maybe we should add dockerfile in
source code.
###
griffenliu edited a comment on issue #2006:
URL: https://github.com/apache/apisix/issues/2006#issuecomment-694208133
I want to use the prometheus plug-ins.
But when I access http://localhost:9080/apisix/prometheus/metrics based on
the document
nic-chen opened a new pull request #484:
URL: https://github.com/apache/apisix-dashboard/pull/484
Please answer these questions before submitting a pull request
- Why submit this pull request?
add structs
juzhiyuan opened a new issue #480:
URL: https://github.com/apache/apisix-dashboard/issues/480
- [ ] Improve i18n
- [ ] icon for plugins
- [ ] Disable
https://github.com/apache/apisix/pull/2099/files#diff-ed26f75979353d43aa8168d799d931d0R609
juzhiyuan closed pull request #481:
URL: https://github.com/apache/apisix-dashboard/pull/481
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
juzhiyuan opened a new pull request #481:
URL: https://github.com/apache/apisix-dashboard/pull/481
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bug fix
- [ ] New feature provided
- [ ] Improve performance
-
Yiyiyimu opened a new issue #75:
URL: https://github.com/apache/apisix-docker/issues/75
Since apisix would not support etcd v2 anymore
This is an automated message from the Apache Git Service.
To respond to the message,
membphis opened a new pull request #2251:
URL: https://github.com/apache/apisix/pull/2251
…seful when a
serious error occurs.
### What this PR does / why we need it:
chore: get the complete error stack when sync etcd data, it is very useful
when a
membphis commented on a change in pull request #2244:
URL: https://github.com/apache/apisix/pull/2244#discussion_r490290166
##
File path: bin/apisix
##
@@ -799,6 +799,8 @@ version:print the version of apisix
]])
end
+
+local is_checked_admin_key
Review comment:
This is an automated email from the ASF dual-hosted git repository.
membphis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 4f90039 bugfix: independently check the
membphis closed issue #2084:
URL: https://github.com/apache/apisix/issues/2084
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
membphis merged pull request #2099:
URL: https://github.com/apache/apisix/pull/2099
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
LiteSun opened a new pull request #483:
URL: https://github.com/apache/apisix-dashboard/pull/483
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bug fix
- [ ] New feature provided
- [x] Improve performance
- Related
Yiyiyimu commented on issue #2248:
URL: https://github.com/apache/apisix/issues/2248#issuecomment-694282024
Hi @huzhewei I think I met same problem before. I suggest to follow
instructions in
96 matches
Mail list logo
