[GitHub] [incubator-apisix] moonming commented on a change in pull request #813: update FAQ, add one about slow luarocks

2019-11-05 Thread GitBox
moonming commented on a change in pull request #813: update FAQ, add one about slow luarocks URL: https://github.com/apache/incubator-apisix/pull/813#discussion_r342943572 ## File path: FAQ_CN.md ## @@ -56,3 +56,16 @@ APISIX 是当前性能最好的 API 网关,单核 QPS 达到 2.3 万,平均 5. 高性能

[GitHub] [incubator-apisix] moonming commented on a change in pull request #813: update FAQ, add one about slow luarocks

2019-11-05 Thread GitBox
moonming commented on a change in pull request #813: update FAQ, add one about slow luarocks URL: https://github.com/apache/incubator-apisix/pull/813#discussion_r342943753 ## File path: FAQ_CN.md ## @@ -56,3 +56,16 @@ APISIX 是当前性能最好的 API 网关,单核 QPS 达到 2.3 万,平均 5. 高性能

[GitHub] [incubator-apisix] soulsoul closed pull request #606: add doc for plugin development

2019-11-05 Thread GitBox
soulsoul closed pull request #606: add doc for plugin development URL: https://github.com/apache/incubator-apisix/pull/606 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-apisix] idevz commented on a change in pull request #813: update FAQ, add one about slow luarocks

2019-11-05 Thread GitBox
idevz commented on a change in pull request #813: update FAQ, add one about slow luarocks URL: https://github.com/apache/incubator-apisix/pull/813#discussion_r342944847 ## File path: FAQ_CN.md ## @@ -56,3 +56,16 @@ APISIX 是当前性能最好的 API 网关,单核 QPS 达到 2.3 万,平均 5. 高性能

[GitHub] [incubator-apisix] lilien1010 commented on issue #817: bugfix(radixtree_host_uri): match priority, host > uri.

2019-11-07 Thread GitBox
lilien1010 commented on issue #817: bugfix(radixtree_host_uri): match priority, host > uri. URL: https://github.com/apache/incubator-apisix/pull/817#issuecomment-551011542  This is an automated message from the Apache Git

[GitHub] [incubator-apisix] membphis opened a new pull request #818: feature: support for adding the specified request header for upstream…

2019-11-07 Thread GitBox
membphis opened a new pull request #818: feature: support for adding the specified request header for upstream… URL: https://github.com/apache/incubator-apisix/pull/818 … health check. Fix #766. This is an automated

[GitHub] [incubator-apisix-dashboard] lilien1010 commented on issue #69: null value option can be selected in Route Edit Page

2019-11-07 Thread GitBox
lilien1010 commented on issue #69: null value option can be selected in Route Edit Page URL: https://github.com/apache/incubator-apisix-dashboard/issues/69#issuecomment-551012737 ok This is an automated message from the

[GitHub] [incubator-apisix-dashboard] lilien1010 edited a comment on issue #69: null value option can be selected in Route Edit Page

2019-11-07 Thread GitBox
lilien1010 edited a comment on issue #69: null value option can be selected in Route Edit Page URL: https://github.com/apache/incubator-apisix-dashboard/issues/69#issuecomment-551012737 @juzhiyuan ok This is an automated

[GitHub] [incubator-apisix] membphis opened a new pull request #819: change: removed useless file copy.

2019-11-07 Thread GitBox
membphis opened a new pull request #819: change: removed useless file copy. URL: https://github.com/apache/incubator-apisix/pull/819 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on issue #66: LICENSE: remove ALv2 header from original files

2019-11-07 Thread GitBox
juzhiyuan commented on issue #66: LICENSE: remove ALv2 header from original files URL: https://github.com/apache/incubator-apisix-dashboard/issues/66#issuecomment-551395456 Will do this weekend. This is an automated message

[GitHub] [incubator-apisix] nic-chen commented on issue #820: bug: 上传 gRpc proto 内容超过4096个字节报错

2019-11-07 Thread GitBox
nic-chen commented on issue #820: bug: 上传 gRpc proto 内容超过4096个字节报错 URL: https://github.com/apache/incubator-apisix/issues/820#issuecomment-551397255 I think we could increase the maxLength to 1M, since ETCD's default max-request-bytes is 1.5M

[GitHub] [incubator-apisix-dashboard] juzhiyuan edited a comment on issue #66: LICENSE: remove ALv2 header from original files

2019-11-07 Thread GitBox
juzhiyuan edited a comment on issue #66: LICENSE: remove ALv2 header from original files URL: https://github.com/apache/incubator-apisix-dashboard/issues/66#issuecomment-551395456 I will do this weekend. This is an

[GitHub] [incubator-apisix] Miss-you commented on issue #802: request help: Is there any plan that the APISIX supports the Consul?

2019-11-06 Thread GitBox
Miss-you commented on issue #802: request help: Is there any plan that the APISIX supports the Consul? URL: https://github.com/apache/incubator-apisix/issues/802#issuecomment-550410384 PR on the way This is an automated

[GitHub] [incubator-apisix] Miss-you commented on issue #804: request help: Which one has a higher priority, Eureka or Consul?

2019-11-06 Thread GitBox
Miss-you commented on issue #804: request help: Which one has a higher priority, Eureka or Consul? URL: https://github.com/apache/incubator-apisix/issues/804#issuecomment-550411033 I think we need more user to vote for this question.

[GitHub] [incubator-apisix] membphis merged pull request #819: change: removed useless file copy.

2019-11-07 Thread GitBox
membphis merged pull request #819: change: removed useless file copy. URL: https://github.com/apache/incubator-apisix/pull/819 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-apisix] Miss-you commented on issue #500: [WIP]feature: CORS plugin.

2019-11-06 Thread GitBox
Miss-you commented on issue #500: [WIP]feature: CORS plugin. URL: https://github.com/apache/incubator-apisix/pull/500#issuecomment-550332101 I'm sorry for that I had no time to finish this cors plugin. I will create a new PR for CORS next week. thanks yousa WenMing

[GitHub] [incubator-apisix-dashboard] juzhiyuan closed issue #71: bug: unable to open websocket proxy in proxy-write plugin

2019-11-07 Thread GitBox
juzhiyuan closed issue #71: bug: unable to open websocket proxy in proxy-write plugin URL: https://github.com/apache/incubator-apisix-dashboard/issues/71 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-apisix-dashboard] juzhiyuan merged pull request #72: fix: enable to open websocket

2019-11-07 Thread GitBox
juzhiyuan merged pull request #72: fix: enable to open websocket URL: https://github.com/apache/incubator-apisix-dashboard/pull/72 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on issue #70: fix:add regexp for uris and host filter when create route

2019-11-07 Thread GitBox
juzhiyuan commented on issue #70: fix:add regexp for uris and host filter when create route URL: https://github.com/apache/incubator-apisix-dashboard/pull/70#issuecomment-551373471

[GitHub] [incubator-apisix-dashboard] juzhiyuan commented on issue #70: fix:add regexp for uris and host filter when create route

2019-11-07 Thread GitBox
juzhiyuan commented on issue #70: fix:add regexp for uris and host filter when create route URL: https://github.com/apache/incubator-apisix-dashboard/pull/70#issuecomment-551375568

[GitHub] [incubator-apisix] membphis commented on issue #775: bugfix: support more built-in parameters when set chash balancer

2019-10-31 Thread GitBox
membphis commented on issue #775: bugfix: support more built-in parameters when set chash balancer URL: https://github.com/apache/incubator-apisix/pull/775#issuecomment-548376615 @lilien1010 There are some minor issues with the documentation, and the rest is fine. We will merge after you

[GitHub] [incubator-apisix] membphis commented on issue #769: delete admin routes.lua host and hosts variable duplicate check code

2019-10-31 Thread GitBox
membphis commented on issue #769: delete admin routes.lua host and hosts variable duplicate check code URL: https://github.com/apache/incubator-apisix/pull/769#issuecomment-548382478 Merged, many thanks. This is an automated

[GitHub] [incubator-apisix] membphis merged pull request #769: delete admin routes.lua host and hosts variable duplicate check code

2019-10-31 Thread GitBox
membphis merged pull request #769: delete admin routes.lua host and hosts variable duplicate check code URL: https://github.com/apache/incubator-apisix/pull/769 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-apisix] membphis commented on issue #761: bug: 三级泛解析路由规则无法匹配

2019-10-31 Thread GitBox
membphis commented on issue #761: bug: 三级泛解析路由规则无法匹配 URL: https://github.com/apache/incubator-apisix/issues/761#issuecomment-548366809 Yes, it should be a bug, PR welcome. This is an automated message from the Apache Git

[GitHub] [incubator-apisix] membphis commented on a change in pull request #775: bugfix: support more built-in parameters when set chash balancer

2019-10-31 Thread GitBox
membphis commented on a change in pull request #775: bugfix: support more built-in parameters when set chash balancer URL: https://github.com/apache/incubator-apisix/pull/775#discussion_r341134378 ## File path: doc/architecture-design-cn.md ## @@ -237,7 +237,7 @@ APISIX 的

[GitHub] [incubator-apisix] wangxiaochuang commented on issue #776: bug: merge_service_route function's second return value will always be nil

2019-10-31 Thread GitBox
wangxiaochuang commented on issue #776: bug: merge_service_route function's second return value will always be nil URL: https://github.com/apache/incubator-apisix/issues/776#issuecomment-548373338 yes, I know the right one; if it hasn't cached, "local function merge_service_route"

[GitHub] [incubator-apisix] wangxiaochuang edited a comment on issue #776: bug: merge_service_route function's second return value will always be nil

2019-10-31 Thread GitBox
wangxiaochuang edited a comment on issue #776: bug: merge_service_route function's second return value will always be nil URL: https://github.com/apache/incubator-apisix/issues/776#issuecomment-548373338 yes, I know the right one; if it hasn't cached, "local function merge_service_route"

[GitHub] [incubator-apisix] moonming commented on issue #691: feat grpc proxy doc && test case

2019-10-31 Thread GitBox
moonming commented on issue #691: feat grpc proxy doc && test case URL: https://github.com/apache/incubator-apisix/pull/691#issuecomment-548395746 @nic-chen need to add ASF header for new files, otherwise, the Travis will fail

[GitHub] [incubator-apisix] lilien1010 commented on a change in pull request #775: bugfix: support more built-in parameters when set chash balancer

2019-10-31 Thread GitBox
lilien1010 commented on a change in pull request #775: bugfix: support more built-in parameters when set chash balancer URL: https://github.com/apache/incubator-apisix/pull/775#discussion_r341195793 ## File path: doc/architecture-design-cn.md ## @@ -237,7 +237,7 @@ APISIX

[GitHub] [incubator-apisix] moonming commented on issue #776: bug: merge_service_route function's second return value will always be nil

2019-10-31 Thread GitBox
moonming commented on issue #776: bug: merge_service_route function's second return value will always be nil URL: https://github.com/apache/incubator-apisix/issues/776#issuecomment-548371531 @wangxiaochuang you didn't find the correct function, you can search `merge_service_route` in

[GitHub] [incubator-apisix] YazaiHu commented on issue #769: delete admin routes.lua host and hosts variable duplicate check code

2019-10-31 Thread GitBox
YazaiHu commented on issue #769: delete admin routes.lua host and hosts variable duplicate check code URL: https://github.com/apache/incubator-apisix/pull/769#issuecomment-548380008 In this file apisix/admin/routes.lua has appear twice. you can review it. 发自我的iPhone

[GitHub] [incubator-apisix] Zheaoli commented on issue #761: bug: 三级泛解析路由规则无法匹配

2019-10-31 Thread GitBox
Zheaoli commented on issue #761: bug: 三级泛解析路由规则无法匹配 URL: https://github.com/apache/incubator-apisix/issues/761#issuecomment-548390075 I'll take care of it This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-apisix] membphis commented on a change in pull request #775: bugfix: support more built-in parameters when set chash balancer

2019-10-31 Thread GitBox
membphis commented on a change in pull request #775: bugfix: support more built-in parameters when set chash balancer URL: https://github.com/apache/incubator-apisix/pull/775#discussion_r341134807 ## File path: doc/architecture-design-cn.md ## @@ -237,7 +237,7 @@ APISIX 的

[GitHub] [incubator-apisix] membphis commented on a change in pull request #691: feat grpc proxy doc && test case

2019-10-31 Thread GitBox
membphis commented on a change in pull request #691: feat grpc proxy doc && test case URL: https://github.com/apache/incubator-apisix/pull/691#discussion_r341147346 ## File path: .travis/osx_runner.sh ## @@ -64,6 +66,25 @@ script() { sudo make run mkdir -p logs

[GitHub] [incubator-apisix] Zheaoli opened a new pull request #779: allow failure when exec CI process in MacOS

2019-10-31 Thread GitBox
Zheaoli opened a new pull request #779: allow failure when exec CI process in MacOS URL: https://github.com/apache/incubator-apisix/pull/779 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-apisix] membphis commented on issue #768: change: updated resty-radixtree to v1.5.

2019-10-31 Thread GitBox
membphis commented on issue #768: change: updated resty-radixtree to v1.5. URL: https://github.com/apache/incubator-apisix/pull/768#issuecomment-548378842 @moonming please take a look This is an automated message from the

[GitHub] [incubator-apisix] membphis opened a new issue #777: gRPC test case: added more test case.

2019-10-31 Thread GitBox
membphis opened a new issue #777: gRPC test case: added more test case. URL: https://github.com/apache/incubator-apisix/issues/777 https://github.com/apache/incubator-apisix/pull/691/files#r334773223 Need more test cases, more tests in different situations, such as normal, failure,

[GitHub] [incubator-apisix] Zheaoli opened a new pull request #778: update Makefile to throw an error when OpenResty is not existed in PATH

2019-10-31 Thread GitBox
Zheaoli opened a new pull request #778: update Makefile to throw an error when OpenResty is not existed in PATH URL: https://github.com/apache/incubator-apisix/pull/778 This Makefile use `OR_EXEC ?= $(shell which openresty)` to find the openresty exec path. But when openresty does

[GitHub] [incubator-apisix] wangxiaochuang commented on issue #776: bug: merge_service_route function's second return value will always be nil

2019-10-31 Thread GitBox
wangxiaochuang commented on issue #776: bug: merge_service_route function's second return value will always be nil URL: https://github.com/apache/incubator-apisix/issues/776#issuecomment-548375675 I have debugged the code successfully

[GitHub] [incubator-apisix] membphis commented on issue #691: feat grpc proxy doc && test case

2019-10-31 Thread GitBox
membphis commented on issue #691: feat grpc proxy doc && test case URL: https://github.com/apache/incubator-apisix/pull/691#issuecomment-548388357 This PR and https://github.com/apache/incubator-apisix/pull/683, they modified the Travis installation scripts, they are better to be merged as

[GitHub] [incubator-apisix] yy8866 edited a comment on issue #761: bug: 三级泛解析路由规则无法匹配

2019-10-31 Thread GitBox
yy8866 edited a comment on issue #761: bug: 三级泛解析路由规则无法匹配 URL: https://github.com/apache/incubator-apisix/issues/761#issuecomment-547894322 > > > > 理论上*.xxx.xxx.com的优先级是应该大于host为空的那条路由的。实际使用中上优先匹配了空host的那条路由 > > Sorry, I didn't understand your example, and I didn't search

[GitHub] [incubator-apisix] moonming commented on issue #691: feat grpc proxy doc && test case

2019-10-31 Thread GitBox
moonming commented on issue #691: feat grpc proxy doc && test case URL: https://github.com/apache/incubator-apisix/pull/691#issuecomment-548394605 > I think we can merge this PR first. Some small points, we will fix them later. @moonming please add issues for that.

[GitHub] [incubator-apisix] membphis commented on issue #779: allow failure when exec CI process in MacOS

2019-10-31 Thread GitBox
membphis commented on issue #779: allow failure when exec CI process in MacOS URL: https://github.com/apache/incubator-apisix/pull/779#issuecomment-548669628 > maybe we can split the plugin out from the main codebase? We don't plan to put the plugin in a separate repository, which

[GitHub] [incubator-apisix] membphis merged pull request #779: allow failure when exec CI process in MacOS

2019-10-31 Thread GitBox
membphis merged pull request #779: allow failure when exec CI process in MacOS URL: https://github.com/apache/incubator-apisix/pull/779 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [incubator-apisix] membphis commented on issue #733: 支持nginx的proxy_pass路由转发功能

2019-11-01 Thread GitBox
membphis commented on issue #733: 支持nginx的proxy_pass路由转发功能 URL: https://github.com/apache/incubator-apisix/issues/733#issuecomment-548689015 you can use plugin `proxy-rewrite` to do this. This is an automated message from

[GitHub] [incubator-apisix] membphis commented on issue #737: bugfix: skipped to init etcd if use local file as config center.

2019-11-01 Thread GitBox
membphis commented on issue #737: bugfix: skipped to init etcd if use local file as config center. URL: https://github.com/apache/incubator-apisix/pull/737#issuecomment-548689323 @moonming please take a look when you have time.

[GitHub] [incubator-apisix] lilien1010 commented on a change in pull request #775: bugfix: support more built-in parameters when set chash balancer

2019-10-31 Thread GitBox
lilien1010 commented on a change in pull request #775: bugfix: support more built-in parameters when set chash balancer URL: https://github.com/apache/incubator-apisix/pull/775#discussion_r341440325 ## File path: doc/architecture-design-cn.md ## @@ -237,7 +237,7 @@ APISIX

[GitHub] [incubator-apisix] moonming commented on issue #633: feature:proxy_pass to http or https domain

2019-10-31 Thread GitBox
moonming commented on issue #633: feature:proxy_pass to http or https domain URL: https://github.com/apache/incubator-apisix/issues/633#issuecomment-548669093 consider resolved. This is an automated message from the Apache

[GitHub] [incubator-apisix] membphis closed pull request #783: [WIP] github action

2019-10-31 Thread GitBox
membphis closed pull request #783: [WIP] github action URL: https://github.com/apache/incubator-apisix/pull/783 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-apisix] moonming closed issue #633: feature:proxy_pass to http or https domain

2019-10-31 Thread GitBox
moonming closed issue #633: feature:proxy_pass to http or https domain URL: https://github.com/apache/incubator-apisix/issues/633 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-apisix] membphis opened a new pull request #783: [WIP] github action

2019-10-31 Thread GitBox
membphis opened a new pull request #783: [WIP] github action URL: https://github.com/apache/incubator-apisix/pull/783 Make a test This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-apisix] moonming commented on issue #606: add doc for plugin development

2019-10-31 Thread GitBox
moonming commented on issue #606: add doc for plugin development URL: https://github.com/apache/incubator-apisix/pull/606#issuecomment-548668099 any update? @soulsoul This is an automated message from the Apache Git Service.

[GitHub] [incubator-apisix] moonming closed pull request #669: feature: added ssl_protocols_suite to skip detail of ssl_protocols.

2019-10-31 Thread GitBox
moonming closed pull request #669: feature: added ssl_protocols_suite to skip detail of ssl_protocols. URL: https://github.com/apache/incubator-apisix/pull/669 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-apisix] moonming commented on issue #500: [WIP]feature: CORS plugin.

2019-10-31 Thread GitBox
moonming commented on issue #500: [WIP]feature: CORS plugin. URL: https://github.com/apache/incubator-apisix/pull/500#issuecomment-548667827 I think it a zombie PR, I will close it 2 days later. This is an automated message

[GitHub] [incubator-apisix] moonming merged pull request #778: update Makefile to throw an error when OpenResty does not existed in PATH

2019-10-31 Thread GitBox
moonming merged pull request #778: update Makefile to throw an error when OpenResty does not existed in PATH URL: https://github.com/apache/incubator-apisix/pull/778 This is an automated message from the Apache Git Service.

[GitHub] [incubator-apisix] moonming closed pull request #472: [WIP] doc: added comment for code.

2019-10-31 Thread GitBox
moonming closed pull request #472: [WIP] doc: added comment for code. URL: https://github.com/apache/incubator-apisix/pull/472 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-apisix] Zheaoli commented on issue #779: allow failure when exec CI process in MacOS

2019-11-01 Thread GitBox
Zheaoli commented on issue #779: allow failure when exec CI process in MacOS URL: https://github.com/apache/incubator-apisix/pull/779#issuecomment-548684249 @membphis All right, I will find out a new way to make a full test in MacOS

[GitHub] [incubator-apisix] Zheaoli commented on issue #779: allow failure when exec CI process in MacOS

2019-10-31 Thread GitBox
Zheaoli commented on issue #779: allow failure when exec CI process in MacOS URL: https://github.com/apache/incubator-apisix/pull/779#issuecomment-548637195 @moonming Yeap,It's just a patch for the code in the master branch.

[GitHub] [incubator-apisix] Zheaoli commented on a change in pull request #778: update Makefile to throw an error when OpenResty does not existed in PATH

2019-10-31 Thread GitBox
Zheaoli commented on a change in pull request #778: update Makefile to throw an error when OpenResty does not existed in PATH URL: https://github.com/apache/incubator-apisix/pull/778#discussion_r341428574 ## File path: Makefile ## @@ -82,12 +82,20 @@ init: run:

[GitHub] [incubator-apisix] Zheaoli commented on issue #779: allow failure when exec CI process in MacOS

2019-10-31 Thread GitBox
Zheaoli commented on issue #779: allow failure when exec CI process in MacOS URL: https://github.com/apache/incubator-apisix/pull/779#issuecomment-548644093 maybe we can split the plugin out from the main codebase? This is an

[GitHub] [incubator-apisix] moonming commented on a change in pull request #775: bugfix: support more built-in parameters when set chash balancer

2019-10-31 Thread GitBox
moonming commented on a change in pull request #775: bugfix: support more built-in parameters when set chash balancer URL: https://github.com/apache/incubator-apisix/pull/775#discussion_r341425804 ## File path: doc/architecture-design-cn.md ## @@ -237,7 +237,7 @@ APISIX 的

[GitHub] [incubator-apisix] membphis merged pull request #768: change: updated resty-radixtree to v1.5.

2019-10-31 Thread GitBox
membphis merged pull request #768: change: updated resty-radixtree to v1.5. URL: https://github.com/apache/incubator-apisix/pull/768 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-apisix] moonming merged pull request #774: change: added new test cases about upstream priority.

2019-10-31 Thread GitBox
moonming merged pull request #774: change: added new test cases about upstream priority. URL: https://github.com/apache/incubator-apisix/pull/774 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [incubator-apisix] moonming commented on issue #761: bug: 三级泛解析路由规则无法匹配

2019-10-31 Thread GitBox
moonming commented on issue #761: bug: 三级泛解析路由规则无法匹配 URL: https://github.com/apache/incubator-apisix/issues/761#issuecomment-548636499 @Zheaoli thanks This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-apisix] membphis closed issue #771: bug: rewrite function of plugin does not run at rewrite phase

2019-10-31 Thread GitBox
membphis closed issue #771: bug: rewrite function of plugin does not run at rewrite phase URL: https://github.com/apache/incubator-apisix/issues/771 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-apisix] moonming commented on issue #779: allow failure when exec CI process in MacOS

2019-10-31 Thread GitBox
moonming commented on issue #779: allow failure when exec CI process in MacOS URL: https://github.com/apache/incubator-apisix/pull/779#issuecomment-548635932 I think better we can finger it out why macOS CI failed. This is an

[GitHub] [incubator-apisix] membphis commented on issue #771: bug: rewrite function of plugin does not run at rewrite phase

2019-10-31 Thread GitBox
membphis commented on issue #771: bug: rewrite function of plugin does not run at rewrite phase URL: https://github.com/apache/incubator-apisix/issues/771#issuecomment-548636332 This is an optimization method. Combine the different phases to make APISIX faster.

[GitHub] [incubator-apisix] membphis merged pull request #691: feat grpc proxy doc && test case

2019-10-31 Thread GitBox
membphis merged pull request #691: feat grpc proxy doc && test case URL: https://github.com/apache/incubator-apisix/pull/691 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-apisix] membphis opened a new issue #780: some small points about `gRPC proxy`

2019-10-31 Thread GitBox
membphis opened a new issue #780: some small points about `gRPC proxy` URL: https://github.com/apache/incubator-apisix/issues/780 https://github.com/apache/incubator-apisix/pull/691#issuecomment-548394605 1. doc style 2. ASF license

[GitHub] [incubator-apisix] wangxiaochuang opened a new issue #771: bug: rewrite function of plugin does not run at rewrite phase

2019-10-30 Thread GitBox
wangxiaochuang opened a new issue #771: bug: rewrite function of plugin does not run at rewrite phase URL: https://github.com/apache/incubator-apisix/issues/771 ### Issue description in access_phase, the plugin's rewrite executed if it exists ### Environment * apisix

[GitHub] [incubator-apisix] membphis commented on a change in pull request #768: change: updated resty-radixtree to v1.5.

2019-10-30 Thread GitBox
membphis commented on a change in pull request #768: change: updated resty-radixtree to v1.5. URL: https://github.com/apache/incubator-apisix/pull/768#discussion_r340933899 ## File path: doc/admin-api-cn.md ## @@ -67,5 +68,35 @@ Date: Sat, 31 Aug 2019 01:17:15 GMT

[GitHub] [incubator-apisix] membphis commented on a change in pull request #768: change: updated resty-radixtree to v1.5.

2019-10-30 Thread GitBox
membphis commented on a change in pull request #768: change: updated resty-radixtree to v1.5. URL: https://github.com/apache/incubator-apisix/pull/768#discussion_r340934104 ## File path: doc/admin-api-cn.md ## @@ -32,7 +32,8 @@ |remote_addr|可选 |匹配规则|客户端请求 IP 地址:

[GitHub] [incubator-apisix] moonming merged pull request #732: feature: supported `redirect` plugin.

2019-10-30 Thread GitBox
moonming merged pull request #732: feature: supported `redirect` plugin. URL: https://github.com/apache/incubator-apisix/pull/732 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-apisix] membphis opened a new pull request #787: bugfix: exported schema for plugin `serverless`.

2019-11-01 Thread GitBox
membphis opened a new pull request #787: bugfix: exported schema for plugin `serverless`. URL: https://github.com/apache/incubator-apisix/pull/787 Fix https://github.com/apache/incubator-apisix/issues/785 This is an

[GitHub] [incubator-apisix] membphis commented on issue #683: travis: supported to run apisix with tengine.

2019-11-01 Thread GitBox
membphis commented on issue #683: travis: supported to run apisix with tengine. URL: https://github.com/apache/incubator-apisix/pull/683#issuecomment-548710662 @moonming please take a look This is an automated message from

[GitHub] [incubator-apisix] juzhiyuan opened a new pull request #784: docs: fix typo

2019-11-01 Thread GitBox
juzhiyuan opened a new pull request #784: docs: fix typo URL: https://github.com/apache/incubator-apisix/pull/784 ### Summary Fix typo ### Full changelog ### Issues resolved fix https://github.com/apache/incubator-apisix/issues/759

[GitHub] [incubator-apisix] membphis commented on issue #786: Feature: Support full test in MacOS by using Azure Pipeline

2019-11-01 Thread GitBox
membphis commented on issue #786: Feature: Support full test in MacOS by using Azure Pipeline URL: https://github.com/apache/incubator-apisix/issues/786#issuecomment-548732124 Is it free for open source projects? This is an

[GitHub] [incubator-apisix] membphis commented on issue #786: Feature: Support full test in MacOS by using Azure Pipeline

2019-11-01 Thread GitBox
membphis commented on issue #786: Feature: Support full test in MacOS by using Azure Pipeline URL: https://github.com/apache/incubator-apisix/issues/786#issuecomment-548736057 you can make a try ^_^ This is an automated

[GitHub] [incubator-apisix] juzhiyuan opened a new issue #785: bug: can't load plugin configuration from API

2019-11-01 Thread GitBox
juzhiyuan opened a new issue #785: bug: can't load plugin configuration from API URL: https://github.com/apache/incubator-apisix/issues/785 ### Issue description Both `serverless-pre-function` and `serverless-post-function` plugins cannot load configuration from API. ```

[GitHub] [incubator-apisix] Zheaoli commented on issue #786: Feature: Support full test in MacOS by using Azure Pipeline

2019-11-01 Thread GitBox
Zheaoli commented on issue #786: Feature: Support full test in MacOS by using Azure Pipeline URL: https://github.com/apache/incubator-apisix/issues/786#issuecomment-548732613 @membphis yes it's free for non-commercial usage. I can take care of this issue.

[GitHub] [incubator-apisix] Zheaoli opened a new issue #786: Feature: Support full test in MacOS by using Azure Pipeline

2019-11-01 Thread GitBox
Zheaoli opened a new issue #786: Feature: Support full test in MacOS by using Azure Pipeline URL: https://github.com/apache/incubator-apisix/issues/786 In the Travis, MacOS can't support some test circumstances such as some special dependency. Maybe the APISIX can add some CI

[GitHub] [incubator-apisix] lilien1010 commented on issue #690: Update powered-by.md

2019-10-30 Thread GitBox
lilien1010 commented on issue #690: Update powered-by.md URL: https://github.com/apache/incubator-apisix/pull/690#issuecomment-548211814 @membphis I create a new PR and close this one。 This is an automated message from the

[GitHub] [incubator-apisix] juzhiyuan commented on issue #719: bugfix: support more built-in parameters when set chash balancer

2019-10-31 Thread GitBox
juzhiyuan commented on issue #719: bugfix: support more built-in parameters when set chash balancer URL: https://github.com/apache/incubator-apisix/pull/719#issuecomment-548228338 @lilien1010 because the current branch doesn't have the latest Dashboard codes, we may need update the

[GitHub] [incubator-apisix] juzhiyuan edited a comment on issue #719: bugfix: support more built-in parameters when set chash balancer

2019-10-31 Thread GitBox
juzhiyuan edited a comment on issue #719: bugfix: support more built-in parameters when set chash balancer URL: https://github.com/apache/incubator-apisix/pull/719#issuecomment-548228338 @lilien1010 because the current branch doesn't have the latest Dashboard codes, we may need update the

[GitHub] [incubator-apisix] juzhiyuan commented on issue #772: Doc: add HelloTalk into powered-by

2019-10-30 Thread GitBox
juzhiyuan commented on issue #772: Doc: add HelloTalk into powered-by URL: https://github.com/apache/incubator-apisix/pull/772#issuecomment-548209449 What about this PR https://github.com/apache/incubator-apisix/pull/690 This

[GitHub] [incubator-apisix] lilien1010 closed pull request #690: Update powered-by.md

2019-10-30 Thread GitBox
lilien1010 closed pull request #690: Update powered-by.md URL: https://github.com/apache/incubator-apisix/pull/690 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-apisix] lilien1010 commented on issue #772: Doc: add HelloTalk into powered-by

2019-10-30 Thread GitBox
lilien1010 commented on issue #772: Doc: add HelloTalk into powered-by URL: https://github.com/apache/incubator-apisix/pull/772#issuecomment-548211533 @juzhiyuan I close that one ,since that branch patch-3 is outdate This

[GitHub] [incubator-apisix] lilien1010 commented on issue #719: bugfix: support more built-in parameters when set chash balancer

2019-10-30 Thread GitBox
lilien1010 commented on issue #719: bugfix: support more built-in parameters when set chash balancer URL: https://github.com/apache/incubator-apisix/pull/719#issuecomment-548212617 it wired, I already rebased from remote master, and made the file comparision with 'beyond compare' ,it

[GitHub] [incubator-apisix] moonming opened a new pull request #773: CI: skip make check for macos.

2019-10-30 Thread GitBox
moonming opened a new pull request #773: CI: skip make check for macos. URL: https://github.com/apache/incubator-apisix/pull/773 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-apisix] moonming commented on a change in pull request #772: Doc: add HelloTalk into powered-by

2019-10-30 Thread GitBox
moonming commented on a change in pull request #772: Doc: add HelloTalk into powered-by URL: https://github.com/apache/incubator-apisix/pull/772#discussion_r340970298 ## File path: doc/powered-by.md ## @@ -48,3 +49,6 @@ Using APISIX as a gateway, it uses the functions of

[GitHub] [incubator-apisix] moonming merged pull request #770: license: ingore grpc_server_example dir for check license.

2019-10-30 Thread GitBox
moonming merged pull request #770: license: ingore grpc_server_example dir for check license. URL: https://github.com/apache/incubator-apisix/pull/770 This is an automated message from the Apache Git Service. To respond to

[GitHub] [incubator-apisix] lilien1010 opened a new pull request #772: Doc: add HelloTalk into powered-by

2019-10-30 Thread GitBox
lilien1010 opened a new pull request #772: Doc: add HelloTalk into powered-by URL: https://github.com/apache/incubator-apisix/pull/772 ### Summary SUMMARY_HERE ### Full changelog * [Implement ...] * [Add related tests] * ... ### Issues resolved Fix

[GitHub] [incubator-apisix] tom2nonames commented on issue #846: grpc-transcode 插件的配置中增加proto option 选项开关.

2019-11-13 Thread GitBox
tom2nonames commented on issue #846: grpc-transcode 插件的配置中增加proto option 选项开关. URL: https://github.com/apache/incubator-apisix/pull/846#issuecomment-553365204 Dear nic-chen, 测试用例本打算写的, 但这个测试需要有一个支持grpc的服务, 需要定义proto的message 和 rpc 方法, 我在源代码中也没有找到这一部分的代码, 我想CI 跑的时候这个服务需要先启动吧!

[GitHub] [incubator-apisix] nic-chen commented on issue #846: grpc-transcode 插件的配置中增加proto option 选项开关.

2019-11-13 Thread GitBox
nic-chen commented on issue #846: grpc-transcode 插件的配置中增加proto option 选项开关. URL: https://github.com/apache/incubator-apisix/pull/846#issuecomment-553354697 @tom2nonames need test cases cover. This is an automated message

[GitHub] [incubator-apisix] cuiyuan commented on issue #487: Who is using APISIX?(欢迎使用 APISIX 的个人和公司在此留言)

2019-11-13 Thread GitBox
cuiyuan commented on issue #487: Who is using APISIX?(欢迎使用 APISIX 的个人和公司在此留言) URL: https://github.com/apache/incubator-apisix/issues/487#issuecomment-553324665 Organization: Netease Location: Hangzhou, China Contact: cui...@gmail.com Scenario: test,Research

[GitHub] [incubator-apisix] membphis commented on issue #847: Is there any plan to support zookeeper ??

2019-11-13 Thread GitBox
membphis commented on issue #847: Is there any plan to support zookeeper ?? URL: https://github.com/apache/incubator-apisix/issues/847#issuecomment-553427799 There is currently no such plan now, and etcd is more suitable for APISIX.

[GitHub] [incubator-apisix] membphis commented on issue #487: Who is using APISIX?(欢迎使用 APISIX 的个人和公司在此留言)

2019-11-13 Thread GitBox
membphis commented on issue #487: Who is using APISIX?(欢迎使用 APISIX 的个人和公司在此留言) URL: https://github.com/apache/incubator-apisix/issues/487#issuecomment-553413544 @cuiyuan would you send a PR to add your company into the powered-by page? thx

[GitHub] [incubator-apisix] membphis commented on a change in pull request #846: grpc-transcode 插件的配置中增加proto option 选项开关.

2019-11-13 Thread GitBox
membphis commented on a change in pull request #846: grpc-transcode 插件的配置中增加proto option 选项开关. URL: https://github.com/apache/incubator-apisix/pull/846#discussion_r345784452 ## File path: doc/plugins/grpc-transcoding-cn.md ## @@ -107,3 +107,72 @@ Proxy-Connection:

[GitHub] [incubator-apisix] lilien1010 commented on a change in pull request #855: Allow APISIX config more Nginx-built-in directives into nginx.conf

2019-11-14 Thread GitBox
lilien1010 commented on a change in pull request #855: Allow APISIX config more Nginx-built-in directives into nginx.conf URL: https://github.com/apache/incubator-apisix/pull/855#discussion_r346346096 ## File path: conf/config.yaml ## @@ -65,6 +65,11 @@ nginx_config:

[GitHub] [incubator-apisix] membphis commented on issue #838: bug: APISIX v0.8 doesn't support the Stand-alone mode, need fix the doc.

2019-11-13 Thread GitBox
membphis commented on issue #838: bug: APISIX v0.8 doesn't support the Stand-alone mode, need fix the doc. URL: https://github.com/apache/incubator-apisix/issues/838#issuecomment-553644786 I got it too, thx @justinmclean

<    1   2   3   4   5   6   7   8   9   10   >