[GitHub] [apisix] tokers commented on pull request #2233: change: check etcd cluster version when init_etcd

tokers commented on pull request #2233: URL: https://github.com/apache/apisix/pull/2233#issuecomment-693204656 @membphis Fixed. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [apisix] tokers commented on pull request #2233: change: check etcd cluster version when init_etcd

tokers commented on pull request #2233: URL: https://github.com/apache/apisix/pull/2233#issuecomment-693134034 @moonming I found PR #2036 also checked the etcd version, but IMHO the way is wrong. Firstly, when we ask the version message from etcd, it returns a JSON string like

[GitHub] [apisix] tokers commented on pull request #2233: change: check etcd cluster version when init_etcd

tokers commented on pull request #2233: URL: https://github.com/apache/apisix/pull/2233#issuecomment-693130100 @moonming OK, let me rebase my branch. By the way, i think it's better to check out the CHANGELOG of etcd, AKAIK there are some bugs in 3.x series releases, but i'm not sure the

[GitHub] [apisix] tokers commented on pull request #2233: change: check etcd cluster version when init_etcd

tokers commented on pull request #2233: URL: https://github.com/apache/apisix/pull/2233#issuecomment-693127956 @moonming It seems the version selection for etcd is not specified in `./bin/apisix` or other stuffs. Is it under the Github Action's control?