[GitHub] [incubator-apisix] membphis commented on pull request #1888: change: add more prometheus metrics(etcd modify index)

2020-07-30 Thread GitBox
membphis commented on pull request #1888: URL: https://github.com/apache/incubator-apisix/pull/1888#issuecomment-666129858 @nic-chen please update the checklist, it seems that we are missing `Have you modified the corresponding document?` .

[GitHub] [incubator-apisix] membphis commented on pull request #1888: change: add more prometheus metrics(etcd modify index)

2020-07-29 Thread GitBox
membphis commented on pull request #1888: URL: https://github.com/apache/incubator-apisix/pull/1888#issuecomment-665122748 @nic-chen if you have fixed them, you can click this button, it means you have fixed it.

[GitHub] [incubator-apisix] membphis commented on pull request #1888: change: add more prometheus metrics(etcd modify index)

2020-07-25 Thread GitBox
membphis commented on pull request #1888: URL: https://github.com/apache/incubator-apisix/pull/1888#issuecomment-663918587 Because we added some new metrics this time, it will affect the performance, so let’s do a simple performance test.