[jira] [Updated] (ASTERIXDB-1623) Certain Rewrite Rule causes NPE in LogicalPlan.toString()

[Xikui Wang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ASTERIXDB-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Xikui Wang updated ASTERIXDB-1623:
--
Description: 
I met this bug when I was adding 'upsert-option' for the feed part. The easiest 
way to reproduce this bug is to checkout my change at gerrit: 
https://asterix-gerrit.ics.uci.edu/#/c/1068/ and execute the added test case. 

The logical plan generated by subscribe statement is: 
from: 
org/apache/hyracks/algebricks/core/rewriter/base/HeuristicOptimizer.java:81
{quote}
sink -- |UNPARTITIONED|
  upsert into experiments:TwitterUsers from record: %0->$$2 partitioned by 
[%0->$$3] out: ([record-before-upsert:null])  -- |UNPARTITIONED|
assign [$$3] <- [function-call: asterix:field-access-by-name, 
Args:[%0->$$2, AString: {screen-name}]] -- |UNPARTITIONED|
  project ([$$2]) -- |UNPARTITIONED|
assign [$$2] <- [function-call: asterix:collection-to-sequence, 
Args:[%0->$$0]] -- |UNPARTITIONED|
  unnest $$0 <- function-call: asterix:feed-collect, Args:[AString: 
{experiments}, AString: {UserFeed}, AString: {UserFeed}, AString: {INTAKE}, 
AString: {TwitterUsers}, AString: {TwitterUserType}] -- |UNPARTITIONED|
empty-tuple-source -- |UNPARTITIONED|
{quote}

I managed to trace down that after runOptimizationSets 
(org.apache.hyracks.algebricks.core.rewriter.base.HeuristicOptimizer#runOptimizationSets)
 worked on ruleList "ruleList.second.get(0) instanceof PullSelectOutOfEqJoin", 
the plan.toString will causes NPE. 

In normal scenario, this exception will not appear due to the log level 
setting. However, during the integration test, this bug will be triggered by 
org/apache/hyracks/algebricks/core/rewriter/base/HeuristicOptimizer.java:85

The stack trace is as below:

{quote}
java.lang.NullPointerException
at 
org.apache.hyracks.algebricks.core.algebra.expressions.VariableReferenceExpression.toString(VariableReferenceExpression.java:67)
at java.lang.String.valueOf(String.java:2994)
at java.lang.StringBuilder.append(StringBuilder.java:131)
at 
org.apache.hyracks.algebricks.core.algebra.expressions.AbstractFunctionCallExpression.toString(AbstractFunctionCallExpression.java:124)
at java.lang.String.valueOf(String.java:2994)
at java.lang.StringBuilder.append(StringBuilder.java:131)
at 
org.apache.hyracks.algebricks.core.algebra.expressions.AbstractFunctionCallExpression.toString(AbstractFunctionCallExpression.java:124)
at 
org.apache.hyracks.algebricks.core.algebra.prettyprint.LogicalExpressionPrettyPrintVisitor.visitScalarFunctionCallExpression(LogicalExpressionPrettyPrintVisitor.java:57)
at 
org.apache.hyracks.algebricks.core.algebra.prettyprint.LogicalExpressionPrettyPrintVisitor.visitScalarFunctionCallExpression(LogicalExpressionPrettyPrintVisitor.java:31)
at 
org.apache.hyracks.algebricks.core.algebra.expressions.ScalarFunctionCallExpression.accept(ScalarFunctionCallExpression.java:55)
at 
org.apache.hyracks.algebricks.core.algebra.prettyprint.LogicalOperatorPrettyPrintVisitor.pprintExprList(LogicalOperatorPrettyPrintVisitor.java:483)
at 
org.apache.hyracks.algebricks.core.algebra.prettyprint.LogicalOperatorPrettyPrintVisitor.visitAssignOperator(LogicalOperatorPrettyPrintVisitor.java:198)
at 
org.apache.hyracks.algebricks.core.algebra.prettyprint.LogicalOperatorPrettyPrintVisitor.visitAssignOperator(LogicalOperatorPrettyPrintVisitor.java:70)
at 
org.apache.hyracks.algebricks.core.algebra.operators.logical.AssignOperator.accept(AssignOperator.java:63)
at 
org.apache.hyracks.algebricks.core.algebra.prettyprint.PlanPrettyPrinter.printOperator(PlanPrettyPrinter.java:47)
at 
org.apache.hyracks.algebricks.core.algebra.prettyprint.PlanPrettyPrinter.printOperator(PlanPrettyPrinter.java:59)
at 
org.apache.hyracks.algebricks.core.algebra.prettyprint.PlanPrettyPrinter.printOperator(PlanPrettyPrinter.java:59)
at 
org.apache.hyracks.algebricks.core.algebra.prettyprint.PlanPrettyPrinter.printPlan(PlanPrettyPrinter.java:33)
at 
org.apache.hyracks.algebricks.core.rewriter.base.HeuristicOptimizer.logPlanAt(HeuristicOptimizer.java:93)
at 
org.apache.hyracks.algebricks.core.rewriter.base.HeuristicOptimizer.optimize(HeuristicOptimizer.java:85)
at 
org.apache.hyracks.algebricks.compiler.api.HeuristicCompilerFactoryBuilder$1$1.optimize(HeuristicCompilerFactoryBuilder.java:90)
at 
org.apache.asterix.api.common.APIFramework.compileQuery(APIFramework.java:275)
at 
org.apache.asterix.app.translator.QueryTranslator.rewriteCompileQuery(QueryTranslator.java:1959)
at 
org.apache.asterix.app.translator.QueryTranslator.handleSubscribeFeedStatement(QueryTranslator.java:2406)
at 
org.apache.asterix.app.translator.QueryTranslator.compileAndExecute(QueryTranslator.java:358)
at 

[jira] [Commented] (ASTERIXDB-1623) Certain Rewrite Rule causes NPE in LogicalPlan.toString()

[Xikui Wang (JIRA)]

[ 
https://issues.apache.org/jira/browse/ASTERIXDB-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15454367#comment-15454367
 ] 

Xikui Wang commented on ASTERIXDB-1623:
---

Attached. :) 

> Certain Rewrite Rule causes NPE in LogicalPlan.toString()
> -
>
> Key: ASTERIXDB-1623
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1623
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: Optimizer
>Reporter: Xikui Wang
>Assignee: Yingyi Bu
>
> I met this bug when I was adding 'upsert-option' for the feed part. The 
> easiest way to reproduce this bug is to checkout my change at gerrit: 
> https://asterix-gerrit.ics.uci.edu/#/c/1068/ and execute the added test case. 
> The logical plan generated by subscribe statement is: 
> from: 
> org/apache/hyracks/algebricks/core/rewriter/base/HeuristicOptimizer.java:81
> {quote}
> sink -- |UNPARTITIONED|
>   upsert into experiments:TwitterUsers from record: %0->$$2 partitioned by 
> [%0->$$3] out: ([record-before-upsert:null])  -- |UNPARTITIONED|
> assign [$$3] <- [function-call: asterix:field-access-by-name, 
> Args:[%0->$$2, AString: {screen-name}]] -- |UNPARTITIONED|
>   project ([$$2]) -- |UNPARTITIONED|
> assign [$$2] <- [function-call: asterix:collection-to-sequence, 
> Args:[%0->$$0]] -- |UNPARTITIONED|
>   unnest $$0 <- function-call: asterix:feed-collect, Args:[AString: 
> {experiments}, AString: {UserFeed}, AString: {UserFeed}, AString: {INTAKE}, 
> AString: {TwitterUsers}, AString: {TwitterUserType}] -- |UNPARTITIONED|
> empty-tuple-source -- |UNPARTITIONED|
> {quote}
> I managed to trace down that after runOptimizationSets 
> (org.apache.hyracks.algebricks.core.rewriter.base.HeuristicOptimizer#runOptimizationSets)
>  worked on ruleList "ruleList.second.get(0) instanceof 
> PullSelectOutOfEqJoin", the plan.toString will causes NPE. 
> In normal scenario, this exception will not appear due to the log level 
> setting. However, during the integration test, this bug will be triggered by 
> org/apache/hyracks/algebricks/core/rewriter/base/HeuristicOptimizer.java:85
> The stack trace is as below:
> {quote}
> java.lang.NullPointerException
>   at 
> org.apache.hyracks.algebricks.core.algebra.expressions.VariableReferenceExpression.toString(VariableReferenceExpression.java:67)
>   at java.lang.String.valueOf(String.java:2994)
>   at java.lang.StringBuilder.append(StringBuilder.java:131)
>   at 
> org.apache.hyracks.algebricks.core.algebra.expressions.AbstractFunctionCallExpression.toString(AbstractFunctionCallExpression.java:124)
>   at java.lang.String.valueOf(String.java:2994)
>   at java.lang.StringBuilder.append(StringBuilder.java:131)
>   at 
> org.apache.hyracks.algebricks.core.algebra.expressions.AbstractFunctionCallExpression.toString(AbstractFunctionCallExpression.java:124)
>   at 
> org.apache.hyracks.algebricks.core.algebra.prettyprint.LogicalExpressionPrettyPrintVisitor.visitScalarFunctionCallExpression(LogicalExpressionPrettyPrintVisitor.java:57)
>   at 
> org.apache.hyracks.algebricks.core.algebra.prettyprint.LogicalExpressionPrettyPrintVisitor.visitScalarFunctionCallExpression(LogicalExpressionPrettyPrintVisitor.java:31)
>   at 
> org.apache.hyracks.algebricks.core.algebra.expressions.ScalarFunctionCallExpression.accept(ScalarFunctionCallExpression.java:55)
>   at 
> org.apache.hyracks.algebricks.core.algebra.prettyprint.LogicalOperatorPrettyPrintVisitor.pprintExprList(LogicalOperatorPrettyPrintVisitor.java:483)
>   at 
> org.apache.hyracks.algebricks.core.algebra.prettyprint.LogicalOperatorPrettyPrintVisitor.visitAssignOperator(LogicalOperatorPrettyPrintVisitor.java:198)
>   at 
> org.apache.hyracks.algebricks.core.algebra.prettyprint.LogicalOperatorPrettyPrintVisitor.visitAssignOperator(LogicalOperatorPrettyPrintVisitor.java:70)
>   at 
> org.apache.hyracks.algebricks.core.algebra.operators.logical.AssignOperator.accept(AssignOperator.java:63)
>   at 
> org.apache.hyracks.algebricks.core.algebra.prettyprint.PlanPrettyPrinter.printOperator(PlanPrettyPrinter.java:47)
>   at 
> org.apache.hyracks.algebricks.core.algebra.prettyprint.PlanPrettyPrinter.printOperator(PlanPrettyPrinter.java:59)
>   at 
> org.apache.hyracks.algebricks.core.algebra.prettyprint.PlanPrettyPrinter.printOperator(PlanPrettyPrinter.java:59)
>   at 
> org.apache.hyracks.algebricks.core.algebra.prettyprint.PlanPrettyPrinter.printPlan(PlanPrettyPrinter.java:33)
>   at 
> org.apache.hyracks.algebricks.core.rewriter.base.HeuristicOptimizer.logPlanAt(HeuristicOptimizer.java:93)
>   at 
> org.apache.hyracks.algebricks.core.rewriter.base.HeuristicOptimizer.optimize(HeuristicOptimizer.java:85)
>   at 
> 

Change in asterixdb[master]: Output From ShutdownAPIServlet; status 405 on GET

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Output From ShutdownAPIServlet; status 405 on GET
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/531/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1136
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f1a7d707ebdcb2a6502bc06d35d7ed38121e472
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Not suppose to MERGE, for discussion purpose The following c...

[Jianfeng Jia (Code Review)]

Jianfeng Jia has posted comments on this change.

Change subject: Not suppose to MERGE, for discussion purpose The following 
commits from your working branch will be included:
..


Patch Set 1:

@Yingyi, I think there maybe the issue of the Math.pow() which gives an 
approximate result. Here I tested the Int number from 1 to Int.Max. The result 
is as expected, but this test gonna take looong to execute. Any suggestions?

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1135
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id6d437ccff51adb236f4e69c78761a2c336ae71a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Jianfeng Jia 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: Not suppose to MERGE, for discussion purpose The following c...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Not suppose to MERGE, for discussion purpose The following 
commits from your working branch will be included:
..


Patch Set 1:

Integration Tests Aborted

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/529/ : 
ABORTED

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1135
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id6d437ccff51adb236f4e69c78761a2c336ae71a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Jianfeng Jia 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Output From ShutdownAPIServlet; status 405 on GET

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Output From ShutdownAPIServlet; status 405 on GET
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2483/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1136
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f1a7d707ebdcb2a6502bc06d35d7ed38121e472
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Output From ShutdownAPIServlet; status 405 on GET

[Michael Blow (Code Review)]

Michael Blow has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1136

Change subject: Output From ShutdownAPIServlet; status 405 on GET
..

Output From ShutdownAPIServlet; status 405 on GET

Change-Id: I3f1a7d707ebdcb2a6502bc06d35d7ed38121e472
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ShutdownAPIServlet.java
1 file changed, 22 insertions(+), 10 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/36/1136/1

diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ShutdownAPIServlet.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ShutdownAPIServlet.java
index 6d8c444..dd2f799 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ShutdownAPIServlet.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/servlet/ShutdownAPIServlet.java
@@ -19,6 +19,8 @@
 package org.apache.asterix.api.http.servlet;
 
 import java.io.IOException;
+import java.io.PrintWriter;
+import java.util.Date;
 import java.util.logging.Level;
 
 import javax.servlet.ServletContext;
@@ -28,7 +30,9 @@
 import javax.servlet.http.HttpServletResponse;
 
 import org.apache.asterix.common.config.GlobalConfig;
+import org.apache.asterix.om.util.AsterixClusterProperties;
 import org.apache.hyracks.api.client.IHyracksClientConnection;
+import org.json.JSONObject;
 
 import static 
org.apache.asterix.api.http.servlet.ServletConstants.HYRACKS_CONNECTION_ATTR;
 
@@ -39,23 +43,31 @@
 protected void doPost(HttpServletRequest request, HttpServletResponse 
response)
 throws ServletException, IOException {
 
-response.setContentType("application/json");
-response.setCharacterEncoding("utf-8");
-
 ServletContext context = getServletContext();
 IHyracksClientConnection hcc = (IHyracksClientConnection) 
context.getAttribute(HYRACKS_CONNECTION_ATTR);
 Thread t = new Thread(() -> {
 try {
 hcc.stopCluster();
 } catch (Exception e) {
-GlobalConfig.ASTERIX_LOGGER.log(Level.SEVERE, e.getMessage(), 
e);
+GlobalConfig.ASTERIX_LOGGER.log(Level.SEVERE, "Exception 
stopping cluster", e);
 }
-});
-t.start();
-response.setStatus(HttpServletResponse.SC_ACCEPTED);
-}
+}, "Shutdown Servlet Worker");
 
-@Override
-public void doGet(HttpServletRequest request, HttpServletResponse 
response) throws IOException {
+response.setContentType("application/json");
+response.setCharacterEncoding("utf-8");
+response.setStatus(HttpServletResponse.SC_ACCEPTED);
+JSONObject jsonObject = new JSONObject();
+try {
+jsonObject.put("status", "SHUTTING_DOWN");
+jsonObject.put("date", new Date());
+jsonObject.put("cluster" , 
AsterixClusterProperties.INSTANCE.getClusterStateDescription());
+
+final PrintWriter writer = response.getWriter();
+writer.print(jsonObject.toString(4));
+writer.close();
+} catch (Exception e) {
+GlobalConfig.ASTERIX_LOGGER.log(Level.INFO, "Exception writing 
response", e);
+}
+t.start();
 }
 }

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1136
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3f1a7d707ebdcb2a6502bc06d35d7ed38121e472
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 

Change in asterixdb[master]: Not suppose to MERGE, for discussion purpose The following c...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Not suppose to MERGE, for discussion purpose The following 
commits from your working branch will be included:
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/529/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1135
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id6d437ccff51adb236f4e69c78761a2c336ae71a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Jianfeng Jia 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Not suppose to MERGE, for discussion purpose The following c...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Not suppose to MERGE, for discussion purpose The following 
commits from your working branch will be included:
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2482/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1135
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id6d437ccff51adb236f4e69c78761a2c336ae71a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Jianfeng Jia 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1581: fix subquery decorrelation.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1581: fix subquery decorrelation.
..


Patch Set 9: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/528/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1125
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2fa4b5b836eafee1975bd1164ae7c22199a4af0
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

[jira] [Commented] (ASTERIXDB-1623) Certain Rewrite Rule causes NPE in LogicalPlan.toString()

[Till (JIRA)]

[ 
https://issues.apache.org/jira/browse/ASTERIXDB-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15453542#comment-15453542
 ] 

Till commented on ASTERIXDB-1623:
-

[~idleft], could you attach a stack trace to the issue?

> Certain Rewrite Rule causes NPE in LogicalPlan.toString()
> -
>
> Key: ASTERIXDB-1623
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1623
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: Optimizer
>Reporter: Xikui Wang
>Assignee: Yingyi Bu
>
> I met this bug when I was adding 'upsert-option' for the feed part. The 
> easiest way to reproduce this bug is to checkout my change at gerrit: 
> https://asterix-gerrit.ics.uci.edu/#/c/1068/ and execute the added test case. 
> The logical plan generated by subscribe statement is: 
> from: 
> org/apache/hyracks/algebricks/core/rewriter/base/HeuristicOptimizer.java:81
> {quote}
> sink -- |UNPARTITIONED|
>   upsert into experiments:TwitterUsers from record: %0->$$2 partitioned by 
> [%0->$$3] out: ([record-before-upsert:null])  -- |UNPARTITIONED|
> assign [$$3] <- [function-call: asterix:field-access-by-name, 
> Args:[%0->$$2, AString: {screen-name}]] -- |UNPARTITIONED|
>   project ([$$2]) -- |UNPARTITIONED|
> assign [$$2] <- [function-call: asterix:collection-to-sequence, 
> Args:[%0->$$0]] -- |UNPARTITIONED|
>   unnest $$0 <- function-call: asterix:feed-collect, Args:[AString: 
> {experiments}, AString: {UserFeed}, AString: {UserFeed}, AString: {INTAKE}, 
> AString: {TwitterUsers}, AString: {TwitterUserType}] -- |UNPARTITIONED|
> empty-tuple-source -- |UNPARTITIONED|
> {quote}
> I managed to trace down that after runOptimizationSets 
> (org.apache.hyracks.algebricks.core.rewriter.base.HeuristicOptimizer#runOptimizationSets)
>  worked on ruleList "ruleList.second.get(0) instanceof 
> PullSelectOutOfEqJoin", the plan.toString will causes NPE. 
> In normal scenario, this exception will not appear due to the log level 
> setting. However, during the integration test, this bug will be triggered by 
> org/apache/hyracks/algebricks/core/rewriter/base/HeuristicOptimizer.java:85



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Change in asterixdb[master]: ASTERIXDB-1581: fix subquery decorrelation.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1581: fix subquery decorrelation.
..


Patch Set 9:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/528/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1125
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2fa4b5b836eafee1975bd1164ae7c22199a4af0
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

[jira] [Updated] (ASTERIXDB-1588) Exception when using auto generated uuid primary key and socket feed

[Xikui Wang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ASTERIXDB-1588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Xikui Wang updated ASTERIXDB-1588:
--
Assignee: Yingyi Bu  (was: Xikui Wang)

> Exception when using auto generated uuid primary key and socket feed
> 
>
> Key: ASTERIXDB-1588
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1588
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: Feeds
>Reporter: Xikui Wang
>Assignee: Yingyi Bu
>
> Following ddl with 'autogenerated' will cause indexOutOfBoundary exception at 
> the SocketFeed part.
> {quote}
> drop dataverse feeds if exists; 
> create dataverse feeds;
> use dataverse feeds;
> create type TwitterUser if not exists as open\{
> screen-name: uuid
> \};
> create dataset TwitterUsers1(TwitterUser) primary key screen-name 
> autogenerated;
> create feed UserFeed1 using socket_adapter
> (
>   ("sockets"="127.0.0.1:10001"),
>   ("address-type"="IP"),
>   ("type-name"="TwitterUser"),
>   ("format"="adm")
> );
> use dataverse feeds;
> set wait-for-completion-feed "false";
> connect feed UserFeed1 to dataset TwitterUsers1
> {quote}
> The reason this happens is when SocketServerInputStream found no available 
> bytes, it will trigger the TupleForwarder to flush all tuples. 
> org/apache/asterix/external/input/stream/SocketServerInputStream.java:70
> This causes the indexOutOfBoundary exception at 
> org/apache/asterix/external/util/FeedUtils.java:123
> Same ddl without 'autogenerated' will work properly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (ASTERIXDB-1588) Exception when using auto generated uuid primary key and socket feed

[Xikui Wang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ASTERIXDB-1588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Xikui Wang reassigned ASTERIXDB-1588:
-

Assignee: Xikui Wang

> Exception when using auto generated uuid primary key and socket feed
> 
>
> Key: ASTERIXDB-1588
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1588
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: Feeds
>Reporter: Xikui Wang
>Assignee: Xikui Wang
>
> Following ddl with 'autogenerated' will cause indexOutOfBoundary exception at 
> the SocketFeed part.
> {quote}
> drop dataverse feeds if exists; 
> create dataverse feeds;
> use dataverse feeds;
> create type TwitterUser if not exists as open\{
> screen-name: uuid
> \};
> create dataset TwitterUsers1(TwitterUser) primary key screen-name 
> autogenerated;
> create feed UserFeed1 using socket_adapter
> (
>   ("sockets"="127.0.0.1:10001"),
>   ("address-type"="IP"),
>   ("type-name"="TwitterUser"),
>   ("format"="adm")
> );
> use dataverse feeds;
> set wait-for-completion-feed "false";
> connect feed UserFeed1 to dataset TwitterUsers1
> {quote}
> The reason this happens is when SocketServerInputStream found no available 
> bytes, it will trigger the TupleForwarder to flush all tuples. 
> org/apache/asterix/external/input/stream/SocketServerInputStream.java:70
> This causes the indexOutOfBoundary exception at 
> org/apache/asterix/external/util/FeedUtils.java:123
> Same ddl without 'autogenerated' will work properly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Change in asterixdb[master]: ASTERIXDB-1581: fix subquery decorrelation.

[Yingyi Bu (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1125

to look at the new patch set (#9).

Change subject: ASTERIXDB-1581: fix subquery decorrelation.
..

ASTERIXDB-1581: fix subquery decorrelation.

- fix concurrent modification exception;
- fix variable substitution ordering;
- fix required partitioning property for DataSourceScan;
- fix partitioning property enforcer for nested operators;
- fix recursive subplan decorrelation;
- fix CardinalityInferenceVisitor;
- add a rule to switch inner join branches;
- fix SimpleUnnestToProductRule;
- add test cases which are variants of ASTERIXDB-1581.

Change-Id: Ia2fa4b5b836eafee1975bd1164ae7c22199a4af0
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/InvertedIndexAccessMethod.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineAllNtsInSubplanVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineSubplanInputForNestedTupleSourceRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/SubplanFlatteningUtil.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/join-singletonbranch-2.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/join-singletonbranch-3.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/join-singletonbranch.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/tpcds/query-ASTERIXDB-1581-correlated.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/tpcds/query-ASTERIXDB-1581.sqlpp
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/filter-nested.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/join-singletonbranch-2.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/join-singletonbranch-3.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/join-singletonbranch.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/nest_aggregate.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/tpcds/query-ASTERIXDB-1581-correlated.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/tpcds/query-ASTERIXDB-1581.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/udfs/query-ASTERIXDB-1018.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/udfs/query-ASTERIXDB-1019.plan
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/aggregate_join/aggregate_join.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/aggregate_join/aggregate_join.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/aggregate_join/aggregate_join.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/aggregate_join_external/aggregate_join_external.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/aggregate_join_external/aggregate_join_external.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-2/query-ASTERIXDB-1581-2.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-2/query-ASTERIXDB-1581-2.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-2/query-ASTERIXDB-1581-2.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-3/query-ASTERIXDB-1581-3.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-3/query-ASTERIXDB-1581-3.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-3/query-ASTERIXDB-1581-3.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-4/query-ASTERIXDB-1581-4.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-4/query-ASTERIXDB-1581-4.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-4/query-ASTERIXDB-1581-4.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-5/query-ASTERIXDB-1581-5.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-5/query-ASTERIXDB-1581-5.2.update.sqlpp
A 

Change in asterixdb[master]: Extensibility, Cleanup For Client Helper

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Extensibility, Cleanup For Client Helper
..


Patch Set 1:

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/527/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1133
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa24e952c1b49d7d3a5b971906915ae1560086c8
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1581: fix subquery decorrelation.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1581: fix subquery decorrelation.
..


Patch Set 8:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1125
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2fa4b5b836eafee1975bd1164ae7c22199a4af0
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1581: fix subquery decorrelation.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1581: fix subquery decorrelation.
..


Patch Set 8:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2479/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1125
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2fa4b5b836eafee1975bd1164ae7c22199a4af0
Gerrit-PatchSet: 8
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1581: fix subquery decorrelation.

[Yingyi Bu (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1125

to look at the new patch set (#8).

Change subject: ASTERIXDB-1581: fix subquery decorrelation.
..

ASTERIXDB-1581: fix subquery decorrelation.

- fix concurrent modification exception;
- fix variable substitution ordering;
- fix required partitioning property for DataSourceScan;
- fix partitioning property enforcer for nested operators;
- fix recursive subplan decorrelation;
- fix CardinalityInferenceVisitor;
- add a rule to switch inner join branches;
- fix SimpleUnnestToProductRule;
- add test cases which are variants of ASTERIXDB-1581.

Change-Id: Ia2fa4b5b836eafee1975bd1164ae7c22199a4af0
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/InvertedIndexAccessMethod.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineAllNtsInSubplanVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineSubplanInputForNestedTupleSourceRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/SubplanFlatteningUtil.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/join-singletonbranch-2.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/join-singletonbranch-3.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/join-singletonbranch.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/tpcds/query-ASTERIXDB-1581-correlated.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/tpcds/query-ASTERIXDB-1581.sqlpp
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/filter-nested.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/join-singletonbranch-2.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/join-singletonbranch-3.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/join-singletonbranch.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/nest_aggregate.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/tpcds/query-ASTERIXDB-1581-correlated.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/tpcds/query-ASTERIXDB-1581.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/udfs/query-ASTERIXDB-1018.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/udfs/query-ASTERIXDB-1019.plan
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/aggregate_join/aggregate_join.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/aggregate_join/aggregate_join.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/aggregate_join/aggregate_join.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/aggregate_join_external/aggregate_join_external.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/aggregate_join_external/aggregate_join_external.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-2/query-ASTERIXDB-1581-2.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-2/query-ASTERIXDB-1581-2.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-2/query-ASTERIXDB-1581-2.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-3/query-ASTERIXDB-1581-3.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-3/query-ASTERIXDB-1581-3.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-3/query-ASTERIXDB-1581-3.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-4/query-ASTERIXDB-1581-4.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-4/query-ASTERIXDB-1581-4.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-4/query-ASTERIXDB-1581-4.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-5/query-ASTERIXDB-1581-5.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-5/query-ASTERIXDB-1581-5.2.update.sqlpp
A 

Change in asterixdb[master]: Extensibility, Cleanup For Client Helper

[Michael Blow (Code Review)]

Michael Blow has submitted this change and it was merged.

Change subject: Extensibility, Cleanup For Client Helper
..


Extensibility, Cleanup For Client Helper

Change-Id: Ifa24e952c1b49d7d3a5b971906915ae1560086c8
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1133
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Reviewed-by: Till Westmann 
---
M 
asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/AsterixHelperExecution.java
M 
asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/commands/ClientCommand.java
M 
asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/commands/RemoteCommand.java
3 files changed, 17 insertions(+), 8 deletions(-)

Approvals:
  Till Westmann: Looks good to me, approved
  Jenkins: Verified; No violations found



diff --git 
a/asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/AsterixHelperExecution.java
 
b/asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/AsterixHelperExecution.java
index 82e8386..419e660 100644
--- 
a/asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/AsterixHelperExecution.java
+++ 
b/asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/AsterixHelperExecution.java
@@ -33,6 +33,7 @@
 public class AsterixHelperExecution {
 
 public static final String ASTERIX_HELPER = "asterixhelper";
+public static final int COMMAND_USAGE_ALIGNMENT = 20;
 
 protected AsterixHelperExecution() {
 }
@@ -41,7 +42,7 @@
 "squid:S106", // use of System.err
 "squid:S1166" // rethrow or log exception
 })
-protected int execute(String [] argArray) throws IOException {
+public int execute(String [] argArray) throws IOException {
 Args args = createArgs();
 CmdLineParser parser = createParser(args);
 try {
@@ -59,7 +60,7 @@
 System.err.println("ERROR: " + e.getMessage() + "\n\n"
 + "Usage: " + getHelperCommandName() + " [options] 
\n\n"
 + "Commands:");
-printCommandUsage(System.err);
+printCommandsUsage(System.err);
 System.err.println("Options:");
 parser.printUsage(System.err);
 System.err.flush();
@@ -71,12 +72,20 @@
 return ASTERIX_HELPER;
 }
 
-protected void printCommandUsage(PrintStream out) {
+protected void printCommandsUsage(PrintStream out) {
 for (Command command : Command.values()) {
-out.println("  " + command.name().toLowerCase() + " " + 
command.usage());
+printCommandUsage(out, command.name(), command.usage());
 }
 }
 
+protected void printCommandUsage(PrintStream out, String name, String 
usage) {
+StringBuilder padding = new StringBuilder();
+for (int i = name.length(); i < COMMAND_USAGE_ALIGNMENT; i++) {
+padding.append(' ');
+}
+out.println("  " + name.toLowerCase() + padding.toString() + " : " + 
usage);
+}
+
 protected CmdLineParser createParser(Args args) {
 return new CmdLineParser(args, 
ParserProperties.defaults().withUsageWidth(120));
 }
diff --git 
a/asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/commands/ClientCommand.java
 
b/asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/commands/ClientCommand.java
index 734d87b..8f0cac0 100644
--- 
a/asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/commands/ClientCommand.java
+++ 
b/asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/commands/ClientCommand.java
@@ -28,9 +28,9 @@
 public abstract class ClientCommand {
 
 public enum Command {
-GET_CLUSTER_STATE("- Get state of cluster (errorcode 0 = UP, non-zero 
= DOWN)"),
-WAIT_FOR_CLUSTER(" - Wait for cluster to be ready (errorcode 0 = UP, 
non-zero = UNKNOWN)\")"),
-SHUTDOWN_CLUSTER(" - Instructs the cluster to shut down"),;
+GET_CLUSTER_STATE("Get state of cluster (errorcode 0 = UP, non-zero = 
DOWN)"),
+WAIT_FOR_CLUSTER("Wait for cluster to be ready (errorcode 0 = UP, 
non-zero = UNKNOWN)"),
+SHUTDOWN_CLUSTER("Instructs the cluster to shut down"),;
 
 private final String usage;
 private static final Map nameMap = new HashMap<>();
diff --git 
a/asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/commands/RemoteCommand.java
 
b/asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/commands/RemoteCommand.java
index 1440b70..77ccbb4 100644
--- 
a/asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/commands/RemoteCommand.java
+++ 

Change in asterixdb[master]: Extensibility, Cleanup For Client Helper

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: Extensibility, Cleanup For Client Helper
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1133
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa24e952c1b49d7d3a5b971906915ae1560086c8
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Extensibility, Cleanup For Client Helper

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Extensibility, Cleanup For Client Helper
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/527/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1133
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa24e952c1b49d7d3a5b971906915ae1560086c8
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1581: fix subquery decorrelation.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1581: fix subquery decorrelation.
..


Patch Set 7: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/526/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1125
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2fa4b5b836eafee1975bd1164ae7c22199a4af0
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

[jira] [Resolved] (ASTERIXDB-1575) TwitterParser doesn't support non-ascii strings.

[Xikui Wang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ASTERIXDB-1575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Xikui Wang resolved ASTERIXDB-1575.
---
Resolution: Fixed

> TwitterParser doesn't support non-ascii strings.
> 
>
> Key: ASTERIXDB-1575
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1575
> Project: Apache AsterixDB
>  Issue Type: Bug
>Reporter: Wail Alkowaileet
>Assignee: Xikui Wang
>
> Hi,
> When I tried to run the TwitterFeed to collect Arabic tweets, I got malformed 
> strings. 
> it seems that JObjectUtil.getNormalizedString() discard all Arabic letters in 
> UTF-8.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Change in asterixdb[master]: Extensibility, Cleanup For Client Helper

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Extensibility, Cleanup For Client Helper
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2478/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1133
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifa24e952c1b49d7d3a5b971906915ae1560086c8
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1238: Refactor AqlMetadataProvider

[Murtadha Hubail (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1016

to look at the new patch set (#2).

Change subject: ASTERIXDB-1238: Refactor AqlMetadataProvider
..

ASTERIXDB-1238: Refactor AqlMetadataProvider

Change-Id: If2720817c5659622e1f713653856825d612eb892
---
M 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/AqlMetadataProvider.java
A 
asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/MetadataManagerUtil.java
2 files changed, 1,146 insertions(+), 1,602 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/16/1016/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1016
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If2720817c5659622e1f713653856825d612eb892
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: abdullah alamoudi 

Change in asterixdb[master]: ASTERIXDB-1581: fix subquery decorrelation.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1581: fix subquery decorrelation.
..


Patch Set 7:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/526/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1125
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2fa4b5b836eafee1975bd1164ae7c22199a4af0
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Add Helper Client To Interface With Cluster HTTP APIs

[Michael Blow (Code Review)]

Michael Blow has submitted this change and it was merged.

Change subject: Add Helper Client To Interface With Cluster HTTP APIs
..


Add Helper Client To Interface With Cluster HTTP APIs

- updated start / stop sample cluster scripts
- align args4j versions with latest released
- removed sample scripts from asterix-server jar
- extendable

Change-Id: Ib44cc3617c4ff6e995f26c1853bc9d78a1faacd7
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1126
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: Till Westmann 
---
A asterixdb/asterix-client-helper/pom.xml
A asterixdb/asterix-client-helper/src/main/assembly/assembly.xml
A 
asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/Args.java
A 
asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/AsterixHelper.java
A 
asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/AsterixHelperExecution.java
A 
asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/commands/ClientCommand.java
A 
asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/commands/GetClusterStateCommand.java
A 
asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/commands/RemoteCommand.java
A 
asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/commands/ShutdownCommand.java
A 
asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/commands/WaitForClusterCommand.java
M asterixdb/asterix-events/pom.xml
M 
asterixdb/asterix-events/src/main/java/org/apache/asterix/event/service/AsterixEventServiceUtil.java
M asterixdb/asterix-installer/pom.xml
M asterixdb/asterix-server/pom.xml
M asterixdb/asterix-server/src/main/assembly/binary-assembly.xml
M asterixdb/asterix-server/src/main/assembly/filter.properties
D 
asterixdb/asterix-server/src/main/resources/samples/local/bin/start-sample-cluster.sh
D 
asterixdb/asterix-server/src/main/resources/samples/local/bin/stop-sample-cluster.sh
A asterixdb/asterix-server/src/main/samples/local/bin/start-sample-cluster.sh
A asterixdb/asterix-server/src/main/samples/local/bin/stop-sample-cluster.sh
R asterixdb/asterix-server/src/main/samples/local/conf/blue.conf
R asterixdb/asterix-server/src/main/samples/local/conf/cc.conf
M asterixdb/pom.xml
M hyracks-fullstack/hyracks/pom.xml
24 files changed, 843 insertions(+), 148 deletions(-)

Approvals:
  Till Westmann: Looks good to me, approved
  Jenkins: Verified; No violations found; Verified



diff --git a/asterixdb/asterix-client-helper/pom.xml 
b/asterixdb/asterix-client-helper/pom.xml
new file mode 100644
index 000..7068cf6
--- /dev/null
+++ b/asterixdb/asterix-client-helper/pom.xml
@@ -0,0 +1,88 @@
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/maven-v4_0_0.xsd;>
+  4.0.0
+  asterix-client-helper
+  
+org.apache.asterix
+apache-asterixdb
+0.8.9-SNAPSHOT
+  
+  
+
+  
+org.codehaus.mojo
+appassembler-maven-plugin
+1.3
+
+  
+${project.build.directory}/appassembler
+  
+  flat
+  lib
+  false
+  
+
+  
+unix
+  
+  asterixhelper
+  
org.apache.asterix.clienthelper.AsterixHelper
+
+  
+  
+
+
+  
+
+  assemble
+  generate-daemons
+
+  
+
+  
+  
+maven-assembly-plugin
+2.6
+
+  
+
+  true
+  src/main/assembly/assembly.xml
+
+package
+
+  single
+
+  
+
+  
+
+  
+  
+
+  args4j
+  args4j
+
+
+  javax.servlet
+  javax.servlet-api
+
+  
+
diff --git a/asterixdb/asterix-client-helper/src/main/assembly/assembly.xml 
b/asterixdb/asterix-client-helper/src/main/assembly/assembly.xml
new file mode 100644
index 000..2e4e133
--- /dev/null
+++ b/asterixdb/asterix-client-helper/src/main/assembly/assembly.xml
@@ -0,0 +1,38 @@
+
+http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.3;
+  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+  
xsi:schemaLocation="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.3
 http://maven.apache.org/xsd/assembly-1.1.3.xsd;>
+  assembly
+  
+zip
+  
+  false
+  
+
+  target/appassembler/lib
+  lib
+
+
+  target/appassembler/bin
+  bin
+  0755
+
+  
+
diff --git 

Change in asterixdb[master]: ASTERIXDB-1581: fix subquery decorrelation.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1581: fix subquery decorrelation.
..


Patch Set 7:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1125
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2fa4b5b836eafee1975bd1164ae7c22199a4af0
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1581: fix subquery decorrelation.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1581: fix subquery decorrelation.
..


Patch Set 7:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2476/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1125
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2fa4b5b836eafee1975bd1164ae7c22199a4af0
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1581: fix subquery decorrelation.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1581: fix subquery decorrelation.
..


Patch Set 6: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/525/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1125
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2fa4b5b836eafee1975bd1164ae7c22199a4af0
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1581: fix subquery decorrelation.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1581: fix subquery decorrelation.
..


Patch Set 6:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/525/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1125
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2fa4b5b836eafee1975bd1164ae7c22199a4af0
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1581: fix subquery decorrelation.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1581: fix subquery decorrelation.
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2475/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1125
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2fa4b5b836eafee1975bd1164ae7c22199a4af0
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Add Helper Client To Interface With Cluster HTTP APIs

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: Add Helper Client To Interface With Cluster HTTP APIs
..


Patch Set 11: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1126
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib44cc3617c4ff6e995f26c1853bc9d78a1faacd7
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1581: fix subquery decorrelation.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1581: fix subquery decorrelation.
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2474/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1125
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2fa4b5b836eafee1975bd1164ae7c22199a4af0
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: ASTERIXDB-1581: fix subquery decorrelation.

[Yingyi Bu (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1125

to look at the new patch set (#6).

Change subject: ASTERIXDB-1581: fix subquery decorrelation.
..

ASTERIXDB-1581: fix subquery decorrelation.

- fix concurrent modification exception;
- fix variable substitution ordering;
- fix required partitioning property for DataSourceScan;
- fix partitioning property enforcer for nested operators;
- fix recursive subplan decorrelation;
- fix CardinalityInferenceVisitor;
- add a rule to switch inner join branches;
- fix SimpleUnnestToProductRule;
- add test cases which are variants of ASTERIXDB-1581.

Change-Id: Ia2fa4b5b836eafee1975bd1164ae7c22199a4af0
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/base/RuleCollections.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/InvertedIndexAccessMethod.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineAllNtsInSubplanVisitor.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/InlineSubplanInputForNestedTupleSourceRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/subplan/SubplanFlatteningUtil.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/LangExpressionToPlanTranslator.java
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/join-singletonbranch-2.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/join-singletonbranch.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/tpcds/query-ASTERIXDB-1581-correlated.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/tpcds/query-ASTERIXDB-1581.sqlpp
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/filter-nested.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/join-singletonbranch-2.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/join-singletonbranch.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/nest_aggregate.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/tpcds/query-ASTERIXDB-1581-correlated.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/tpcds/query-ASTERIXDB-1581.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/udfs/query-ASTERIXDB-1018.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/udfs/query-ASTERIXDB-1019.plan
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/aggregate_join/aggregate_join.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/aggregate_join/aggregate_join.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/aggregate_join/aggregate_join.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/aggregate_join_external/aggregate_join_external.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/subquery/aggregate_join_external/aggregate_join_external.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-2/query-ASTERIXDB-1581-2.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-2/query-ASTERIXDB-1581-2.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-2/query-ASTERIXDB-1581-2.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-3/query-ASTERIXDB-1581-3.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-3/query-ASTERIXDB-1581-3.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-3/query-ASTERIXDB-1581-3.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-4/query-ASTERIXDB-1581-4.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-4/query-ASTERIXDB-1581-4.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-4/query-ASTERIXDB-1581-4.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-5/query-ASTERIXDB-1581-5.1.ddl.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-5/query-ASTERIXDB-1581-5.2.update.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-5/query-ASTERIXDB-1581-5.3.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/tpcds/query-ASTERIXDB-1581-6/query-ASTERIXDB-1581-6.1.ddl.sqlpp
A 

Change in asterixdb[master]: Refactor Messaging

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Refactor Messaging
..


Patch Set 9: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/524/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1128
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7c918bf504058c98ecf89f5b019503278e9aa01f
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Add Helper Client To Interface With Cluster HTTP APIs

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add Helper Client To Interface With Cluster HTTP APIs
..


Patch Set 11: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/523/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1126
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib44cc3617c4ff6e995f26c1853bc9d78a1faacd7
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Refactor Messaging

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Refactor Messaging
..


Patch Set 9:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/524/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1128
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7c918bf504058c98ecf89f5b019503278e9aa01f
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: restore extension point

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: restore extension point
..


Patch Set 1:

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/522/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1132
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I331d01c6786c45ddcef953b6ba5570205549f1e3
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: Add Helper Client To Interface With Cluster HTTP APIs

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add Helper Client To Interface With Cluster HTTP APIs
..


Patch Set 11:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/523/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1126
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib44cc3617c4ff6e995f26c1853bc9d78a1faacd7
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Refactor Messaging

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Refactor Messaging
..


Patch Set 9:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1128
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7c918bf504058c98ecf89f5b019503278e9aa01f
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

[jira] [Updated] (ASTERIXDB-1623) Certain Rewrite Rule causes NPE in LogicalPlan.toString()

[Xikui Wang (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ASTERIXDB-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Xikui Wang updated ASTERIXDB-1623:
--
Summary: Certain Rewrite Rule causes NPE in LogicalPlan.toString()  (was: 
Certain Rewritten Rule causes NPE in LogicalPlan.toString())

> Certain Rewrite Rule causes NPE in LogicalPlan.toString()
> -
>
> Key: ASTERIXDB-1623
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1623
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: Optimizer
>Reporter: Xikui Wang
>
> I met this bug when I was adding 'upsert-option' for the feed part. The 
> easiest way to reproduce this bug is to checkout my change at gerrit: 
> https://asterix-gerrit.ics.uci.edu/#/c/1068/ and execute the added test case. 
> The logical plan generated by subscribe statement is: 
> from: 
> org/apache/hyracks/algebricks/core/rewriter/base/HeuristicOptimizer.java:81
> {quote}
> sink -- |UNPARTITIONED|
>   upsert into experiments:TwitterUsers from record: %0->$$2 partitioned by 
> [%0->$$3] out: ([record-before-upsert:null])  -- |UNPARTITIONED|
> assign [$$3] <- [function-call: asterix:field-access-by-name, 
> Args:[%0->$$2, AString: {screen-name}]] -- |UNPARTITIONED|
>   project ([$$2]) -- |UNPARTITIONED|
> assign [$$2] <- [function-call: asterix:collection-to-sequence, 
> Args:[%0->$$0]] -- |UNPARTITIONED|
>   unnest $$0 <- function-call: asterix:feed-collect, Args:[AString: 
> {experiments}, AString: {UserFeed}, AString: {UserFeed}, AString: {INTAKE}, 
> AString: {TwitterUsers}, AString: {TwitterUserType}] -- |UNPARTITIONED|
> empty-tuple-source -- |UNPARTITIONED|
> {quote}
> I managed to trace down that after runOptimizationSets 
> (org.apache.hyracks.algebricks.core.rewriter.base.HeuristicOptimizer#runOptimizationSets)
>  worked on ruleList "ruleList.second.get(0) instanceof 
> PullSelectOutOfEqJoin", the plan.toString will causes NPE. 
> In normal scenario, this exception will not appear due to the log level 
> setting. However, during the integration test, this bug will be triggered by 
> org/apache/hyracks/algebricks/core/rewriter/base/HeuristicOptimizer.java:85



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Change in asterixdb[master]: Refactor Messaging

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Refactor Messaging
..


Patch Set 9:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2473/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1128
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7c918bf504058c98ecf89f5b019503278e9aa01f
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: restore extension point

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: restore extension point
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/522/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1132
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I331d01c6786c45ddcef953b6ba5570205549f1e3
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

[jira] [Created] (ASTERIXDB-1623) Certain Rewritten Rule causes NPE in LogicalPlan.toString()

[Xikui Wang (JIRA)]

Xikui Wang created ASTERIXDB-1623:
-

 Summary: Certain Rewritten Rule causes NPE in 
LogicalPlan.toString()
 Key: ASTERIXDB-1623
 URL: https://issues.apache.org/jira/browse/ASTERIXDB-1623
 Project: Apache AsterixDB
  Issue Type: Bug
  Components: Optimizer
Reporter: Xikui Wang


I met this bug when I was adding 'upsert-option' for the feed part. The easiest 
way to reproduce this bug is to checkout my change at gerrit: 
https://asterix-gerrit.ics.uci.edu/#/c/1068/ and execute the added test case. 

The logical plan generated by subscribe statement is: 
from: 
org/apache/hyracks/algebricks/core/rewriter/base/HeuristicOptimizer.java:81
{quote}
sink -- |UNPARTITIONED|
  upsert into experiments:TwitterUsers from record: %0->$$2 partitioned by 
[%0->$$3] out: ([record-before-upsert:null])  -- |UNPARTITIONED|
assign [$$3] <- [function-call: asterix:field-access-by-name, 
Args:[%0->$$2, AString: {screen-name}]] -- |UNPARTITIONED|
  project ([$$2]) -- |UNPARTITIONED|
assign [$$2] <- [function-call: asterix:collection-to-sequence, 
Args:[%0->$$0]] -- |UNPARTITIONED|
  unnest $$0 <- function-call: asterix:feed-collect, Args:[AString: 
{experiments}, AString: {UserFeed}, AString: {UserFeed}, AString: {INTAKE}, 
AString: {TwitterUsers}, AString: {TwitterUserType}] -- |UNPARTITIONED|
empty-tuple-source -- |UNPARTITIONED|
{quote}

I managed to trace down after runOptimizationSets 
(org.apache.hyracks.algebricks.core.rewriter.base.HeuristicOptimizer#runOptimizationSets)
 worked on ruleList "ruleList.second.get(0) instanceof PullSelectOutOfEqJoin". 
The plan.toString will causes NPE. 

In normal scenario, this exception will not appear due to the log level 
setting. However, during the integration test, this bug will be triggered by 
org/apache/hyracks/algebricks/core/rewriter/base/HeuristicOptimizer.java:85



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Change in asterixdb[master]: ASTERIXDB-1581: fix subquery decorrelation.

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: ASTERIXDB-1581: fix subquery decorrelation.
..


Patch Set 5: Integration-Tests-1

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/520/ : 
UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1125
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2fa4b5b836eafee1975bd1164ae7c22199a4af0
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Add Helper Client To Interface With Cluster HTTP APIs

[Michael Blow (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1126

to look at the new patch set (#11).

Change subject: Add Helper Client To Interface With Cluster HTTP APIs
..

Add Helper Client To Interface With Cluster HTTP APIs

- updated start / stop sample cluster scripts
- align args4j versions with latest released
- removed sample scripts from asterix-server jar
- extendable

Change-Id: Ib44cc3617c4ff6e995f26c1853bc9d78a1faacd7
---
A asterixdb/asterix-client-helper/pom.xml
A asterixdb/asterix-client-helper/src/main/assembly/assembly.xml
A 
asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/Args.java
A 
asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/AsterixHelper.java
A 
asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/AsterixHelperExecution.java
A 
asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/commands/ClientCommand.java
A 
asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/commands/GetClusterStateCommand.java
A 
asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/commands/RemoteCommand.java
A 
asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/commands/ShutdownCommand.java
A 
asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/commands/WaitForClusterCommand.java
M asterixdb/asterix-events/pom.xml
M 
asterixdb/asterix-events/src/main/java/org/apache/asterix/event/service/AsterixEventServiceUtil.java
M asterixdb/asterix-installer/pom.xml
M asterixdb/asterix-server/pom.xml
M asterixdb/asterix-server/src/main/assembly/binary-assembly.xml
M asterixdb/asterix-server/src/main/assembly/filter.properties
D 
asterixdb/asterix-server/src/main/resources/samples/local/bin/start-sample-cluster.sh
D 
asterixdb/asterix-server/src/main/resources/samples/local/bin/stop-sample-cluster.sh
A asterixdb/asterix-server/src/main/samples/local/bin/start-sample-cluster.sh
A asterixdb/asterix-server/src/main/samples/local/bin/stop-sample-cluster.sh
R asterixdb/asterix-server/src/main/samples/local/conf/blue.conf
R asterixdb/asterix-server/src/main/samples/local/conf/cc.conf
M asterixdb/pom.xml
M hyracks-fullstack/hyracks/pom.xml
24 files changed, 843 insertions(+), 148 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/26/1126/11
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1126
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib44cc3617c4ff6e995f26c1853bc9d78a1faacd7
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 

[jira] [Commented] (ASTERIXDB-1616) NPE when printing record inside open type with unicode fields

[Ian Maxon (JIRA)]

[ 
https://issues.apache.org/jira/browse/ASTERIXDB-1616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15451380#comment-15451380
 ] 

Ian Maxon commented on ASTERIXDB-1616:
--

I did also notice that the size looked more reasonable if I shifted up one byte 
on the size. I wasn't really sure if that was a coincidence or what though. 
1334 and this do bear a striking resemblance now that I look at it closely, 
even down to the coincidence that the tweet that seems to have an error uses 
Arabic script as well. I remember last week swearing I saw this issue before, 
but I couldn't find the JIRA...
Are you also working on this actively? If so we should probably decide who 
should be assigned, because it seems odd for both of us to work on the same 
thing simultaneously.  I was looking at this bug because it's blocking some of 
the SDSC guys' queries (hence the urls in the description). 

> NPE when printing record inside open type with unicode fields
> -
>
> Key: ASTERIXDB-1616
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1616
> Project: Apache AsterixDB
>  Issue Type: Bug
>Reporter: Ian Maxon
>Assignee: Ian Maxon
>
> DDL: 
> https://github.com/kevincoakley/asterixdb_tests/blob/master/notebooks/asterixdb-spark/Count%20one_percent%20Tweets%20Spark%20Single.ipynb
> Data: 
> https://object.cloud.sdsc.edu/v1/AUTH_kcoakley/asterixdblogs/2015_11_07_00_onepercent.txt
> Basically just a scan+limit on the one_percent dataset will give 
> IndexOutOfBounds. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Change in asterixdb[master]: Add Helper Client To Interface With Cluster HTTP APIs

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add Helper Client To Interface With Cluster HTTP APIs
..


Patch Set 10:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/521/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1126
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib44cc3617c4ff6e995f26c1853bc9d78a1faacd7
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: restore extension point

[Michael Blow (Code Review)]

Michael Blow has posted comments on this change.

Change subject: restore extension point
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1132
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I331d01c6786c45ddcef953b6ba5570205549f1e3
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: restore extension point

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: restore extension point
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2471/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1132
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I331d01c6786c45ddcef953b6ba5570205549f1e3
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Add Helper Client To Interface With Cluster HTTP APIs

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add Helper Client To Interface With Cluster HTTP APIs
..


Patch Set 10:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1126
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib44cc3617c4ff6e995f26c1853bc9d78a1faacd7
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Add Helper Client To Interface With Cluster HTTP APIs

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Add Helper Client To Interface With Cluster HTTP APIs
..


Patch Set 10:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2470/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1126
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib44cc3617c4ff6e995f26c1853bc9d78a1faacd7
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Add Helper Client To Interface With Cluster HTTP APIs

[Michael Blow (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1126

to look at the new patch set (#10).

Change subject: Add Helper Client To Interface With Cluster HTTP APIs
..

Add Helper Client To Interface With Cluster HTTP APIs

- updated start / stop sample cluster scripts
- align args4j versions with latest released
- removed sample scripts from asterix-server jar
- extendable

Change-Id: Ib44cc3617c4ff6e995f26c1853bc9d78a1faacd7
---
A asterixdb/asterix-client-helper/pom.xml
A asterixdb/asterix-client-helper/src/main/assembly/assembly.xml
A 
asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/Args.java
A 
asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/AsterixHelper.java
A 
asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/AsterixHelperExecution.java
A 
asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/commands/ClientCommand.java
A 
asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/commands/GetClusterStateCommand.java
A 
asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/commands/RemoteCommand.java
A 
asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/commands/ShutdownCommand.java
A 
asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/commands/WaitForClusterCommand.java
M asterixdb/asterix-events/pom.xml
M 
asterixdb/asterix-events/src/main/java/org/apache/asterix/event/service/AsterixEventServiceUtil.java
M asterixdb/asterix-installer/pom.xml
M asterixdb/asterix-server/pom.xml
M asterixdb/asterix-server/src/main/assembly/binary-assembly.xml
M asterixdb/asterix-server/src/main/assembly/filter.properties
D 
asterixdb/asterix-server/src/main/resources/samples/local/bin/start-sample-cluster.sh
D 
asterixdb/asterix-server/src/main/resources/samples/local/bin/stop-sample-cluster.sh
A asterixdb/asterix-server/src/main/samples/local/bin/start-sample-cluster.sh
A asterixdb/asterix-server/src/main/samples/local/bin/stop-sample-cluster.sh
R asterixdb/asterix-server/src/main/samples/local/conf/blue.conf
R asterixdb/asterix-server/src/main/samples/local/conf/cc.conf
M asterixdb/pom.xml
M hyracks-fullstack/hyracks/pom.xml
24 files changed, 843 insertions(+), 148 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/26/1126/10
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1126
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib44cc3617c4ff6e995f26c1853bc9d78a1faacd7
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: Add Helper Client To Interface With Cluster HTTP APIs

[Michael Blow (Code Review)]

Michael Blow has posted comments on this change.

Change subject: Add Helper Client To Interface With Cluster HTTP APIs
..


Patch Set 9:

(4 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1126/9/asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/commands/ClientCommand.java
File 
asterixdb/asterix-client-helper/src/main/java/org/apache/asterix/clienthelper/commands/ClientCommand.java:

Line 95: public abstract int execute();
> Should we have this one throw an IOException and save some exception wrappi
Done


https://asterix-gerrit.ics.uci.edu/#/c/1126/9/asterixdb/asterix-server/src/main/samples/local/bin/start-sample-cluster.sh
File 
asterixdb/asterix-server/src/main/samples/local/bin/start-sample-cluster.sh:

Line 19: #   reserved.
> s/2006/2016/ ? Or remove the copyright and put the "normal" header?
Done- I wonder where I copied these these from...


https://asterix-gerrit.ics.uci.edu/#/c/1126/9/asterixdb/asterix-server/src/main/samples/local/bin/stop-sample-cluster.sh
File asterixdb/asterix-server/src/main/samples/local/bin/stop-sample-cluster.sh:

Line 19: #   reserved.
> s/2006/2016/ ? Or remove the copyright and put the "normal" header?
Done


Line 49:   echo  " wait for CCDriver to terminate if running."
> only one space between echo and "
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1126
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib44cc3617c4ff6e995f26c1853bc9d78a1faacd7
Gerrit-PatchSet: 9
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes