Change in asterixdb[master]: [ASTERIXDB-1952][TX][IDX]Filter logs pt.2

[Anon. E. Moose (Code Review)]

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-1952][TX][IDX]Filter logs pt.2
..


Patch Set 11: Contrib-1

Analytics Compatibility Tests Failed
: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1857
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9e7795d9c8c212e8610dcb9bb5d26ec9fbbee8a
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ian Maxon 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Jianfeng Jia 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-HasComments: No

[jira] [Created] (ASTERIXDB-2018) Http requests hang forever if client closed connection

[Murtadha Hubail (JIRA)]

Murtadha Hubail created ASTERIXDB-2018:
--

 Summary: Http requests hang forever if client closed connection
 Key: ASTERIXDB-2018
 URL: https://issues.apache.org/jira/browse/ASTERIXDB-2018
 Project: Apache AsterixDB
  Issue Type: Bug
  Components: NET - Network
Reporter: Murtadha Hubail
Assignee: Murtadha Hubail


If a client closes the HTTP request before the response is sent, the request 
thread hangs forever in ChunkedNettyOutputStream.ensureWritable



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Change in asterixdb[master]: [ASTERIXDB-2015][IDX] Introduce Secondary Primary Index

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2015][IDX] Introduce Secondary Primary Index
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3591/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1916
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59725425ba7c5fe438507dc900f83eaab239d296
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Set Default Number of Reattempts to 0

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Set Default Number of Reattempts to 0
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-rebalance-cancellation/326/
 (11/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1914
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I922611fca234a77aca0947f4571c4ffad008273a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2015][IDX] Introduce Secondary Primary Index

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2015][IDX] Introduce Secondary Primary Index
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/508/ (3/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1916
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59725425ba7c5fe438507dc900f83eaab239d296
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2015][IDX] Introduce Secondary Primary Index

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2015][IDX] Introduce Secondary Primary Index
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/847/ 
(4/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1916
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59725425ba7c5fe438507dc900f83eaab239d296
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2015][IDX] Introduce Secondary Primary Index

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2015][IDX] Introduce Secondary Primary Index
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/513/ 
(2/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1916
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59725425ba7c5fe438507dc900f83eaab239d296
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2015][IDX] Introduce Secondary Primary Index

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2015][IDX] Introduce Secondary Primary Index
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6070/ (1/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1916
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59725425ba7c5fe438507dc900f83eaab239d296
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Set Default Number of Reattempts to 0

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Set Default Number of Reattempts to 0
..


Patch Set 1:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1576/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1914
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I922611fca234a77aca0947f4571c4ffad008273a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Set Default Number of Reattempts to 0

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Set Default Number of Reattempts to 0
..


Patch Set 1: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1576/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1914
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I922611fca234a77aca0947f4571c4ffad008273a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Set Default Number of Reattempts to 0

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: Set Default Number of Reattempts to 0
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/1412/ (11/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1914
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I922611fca234a77aca0947f4571c4ffad008273a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2015][IDX] Introduce Secondary Primary Index

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2015][IDX] Introduce Secondary Primary Index
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/505/
 (11/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1916
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59725425ba7c5fe438507dc900f83eaab239d296
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2015][IDX] Introduce Secondary Primary Index

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2015][IDX] Introduce Secondary Primary Index
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-rebalance-cancellation/327/
 (8/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1916
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59725425ba7c5fe438507dc900f83eaab239d296
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2015][IDX] Introduce Secondary Primary Index

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2015][IDX] Introduce Secondary Primary Index
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1240/ 
(6/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1916
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59725425ba7c5fe438507dc900f83eaab239d296
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2015][IDX] Introduce Secondary Primary Index

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2015][IDX] Introduce Secondary Primary Index
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1126/ (5/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1916
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59725425ba7c5fe438507dc900f83eaab239d296
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2015][IDX] Introduce Secondary Primary Index

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2015][IDX] Introduce Secondary Primary Index
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3591/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1916
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59725425ba7c5fe438507dc900f83eaab239d296
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2015][IDX] Introduce Secondary Primary Index

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2015][IDX] Introduce Secondary Primary Index
..


Patch Set 1:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1916
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59725425ba7c5fe438507dc900f83eaab239d296
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2015][IDX] Introduce Secondary Primary Index

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2015][IDX] Introduce Secondary Primary Index
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/4589/ (7/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1916
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59725425ba7c5fe438507dc900f83eaab239d296
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2015][IDX] Introduce Secondary Primary Index

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2015][IDX] Introduce Secondary Primary Index
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1192/
 (10/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1916
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59725425ba7c5fe438507dc900f83eaab239d296
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2015][IDX] Introduce Secondary Primary Index

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2015][IDX] Introduce Secondary Primary Index
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/1413/ (9/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1916
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I59725425ba7c5fe438507dc900f83eaab239d296
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ali Alsuliman 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

[jira] [Created] (ASTERIXDB-2020) Set default max number of reattempts to 0 in JobSpecification

[Abdullah Alamoudi (JIRA)]

Abdullah Alamoudi created ASTERIXDB-2020:


 Summary: Set default max number of reattempts to 0 in 
JobSpecification
 Key: ASTERIXDB-2020
 URL: https://issues.apache.org/jira/browse/ASTERIXDB-2020
 Project: Apache AsterixDB
  Issue Type: Bug
  Components: HYR - Hyracks
Reporter: Abdullah Alamoudi
Assignee: Abdullah Alamoudi


In Hyracks JobSpecification, the default max number of reattempts is set to 2. 
This forces anyone who creates a job that shouldn't be re-attempted to 
explicitly set the number to 0 and we have many calls that sets it to 0.

However, sometimes, developers forget to set that and this leads to serious 
failures...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Change in asterixdb[master]: [ASTERIXDB-2018][NET] Add HTTP close channel listener

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2018][NET] Add HTTP close channel listener
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-rebalance-cancellation/331/
 (3/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1917
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08e4890880a70d42e3e181366a5b0252102d0ea2
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2018][NET] Add HTTP close channel listener

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2018][NET] Add HTTP close channel listener
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/851/ 
(7/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1917
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08e4890880a70d42e3e181366a5b0252102d0ea2
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2018][NET] Add HTTP close channel listener

[abdullah alamoudi (Code Review)]

abdullah alamoudi has posted comments on this change.

Change subject: [ASTERIXDB-2018][NET] Add HTTP close channel listener
..


Patch Set 1:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1917/1/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/ChunkedNettyOutputStream.java
File 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/ChunkedNettyOutputStream.java:

PS1, Line 85: flush();
: buffer.release();
if flush() throws an IOException, then buffer is leaked.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1917
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08e4890880a70d42e3e181366a5b0252102d0ea2
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [ASTERIXDB-2018][NET] Add HTTP close channel listener

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2018][NET] Add HTTP close channel listener
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/517/ 
(4/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1917
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08e4890880a70d42e3e181366a5b0252102d0ea2
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2018][NET] Add HTTP close channel listener

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2018][NET] Add HTTP close channel listener
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6074/ (1/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1917
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08e4890880a70d42e3e181366a5b0252102d0ea2
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2018][NET] Add HTTP close channel listener

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2018][NET] Add HTTP close channel listener
..


Patch Set 2:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3595/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1917
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08e4890880a70d42e3e181366a5b0252102d0ea2
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2018][NET] Add HTTP close channel listener

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2018][NET] Add HTTP close channel listener
..


Patch Set 2:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1580/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1917
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08e4890880a70d42e3e181366a5b0252102d0ea2
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [WIP][ASTERIXDB-1984][COMP] probe-subtree init not required

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: [WIP][ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 10:

(51 comments)

1. Can you add other two queries listed in the issue ASTERIXDB-1984 into the 
tests?

2. Can you leave tests under nested-open-index as they are now, instead of 
changing them to closed fields which are covered elsewhere.  Instead, making 
them negative tests and check that hash join is used.

https://asterix-gerrit.ics.uci.edu/#/c/1880/10/asterixdb/asterix-app/src/test/resources/optimizerts/queries/meta/secondary_index-nljoin_with_meta-1.aql
File 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/meta/secondary_index-nljoin_with_meta-1.aql:

PS10, Line 40: $x.clineid 
Can you let the test as it is and change the resulting plan?

We want to prevent index join in that case.


https://asterix-gerrit.ics.uci.edu/#/c/1880/10/asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/leftouterjoin-probe-pidx-with-join-btree-sidx_01_2.aql
File 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/leftouterjoin-probe-pidx-with-join-btree-sidx_01_2.aql:

PS10, Line 47: countA: int32
Can you leave the test as it is and update the resulting query plan?


https://asterix-gerrit.ics.uci.edu/#/c/1880/10/asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/leftouterjoin-probe-pidx-with-join-btree-sidx_02_2.aql
File 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/leftouterjoin-probe-pidx-with-join-btree-sidx_02_2.aql:

PS10, Line 47:  countA: int32
leave the query as it is and update the resulting query plan?


https://asterix-gerrit.ics.uci.edu/#/c/1880/10/asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-join_01.aql
File 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-join_01.aql:

PS10, Line 32: cfname : string,
 : clname : string
leave the query as it is and change the resulting plan


https://asterix-gerrit.ics.uci.edu/#/c/1880/10/asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-join_02.aql
File 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-join_02.aql:

PS10, Line 32:cfname : string,
 : clname : string
leave the query as it is, and change the resulting plan?


https://asterix-gerrit.ics.uci.edu/#/c/1880/10/asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-join_03.aql
File 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-join_03.aql:

PS10, Line 32: string
leave the query as it is, and change the resulting plan?


https://asterix-gerrit.ics.uci.edu/#/c/1880/10/asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-prefix-join_01.aql
File 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-prefix-join_01.aql:

PS10, Line 33: string
leave the query as it is, and change the resulting plan?


https://asterix-gerrit.ics.uci.edu/#/c/1880/10/asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-prefix-join_02.aql
File 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-prefix-join_02.aql:

PS10, Line 33: string
leave the query as it is, and change the resulting plan?


https://asterix-gerrit.ics.uci.edu/#/c/1880/10/asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-prefix-join_04.aql
File 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-prefix-join_04.aql:

PS10, Line 33:  
leave the query as it is, and change the resulting plan?


https://asterix-gerrit.ics.uci.edu/#/c/1880/10/asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-prefix-join_05.aql
File 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-prefix-join_05.aql:

PS10, Line 33: clname
leave the query as it is, and change the resulting plan?


https://asterix-gerrit.ics.uci.edu/#/c/1880/10/asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-prefix-join_06.aql
File 

Change in asterixdb[master]: [ASTERIXDB-2018][NET] Add HTTP close channel listener

[Murtadha Hubail (Code Review)]

Murtadha Hubail has submitted this change and it was merged.

Change subject: [ASTERIXDB-2018][NET] Add HTTP close channel listener
..


[ASTERIXDB-2018][NET] Add HTTP close channel listener

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
Add a listener on HTTP channel to notify waiters when the
channel is closed.

Change-Id: I08e4890880a70d42e3e181366a5b0252102d0ea2
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1917
Reviewed-by: abdullah alamoudi 
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Contrib: Jenkins 
Integration-Tests: Jenkins 
---
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/ChunkedNettyOutputStream.java
1 file changed, 14 insertions(+), 2 deletions(-)

Approvals:
  abdullah alamoudi: Looks good to me, approved
  Jenkins: Verified; No violations found; No violations found; Verified



diff --git 
a/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/ChunkedNettyOutputStream.java
 
b/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/ChunkedNettyOutputStream.java
index 6509dcc..3456343 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/ChunkedNettyOutputStream.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/ChunkedNettyOutputStream.java
@@ -40,6 +40,12 @@
 this.response = response;
 this.ctx = ctx;
 buffer = ctx.alloc().buffer(chunkSize);
+// register listener for channel closed
+ctx.channel().closeFuture().addListener(futureListener -> {
+synchronized (ChunkedNettyOutputStream.this) {
+ChunkedNettyOutputStream.this.notifyAll();
+}
+});
 }
 
 @Override
@@ -76,8 +82,11 @@
 public void close() throws IOException {
 if (!closed) {
 if (response.isHeaderSent() || response.status() != 
HttpResponseStatus.OK) {
-flush();
-buffer.release();
+try {
+flush();
+} finally {
+buffer.release();
+}
 } else {
 response.fullReponse(buffer);
 }
@@ -121,6 +130,9 @@
 while (!ctx.channel().isWritable()) {
 try {
 ctx.flush();
+if (!ctx.channel().isOpen()) {
+throw new IOException("Closed channel");
+}
 wait();
 } catch (InterruptedException e) {
 Thread.currentThread().interrupt();

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1917
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I08e4890880a70d42e3e181366a5b0252102d0ea2
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 

Change in asterixdb[master]: Set Default Number of Reattempts to 0

[Murtadha Hubail (Code Review)]

Murtadha Hubail has posted comments on this change.

Change subject: Set Default Number of Reattempts to 0
..


Patch Set 1:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1914/1//COMMIT_MSG
Commit Message:

PS1, Line 7: Set Default Number of Reattempts to 0
Please fix commit message


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1914
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I922611fca234a77aca0947f4571c4ffad008273a
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [ASTERIXDB-2020][HYR] Set Default Number of Reattempts to 0

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2020][HYR] Set Default Number of Reattempts to 0
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/516/ 
(3/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1914
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I922611fca234a77aca0947f4571c4ffad008273a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2020][HYR] Set Default Number of Reattempts to 0

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2020][HYR] Set Default Number of Reattempts to 0
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-rebalance-cancellation/330/
 (8/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1914
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I922611fca234a77aca0947f4571c4ffad008273a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2020][HYR] Set Default Number of Reattempts to 0

[abdullah alamoudi (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1914

to look at the new patch set (#2).

Change subject: [ASTERIXDB-2020][HYR] Set Default Number of Reattempts to 0
..

[ASTERIXDB-2020][HYR] Set Default Number of Reattempts to 0

- user model changes: no
- storage format changes: no
- interface changes: no

details:
- Set Default Number of Reattempts to 0

Change-Id: I922611fca234a77aca0947f4571c4ffad008273a
---
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/JobSpecification.java
1 file changed, 40 insertions(+), 43 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/14/1914/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1914
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I922611fca234a77aca0947f4571c4ffad008273a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 

Change in asterixdb[master]: [ASTERIXDB-2020][HYR] Set Default Number of Reattempts to 0

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2020][HYR] Set Default Number of Reattempts to 0
..


Patch Set 2:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/511/ (5/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1914
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I922611fca234a77aca0947f4571c4ffad008273a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2020][HYR] Set Default Number of Reattempts to 0

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2020][HYR] Set Default Number of Reattempts to 0
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6073/ (4/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1914
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I922611fca234a77aca0947f4571c4ffad008273a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2020][HYR] Set Default Number of Reattempts to 0

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2020][HYR] Set Default Number of Reattempts to 0
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1243/ 
(6/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1914
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I922611fca234a77aca0947f4571c4ffad008273a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2020][HYR] Set Default Number of Reattempts to 0

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2020][HYR] Set Default Number of Reattempts to 0
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1129/ (1/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1914
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I922611fca234a77aca0947f4571c4ffad008273a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2020][HYR] Set Default Number of Reattempts to 0

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2020][HYR] Set Default Number of Reattempts to 0
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/4592/ (2/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1914
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I922611fca234a77aca0947f4571c4ffad008273a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2020][HYR] Set Default Number of Reattempts to 0

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2020][HYR] Set Default Number of Reattempts to 0
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/850/ 
(7/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1914
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I922611fca234a77aca0947f4571c4ffad008273a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2020][HYR] Set Default Number of Reattempts to 0

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2020][HYR] Set Default Number of Reattempts to 0
..


Patch Set 2:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3594/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1914
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I922611fca234a77aca0947f4571c4ffad008273a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [WIP][ASTERIXDB-1984][COMP] probe-subtree init not required

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: [WIP][ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 10:

(5 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1880/10/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java:

PS10, Line 117: boolean updateEntireExprInfo)
What does this parameter mean and why it is needed?


https://asterix-gerrit.ics.uci.edu/#/c/1880/10/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceJoinAccessMethodRule.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceJoinAccessMethodRule.java:

PS10, Line 323: fillSubTreeIndexExprs(leftSubTree, analyzedAMs, context, false);
Why do we need to map variables for the left sub tree?


PS10, Line 351: isNullFuncExpr
isNullFuncExpr -> isMissingFuncExpr ?


PS10, Line 400: boolean leftSubTreeInitialized = 
leftSubTree.initFromSubTree(joinOp.getInputs().get(0), false);
Still need to init the left sub tree?


https://asterix-gerrit.ics.uci.edu/#/c/1880/10/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/OptimizableOperatorSubTree.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/OptimizableOperatorSubTree.java:

PS10, Line 102:  if (!initDataSource) {
  : return true;
  : }
for left subtree, it's a no-op?   Maybe it shouldn't be called at all?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1880
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a25
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [WIP][ASTERIXDB-1984][COMP] probe-subtree init not required

[Taewoo Kim (Code Review)]

Taewoo Kim has posted comments on this change.

Change subject: [WIP][ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 10:

(4 comments)

For the test cases, I will also keep the original cases so that we will be able 
to see those test cases turn into the hash-join.

https://asterix-gerrit.ics.uci.edu/#/c/1880/10/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java:

PS10, Line 117: boolean updateEntireExprInfo)
> What does this parameter mean and why it is needed?
This parameter is needed not to fill out all information (access method type, 
variable, and indexes for the given expression) for the given optimizable 
function expression. For the probe-tree, we only need to set the field-type for 
the given expression, though.


https://asterix-gerrit.ics.uci.edu/#/c/1880/10/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceJoinAccessMethodRule.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceJoinAccessMethodRule.java:

PS10, Line 323: fillSubTreeIndexExprs(leftSubTree, analyzedAMs, context, false);
> Why do we need to map variables for the left sub tree?
This only sets the field-type for the probe-subtree.


PS10, Line 351: isNullFuncExpr
> isNullFuncExpr -> isMissingFuncExpr ?
Done


PS10, Line 400: boolean leftSubTreeInitialized = 
leftSubTree.initFromSubTree(joinOp.getInputs().get(0), false);
> Still need to init the left sub tree?
Yes. We need to at least create a new blank subtree class and set the root 
operator for that.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1880
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a25
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

[jira] [Created] (ASTERIXDB-2021) IClusterStateManager should only throw HyracksDataException

[Till (JIRA)]

Till created ASTERIXDB-2021:
---

 Summary: IClusterStateManager should only throw 
HyracksDataException
 Key: ASTERIXDB-2021
 URL: https://issues.apache.org/jira/browse/ASTERIXDB-2021
 Project: Apache AsterixDB
  Issue Type: Bug
  Components: CLUS - Cluster management
Reporter: Till
Assignee: Till


Currently it throws HyracksDataException or AsterixException.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Change in asterixdb[master]: [ASTERIXDB-2019][CLUS] Update cluster state on partitions ch...

[Murtadha Hubail (Code Review)]

Murtadha Hubail has posted comments on this change.

Change subject: [ASTERIXDB-2019][CLUS] Update cluster state on partitions 
changes
..


Patch Set 1:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1918/1/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/ClusterStateManager.java
File 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/ClusterStateManager.java:

PS1, Line 377: TODO
> Would https://issues.apache.org/jira/browse/ASTERIXDB-2021 address this TOD
Yes, but ideally I think since this is on Asterix level, it should throw 
RuntimeDataException. I tried updating the API but it required touching so many 
classes.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1918
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7d11733a1dcd86136e157d80517bff4abcfc776b
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [WIP][ASTERIXDB-1984][COMP] probe-subtree init not required

[Taewoo Kim (Code Review)]

Taewoo Kim has posted comments on this change.

Change subject: [WIP][ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 10:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1880/10/asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/inverted-index-join/ngram-edit-distance_04.aql
File 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/inverted-index-join/ngram-edit-distance_04.aql:

PS10, Line 22: nested
> update the description.
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1880
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a25
Gerrit-PatchSet: 10
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [ASTERIXDB-2020][HYR] Set Default Number of Reattempts to 0

[abdullah alamoudi (Code Review)]

abdullah alamoudi has submitted this change and it was merged.

Change subject: [ASTERIXDB-2020][HYR] Set Default Number of Reattempts to 0
..


[ASTERIXDB-2020][HYR] Set Default Number of Reattempts to 0

- user model changes: no
- storage format changes: no
- interface changes: no

details:
- Set Default Number of Reattempts to 0

Change-Id: I922611fca234a77aca0947f4571c4ffad008273a
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1914
Reviewed-by: Murtadha Hubail 
Integration-Tests: Murtadha Hubail 
Tested-by: Murtadha Hubail 
---
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/JobSpecification.java
1 file changed, 40 insertions(+), 43 deletions(-)

Approvals:
  Murtadha Hubail: Looks good to me, approved; Verified; Verified



diff --git 
a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/JobSpecification.java
 
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/JobSpecification.java
index a7d3864..2cf96c2 100644
--- 
a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/JobSpecification.java
+++ 
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/JobSpecification.java
@@ -31,6 +31,7 @@
 import org.apache.commons.lang3.tuple.Pair;
 import org.apache.hyracks.api.constraints.Constraint;
 import org.apache.hyracks.api.constraints.expressions.ConstantExpression;
+import 
org.apache.hyracks.api.constraints.expressions.ConstraintExpression.ExpressionTag;
 import org.apache.hyracks.api.constraints.expressions.PartitionCountExpression;
 import 
org.apache.hyracks.api.constraints.expressions.PartitionLocationExpression;
 import org.apache.hyracks.api.dataflow.ConnectorDescriptorId;
@@ -95,18 +96,18 @@
 }
 
 public JobSpecification(int frameSize) {
-roots = new ArrayList();
-resultSetIds = new ArrayList();
-opMap = new HashMap();
-connMap = new HashMap();
-opInputMap = new HashMap();
-opOutputMap = new HashMap();
+roots = new ArrayList<>();
+resultSetIds = new ArrayList<>();
+opMap = new HashMap<>();
+connMap = new HashMap<>();
+opInputMap = new HashMap<>();
+opOutputMap = new HashMap<>();
 connectorOpMap = new HashMap<>();
-properties = new HashMap();
-userConstraints = new HashSet();
+properties = new HashMap<>();
+userConstraints = new HashSet<>();
 operatorIdCounter = 0;
 connectorIdCounter = 0;
-maxReattempts = 2;
+maxReattempts = 0;
 useConnectorPolicyForScheduling = false;
 requiredClusterCapacity = new ClusterCapacity();
 setFrameSize(frameSize);
@@ -170,20 +171,20 @@
 }
 
 public RecordDescriptor getConnectorRecordDescriptor(IConnectorDescriptor 
conn) {
-Pair, Pair> connInfo = connectorOpMap
-.get(conn.getConnectorId());
+Pair, Pair> connInfo =
+connectorOpMap.get(conn.getConnectorId());
 return 
connInfo.getLeft().getLeft().getOutputRecordDescriptors()[connInfo.getLeft().getRight()];
 }
 
 public IOperatorDescriptor getConsumer(IConnectorDescriptor conn) {
-Pair, Pair> connInfo = connectorOpMap
-.get(conn.getConnectorId());
+Pair, Pair> connInfo =
+connectorOpMap.get(conn.getConnectorId());
 return connInfo.getRight().getLeft();
 }
 
 public int getConsumerInputIndex(IConnectorDescriptor conn) {
-Pair, Pair> connInfo = connectorOpMap
-.get(conn.getConnectorId());
+Pair, Pair> connInfo =
+connectorOpMap.get(conn.getConnectorId());
 return connInfo.getRight().getRight();
 }
 
@@ -224,14 +225,14 @@
 }
 
 public IOperatorDescriptor getProducer(IConnectorDescriptor conn) {
-Pair, Pair> connInfo = connectorOpMap
-.get(conn.getConnectorId());
+Pair, Pair> connInfo =
+connectorOpMap.get(conn.getConnectorId());
 return connInfo.getLeft().getLeft();
 }
 
 public int 

Change in asterixdb[master]: [ASTERIXDB-2019][CLUS] Update cluster state on partitions ch...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2019][CLUS] Update cluster state on partitions 
changes
..


Patch Set 1:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1579/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1918
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7d11733a1dcd86136e157d80517bff4abcfc776b
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2020][HYR] Set Default Number of Reattempts to 0

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2020][HYR] Set Default Number of Reattempts to 0
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/508/
 (11/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1914
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I922611fca234a77aca0947f4571c4ffad008273a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2018][NET] Add HTTP close channel listener

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2018][NET] Add HTTP close channel listener
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/4593/ (2/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1917
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08e4890880a70d42e3e181366a5b0252102d0ea2
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2018][NET] Add HTTP close channel listener

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2018][NET] Add HTTP close channel listener
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/1417/ (9/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1917
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08e4890880a70d42e3e181366a5b0252102d0ea2
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2018][NET] Add HTTP close channel listener

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2018][NET] Add HTTP close channel listener
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1130/ (8/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1917
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08e4890880a70d42e3e181366a5b0252102d0ea2
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2018][NET] Add HTTP close channel listener

[abdullah alamoudi (Code Review)]

abdullah alamoudi has posted comments on this change.

Change subject: [ASTERIXDB-2018][NET] Add HTTP close channel listener
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1917
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08e4890880a70d42e3e181366a5b0252102d0ea2
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2018][NET] Add HTTP close channel listener

[Murtadha Hubail (Code Review)]

Murtadha Hubail has posted comments on this change.

Change subject: [ASTERIXDB-2018][NET] Add HTTP close channel listener
..


Patch Set 1:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1917/1/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/ChunkedNettyOutputStream.java
File 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/ChunkedNettyOutputStream.java:

PS1, Line 85: flush();
: buffer.release();
> if flush() throws an IOException, then buffer is leaked.
done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1917
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08e4890880a70d42e3e181366a5b0252102d0ea2
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [ASTERIXDB-2018][NET] Add HTTP close channel listener

[Murtadha Hubail (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1917

to look at the new patch set (#2).

Change subject: [ASTERIXDB-2018][NET] Add HTTP close channel listener
..

[ASTERIXDB-2018][NET] Add HTTP close channel listener

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
Add a listener on HTTP channel to notify waiters when the
channel is closed.

Change-Id: I08e4890880a70d42e3e181366a5b0252102d0ea2
---
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/ChunkedNettyOutputStream.java
1 file changed, 14 insertions(+), 2 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/17/1917/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1917
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I08e4890880a70d42e3e181366a5b0252102d0ea2
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 

Change in asterixdb[master]: [ASTERIXDB-2018][NET] Add HTTP close channel listener

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2018][NET] Add HTTP close channel listener
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1244/ 
(6/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1917
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08e4890880a70d42e3e181366a5b0252102d0ea2
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2018][NET] Add HTTP close channel listener

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2018][NET] Add HTTP close channel listener
..


Patch Set 2:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/512/ (5/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1917
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08e4890880a70d42e3e181366a5b0252102d0ea2
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2020][HYR] Set Default Number of Reattempts to 0

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2020][HYR] Set Default Number of Reattempts to 0
..


Patch Set 2:

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3594/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1914
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I922611fca234a77aca0947f4571c4ffad008273a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2020][HYR] Set Default Number of Reattempts to 0

[Murtadha Hubail (Code Review)]

Murtadha Hubail has posted comments on this change.

Change subject: [ASTERIXDB-2020][HYR] Set Default Number of Reattempts to 0
..


Patch Set 2: Code-Review+2 Integration-Tests+1 Verified+1

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1914
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I922611fca234a77aca0947f4571c4ffad008273a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2020][HYR] Set Default Number of Reattempts to 0

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2020][HYR] Set Default Number of Reattempts to 0
..


Patch Set 2:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1578/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1914
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I922611fca234a77aca0947f4571c4ffad008273a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2020][HYR] Set Default Number of Reattempts to 0

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2020][HYR] Set Default Number of Reattempts to 0
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1195/
 (10/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1914
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I922611fca234a77aca0947f4571c4ffad008273a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2020][HYR] Set Default Number of Reattempts to 0

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2020][HYR] Set Default Number of Reattempts to 0
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/1416/ (9/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1914
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I922611fca234a77aca0947f4571c4ffad008273a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2019][CLUS] Update cluster state on partitions ch...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2019][CLUS] Update cluster state on partitions 
changes
..


Patch Set 1: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1579/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1918
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7d11733a1dcd86136e157d80517bff4abcfc776b
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2018][NET] Add HTTP close channel listener

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2018][NET] Add HTTP close channel listener
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/509/
 (11/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1917
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08e4890880a70d42e3e181366a5b0252102d0ea2
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2018][NET] Add HTTP close channel listener

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2018][NET] Add HTTP close channel listener
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1196/
 (10/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1917
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08e4890880a70d42e3e181366a5b0252102d0ea2
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2018][NET] Add HTTP close channel listener

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2018][NET] Add HTTP close channel listener
..


Patch Set 2: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1580/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1917
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08e4890880a70d42e3e181366a5b0252102d0ea2
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2018][NET] Add HTTP close channel listener

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2018][NET] Add HTTP close channel listener
..


Patch Set 2: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3595/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1917
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I08e4890880a70d42e3e181366a5b0252102d0ea2
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No

Change in asterixdb[master]: [TEST] Add performance test for AsterixDB

[Yingyi Bu (Code Review)]

Yingyi Bu has posted comments on this change.

Change subject: [TEST] Add performance test for AsterixDB
..


Patch Set 35:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/1879/35/asterixdb/asterix-benchmark/src/main/resources/conf/benchmark_setting.yml
File asterixdb/asterix-benchmark/src/main/resources/conf/benchmark_setting.yml:

PS35, Line 21: 0.5
should 1.0 be the default?


https://asterix-gerrit.ics.uci.edu/#/c/1879/35/asterixdb/asterix-benchmark/src/main/resources/others/SparkSQL/ansible/create_aws_cluster.yml
File 
asterixdb/asterix-benchmark/src/main/resources/others/SparkSQL/ansible/create_aws_cluster.yml:

PS35, Line 26: spark_test
spark_test --> spark_{{ lookup('env','USER') }} ?

So that different users can run the tests at same time?


https://asterix-gerrit.ics.uci.edu/#/c/1879/35/asterixdb/asterix-benchmark/src/main/resources/others/SparkSQL/ansible/spark_sql_settings.yml
File 
asterixdb/asterix-benchmark/src/main/resources/others/SparkSQL/ansible/spark_sql_settings.yml:

PS35, Line 48: tpch_scale: 0.5
Should this be generated from another config file?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1879
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9ff8efa0be71bde67190ba6f9fbd647c7799084
Gerrit-PatchSet: 35
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [ASTERIXDB-2019][CLUS] Update cluster state on partitions ch...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2019][CLUS] Update cluster state on partitions 
changes
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3593/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1918
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7d11733a1dcd86136e157d80517bff4abcfc776b
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: Fix: Cursor can release entity lock twice in case of reconcile

[abdullah alamoudi (Code Review)]

abdullah alamoudi has abandoned this change.

Change subject: Fix: Cursor can release entity lock twice in case of reconcile
..


Abandoned

fixed in a different change

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1804
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ia7f831147f6df6a712e592e029a28a1e9b8ef5a5
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-Reviewer: abdullah alamoudi 

Change in asterixdb[master]: [ASTERIXDB-2019][CLUS] Update cluster state on partitions ch...

[Till Westmann (Code Review)]

Till Westmann has posted comments on this change.

Change subject: [ASTERIXDB-2019][CLUS] Update cluster state on partitions 
changes
..


Patch Set 1:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/1918/1/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/ClusterStateManager.java
File 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/ClusterStateManager.java:

PS1, Line 377: TODO
Would https://issues.apache.org/jira/browse/ASTERIXDB-2021 address this TODO? 
Or is its something else?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1918
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7d11733a1dcd86136e157d80517bff4abcfc776b
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [WIP][ASTERIXDB-1984][COMP] probe-subtree init not required

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [WIP][ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 11:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6077/ (6/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1880
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a25
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: [WIP][ASTERIXDB-1984][COMP] probe-subtree init not required

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [WIP][ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 11:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/4596/ (8/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1880
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a25
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: [WIP][ASTERIXDB-1984][COMP] probe-subtree init not required

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [WIP][ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 11:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/512/
 (11/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1880
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a25
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: [WIP][ASTERIXDB-1984][COMP] probe-subtree init not required

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [WIP][ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 11:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1247/ 
(4/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1880
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a25
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: [WIP][ASTERIXDB-1984][COMP] probe-subtree init not required

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [WIP][ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 11:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-rebalance-cancellation/334/
 (2/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1880
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a25
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: [WIP][ASTERIXDB-1984][COMP] probe-subtree init not required

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [WIP][ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 11:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/1420/ (9/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1880
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a25
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: [WIP][ASTERIXDB-1984][COMP] probe-subtree init not required

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [WIP][ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 11:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1133/ (1/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1880
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a25
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: [WIP][ASTERIXDB-1984][COMP] probe-subtree init not required

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [WIP][ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 11:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1199/
 (10/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1880
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a25
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2013][HYR] non-POST x-www-form-urlencoded, config...

[Anon. E. Moose (Code Review)]

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2013][HYR] non-POST x-www-form-urlencoded, config 
null value handling
..


Patch Set 7: Contrib-1

Analytics Compatibility Tests Failed
: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1911
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I670b815a5276d870f7d538d1ce9d8bef2d0fcf4f
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2013][HYR] non-POST x-www-form-urlencoded, config...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2013][HYR] non-POST x-www-form-urlencoded, config 
null value handling
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/1418/ (9/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1911
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I670b815a5276d870f7d538d1ce9d8bef2d0fcf4f
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2013][HYR] non-POST x-www-form-urlencoded, config...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2013][HYR] non-POST x-www-form-urlencoded, config 
null value handling
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-rebalance-cancellation/332/
 (2/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1911
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I670b815a5276d870f7d538d1ce9d8bef2d0fcf4f
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2013][HYR] non-POST x-www-form-urlencoded, config...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2013][HYR] non-POST x-www-form-urlencoded, config 
null value handling
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/4594/ (3/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1911
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I670b815a5276d870f7d538d1ce9d8bef2d0fcf4f
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2013][HYR] non-POST x-www-form-urlencoded, config...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2013][HYR] non-POST x-www-form-urlencoded, config 
null value handling
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6075/ (1/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1911
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I670b815a5276d870f7d538d1ce9d8bef2d0fcf4f
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2013][HYR] non-POST x-www-form-urlencoded, config...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2013][HYR] non-POST x-www-form-urlencoded, config 
null value handling
..


Patch Set 6:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1911
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I670b815a5276d870f7d538d1ce9d8bef2d0fcf4f
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2013][HYR] non-POST x-www-form-urlencoded, config...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2013][HYR] non-POST x-www-form-urlencoded, config 
null value handling
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1197/
 (10/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1911
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I670b815a5276d870f7d538d1ce9d8bef2d0fcf4f
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2013][HYR] non-POST x-www-form-urlencoded, config...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2013][HYR] non-POST x-www-form-urlencoded, config 
null value handling
..


Patch Set 6:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/852/ 
(8/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1911
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I670b815a5276d870f7d538d1ce9d8bef2d0fcf4f
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2013][HYR] non-POST x-www-form-urlencoded, config...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2013][HYR] non-POST x-www-form-urlencoded, config 
null value handling
..


Patch Set 6:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3596/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1911
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I670b815a5276d870f7d538d1ce9d8bef2d0fcf4f
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2019][CLUS] Update cluster state on partitions ch...

[Murtadha Hubail (Code Review)]

Murtadha Hubail has submitted this change and it was merged.

Change subject: [ASTERIXDB-2019][CLUS] Update cluster state on partitions 
changes
..


[ASTERIXDB-2019][CLUS] Update cluster state on partitions changes

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Set the cluster to UNUSABLE when no partitions are registered
- Update cluster state after partitions register/de-register
- Reject unregistered nodes queries on CC
- Avoid NPE when trying to send to a node that was de-registered

Change-Id: I7d11733a1dcd86136e157d80517bff4abcfc776b
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1918
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Contrib: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: Michael Blow 
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ExecuteStatementRequestMessage.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/messaging/CCMessageBroker.java
M 
asterixdb/asterix-common/src/main/java/org/apache/asterix/common/cluster/IClusterStateManager.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/ClusterStateManager.java
4 files changed, 57 insertions(+), 10 deletions(-)

Approvals:
  Michael Blow: Looks good to me, approved
  Jenkins: Verified; No violations found; No violations found; Verified



diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ExecuteStatementRequestMessage.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ExecuteStatementRequestMessage.java
index fc0c1ff..9faa9e9 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ExecuteStatementRequestMessage.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/message/ExecuteStatementRequestMessage.java
@@ -92,6 +92,11 @@
 ClusterControllerService ccSrv = (ClusterControllerService) 
ccSrvContext.getControllerService();
 CCApplication ccApp = (CCApplication) ccSrv.getApplication();
 CCMessageBroker messageBroker = (CCMessageBroker) 
ccSrvContext.getMessageBroker();
+final String rejectionReason = getRejectionReason(ccSrv);
+if (rejectionReason != null) {
+sendRejection(rejectionReason, messageBroker);
+return;
+}
 CCExtensionManager ccExtMgr = (CCExtensionManager) 
ccAppCtx.getExtensionManager();
 ILangCompilationProvider compilationProvider = 
ccExtMgr.getCompilationProvider(lang);
 IStorageComponentProvider storageComponentProvider = 
ccAppCtx.getStorageComponentProvider();
@@ -100,16 +105,9 @@
 
 ccSrv.getExecutor().submit(() -> {
 ExecuteStatementResponseMessage responseMsg = new 
ExecuteStatementResponseMessage(requestMessageId);
-
 try {
-final IClusterManagementWork.ClusterState clusterState = 
ClusterStateManager.INSTANCE.getState();
-if (clusterState != 
IClusterManagementWork.ClusterState.ACTIVE) {
-throw new IllegalStateException("Cannot execute request, 
cluster is " + clusterState);
-}
-
 IParser parser = 
compilationProvider.getParserFactory().createParser(statementsText);
 List statements = parser.parse();
-
 StringWriter outWriter = new StringWriter(256);
 PrintWriter outPrinter = new PrintWriter(outWriter);
 SessionOutput.ResultDecorator resultPrefix = 
ResultUtil.createPreResultDecorator();
@@ -148,6 +146,27 @@
 });
 }
 
+private String getRejectionReason(ClusterControllerService ccSrv) {
+if (ccSrv.getNodeManager().getNodeControllerState(requestNodeId) == 
null) {
+return "Node is not registerted with the CC";
+}
+final IClusterManagementWork.ClusterState clusterState = 
ClusterStateManager.INSTANCE.getState();
+if (clusterState != IClusterManagementWork.ClusterState.ACTIVE) {
+return "Cannot execute request, cluster is " + clusterState;
+}
+return null;
+}
+
+private void sendRejection(String reason, CCMessageBroker messageBroker) {
+ExecuteStatementResponseMessage responseMsg = new 
ExecuteStatementResponseMessage(requestMessageId);
+responseMsg.setError(new Exception(reason));
+try {
+messageBroker.sendApplicationMessageToNC(responseMsg, 
requestNodeId);
+} catch (Exception e) {
+LOGGER.log(Level.WARNING, e.toString(), e);
+}
+}
+
 @Override
 public String toString() {
 return String.format("%s(id=%s, from=%s): %s", 
getClass().getSimpleName(), requestMessageId, requestNodeId,
diff --git 

[jira] [Commented] (ASTERIXDB-2014) Don't contact NCService on failed nodes, if NCService is disabled

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ASTERIXDB-2014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115046#comment-16115046
 ] 

ASF subversion and git services commented on ASTERIXDB-2014:


Commit 27434300cc39e9808f314a6ea539011c97d4fdc7 in asterixdb's branch 
refs/heads/master from [~mblow]
[ https://git-wip-us.apache.org/repos/asf?p=asterixdb.git;h=2743430 ]

[ASTERIXDB-2014][HYR][CLUS] Respect disabled NCService

- Don't contact NCService on failed nodes, if NCService is disabled
- Also, don't block work queue for TriggerNCWork

Change-Id: Ib307f06d8bbcf4039480291aef566f240cadba20
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1913
Reviewed-by: Till Westmann 
Integration-Tests: Till Westmann 
Tested-by: Till Westmann 


> Don't contact NCService on failed nodes, if NCService is disabled
> -
>
> Key: ASTERIXDB-2014
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-2014
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: CLUS - Cluster management, HYR - Hyracks
>Reporter: Michael Blow
>Assignee: Michael Blow
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ASTERIXDB-2020) Set default max number of reattempts to 0 in JobSpecification

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ASTERIXDB-2020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115049#comment-16115049
 ] 

ASF subversion and git services commented on ASTERIXDB-2020:


Commit b5112d4b3ca26995feab3e8083b5eff89a34a618 in asterixdb's branch 
refs/heads/master from [~alamoudi]
[ https://git-wip-us.apache.org/repos/asf?p=asterixdb.git;h=b5112d4 ]

[ASTERIXDB-2020][HYR] Set Default Number of Reattempts to 0

- user model changes: no
- storage format changes: no
- interface changes: no

details:
- Set Default Number of Reattempts to 0

Change-Id: I922611fca234a77aca0947f4571c4ffad008273a
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1914
Reviewed-by: Murtadha Hubail 
Integration-Tests: Murtadha Hubail 
Tested-by: Murtadha Hubail 


> Set default max number of reattempts to 0 in JobSpecification
> -
>
> Key: ASTERIXDB-2020
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-2020
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: HYR - Hyracks
>Reporter: Abdullah Alamoudi
>Assignee: Abdullah Alamoudi
>
> In Hyracks JobSpecification, the default max number of reattempts is set to 
> 2. This forces anyone who creates a job that shouldn't be re-attempted to 
> explicitly set the number to 0 and we have many calls that sets it to 0.
> However, sometimes, developers forget to set that and this leads to serious 
> failures...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Change in asterixdb[master]: [WIP][ASTERIXDB-1984][COMP] probe-subtree init not required

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [WIP][ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 11: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3598/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1880
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a25
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2013][HYR] non-POST x-www-form-urlencoded, config...

[Michael Blow (Code Review)]

Michael Blow has submitted this change and it was merged.

Change subject: [ASTERIXDB-2013][HYR] non-POST x-www-form-urlencoded, config 
null value handling
..


[ASTERIXDB-2013][HYR] non-POST x-www-form-urlencoded, config null value handling

- handle null config values when marshall/unmarshalling
- support non-post x-www-form-urlencoded directly
- don't assume POSTs are x-www-form-urlencoded
- add support to TestExecutor for POST/PUT form-urlencoded parameters

Change-Id: I670b815a5276d870f7d538d1ce9d8bef2d0fcf4f
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1911
Reviewed-by: Till Westmann 
Tested-by: Jenkins 
Contrib: Jenkins 
Integration-Tests: Jenkins 
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryResultApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryStatusApiServlet.java
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/hyracks/bootstrap/CCApplication.java
M 
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/config/IOption.java
M 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/config/IOptionType.java
M hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/pom.xml
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/config/ConfigManager.java
M 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-common/src/main/java/org/apache/hyracks/control/common/config/OptionTypes.java
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/api/IServletRequest.java
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/BaseRequest.java
A 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/FormUrlEncodedRequest.java
D 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/PostRequest.java
M 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/utils/HttpUtil.java
15 files changed, 347 insertions(+), 191 deletions(-)

Approvals:
  Till Westmann: Looks good to me, approved
  Jenkins: Verified; No violations found; Verified

Objections:
  Anon. E. Moose #1000171: Violations found
  Jenkins: Violations found



diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryResultApiServlet.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryResultApiServlet.java
index 42e23ba..901aff8 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryResultApiServlet.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryResultApiServlet.java
@@ -41,7 +41,7 @@
 public class QueryResultApiServlet extends AbstractQueryApiServlet {
 private static final Logger LOGGER = 
Logger.getLogger(QueryResultApiServlet.class.getName());
 
-public QueryResultApiServlet(ConcurrentMap ctx, String[] 
paths, IApplicationContext appCtx) {
+public QueryResultApiServlet(ConcurrentMap ctx, 
IApplicationContext appCtx, String... paths) {
 super(appCtx, ctx, paths);
 }
 
diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java
index 9ee064e..1cec616 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java
@@ -62,8 +62,6 @@
 import com.fasterxml.jackson.databind.JsonNode;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.fasterxml.jackson.databind.node.ObjectNode;
-
-import io.netty.handler.codec.http.HttpHeaderNames;
 import io.netty.handler.codec.http.HttpResponseStatus;
 
 public class QueryServiceServlet extends AbstractQueryApiServlet {
@@ -317,9 +315,7 @@
 }
 
 private RequestParameters getRequestParameters(IServletRequest request) 
throws IOException {
-final String contentTypeParam = 
request.getHttpRequest().headers().get(HttpHeaderNames.CONTENT_TYPE);
-int sep = contentTypeParam.indexOf(';');
-final String contentType = sep < 0 ? contentTypeParam.trim() : 
contentTypeParam.substring(0, sep).trim();
+final String contentType = HttpUtil.getContentTypeOnly(request);
 RequestParameters param = new RequestParameters();
 param.host = host(request);
   

[jira] [Commented] (ASTERIXDB-2013) Support application/x-www-form-urlencoded for non-POST methods

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ASTERIXDB-2013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115215#comment-16115215
 ] 

ASF subversion and git services commented on ASTERIXDB-2013:


Commit a14cebbf0c62cec4593eaa3e81b3b4919286be05 in asterixdb's branch 
refs/heads/master from [~mblow]
[ https://git-wip-us.apache.org/repos/asf?p=asterixdb.git;h=a14cebb ]

[ASTERIXDB-2013][HYR] non-POST x-www-form-urlencoded, config null value handling

- handle null config values when marshall/unmarshalling
- support non-post x-www-form-urlencoded directly
- don't assume POSTs are x-www-form-urlencoded
- add support to TestExecutor for POST/PUT form-urlencoded parameters

Change-Id: I670b815a5276d870f7d538d1ce9d8bef2d0fcf4f
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1911
Reviewed-by: Till Westmann 
Tested-by: Jenkins 
Contrib: Jenkins 
Integration-Tests: Jenkins 


> Support application/x-www-form-urlencoded for non-POST methods
> --
>
> Key: ASTERIXDB-2013
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-2013
> Project: Apache AsterixDB
>  Issue Type: Improvement
>  Components: HYR - Hyracks
>Reporter: Michael Blow
>Assignee: Michael Blow
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (ASTERIXDB-1984) Index-Nested-Loop Join should not care about the contents of the probe branch

[Taewoo Kim (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ASTERIXDB-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Taewoo Kim updated ASTERIXDB-1984:
--
Description: 
Currently, when the optimizer tries to transform a query with the "index_nl" 
hint, it tries to identify datasource, assign, and unnest operators in both 
outer (probe) and inner branch. It also tries to identify the fieldname of the 
variables that are being joined. However, the probe branch can be an arbitrary 
sub-plan and what only really matters for the probe subtree is the type of the 
field from the probe tree that is being joined. If that field type is correctly 
identified, then any form of probe-subtree with a simple data-scan on the inner 
branch can be correctly transformed into an index-utilization plan. The 
following queries should be transformed into an index-utilization plan. 
However, they are not transformed now in the current master.

E.g.,

{code}
SELECT * FROM
[1, 2, 3] AS bar JOIN foo on bar /*+ indexnl */ =  foo.key;


SELECT  * FROM
bar JOIN foo on bar.id = foo.key JOIN datac ON foo.key /*+ indexnl */ = 
datac.val;


SELECT  * FROM
(SELECT id, COUNT(*) FROM bar GROUP BY id) AS barr JOIN foo ON barr.id /*+ 
indexnl */ =  foo.key;
{code}

  was:
Currently, when the optimizer tries to transform a query with the "index_nl" 
hint, it tries to identify datasource, assign, and unnest operators in both 
outer (probe) and inner branch. It also tries to identify the fieldname of the 
variables that are being joined. However, the probe branch can be an arbitrary 
sub-plan and what only really matters for the probe subtree is the type of the 
field from the probe tree that is being joined. If that field type is correctly 
identified, then any form of probe-subtree with a simple data-scan on the inner 
branch can be correctly transformed into an index-utilization plan. The 
following queries should be transformed into an index-utilization plan. 
However, they are not transformed now in the current master.

E.g.,

{code}
SELECT * FROM
[1, 2, 3] AS bar JOIN foo on bar = /*+ indexnl */ foo.key;


SELECT  * FROM
bar JOIN foo on bar.id = foo.key JOIN datac ON foo.key = /*+ indexnl */ 
datac.val;


SELECT  * FROM
(SELECT id, COUNT(*) FROM bar GROUP BY id) AS barr JOIN foo ON barr.id= /*+ 
indexnl */ foo.key;
{code}



> Index-Nested-Loop Join should not care about the contents of the probe branch
> -
>
> Key: ASTERIXDB-1984
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-1984
> Project: Apache AsterixDB
>  Issue Type: Bug
>Reporter: Taewoo Kim
>Assignee: Taewoo Kim
>
> Currently, when the optimizer tries to transform a query with the "index_nl" 
> hint, it tries to identify datasource, assign, and unnest operators in both 
> outer (probe) and inner branch. It also tries to identify the fieldname of 
> the variables that are being joined. However, the probe branch can be an 
> arbitrary sub-plan and what only really matters for the probe subtree is the 
> type of the field from the probe tree that is being joined. If that field 
> type is correctly identified, then any form of probe-subtree with a simple 
> data-scan on the inner branch can be correctly transformed into an 
> index-utilization plan. The following queries should be transformed into an 
> index-utilization plan. However, they are not transformed now in the current 
> master.
> E.g.,
> {code}
> SELECT * FROM
> [1, 2, 3] AS bar JOIN foo on bar /*+ indexnl */ =  foo.key;
> SELECT  * FROM
> bar JOIN foo on bar.id = foo.key JOIN datac ON foo.key /*+ indexnl */ = 
> datac.val;
> SELECT  * FROM
> (SELECT id, COUNT(*) FROM bar GROUP BY id) AS barr JOIN foo ON barr.id /*+ 
> indexnl */ =  foo.key;
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Change in asterixdb[master]: [ASTERIXDB-2013][HYR] non-POST x-www-form-urlencoded, config...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2013][HYR] non-POST x-www-form-urlencoded, config 
null value handling
..


Patch Set 7:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1582/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1911
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I670b815a5276d870f7d538d1ce9d8bef2d0fcf4f
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-2013][HYR] non-POST x-www-form-urlencoded, config...

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2013][HYR] non-POST x-www-form-urlencoded, config 
null value handling
..


Patch Set 7: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1582/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1911
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I670b815a5276d870f7d538d1ce9d8bef2d0fcf4f
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Michael Blow 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No

Change in asterixdb[master]: [WIP][ASTERIXDB-1984][COMP] probe-subtree init not required

[Taewoo Kim (Code Review)]

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/1880

to look at the new patch set (#11).

Change subject: [WIP][ASTERIXDB-1984][COMP] probe-subtree init not required
..

[WIP][ASTERIXDB-1984][COMP] probe-subtree init not required

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Let the IntroduceJoinAccessMethod accept arbitrary
  forms of sub-tree for the probe-tree.
- As a result, an open-type field with an enforced-index
  on the probe side will not be considered for the
  index-nested-loop join. An explicit conversion function
  should be used in such case.
- The surrogate-join in the InvertedIndexAccessMethod now
  does not need a fixed form of sub-tree.

Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a25
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodAnalysisContext.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceJoinAccessMethodRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceSelectAccessMethodRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/InvertedIndexAccessMethod.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/OptimizableOperatorSubTree.java
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/btree-index-join/secondary-equi-join_04.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/btree-index-join/secondary-equi-join_05.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/btree-index-join/secondary-equi-join_06.sqlpp
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/meta/secondary_index-lojoin_with_meta-1.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/meta/secondary_index-nljoin_with_meta-1.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/leftouterjoin-probe-pidx-with-join-btree-sidx_01_2.aql
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/leftouterjoin-probe-pidx-with-join-btree-sidx_01_3.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/leftouterjoin-probe-pidx-with-join-btree-sidx_02_2.aql
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/leftouterjoin-probe-pidx-with-join-btree-sidx_02_3.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-join_01.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-join_02.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-join_03.aql
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-join_04.aql
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-join_05.aql
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-join_06.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-prefix-join_01.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-prefix-join_02.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-prefix-join_03.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-prefix-join_04.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-prefix-join_05.aql
M 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-prefix-join_06.aql
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-prefix-join_07.aql
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-prefix-join_08.aql
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-prefix-join_09.aql
A 

Change in asterixdb[master]: [WIP][ASTERIXDB-1984][COMP] probe-subtree init not required

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [WIP][ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 11:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/854/ 
(7/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1880
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a25
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: [WIP][ASTERIXDB-1984][COMP] probe-subtree init not required

[Jenkins (Code Review)]

Jenkins has posted comments on this change.

Change subject: [WIP][ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 11:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/515/ (5/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1880
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a25
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No