Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements

2018-02-22 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][NET] Networking Improvements
..


Patch Set 2: Contrib-2

Analytics Compatibility Tests Failed
https://goo.gl/1sUwU1 : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2418
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] Networking Improvements
..


Patch Set 2: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2756/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2418
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2225] Improve formatting of the dashboard source ...

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2225] Improve formatting of the dashboard source code
..


Patch Set 11:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/2734/ 
(7/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2320
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie18f5e1fc2be1e7f565b3faa245fae269b5285d4
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Emilio Jose Coronado Lopez 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Emilio Jose Coronado Lopez 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2225] Improve formatting of the dashboard source ...

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2225] Improve formatting of the dashboard source code
..


Patch Set 11:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3354/ (3/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2320
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie18f5e1fc2be1e7f565b3faa245fae269b5285d4
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Emilio Jose Coronado Lopez 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Emilio Jose Coronado Lopez 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2225] Improve formatting of the dashboard source ...

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2225] Improve formatting of the dashboard source code
..


Patch Set 11:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3317/ 
(2/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2320
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie18f5e1fc2be1e7f565b3faa245fae269b5285d4
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Emilio Jose Coronado Lopez 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Emilio Jose Coronado Lopez 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2225] Improve formatting of the dashboard source ...

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2225] Improve formatting of the dashboard source code
..


Patch Set 11:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3293/
 (10/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2320
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie18f5e1fc2be1e7f565b3faa245fae269b5285d4
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Emilio Jose Coronado Lopez 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Emilio Jose Coronado Lopez 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2225] Improve formatting of the dashboard source ...

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2225] Improve formatting of the dashboard source code
..


Patch Set 11:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/6773/ (9/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2320
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie18f5e1fc2be1e7f565b3faa245fae269b5285d4
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Emilio Jose Coronado Lopez 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Emilio Jose Coronado Lopez 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2225] Improve formatting of the dashboard source ...

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2225] Improve formatting of the dashboard source code
..


Patch Set 11:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/2781/ 
(6/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2320
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie18f5e1fc2be1e7f565b3faa245fae269b5285d4
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Emilio Jose Coronado Lopez 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Emilio Jose Coronado Lopez 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2225] Improve formatting of the dashboard source ...

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2225] Improve formatting of the dashboard source code
..


Patch Set 11:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/2807/ 
(5/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2320
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie18f5e1fc2be1e7f565b3faa245fae269b5285d4
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Emilio Jose Coronado Lopez 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Emilio Jose Coronado Lopez 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] Networking Improvements
..


Patch Set 2: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5733/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2418
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2225] Improve formatting of the dashboard source ...

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2225] Improve formatting of the dashboard source code
..


Patch Set 11:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3554/ (4/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2320
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie18f5e1fc2be1e7f565b3faa245fae269b5285d4
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Emilio Jose Coronado Lopez 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Emilio Jose Coronado Lopez 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2225] Improve formatting of the dashboard source ...

2018-02-22 Thread Emilio Jose Coronado Lopez (Code Review)
Hello Anon. E. Moose #1000171, Jenkins, Michael Blow,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2320

to look at the new patch set (#11).

Change subject: [ASTERIXDB-2225] Improve formatting of the dashboard source code
..

[ASTERIXDB-2225] Improve formatting of the dashboard source code

[ASTERIXDB-2241] Unable to change dataverse focus in new console

[ASTERIXDB-2240] Multi-statement sequences not supported in new console

UI-Web Interface

- user model changes: no
- storage format changes: no
- interface changes: no

Change-Id: Ie18f5e1fc2be1e7f565b3faa245fae269b5285d4
---
M asterixdb/LICENSE
M asterixdb/asterix-app/src/main/appended-resources/META-INF/LICENSE
M asterixdb/asterix-dashboard/pom.xml
A asterixdb/asterix-dashboard/src/main/appended-resources/META-INF/LICENSE
M asterixdb/asterix-dashboard/src/main/resources/dashboard/.angular-cli.json
M asterixdb/asterix-dashboard/src/main/resources/dashboard/README.md
M asterixdb/asterix-dashboard/src/main/resources/dashboard/karma.conf.js
M asterixdb/asterix-dashboard/src/main/resources/dashboard/package.json
M asterixdb/asterix-dashboard/src/main/resources/dashboard/protractor.conf.js
M 
asterixdb/asterix-dashboard/src/main/resources/dashboard/src/app/app-config.service.ts
M 
asterixdb/asterix-dashboard/src/main/resources/dashboard/src/app/app.component.html
M 
asterixdb/asterix-dashboard/src/main/resources/dashboard/src/app/app.component.ts
M asterixdb/asterix-dashboard/src/main/resources/dashboard/src/app/app.module.ts
M 
asterixdb/asterix-dashboard/src/main/resources/dashboard/src/app/dashboard/appbar.component.html
M 
asterixdb/asterix-dashboard/src/main/resources/dashboard/src/app/dashboard/appbar.component.scss
M 
asterixdb/asterix-dashboard/src/main/resources/dashboard/src/app/dashboard/appbar.component.ts
M 
asterixdb/asterix-dashboard/src/main/resources/dashboard/src/app/dashboard/apptab.component.html
M 
asterixdb/asterix-dashboard/src/main/resources/dashboard/src/app/dashboard/apptab.component.scss
M 
asterixdb/asterix-dashboard/src/main/resources/dashboard/src/app/dashboard/apptab.component.ts
M 
asterixdb/asterix-dashboard/src/main/resources/dashboard/src/app/dashboard/metadata/codemirror-metadata.component.ts
M 
asterixdb/asterix-dashboard/src/main/resources/dashboard/src/app/dashboard/metadata/datasets-collection/dataset-create-dialog.component.scss
M 
asterixdb/asterix-dashboard/src/main/resources/dashboard/src/app/dashboard/metadata/datasets-collection/dataset-drop-dialog.component.html
M 
asterixdb/asterix-dashboard/src/main/resources/dashboard/src/app/dashboard/metadata/datasets-collection/dataset-drop-dialog.component.scss
M 
asterixdb/asterix-dashboard/src/main/resources/dashboard/src/app/dashboard/metadata/datasets-collection/datasets.component.html
M 
asterixdb/asterix-dashboard/src/main/resources/dashboard/src/app/dashboard/metadata/datasets-collection/datasets.component.scss
M 
asterixdb/asterix-dashboard/src/main/resources/dashboard/src/app/dashboard/metadata/datasets-collection/datasets.component.ts
M 
asterixdb/asterix-dashboard/src/main/resources/dashboard/src/app/dashboard/metadata/datatypes-collection/datatype-create-dialog.component.scss
M 
asterixdb/asterix-dashboard/src/main/resources/dashboard/src/app/dashboard/metadata/datatypes-collection/datatype-drop-dialog.component.html
M 
asterixdb/asterix-dashboard/src/main/resources/dashboard/src/app/dashboard/metadata/datatypes-collection/datatype-drop-dialog.component.scss
M 
asterixdb/asterix-dashboard/src/main/resources/dashboard/src/app/dashboard/metadata/datatypes-collection/datatypes.component.html
M 
asterixdb/asterix-dashboard/src/main/resources/dashboard/src/app/dashboard/metadata/datatypes-collection/datatypes.component.scss
M 
asterixdb/asterix-dashboard/src/main/resources/dashboard/src/app/dashboard/metadata/datatypes-collection/datatypes.component.ts
M 
asterixdb/asterix-dashboard/src/main/resources/dashboard/src/app/dashboard/metadata/dataverses-collection/dataverses-create-dialog.component.html
M 
asterixdb/asterix-dashboard/src/main/resources/dashboard/src/app/dashboard/metadata/dataverses-collection/dataverses-create-dialog.component.scss
M 
asterixdb/asterix-dashboard/src/main/resources/dashboard/src/app/dashboard/metadata/dataverses-collection/dataverses-drop-dialog.component.html
M 
asterixdb/asterix-dashboard/src/main/resources/dashboard/src/app/dashboard/metadata/dataverses-collection/dataverses-drop-dialog.component.scss
M 
asterixdb/asterix-dashboard/src/main/resources/dashboard/src/app/dashboard/metadata/dataverses-collection/dataverses.component.html
M 
asterixdb/asterix-dashboard/src/main/resources/dashboard/src/app/dashboard/metadata/dataverses-collection/dataverses.component.scss
M 
asterixdb/asterix-dashboard/src/main/resources/dashboard/src/app/dashboard/metadata/dataverses-collection/dataverses.component.ts
M 

Change in asterixdb[master]: [ASTERIXDB-2225] Improve formatting of the dashboard source ...

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2225] Improve formatting of the dashboard source code
..


Patch Set 11:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8280/ (1/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2320
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie18f5e1fc2be1e7f565b3faa245fae269b5285d4
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Emilio Jose Coronado Lopez 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Emilio Jose Coronado Lopez 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2225] Improve formatting of the dashboard source ...

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2225] Improve formatting of the dashboard source code
..


Patch Set 11:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3040/ 
(8/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2320
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie18f5e1fc2be1e7f565b3faa245fae269b5285d4
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Emilio Jose Coronado Lopez 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Emilio Jose Coronado Lopez 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2225] Improve formatting of the dashboard source ...

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2225] Improve formatting of the dashboard source code
..


Patch Set 11:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/2815/
 (12/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2320
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie18f5e1fc2be1e7f565b3faa245fae269b5285d4
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Emilio Jose Coronado Lopez 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Emilio Jose Coronado Lopez 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2225] Improve formatting of the dashboard source ...

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2225] Improve formatting of the dashboard source code
..


Patch Set 11:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/830/ 
(11/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2320
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie18f5e1fc2be1e7f565b3faa245fae269b5285d4
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Emilio Jose Coronado Lopez 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Emilio Jose Coronado Lopez 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2225] Improve formatting of the dashboard source ...

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2225] Improve formatting of the dashboard source code
..


Patch Set 11:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5734/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2320
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie18f5e1fc2be1e7f565b3faa245fae269b5285d4
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Emilio Jose Coronado Lopez 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Emilio Jose Coronado Lopez 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2225] Improve formatting of the dashboard source ...

2018-02-22 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2225] Improve formatting of the dashboard source code
..


Patch Set 11:

Analytics Compatibility Compilation Successful
https://goo.gl/GJdTjv : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2320
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie18f5e1fc2be1e7f565b3faa245fae269b5285d4
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Emilio Jose Coronado Lopez 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Emilio Jose Coronado Lopez 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2225] Improve formatting of the dashboard source ...

2018-02-22 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2225] Improve formatting of the dashboard source code
..


Patch Set 11: Contrib-2

Analytics Compatibility Tests Failed
https://goo.gl/vMnKju : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2320
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie18f5e1fc2be1e7f565b3faa245fae269b5285d4
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Emilio Jose Coronado Lopez 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Emilio Jose Coronado Lopez 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2225] Improve formatting of the dashboard source ...

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2225] Improve formatting of the dashboard source code
..


Patch Set 11:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2757/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2320
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie18f5e1fc2be1e7f565b3faa245fae269b5285d4
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Emilio Jose Coronado Lopez 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Emilio Jose Coronado Lopez 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements

2018-02-22 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][NET] Networking Improvements
..


Patch Set 2:

Analytics Compatibility Tests Failed
https://goo.gl/bywCQu : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2418
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2225] Improve formatting of the dashboard source ...

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2225] Improve formatting of the dashboard source code
..


Patch Set 11: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5734/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2320
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie18f5e1fc2be1e7f565b3faa245fae269b5285d4
Gerrit-PatchSet: 11
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Emilio Jose Coronado Lopez 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Emilio Jose Coronado Lopez 
Gerrit-Reviewer: Ian Maxon 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements

2018-02-22 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][NET] Networking Improvements
..


Patch Set 2:

Analytics Compatibility Tests Failed
https://goo.gl/2Xx5N1 : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2418
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements

2018-02-22 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][NET] Networking Improvements
..


Patch Set 2:

Analytics Compatibility Tests Failed
https://goo.gl/2f3ELV : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2418
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2291][FUN] Implement if_inf,if_nan,if_nan_or_inf

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2291][FUN] Implement if_inf,if_nan,if_nan_or_inf
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/2817/
 (12/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2411
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12dccd848a1d6b4ba102bea3b7602c2cbd8aaef5
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2287][SQL] Support SELECT variable.* in SQL++

2018-02-22 Thread Dmitry Lychagin (Code Review)
Dmitry Lychagin has posted comments on this change.

Change subject: [ASTERIXDB-2287][SQL] Support SELECT variable.* in SQL++
..


Patch Set 6:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/2394/6/asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/ObjectsQueries.xml
File 
asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/ObjectsQueries.xml:

PS6, Line 155: 

Change in asterixdb[master]: [ASTERIXDB-2294][FUN] Implement is_atomic()

2018-02-22 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2294][FUN] Implement is_atomic()
..


Patch Set 2:

Analytics Compatibility Tests Failed
https://goo.gl/eEGJUb : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2416
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib979f4fe2fdce7575d13a259ac241d58d9fc6ae2
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2291][FUN] Implement if_inf,if_nan,if_nan_or_inf

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2291][FUN] Implement if_inf,if_nan,if_nan_or_inf
..


Patch Set 3: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2758/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2411
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12dccd848a1d6b4ba102bea3b7602c2cbd8aaef5
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2294][FUN] Implement is_atomic()

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2294][FUN] Implement is_atomic()
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/2816/
 (12/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2416
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib979f4fe2fdce7575d13a259ac241d58d9fc6ae2
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements

2018-02-22 Thread Michael Blow (Code Review)
Michael Blow has posted comments on this change.

Change subject: [NO ISSUE][NET] Networking Improvements
..


Patch Set 2:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/2418/2/hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/IPCConnectionManager.java
File 
hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/IPCConnectionManager.java:

PS2, Line 370: LOGGER.error(() -> new ParameterizedMessage("TCP 
read error from {}", handle.getRemoteAddress()), e);
how does this differ from:
LOGGER.error("TCP read error from {}", handle::getRemoteAddress, e);


PS2, Line 394: LOGGER.error(() -> new ParameterizedMessage("TCP 
write error to {}", handle.getRemoteAddress()), e);
see above q


https://asterix-gerrit.ics.uci.edu/#/c/2418/2/hyracks-fullstack/hyracks/hyracks-net/src/main/java/org/apache/hyracks/net/protocols/tcp/TCPEndpoint.java
File 
hyracks-fullstack/hyracks/hyracks-net/src/main/java/org/apache/hyracks/net/protocols/tcp/TCPEndpoint.java:

PS2, Line 211: LOGGER.error(() -> new 
ParameterizedMessage("Error in TCPEndpoint {}", localAddress), e);
not asking again


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2418
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-HasComments: Yes


Change in asterixdb[master]: [ASTERIXDB-2291][FUN] Implement if_inf,if_nan,if_nan_or_inf

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2291][FUN] Implement if_inf,if_nan,if_nan_or_inf
..


Patch Set 3:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2758/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2411
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12dccd848a1d6b4ba102bea3b7602c2cbd8aaef5
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] Networking Improvements
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/2818/
 (4/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2418
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] Networking Improvements
..


Patch Set 3:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/2735/ 
(7/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2418
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] Networking Improvements
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/2808/ 
(12/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2418
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] Networking Improvements
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3355/ (10/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2418
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] Networking Improvements
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3294/
 (3/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2418
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements

2018-02-22 Thread Murtadha Hubail (Code Review)
Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2418

to look at the new patch set (#3).

Change subject: [NO ISSUE][NET] Networking Improvements
..

[NO ISSUE][NET] Networking Improvements

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Set keep alive and no TCP delay options
  on socket channels.
- Cancel key and close IPC handle on failed
  read/writes to avoid getting the same failures
  with every NetworkThread loop.

Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a
---
M 
asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/api/PartitionReplica.java
M 
asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/api/ReplicationDestination.java
M hyracks-fullstack/hyracks/hyracks-ipc/pom.xml
M 
hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/IPCConnectionManager.java
M hyracks-fullstack/hyracks/hyracks-net/pom.xml
M 
hyracks-fullstack/hyracks/hyracks-net/src/main/java/org/apache/hyracks/net/protocols/tcp/TCPEndpoint.java
A 
hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/NetworkUtil.java
7 files changed, 139 insertions(+), 52 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/18/2418/3
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2418
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 


Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] Networking Improvements
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/6774/ (5/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2418
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] Networking Improvements
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/2782/ 
(11/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2418
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] Networking Improvements
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/831/ 
(2/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2418
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2287][SQL] Support SELECT variable.* in SQL++

2018-02-22 Thread Dmitry Lychagin (Code Review)
Dmitry Lychagin has posted comments on this change.

Change subject: [ASTERIXDB-2287][SQL] Support SELECT variable.* in SQL++
..


Patch Set 6:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/2394/6/asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/ObjectsQueries.xml
File 
asterixdb/asterix-app/src/test/resources/runtimets/queries/objects/ObjectsQueries.xml:

PS6, Line 155: 

[jira] [Created] (ASTERIXDB-2295) Intermittent failures in objects/object-add-fields, object-remove-fields

2018-02-22 Thread Dmitry Lychagin (JIRA)
Dmitry Lychagin created ASTERIXDB-2295:
--

 Summary: Intermittent failures in objects/object-add-fields, 
object-remove-fields  
 Key: ASTERIXDB-2295
 URL: https://issues.apache.org/jira/browse/ASTERIXDB-2295
 Project: Apache AsterixDB
  Issue Type: Bug
  Components: FUN - Functions
Reporter: Dmitry Lychagin
Assignee: Dmitry Lychagin


objects/object-add-fields, object-remove-fields tests are currently disabled 
because of intermittent issues. They seem to produce corrupt records. Need to 
re-enable them and investigate.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Change in asterixdb[master]: [NO ISSUE][STO] Move the IO threads from BufferCache to IOMa...

2018-02-22 Thread Michael Blow (Code Review)
Michael Blow has posted comments on this change.

Change subject: [NO ISSUE][STO] Move the IO threads from BufferCache to 
IOManager
..


Patch Set 3:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/2417/3/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/util/CleanupUtils.java
File 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/util/CleanupUtils.java:

PS3, Line 117: re-thrown
suppressed


https://asterix-gerrit.ics.uci.edu/#/c/2417/3/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/io/IoRequestHandler.java
File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/io/IoRequestHandler.java:

PS3, Line 52: InvokeUtil.doUninterruptibly(() -> queue.put(POISON_PILL));
why do we put the pill back onto the queue?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2417
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic02b456826ae7abc2619a7eec3f90b48717b0adb
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes


Change in asterixdb[master]: [ASTERIXDB-2291][FUN] Implement if_inf,if_nan,if_nan_or_inf

2018-02-22 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2291][FUN] Implement if_inf,if_nan,if_nan_or_inf
..


Patch Set 3:

Analytics Compatibility Tests Failed
https://goo.gl/hP48b8 : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2411
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12dccd848a1d6b4ba102bea3b7602c2cbd8aaef5
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2233][COMP] Factor out common conjunct from disjunct

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2233][COMP] Factor out common conjunct from disjunct
..


Patch Set 13:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5736/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2322
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I97fe7d94276f9206c076ca94814b2fa794107859
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2233][COMP] Factor out common conjunct from disjunct

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2233][COMP] Factor out common conjunct from disjunct
..


Patch Set 13:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/2819/
 (9/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2322
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I97fe7d94276f9206c076ca94814b2fa794107859
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2233][COMP] Factor out common conjunct from disjunct

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2233][COMP] Factor out common conjunct from disjunct
..


Patch Set 13:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2322
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I97fe7d94276f9206c076ca94814b2fa794107859
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2233][COMP] Factor out common conjunct from disjunct

2018-02-22 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2233][COMP] Factor out common conjunct from disjunct
..


Patch Set 13:

Analytics Compatibility Compilation Successful
https://goo.gl/C2dHsq : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2322
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I97fe7d94276f9206c076ca94814b2fa794107859
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] Networking Improvements
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3041/ 
(8/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2418
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] Networking Improvements
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8281/ (1/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2418
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] Networking Improvements
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3318/ 
(6/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2418
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] Networking Improvements
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3555/ (9/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2418
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2233][COMP] Factor out common conjunct from disjunct

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2233][COMP] Factor out common conjunct from disjunct
..


Patch Set 13:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/6775/ (3/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2322
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I97fe7d94276f9206c076ca94814b2fa794107859
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2233][COMP] Factor out common conjunct from disjunct

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2233][COMP] Factor out common conjunct from disjunct
..


Patch Set 13:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3356/ (1/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2322
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I97fe7d94276f9206c076ca94814b2fa794107859
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2233][COMP] Factor out common conjunct from disjunct

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2233][COMP] Factor out common conjunct from disjunct
..


Patch Set 13:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/832/ 
(8/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2322
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I97fe7d94276f9206c076ca94814b2fa794107859
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2233][COMP] Factor out common conjunct from disjunct

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2233][COMP] Factor out common conjunct from disjunct
..


Patch Set 13:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8282/ (2/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2322
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I97fe7d94276f9206c076ca94814b2fa794107859
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2233][COMP] Factor out common conjunct from disjunct

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2233][COMP] Factor out common conjunct from disjunct
..


Patch Set 13:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/2783/ 
(7/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2322
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I97fe7d94276f9206c076ca94814b2fa794107859
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2233][COMP] Factor out common conjunct from disjunct

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2233][COMP] Factor out common conjunct from disjunct
..


Patch Set 13:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/2809/ 
(6/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2322
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I97fe7d94276f9206c076ca94814b2fa794107859
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2233][COMP] Factor out common conjunct from disjunct

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2233][COMP] Factor out common conjunct from disjunct
..


Patch Set 13:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/2736/ 
(4/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2322
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I97fe7d94276f9206c076ca94814b2fa794107859
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2233][COMP] Factor out common conjunct from disjunct

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2233][COMP] Factor out common conjunct from disjunct
..


Patch Set 13:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3042/ 
(5/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2322
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I97fe7d94276f9206c076ca94814b2fa794107859
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements

2018-02-22 Thread Murtadha Hubail (Code Review)
Murtadha Hubail has posted comments on this change.

Change subject: [NO ISSUE][NET] Networking Improvements
..


Patch Set 2:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/2418/2/hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/IPCConnectionManager.java
File 
hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/IPCConnectionManager.java:

PS2, Line 370: LOGGER.error(() -> new ParameterizedMessage("TCP 
read error from {}", handle.getRemoteAddress()), e);
> how does this differ from:
It's not


PS2, Line 394: LOGGER.error(() -> new ParameterizedMessage("TCP 
write error to {}", handle.getRemoteAddress()), e);
> see above q
see above a


https://asterix-gerrit.ics.uci.edu/#/c/2418/2/hyracks-fullstack/hyracks/hyracks-net/src/main/java/org/apache/hyracks/net/protocols/tcp/TCPEndpoint.java
File 
hyracks-fullstack/hyracks/hyracks-net/src/main/java/org/apache/hyracks/net/protocols/tcp/TCPEndpoint.java:

PS2, Line 211: LOGGER.error(() -> new 
ParameterizedMessage("Error in TCPEndpoint {}", localAddress), e);
> not asking again
not answering again


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2418
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-HasComments: Yes


Change in asterixdb[master]: [NO ISSUE][STO] Move the IO threads from BufferCache to IOMa...

2018-02-22 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][STO] Move the IO threads from BufferCache to 
IOManager
..


Patch Set 3: Contrib-2

Analytics Compatibility Tests Failed
https://goo.gl/q58ZU6 : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2417
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic02b456826ae7abc2619a7eec3f90b48717b0adb
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements

2018-02-22 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][NET] Networking Improvements
..


Patch Set 3:

Analytics Compatibility Compilation Successful
https://goo.gl/bUaWo2 : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2418
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] Networking Improvements
..


Patch Set 3:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5735/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2418
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2294][FUN] Implement is_atomic()

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2294][FUN] Implement is_atomic()
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/2820/
 (12/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2416
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib979f4fe2fdce7575d13a259ac241d58d9fc6ae2
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2227][ING] Enabling filitering incoming data in feed

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2227][ING] Enabling filitering incoming data in feed
..


Patch Set 16:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3557/ (10/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2255
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0b3cc6fe9d7fb5f5645dd9c759da448bfe1e88f1
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][NET] Networking Improvements
..


Patch Set 3: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2759/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2418
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Move the IO threads from BufferCache to IOMa...

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Move the IO threads from BufferCache to 
IOManager
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/2822/
 (9/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2417
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic02b456826ae7abc2619a7eec3f90b48717b0adb
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


[jira] [Created] (ASTERIXDB-2296) AbstractIntroduceAccessMethodRule.getFieldNameFromSubTree() cannot handle AUnionType

2018-02-22 Thread Taewoo Kim (JIRA)
Taewoo Kim created ASTERIXDB-2296:
-

 Summary: 
AbstractIntroduceAccessMethodRule.getFieldNameFromSubTree() cannot handle 
AUnionType
 Key: ASTERIXDB-2296
 URL: https://issues.apache.org/jira/browse/ASTERIXDB-2296
 Project: Apache AsterixDB
  Issue Type: Bug
Reporter: Taewoo Kim


DDL
{code:java}
drop dataverse twitter if exists;
create dataverse twitter if not exists;
use twitter;

create type typeUser if not exists as open {
    id: int64,
    name: string,
    screen_name : string,
    profile_image_url : string?,
    lang : string,
    location: string,
    create_at: date,
    description: string,
    followers_count: int32,
    friends_count: int32,
    statues_count: int64
};

create type typePlace if not exists as open{
    country : string,
    country_code : string,
    full_name : string,
    id : string,
    name : string,
    place_type : string,
    bounding_box : rectangle
};

create type typeGeoTag if not exists as open {
    stateID: int32,
    stateName: string,
    countyID: int32,
    countyName: string,
    cityID: int32?,
    cityName: string?
};

create type typeTweet if not exists as open {
    create_at : datetime,
    id: int64,
    text: string,
    in_reply_to_status : int64,
    in_reply_to_user : int64,
    favorite_count : int64,
    coordinate: point?,
    retweet_count : int64,
    lang : string,
    is_retweet: boolean,
    hashtags : {{ string }} ?,
    user_mentions : {{ int64 }} ? ,
    user : typeUser,
    place : typePlace?,
    geo_tag: typeGeoTag
};

create dataset ds_tweet(typeTweet) if not exists primary key id with filter on 
create_at with
{"merge-policy":
  {"name":"prefix","parameters":
    {"max-mergable-component-size":134217728, 
"max-tolerance-component-count":10}
  }
};

create index text_idx if not exists on ds_tweet(text) type fulltext;
{code}
The following SQL++ query doesn't work based on the above DDL. This is because 
"place" is an optional field so that its type if AUnionType that contains 
ARecordType, not ARecordType itself.
{code:java}
select t.`place`.`bounding_box` as `place.bounding_box`,t.`user`.`id` as 
`user.id`,t.`id` as `id`,
t.`coordinate` as `coordinate`,t.`create_at` as `create_at`
from twitter.ds_tweet t
where t.`create_at` >= datetime('2018-02-22T10:53:07.888Z') and t.`create_at` < 
datetime('2018-02-22T18:50:39.301Z')
and ftcontains(t.`text`, ['francisco'], {'mode':'all'}) and 
t.`geo_tag`.`stateID` in [ 37,51,24,11 ]
order by t.`create_at` desc
limit 2147483647
offset 0;
{code}
An exception:
{code:java}
11:23:01.827 [QueryTranslator] INFO 
org.apache.asterix.app.translator.QueryTranslator - 
org.apache.asterix.om.types.AUnionType cannot be cast to 
org.apache.asterix.om.types.ARecordType
java.lang.ClassCastException: org.apache.asterix.om.types.AUnionType cannot be 
cast to org.apache.asterix.om.types.ARecordType
at 
org.apache.asterix.optimizer.rules.am.AbstractIntroduceAccessMethodRule.getFieldNameFromSubTree(AbstractIntroduceAccessMethodRule.java:877)
 ~[asterix-algebra-0.9.4-SNAPSHOT.jar:0.9.4-SNAPSHOT]
at 
org.apache.asterix.optimizer.rules.am.AbstractIntroduceAccessMethodRule.fillFieldNamesInTheSubTree(AbstractIntroduceAccessMethodRule.java:973)
 ~[asterix-algebra-0.9.4-SNAPSHOT.jar:0.9.4-SNAPSHOT]
at 
org.apache.asterix.optimizer.rules.am.IntroduceSelectAccessMethodRule.checkAndApplyTheSelectTransformation(IntroduceSelectAccessMethodRule.java:412)
 ~[asterix-algebra-0.9.4-SNAPSHOT.jar:0.9.4-SNAPSHOT]
at 
org.apache.asterix.optimizer.rules.am.IntroduceSelectAccessMethodRule.checkAndApplyTheSelectTransformation(IntroduceSelectAccessMethodRule.java:327)
 ~[asterix-algebra-0.9.4-SNAPSHOT.jar:0.9.4-SNAPSHOT]
at 
org.apache.asterix.optimizer.rules.am.IntroduceSelectAccessMethodRule.checkAndApplyTheSelectTransformation(IntroduceSelectAccessMethodRule.java:327)
 ~[asterix-algebra-0.9.4-SNAPSHOT.jar:0.9.4-SNAPSHOT]
at 
org.apache.asterix.optimizer.rules.am.IntroduceSelectAccessMethodRule.checkAndApplyTheSelectTransformation(IntroduceSelectAccessMethodRule.java:327)
 ~[asterix-algebra-0.9.4-SNAPSHOT.jar:0.9.4-SNAPSHOT]
at 
org.apache.asterix.optimizer.rules.am.IntroduceSelectAccessMethodRule.checkAndApplyTheSelectTransformation(IntroduceSelectAccessMethodRule.java:327)
 ~[asterix-algebra-0.9.4-SNAPSHOT.jar:0.9.4-SNAPSHOT]
at 
org.apache.asterix.optimizer.rules.am.IntroduceSelectAccessMethodRule.checkAndApplyTheSelectTransformation(IntroduceSelectAccessMethodRule.java:327)
 ~[asterix-algebra-0.9.4-SNAPSHOT.jar:0.9.4-SNAPSHOT]
at 
org.apache.asterix.optimizer.rules.am.IntroduceSelectAccessMethodRule.checkAndApplyTheSelectTransformation(IntroduceSelectAccessMethodRule.java:327)
 ~[asterix-algebra-0.9.4-SNAPSHOT.jar:0.9.4-SNAPSHOT]
at 
org.apache.asterix.optimizer.rules.am.IntroduceSelectAccessMethodRule.checkAndApplyTheSelectTransformation(IntroduceSelectAccessMethodRule.java:327)
 

Change in asterixdb[master]: [NO ISSUE][STO] Move the IO threads from BufferCache to IOMa...

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Move the IO threads from BufferCache to 
IOManager
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3321/ 
(12/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2417
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic02b456826ae7abc2619a7eec3f90b48717b0adb
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


[jira] [Resolved] (ASTERIXDB-2294) Implement is_atomic() function

2018-02-22 Thread Dmitry Lychagin (JIRA)

 [ 
https://issues.apache.org/jira/browse/ASTERIXDB-2294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dmitry Lychagin resolved ASTERIXDB-2294.

Resolution: Fixed

> Implement is_atomic() function
> --
>
> Key: ASTERIXDB-2294
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-2294
> Project: Apache AsterixDB
>  Issue Type: Improvement
>  Components: FUN - Functions
>Reporter: Dmitry Lychagin
>Assignee: Dmitry Lychagin
>Priority: Minor
>
> Implement is_atomic() functions which returns whether input argument is of 
> primitive type or not. Aliases: isatomic(), isatom()



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Change in asterixdb[master]: [NO ISSUE][STO] Move the IO threads from BufferCache to IOMa...

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Move the IO threads from BufferCache to 
IOManager
..


Patch Set 4:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2417
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic02b456826ae7abc2619a7eec3f90b48717b0adb
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield 
type
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/835/ 
(8/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2419
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...

2018-02-22 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield 
type
..


Patch Set 1:

Analytics Compatibility Compilation Successful
https://goo.gl/JJX9PU : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2419
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2227][ING] Enabling filitering incoming data in feed

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2227][ING] Enabling filitering incoming data in feed
..


Patch Set 16: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2762/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2255
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0b3cc6fe9d7fb5f5645dd9c759da448bfe1e88f1
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2291][FUN] Implement if_inf,if_nan,if_nan_or_inf

2018-02-22 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change.

Change subject: [ASTERIXDB-2291][FUN] Implement if_inf,if_nan,if_nan_or_inf
..


Patch Set 3:

(4 comments)

https://asterix-gerrit.ics.uci.edu/#/c/2411/3/asterixdb/asterix-doc/src/main/markdown/builtins/13_conditional.md
File asterixdb/asterix-doc/src/main/markdown/builtins/13_conditional.md:

PS3, Line 104:  
WS


PS3, Line 115:  
WS


PS3, Line 148:  
WS


PS3, Line 181:  
WS


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2411
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I12dccd848a1d6b4ba102bea3b7602c2cbd8aaef5
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: Yes


Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...

2018-02-22 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield 
type
..


Patch Set 1: Contrib-2

Analytics Compatibility Tests Failed
https://goo.gl/mPn7pA : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2419
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2227][ING] Enabling filitering incoming data in feed

2018-02-22 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2227][ING] Enabling filitering incoming data in feed
..


Patch Set 16:

Analytics Compatibility Compilation Successful
https://goo.gl/RGZod4 : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2255
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0b3cc6fe9d7fb5f5645dd9c759da448bfe1e88f1
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2233][COMP] Factor out common conjunct from disjunct

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2233][COMP] Factor out common conjunct from disjunct
..


Patch Set 13:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3295/
 (11/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2322
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I97fe7d94276f9206c076ca94814b2fa794107859
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2233][COMP] Factor out common conjunct from disjunct

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2233][COMP] Factor out common conjunct from disjunct
..


Patch Set 13:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3319/ 
(12/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2322
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I97fe7d94276f9206c076ca94814b2fa794107859
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2233][COMP] Factor out common conjunct from disjunct

2018-02-22 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2233][COMP] Factor out common conjunct from disjunct
..


Patch Set 13: Contrib-2

Analytics Compatibility Tests Failed
https://goo.gl/Xt4a4d : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2322
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I97fe7d94276f9206c076ca94814b2fa794107859
Gerrit-PatchSet: 13
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Wail Alkowaileet 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Wail Alkowaileet 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Move the IO threads from BufferCache to IOMa...

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Move the IO threads from BufferCache to 
IOManager
..


Patch Set 4:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5738/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2417
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic02b456826ae7abc2619a7eec3f90b48717b0adb
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield 
type
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8285/ (6/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2419
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2227][ING] Enabling filitering incoming data in feed

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2227][ING] Enabling filitering incoming data in feed
..


Patch Set 16:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2762/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2255
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0b3cc6fe9d7fb5f5645dd9c759da448bfe1e88f1
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Move the IO threads from BufferCache to IOMa...

2018-02-22 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][STO] Move the IO threads from BufferCache to 
IOManager
..


Patch Set 4: Contrib-2

Analytics Compatibility Tests Failed
https://goo.gl/TmSQgG : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2417
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic02b456826ae7abc2619a7eec3f90b48717b0adb
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2294][FUN] Implement is_atomic()

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2294][FUN] Implement is_atomic()
..


Patch Set 2: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2761/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2416
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib979f4fe2fdce7575d13a259ac241d58d9fc6ae2
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2294][FUN] Implement is_atomic()

2018-02-22 Thread Dmitry Lychagin (Code Review)
Dmitry Lychagin has submitted this change and it was merged.

Change subject: [ASTERIXDB-2294][FUN] Implement is_atomic()
..


[ASTERIXDB-2294][FUN] Implement is_atomic()

- user model changes: yes
- storage format changes: no
- interface changes: no

Details:
- Implement is_atomic() function with aliases isatomic(), isatom()
- Add testcases and documentation

Change-Id: Ib979f4fe2fdce7575d13a259ac241d58d9fc6ae2
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2416
Sonar-Qube: Jenkins 
Integration-Tests: Jenkins 
Tested-by: Jenkins 
Contrib: Jenkins 
Reviewed-by: Till Westmann 
---
A 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/types/isatomic/isatomic.1.query.sqlpp
A 
asterixdb/asterix-app/src/test/resources/runtimets/results/types/isatomic/isatomic.1.adm
M asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
M asterixdb/asterix-doc/src/main/markdown/builtins/11_type.md
M 
asterixdb/asterix-lang-common/src/main/java/org/apache/asterix/lang/common/util/CommonFunctionMapUtil.java
M 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/BuiltinFunctions.java
A 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/IsAtomicDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/functions/FunctionCollection.java
8 files changed, 142 insertions(+), 0 deletions(-)

Approvals:
  Till Westmann: Looks good to me, approved
  Jenkins: Verified; No violations found; ; Verified

Objections:
  Anon. E. Moose #1000171: Violations found



diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/types/isatomic/isatomic.1.query.sqlpp
 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/types/isatomic/isatomic.1.query.sqlpp
new file mode 100644
index 000..4339904
--- /dev/null
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/types/isatomic/isatomic.1.query.sqlpp
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+{
+  "a": isatomic(true),
+  "b": isatomic(false),
+  "c": is_atomic(null),
+  "d": is_atomic(missing),
+  "e": isatom("d"),
+  "f": isatom(4.0),
+  "g": isatom(5),
+  "h": isatom(["1", 2]),
+  "i": isatom({"a":1})
+};
diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/results/types/isatomic/isatomic.1.adm
 
b/asterixdb/asterix-app/src/test/resources/runtimets/results/types/isatomic/isatomic.1.adm
new file mode 100644
index 000..b6cd2d0
--- /dev/null
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/results/types/isatomic/isatomic.1.adm
@@ -0,0 +1 @@
+{ "a": true, "b": true, "c": null, "e": true, "f": true, "g": true, "h": 
false, "i": false }
diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml 
b/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
index 3a2c24c..a869b22 100644
--- a/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
+++ b/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
@@ -8987,6 +8987,11 @@
   
 
 
+  
+isatomic
+  
+
+
   
 isboolean
   
diff --git a/asterixdb/asterix-doc/src/main/markdown/builtins/11_type.md 
b/asterixdb/asterix-doc/src/main/markdown/builtins/11_type.md
index a2b2555..fd6a262 100644
--- a/asterixdb/asterix-doc/src/main/markdown/builtins/11_type.md
+++ b/asterixdb/asterix-doc/src/main/markdown/builtins/11_type.md
@@ -53,6 +53,38 @@
 
  The function has an alias `isarray`.
 
+### is_atomic (isatomic, isatom) ###
+ * Syntax:
+
+is_atomic(expr)
+
+ * Checks whether the given expression is evaluated to be a value of a 
[primitive](../datamodel.html#PrimitiveTypes) type.
+ * Arguments:
+* `expr` : an expression (any type is allowed).
+ * Return Value:
+* a `boolean` on whether the argument is a primitive type or not,
+* a `missing` if the argument is a `missing` value,
+* a `null` if the argument is a `null` 

Change in asterixdb[master]: [NO ISSUE][STO] Move the IO threads from BufferCache to IOMa...

2018-02-22 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change.

Change subject: [NO ISSUE][STO] Move the IO threads from BufferCache to 
IOManager
..


Patch Set 3:

(5 comments)

https://asterix-gerrit.ics.uci.edu/#/c/2417/3/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/util/CleanupUtils.java
File 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/util/CleanupUtils.java:

PS3, Line 120: Throwable
Suppress SQ warnings?


https://asterix-gerrit.ics.uci.edu/#/c/2417/3/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java
File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java:

PS3, Line 238: Throwable
Suppress SQ warning?


https://asterix-gerrit.ics.uci.edu/#/c/2417/3/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/io/IOManager.java
File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/io/IOManager.java:

PS3, Line 167: try {
 : if (req.getState() == State.OPERATION_SUCCEEDED) {
 : return req.getWrites();
 : } else if (req.getState() == State.OPERATION_FAILED) 
{
 : throw req.getFailure();
 : } else {
 : throw new IllegalStateException("Write request 
completed with state " + req.getState());
 : }
 : } finally {
 : req.recycle();
 : }
Seems identical to the methods above. Can we factor this out?


PS3, Line 205: asyncWrite
Move this close to the other asyncWrite method?


https://asterix-gerrit.ics.uci.edu/#/c/2417/3/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/io/IoRequestHandler.java
File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/io/IoRequestHandler.java:

PS3, Line 46: InterruptedException
Suppress SQ warning?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2417
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic02b456826ae7abc2619a7eec3f90b48717b0adb
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: Yes


Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield 
type
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3298/
 (11/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2419
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield 
type
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3322/ 
(12/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2419
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Move the IO threads from BufferCache to IOMa...

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Move the IO threads from BufferCache to 
IOManager
..


Patch Set 5:

WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN:
* asterixdb
* hyracks-fullstack

PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2417
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic02b456826ae7abc2619a7eec3f90b48717b0adb
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2227][ING] Enabling filitering incoming data in feed

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2227][ING] Enabling filitering incoming data in feed
..


Patch Set 16:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/2821/
 (9/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2255
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0b3cc6fe9d7fb5f5645dd9c759da448bfe1e88f1
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][NET] Networking Improvements

2018-02-22 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [NO ISSUE][NET] Networking Improvements
..


Patch Set 3: Contrib-2

Analytics Compatibility Tests Failed
https://goo.gl/FJG2D1 : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2418
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Murtadha Hubail 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2227][ING] Enabling filitering incoming data in feed

2018-02-22 Thread Anon. E. Moose (Code Review)
Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-2227][ING] Enabling filitering incoming data in feed
..


Patch Set 16: Contrib-2

Analytics Compatibility Tests Failed
https://goo.gl/vQQ9nj : UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2255
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0b3cc6fe9d7fb5f5645dd9c759da448bfe1e88f1
Gerrit-PatchSet: 16
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Xikui Wang 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...

2018-02-22 Thread Taewoo Kim (Code Review)
Taewoo Kim has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/2419

Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield 
type
..

[ASTERIXDB-2296][COMP] proper handling of an optional subfield type

- user-model changes: no
- storage format changes: no
- interface changes: no

Details:
- Handle an optional subfield type properly in
  AbstractIntroduceAccessMethodRule.getFieldNameFromSubTree()

Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries/filter/inverted-btree-search-return-optional-field.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/filter/inverted-btree-search-return-optional-field.plan
3 files changed, 149 insertions(+), 3 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/19/2419/1

diff --git 
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java
 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java
index f4178d7..41593dc 100644
--- 
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java
+++ 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java
@@ -30,6 +30,8 @@
 
 import org.apache.asterix.common.config.DatasetConfig.DatasetType;
 import org.apache.asterix.common.config.DatasetConfig.IndexType;
+import org.apache.asterix.common.exceptions.CompilationException;
+import org.apache.asterix.common.exceptions.ErrorCode;
 import org.apache.asterix.dataflow.data.common.ExpressionTypeComputer;
 import org.apache.asterix.metadata.declared.MetadataProvider;
 import org.apache.asterix.metadata.entities.Index;
@@ -40,6 +42,7 @@
 import org.apache.asterix.om.functions.BuiltinFunctions;
 import org.apache.asterix.om.types.ARecordType;
 import org.apache.asterix.om.types.ATypeTag;
+import org.apache.asterix.om.types.AUnionType;
 import org.apache.asterix.om.types.AbstractCollectionType;
 import org.apache.asterix.om.types.BuiltinType;
 import org.apache.asterix.om.types.IAType;
@@ -872,9 +875,18 @@
 }
 
 if (!isByName) {
-fieldName = sourceVar.equals(metaVar)
-? ((ARecordType) 
metaType.getSubFieldType(parentFieldNames)).getFieldNames()[fieldIndex]
-: ((ARecordType) 
recordType.getSubFieldType(parentFieldNames)).getFieldNames()[fieldIndex];
+// Sub-field type can be AUnionType in case if it's 
optional.
+IAType subFieldType = sourceVar.equals(metaVar) ? 
metaType.getSubFieldType(parentFieldNames)
+: recordType.getSubFieldType(parentFieldNames);
+if (subFieldType instanceof AUnionType) {
+subFieldType = ((AUnionType) 
subFieldType).getActualType();
+}
+if (!(subFieldType instanceof ARecordType)) {
+throw 
CompilationException.create(ErrorCode.TYPE_CONVERT, AUnionType.class.getName(),
+ARecordType.class.getName());
+}
+fieldName = sourceVar.equals(metaVar) ? ((ARecordType) 
subFieldType).getFieldNames()[fieldIndex]
+: ((ARecordType) 
subFieldType).getFieldNames()[fieldIndex];
 }
 if (optFuncExpr != null) {
 optFuncExpr.setSourceVar(funcVarIndex, ((AssignOperator) 
op).getVariables().get(assignVarIndex));
diff --git 
a/asterixdb/asterix-app/src/test/resources/optimizerts/queries/filter/inverted-btree-search-return-optional-field.sqlpp
 
b/asterixdb/asterix-app/src/test/resources/optimizerts/queries/filter/inverted-btree-search-return-optional-field.sqlpp
new file mode 100644
index 000..3221cc3
--- /dev/null
+++ 
b/asterixdb/asterix-app/src/test/resources/optimizerts/queries/filter/inverted-btree-search-return-optional-field.sqlpp
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS 

Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield 
type
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3045/ 
(7/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2419
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield 
type
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/2786/ 
(1/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2419
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2294][FUN] Implement is_atomic()

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2294][FUN] Implement is_atomic()
..


Patch Set 2:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2761/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2416
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib979f4fe2fdce7575d13a259ac241d58d9fc6ae2
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE][STO] Move the IO threads from BufferCache to IOMa...

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [NO ISSUE][STO] Move the IO threads from BufferCache to 
IOManager
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3558/ (10/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2417
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic02b456826ae7abc2619a7eec3f90b48717b0adb
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-Reviewer: Till Westmann 
Gerrit-Reviewer: abdullah alamoudi 
Gerrit-HasComments: No


Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...

2018-02-22 Thread Jenkins (Code Review)
Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield 
type
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/2812/ 
(5/12)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2419
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No


  1   2   3   4   >