Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON
Till Westmann has posted comments on this change.
Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON
..
Patch Set 16:
(30 comments)
https://asterix-gerrit.ics.uci.edu/#/c/1885/16//COMMIT_MSG
Commit Message:
PS16, Line 7: / formatted JSON
remove this?
PS16, Line 15: , and clean-json.
remove this?
https://asterix-gerrit.ics.uci.edu/#/c/1885/16/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SessionConfig.java
File
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SessionConfig.java:
PS16, Line 163: oplpfmt
Fix the comment and move it to the constructor it applies to.
https://asterix-gerrit.ics.uci.edu/#/c/1885/16/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
File
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java:
PS16, Line 162: "Optimized logical plan"
If we use these strings to trigger a specific behavior, we should have then as
string constants or as enums.
Line 173:
Remove the empty line?
https://asterix-gerrit.ics.uci.edu/#/c/1885/16/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java
File
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java:
Line 21:
remove the empty line?
PS16, Line 109: .equalsIgnoreCase("String") ? "STRING" : "JSON"
Could this be done inside PlanFormat.get? I.e. could we just pass the request
parameter in and have PlanFormat.get do all normalization work?
https://asterix-gerrit.ics.uci.edu/#/c/1885/16/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java
File
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java:
PS16, Line 113: OPTIMIZED_PLAN_FORMAT("optimized-plan-format")
remove this?
PS16, Line 165: String lpfmt;
: String oplpfmt;
can these be removed?
PS16, Line 237: SessionConfig sessionConfig =
: new SessionConfig(format);
make this a single line?
https://asterix-gerrit.ics.uci.edu/#/c/1885/16/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RestApiServlet.java
File
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RestApiServlet.java:
Line 21:
remove the empty line?
PS16, Line 97: .equalsIgnoreCase("STRING") ? "STRING" : "JSON
Same question as before.
Line 100: PlanFormat planFormat = PlanFormat.STRING;
> MAJOR SonarQube violation:
+1
PS16, Line 126: SessionConfig sessionConfig =
: new SessionConfig(format, planFormat);
make this a single line?
https://asterix-gerrit.ics.uci.edu/#/c/1885/16/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/java/AsterixJavaClient.java
File
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/java/AsterixJavaClient.java:
Line 94: boolean printOptimizedPlan, boolean printPhysicalOpsOnly,
boolean generateBinaryRuntime, boolean printJob, PlanFormat pformat)
> MAJOR SonarQube violation:
+1
https://asterix-gerrit.ics.uci.edu/#/c/1885/16/asterixdb/asterix-app/src/main/java/org/apache/asterix/drivers/AsterixClientDriver.java
File
asterixdb/asterix-app/src/main/java/org/apache/asterix/drivers/AsterixClientDriver.java:
PS16, Line 67: =
This formatting seems inconsistent with the one above.
https://asterix-gerrit.ics.uci.edu/#/c/1885/16/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/jsonplan/JsonLogicalPlanTest.java
File
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/jsonplan/JsonLogicalPlanTest.java:
PS16, Line 63:
Fix the formatting for the file?
PS16, Line 231:
:
remove the empty lines here as well?
https://asterix-gerrit.ics.uci.edu/#/c/1885/16/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractLogicalOperator.java
File
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractLogicalOperator.java:
PS16, Line 68: operatorID
Should this be a property of the Operator or a property of the plan generation
(i.e. should we keep the mapping from operator to id outside in the plan
generator)?
Line 87:
remove this empty line?
https://asterix-gerrit.ics.uci.edu/#/c/1885/16/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractOperatorWithNestedPlans.java
File
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractOperatorWithNestedPlans.java:
Line 27: import
org.apache.hyracks.algebricks.core.algebra.base.ILogicalOperator;
Revert the file as there are not semantic changes.
https://asterix-gerrit.ics.uci.edu/#/c/1885/16/hyracks-fullstack/al
Change in asterixdb[master]: Refactoring LSM operations codebase
Jenkins has posted comments on this change. Change subject: Refactoring LSM operations codebase .. Patch Set 4: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/2014 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Refactoring LSM operations codebase
Jenkins has posted comments on this change. Change subject: Refactoring LSM operations codebase .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6443/ (1/9) -- To view, visit https://asterix-gerrit.ics.uci.edu/2014 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Refactoring LSM operations codebase
Jenkins has posted comments on this change. Change subject: Refactoring LSM operations codebase .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1621/ (9/9) -- To view, visit https://asterix-gerrit.ics.uci.edu/2014 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Refactoring LSM operations codebase
Jenkins has posted comments on this change. Change subject: Refactoring LSM operations codebase .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/887/ (3/9) -- To view, visit https://asterix-gerrit.ics.uci.edu/2014 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Refactoring LSM operations codebase
Jenkins has posted comments on this change. Change subject: Refactoring LSM operations codebase .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/892/ (2/9) -- To view, visit https://asterix-gerrit.ics.uci.edu/2014 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Refactoring LSM operations codebase
Jenkins has posted comments on this change. Change subject: Refactoring LSM operations codebase .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/892/ (6/9) -- To view, visit https://asterix-gerrit.ics.uci.edu/2014 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Refactoring LSM operations codebase
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2014 to look at the new patch set (#4). Change subject: Refactoring LSM operations codebase .. Refactoring LSM operations codebase Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e --- M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMBTreeIOOperationCallback.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/ioopcallbacks/LSMBTreeWithBuddyIOOperationCallback.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/ExternalBTree.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/ExternalBTreeWithBuddy.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTree.java D hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeBulkLoader.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeDiskComponent.java D hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeDiskComponentBulkLoader.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeDiskComponentFactory.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeDiskComponentScanCursor.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreePointSearchCursor.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeRangeSearchCursor.java A hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeWithBloomFilterDiskComponent.java A hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeWithBloomFilterDiskComponentFactory.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeWithBuddyAbstractCursor.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeWithBuddyDiskComponent.java D hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeWithBuddyDiskComponentBulkLoader.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeWithBuddyDiskComponentFactory.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBuddyBTreeMergeCursor.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMDiskComponent.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMDiskComponentBulkLoader.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMDiskComponentFactory.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMDiskComponent.java D hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMDiskComponentBulkLoader.java D hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMDiskComponentWithBuddyBulkLoader.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/AbstractLSMIndex.java A hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/BloomFilterBulkLoaderBuilder.java A hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/ChainedLSMComponentBulkLoader.java M hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/ExternalIndexHarness.java A hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/FilterBulkLoaderBuilder.java A hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/IChainedLSMComponentBulkLoader.java A
Change in asterixdb[master]: Refactoring LSM operations codebase
Jenkins has posted comments on this change. Change subject: Refactoring LSM operations codebase .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1227/ (7/9) -- To view, visit https://asterix-gerrit.ics.uci.edu/2014 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Refactoring LSM operations codebase
Jenkins has posted comments on this change. Change subject: Refactoring LSM operations codebase .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/1807/ (5/9) -- To view, visit https://asterix-gerrit.ics.uci.edu/2014 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Refactoring LSM operations codebase
Jenkins has posted comments on this change. Change subject: Refactoring LSM operations codebase .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1504/ (8/9) -- To view, visit https://asterix-gerrit.ics.uci.edu/2014 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: Refactoring LSM operations codebase
Jenkins has posted comments on this change. Change subject: Refactoring LSM operations codebase .. Patch Set 4: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1565/ (4/9) -- To view, visit https://asterix-gerrit.ics.uci.edu/2014 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6739d751b990e7a28e03e32a5de6e2b670d37a1e Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ildar Absalyamov Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required .. Patch Set 18: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3967/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/1880 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a25 Gerrit-PatchSet: 18 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON
Jenkins has posted comments on this change. Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON .. Patch Set 16: Integration-Tests-1 Integration Tests Timed Out https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3966/ : ABORTED -- To view, visit https://asterix-gerrit.ics.uci.edu/1885 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357 Gerrit-PatchSet: 16 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: shi...@uci.edu Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Shiva Jahangiri Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2015][IDX] Introduce Secondary Primary Index
Ali Alsuliman has posted comments on this change. Change subject: [ASTERIXDB-2015][IDX] Introduce Secondary Primary Index .. Patch Set 8: (8 comments) https://asterix-gerrit.ics.uci.edu/#/c/1916/12//COMMIT_MSG Commit Message: PS12, Line 20: enforeced > enforced Done https://asterix-gerrit.ics.uci.edu/#/c/1916/12/asterixdb/asterix-lang-aql/src/main/javacc/AQL.jj File asterixdb/asterix-lang-aql/src/main/javacc/AQL.jj: PS12, Line 604: indexName = Identifier() ifNotExists = IfNotExists() : | : ifNotExists = IfNotExists() (indexName = Identifier())? > Let's only have the index creation option that's consistent with the one ab Done PS12, Line 613: + > WS around the "+"? Done https://asterix-gerrit.ics.uci.edu/#/c/1916/12/asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj File asterixdb/asterix-lang-sqlpp/src/main/javacc/SQLPP.jj: PS12, Line 650: indexName = Identifier() ifNotExists = IfNotExists() : | : ifNotExists = IfNotExists() (indexName = Identifier())? > Let's only have the index creation option that's consistent with the one ab Done https://asterix-gerrit.ics.uci.edu/#/c/1916/14/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/Index.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/entities/Index.java: Line 146: > Why have these checks here? Can we instead disallow secondary primary index Yes, we could put checks in "QueryTranslator.handleCreateIndexStatement" to only allow primary index on internal datasets and remove this method altogether. In this case, keyFieldNames.isEmpty() would always imply that the index is primary index. https://asterix-gerrit.ics.uci.edu/#/c/1916/14/hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/FixReplicateOperatorOutputsRule.java File hyracks-fullstack/algebricks/algebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/rules/FixReplicateOperatorOutputsRule.java: Line 123: > There's no guarantee that the "old parent" is still in the query plan. (i.e Yes, when replicate/split operators hold references to their outputs (i.e. parents in the logical plan), it makes them prone to errors and a source of problems. Besides, using them, as they are now, requires some work and caution. The "outputs" variable is an ArrayList while "outputMaterializationFlags" is a static array. That means, if the operators are not used/maintained correctly, the "outputs" could outgrow its counterpart "outputMaterializationFlags". So, what if, instead, we delete all outputs of replicate/split operators at first. Then, as we traverse the plan and encounter the "real" parents, we add them to the list "outputs"? There is one hidden assumption here, the "real" parents and "outputMaterializationFlags" are in sync in terms of position in the plan and how many parents there are. https://asterix-gerrit.ics.uci.edu/#/c/1916/12/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreePointSearchCursor.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreePointSearchCursor.java: PS12, Line 66: Override > line break Done PS12, Line 190: BloomFilter > Please file an issue and submit a separate change for this. The rest of the Done -- To view, visit https://asterix-gerrit.ics.uci.edu/1916 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59725425ba7c5fe438507dc900f83eaab239d296 Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ali Alsuliman Gerrit-Reviewer: Ali Alsuliman Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Carey Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: Yingyi Bu Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: Yes
[jira] [Created] (ASTERIXDB-2100) Check if Bloom filter is available in LSMBTreePointSearchCursor
Ali Alsuliman created ASTERIXDB-2100: Summary: Check if Bloom filter is available in LSMBTreePointSearchCursor Key: ASTERIXDB-2100 URL: https://issues.apache.org/jira/browse/ASTERIXDB-2100 Project: Apache AsterixDB Issue Type: Bug Components: STO - Storage Reporter: Ali Alsuliman Currently, for LSMBTreePointSearchCursor, the assumption is that the index has a Bloom filter. A check should be there for the case when an index with no Bloom filter is using the point cursor. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required .. Patch Set 18: -Integration-Tests Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3967/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1880 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a25 Gerrit-PatchSet: 18 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON
Shiva Jahangiri has posted comments on this change.
Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON
..
Patch Set 15:
(16 comments)
https://asterix-gerrit.ics.uci.edu/#/c/1885/15/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SessionConfig.java
File
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SessionConfig.java:
PS15, Line 57: JSON,
: CLEAN_JSON,
> Is there a difference between JSON and CLEAN_JSON? Do we need both?
Only at UI they are different. Removed CLEAN_JSON from here.
Line 60: };
> Could we add a method
Done
PS15, Line 130: SessionConfig
> Could we add backwards-compatible constructors that default to the STRING f
Done
PS15, Line 152: SessionConfig
> ... and here?
Done
https://asterix-gerrit.ics.uci.edu/#/c/1885/15/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java
File
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java:
PS15, Line 237: resetOperatorID
> Why Do we need to reset an operatorId here?
We have to reset it otherwise if the same operator is used in optimized logical
plan, it uses the id set from logical plan. So I reset it after each plan.
https://asterix-gerrit.ics.uci.edu/#/c/1885/15/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java
File
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java:
PS15, Line 103: optimizedPlanFormat
> Should we call this "optimized-plan-format" as well?
I discussed with Mike about this, and the decision was to have one global
setting for both plans.
PS15, Line 114: try {
: planFormat = PlanFormat.valueOf(plan);
: } catch (IllegalArgumentException e) {
: LOGGER.log(Level.INFO, plan + ": unsupported
plan-format, using " + PlanFormat.CLEAN_JSON + " instead", e);
: // Default output format
: planFormat = PlanFormat.CLEAN_JSON;
: }
> Use the proposed method for PlanFormat here?
Done
https://asterix-gerrit.ics.uci.edu/#/c/1885/15/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RestApiServlet.java
File
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RestApiServlet.java:
PS15, Line 116: request.getParameter("plan-format")
> Reuse variable "plan" here?
Done
PS15, Line 115: try {
: if (request.getParameter("plan-format") != null) {
: planFormat =
PlanFormat.valueOf(request.getParameter("plan-format"));
: }
: } catch (IllegalArgumentException e) {
: LOGGER.log(Level.INFO, plan + ": unsupported
plan-format, using " + PlanFormat.CLEAN_JSON + " instead", e);
: // Default plan format
: planFormat = PlanFormat.CLEAN_JSON;
: }
> Use the proposed method for PlanFormat here?
Done
PS15, Line 125: request.getParameter("optimizedPlanFormat")
> Reuse variable "opPlan" here?
This part has been removed as part of a global setting for both plans.
https://asterix-gerrit.ics.uci.edu/#/c/1885/15/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/jsonplan/JsonOptimizedLogicalPlanTest.java
File
asterixdb/asterix-app/src/test/java/org/apache/asterix/test/jsonplan/JsonOptimizedLogicalPlanTest.java:
PS15, Line 40:
:
> Remove empty lines at the end of the file?
Done
https://asterix-gerrit.ics.uci.edu/#/c/1885/15/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractLogicalOperator.java
File
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractLogicalOperator.java:
PS15, Line 68: operatorID
> Why do we need an operator id? What does it represent?
OperatorID is used to help with understanding the replication. When the same
operatorID happens in the plan we are using replication.
PS15, Line 206:
> Something went wrong with the indentation here.
Done
https://asterix-gerrit.ics.uci.edu/#/c/1885/15/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitorJson.java
File
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitorJson.java:
PS15, Line 98: Override
> Reformat the file?
Done
https://asterix-gerrit.ics.uci.edu/#/c/1885/15/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/PlanPrettyPrinter.java
File
hyr
Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON
Jenkins has posted comments on this change. Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON .. Patch Set 16: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/1806/ (10/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1885 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357 Gerrit-PatchSet: 16 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: shi...@uci.edu Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Shiva Jahangiri Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON
Jenkins has posted comments on this change. Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON .. Patch Set 16: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/1885 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357 Gerrit-PatchSet: 16 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: shi...@uci.edu Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Shiva Jahangiri Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON
Jenkins has posted comments on this change. Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON .. Patch Set 16: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3966/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1885 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357 Gerrit-PatchSet: 16 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: shi...@uci.edu Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Shiva Jahangiri Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON
Jenkins has posted comments on this change. Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON .. Patch Set 16: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1564/ (7/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1885 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357 Gerrit-PatchSet: 16 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: shi...@uci.edu Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Shiva Jahangiri Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON
Jenkins has posted comments on this change. Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON .. Patch Set 16: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1226/ (3/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1885 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357 Gerrit-PatchSet: 16 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: shi...@uci.edu Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Shiva Jahangiri Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON
Jenkins has posted comments on this change. Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON .. Patch Set 16: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/4958/ (2/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1885 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357 Gerrit-PatchSet: 16 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: shi...@uci.edu Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Shiva Jahangiri Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON
Jenkins has posted comments on this change. Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON .. Patch Set 16: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/891/ (5/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1885 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357 Gerrit-PatchSet: 16 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: shi...@uci.edu Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Shiva Jahangiri Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON
Jenkins has posted comments on this change. Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON .. Patch Set 16: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6442/ (1/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1885 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357 Gerrit-PatchSet: 16 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: shi...@uci.edu Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Shiva Jahangiri Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1885 to look at the new patch set (#16). Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON .. [UI] Allow logical plan to be viewed as JSON / formatted JSON - user model changes: no - storage format changes: no - interface changes: enhancements to the web interface details: Added drop-down menu for printing logical plan and optimized logical plan in string,json, and clean-json. Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357 --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/translator/SessionConfig.java M asterixdb/asterix-app/pom.xml M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/APIFramework.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/ApiServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/QueryServiceServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/http/server/RestApiServlet.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/api/java/AsterixJavaClient.java M asterixdb/asterix-app/src/main/java/org/apache/asterix/drivers/AsterixClientDriver.java M asterixdb/asterix-app/src/main/resources/webui/querytemplate.html M asterixdb/asterix-app/src/main/resources/webui/static/css/style.css A asterixdb/asterix-app/src/test/java/org/apache/asterix/test/jsonplan/JsonLogicalPlanTest.java A asterixdb/asterix-app/src/test/java/org/apache/asterix/test/jsonplan/JsonOptimizedLogicalPlanTest.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractLogicalOperator.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AbstractOperatorWithNestedPlans.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/AggregateOperator.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitor.java A hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/LogicalOperatorPrettyPrintVisitorJson.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/prettyprint/PlanPrettyPrinter.java M hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/visitors/ILogicalOperatorVisitor.java 19 files changed, 1,224 insertions(+), 135 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/85/1885/16 -- To view, visit https://asterix-gerrit.ics.uci.edu/1885 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357 Gerrit-PatchSet: 16 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: shi...@uci.edu Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Shiva Jahangiri Gerrit-Reviewer: Till Westmann
Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON
Jenkins has posted comments on this change. Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON .. Patch Set 16: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/886/ (9/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1885 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357 Gerrit-PatchSet: 16 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: shi...@uci.edu Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Shiva Jahangiri Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON
Jenkins has posted comments on this change. Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON .. Patch Set 16: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1503/ (8/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1885 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357 Gerrit-PatchSet: 16 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: shi...@uci.edu Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Shiva Jahangiri Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON
Jenkins has posted comments on this change. Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON .. Patch Set 16: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1620/ (6/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1885 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357 Gerrit-PatchSet: 16 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: shi...@uci.edu Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Shiva Jahangiri Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [UI] Allow logical plan to be viewed as JSON / formatted JSON
Jenkins has posted comments on this change. Change subject: [UI] Allow logical plan to be viewed as JSON / formatted JSON .. Patch Set 16: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/891/ (4/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1885 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4dd62e355048a5b8a02e074049fe41e73e74e357 Gerrit-PatchSet: 16 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: shi...@uci.edu Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Shiva Jahangiri Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required .. Patch Set 18: Integration-Tests-1 Integration Tests Failed https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3965/ : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/1880 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a25 Gerrit-PatchSet: 18 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required .. Patch Set 18: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/1805/ (10/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1880 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a25 Gerrit-PatchSet: 18 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required .. Patch Set 18: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/3965/ -- To view, visit https://asterix-gerrit.ics.uci.edu/1880 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a25 Gerrit-PatchSet: 18 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required .. Patch Set 18: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1225/ (2/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1880 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a25 Gerrit-PatchSet: 18 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required .. Patch Set 18: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/890/ (5/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1880 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a25 Gerrit-PatchSet: 18 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required .. Patch Set 18: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1619/ (4/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1880 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a25 Gerrit-PatchSet: 18 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required .. Patch Set 18: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6441/ (9/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1880 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a25 Gerrit-PatchSet: 18 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required .. Patch Set 18: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/4957/ (3/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1880 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a25 Gerrit-PatchSet: 18 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/1880 to look at the new patch set (#18). Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required .. [ASTERIXDB-1984][COMP] probe-subtree init not required - user model changes: no - storage format changes: no - interface changes: no Details: - Let the IntroduceJoinAccessMethod accept arbitrary forms of sub-tree for the probe-tree. - As a result, an open-type field with an enforced-index on the probe side will not be considered for the index-nested-loop join. An explicit conversion function should be used in such case. - The surrogate-join in the InvertedIndexAccessMethod now does not need a fixed form of sub-tree. Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a25 --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodAnalysisContext.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AccessMethodUtils.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceJoinAccessMethodRule.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceSelectAccessMethodRule.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/InvertedIndexAccessMethod.java M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/OptimizableOperatorSubTree.java A asterixdb/asterix-app/src/test/resources/optimizerts/queries/btree-index-join/secondary-equi-join_04.sqlpp A asterixdb/asterix-app/src/test/resources/optimizerts/queries/btree-index-join/secondary-equi-join_05.sqlpp A asterixdb/asterix-app/src/test/resources/optimizerts/queries/btree-index-join/secondary-equi-join_06.sqlpp M asterixdb/asterix-app/src/test/resources/optimizerts/queries/meta/secondary_index-lojoin_with_meta-1.aql M asterixdb/asterix-app/src/test/resources/optimizerts/queries/meta/secondary_index-nljoin_with_meta-1.aql M asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/leftouterjoin-probe-pidx-with-join-btree-sidx_01_2.aql A asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/leftouterjoin-probe-pidx-with-join-btree-sidx_01_3.aql M asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/leftouterjoin-probe-pidx-with-join-btree-sidx_02_2.aql A asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/leftouterjoin-probe-pidx-with-join-btree-sidx_02_3.aql M asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-join_01.aql M asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-join_02.aql M asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-join_03.aql A asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-join_04.aql A asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-join_05.aql A asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-join_06.aql M asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-prefix-join_01.aql M asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-prefix-join_02.aql M asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-prefix-join_03.aql M asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-prefix-join_04.aql M asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-prefix-join_05.aql M asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-prefix-join_06.aql A asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-prefix-join_07.aql A asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-prefix-join_08.aql A asterixdb/asterix-app/src/test/resources/optimizerts/queries/nested-open-index/btree-index-join/secondary-composite-key-prefix-join_09.aql A asterixdb/asterix-app/src/test/resources
Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required .. Patch Set 18: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/890/ (8/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1880 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a25 Gerrit-PatchSet: 18 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required .. Patch Set 18: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1502/ (6/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1880 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a25 Gerrit-PatchSet: 18 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required .. Patch Set 18: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1563/ (7/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1880 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a25 Gerrit-PatchSet: 18 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required .. Patch Set 18: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/885/ (1/10) -- To view, visit https://asterix-gerrit.ics.uci.edu/1880 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a25 Gerrit-PatchSet: 18 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-Reviewer: Yingyi Bu Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required
Taewoo Kim has posted comments on this change.
Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
..
Patch Set 17:
(6 comments)
Thanks Dmitry for the initial comments.
https://asterix-gerrit.ics.uci.edu/#/c/1880/17/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceJoinAccessMethodRule.java
File
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceJoinAccessMethodRule.java:
Line 328: e.printStackTrace();
> Same. Why exception is caught and swallowed here?
Yingyi suggested that a lambda expression is more understandable for this
place. I modified the function. However, for the exception, other than choosing
this, "throw an exception" didn't help. Could you give me some hint to modify
this?
Line 335: e.printStackTrace();
> Same. Why exception is caught and swallowed here?
Yingyi suggested that a lambda expression is more understandable for this
place. I modified the function. However, for the exception, other than choosing
this, "throw an exception" didn't help. Could you give me some hint to modify
this?
Line 413: boolean leftSubTreeInitialized =
leftSubTree.initFromSubTree(joinOp.getInputs().get(0), false);
> leftSubTreeInitialized is not needed and should probably be removed because
At least we need to set the root operator of the subtree. So, that
initialization is required.
Line 421: if (leftSubTree.hasDataSourceScan() ||
rightSubTree.hasDataSourceScan()) {
> Can we remove leftSubTree.hasDataSourceScan() , because The left subtree wa
That's correct. Modified.
https://asterix-gerrit.ics.uci.edu/#/c/1880/17/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceSelectAccessMethodRule.java
File
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceSelectAccessMethodRule.java:
Line 343: } catch (Exception e) {
> What kind of exception is caught here and why is it swallowed? It didn't do
Same for the join case. I tried to change it to a lambda expression and "throw
an exception" didn't work here. Could you give me some hint?
https://asterix-gerrit.ics.uci.edu/#/c/1880/17/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/OptimizableOperatorSubTree.java
File
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/OptimizableOperatorSubTree.java:
Line 103: return true;
> Should this return 'false' because the subtree was not fully initialized? R
Makes sense. Modified.
--
To view, visit https://asterix-gerrit.ics.uci.edu/1880
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a25
Gerrit-PatchSet: 17
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Taewoo Kim
Gerrit-Reviewer: Yingyi Bu
Gerrit-HasComments: Yes
