Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE] Simplify IoUtil delete API
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE] Simplify IoUtil delete API .. Patch Set 1: Contrib-2 Analytics Compatibility Tests Failed https://goo.gl/UMs4Du : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2502 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0dabcb642fa3007b3b6e9d30be9911a22ed8f252 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE] Simplify IoUtil delete API
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE] Simplify IoUtil delete API .. Patch Set 1: Analytics Compatibility Compilation Successful https://goo.gl/bFX4Df : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2502 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0dabcb642fa3007b3b6e9d30be9911a22ed8f252 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE] Simplify IoUtil delete API
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Simplify IoUtil delete API .. Patch Set 1: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/2502 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0dabcb642fa3007b3b6e9d30be9911a22ed8f252 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE] Simplify IoUtil delete API
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Simplify IoUtil delete API .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5995/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2502 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0dabcb642fa3007b3b6e9d30be9911a22ed8f252 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE] Simplify IoUtil delete API
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Simplify IoUtil delete API .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1117/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2502 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0dabcb642fa3007b3b6e9d30be9911a22ed8f252 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE] Simplify IoUtil delete API
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Simplify IoUtil delete API .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3571/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2502 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0dabcb642fa3007b3b6e9d30be9911a22ed8f252 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE] Simplify IoUtil delete API
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Simplify IoUtil delete API .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3098/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2502 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0dabcb642fa3007b3b6e9d30be9911a22ed8f252 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE] Simplify IoUtil delete API
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Simplify IoUtil delete API .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3547/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2502 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0dabcb642fa3007b3b6e9d30be9911a22ed8f252 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE] Simplify IoUtil delete API
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Simplify IoUtil delete API .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3328/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2502 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0dabcb642fa3007b3b6e9d30be9911a22ed8f252 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE] Simplify IoUtil delete API
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Simplify IoUtil delete API .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3822/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2502 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0dabcb642fa3007b3b6e9d30be9911a22ed8f252 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE] Simplify IoUtil delete API
Michael Blow has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/2502
Change subject: [NO ISSUE] Simplify IoUtil delete API
..
[NO ISSUE] Simplify IoUtil delete API
Change-Id: I0dabcb642fa3007b3b6e9d30be9911a22ed8f252
---
M
asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/messaging/DropIndexTask.java
M
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/util/IoUtil.java
2 files changed, 14 insertions(+), 28 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/02/2502/1
diff --git
a/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/messaging/DropIndexTask.java
b/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/messaging/DropIndexTask.java
index b7f0985..4bd97c1 100644
---
a/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/messaging/DropIndexTask.java
+++
b/asterixdb/asterix-replication/src/main/java/org/apache/asterix/replication/messaging/DropIndexTask.java
@@ -52,7 +52,7 @@
final File indexFile = ioManager.resolve(file).getFile();
if (indexFile.exists()) {
File indexDir = indexFile.getParentFile();
-IoUtil.deleteDirectory(indexDir);
+IoUtil.delete(indexDir);
LOGGER.info(() -> "Deleted index: " +
indexFile.getAbsolutePath());
} else {
LOGGER.warning(() -> "Requested to delete a non-existing
index: " + indexFile.getAbsolutePath());
diff --git
a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/util/IoUtil.java
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/util/IoUtil.java
index 396c026..561d632 100644
---
a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/util/IoUtil.java
+++
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/util/IoUtil.java
@@ -46,10 +46,8 @@
/**
* Delete a file
*
- * @param fileRef
- *the file to be deleted
- * @throws HyracksDataException
- * if the file couldn't be deleted
+ * @param fileRef the file to be deleted
+ * @throws HyracksDataException if the file couldn't be deleted
*/
public static void delete(FileReference fileRef) throws
HyracksDataException {
delete(fileRef.getFile());
@@ -58,18 +56,17 @@
/**
* Delete a file
*
- * @param file
- *the file to be deleted
- * @throws HyracksDataException
- * if the file couldn't be deleted
+ * @param file the file to be deleted
+ * @throws HyracksDataException if the file couldn't be deleted
*/
public static void delete(File file) throws HyracksDataException {
try {
-if (file.isDirectory()) {
-deleteDirectory(file);
-} else {
-Files.delete(file.toPath());
+if (!file.exists()) {
+return;
+} else if (file.isDirectory() && !FileUtils.isSymlink(file)) {
+cleanDirectory(file);
}
+Files.delete(file.toPath());
} catch (NoSuchFileException | FileNotFoundException e) {
LOGGER.warn(() -> FILE_NOT_FOUND_MSG + ": " + e.getMessage(), e);
} catch (IOException e) {
@@ -80,10 +77,8 @@
/**
* Create a file on disk
*
- * @param fileRef
- *the file to create
- * @throws HyracksDataException
- * if the file already exists or if it couldn't be created
+ * @param fileRef the file to create
+ * @throws HyracksDataException if the file already exists or if it
couldn't be created
*/
public static void create(FileReference fileRef) throws
HyracksDataException {
if (fileRef.getFile().exists()) {
@@ -99,17 +94,7 @@
}
}
-public static void deleteDirectory(File directory) throws IOException {
-if (!directory.exists()) {
-return;
-}
-if (!FileUtils.isSymlink(directory)) {
-cleanDirectory(directory);
-}
-Files.delete(directory.toPath());
-}
-
-public static void cleanDirectory(final File directory) throws IOException
{
+private static void cleanDirectory(final File directory) throws
IOException {
final File[] files = verifiedListFiles(directory);
for (final File file : files) {
delete(file);
@@ -133,4 +118,5 @@
}
return files;
}
+
}
--
To view, visit https://asterix-gerrit.ics.uci.edu/2502
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0dabcb642fa3007b3b6e9d30be9911a22ed8f252
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: release-
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE] Simplify IoUtil delete API
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Simplify IoUtil delete API .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/3113/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2502 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0dabcb642fa3007b3b6e9d30be9911a22ed8f252 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE] Simplify IoUtil delete API
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Simplify IoUtil delete API .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/3023/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2502 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0dabcb642fa3007b3b6e9d30be9911a22ed8f252 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE] Simplify IoUtil delete API
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Simplify IoUtil delete API .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3642/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2502 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0dabcb642fa3007b3b6e9d30be9911a22ed8f252 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE] Simplify IoUtil delete API
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Simplify IoUtil delete API .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/3071/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2502 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0dabcb642fa3007b3b6e9d30be9911a22ed8f252 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE] Simplify IoUtil delete API
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Simplify IoUtil delete API .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8568/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2502 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0dabcb642fa3007b3b6e9d30be9911a22ed8f252 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE] Simplify IoUtil delete API
Jenkins has posted comments on this change. Change subject: [NO ISSUE] Simplify IoUtil delete API .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/7060/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2502 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0dabcb642fa3007b3b6e9d30be9911a22ed8f252 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2321][STO] Follow the contract in IIndexCursor.op...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2321][STO] Follow the contract in IIndexCursor.open calls .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5994/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2501 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19db2afd2d6ca4a2ca1056cd95ae504b2be69813 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE][RT] Report all errors on SuperActivityOperatorNod...
Michael Blow has submitted this change and it was merged.
Change subject: [NO ISSUE][RT] Report all errors on
SuperActivityOperatorNodePushable
..
[NO ISSUE][RT] Report all errors on SuperActivityOperatorNodePushable
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Currently, if a failure happens in SuperActivityOperatorNodePushable,
we only report that failure and miss the rest of the failures.
This is especially critical in case of job cancellation since we
don't know where each thread was interrupted.
- After this change, we suppress all other failures in the root
failure for reporting purposes.
Change-Id: Ibbf31dd91303ce2f606734fcccb19270875266b3
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2500
Reviewed-by: Michael Blow
Tested-by: Jenkins
Contrib: Jenkins
Integration-Tests: Jenkins
---
M
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/rewriter/runtime/SuperActivityOperatorNodePushable.java
M
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/Task.java
2 files changed, 46 insertions(+), 41 deletions(-)
Approvals:
Anon. E. Moose #1000171:
Jenkins: Verified; ; Verified
Michael Blow: Looks good to me, approved
Objections:
Jenkins: Violations found
diff --git
a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/rewriter/runtime/SuperActivityOperatorNodePushable.java
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/rewriter/runtime/SuperActivityOperatorNodePushable.java
index 83ab532..d499554 100644
---
a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/rewriter/runtime/SuperActivityOperatorNodePushable.java
+++
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/rewriter/runtime/SuperActivityOperatorNodePushable.java
@@ -27,6 +27,7 @@
import java.util.Map;
import java.util.Map.Entry;
import java.util.Queue;
+import java.util.concurrent.ArrayBlockingQueue;
import java.util.concurrent.ExecutionException;
import java.util.concurrent.Future;
import java.util.concurrent.Semaphore;
@@ -44,6 +45,7 @@
import org.apache.hyracks.api.dataflow.value.RecordDescriptor;
import org.apache.hyracks.api.exceptions.HyracksDataException;
import org.apache.hyracks.api.job.JobFlag;
+import org.apache.hyracks.api.util.ExceptionUtils;
/**
* The runtime of a SuperActivity, which internally executes a DAG of
one-to-one
@@ -193,15 +195,20 @@
}
private void runInParallel(OperatorNodePushableAction action) throws
HyracksDataException {
-List> tasks = new ArrayList<>();
+List> tasks = new
ArrayList<>(operatorNodePushablesBFSOrder.size());
+Queue failures = new
ArrayBlockingQueue<>(operatorNodePushablesBFSOrder.size());
final Semaphore startSemaphore = new Semaphore(1 -
operatorNodePushablesBFSOrder.size());
final Semaphore completeSemaphore = new Semaphore(1 -
operatorNodePushablesBFSOrder.size());
+Throwable root = null;
try {
for (final IOperatorNodePushable op :
operatorNodePushablesBFSOrder) {
tasks.add(ctx.getExecutorService().submit(() -> {
startSemaphore.release();
try {
action.run(op);
+} catch (Throwable th) { // NOSONAR: Must catch all causes
of failure
+failures.offer(th);
+throw th;
} finally {
completeSemaphore.release();
}
@@ -211,13 +218,16 @@
for (Future task : tasks) {
task.get();
}
-} catch (InterruptedException e) {
-cancelTasks(tasks, startSemaphore, completeSemaphore);
-Thread.currentThread().interrupt();
-throw HyracksDataException.create(e);
} catch (ExecutionException e) {
+root = e.getCause();
+} catch (Throwable e) { // NOSONAR: Must catch all causes of failure
+root = e;
+}
+if (root != null) {
+final Throwable failure = root;
cancelTasks(tasks, startSemaphore, completeSemaphore);
-throw HyracksDataException.create(e.getCause());
+failures.forEach(t -> ExceptionUtils.suppress(failure, t));
+throw HyracksDataException.create(failure);
}
}
diff --git
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/Task.java
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/Task.java
index dcfc291..9d99968 100644
---
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/Task.java
+++
b/hyracks-f
Change in asterixdb[master]: [NO ISSUE][RT] Report all errors on SuperActivityOperatorNod...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Report all errors on SuperActivityOperatorNodePushable .. Patch Set 8: Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5992/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2498 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbf31dd91303ce2f606734fcccb19270875266b3 Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2321][STO] Follow the contract in IIndexCursor.op...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2321][STO] Follow the contract in IIndexCursor.open calls .. Patch Set 1: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2920/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2501 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19db2afd2d6ca4a2ca1056cd95ae504b2be69813 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE][RT] Report all errors on SuperActivityOperatorNod...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Report all errors on SuperActivityOperatorNodePushable .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5993/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2500 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbf31dd91303ce2f606734fcccb19270875266b3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2321][STO] Follow the contract in IIndexCursor.op...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2321][STO] Follow the contract in IIndexCursor.open calls .. Patch Set 1: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2920/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2501 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19db2afd2d6ca4a2ca1056cd95ae504b2be69813 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2321][STO] Follow the contract in IIndexCursor.op...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2321][STO] Follow the contract in IIndexCursor.open calls .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5994/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2501 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19db2afd2d6ca4a2ca1056cd95ae504b2be69813 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE][RT] Report all errors on SuperActivityOperatorNod...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Report all errors on SuperActivityOperatorNodePushable .. Patch Set 1: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2919/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2500 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbf31dd91303ce2f606734fcccb19270875266b3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2321][STO] Follow the contract in IIndexCursor.op...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2321][STO] Follow the contract in IIndexCursor.open calls .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3570/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2501 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19db2afd2d6ca4a2ca1056cd95ae504b2be69813 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE][RT] Report all errors on SuperActivityOperatorNod...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Report all errors on SuperActivityOperatorNodePushable .. Patch Set 1: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2919/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2500 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbf31dd91303ce2f606734fcccb19270875266b3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE][RT] Report all errors on SuperActivityOperatorNod...
Michael Blow has posted comments on this change. Change subject: [NO ISSUE][RT] Report all errors on SuperActivityOperatorNodePushable .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2500 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbf31dd91303ce2f606734fcccb19270875266b3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2321][STO] Follow the contract in IIndexCursor.op...
Michael Blow has posted comments on this change. Change subject: [ASTERIXDB-2321][STO] Follow the contract in IIndexCursor.open calls .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2501 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19db2afd2d6ca4a2ca1056cd95ae504b2be69813 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2321][STO] Follow the contract in IIndexCursor.op...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2321][STO] Follow the contract in IIndexCursor.open calls .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3546/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2501 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19db2afd2d6ca4a2ca1056cd95ae504b2be69813 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2321][STO] Follow the contract in IIndexCursor.op...
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2321][STO] Follow the contract in IIndexCursor.open calls .. Patch Set 1: Contrib-2 Analytics Compatibility Tests Failed https://goo.gl/Ka7Y6w : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2501 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19db2afd2d6ca4a2ca1056cd95ae504b2be69813 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE][RT] Report all errors on SuperActivityOperatorNod...
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][RT] Report all errors on SuperActivityOperatorNodePushable .. Patch Set 1: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/r1dLCk : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2500 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbf31dd91303ce2f606734fcccb19270875266b3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][RT] Remove runtime from ActiveManager after it stops
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Remove runtime from ActiveManager after it stops .. Patch Set 2: BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2918/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2494 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I07c6398f46d4bb6d29b270aa71dee36e0d0917ae Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][RT] Remove runtime from ActiveManager after it stops
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Remove runtime from ActiveManager after it stops .. Patch Set 2: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2918/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2494 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I07c6398f46d4bb6d29b270aa71dee36e0d0917ae Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2321][STO] Follow the contract in IIndexCursor.op...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2321][STO] Follow the contract in IIndexCursor.open calls .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3821/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2501 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19db2afd2d6ca4a2ca1056cd95ae504b2be69813 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE][RT] Report all errors on SuperActivityOperatorNod...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Report all errors on SuperActivityOperatorNodePushable .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5993/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2500 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbf31dd91303ce2f606734fcccb19270875266b3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1708] Prevent log deletion during scan
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1708] Prevent log deletion during scan .. Patch Set 12: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5991/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2256 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icff1a520af24c8fac8e5836cdbf46425b78b1260 Gerrit-PatchSet: 12 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE][RT] Report all errors on SuperActivityOperatorNod...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Report all errors on SuperActivityOperatorNodePushable .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3569/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2500 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbf31dd91303ce2f606734fcccb19270875266b3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2321][STO] Follow the contract in IIndexCursor.op...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2321][STO] Follow the contract in IIndexCursor.open calls .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/3112/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2501 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19db2afd2d6ca4a2ca1056cd95ae504b2be69813 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2321][STO] Follow the contract in IIndexCursor.op...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2321][STO] Follow the contract in IIndexCursor.open calls .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1116/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2501 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19db2afd2d6ca4a2ca1056cd95ae504b2be69813 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2321][STO] Follow the contract in IIndexCursor.op...
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2321][STO] Follow the contract in IIndexCursor.open calls .. Patch Set 1: Analytics Compatibility Compilation Successful https://goo.gl/uhLZjH : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2501 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19db2afd2d6ca4a2ca1056cd95ae504b2be69813 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE][RT] Report all errors on SuperActivityOperatorNod...
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][RT] Report all errors on SuperActivityOperatorNodePushable .. Patch Set 1: Analytics Compatibility Compilation Successful https://goo.gl/e4vWdV : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2500 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbf31dd91303ce2f606734fcccb19270875266b3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2321][STO] Follow the contract in IIndexCursor.op...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2321][STO] Follow the contract in IIndexCursor.open calls .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3327/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2501 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19db2afd2d6ca4a2ca1056cd95ae504b2be69813 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2321][STO] Follow the contract in IIndexCursor.op...
abdullah alamoudi has abandoned this change. Change subject: [ASTERIXDB-2321][STO] Follow the contract in IIndexCursor.open calls .. Abandoned changed branch -- To view, visit https://asterix-gerrit.ics.uci.edu/2496 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I19db2afd2d6ca4a2ca1056cd95ae504b2be69813 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi
Change in asterixdb[master]: [NO ISSUE][RT] Report all errors on SuperActivityOperatorNod...
abdullah alamoudi has abandoned this change. Change subject: [NO ISSUE][RT] Report all errors on SuperActivityOperatorNodePushable .. Abandoned changed branch -- To view, visit https://asterix-gerrit.ics.uci.edu/2498 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ibbf31dd91303ce2f606734fcccb19270875266b3 Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2321][STO] Follow the contract in IIndexCursor.op...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2321][STO] Follow the contract in IIndexCursor.open calls .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/7059/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2501 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19db2afd2d6ca4a2ca1056cd95ae504b2be69813 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2321][STO] Follow the contract in IIndexCursor.op...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2321][STO] Follow the contract in IIndexCursor.open calls .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/3022/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2501 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19db2afd2d6ca4a2ca1056cd95ae504b2be69813 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2321][STO] Follow the contract in IIndexCursor.op...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2321][STO] Follow the contract in IIndexCursor.open calls .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3641/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2501 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19db2afd2d6ca4a2ca1056cd95ae504b2be69813 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2321][STO] Follow the contract in IIndexCursor.op...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2321][STO] Follow the contract in IIndexCursor.open calls .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8567/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2501 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19db2afd2d6ca4a2ca1056cd95ae504b2be69813 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2321][STO] Follow the contract in IIndexCursor.op...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2321][STO] Follow the contract in IIndexCursor.open calls .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/3070/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2501 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19db2afd2d6ca4a2ca1056cd95ae504b2be69813 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2321][STO] Follow the contract in IIndexCursor.op...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2321][STO] Follow the contract in IIndexCursor.open calls .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3097/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2501 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19db2afd2d6ca4a2ca1056cd95ae504b2be69813 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [ASTERIXDB-2321][STO] Follow the contract in IIndexCursor.op...
abdullah alamoudi has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/2501
Change subject: [ASTERIXDB-2321][STO] Follow the contract in IIndexCursor.open
calls
..
[ASTERIXDB-2321][STO] Follow the contract in IIndexCursor.open calls
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- The index cursor contract says that an open call which returns
successfully, leaves the cursor in the open state, otherwise,
the cursor remains in the closed state.
- The LSM cursors have many cursors inside. In the
case where one of the cursors fails to open, and an exception
is about to be thrown, we must close all previously open cursors
since the LSM cursor will be in the closed state
and close will not be called.
Change-Id: I19db2afd2d6ca4a2ca1056cd95ae504b2be69813
---
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeDiskComponentScanCursor.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeRangeSearchCursor.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeWithBuddySortedCursor.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBuddyBTreeMergeCursor.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/api/ILSMIndex.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/impls/LSMInvertedIndexDeletedKeysBTreeMergeCursor.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/LSMRTreeDeletedKeysBTreeMergeCursor.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/LSMRTreeSortedCursor.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/LSMRTreeWithAntiMatterTuplesFlushCursor.java
M
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-rtree/src/main/java/org/apache/hyracks/storage/am/lsm/rtree/impls/LSMRTreeWithAntiMatterTuplesSearchCursor.java
A
hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/util/IndexCursorUtils.java
11 files changed, 223 insertions(+), 55 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/01/2501/1
diff --git
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeDiskComponentScanCursor.java
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeDiskComponentScanCursor.java
index a120296..a6c8393 100644
---
a/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeDiskComponentScanCursor.java
+++
b/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeDiskComponentScanCursor.java
@@ -40,6 +40,7 @@
import org.apache.hyracks.storage.common.IIndexCursor;
import org.apache.hyracks.storage.common.ISearchPredicate;
import org.apache.hyracks.storage.common.MultiComparator;
+import org.apache.hyracks.storage.common.util.IndexCursorUtils;
public class LSMBTreeDiskComponentScanCursor extends LSMIndexSearchCursor {
@@ -77,15 +78,20 @@
BTree btree = (BTree) component.getIndex();
btreeAccessors[i] =
btree.createAccessor(NoOpIndexAccessParameters.INSTANCE);
rangeCursors[i] = btreeAccessors[i].createSearchCursor(false);
-btreeAccessors[i].search(rangeCursors[i], searchPred);
}
-
-cursorIndexPointable = new IntegerPointable();
-int length = IntegerPointable.TYPE_TRAITS.getFixedLength();
-cursorIndexPointable.set(new byte[length], 0, length);
-
-setPriorityQueueComparator();
-initPriorityQueue();
+IndexCursorUtils.open(btreeAccessors, rangeCursors, searchPred);
+try {
+cursorIndexPointable = new IntegerPointable();
+int length = IntegerPointable.TYPE_TRAITS.getFixedLength();
+cursorIndexPointable.set(new byte[length], 0, length);
+setPriorityQueueComparator();
+initPriorityQueue();
+} catch (Throwable th) { // NOSONAR: Must call this on
+for (int i = 0; i < numBTrees; i++) {
+IndexCursorUtils.close(rangeCursors[i], th);
+}
+throw HyracksDataException.create(th);
+}
}
@Override
diff --git
a/hyracks-fullstac
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE][RT] Report all errors on SuperActivityOperatorNod...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Report all errors on SuperActivityOperatorNodePushable .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3096/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2500 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbf31dd91303ce2f606734fcccb19270875266b3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE][RT] Report all errors on SuperActivityOperatorNod...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Report all errors on SuperActivityOperatorNodePushable .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3640/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2500 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbf31dd91303ce2f606734fcccb19270875266b3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE][RT] Report all errors on SuperActivityOperatorNod...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Report all errors on SuperActivityOperatorNodePushable .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8566/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2500 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbf31dd91303ce2f606734fcccb19270875266b3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE][RT] Report all errors on SuperActivityOperatorNod...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Report all errors on SuperActivityOperatorNodePushable .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/7058/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2500 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbf31dd91303ce2f606734fcccb19270875266b3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE][RT] Report all errors on SuperActivityOperatorNod...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Report all errors on SuperActivityOperatorNodePushable .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3820/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2500 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbf31dd91303ce2f606734fcccb19270875266b3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE][RT] Report all errors on SuperActivityOperatorNod...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Report all errors on SuperActivityOperatorNodePushable .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/3069/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2500 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbf31dd91303ce2f606734fcccb19270875266b3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE][RT] Report all errors on SuperActivityOperatorNod...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Report all errors on SuperActivityOperatorNodePushable .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1115/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2500 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbf31dd91303ce2f606734fcccb19270875266b3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE][RT] Report all errors on SuperActivityOperatorNod...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Report all errors on SuperActivityOperatorNodePushable .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3326/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2500 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbf31dd91303ce2f606734fcccb19270875266b3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE][RT] Report all errors on SuperActivityOperatorNod...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Report all errors on SuperActivityOperatorNodePushable .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/3111/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2500 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbf31dd91303ce2f606734fcccb19270875266b3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE][RT] Report all errors on SuperActivityOperatorNod...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Report all errors on SuperActivityOperatorNodePushable .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/3021/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2500 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbf31dd91303ce2f606734fcccb19270875266b3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE][RT] Report all errors on SuperActivityOperatorNod...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Report all errors on SuperActivityOperatorNodePushable .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3545/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2500 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbf31dd91303ce2f606734fcccb19270875266b3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE][RT] Report all errors on SuperActivityOperatorNod...
abdullah alamoudi has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/2500
Change subject: [NO ISSUE][RT] Report all errors on
SuperActivityOperatorNodePushable
..
[NO ISSUE][RT] Report all errors on SuperActivityOperatorNodePushable
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Currently, if a failure happens in SuperActivityOperatorNodePushable,
we only report that failure and miss the rest of the failures.
This is especially critical in case of job cancellation since we
don't know where each thread was interrupted.
- After this change, we suppress all other failures in the root
failure for reporting purposes.
Change-Id: Ibbf31dd91303ce2f606734fcccb19270875266b3
---
M
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/rewriter/runtime/SuperActivityOperatorNodePushable.java
M
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/Task.java
2 files changed, 46 insertions(+), 41 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/00/2500/1
diff --git
a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/rewriter/runtime/SuperActivityOperatorNodePushable.java
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/rewriter/runtime/SuperActivityOperatorNodePushable.java
index 83ab532..d499554 100644
---
a/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/rewriter/runtime/SuperActivityOperatorNodePushable.java
+++
b/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/rewriter/runtime/SuperActivityOperatorNodePushable.java
@@ -27,6 +27,7 @@
import java.util.Map;
import java.util.Map.Entry;
import java.util.Queue;
+import java.util.concurrent.ArrayBlockingQueue;
import java.util.concurrent.ExecutionException;
import java.util.concurrent.Future;
import java.util.concurrent.Semaphore;
@@ -44,6 +45,7 @@
import org.apache.hyracks.api.dataflow.value.RecordDescriptor;
import org.apache.hyracks.api.exceptions.HyracksDataException;
import org.apache.hyracks.api.job.JobFlag;
+import org.apache.hyracks.api.util.ExceptionUtils;
/**
* The runtime of a SuperActivity, which internally executes a DAG of
one-to-one
@@ -193,15 +195,20 @@
}
private void runInParallel(OperatorNodePushableAction action) throws
HyracksDataException {
-List> tasks = new ArrayList<>();
+List> tasks = new
ArrayList<>(operatorNodePushablesBFSOrder.size());
+Queue failures = new
ArrayBlockingQueue<>(operatorNodePushablesBFSOrder.size());
final Semaphore startSemaphore = new Semaphore(1 -
operatorNodePushablesBFSOrder.size());
final Semaphore completeSemaphore = new Semaphore(1 -
operatorNodePushablesBFSOrder.size());
+Throwable root = null;
try {
for (final IOperatorNodePushable op :
operatorNodePushablesBFSOrder) {
tasks.add(ctx.getExecutorService().submit(() -> {
startSemaphore.release();
try {
action.run(op);
+} catch (Throwable th) { // NOSONAR: Must catch all causes
of failure
+failures.offer(th);
+throw th;
} finally {
completeSemaphore.release();
}
@@ -211,13 +218,16 @@
for (Future task : tasks) {
task.get();
}
-} catch (InterruptedException e) {
-cancelTasks(tasks, startSemaphore, completeSemaphore);
-Thread.currentThread().interrupt();
-throw HyracksDataException.create(e);
} catch (ExecutionException e) {
+root = e.getCause();
+} catch (Throwable e) { // NOSONAR: Must catch all causes of failure
+root = e;
+}
+if (root != null) {
+final Throwable failure = root;
cancelTasks(tasks, startSemaphore, completeSemaphore);
-throw HyracksDataException.create(e.getCause());
+failures.forEach(t -> ExceptionUtils.suppress(failure, t));
+throw HyracksDataException.create(failure);
}
}
diff --git
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/Task.java
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/Task.java
index dcfc291..9d99968 100644
---
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/Task.java
+++
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/Task.java
@@ -102,7 +102,7 @@
private volatile boolean aborted;
-priv
Change in asterixdb[master]: [ASTERIXDB-1708] Prevent log deletion during scan
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-1708] Prevent log deletion during scan .. Patch Set 12: Contrib-2 Analytics Compatibility Tests Failed https://goo.gl/wwNKSw : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2256 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icff1a520af24c8fac8e5836cdbf46425b78b1260 Gerrit-PatchSet: 12 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1708] Prevent log deletion during scan
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1708] Prevent log deletion during scan .. Patch Set 12: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2917/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2256 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icff1a520af24c8fac8e5836cdbf46425b78b1260 Gerrit-PatchSet: 12 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1708] Prevent log deletion during scan
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1708] Prevent log deletion during scan .. Patch Set 12: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2917/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2256 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icff1a520af24c8fac8e5836cdbf46425b78b1260 Gerrit-PatchSet: 12 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][RT] Report all errors on SuperActivityOperatorNod...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Report all errors on SuperActivityOperatorNodePushable .. Patch Set 8: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5992/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2498 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbf31dd91303ce2f606734fcccb19270875266b3 Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1708] Prevent log deletion during scan
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-1708] Prevent log deletion during scan .. Patch Set 12: Analytics Compatibility Compilation Successful https://goo.gl/shSPhy : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2256 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icff1a520af24c8fac8e5836cdbf46425b78b1260 Gerrit-PatchSet: 12 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1708] Prevent log deletion during scan
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1708] Prevent log deletion during scan .. Patch Set 12: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5991/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2256 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icff1a520af24c8fac8e5836cdbf46425b78b1260 Gerrit-PatchSet: 12 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1708] Prevent log deletion during scan
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2256 to look at the new patch set (#12). Change subject: [ASTERIXDB-1708] Prevent log deletion during scan .. [ASTERIXDB-1708] Prevent log deletion during scan Right now there is a potential for a soft checkpoint to delete a log file that is about to be read as part of a transaction rollback. This patch stops the soft checkpoint from proceeding if a rollback is about to take place and vice-versa. Change-Id: Icff1a520af24c8fac8e5836cdbf46425b78b1260 --- M asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/RecoveryManager.java M asterixdb/asterix-app/src/test/java/org/apache/asterix/test/logging/CheckpointingTest.java M asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/ICheckpointManager.java M asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogManager.java M asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/recovery/AbstractCheckpointManager.java M asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/recovery/CheckpointManager.java M asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/transaction/TransactionManager.java 7 files changed, 180 insertions(+), 74 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/56/2256/12 -- To view, visit https://asterix-gerrit.ics.uci.edu/2256 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Icff1a520af24c8fac8e5836cdbf46425b78b1260 Gerrit-PatchSet: 12 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi
Change in asterixdb[master]: [ASTERIXDB-1708] Prevent log deletion during scan
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1708] Prevent log deletion during scan .. Patch Set 12: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/7057/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2256 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icff1a520af24c8fac8e5836cdbf46425b78b1260 Gerrit-PatchSet: 12 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1708] Prevent log deletion during scan
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1708] Prevent log deletion during scan .. Patch Set 12: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/3068/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2256 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icff1a520af24c8fac8e5836cdbf46425b78b1260 Gerrit-PatchSet: 12 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1708] Prevent log deletion during scan
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1708] Prevent log deletion during scan .. Patch Set 12: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3095/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2256 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icff1a520af24c8fac8e5836cdbf46425b78b1260 Gerrit-PatchSet: 12 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1708] Prevent log deletion during scan
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1708] Prevent log deletion during scan .. Patch Set 12: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/1114/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2256 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icff1a520af24c8fac8e5836cdbf46425b78b1260 Gerrit-PatchSet: 12 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1708] Prevent log deletion during scan
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1708] Prevent log deletion during scan .. Patch Set 12: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/3020/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2256 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icff1a520af24c8fac8e5836cdbf46425b78b1260 Gerrit-PatchSet: 12 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1708] Prevent log deletion during scan
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1708] Prevent log deletion during scan .. Patch Set 12: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3568/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2256 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icff1a520af24c8fac8e5836cdbf46425b78b1260 Gerrit-PatchSet: 12 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1708] Prevent log deletion during scan
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1708] Prevent log deletion during scan .. Patch Set 12: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3544/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2256 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icff1a520af24c8fac8e5836cdbf46425b78b1260 Gerrit-PatchSet: 12 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1708] Prevent log deletion during scan
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1708] Prevent log deletion during scan .. Patch Set 12: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3639/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2256 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icff1a520af24c8fac8e5836cdbf46425b78b1260 Gerrit-PatchSet: 12 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1708] Prevent log deletion during scan
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1708] Prevent log deletion during scan .. Patch Set 12: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8565/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2256 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icff1a520af24c8fac8e5836cdbf46425b78b1260 Gerrit-PatchSet: 12 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1708] Prevent log deletion during scan
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1708] Prevent log deletion during scan .. Patch Set 12: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/3110/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2256 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icff1a520af24c8fac8e5836cdbf46425b78b1260 Gerrit-PatchSet: 12 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1708] Prevent log deletion during scan
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1708] Prevent log deletion during scan .. Patch Set 12: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3819/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2256 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icff1a520af24c8fac8e5836cdbf46425b78b1260 Gerrit-PatchSet: 12 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1708] Prevent log deletion during scan
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1708] Prevent log deletion during scan .. Patch Set 12: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3325/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2256 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icff1a520af24c8fac8e5836cdbf46425b78b1260 Gerrit-PatchSet: 12 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1708] Prevent log deletion during scan
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1708] Prevent log deletion during scan .. Patch Set 11: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5990/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2256 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icff1a520af24c8fac8e5836cdbf46425b78b1260 Gerrit-PatchSet: 11 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1708] Prevent log deletion during scan
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-1708] Prevent log deletion during scan .. Patch Set 11: Contrib-2 Analytics Compatibility Tests Failed https://goo.gl/pr5PF6 : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2256 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icff1a520af24c8fac8e5836cdbf46425b78b1260 Gerrit-PatchSet: 11 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TX] Log LogBufferTailReader Read Failures
Murtadha Hubail has submitted this change and it was merged.
Change subject: [NO ISSUE][TX] Log LogBufferTailReader Read Failures
..
[NO ISSUE][TX] Log LogBufferTailReader Read Failures
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- on read failures, include the read attempt status
and the last log record that was read.
Change-Id: Iba2edd8808e1d6de33b1b0fedd27263d99171b39
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2499
Sonar-Qube: Jenkins
Reviewed-by: Michael Blow
Tested-by: Jenkins
Contrib: Jenkins
---
M asterixdb/asterix-transactions/pom.xml
M
asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogBufferTailReader.java
A
asterixdb/asterix-transactions/src/test/java/org/apache/asterix/transaction/management/service/locking/LogBufferTailReaderTest.java
M asterixdb/pom.xml
4 files changed, 68 insertions(+), 1 deletion(-)
Approvals:
Jenkins: Verified; No violations found;
Michael Blow: Looks good to me, approved
Objections:
Anon. E. Moose #1000171: Violations found
diff --git a/asterixdb/asterix-transactions/pom.xml
b/asterixdb/asterix-transactions/pom.xml
index ad044cb..07dcf5d 100644
--- a/asterixdb/asterix-transactions/pom.xml
+++ b/asterixdb/asterix-transactions/pom.xml
@@ -159,5 +159,9 @@
org.apache.hyracks
hyracks-util
+
+ commons-codec
+ commons-codec
+
diff --git
a/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogBufferTailReader.java
b/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogBufferTailReader.java
index 5ed5724..550b747 100644
---
a/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogBufferTailReader.java
+++
b/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogBufferTailReader.java
@@ -19,12 +19,17 @@
package org.apache.asterix.transaction.management.service.logging;
import java.nio.ByteBuffer;
+import java.util.Arrays;
import org.apache.asterix.common.transactions.ILogRecord.RecordReadStatus;
import org.apache.asterix.common.transactions.LogRecord;
+import org.apache.commons.codec.binary.Hex;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
public class LogBufferTailReader {
+private static final Logger LOGGER = LogManager.getLogger();
private final ByteBuffer buffer;
private final LogRecord logRecord;
private int endOffset;
@@ -46,8 +51,19 @@
RecordReadStatus status = logRecord.readLogRecord(buffer);
//underflow is not expected because we are at the very tail of the
current log buffer
if (status != RecordReadStatus.OK) {
-throw new IllegalStateException();
+logReadFailure(status);
+throw new IllegalStateException("Unexpected log read status: " +
status);
}
return logRecord;
}
+
+private void logReadFailure(RecordReadStatus status) {
+final int bufferRemaining = endOffset - buffer.position();
+final byte[] remainingData = new byte[bufferRemaining];
+buffer.get(remainingData);
+final char[] hexData = Hex.encodeHex(remainingData);
+LOGGER.error(
+"Unexpected read status {}, read Log: {}, buffer remaining at
read: {}, buffer remaining content: {}",
+status, bufferRemaining, logRecord.getLogRecordForDisplay(),
Arrays.toString(hexData));
+}
}
diff --git
a/asterixdb/asterix-transactions/src/test/java/org/apache/asterix/transaction/management/service/locking/LogBufferTailReaderTest.java
b/asterixdb/asterix-transactions/src/test/java/org/apache/asterix/transaction/management/service/locking/LogBufferTailReaderTest.java
new file mode 100644
index 000..3083605
--- /dev/null
+++
b/asterixdb/asterix-transactions/src/test/java/org/apache/asterix/transaction/management/service/locking/LogBufferTailReaderTest.java
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and li
Change in asterixdb[master]: [ASTERIXDB-2321][STO] Follow the contract in IIndexCursor.op...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2321][STO] Follow the contract in IIndexCursor.open calls .. Patch Set 7: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5989/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2496 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19db2afd2d6ca4a2ca1056cd95ae504b2be69813 Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][RT] Report all errors on SuperActivityOperatorNod...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Report all errors on SuperActivityOperatorNodePushable .. Patch Set 8: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2916/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2498 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbf31dd91303ce2f606734fcccb19270875266b3 Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1708] Prevent log deletion during scan
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-1708] Prevent log deletion during scan .. Patch Set 10: Contrib-2 Analytics Compatibility Tests Failed https://goo.gl/ofu9xw : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2256 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icff1a520af24c8fac8e5836cdbf46425b78b1260 Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][RT] Report all errors on SuperActivityOperatorNod...
Jenkins has posted comments on this change. Change subject: [NO ISSUE][RT] Report all errors on SuperActivityOperatorNodePushable .. Patch Set 8: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2916/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2498 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbf31dd91303ce2f606734fcccb19270875266b3 Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TX] Log LogBufferTailReader Read Failures
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TX] Log LogBufferTailReader Read Failures .. Patch Set 3: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2915/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2499 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba2edd8808e1d6de33b1b0fedd27263d99171b39 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][TX] Log LogBufferTailReader Read Failures
Jenkins has posted comments on this change. Change subject: [NO ISSUE][TX] Log LogBufferTailReader Read Failures .. Patch Set 3: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2915/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2499 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba2edd8808e1d6de33b1b0fedd27263d99171b39 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1708] Prevent log deletion during scan
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1708] Prevent log deletion during scan .. Patch Set 11: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5990/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2256 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icff1a520af24c8fac8e5836cdbf46425b78b1260 Gerrit-PatchSet: 11 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1708] Prevent log deletion during scan
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1708] Prevent log deletion during scan .. Patch Set 11: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3567/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2256 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icff1a520af24c8fac8e5836cdbf46425b78b1260 Gerrit-PatchSet: 11 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1708] Prevent log deletion during scan
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-1708] Prevent log deletion during scan .. Patch Set 11: Analytics Compatibility Compilation Successful https://goo.gl/5kc3CJ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2256 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icff1a520af24c8fac8e5836cdbf46425b78b1260 Gerrit-PatchSet: 11 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1708] Prevent log deletion during scan
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1708] Prevent log deletion during scan .. Patch Set 11: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8564/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2256 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icff1a520af24c8fac8e5836cdbf46425b78b1260 Gerrit-PatchSet: 11 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1708] Prevent log deletion during scan
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1708] Prevent log deletion during scan .. Patch Set 11: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/3094/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2256 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icff1a520af24c8fac8e5836cdbf46425b78b1260 Gerrit-PatchSet: 11 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1708] Prevent log deletion during scan
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1708] Prevent log deletion during scan .. Patch Set 11: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3543/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2256 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icff1a520af24c8fac8e5836cdbf46425b78b1260 Gerrit-PatchSet: 11 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1708] Prevent log deletion during scan
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1708] Prevent log deletion during scan .. Patch Set 11: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3324/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2256 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icff1a520af24c8fac8e5836cdbf46425b78b1260 Gerrit-PatchSet: 11 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-1708] Prevent log deletion during scan
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-1708] Prevent log deletion during scan .. Patch Set 11: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/7056/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2256 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icff1a520af24c8fac8e5836cdbf46425b78b1260 Gerrit-PatchSet: 11 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Luo Chen Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: abdullah alamoudi Gerrit-HasComments: No
