Change in asterixdb[master]: [WIP][NET] Limit Net Read Buffers
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [WIP][NET] Limit Net Read Buffers .. Patch Set 1: Analytics Compatibility Tests Failed https://goo.gl/RMB28Y : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2915 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9069f380035db3f631b370ec839845f62638dc7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Michael Blow has submitted this change and it was merged.
Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the
operation cannot be performed
..
[ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be
performed
- user model changes: yes
- storage format changes: no
- interface changes: no
Details:
- substring() should return NULL if starting offset is out of bounds
for given string or length is negative
Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2914
Sonar-Qube: Jenkins
Integration-Tests: Jenkins
Tested-by: Jenkins
Reviewed-by: Till Westmann
---
M
asterixdb/asterix-app/src/test/resources/runtimets/queries/string/substr04/substr04.3.query.aql
M
asterixdb/asterix-app/src/test/resources/runtimets/queries/string/substring2-4/substring2-4.3.query.aql
M
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/substr04/substr04.3.query.sqlpp
M
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/substring2-4/substring2-4.3.query.sqlpp
M
asterixdb/asterix-app/src/test/resources/runtimets/results/string/substr01/substr01.1.adm
M
asterixdb/asterix-app/src/test/resources/runtimets/results/string/substr04/substr04.1.adm
M
asterixdb/asterix-app/src/test/resources/runtimets/results/string/substring2-3/substring2-3.1.adm
M
asterixdb/asterix-app/src/test/resources/runtimets/results/string/substring2-4/substring2-4.1.adm
M
asterixdb/asterix-app/src/test/resources/runtimets/results/stringoffset/substring/substring.1.adm
M
asterixdb/asterix-app/src/test/resources/runtimets/results/stringoffset/substring2/substring2.1.adm
M
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/string/substr04/substr04.3.ast
M
asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/string/substring2-4/substring2-4.3.ast
M asterixdb/asterix-doc/src/main/markdown/builtins/2_string_common.md
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/BuiltinFunctions.java
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/StringIntToStringTypeComputer.java
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/SubstringTypeComputer.java
M
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/Substring2Descriptor.java
M
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/SubstringDescriptor.java
M
hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/primitive/UTF8StringPointable.java
19 files changed, 101 insertions(+), 55 deletions(-)
Approvals:
Till Westmann: Looks good to me, approved
Jenkins: Verified; No violations found; Verified
diff --git
a/asterixdb/asterix-app/src/test/resources/runtimets/queries/string/substr04/substr04.3.query.aql
b/asterixdb/asterix-app/src/test/resources/runtimets/queries/string/substr04/substr04.3.query.aql
index 1c31ea0..f792e7f 100644
---
a/asterixdb/asterix-app/src/test/resources/runtimets/queries/string/substr04/substr04.3.query.aql
+++
b/asterixdb/asterix-app/src/test/resources/runtimets/queries/string/substr04/substr04.3.query.aql
@@ -30,6 +30,9 @@
substring("ABCD", 0, 4),
substring("UC Irvine", 3, string-length("UC Irvine") - 3),
substring("UC Irvine", 0, string-length("UC Irvine")),
-substring(substring("UC Irvine", 3), 0, string-length("Irvine"))
+substring(substring("UC Irvine", 3), 0, string-length("Irvine")),
+substring('ABCD',-3,2),
+substring('ABCD',-10,1),
+substring('ABCD',1,-1)
]
return $a
diff --git
a/asterixdb/asterix-app/src/test/resources/runtimets/queries/string/substring2-4/substring2-4.3.query.aql
b/asterixdb/asterix-app/src/test/resources/runtimets/queries/string/substring2-4/substring2-4.3.query.aql
index ecfcd94..b0e8697 100644
---
a/asterixdb/asterix-app/src/test/resources/runtimets/queries/string/substring2-4/substring2-4.3.query.aql
+++
b/asterixdb/asterix-app/src/test/resources/runtimets/queries/string/substring2-4/substring2-4.3.query.aql
@@ -19,4 +19,5 @@
use dataverse test;
let $c1 := substring("HEllow",-3)
-return {"result1": $c1}
+let $c2 := substring("HEllow",-7)
+return {"result1": $c1, "result2": $c2}
diff --git
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/substr04/substr04.3.query.sqlpp
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/substr04/substr04.3.query.sqlpp
index e1ef68b..d9f936f 100644
---
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/substr04/substr04.3.query.sqlpp
+++
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/substr04/substr04.3.query.sqlpp
@@ -32,7 +32,10 @@
substring('ABCD',0,4),
substring('UC Irvine',3,(`string-length`('UC Irvine') - 3)),
substring('UC
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Till Westmann has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 2: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2914 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Michael Blow Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2384/ (11/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2914 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Michael Blow Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [WIP][NET] Limit Net Read Buffers
Jenkins has posted comments on this change. Change subject: [WIP][NET] Limit Net Read Buffers .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2385/ (13/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2915 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9069f380035db3f631b370ec839845f62638dc7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [WIP][NET] Limit Net Read Buffers
Jenkins has posted comments on this change. Change subject: [WIP][NET] Limit Net Read Buffers .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7198/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2915 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9069f380035db3f631b370ec839845f62638dc7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [WIP][NET] Limit Net Read Buffers
Jenkins has posted comments on this change. Change subject: [WIP][NET] Limit Net Read Buffers .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4733/ (12/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2915 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9069f380035db3f631b370ec839845f62638dc7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 2: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7197/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2914 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Michael Blow Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [WIP][NET] Limit Net Read Buffers
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [WIP][NET] Limit Net Read Buffers .. Patch Set 1: Contrib-2 Analytics Compatibility Tests Failed https://goo.gl/HWQjEj : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2915 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9069f380035db3f631b370ec839845f62638dc7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [WIP][NET] Limit Net Read Buffers
Jenkins has posted comments on this change. Change subject: [WIP][NET] Limit Net Read Buffers .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/4764/ (11/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2915 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9069f380035db3f631b370ec839845f62638dc7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [WIP][NET] Limit Net Read Buffers
Jenkins has posted comments on this change. Change subject: [WIP][NET] Limit Net Read Buffers .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4930/ (10/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2915 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9069f380035db3f631b370ec839845f62638dc7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [WIP][NET] Limit Net Read Buffers
Jenkins has posted comments on this change. Change subject: [WIP][NET] Limit Net Read Buffers .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/4593/ (9/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2915 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9069f380035db3f631b370ec839845f62638dc7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [WIP][NET] Limit Net Read Buffers
Jenkins has posted comments on this change. Change subject: [WIP][NET] Limit Net Read Buffers .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4372/ (8/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2915 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9069f380035db3f631b370ec839845f62638dc7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [WIP][NET] Limit Net Read Buffers
Jenkins has posted comments on this change. Change subject: [WIP][NET] Limit Net Read Buffers .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4286/ (7/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2915 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9069f380035db3f631b370ec839845f62638dc7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [WIP][NET] Limit Net Read Buffers
Jenkins has posted comments on this change. Change subject: [WIP][NET] Limit Net Read Buffers .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage-jre10/657/ (6/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2915 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9069f380035db3f631b370ec839845f62638dc7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [WIP][NET] Limit Net Read Buffers
Jenkins has posted comments on this change. Change subject: [WIP][NET] Limit Net Read Buffers .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8310/ (5/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2915 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9069f380035db3f631b370ec839845f62638dc7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [WIP][NET] Limit Net Read Buffers
Jenkins has posted comments on this change. Change subject: [WIP][NET] Limit Net Read Buffers .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/9850/ (4/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2915 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9069f380035db3f631b370ec839845f62638dc7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [WIP][NET] Limit Net Read Buffers
Jenkins has posted comments on this change. Change subject: [WIP][NET] Limit Net Read Buffers .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-java10/583/ (3/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2915 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9069f380035db3f631b370ec839845f62638dc7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [WIP][NET] Limit Net Read Buffers
Jenkins has posted comments on this change. Change subject: [WIP][NET] Limit Net Read Buffers .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4340/ (2/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2915 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9069f380035db3f631b370ec839845f62638dc7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4929/ (10/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2914 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Michael Blow Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [WIP][NET] Limit Net Read Buffers
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [WIP][NET] Limit Net Read Buffers .. Patch Set 1: Analytics Compatibility Compilation Successful https://goo.gl/K7s8ba : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2915 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9069f380035db3f631b370ec839845f62638dc7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [WIP][NET] Limit Net Read Buffers
Jenkins has posted comments on this change. Change subject: [WIP][NET] Limit Net Read Buffers .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7198/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2915 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9069f380035db3f631b370ec839845f62638dc7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [WIP][NET] Limit Net Read Buffers
Murtadha Hubail has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/2915
Change subject: [WIP][NET] Limit Net Read Buffers
..
[WIP][NET] Limit Net Read Buffers
Change-Id: Ia9069f380035db3f631b370ec839845f62638dc7
---
M
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/ReportPartitionAvailabilityWork.java
M
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/StartTasksWork.java
2 files changed, 5 insertions(+), 2 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/15/2915/1
diff --git
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/ReportPartitionAvailabilityWork.java
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/ReportPartitionAvailabilityWork.java
index cfd69ce..854de0c 100644
---
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/ReportPartitionAvailabilityWork.java
+++
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/ReportPartitionAvailabilityWork.java
@@ -32,6 +32,7 @@
import org.apache.hyracks.control.nc.NodeControllerService;
public class ReportPartitionAvailabilityWork extends AbstractWork {
+private static final int READ_BUFFERS = 1;
private final NodeControllerService ncs;
private final PartitionId pid;
@@ -56,7 +57,7 @@
new InetSocketAddress(
InetAddress.getByAddress(networkAddress.lookupIpAddress()),
networkAddress.getPort()),
-pid, 5));
+pid, READ_BUFFERS));
ji.reportPartitionAvailability(channel);
}
} catch (Exception e) {
diff --git
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/StartTasksWork.java
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/StartTasksWork.java
index 09a4c18..c3a760d 100644
---
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/StartTasksWork.java
+++
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/work/StartTasksWork.java
@@ -77,6 +77,8 @@
public class StartTasksWork extends AbstractWork {
private static final Logger LOGGER = LogManager.getLogger();
+private static final int READ_BUFFERS = 1;
+
private final NodeControllerService ncs;
private final DeploymentId deploymentId;
@@ -301,7 +303,7 @@
new InetSocketAddress(
InetAddress.getByAddress(networkAddress.lookupIpAddress()),
networkAddress.getPort()),
-pid, 5));
+pid, READ_BUFFERS));
channels.add(channel);
}
}
--
To view, visit https://asterix-gerrit.ics.uci.edu/2915
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia9069f380035db3f631b370ec839845f62638dc7
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail
Change in asterixdb[master]: [WIP][NET] Limit Net Read Buffers
Jenkins has posted comments on this change. Change subject: [WIP][NET] Limit Net Read Buffers .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4375/ (1/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2915 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia9069f380035db3f631b370ec839845f62638dc7 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/4592/ (9/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2914 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Michael Blow Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4371/ (8/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2914 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Michael Blow Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4285/ (7/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2914 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Michael Blow Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8309/ (6/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2914 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Michael Blow Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7197/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2914 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Michael Blow Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4374/ (1/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2914 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Michael Blow Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/4763/ (3/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2914 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Michael Blow Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4339/ (4/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2914 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Michael Blow Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4732/ (5/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2914 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Michael Blow Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/9849/ (2/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2914 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Michael Blow Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Hello Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2914 to look at the new patch set (#2). Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed - user model changes: yes - storage format changes: no - interface changes: no Details: - substring() should return NULL if starting offset is out of bounds for given string or length is negative Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa --- M asterixdb/asterix-app/src/test/resources/runtimets/queries/string/substr04/substr04.3.query.aql M asterixdb/asterix-app/src/test/resources/runtimets/queries/string/substring2-4/substring2-4.3.query.aql M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/substr04/substr04.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/substring2-4/substring2-4.3.query.sqlpp M asterixdb/asterix-app/src/test/resources/runtimets/results/string/substr01/substr01.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/results/string/substr04/substr04.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/results/string/substring2-3/substring2-3.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/results/string/substring2-4/substring2-4.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/results/stringoffset/substring/substring.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/results/stringoffset/substring2/substring2.1.adm M asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/string/substr04/substr04.3.ast M asterixdb/asterix-app/src/test/resources/runtimets/results_parser_sqlpp/string/substring2-4/substring2-4.3.ast M asterixdb/asterix-doc/src/main/markdown/builtins/2_string_common.md M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/BuiltinFunctions.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/StringIntToStringTypeComputer.java M asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/SubstringTypeComputer.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/Substring2Descriptor.java M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/SubstringDescriptor.java M hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/primitive/UTF8StringPointable.java 19 files changed, 101 insertions(+), 55 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/14/2914/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2914 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Michael Blow Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7196/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2914 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE] User-defined Function Documentation update
Jenkins has posted comments on this change. Change subject: [NO ISSUE] User-defined Function Documentation update .. Patch Set 9: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4373/ (13/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2804 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I17b1b4d639ca38689298ce88145257e794eb90e1 Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Till Westmann Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4928/ (10/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2914 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][FAIL] Remove Special Message Handling From Hyrack...
Murtadha Hubail has restored this change. Change subject: [NO ISSUE][FAIL] Remove Special Message Handling From HyracksException .. Restored -- To view, visit https://asterix-gerrit.ics.uci.edu/2723 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: restore Gerrit-Change-Id: Ie87225d6d332bc0028bf81dfc947acc7063a898e Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann
Change in asterixdb[release-0.9.4-pre-rc]: [NO ISSUE][*DB] Refactor *DB POM hierarchy
Michael Blow has abandoned this change. Change subject: [NO ISSUE][*DB] Refactor *DB POM hierarchy .. Abandoned -- To view, visit https://asterix-gerrit.ics.uci.edu/2596 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I545834153c9f969cfeddbcfc364759be4f1090f1 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-Reviewer: Murtadha Hubail Gerrit-Reviewer: Till Westmann
Change in asterixdb-bad[master]: Coordinated change for https://asterix-gerrit.ics.uci.edu/#/...
Michael Blow has abandoned this change. Change subject: Coordinated change for https://asterix-gerrit.ics.uci.edu/#/c/2596/ .. Abandoned -- To view, visit https://asterix-gerrit.ics.uci.edu/2597 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I08c21b46ac6c5d1af93226532a5359532550567b Gerrit-PatchSet: 1 Gerrit-Project: asterixdb-bad Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/4591/ (9/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2914 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: WIP: prune aql tests
Michael Blow has abandoned this change. Change subject: WIP: prune aql tests .. Abandoned -- To view, visit https://asterix-gerrit.ics.uci.edu/2506 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I0d742859a9c8098319cb0eaa55196c6c844ba9ae Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4370/ (8/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2914 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4731/ (7/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2914 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4284/ (6/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2914 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8308/ (5/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2914 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7196/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2914 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/9848/ (3/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2914 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/4762/ (2/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2914 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Michael Blow has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/2914
Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the
operation cannot be performed
..
[ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be
performed
- user model changes: yes
- storage format changes: no
- interface changes: no
Details:
- substring() should return NULL if starting offset is out of bounds
for given string or length is negative
Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa
---
M
asterixdb/asterix-app/src/test/resources/runtimets/queries/string/substr04/substr04.3.query.aql
M
asterixdb/asterix-app/src/test/resources/runtimets/queries/string/substring2-4/substring2-4.3.query.aql
M
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/substr04/substr04.3.query.sqlpp
M
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/substring2-4/substring2-4.3.query.sqlpp
M
asterixdb/asterix-app/src/test/resources/runtimets/results/string/substr01/substr01.1.adm
M
asterixdb/asterix-app/src/test/resources/runtimets/results/string/substr04/substr04.1.adm
M
asterixdb/asterix-app/src/test/resources/runtimets/results/string/substring2-3/substring2-3.1.adm
M
asterixdb/asterix-app/src/test/resources/runtimets/results/string/substring2-4/substring2-4.1.adm
M asterixdb/asterix-doc/src/main/markdown/builtins/2_string_common.md
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/BuiltinFunctions.java
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/StringIntToStringTypeComputer.java
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/SubstringTypeComputer.java
M
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/Substring2Descriptor.java
M
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/SubstringDescriptor.java
M
hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/primitive/UTF8StringPointable.java
15 files changed, 76 insertions(+), 53 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/14/2914/1
diff --git
a/asterixdb/asterix-app/src/test/resources/runtimets/queries/string/substr04/substr04.3.query.aql
b/asterixdb/asterix-app/src/test/resources/runtimets/queries/string/substr04/substr04.3.query.aql
index 1c31ea0..f792e7f 100644
---
a/asterixdb/asterix-app/src/test/resources/runtimets/queries/string/substr04/substr04.3.query.aql
+++
b/asterixdb/asterix-app/src/test/resources/runtimets/queries/string/substr04/substr04.3.query.aql
@@ -30,6 +30,9 @@
substring("ABCD", 0, 4),
substring("UC Irvine", 3, string-length("UC Irvine") - 3),
substring("UC Irvine", 0, string-length("UC Irvine")),
-substring(substring("UC Irvine", 3), 0, string-length("Irvine"))
+substring(substring("UC Irvine", 3), 0, string-length("Irvine")),
+substring('ABCD',-3,2),
+substring('ABCD',-10,1),
+substring('ABCD',1,-1)
]
return $a
diff --git
a/asterixdb/asterix-app/src/test/resources/runtimets/queries/string/substring2-4/substring2-4.3.query.aql
b/asterixdb/asterix-app/src/test/resources/runtimets/queries/string/substring2-4/substring2-4.3.query.aql
index ecfcd94..b0e8697 100644
---
a/asterixdb/asterix-app/src/test/resources/runtimets/queries/string/substring2-4/substring2-4.3.query.aql
+++
b/asterixdb/asterix-app/src/test/resources/runtimets/queries/string/substring2-4/substring2-4.3.query.aql
@@ -19,4 +19,5 @@
use dataverse test;
let $c1 := substring("HEllow",-3)
-return {"result1": $c1}
+let $c2 := substring("HEllow",-7)
+return {"result1": $c1, "result2": $c2}
diff --git
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/substr04/substr04.3.query.sqlpp
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/substr04/substr04.3.query.sqlpp
index e1ef68b..d9f936f 100644
---
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/substr04/substr04.3.query.sqlpp
+++
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/substr04/substr04.3.query.sqlpp
@@ -32,7 +32,10 @@
substring('ABCD',0,4),
substring('UC Irvine',3,(`string-length`('UC Irvine') - 3)),
substring('UC Irvine',0,`string-length`('UC Irvine')),
-substring(substring('UC Irvine',3),0,`string-length`('Irvine'))
+substring(substring('UC Irvine',3),0,`string-length`('Irvine')),
+substring('ABCD',-3,2),
+substring('ABCD',-10,1),
+substring('ABCD',1,-1)
] as a
;
diff --git
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/substring2-4/substring2-4.3.query.sqlpp
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/substring2-4/substring2-4.3.query.sqlpp
index ae943d4..6b63289 100644
---
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4338/ (1/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2914 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[stabilization-f69489]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4372/ (4/11) -- To view, visit https://asterix-gerrit.ics.uci.edu/2914 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: stabilization-f69489 Gerrit-Owner: Michael Blow Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7195/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2913 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4730/ (13/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2913 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 1: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/Xj25Qw : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2913 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Propagate Network Failure Error Codes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Propagate Network Failure Error Codes .. Patch Set 1: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3614/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2912 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29cffa916df9fecc9942f449ba6c5ca7c84b43b3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Propagate Network Failure Error Codes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Propagate Network Failure Error Codes .. Patch Set 1: BAD Compatibility Tests Failed https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/3614/ : FAILURE -- To view, visit https://asterix-gerrit.ics.uci.edu/2912 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29cffa916df9fecc9942f449ba6c5ca7c84b43b3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Propagate Network Failure Error Codes
Michael Blow has submitted this change and it was merged.
Change subject: [NO ISSUE][NET] Propagate Network Failure Error Codes
..
[NO ISSUE][NET] Propagate Network Failure Error Codes
- user model changes: no
- storage format changes: no
- interface changes: no
Details:
- Pass the network error code to the channel
to determine whether the error should be
sent to the receiver or not.
Change-Id: I29cffa916df9fecc9942f449ba6c5ca7c84b43b3
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2912
Reviewed-by: Michael Blow
Tested-by: Michael Blow
---
M
hyracks-fullstack/hyracks/hyracks-comm/src/main/java/org/apache/hyracks/comm/channels/NetworkOutputChannel.java
M
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/net/NetworkManager.java
M
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/net/ResultNetworkManager.java
M
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/partitions/PartitionManager.java
M
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/result/ResultPartitionReader.java
5 files changed, 12 insertions(+), 8 deletions(-)
Approvals:
Anon. E. Moose #1000171:
Michael Blow: Looks good to me, approved; Verified
diff --git
a/hyracks-fullstack/hyracks/hyracks-comm/src/main/java/org/apache/hyracks/comm/channels/NetworkOutputChannel.java
b/hyracks-fullstack/hyracks/hyracks-comm/src/main/java/org/apache/hyracks/comm/channels/NetworkOutputChannel.java
index 8bee56e..334fb5c 100644
---
a/hyracks-fullstack/hyracks/hyracks-comm/src/main/java/org/apache/hyracks/comm/channels/NetworkOutputChannel.java
+++
b/hyracks-fullstack/hyracks/hyracks-comm/src/main/java/org/apache/hyracks/comm/channels/NetworkOutputChannel.java
@@ -104,8 +104,8 @@
ccb.getWriteInterface().getFullBufferAcceptor().close();
}
-public void abort() {
-
ccb.getWriteInterface().getFullBufferAcceptor().error(AbstractChannelWriteInterface.REMOTE_ERROR_CODE);
+public void abort(int ecode) {
+ccb.getWriteInterface().getFullBufferAcceptor().error(ecode);
synchronized (NetworkOutputChannel.this) {
aborted = true;
NetworkOutputChannel.this.notifyAll();
diff --git
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/net/NetworkManager.java
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/net/NetworkManager.java
index 98693d0..8b02f9c 100644
---
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/net/NetworkManager.java
+++
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/net/NetworkManager.java
@@ -139,7 +139,7 @@
@Override
public void error(int ecode) {
if (noc != null) {
-noc.abort();
+noc.abort(ecode);
}
}
}
diff --git
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/net/ResultNetworkManager.java
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/net/ResultNetworkManager.java
index 6927a58..ee821d6 100644
---
a/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/net/ResultNetworkManager.java
+++
b/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/net/ResultNetworkManager.java
@@ -33,6 +33,7 @@
import org.apache.hyracks.api.result.ResultSetId;
import org.apache.hyracks.comm.channels.IChannelConnectionFactory;
import org.apache.hyracks.comm.channels.NetworkOutputChannel;
+import org.apache.hyracks.net.protocols.muxdemux.AbstractChannelWriteInterface;
import org.apache.hyracks.net.protocols.muxdemux.ChannelControlBlock;
import org.apache.hyracks.net.protocols.muxdemux.IChannelOpenListener;
import org.apache.hyracks.net.protocols.muxdemux.MultiplexedConnection;
@@ -146,7 +147,7 @@
partitionManager.initializeResultPartitionReader(jobId, rsId,
partition, noc);
} catch (HyracksException e) {
LOGGER.warn("Failed to initialize result partition reader", e);
-noc.abort();
+noc.abort(AbstractChannelWriteInterface.REMOTE_ERROR_CODE);
}
}
@@ -158,7 +159,7 @@
@Override
public void error(int ecode) {
if (noc != null) {
-noc.abort();
+noc.abort(ecode);
}
}
}
diff --git
Change in asterixdb[master]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4371/ (2/5) -- To view, visit https://asterix-gerrit.ics.uci.edu/2913 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2383/ (7/8) -- To view, visit https://asterix-gerrit.ics.uci.edu/2913 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Propagate Network Failure Error Codes
Michael Blow has posted comments on this change. Change subject: [NO ISSUE][NET] Propagate Network Failure Error Codes .. Patch Set 1: Verified+1 -- To view, visit https://asterix-gerrit.ics.uci.edu/2912 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29cffa916df9fecc9942f449ba6c5ca7c84b43b3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4337/ (1/4) -- To view, visit https://asterix-gerrit.ics.uci.edu/2913 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage-jre10/656/ (6/7) -- To view, visit https://asterix-gerrit.ics.uci.edu/2913 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/9847/ (3/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/2913 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4369/ (10/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2913 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/4590/ (11/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2913 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4927/ (12/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2913 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8307/ (5/7) -- To view, visit https://asterix-gerrit.ics.uci.edu/2913 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/4761/ (9/9) -- To view, visit https://asterix-gerrit.ics.uci.edu/2913 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-java10/582/ (4/6) -- To view, visit https://asterix-gerrit.ics.uci.edu/2913 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4283/ (8/9) -- To view, visit https://asterix-gerrit.ics.uci.edu/2913 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Propagate Network Failure Error Codes
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][NET] Propagate Network Failure Error Codes .. Patch Set 1: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/RadNJn : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2912 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29cffa916df9fecc9942f449ba6c5ca7c84b43b3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Propagate Network Failure Error Codes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Propagate Network Failure Error Codes .. Patch Set 1: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7194/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2912 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29cffa916df9fecc9942f449ba6c5ca7c84b43b3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
[jira] [Commented] (ASTERIXDB-2443) The current word tokenizer is too restricted.
[ https://issues.apache.org/jira/browse/ASTERIXDB-2443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581764#comment-16581764 ] Chen Li commented on ASTERIXDB-2443: This can be viewed as a short-term solution. For the long term, we need to allow the user to provide a customizable analyzer to process text. > The current word tokenizer is too restricted. > - > > Key: ASTERIXDB-2443 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-2443 > Project: Apache AsterixDB > Issue Type: Improvement >Reporter: Taewoo Kim >Assignee: Taewoo Kim >Priority: Major > > The current tokenizer is too restricted. It treats all characters except > alphanumeric characters (A-Za-z0-9) as a delimiter. As a consequence, all > international characters are treated as a delimiter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Change in asterixdb[master]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4729/ (13/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2913 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
[jira] [Commented] (ASTERIXDB-2443) The current word tokenizer is too restricted.
[ https://issues.apache.org/jira/browse/ASTERIXDB-2443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16581756#comment-16581756 ] Taewoo Kim commented on ASTERIXDB-2443: --- [~che...@gmail.com] and I had a discussion. And we had a short discussion with [~dtabass]. An intermediate solution could be changing from a whitelist (defining all non-delimiters) approach to a blacklist approach (defining all delimiters). > The current word tokenizer is too restricted. > - > > Key: ASTERIXDB-2443 > URL: https://issues.apache.org/jira/browse/ASTERIXDB-2443 > Project: Apache AsterixDB > Issue Type: Improvement >Reporter: Taewoo Kim >Assignee: Taewoo Kim >Priority: Major > > The current tokenizer is too restricted. It treats all characters except > alphanumeric characters (A-Za-z0-9) as a delimiter. As a consequence, all > international characters are treated as a delimiter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (ASTERIXDB-2443) The current word tokenizer is too restricted.
Taewoo Kim created ASTERIXDB-2443: - Summary: The current word tokenizer is too restricted. Key: ASTERIXDB-2443 URL: https://issues.apache.org/jira/browse/ASTERIXDB-2443 Project: Apache AsterixDB Issue Type: Improvement Reporter: Taewoo Kim Assignee: Taewoo Kim The current tokenizer is too restricted. It treats all characters except alphanumeric characters (A-Za-z0-9) as a delimiter. As a consequence, all international characters are treated as a delimiter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Change in asterixdb[master]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/4760/ (12/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2913 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Propagate Network Failure Error Codes
Michael Blow has posted comments on this change. Change subject: [NO ISSUE][NET] Propagate Network Failure Error Codes .. Patch Set 1: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2912 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29cffa916df9fecc9942f449ba6c5ca7c84b43b3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Michael Blow Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-java10/581/ (11/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2913 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7195/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2913 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Propagate Network Failure Error Codes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Propagate Network Failure Error Codes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/4728/ (13/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2912 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29cffa916df9fecc9942f449ba6c5ca7c84b43b3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 1: Analytics Compatibility Compilation Successful https://goo.gl/wVubSi : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2913 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/4589/ (10/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2913 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4926/ (9/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2913 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 1: WARNING: THIS CHANGE CONTAINS CROSS-PRODUCT CHANGES IN: * asterixdb * hyracks-fullstack PLEASE REVIEW CAREFULLY AND LOOK FOR API CHANGES! -- To view, visit https://asterix-gerrit.ics.uci.edu/2913 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/4368/ (8/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2913 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/4282/ (7/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2913 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage-jre10/655/ (6/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2913 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/9846/ (3/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2913 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/4336/ (4/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2913 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8306/ (2/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2913 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/2382/ (1/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2913 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Dmitry Lychagin has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/2913
Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the
operation cannot be performed
..
[ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be
performed
- user model changes: yes
- storage format changes: no
- interface changes: no
Details:
- substring() should return NULL if starting offset is out of bounds
for given string or length is negative
Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa
---
M
asterixdb/asterix-app/src/test/resources/runtimets/queries/string/substr04/substr04.3.query.aql
M
asterixdb/asterix-app/src/test/resources/runtimets/queries/string/substring2-4/substring2-4.3.query.aql
M
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/substr04/substr04.3.query.sqlpp
M
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/substring2-4/substring2-4.3.query.sqlpp
M
asterixdb/asterix-app/src/test/resources/runtimets/results/string/substr01/substr01.1.adm
M
asterixdb/asterix-app/src/test/resources/runtimets/results/string/substr04/substr04.1.adm
M
asterixdb/asterix-app/src/test/resources/runtimets/results/string/substring2-3/substring2-3.1.adm
M
asterixdb/asterix-app/src/test/resources/runtimets/results/string/substring2-4/substring2-4.1.adm
M asterixdb/asterix-doc/src/main/markdown/builtins/2_string_common.md
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/functions/BuiltinFunctions.java
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/StringIntToStringTypeComputer.java
M
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/typecomputer/impl/SubstringTypeComputer.java
M
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/Substring2Descriptor.java
M
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/SubstringDescriptor.java
M
hyracks-fullstack/hyracks/hyracks-data/hyracks-data-std/src/main/java/org/apache/hyracks/data/std/primitive/UTF8StringPointable.java
15 files changed, 76 insertions(+), 53 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/13/2913/1
diff --git
a/asterixdb/asterix-app/src/test/resources/runtimets/queries/string/substr04/substr04.3.query.aql
b/asterixdb/asterix-app/src/test/resources/runtimets/queries/string/substr04/substr04.3.query.aql
index 1c31ea0..f792e7f 100644
---
a/asterixdb/asterix-app/src/test/resources/runtimets/queries/string/substr04/substr04.3.query.aql
+++
b/asterixdb/asterix-app/src/test/resources/runtimets/queries/string/substr04/substr04.3.query.aql
@@ -30,6 +30,9 @@
substring("ABCD", 0, 4),
substring("UC Irvine", 3, string-length("UC Irvine") - 3),
substring("UC Irvine", 0, string-length("UC Irvine")),
-substring(substring("UC Irvine", 3), 0, string-length("Irvine"))
+substring(substring("UC Irvine", 3), 0, string-length("Irvine")),
+substring('ABCD',-3,2),
+substring('ABCD',-10,1),
+substring('ABCD',1,-1)
]
return $a
diff --git
a/asterixdb/asterix-app/src/test/resources/runtimets/queries/string/substring2-4/substring2-4.3.query.aql
b/asterixdb/asterix-app/src/test/resources/runtimets/queries/string/substring2-4/substring2-4.3.query.aql
index ecfcd94..b0e8697 100644
---
a/asterixdb/asterix-app/src/test/resources/runtimets/queries/string/substring2-4/substring2-4.3.query.aql
+++
b/asterixdb/asterix-app/src/test/resources/runtimets/queries/string/substring2-4/substring2-4.3.query.aql
@@ -19,4 +19,5 @@
use dataverse test;
let $c1 := substring("HEllow",-3)
-return {"result1": $c1}
+let $c2 := substring("HEllow",-7)
+return {"result1": $c1, "result2": $c2}
diff --git
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/substr04/substr04.3.query.sqlpp
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/substr04/substr04.3.query.sqlpp
index e1ef68b..d9f936f 100644
---
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/substr04/substr04.3.query.sqlpp
+++
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/substr04/substr04.3.query.sqlpp
@@ -32,7 +32,10 @@
substring('ABCD',0,4),
substring('UC Irvine',3,(`string-length`('UC Irvine') - 3)),
substring('UC Irvine',0,`string-length`('UC Irvine')),
-substring(substring('UC Irvine',3),0,`string-length`('Irvine'))
+substring(substring('UC Irvine',3),0,`string-length`('Irvine')),
+substring('ABCD',-3,2),
+substring('ABCD',-10,1),
+substring('ABCD',1,-1)
] as a
;
diff --git
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/substring2-4/substring2-4.3.query.sqlpp
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/string/substring2-4/substring2-4.3.query.sqlpp
index ae943d4..6b63289 100644
---
Change in asterixdb[master]: [ASTERIXDB-2442][FUN] substring() should return NULL if the ...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2442][FUN] substring() should return NULL if the operation cannot be performed .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/4370/ (5/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2913 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia43a4266a2406ebba65809d527de896ad11fdffa Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Propagate Network Failure Error Codes
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [NO ISSUE][NET] Propagate Network Failure Error Codes .. Patch Set 1: Analytics Compatibility Compilation Successful https://goo.gl/hVs5ca : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2912 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29cffa916df9fecc9942f449ba6c5ca7c84b43b3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Propagate Network Failure Error Codes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Propagate Network Failure Error Codes .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/7194/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2912 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29cffa916df9fecc9942f449ba6c5ca7c84b43b3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Propagate Network Failure Error Codes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Propagate Network Failure Error Codes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/8305/ (4/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2912 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29cffa916df9fecc9942f449ba6c5ca7c84b43b3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [NO ISSUE][NET] Propagate Network Failure Error Codes
Jenkins has posted comments on this change. Change subject: [NO ISSUE][NET] Propagate Network Failure Error Codes .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/4925/ (10/13) -- To view, visit https://asterix-gerrit.ics.uci.edu/2912 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I29cffa916df9fecc9942f449ba6c5ca7c84b43b3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
