Change in asterixdb[master]: [NO ISSUE] Fix type inference for ANY in UDFs

2019-05-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3405 )

Change subject: [NO ISSUE] Fix type inference for ANY in UDFs
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5732/ (2/4)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3405
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a03749fe041ec6f43de230d3e784122f7664545
Gerrit-Change-Number: 3405
Gerrit-PatchSet: 1
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 24 May 2019 03:30:33 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Fix type inference for ANY in UDFs

2019-05-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3405 )

Change subject: [NO ISSUE] Fix type inference for ANY in UDFs
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5983/
 (8/10)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3405
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a03749fe041ec6f43de230d3e784122f7664545
Gerrit-Change-Number: 3405
Gerrit-PatchSet: 1
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 24 May 2019 03:30:41 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Fix type inference for ANY in UDFs

2019-05-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3405 )

Change subject: [NO ISSUE] Fix type inference for ANY in UDFs
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/994/ (12/13)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3405
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a03749fe041ec6f43de230d3e784122f7664545
Gerrit-Change-Number: 3405
Gerrit-PatchSet: 1
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 24 May 2019 03:30:50 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Fix type inference for ANY in UDFs

2019-05-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3405 )

Change subject: [NO ISSUE] Fix type inference for ANY in UDFs
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/597/ 
(5/6)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3405
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a03749fe041ec6f43de230d3e784122f7664545
Gerrit-Change-Number: 3405
Gerrit-PatchSet: 1
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 24 May 2019 03:30:35 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Fix type inference for ANY in UDFs

2019-05-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3405 )

Change subject: [NO ISSUE] Fix type inference for ANY in UDFs
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1183/
 (11/12)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3405
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a03749fe041ec6f43de230d3e784122f7664545
Gerrit-Change-Number: 3405
Gerrit-PatchSet: 1
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 24 May 2019 03:30:47 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Fix type inference for ANY in UDFs

2019-05-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3405 )

Change subject: [NO ISSUE] Fix type inference for ANY in UDFs
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6038/ 
(15/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3405
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a03749fe041ec6f43de230d3e784122f7664545
Gerrit-Change-Number: 3405
Gerrit-PatchSet: 1
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 24 May 2019 03:30:54 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Fix type inference for ANY in UDFs

2019-05-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3405 )

Change subject: [NO ISSUE] Fix type inference for ANY in UDFs
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6188/ 
(9/11)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3405
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a03749fe041ec6f43de230d3e784122f7664545
Gerrit-Change-Number: 3405
Gerrit-PatchSet: 1
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 24 May 2019 03:30:43 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Fix type inference for ANY in UDFs

2019-05-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3405 )

Change subject: [NO ISSUE] Fix type inference for ANY in UDFs
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3827/ 
(16/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3405
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a03749fe041ec6f43de230d3e784122f7664545
Gerrit-Change-Number: 3405
Gerrit-PatchSet: 1
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 24 May 2019 03:30:56 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Fix type inference for ANY in UDFs

2019-05-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3405 )

Change subject: [NO ISSUE] Fix type inference for ANY in UDFs
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6398/ (14/15)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3405
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a03749fe041ec6f43de230d3e784122f7664545
Gerrit-Change-Number: 3405
Gerrit-PatchSet: 1
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 24 May 2019 03:30:53 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Fix type inference for ANY in UDFs

2019-05-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3405 )

Change subject: [NO ISSUE] Fix type inference for ANY in UDFs
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1092/
 (13/14)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3405
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a03749fe041ec6f43de230d3e784122f7664545
Gerrit-Change-Number: 3405
Gerrit-PatchSet: 1
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 24 May 2019 03:30:51 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Fix type inference for ANY in UDFs

2019-05-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3405 )

Change subject: [NO ISSUE] Fix type inference for ANY in UDFs
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5833/ 
(4/6)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3405
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a03749fe041ec6f43de230d3e784122f7664545
Gerrit-Change-Number: 3405
Gerrit-PatchSet: 1
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 24 May 2019 03:30:35 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Fix type inference for ANY in UDFs

2019-05-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3405 )

Change subject: [NO ISSUE] Fix type inference for ANY in UDFs
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5796/ (3/5)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3405
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a03749fe041ec6f43de230d3e784122f7664545
Gerrit-Change-Number: 3405
Gerrit-PatchSet: 1
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 24 May 2019 03:30:34 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Fix type inference for ANY in UDFs

2019-05-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3405 )

Change subject: [NO ISSUE] Fix type inference for ANY in UDFs
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9774/ (10/12)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3405
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a03749fe041ec6f43de230d3e784122f7664545
Gerrit-Change-Number: 3405
Gerrit-PatchSet: 1
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 24 May 2019 03:30:45 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Fix type inference for ANY in UDFs

2019-05-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3405 )

Change subject: [NO ISSUE] Fix type inference for ANY in UDFs
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11307/ (1/4)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3405
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a03749fe041ec6f43de230d3e784122f7664545
Gerrit-Change-Number: 3405
Gerrit-PatchSet: 1
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 24 May 2019 03:30:33 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Fix type inference for ANY in UDFs

2019-05-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3405 )

Change subject: [NO ISSUE] Fix type inference for ANY in UDFs
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/756/ 
(6/7)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3405
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a03749fe041ec6f43de230d3e784122f7664545
Gerrit-Change-Number: 3405
Gerrit-PatchSet: 1
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 24 May 2019 03:30:36 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Fix type inference for ANY in UDFs

2019-05-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3405 )

Change subject: [NO ISSUE] Fix type inference for ANY in UDFs
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5815/
 (7/10)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3405
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a03749fe041ec6f43de230d3e784122f7664545
Gerrit-Change-Number: 3405
Gerrit-PatchSet: 1
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 24 May 2019 03:30:38 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Fix type inference for ANY in UDFs

2019-05-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3405 )

Change subject: [NO ISSUE] Fix type inference for ANY in UDFs
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8593/


--
To view, visit https://asterix-gerrit.ics.uci.edu/3405
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a03749fe041ec6f43de230d3e784122f7664545
Gerrit-Change-Number: 3405
Gerrit-PatchSet: 1
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 24 May 2019 02:32:59 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Fix type inference for ANY in UDFs

2019-05-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3405 )

Change subject: [NO ISSUE] Fix type inference for ANY in UDFs
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/5832/ 
(15/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3405
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a03749fe041ec6f43de230d3e784122f7664545
Gerrit-Change-Number: 3405
Gerrit-PatchSet: 1
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 24 May 2019 02:32:01 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Fix type inference for ANY in UDFs

2019-05-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3405 )

Change subject: [NO ISSUE] Fix type inference for ANY in UDFs
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/6037/ 
(4/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3405
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a03749fe041ec6f43de230d3e784122f7664545
Gerrit-Change-Number: 3405
Gerrit-PatchSet: 1
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 24 May 2019 02:31:39 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Fix type inference for ANY in UDFs

2019-05-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3405 )

Change subject: [NO ISSUE] Fix type inference for ANY in UDFs
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/5795/ 
(16/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3405
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a03749fe041ec6f43de230d3e784122f7664545
Gerrit-Change-Number: 3405
Gerrit-PatchSet: 1
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 24 May 2019 02:32:03 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Fix type inference for ANY in UDFs

2019-05-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3405 )

Change subject: [NO ISSUE] Fix type inference for ANY in UDFs
..


Patch Set 1: Contrib-2

BAD Compatibility Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4442/ : FAILURE


--
To view, visit https://asterix-gerrit.ics.uci.edu/3405
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a03749fe041ec6f43de230d3e784122f7664545
Gerrit-Change-Number: 3405
Gerrit-PatchSet: 1
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 24 May 2019 02:38:24 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Fix type inference for ANY in UDFs

2019-05-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3405 )

Change subject: [NO ISSUE] Fix type inference for ANY in UDFs
..


Patch Set 1: Integration-Tests-1

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/8593/ 
: FAILURE


--
To view, visit https://asterix-gerrit.ics.uci.edu/3405
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a03749fe041ec6f43de230d3e784122f7664545
Gerrit-Change-Number: 3405
Gerrit-PatchSet: 1
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 24 May 2019 02:35:44 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Fix type inference for ANY in UDFs

2019-05-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3405 )

Change subject: [NO ISSUE] Fix type inference for ANY in UDFs
..


Patch Set 1:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/4442/


--
To view, visit https://asterix-gerrit.ics.uci.edu/3405
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a03749fe041ec6f43de230d3e784122f7664545
Gerrit-Change-Number: 3405
Gerrit-PatchSet: 1
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 24 May 2019 02:34:59 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Fix type inference for ANY in UDFs

2019-05-23 Thread Anon. E. Moose (Code Review)
Anon. E. Moose (1000171) has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3405 )

Change subject: [NO ISSUE] Fix type inference for ANY in UDFs
..


Patch Set 1: Contrib-2

Analytics Compatibility Compilation Failed
https://cbjenkins.page.link/755LW7VsCgUyCqbr6 : UNSTABLE


--
To view, visit https://asterix-gerrit.ics.uci.edu/3405
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a03749fe041ec6f43de230d3e784122f7664545
Gerrit-Change-Number: 3405
Gerrit-PatchSet: 1
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 24 May 2019 02:35:03 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Fix type inference for ANY in UDFs

2019-05-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3405 )

Change subject: [NO ISSUE] Fix type inference for ANY in UDFs
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/5982/
 (12/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3405
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a03749fe041ec6f43de230d3e784122f7664545
Gerrit-Change-Number: 3405
Gerrit-PatchSet: 1
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 24 May 2019 02:31:55 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Fix type inference for ANY in UDFs

2019-05-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3405 )

Change subject: [NO ISSUE] Fix type inference for ANY in UDFs
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-spidersilk-tests/755/ 
(13/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3405
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a03749fe041ec6f43de230d3e784122f7664545
Gerrit-Change-Number: 3405
Gerrit-PatchSet: 1
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 24 May 2019 02:31:57 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Fix type inference for ANY in UDFs

2019-05-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3405 )

Change subject: [NO ISSUE] Fix type inference for ANY in UDFs
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/11306/ (9/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3405
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a03749fe041ec6f43de230d3e784122f7664545
Gerrit-Change-Number: 3405
Gerrit-PatchSet: 1
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 24 May 2019 02:31:49 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Fix type inference for ANY in UDFs

2019-05-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3405 )

Change subject: [NO ISSUE] Fix type inference for ANY in UDFs
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/9773/ (5/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3405
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a03749fe041ec6f43de230d3e784122f7664545
Gerrit-Change-Number: 3405
Gerrit-PatchSet: 1
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 24 May 2019 02:31:41 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Fix type inference for ANY in UDFs

2019-05-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3405 )

Change subject: [NO ISSUE] Fix type inference for ANY in UDFs
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ssl-compression/596/ 
(14/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3405
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a03749fe041ec6f43de230d3e784122f7664545
Gerrit-Change-Number: 3405
Gerrit-PatchSet: 1
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 24 May 2019 02:31:58 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Fix type inference for ANY in UDFs

2019-05-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3405 )

Change subject: [NO ISSUE] Fix type inference for ANY in UDFs
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-txnlog/993/ (8/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3405
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a03749fe041ec6f43de230d3e784122f7664545
Gerrit-Change-Number: 3405
Gerrit-PatchSet: 1
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 24 May 2019 02:31:47 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Fix type inference for ANY in UDFs

2019-05-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3405 )

Change subject: [NO ISSUE] Fix type inference for ANY in UDFs
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-openjdk11/1182/
 (3/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3405
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a03749fe041ec6f43de230d3e784122f7664545
Gerrit-Change-Number: 3405
Gerrit-PatchSet: 1
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 24 May 2019 02:31:38 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Fix type inference for ANY in UDFs

2019-05-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3405 )

Change subject: [NO ISSUE] Fix type inference for ANY in UDFs
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/6187/ 
(10/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3405
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a03749fe041ec6f43de230d3e784122f7664545
Gerrit-Change-Number: 3405
Gerrit-PatchSet: 1
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 24 May 2019 02:31:51 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Fix type inference for ANY in UDFs

2019-05-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3405 )

Change subject: [NO ISSUE] Fix type inference for ANY in UDFs
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/5731/ 
(1/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3405
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a03749fe041ec6f43de230d3e784122f7664545
Gerrit-Change-Number: 3405
Gerrit-PatchSet: 1
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 24 May 2019 02:31:38 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Fix type inference for ANY in UDFs

2019-05-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3405 )

Change subject: [NO ISSUE] Fix type inference for ANY in UDFs
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/5814/
 (11/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3405
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a03749fe041ec6f43de230d3e784122f7664545
Gerrit-Change-Number: 3405
Gerrit-PatchSet: 1
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 24 May 2019 02:31:53 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Fix type inference for ANY in UDFs

2019-05-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3405 )

Change subject: [NO ISSUE] Fix type inference for ANY in UDFs
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/3826/ 
(2/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3405
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a03749fe041ec6f43de230d3e784122f7664545
Gerrit-Change-Number: 3405
Gerrit-PatchSet: 1
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 24 May 2019 02:31:38 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Fix type inference for ANY in UDFs

2019-05-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3405 )

Change subject: [NO ISSUE] Fix type inference for ANY in UDFs
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/6397/ (6/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3405
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a03749fe041ec6f43de230d3e784122f7664545
Gerrit-Change-Number: 3405
Gerrit-PatchSet: 1
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 24 May 2019 02:31:42 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Fix type inference for ANY in UDFs

2019-05-23 Thread Jenkins (Code Review)
Jenkins has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3405 )

Change subject: [NO ISSUE] Fix type inference for ANY in UDFs
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-stabilization-f69489-compat/1091/
 (7/16)


--
To view, visit https://asterix-gerrit.ics.uci.edu/3405
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a03749fe041ec6f43de230d3e784122f7664545
Gerrit-Change-Number: 3405
Gerrit-PatchSet: 1
Gerrit-Owner: Xikui Wang 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Fri, 24 May 2019 02:31:45 +
Gerrit-HasComments: No


Change in asterixdb[master]: [NO ISSUE] Fix type inference for ANY in UDFs

2019-05-23 Thread Xikui Wang (Code Review)
Xikui Wang has uploaded this change for review. ( 
https://asterix-gerrit.ics.uci.edu/3405


Change subject: [NO ISSUE] Fix type inference for ANY in UDFs
..

[NO ISSUE] Fix type inference for ANY in UDFs

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
When data type is available, we should use defined data type. If not, we
should try to parse the data type from the data.

Change-Id: I6a03749fe041ec6f43de230d3e784122f7664545
---
M 
asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/upperCase/upperCase.3.query.sqlpp
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/CharArrayRecord.java
M 
asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjectAccessors.java
3 files changed, 14 insertions(+), 4 deletions(-)



  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/05/3405/1

diff --git 
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/upperCase/upperCase.3.query.sqlpp
 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/upperCase/upperCase.3.query.sqlpp
index 743d39a..62c2b87 100644
--- 
a/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/upperCase/upperCase.3.query.sqlpp
+++ 
b/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/external-library/upperCase/upperCase.3.query.sqlpp
@@ -18,7 +18,7 @@
  */
 use externallibtest;

-let i={"id":1, "text_list": [{"text":"lower text1"}, {"text":"lower text2"}]}
+let i={"id":1, "text_list": [{"text":"lower text1"}, {"text":"lower text2"}], 
"another_list" : ["string_1", "string_2"]}
 select value `testlib#toUpper`(i);

 let i=`testlib#toUpper`({"id":1, "text_list":[{"text":"lower text"}]})
diff --git 
a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/CharArrayRecord.java
 
b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/CharArrayRecord.java
index 65ecd8d..678b3d7 100644
--- 
a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/CharArrayRecord.java
+++ 
b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/input/record/CharArrayRecord.java
@@ -90,7 +90,7 @@

 @Override
 public String toString() {
-return String.valueOf(value, 0, size == 0 ? 0 : size - 1);
+return String.valueOf(value, 0, size == 0 ? 0 : size);
 }

 public void endRecord() throws IOException {
diff --git 
a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjectAccessors.java
 
b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjectAccessors.java
index ee8308f..3af08fa 100644
--- 
a/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjectAccessors.java
+++ 
b/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/library/java/JObjectAccessors.java
@@ -583,10 +583,20 @@
 public IJObject access(AListVisitablePointable pointable, 
IObjectPool objectPool,
 IAType listType, JObjectPointableVisitor pointableVisitor) 
throws HyracksDataException {
 List items = pointable.getItems();
+List itemTags = pointable.getItemTags();
 JList list = pointable.ordered() ? new JOrderedList(listType) : 
new JUnorderedList(listType);
 IJObject listItem;
-for (IVisitablePointable itemPointable : items) {
-final IAType fieldType = ((AbstractCollectionType) 
listType).getItemType();
+for (int iter1 = 0; iter1 < items.size(); iter1++) {
+IVisitablePointable itemPointable = items.get(iter1);
+// First, try to get defined type.
+IAType fieldType = ((AbstractCollectionType) 
listType).getItemType();
+if (fieldType.getTypeTag() == ATypeTag.ANY) {
+// Second, if defined type is not available, try to infer 
it from data
+IVisitablePointable itemTagPointable = itemTags.get(iter1);
+ATypeTag itemTypeTag = 
EnumDeserializer.ATYPETAGDESERIALIZER
+
.deserialize(itemTagPointable.getByteArray()[itemTagPointable.getStartOffset()]);
+fieldType = TypeTagUtil.getBuiltinTypeByTag(itemTypeTag);
+}
 typeInfo.reset(fieldType, fieldType.getTypeTag());
 switch (typeInfo.getTypeTag()) {
 case OBJECT:

--
To view, visit https://asterix-gerrit.ics.uci.edu/3405
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6a03749fe041ec6f43de230d3e784122f7664545

Change in asterixdb[master]: [NO ISSUE][API] Return Async Query Results As JSON

2019-05-23 Thread Till Westmann (Code Review)
Till Westmann has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3401 )

Change subject: [NO ISSUE][API] Return Async Query Results As JSON
..


Patch Set 2: Code-Review+2

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/3401/2/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/DistributeResultOperator.java
File 
hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/DistributeResultOperator.java:

https://asterix-gerrit.ics.uci.edu/#/c/3401/2/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/DistributeResultOperator.java@100
PS2, Line 100: public IResultMetadata getResultMetadata() {
 : return resultMetadata;
 : }
Move this next to the other accessors?



--
To view, visit https://asterix-gerrit.ics.uci.edu/3401
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4812a14925099a677f9e77a0040f881d2600724
Gerrit-Change-Number: 3401
Gerrit-PatchSet: 2
Gerrit-Owner: Murtadha Hubail 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Till Westmann 
Gerrit-Comment-Date: Thu, 23 May 2019 23:55:30 +
Gerrit-HasComments: Yes


Change in asterixdb[master]: [NO ISSUE][FUN] Remove unnecessary inner classes

2019-05-23 Thread Hussain Towaileb (Code Review)
Hussain Towaileb has submitted this change and it was merged. ( 
https://asterix-gerrit.ics.uci.edu/3403 )

Change subject: [NO ISSUE][FUN] Remove unnecessary inner classes
..

[NO ISSUE][FUN] Remove unnecessary inner classes

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Remove unnecessary inner classes. Use the evaluator
factories length to check if the end position argument
is passed.

Change-Id: I5cc8c57888e62b26684082dd07a4314b45f9fa7f
Reviewed-on: https://asterix-gerrit.ics.uci.edu/3403
Contrib: Jenkins 
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: Dmitry Lychagin 
---
R 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArraySliceEvaluator.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArraySliceWithEndPositionDescriptor.java
M 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArraySliceWithoutEndPositionDescriptor.java
3 files changed, 23 insertions(+), 59 deletions(-)

Approvals:
  Jenkins: Verified; No violations found; ; Verified
  Dmitry Lychagin: Looks good to me, approved

Objections:
  Anon. E. Moose (1000171): Violations found



diff --git 
a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/AbstractArraySliceEval.java
 
b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArraySliceEvaluator.java
similarity index 90%
rename from 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/AbstractArraySliceEval.java
rename to 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArraySliceEvaluator.java
index 036447a..c907720 100644
--- 
a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/AbstractArraySliceEval.java
+++ 
b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/ArraySliceEvaluator.java
@@ -75,32 +75,31 @@
  * 
  */

-public abstract class AbstractArraySliceEval extends AbstractScalarEval {
+class ArraySliceEvaluator extends AbstractScalarEval {
+
 // List type
 private final IAType inputListType;

 // Storage
-private final ArrayBackedValueStorage storage = new 
ArrayBackedValueStorage();
+private final ArrayBackedValueStorage resultStorage = new 
ArrayBackedValueStorage();

-// Evaluators
+// Evaluators and pointables
 private final IScalarEvaluator listEval;
 private final IScalarEvaluator startPositionEval;
-private final IScalarEvaluator endPositionEval;
-
-// Pointables
+private IScalarEvaluator endPositionEval;
 private final IPointable listPointable = new VoidPointable();
 private final IPointable startPositionPointable = new VoidPointable();
-private final IPointable endPositionPointable = new VoidPointable();
+private IPointable endPositionPointable;

 // Accessors
 private final ListAccessor listAccessor = new ListAccessor();

 // List Builders
-private IAsterixListBuilder orderedListBuilder = new OrderedListBuilder();
-private IAsterixListBuilder unorderedListBuilder = new 
UnorderedListBuilder();
+private final IAsterixListBuilder orderedListBuilder = new 
OrderedListBuilder();
+private final IAsterixListBuilder unorderedListBuilder = new 
UnorderedListBuilder();

 // Constructor
-public AbstractArraySliceEval(IScalarEvaluatorFactory[] args, 
IHyracksTaskContext ctx, SourceLocation sourceLoc,
+ArraySliceEvaluator(IScalarEvaluatorFactory[] argEvalFactories, 
IHyracksTaskContext ctx, SourceLocation sourceLoc,
 FunctionIdentifier functionIdentifier, IAType inputListType) 
throws HyracksDataException {
 // Source location
 super(sourceLoc, functionIdentifier);
@@ -109,20 +108,18 @@
 this.inputListType = inputListType;

 // Evaluators
-listEval = args[0].createScalarEvaluator(ctx);
-startPositionEval = args[1].createScalarEvaluator(ctx);
+listEval = argEvalFactories[0].createScalarEvaluator(ctx);
+startPositionEval = argEvalFactories[1].createScalarEvaluator(ctx);

 // Check for optional parameter
-endPositionEval = getEndPositionEval(args, ctx);
+if (argEvalFactories.length > 2) {
+endPositionEval = argEvalFactories[2].createScalarEvaluator(ctx);
+endPositionPointable = new VoidPointable();
+}
 }
-
-protected abstract IScalarEvaluator 
getEndPositionEval(IScalarEvaluatorFactory[] args, IHyracksTaskContext ctx)
-throws HyracksDataException;

 @Override
 public void evaluate(IFrameTupleReference tuple, IPointable result) throws 
HyracksDataException {
-// Reset storage
-storage.reset();

 // Evaluate
 

Change in asterixdb[master]: [NO ISSUE][FUN] Remove unnecessary inner classes

2019-05-23 Thread Dmitry Lychagin (Code Review)
Dmitry Lychagin has posted comments on this change. ( 
https://asterix-gerrit.ics.uci.edu/3403 )

Change subject: [NO ISSUE][FUN] Remove unnecessary inner classes
..


Patch Set 1: Code-Review+2


--
To view, visit https://asterix-gerrit.ics.uci.edu/3403
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5cc8c57888e62b26684082dd07a4314b45f9fa7f
Gerrit-Change-Number: 3403
Gerrit-PatchSet: 1
Gerrit-Owner: Hussain Towaileb 
Gerrit-Reviewer: Ali Alsuliman 
Gerrit-Reviewer: Anon. E. Moose (1000171)
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Comment-Date: Thu, 23 May 2019 17:49:07 +
Gerrit-HasComments: No


[jira] [Updated] (ASTERIXDB-2574) Inconsistency in min() and max() with respect to arrays/records

2019-05-23 Thread Till (JIRA)


 [ 
https://issues.apache.org/jira/browse/ASTERIXDB-2574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Till updated ASTERIXDB-2574:

Affects Version/s: 0.9.4.1

> Inconsistency in min() and max() with respect to arrays/records
> ---
>
> Key: ASTERIXDB-2574
> URL: https://issues.apache.org/jira/browse/ASTERIXDB-2574
> Project: Apache AsterixDB
>  Issue Type: Bug
>  Components: FUN - Functions
>Affects Versions: 0.9.4.1
>Reporter: Ali Alsuliman
>Assignee: Ali Alsuliman
>Priority: Major
>
> min() and max() functions used on record/array fields sometimes throw an 
> exception and other times process input. That's because if the field type is 
> known the compiler will validate and check the field is numeric, string or 
> datetime. If the field type is not known (ANY), it would pass and the 
> function runtime would process the input data.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)