subject:"Change in asterixdb\[master\]\: \[ASTERIXDB\-1984\]\[COMP\] probe\-subtree init not required"

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2

2017-11-22 Thread Anon. E. Moose (Code Review)

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2
..


Patch Set 2:

Analytics Compatibility Tests Failed
https://goo.gl/jrgCj6: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdf0baa060efa35a173d00e15f0a348937f2e7f6
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2

2017-11-22 Thread Taewoo Kim (Code Review)

Taewoo Kim has submitted this change and it was merged.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2
..


[ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Let the IntroduceJoinAccessMethod accept arbitrary
  forms of sub-tree for the probe-tree.

Change-Id: Ibdf0baa060efa35a173d00e15f0a348937f2e7f6
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2175
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Integration-Tests: Jenkins 
Contrib: Jenkins 
Reviewed-by: Taewoo Kim 
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceJoinAccessMethodRule.java
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/nonpure/keep-datetime-local.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/udfs/query-ASTERIXDB-1019.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/udfs/query-ASTERIXDB-1029.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/udfs/query-ASTERIXDB-1029_2.plan
6 files changed, 197 insertions(+), 162 deletions(-)

Approvals:
  Taewoo Kim: Looks good to me, approved
  Jenkins: Verified; No violations found; No violations found; Verified



diff --git 
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java
 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java
index bed5c7f..e0c6249 100644
--- 
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java
+++ 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java
@@ -22,9 +22,11 @@
 import java.util.Arrays;
 import java.util.Collections;
 import java.util.HashMap;
+import java.util.HashSet;
 import java.util.Iterator;
 import java.util.List;
 import java.util.Map;
+import java.util.Set;
 
 import org.apache.asterix.common.config.DatasetConfig.IndexType;
 import org.apache.asterix.dataflow.data.common.ExpressionTypeComputer;
@@ -62,6 +64,8 @@
 import 
org.apache.hyracks.algebricks.core.algebra.operators.logical.AbstractLogicalOperator;
 import 
org.apache.hyracks.algebricks.core.algebra.operators.logical.AssignOperator;
 import 
org.apache.hyracks.algebricks.core.algebra.operators.logical.UnnestOperator;
+import 
org.apache.hyracks.algebricks.core.algebra.operators.logical.visitors.VariableUtilities;
+import org.apache.hyracks.algebricks.core.algebra.typing.ITypingContext;
 import org.apache.hyracks.algebricks.core.rewriter.base.IAlgebraicRewriteRule;
 
 import com.google.common.collect.ImmutableSet;
@@ -111,6 +115,25 @@
 protected void fillSubTreeIndexExprs(OptimizableOperatorSubTree subTree,
 Map analyzedAMs, 
IOptimizationContext context)
 throws AlgebricksException {
+fillSubTreeIndexExprs(subTree, analyzedAMs, context, false);
+}
+
+/**
+ * Fills the information about the given optimizable function expressions 
using the subtree.
+ *
+ * @param subTree
+ * @param analyzedAMs
+ * @param context
+ * @param isArbitraryFormOfSubtree
+ *if the given subtree is in an arbitrary form that 
OptimizableSubTree class can't initialize, we try
+ *to fill the field type of each variable that is used in the 
optimizable function expressions.
+ *This way, an index-nested-loop-join transformation can be 
conducted properly since the transformation
+ *process skips an optimzable function expression if the field 
type of one of its variable is unknown.
+ * @throws AlgebricksException
+ */
+protected void fillSubTreeIndexExprs(OptimizableOperatorSubTree subTree,
+Map analyzedAMs, 
IOptimizationContext context,
+boolean isArbitraryFormOfSubtree) throws AlgebricksException {
 Iterator> amIt = 
analyzedAMs.entrySet().iterator();
 // Check applicability of indexes by access method type.
 while (amIt.hasNext()) {
@@ -118,7 +141,36 @@
 AccessMethodAnalysisContext amCtx = entry.getValue();
 // For the current access method type, map variables to applicable
 // indexes.
-fillAllIndexExprs(subTree, amCtx, context);
+if (!isArbitraryFormOfSubtree) {
+

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2

2017-11-22 Thread Taewoo Kim (Code Review)

Taewoo Kim has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2
..


Patch Set 2: Code-Review+2

Forwarding Dmitry's +2 from patch set 1 (just rebased)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdf0baa060efa35a173d00e15f0a348937f2e7f6
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2

2017-11-22 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2
..


Patch Set 2: Contrib+2

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2194/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdf0baa060efa35a173d00e15f0a348937f2e7f6
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2

2017-11-22 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2
..


Patch Set 2: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4704/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdf0baa060efa35a173d00e15f0a348937f2e7f6
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2

2017-11-22 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2
..


Patch Set 2:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2194/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdf0baa060efa35a173d00e15f0a348937f2e7f6
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2

2017-11-22 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/2359/ 
(11/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdf0baa060efa35a173d00e15f0a348937f2e7f6
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2

2017-11-22 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/2339/
 (10/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdf0baa060efa35a173d00e15f0a348937f2e7f6
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2

2017-11-22 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/2550/ (9/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdf0baa060efa35a173d00e15f0a348937f2e7f6
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2

2017-11-22 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2
..


Patch Set 1: Contrib-2

BAD Compatibility Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2192/ : FAILURE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdf0baa060efa35a173d00e15f0a348937f2e7f6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2

2017-11-22 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2
..


Patch Set 2:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4704/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdf0baa060efa35a173d00e15f0a348937f2e7f6
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2

2017-11-22 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2
..


Patch Set 1:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2192/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdf0baa060efa35a173d00e15f0a348937f2e7f6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2

2017-11-22 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5725/ (4/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdf0baa060efa35a173d00e15f0a348937f2e7f6
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2

2017-11-22 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1685/ 
(1/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdf0baa060efa35a173d00e15f0a348937f2e7f6
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2

2017-11-22 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/2004/ 
(7/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdf0baa060efa35a173d00e15f0a348937f2e7f6
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2

2017-11-22 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/2301/ (5/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdf0baa060efa35a173d00e15f0a348937f2e7f6
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2

2017-11-22 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/7225/ (6/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdf0baa060efa35a173d00e15f0a348937f2e7f6
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2

2017-11-22 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1694/
 (3/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdf0baa060efa35a173d00e15f0a348937f2e7f6
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2

2017-11-22 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-rebalance-cancellation/873/
 (8/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdf0baa060efa35a173d00e15f0a348937f2e7f6
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2

2017-11-22 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2
..


Patch Set 2:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1673/ 
(2/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdf0baa060efa35a173d00e15f0a348937f2e7f6
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2

2017-11-22 Thread Dmitry Lychagin (Code Review)

Dmitry Lychagin has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdf0baa060efa35a173d00e15f0a348937f2e7f6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2

2017-11-22 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4701/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdf0baa060efa35a173d00e15f0a348937f2e7f6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2

2017-11-22 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2
..


Patch Set 1: -Contrib

BAD Compatibility Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2191/ : FAILURE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdf0baa060efa35a173d00e15f0a348937f2e7f6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2

2017-11-22 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2
..


Patch Set 1: -Integration-Tests

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4701/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdf0baa060efa35a173d00e15f0a348937f2e7f6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2

2017-11-22 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2
..


Patch Set 1:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2191/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdf0baa060efa35a173d00e15f0a348937f2e7f6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2

2017-11-22 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2
..


Patch Set 1: Integration-Tests-1

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4699/ 
: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdf0baa060efa35a173d00e15f0a348937f2e7f6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2

2017-11-22 Thread Anon. E. Moose (Code Review)

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2
..


Patch Set 1: Contrib-2

Analytics Compatibility Tests Failed
https://goo.gl/aLmuJs: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdf0baa060efa35a173d00e15f0a348937f2e7f6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2

2017-11-22 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2
..


Patch Set 1: Contrib-2

BAD Compatibility Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2189/ : FAILURE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdf0baa060efa35a173d00e15f0a348937f2e7f6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2

2017-11-22 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2
..


Patch Set 1:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2189/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdf0baa060efa35a173d00e15f0a348937f2e7f6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2

2017-11-21 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/2336/
 (11/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdf0baa060efa35a173d00e15f0a348937f2e7f6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2

2017-11-21 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/2356/ 
(10/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdf0baa060efa35a173d00e15f0a348937f2e7f6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2

2017-11-21 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2
..


Patch Set 1: -Integration-Tests

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4699/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdf0baa060efa35a173d00e15f0a348937f2e7f6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2

2017-11-21 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2
..


Patch Set 1: Integration-Tests-1

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4687/ 
: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdf0baa060efa35a173d00e15f0a348937f2e7f6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2

2017-11-21 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/2346/ 
(11/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdf0baa060efa35a173d00e15f0a348937f2e7f6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2

2017-11-21 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4687/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdf0baa060efa35a173d00e15f0a348937f2e7f6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2

2017-11-21 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/2538/ (9/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdf0baa060efa35a173d00e15f0a348937f2e7f6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2

2017-11-21 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/2325/
 (10/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdf0baa060efa35a173d00e15f0a348937f2e7f6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2

2017-11-21 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/7212/ (6/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdf0baa060efa35a173d00e15f0a348937f2e7f6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2

2017-11-21 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-rebalance-cancellation/860/
 (4/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdf0baa060efa35a173d00e15f0a348937f2e7f6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2

2017-11-21 Thread Taewoo Kim (Code Review)

Taewoo Kim has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/2175

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2
..

[ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Let the IntroduceJoinAccessMethod accept arbitrary
  forms of sub-tree for the probe-tree.

Change-Id: Ibdf0baa060efa35a173d00e15f0a348937f2e7f6
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceJoinAccessMethodRule.java
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/nonpure/keep-datetime-local.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/udfs/query-ASTERIXDB-1019.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/udfs/query-ASTERIXDB-1029.plan
M 
asterixdb/asterix-app/src/test/resources/optimizerts/results/udfs/query-ASTERIXDB-1029_2.plan
6 files changed, 197 insertions(+), 162 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/75/2175/1

diff --git 
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java
 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java
index bed5c7f..e0c6249 100644
--- 
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java
+++ 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java
@@ -22,9 +22,11 @@
 import java.util.Arrays;
 import java.util.Collections;
 import java.util.HashMap;
+import java.util.HashSet;
 import java.util.Iterator;
 import java.util.List;
 import java.util.Map;
+import java.util.Set;
 
 import org.apache.asterix.common.config.DatasetConfig.IndexType;
 import org.apache.asterix.dataflow.data.common.ExpressionTypeComputer;
@@ -62,6 +64,8 @@
 import 
org.apache.hyracks.algebricks.core.algebra.operators.logical.AbstractLogicalOperator;
 import 
org.apache.hyracks.algebricks.core.algebra.operators.logical.AssignOperator;
 import 
org.apache.hyracks.algebricks.core.algebra.operators.logical.UnnestOperator;
+import 
org.apache.hyracks.algebricks.core.algebra.operators.logical.visitors.VariableUtilities;
+import org.apache.hyracks.algebricks.core.algebra.typing.ITypingContext;
 import org.apache.hyracks.algebricks.core.rewriter.base.IAlgebraicRewriteRule;
 
 import com.google.common.collect.ImmutableSet;
@@ -111,6 +115,25 @@
 protected void fillSubTreeIndexExprs(OptimizableOperatorSubTree subTree,
 Map analyzedAMs, 
IOptimizationContext context)
 throws AlgebricksException {
+fillSubTreeIndexExprs(subTree, analyzedAMs, context, false);
+}
+
+/**
+ * Fills the information about the given optimizable function expressions 
using the subtree.
+ *
+ * @param subTree
+ * @param analyzedAMs
+ * @param context
+ * @param isArbitraryFormOfSubtree
+ *if the given subtree is in an arbitrary form that 
OptimizableSubTree class can't initialize, we try
+ *to fill the field type of each variable that is used in the 
optimizable function expressions.
+ *This way, an index-nested-loop-join transformation can be 
conducted properly since the transformation
+ *process skips an optimzable function expression if the field 
type of one of its variable is unknown.
+ * @throws AlgebricksException
+ */
+protected void fillSubTreeIndexExprs(OptimizableOperatorSubTree subTree,
+Map analyzedAMs, 
IOptimizationContext context,
+boolean isArbitraryFormOfSubtree) throws AlgebricksException {
 Iterator> amIt = 
analyzedAMs.entrySet().iterator();
 // Check applicability of indexes by access method type.
 while (amIt.hasNext()) {
@@ -118,7 +141,36 @@
 AccessMethodAnalysisContext amCtx = entry.getValue();
 // For the current access method type, map variables to applicable
 // indexes.
-fillAllIndexExprs(subTree, amCtx, context);
+if (!isArbitraryFormOfSubtree) {
+fillAllIndexExprs(subTree, amCtx, context);
+} else {
+fillVarFieldTypeForOptFuncExprs(subTree, amCtx, context);
+}
+}
+}
+
+/**
+ * Sets the subtree and the field type for the variables in the given 
function expression.
+ * This method is only used for an arbitrary form of

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2

2017-11-21 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1991/ 
(5/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdf0baa060efa35a173d00e15f0a348937f2e7f6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2

2017-11-21 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2
..


Patch Set 1:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1660/ 
(3/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdf0baa060efa35a173d00e15f0a348937f2e7f6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2

2017-11-21 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1672/ 
(7/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdf0baa060efa35a173d00e15f0a348937f2e7f6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2

2017-11-21 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5713/ (2/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdf0baa060efa35a173d00e15f0a348937f2e7f6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2

2017-11-21 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1681/
 (8/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdf0baa060efa35a173d00e15f0a348937f2e7f6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2

2017-11-21 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required - fix #2
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/2288/ (1/11)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2175
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdf0baa060efa35a173d00e15f0a348937f2e7f6
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required

2017-09-28 Thread Anon. E. Moose (Code Review)

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 4:

Analytics Compatibility Tests Failed Build 2650
: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2030
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required

2017-09-28 Thread Taewoo Kim (Code Review)

Taewoo Kim has submitted this change and it was merged.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
..


[ASTERIXDB-1984][COMP] probe-subtree init not required

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Let the IntroduceJoinAccessMethod accept arbitrary
  forms of sub-tree for the probe-tree.

Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2030
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Contrib: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: Dmitry Lychagin 
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceJoinAccessMethodRule.java
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries_sqlpp/btree-index-join/secondary-equi-join_04.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries_sqlpp/btree-index-join/secondary-equi-join_05.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries_sqlpp/btree-index-join/secondary-equi-join_06.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/secondary-equi-join_04.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/secondary-equi-join_05.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/secondary-equi-join_06.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results_parser_sqlpp/btree-index-join/secondary-equi-join_04.ast
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results_parser_sqlpp/btree-index-join/secondary-equi-join_05.ast
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results_parser_sqlpp/btree-index-join/secondary-equi-join_06.ast
10 files changed, 381 insertions(+), 12 deletions(-)

Approvals:
  Jenkins: Verified; No violations found; ; Verified
  Dmitry Lychagin: Looks good to me, approved



diff --git 
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceJoinAccessMethodRule.java
 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceJoinAccessMethodRule.java
index 7fc7902..1a7ccbd 100644
--- 
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceJoinAccessMethodRule.java
+++ 
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceJoinAccessMethodRule.java
@@ -320,25 +320,21 @@
 // This will be used to find an applicable index on the dataset.
 boolean checkLeftSubTreeMetadata = false;
 boolean checkRightSubTreeMetadata = false;
-if (continueCheck && (matchInLeftSubTree || matchInRightSubTree)) {
+if (continueCheck && matchInRightSubTree) {
 // Set dataset and type metadata.
 if (matchInLeftSubTree) {
 checkLeftSubTreeMetadata = 
leftSubTree.setDatasetAndTypeMetadata(metadataProvider);
 }
-if (matchInRightSubTree) {
-checkRightSubTreeMetadata = 
rightSubTree.setDatasetAndTypeMetadata(metadataProvider);
-}
+checkRightSubTreeMetadata = 
rightSubTree.setDatasetAndTypeMetadata(metadataProvider);
 }
 
-if (continueCheck && (checkLeftSubTreeMetadata || 
checkRightSubTreeMetadata)) {
+if (continueCheck && checkRightSubTreeMetadata) {
 // Map variables to the applicable indexes and find the field 
name and type.
 // Then find the applicable indexes for the variables used in 
the JOIN condition.
 if (checkLeftSubTreeMetadata) {
 fillSubTreeIndexExprs(leftSubTree, analyzedAMs, context);
 }
-if (checkRightSubTreeMetadata) {
-fillSubTreeIndexExprs(rightSubTree, analyzedAMs, context);
-}
+fillSubTreeIndexExprs(rightSubTree, analyzedAMs, context);
 
 // Prune the access methods based on the function expression 
and access methods.
 pruneIndexCandidates(analyzedAMs, context, typeEnvironment);
@@ -414,15 +410,18 @@
 }
 joinCond = (AbstractFunctionCallExpression) condExpr;
 
-boolean leftSubTreeInitialized = 
leftSubTree.initFromSubTree(joinOp.getInputs().get(0));
+// The result of the left subtree initialization does not need to be 
checked since only the field type
+// of the field that is being joined is important. However, if we do 
not initialize the left sub tree,
+// we lose a chance to get the field type of a field if there is an 
enforced index on it.
+

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required

2017-09-28 Thread Dmitry Lychagin (Code Review)

Dmitry Lychagin has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 4: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2030
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required

2017-09-28 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 4: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4085/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2030
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required

2017-09-28 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 4: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1834/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2030
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required

2017-09-28 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 4:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1834/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2030
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required

2017-09-28 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/1923/ (10/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2030
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required

2017-09-28 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 4:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4085/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2030
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required

2017-09-28 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1745/ 
(9/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2030
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required

2017-09-28 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6571/ (7/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2030
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required

2017-09-28 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1022/ 
(4/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2030
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required

2017-09-28 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1356/ 
(2/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2030
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required

2017-09-28 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 4:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1015/ 
(6/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2030
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required

2017-09-28 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1021/
 (1/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2030
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required

2017-09-28 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5077/ (3/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2030
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required

2017-09-28 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1633/ (8/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2030
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required

2017-09-28 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 4:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1694/
 (5/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2030
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required

2017-09-28 Thread Taewoo Kim (Code Review)

Hello Anon. E. Moose #1000171, Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2030

to look at the new patch set (#4).

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
..

[ASTERIXDB-1984][COMP] probe-subtree init not required

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Let the IntroduceJoinAccessMethod accept arbitrary
  forms of sub-tree for the probe-tree.

Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceJoinAccessMethodRule.java
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries_sqlpp/btree-index-join/secondary-equi-join_04.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries_sqlpp/btree-index-join/secondary-equi-join_05.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries_sqlpp/btree-index-join/secondary-equi-join_06.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/secondary-equi-join_04.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/secondary-equi-join_05.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/secondary-equi-join_06.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results_parser_sqlpp/btree-index-join/secondary-equi-join_04.ast
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results_parser_sqlpp/btree-index-join/secondary-equi-join_05.ast
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results_parser_sqlpp/btree-index-join/secondary-equi-join_06.ast
10 files changed, 381 insertions(+), 12 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/30/2030/4
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2030
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required

2017-09-28 Thread Taewoo Kim (Code Review)

Taewoo Kim has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 3:

@Dmitry: OK. Let's do that. Thanks!

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2030
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required

2017-09-28 Thread Dmitry Lychagin (Code Review)

Dmitry Lychagin has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 3:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/2030/3/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/InvertedIndexAccessMethod.java
File 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/InvertedIndexAccessMethod.java:

Line 606: Pair RootOpAndPKVars =
It looks like there're no testcases in this review for changes in 
InvertedIndexAccessMethod. Can we move InvertedIndexAccessMethod changes into a 
separate review and add new tests for them there? 
The remaining changes (in IntroduceJoinAccessMethodRule) look good and can be 
merged.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2030
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Yingyi Bu 
Gerrit-HasComments: Yes

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required

2017-09-27 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 3: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4072/ 
: SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2030
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required

2017-09-27 Thread Anon. E. Moose (Code Review)

Anon. E. Moose #1000171 has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 3: Contrib-1

Analytics Compatibility Tests Failed Build 2641
: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2030
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required

2017-09-27 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 3: Contrib+1

BAD Compatibility Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1825/ : SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2030
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required

2017-09-27 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 3:

BAD Compatibility Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/1825/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2030
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required

2017-09-27 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/1911/ (10/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2030
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required

2017-09-27 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 3:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4072/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2030
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required

2017-09-27 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1732/ 
(9/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2030
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required

2017-09-27 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1680/
 (8/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2030
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required

2017-09-27 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5062/ (2/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2030
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required

2017-09-27 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6556/ (3/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2030
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required

2017-09-27 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1007/ 
(4/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2030
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required

2017-09-27 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 3:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/1000/ 
(5/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2030
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required

2017-09-27 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1618/ (1/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2030
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required

2017-09-27 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1341/ 
(6/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2030
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required

2017-09-27 Thread Taewoo Kim (Code Review)

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2030

to look at the new patch set (#3).

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
..

[ASTERIXDB-1984][COMP] probe-subtree init not required

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Let the IntroduceJoinAccessMethod accept arbitrary
  forms of sub-tree for the probe-tree.
- The surrogate-join in the InvertedIndexAccessMethod now
  does not need a fixed form of sub-tree.

Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceJoinAccessMethodRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/InvertedIndexAccessMethod.java
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries_sqlpp/btree-index-join/secondary-equi-join_04.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries_sqlpp/btree-index-join/secondary-equi-join_05.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries_sqlpp/btree-index-join/secondary-equi-join_06.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/secondary-equi-join_04.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/secondary-equi-join_05.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/secondary-equi-join_06.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results_parser_sqlpp/btree-index-join/secondary-equi-join_04.ast
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results_parser_sqlpp/btree-index-join/secondary-equi-join_05.ast
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results_parser_sqlpp/btree-index-join/secondary-equi-join_06.ast
11 files changed, 421 insertions(+), 40 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/30/2030/3
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2030
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required

2017-09-27 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 3:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1006/
 (7/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2030
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required

2017-09-27 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 2: Integration-Tests-1

Integration Tests Failed

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4066/ 
: UNSTABLE

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2030
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required

2017-09-27 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 2:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4066/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2030
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required

2017-09-27 Thread Taewoo Kim (Code Review)

Hello Jenkins,

I'd like you to reexamine a change.  Please visit

https://asterix-gerrit.ics.uci.edu/2030

to look at the new patch set (#2).

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
..

[ASTERIXDB-1984][COMP] probe-subtree init not required

- user model changes: no
- storage format changes: no
- interface changes: no

Details:
- Let the IntroduceJoinAccessMethod accept arbitrary
  forms of sub-tree for the probe-tree.
- The surrogate-join in the InvertedIndexAccessMethod now
  does not need a fixed form of sub-tree.

Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
---
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/IntroduceJoinAccessMethodRule.java
M 
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/InvertedIndexAccessMethod.java
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries_sqlpp/btree-index-join/secondary-equi-join_04.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries_sqlpp/btree-index-join/secondary-equi-join_05.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/queries_sqlpp/btree-index-join/secondary-equi-join_06.sqlpp
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/secondary-equi-join_04.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/secondary-equi-join_05.plan
A 
asterixdb/asterix-app/src/test/resources/optimizerts/results/btree-index-join/secondary-equi-join_06.plan
8 files changed, 269 insertions(+), 40 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/30/2030/2
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2030
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required

2017-09-27 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1001/ 
(2/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2030
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required

2017-09-27 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/1000/
 (7/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2030
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required

2017-09-27 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/1905/ (10/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2030
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required

2017-09-27 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/1726/ 
(6/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2030
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required

2017-09-27 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/6550/ (4/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2030
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required

2017-09-27 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1674/
 (3/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2030
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required

2017-09-27 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 2:

Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/994/ (1/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2030
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required

2017-09-27 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1335/ 
(5/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2030
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required

2017-09-27 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/5056/ (9/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2030
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required

2017-09-27 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/1612/ (8/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2030
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required

2017-09-27 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 1:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/4065/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2030
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required

2017-09-27 Thread Taewoo Kim (Code Review)

Taewoo Kim has abandoned this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
..


Abandoned

Submitted a new patch set.

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1880
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a25
Gerrit-PatchSet: 18
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Taewoo Kim 
Gerrit-Reviewer: Yingyi Bu

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required

2017-09-27 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/1673/
 (7/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2030
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required

2017-09-27 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/1334/ 
(2/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2030
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: [ASTERIXDB-1984][COMP] probe-subtree init not required

2017-09-27 Thread Jenkins (Code Review)

Jenkins has posted comments on this change.

Change subject: [ASTERIXDB-1984][COMP] probe-subtree init not required
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/1000/ 
(5/10)

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2030
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib353c85bf627d8dd65dba0ea307dee428edb4a26
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

1 2 3 >

1 - 100 of 215 matches

Mail list logo