Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Taewoo Kim has submitted this change and it was merged.
Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield
type
..
[ASTERIXDB-2296][COMP] proper handling of an optional subfield type
- user-model changes: no
- storage format changes: no
- interface changes: no
Details:
- Handle an optional subfield type properly in
AbstractIntroduceAccessMethodRule.getFieldNameFromSubTree()
Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114
Reviewed-on: https://asterix-gerrit.ics.uci.edu/2419
Sonar-Qube: Jenkins
Integration-Tests: Jenkins
Reviewed-by: Dmitry Lychagin
Tested-by: Jenkins
Contrib: Jenkins
---
M
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java
A
asterixdb/asterix-app/src/test/resources/optimizerts/queries/filter/inverted-btree-search-return-optional-field.sqlpp
A
asterixdb/asterix-app/src/test/resources/optimizerts/results/filter/inverted-btree-search-return-optional-field.plan
3 files changed, 146 insertions(+), 3 deletions(-)
Approvals:
Anon. E. Moose #1000171:
Jenkins: Verified; No violations found; ; Verified
Dmitry Lychagin: Looks good to me, approved
diff --git
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java
index f4178d7..4f9b4df 100644
---
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java
+++
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java
@@ -30,6 +30,8 @@
import org.apache.asterix.common.config.DatasetConfig.DatasetType;
import org.apache.asterix.common.config.DatasetConfig.IndexType;
+import org.apache.asterix.common.exceptions.CompilationException;
+import org.apache.asterix.common.exceptions.ErrorCode;
import org.apache.asterix.dataflow.data.common.ExpressionTypeComputer;
import org.apache.asterix.metadata.declared.MetadataProvider;
import org.apache.asterix.metadata.entities.Index;
@@ -38,6 +40,7 @@
import org.apache.asterix.om.base.AString;
import org.apache.asterix.om.constants.AsterixConstantValue;
import org.apache.asterix.om.functions.BuiltinFunctions;
+import org.apache.asterix.om.typecomputer.impl.TypeComputeUtils;
import org.apache.asterix.om.types.ARecordType;
import org.apache.asterix.om.types.ATypeTag;
import org.apache.asterix.om.types.AbstractCollectionType;
@@ -872,9 +875,15 @@
}
if (!isByName) {
-fieldName = sourceVar.equals(metaVar)
-? ((ARecordType)
metaType.getSubFieldType(parentFieldNames)).getFieldNames()[fieldIndex]
-: ((ARecordType)
recordType.getSubFieldType(parentFieldNames)).getFieldNames()[fieldIndex];
+IAType subFieldType = sourceVar.equals(metaVar) ?
metaType.getSubFieldType(parentFieldNames)
+: recordType.getSubFieldType(parentFieldNames);
+// Sub-field type can be AUnionType in case if it's
optional. Thus, needs to get the actual type.
+subFieldType =
TypeComputeUtils.getActualType(subFieldType);
+if (subFieldType.getTypeTag() != ATypeTag.OBJECT) {
+throw
CompilationException.create(ErrorCode.TYPE_CONVERT, subFieldType,
+ARecordType.class.getName());
+}
+fieldName = ((ARecordType)
subFieldType).getFieldNames()[fieldIndex];
}
if (optFuncExpr != null) {
optFuncExpr.setSourceVar(funcVarIndex, ((AssignOperator)
op).getVariables().get(assignVarIndex));
diff --git
a/asterixdb/asterix-app/src/test/resources/optimizerts/queries/filter/inverted-btree-search-return-optional-field.sqlpp
b/asterixdb/asterix-app/src/test/resources/optimizerts/queries/filter/inverted-btree-search-return-optional-field.sqlpp
new file mode 100644
index 000..3221cc3
--- /dev/null
+++
b/asterixdb/asterix-app/src/test/resources/optimizerts/queries/filter/inverted-btree-search-return-optional-field.sqlpp
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed unde
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield type .. Patch Set 3: Contrib+1 BAD Compatibility Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2766/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2419 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield type .. Patch Set 3: BAD Compatibility Tests Started https://asterix-jenkins.ics.uci.edu/job/asterixbad-compat/2766/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2419 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Dmitry Lychagin has posted comments on this change. Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield type .. Patch Set 3: Code-Review+2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2419 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield type .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3566/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2419 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield type .. Patch Set 3: Integration-Tests+1 Integration Tests Successful https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5743/ : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2419 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield type .. Patch Set 3: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/HN278u : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2419 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield type .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3326/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2419 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield type .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3302/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2419 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield type .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3563/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2419 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield type .. Patch Set 3: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5743/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2419 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield type .. Patch Set 3: Analytics Compatibility Compilation Successful https://goo.gl/a5yZDh : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2419 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield type .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/2743/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2419 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield type .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3049/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2419 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield type .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/839/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2419 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield type .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8289/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2419 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield type .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/6782/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2419 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield type .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3363/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2419 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2419 to look at the new patch set (#3). Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield type .. [ASTERIXDB-2296][COMP] proper handling of an optional subfield type - user-model changes: no - storage format changes: no - interface changes: no Details: - Handle an optional subfield type properly in AbstractIntroduceAccessMethodRule.getFieldNameFromSubTree() Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114 --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java A asterixdb/asterix-app/src/test/resources/optimizerts/queries/filter/inverted-btree-search-return-optional-field.sqlpp A asterixdb/asterix-app/src/test/resources/optimizerts/results/filter/inverted-btree-search-return-optional-field.plan 3 files changed, 146 insertions(+), 3 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/19/2419/3 -- To view, visit https://asterix-gerrit.ics.uci.edu/2419 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield type .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/2816/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2419 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield type .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/2827/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2419 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield type .. Patch Set 3: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/2790/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2419 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield type .. Patch Set 2: Integration-Tests-1 Integration Tests Failed https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5741/ : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2419 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield type .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3324/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2419 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield type .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3300/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2419 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield type .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3561/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2419 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield type .. Patch Set 2: Contrib+1 Analytics Compatibility Tests Successful https://goo.gl/TKBVs4 : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2419 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield type .. Patch Set 2: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5741/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2419 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield type .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/2825/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2419 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield type .. Patch Set 2: Analytics Compatibility Compilation Successful https://goo.gl/Bqb67R : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2419 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-Reviewer: Taewoo Kim Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield type .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/2814/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2419 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield type .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/2741/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2419 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield type .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8287/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2419 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield type .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3047/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2419 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Hello Anon. E. Moose #1000171, Jenkins, I'd like you to reexamine a change. Please visit https://asterix-gerrit.ics.uci.edu/2419 to look at the new patch set (#2). Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield type .. [ASTERIXDB-2296][COMP] proper handling of an optional subfield type - user-model changes: no - storage format changes: no - interface changes: no Details: - Handle an optional subfield type properly in AbstractIntroduceAccessMethodRule.getFieldNameFromSubTree() Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114 --- M asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java A asterixdb/asterix-app/src/test/resources/optimizerts/queries/filter/inverted-btree-search-return-optional-field.sqlpp A asterixdb/asterix-app/src/test/resources/optimizerts/results/filter/inverted-btree-search-return-optional-field.plan 3 files changed, 146 insertions(+), 3 deletions(-) git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb refs/changes/19/2419/2 -- To view, visit https://asterix-gerrit.ics.uci.edu/2419 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield type .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/6780/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2419 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield type .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/2788/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2419 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield type .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3361/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2419 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Taewoo Kim has posted comments on this change.
Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield
type
..
Patch Set 1:
(3 comments)
Thanks!
https://asterix-gerrit.ics.uci.edu/#/c/2419/1/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java
File
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java:
Line 881: if (subFieldType instanceof AUnionType) {
> There's a helper method for extracting actual type from a union: TypeComput
Done
Line 884: if (!(subFieldType instanceof ARecordType)) {
> Can we do getTypeTag() != OBJECT here instead of instanceof?
Done
Line 888: fieldName = sourceVar.equals(metaVar) ?
((ARecordType) subFieldType).getFieldNames()[fieldIndex]
> why conditional (?) expression here? both branches seem to be the same.
Done
--
To view, visit https://asterix-gerrit.ics.uci.edu/2419
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin
Gerrit-Reviewer: Jenkins
Gerrit-Reviewer: Taewoo Kim
Gerrit-HasComments: Yes
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield type .. Patch Set 2: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/837/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2419 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield type .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-asterix-app/3322/ (12/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2419 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield type .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-verify-no-installer-app/3298/ (11/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2419 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield type .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app/3559/ (10/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2419 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield type .. Patch Set 1: Contrib-2 Analytics Compatibility Tests Failed https://goo.gl/mPn7pA : UNSTABLE -- To view, visit https://asterix-gerrit.ics.uci.edu/2419 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield type .. Patch Set 1: Integration Tests Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/5739/ -- To view, visit https://asterix-gerrit.ics.uci.edu/2419 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Dmitry Lychagin has posted comments on this change.
Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield
type
..
Patch Set 1:
(3 comments)
https://asterix-gerrit.ics.uci.edu/#/c/2419/1/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java
File
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java:
Line 881: if (subFieldType instanceof AUnionType) {
There's a helper method for extracting actual type from a union:
TypeComputeUtils.getActualType(). Can you use that?
Line 884: if (!(subFieldType instanceof ARecordType)) {
Can we do getTypeTag() != OBJECT here instead of instanceof?
Line 888: fieldName = sourceVar.equals(metaVar) ?
((ARecordType) subFieldType).getFieldNames()[fieldIndex]
why conditional (?) expression here? both branches seem to be the same.
--
To view, visit https://asterix-gerrit.ics.uci.edu/2419
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin
Gerrit-Reviewer: Jenkins
Gerrit-HasComments: Yes
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield type .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-cancellation-test/2812/ (5/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2419 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield type .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/hyracks-gerrit/2739/ (4/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2419 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield type .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-asterix-app-sql-execution/2823/ (9/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2419 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield type .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-sonar/6778/ (3/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2419 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Anon. E. Moose #1000171 has posted comments on this change. Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield type .. Patch Set 1: Analytics Compatibility Compilation Successful https://goo.gl/JJX9PU : SUCCESS -- To view, visit https://asterix-gerrit.ics.uci.edu/2419 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield type .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-ensure-ancestor/835/ (8/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2419 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Taewoo Kim has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/2419
Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield
type
..
[ASTERIXDB-2296][COMP] proper handling of an optional subfield type
- user-model changes: no
- storage format changes: no
- interface changes: no
Details:
- Handle an optional subfield type properly in
AbstractIntroduceAccessMethodRule.getFieldNameFromSubTree()
Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114
---
M
asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java
A
asterixdb/asterix-app/src/test/resources/optimizerts/queries/filter/inverted-btree-search-return-optional-field.sqlpp
A
asterixdb/asterix-app/src/test/resources/optimizerts/results/filter/inverted-btree-search-return-optional-field.plan
3 files changed, 149 insertions(+), 3 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/19/2419/1
diff --git
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java
index f4178d7..41593dc 100644
---
a/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java
+++
b/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java
@@ -30,6 +30,8 @@
import org.apache.asterix.common.config.DatasetConfig.DatasetType;
import org.apache.asterix.common.config.DatasetConfig.IndexType;
+import org.apache.asterix.common.exceptions.CompilationException;
+import org.apache.asterix.common.exceptions.ErrorCode;
import org.apache.asterix.dataflow.data.common.ExpressionTypeComputer;
import org.apache.asterix.metadata.declared.MetadataProvider;
import org.apache.asterix.metadata.entities.Index;
@@ -40,6 +42,7 @@
import org.apache.asterix.om.functions.BuiltinFunctions;
import org.apache.asterix.om.types.ARecordType;
import org.apache.asterix.om.types.ATypeTag;
+import org.apache.asterix.om.types.AUnionType;
import org.apache.asterix.om.types.AbstractCollectionType;
import org.apache.asterix.om.types.BuiltinType;
import org.apache.asterix.om.types.IAType;
@@ -872,9 +875,18 @@
}
if (!isByName) {
-fieldName = sourceVar.equals(metaVar)
-? ((ARecordType)
metaType.getSubFieldType(parentFieldNames)).getFieldNames()[fieldIndex]
-: ((ARecordType)
recordType.getSubFieldType(parentFieldNames)).getFieldNames()[fieldIndex];
+// Sub-field type can be AUnionType in case if it's
optional.
+IAType subFieldType = sourceVar.equals(metaVar) ?
metaType.getSubFieldType(parentFieldNames)
+: recordType.getSubFieldType(parentFieldNames);
+if (subFieldType instanceof AUnionType) {
+subFieldType = ((AUnionType)
subFieldType).getActualType();
+}
+if (!(subFieldType instanceof ARecordType)) {
+throw
CompilationException.create(ErrorCode.TYPE_CONVERT, AUnionType.class.getName(),
+ARecordType.class.getName());
+}
+fieldName = sourceVar.equals(metaVar) ? ((ARecordType)
subFieldType).getFieldNames()[fieldIndex]
+: ((ARecordType)
subFieldType).getFieldNames()[fieldIndex];
}
if (optFuncExpr != null) {
optFuncExpr.setSourceVar(funcVarIndex, ((AssignOperator)
op).getVariables().get(assignVarIndex));
diff --git
a/asterixdb/asterix-app/src/test/resources/optimizerts/queries/filter/inverted-btree-search-return-optional-field.sqlpp
b/asterixdb/asterix-app/src/test/resources/optimizerts/queries/filter/inverted-btree-search-return-optional-field.sqlpp
new file mode 100644
index 000..3221cc3
--- /dev/null
+++
b/asterixdb/asterix-app/src/test/resources/optimizerts/queries/filter/inverted-btree-search-return-optional-field.sqlpp
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield type .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-format/2786/ (1/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2419 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield type .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-source-assemblies/3045/ (7/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2419 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield type .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-verify-storage/3359/ (2/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2419 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
Change in asterixdb[master]: [ASTERIXDB-2296][COMP] proper handling of an optional subfie...
Jenkins has posted comments on this change. Change subject: [ASTERIXDB-2296][COMP] proper handling of an optional subfield type .. Patch Set 1: Build Started https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/8285/ (6/12) -- To view, visit https://asterix-gerrit.ics.uci.edu/2419 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia80b6dbf549b77295f310b7c6f3a3f3f5a323114 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim Gerrit-Reviewer: Jenkins Gerrit-HasComments: No
