Change in asterixdb[master]: Avoid NPE in AsterixHyracksIntegrationUtil.deinit

2016-08-24 Thread Michael Blow (Code Review) 
Michael Blow has submitted this change and it was merged.

Change subject: Avoid NPE in AsterixHyracksIntegrationUtil.deinit
..


Avoid NPE in AsterixHyracksIntegrationUtil.deinit

Change-Id: I4af385918becc2dfbc40462c9505135d91ea859f
Reviewed-on: https://asterix-gerrit.ics.uci.edu/1107
Sonar-Qube: Jenkins 
Tested-by: Jenkins 
Integration-Tests: Jenkins 
Reviewed-by: Michael Blow 
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Michael Blow: Looks good to me, approved
  Jenkins: Verified; No violations found; Verified



diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
index b1bf418..03ed3c4 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
@@ -56,6 +56,7 @@
 private AsterixPropertiesAccessor propertiesAccessor;
 
 public void init(boolean deleteOldInstanceData) throws Exception {
+ncs = new NodeControllerService[0]; // ensure that ncs is not null
 propertiesAccessor = new AsterixPropertiesAccessor();
 if (deleteOldInstanceData) {
 deleteTransactionLogs();

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1107
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4af385918becc2dfbc40462c9505135d91ea859f
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow

Change in asterixdb[master]: Avoid NPE in AsterixHyracksIntegrationUtil.deinit

2016-08-24 Thread Michael Blow (Code Review) 
Michael Blow has posted comments on this change.

Change subject: Avoid NPE in AsterixHyracksIntegrationUtil.deinit
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1107
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4af385918becc2dfbc40462c9505135d91ea859f
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-HasComments: No

Change in asterixdb[master]: Avoid NPE in AsterixHyracksIntegrationUtil.deinit

2016-08-24 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: Avoid NPE in AsterixHyracksIntegrationUtil.deinit
..


Patch Set 2:

Integration Tests Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/433/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1107
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4af385918becc2dfbc40462c9505135d91ea859f
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-HasComments: No

Change in asterixdb[master]: Avoid NPE in AsterixHyracksIntegrationUtil.deinit

2016-08-24 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: Avoid NPE in AsterixHyracksIntegrationUtil.deinit
..


Patch Set 2:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2360/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1107
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4af385918becc2dfbc40462c9505135d91ea859f
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-HasComments: No

Change in asterixdb[master]: Avoid NPE in AsterixHyracksIntegrationUtil.deinit

2016-08-24 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: Avoid NPE in AsterixHyracksIntegrationUtil.deinit
..


Patch Set 1: Integration-Tests+1

Integration Tests Successful

https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-integration-tests/424/ : 
SUCCESS

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1107
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4af385918becc2dfbc40462c9505135d91ea859f
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-Reviewer: Michael Blow 
Gerrit-HasComments: No

Change in asterixdb[master]: Avoid NPE in AsterixHyracksIntegrationUtil.deinit

2016-08-23 Thread Jenkins (Code Review) 
Jenkins has posted comments on this change.

Change subject: Avoid NPE in AsterixHyracksIntegrationUtil.deinit
..


Patch Set 1:

Build Started 
https://asterix-jenkins.ics.uci.edu/job/asterix-gerrit-notopic/2346/

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1107
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4af385918becc2dfbc40462c9505135d91ea859f
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann 
Gerrit-Reviewer: Jenkins 
Gerrit-HasComments: No

Change in asterixdb[master]: Avoid NPE in AsterixHyracksIntegrationUtil.deinit

2016-08-23 Thread Till Westmann (Code Review) 
Till Westmann has uploaded a new change for review.

  https://asterix-gerrit.ics.uci.edu/1107

Change subject: Avoid NPE in AsterixHyracksIntegrationUtil.deinit
..

Avoid NPE in AsterixHyracksIntegrationUtil.deinit

Change-Id: I4af385918becc2dfbc40462c9505135d91ea859f
---
M 
asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb 
refs/changes/07/1107/1

diff --git 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
index b1bf418..03ed3c4 100644
--- 
a/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
+++ 
b/asterixdb/asterix-app/src/main/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java
@@ -56,6 +56,7 @@
 private AsterixPropertiesAccessor propertiesAccessor;
 
 public void init(boolean deleteOldInstanceData) throws Exception {
+ncs = new NodeControllerService[0]; // ensure that ncs is not null
 propertiesAccessor = new AsterixPropertiesAccessor();
 if (deleteOldInstanceData) {
 deleteTransactionLogs();

-- 
To view, visit https://asterix-gerrit.ics.uci.edu/1107
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4af385918becc2dfbc40462c9505135d91ea859f
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Till Westmann